On Sat, Apr 22, 2023 at 8:39 AM Shao-Chien Chiang wrote:
>
> Hi,
>
> I found a problem about cache.
>
> If there are several devices operating the same backend device, the
> cache might be inconsistent.
>
Hi Shao-Chien,
What do you mean by "several devices operating the same backend
device". The
On 4/20/23 09:06, Song Gao wrote:
This patch includes:
- VMAX[I].{B/H/W/D}[U];
- VMIN[I].{B/H/W/D}[U].
Signed-off-by: Song Gao
---
target/loongarch/disas.c| 33
target/loongarch/helper.h | 18 ++
target/loongarch/insn_trans/trans_lsx.c.inc | 200 +
On 4/20/23 09:06, Song Gao wrote:
@@ -972,6 +972,33 @@ void tcg_gen_mulsu2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32
arg1, TCGv_i32 arg2)
}
}
+void tcg_gen_mulus2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 arg1, TCGv_i32 arg2)
+{
+if (TCG_TARGET_REG_BITS == 32) {
+TCGv_i32 t0 =
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Saturday, April 22, 2023 1:14 AM
> To: qemu-devel@nongnu.org
> Cc: qemu-bl...@nongnu.org; Paolo Bonzini ;
> Thomas Huth ; John Snow ; Li
> Zhijian ; Juan Quintela ;
> Stefan Hajnoczi ; Zhang, Chen
> ; Laurent Vivier
> Subject: [PA
> -Original Message-
> From: Thomas Huth
> Sent: Monday, April 24, 2023 2:56 PM
> To: quint...@redhat.com; Zhang, Chen
> Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org;
> qemu-bl...@nongnu.org; Paolo Bonzini ; John
> Snow ; Li Zhijian ; Stefan
> Hajnoczi ; Laurent Vivier
> Subject: Re:
Am 23/04/2023 um 13:02 schrieb wanglian...@126.com:
> From: Wang Liang
>
> We need to get the aio_context before calling the blk_is_available.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615
> Signed-off-by: Wang Liang
>
Reviewed-by: Emanuele Giuseppe Esposito
Am 23. April 2023 17:46:18 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 22/4/23 17:07, Bernhard Beschow wrote:
>> There is redundant code in cmd646 and via which can be extracted into the
>> base
>> class. In case of piix and sii3112 this is currently unneccessary but
>> shouldn't
>> interfere
Am 22. April 2023 19:21:12 UTC schrieb BALATON Zoltan :
>On Sat, 22 Apr 2023, Bernhard Beschow wrote:
>> Am 22. April 2023 17:23:56 UTC schrieb BALATON Zoltan :
>>> On Sat, 22 Apr 2023, Bernhard Beschow wrote:
The VIA south bridge allows the legacy IDE interrupts to be routed to four
d
You've not fully addressed the feedback on v3. The first line
of the commit message needs to be a short sumary, not the
Signed-off-by, which should be at the end of the commit
message
On Fri, Apr 21, 2023 at 06:53:41PM +0200, Karim Taha wrote:
> From: Warner Losh
>
> Intialize guest_base in bsd
Am 24/04/2023 um 10:15 schrieb Emanuele Giuseppe Esposito:
>
>
> Am 23/04/2023 um 13:02 schrieb wanglian...@126.com:
>> From: Wang Liang
>>
>> We need to get the aio_context before calling the blk_is_available.
>>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615
>> Signed-off-b
Kautuk Consul writes:
> Commit c0c8687ef0fd990db8db1655a8a6c5a5e35dd4bb disabled the
> boot_linux.py test-case due to which the code coverage for ppc
> decreased by around 2%. As per the discussion on
> https://lore.kernel.org/qemu-devel/87sfdpqcy4@linaro.org/ it
> was mentioned that the ba
On Mon, 24 Apr 2023 at 07:24, Yong Li wrote:
>
> The virt machine can have two UARTs and the second UART
> can be used when host secure-mode support is enabled.
Do you mean "host" here, or "guest" ?
> Signed-off-by: Yong Li
> ---
> hw/riscv/virt.c | 4
> include/hw/riscv/virt.h |
On Friday, April 21, 2023 3:53:27 PM CEST Peter Foley wrote:
> It's only required for the proxy helper.
>
> Signed-off-by: Peter Foley
> ---
> meson.build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index c44d05a13f..1d4888b1c0 1006
On 2023-04-24 09:53:23, Alex Bennée wrote:
>
> Kautuk Consul writes:
>
> > Commit c0c8687ef0fd990db8db1655a8a6c5a5e35dd4bb disabled the
> > boot_linux.py test-case due to which the code coverage for ppc
> > decreased by around 2%. As per the discussion on
> > https://lore.kernel.org/qemu-devel/8
This series introduces support for KVM AIA in the RISC-V architecture. The
implementation is refered to Anup's KVM AIA implementation in kvmtool
(https://github.com/avpatel/kvmtool.git). To test these patches, a Linux kernel
with KVM AIA support is required, which can be found in the qemu_kvm_aia b
- Do not set the mmio operations of APLIC and IMSIC when using KVM AIA
- Send interrupt signal to KVM AIA via KVM_IRQ_LINE API
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
hw/intc/riscv_aplic.c | 19 +++
hw/intc/riscv_imsic.c | 16 +++-
2 files changed, 26
implement a function to create an KVM AIA chip
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
target/riscv/kvm.c | 83
target/riscv/kvm_riscv.h | 3 ++
2 files changed, 86 insertions(+)
diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
Select KVM AIA when the host kernel has in-kernel AIA chip support.
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
hw/riscv/virt.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 18aede7b23..908b304991 100644
--- a/hw/riscv/virt.c
Sync-up Linux header to get latest KVM RISC-V headers having AIA support.
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
linux-headers/linux/kvm.h | 2 ++
target/riscv/kvm_riscv.h | 33 +
2 files changed, 35 insertions(+)
diff --git a/linux-headers/lin
Vladimir Sementsov-Ogievskiy writes:
> On 20.04.23 18:57, Alex Bennée wrote:
>> There use makes our code safer so we should mention them.
>> Signed-off-by: Alex Bennée
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy
>
>
>> ---
>> docs/devel/style.rst | 36
We check the in-kernel irqchip support when using KVM acceleration.
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
target/riscv/kvm.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
index 30f21453d6..6aad25bbc3 10
Remove M mode AIA devices when using KVM acceleration
Signed-off-by: Yong-Xuan Wang
Reviewed-by: Jim Shu
---
hw/riscv/virt.c | 204 +---
1 file changed, 108 insertions(+), 96 deletions(-)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index a5bc7353b
Exclude out-of-image clusters from allocated and fragmented clusters
calculation.
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 8588c3d775..f389a74466 100644
--- a/block/p
Don't let high_off be more than the file size even if we don't fix the
image.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/
Fix image inflation when offset in BAT is out of image.
Replace whole BAT syncing by flushing only dirty blocks.
Move all the checks outside the main check function in
separate functions
Use WITH_QEMU_LOCK_GUARD for simplier code.
Fix incorrect condition in out-of-image check.
v11:
1: Use bdrv
This helper will be reused in next patches during parallels_co_check
rework to simplify its code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 90 ---
1 file changed, 53 insertions(+)
BAT is written in the context of conventional operations over the image
inside bdrv_co_flush() when it calls parallels_co_flush_to_os() callback.
Thus we should not modify BAT array directly, but call
parallels_set_bat_entry() helper and bdrv_co_flush() further on. After
that there is no need to ma
Karim Taha writes:
> I made a fork on gitlab and pushed a branch at
> https://gitlab.com/Kariiem/qemu/-/tree/gsoc23-task3/ .
OK so I can see the original commits are not following the correct form
so this wasn't introduced by the tool send the emails. As Daniel
mentioned previously the format
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
ind
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 31 +
Set data_end to the end of the last cluster inside the image. In such a
way we can be sure that corrupted offsets in the BAT can't affect on the
image size. If there are no allocated clusters set image_end_offset by
data_end.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 52 +
Replace the way we use mutex in parallels_co_check() for simplier
and less error prone code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/block/parallels.
We will add more and more checks so we need a better code structure in
parallels_co_check. Let each check performs in a separate loop in a
separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 79 ++-
1 f
data_end field in BDRVParallelsState is set to the biggest offset present
in BAT. If this offset is outside of the image, any further write will
create the cluster at this offset and/or the image will be truncated to
this offset on close. This is definitely not correct.
Raise an error in parallels
From: Kautuk Consul
Avocado version 101.0 has a fix to re-compute the checksum
of an asset file if the algorithm used in the *-CHECKSUM
file isn't the same as the one being passed to it by the
avocado user (i.e. the avocado_qemu python module).
In the earlier avocado versions this fix wasn't ther
From: Philippe Mathieu-Daudé
This change adds set of boot tests on SBSA-ref machine:
1. boot firmware up to the EDK2 banner
2. boot Alpine Linux
Prebuilt flash volumes are included, built using upstream documentation.
To unify tests for AArch64/virt and AArch64/sbsa-ref we boot
the same Alpine
We have a more complete document on QOM but we should at least mention
the style requirements in the style guide.
Signed-off-by: Alex Bennée
Cc: Mark Cave-Ayland
Reviewed-by: Juan Quintela
Message-Id: <20230420155723.1711048-9-alex.ben...@linaro.org>
---
vppr:
- use Mark's formulation, brief
From: Thomas Huth
test_arm_ast2500_evb_sdk and test_arm_ast2600_evb_sdk are currently
failing. The problem is that they are trying to look for the login
prompt that does not have a newline at the end - but the logic in
_console_interaction() only handles full lines. It used to work by
accident in
This is my pre-PR tree for the current state of testing/next and the
various documentation patches that haven't been picked up by others.
I'll look to send the PR later in the week.
The following patches still need review:
tests/tcg: limit the scope of the plugin tests (1 acks, 1 sobs, 0 tbs)
From: Thomas Huth
FreeBSD 13.0 has been released in April 2021:
https://www.freebsd.org/releases/13.0R/announce/
According to QEMU's support policy, we stop supporting the previous
major release two years after the the new major release has been
published. So we can stop testing FreeBSD 12 in
From: Thomas Huth
We're currently facing the problem that the device-crash-test script
runs twice as long in the CI when a runner supports KVM - which sometimes
results in a timeout of the CI job. To get a more deterministic runtime
here, add an option to the script that allows to run it with TCG
From: Yohei Kojima
This commit adds the following description:
1. `memdev` option is recommended over `mem` option (see [1,2])
2. users must specify memory for all NUMA nodes (see [2])
This commit also separates descriptions for `mem` and `memdev` into two
paragraphs. The old doc describes legac
From: Kautuk Consul
Commit c0c8687ef0fd990db8db1655a8a6c5a5e35dd4bb disabled the
boot_linux.py test-case due to which the code coverage for ppc
decreased by around 2%. As per the discussion on
https://lore.kernel.org/qemu-devel/87sfdpqcy4@linaro.org/ it
was mentioned that the baseline test fo
From: Kautuk Consul
Factor out the code that finds the qemu-img binary in the
QemuSystemTest class and create a new get_qemu_img() function
with it. This function will get called also from the new code
in tuxrun_baselines.py avocado test-case.
Signed-off-by: Kautuk Consul
Reviewed-by: Harsh Pra
We are a bit premature in recommending -blockdev/-device as the best
way to configure block devices. It seems there are times the more
human friendly -drive still makes sense especially when -snapshot is
involved.
Improve the language to hopefully make things clearer.
Suggested-by: Michael Tokare
From: Thomas Huth
After "make check-venv" had been added to these jobs, they started
to re-run "configure" each time since our logic in the makefile
thinks that some files are out of date here. Avoid it with the same
trick that we are using in buildtest-template.yml already by disabling
the up-to
A possessive its needs no ' whereas the contraction of it is does.
Signed-off-by: Alex Bennée
Reviewed-by: Juan Quintela
Reviewed-by: Thomas Huth
Message-Id: <20230420155723.1711048-7-alex.ben...@linaro.org>
---
docs/system/guest-loader.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deleti
The tuxboot images now have a stable snapshot URL so we can enable the
checksums and remove the avocado warnings. We will have to update as
old snapshots retire but that won't be too frequent.
Signed-off-by: Alex Bennée
---
tests/avocado/tuxrun_baselines.py | 170 +-
From: Thomas Huth
tests/avocado/machine_aspeed.py should belong to the ASPEED section
in the maintainers file. Improve the wildcards here a little bit,
so that it is covered, too.
Signed-off-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Message-Id: <20230421110345.1294131-4-th...@redhat.com>
S
From: Thomas Huth
This function will be useful in other tests, too, so move it to the
core LinuxSSHMixIn class.
Signed-off-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Message-Id: <20230421110345.1294131-2-th...@redhat.com>
Signed-off-by: Alex Bennée
---
tests/avocado/avocado_qemu/__init__.
On Mon, 2023-04-24 at 10:36 +0200, Emanuele Giuseppe Esposito wrote:
>
> Am 24/04/2023 um 10:15 schrieb Emanuele Giuseppe Esposito:
> >
> > Am 23/04/2023 um 13:02 schrieb wanglian...@126.com:
> > > From: Wang Liang
> > >
> > > We need to get the aio_context before calling the
> > > blk_is_avail
On 24/04/2023 11.22, Alex Bennée wrote:
The tuxboot images now have a stable snapshot URL so we can enable the
checksums and remove the avocado warnings. We will have to update as
old snapshots retire but that won't be too frequent.
Signed-off-by: Alex Bennée
---
tests/avocado/tuxrun_baseline
On Fri, 21 Apr 2023 at 17:50, Jonathan Cameron
wrote:
>
> This patch and the problem it is trying to resolve will form part of a talk
> I will be giving next week at Linaro Connect. https://sched.co/1K85p
>
> So in the spirit of giving people almost no warning... Plus being able to
> say the discu
There use makes our code safer so we should mention them.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20230420155723.1711048-10-alex.ben...@linaro.org>
---
vppr:
- show example of what QEMU_
Sorry, this patchset has incorrect//recipients.
On 4/24/23 11:16, Alexander Ivanov wrote:
Fix image inflation when offset in BAT is out of image.
Replace whole BAT syncing by flushing only dirty blocks.
Move all the checks outside the main check function in
separate functions
Use WITH_QEMU_LO
Running every plugin with every test is getting excessive as well as
not really improving coverage that much. Restrict the plugin tests to
just the MULTIARCH_TESTS which are shared between most architecture
for both system and user-mode. For those that aren't we need to squash
MULTIARCH_TESTS so we
While not explicitly disallowing header macro abuse (because that
would make us hypocrites) lets at least address some things to think
about.
Signed-off-by: Alex Bennée
Reviewed-by: Juan Quintela
Message-Id: <20230420155723.1711048-8-alex.ben...@linaro.org>
---
docs/devel/style.rst | 14 +++
Set data_end to the end of the last cluster inside the image. In such a
way we can be sure that corrupted offsets in the BAT can't affect on the
image size. If there are no allocated clusters set image_end_offset by
data_end.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block
data_end field in BDRVParallelsState is set to the biggest offset present
in BAT. If this offset is outside of the image, any further write will
create the cluster at this offset and/or the image will be truncated to
this offset on close. This is definitely not correct.
Raise an error in parallels
Don't let high_off be more than the file size even if we don't fix the
image.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/
BAT is written in the context of conventional operations over the image
inside bdrv_co_flush() when it calls parallels_co_flush_to_os() callback.
Thus we should not modify BAT array directly, but call
parallels_set_bat_entry() helper and bdrv_co_flush() further on. After
that there is no need to ma
We will add more and more checks so we need a better code structure in
parallels_co_check. Let each check performs in a separate loop in a
separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 79 ++-
1 f
This helper will be reused in next patches during parallels_co_check
rework to simplify its code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 31 +
Fix image inflation when offset in BAT is out of image.
Replace whole BAT syncing by flushing only dirty blocks.
Move all the checks outside the main check function in
separate functions
Use WITH_QEMU_LOCK_GUARD for simplier code.
Fix incorrect condition in out-of-image check.
v11:
1: Use bdrv
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 52 +
Exclude out-of-image clusters from allocated and fragmented clusters
calculation.
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 8588c3d775..f389a74466 100644
--- a/block/p
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
ind
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 90 ---
1 file changed, 53 insertions(+)
Replace the way we use mutex in parallels_co_check() for simplier
and less error prone code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/block/parallels.
> -Original Message-
> From: Akihiko Odaki
> Sent: Sunday, 23 April 2023 06:18
> Cc: Sriram Yagnaraman ; Jason Wang
> ; Dmitry Fleytman ;
> Michael S . Tsirkin ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Laurent
> -Original Message-
> From: Akihiko Odaki
> Sent: Sunday, 23 April 2023 06:18
> Cc: Sriram Yagnaraman ; Jason Wang
> ; Dmitry Fleytman ;
> Michael S . Tsirkin ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Lauren
> -Original Message-
> From: Akihiko Odaki
> Sent: Sunday, 23 April 2023 06:18
> Cc: Sriram Yagnaraman ; Jason Wang
> ; Dmitry Fleytman ;
> Michael S . Tsirkin ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Lauren
> -Original Message-
> From: Akihiko Odaki
> Sent: Sunday, 23 April 2023 06:18
> Cc: Sriram Yagnaraman ; Jason Wang
> ; Dmitry Fleytman ;
> Michael S . Tsirkin ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Laurent
> -Original Message-
> From: Akihiko Odaki
> Sent: Sunday, 23 April 2023 06:18
> Cc: Sriram Yagnaraman ; Jason Wang
> ; Dmitry Fleytman ;
> Michael S . Tsirkin ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Laurent
This patchset should be applied on the top of [PATCH v10 00/12] parallels:
Refactor the code of images checks and fix a bug.
Fix incorrect data end calculation in parallels_open().
Split image leak handling to separate check and fix helpers.
Add checking and repairing duplicate offsets in BAT
R
Repair an image at opening if the image is unclean or out-of-image
corruption was detected.
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 65 +--
1 file changed, 35 insertions(+), 30 deletions(-)
diff --git a/block/parallels.c b/block/parall
Cluster offsets must be unique among all the BAT entries. Find duplicate
offsets in the BAT and fix it by copying the content of the relevant
cluster to a newly allocated cluster and set the new cluster offset to the
duplicated entry.
Add host_cluster_index() helper to deduplicate the code.
Move
If the check is called during normal work, tracking of the check must be
present in VM logs to have some clues if something going wrong with user's
data.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 18 +-
1 file changed, 9 insertions(+), 9
The BDRVParallelsState structure contains data_end field that is measured
in sectors. In parallels_open() initially this field is set by data_off
field from parallels image header.
According to the parallels format documentation, data_off field contains
an offset, in sectors, from the start of the
We need to fix leak after deduplication in the next patch. Move leak
fixing to a separate helper parallels_fix_leak() and add
parallels_get_leak_size() helper wich used in parallels_fix_leak() and
parallels_check_leak().
Signed-off-by: Alexander Ivanov
---
block/parallels.c | 86
On Fri, Apr 21, 2023 at 11:59:25PM +0200, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > When running migration tests we monitor for a STOP event so we can skip
> > redundant waits. This will be needed for the RESUME event too shortly.
> >
> > Signed-off-by: Daniel P. Berrangé
>
> Reviewed
Juan Quintela wrote:
> Richard Henderson wrote:
>> On 4/22/23 10:21, Juan Quintela wrote:
>>> Richard Henderson wrote:
On 4/20/23 14:17, Juan Quintela wrote:
>> I'll note that mips32 and armv6 (that is, *not* debian's armv7 based
>> armhf distro) are the only hosts we have that don't have
Markus -- could I trouble you for a quick review of this patch?
It's the only one in the series that touches QMP. Everything
else has been reviewed so otherwise this series is ready to go in.
thanks
-- PMM
On Mon, 17 Apr 2023 at 17:40, Peter Maydell wrote:
>
> The 'singlestep' member of StatusIn
On Mon, 24 Apr 2023, Bernhard Beschow wrote:
Am 22. April 2023 19:21:12 UTC schrieb BALATON Zoltan :
On Sat, 22 Apr 2023, Bernhard Beschow wrote:
Am 22. April 2023 17:23:56 UTC schrieb BALATON Zoltan :
On Sat, 22 Apr 2023, Bernhard Beschow wrote:
The VIA south bridge allows the legacy IDE int
On 20/04/2023 12:02, mark.s...@citrix.com wrote:
From: Mark Syms
Ensure the PV ring is drained on disconnect. Also ensure all pending
AIO is complete, otherwise AIO tries to complete into a mapping of the
ring which has been torn down.
Signed-off-by: Mark Syms
---
CC: Stefano Stabellini
CC:
On 2023/4/24 16:59, Peter Maydell wrote:
On Mon, 24 Apr 2023 at 07:24, Yong Li wrote:
The virt machine can have two UARTs and the second UART
can be used when host secure-mode support is enabled.
Do you mean "host" here, or "guest" ?
Currently, it is an UEFI secure firmware residing in a se
On 4/24/23 10:22, Alex Bennée wrote:
From: Thomas Huth
FreeBSD 13.0 has been released in April 2021:
https://www.freebsd.org/releases/13.0R/announce/
According to QEMU's support policy, we stop supporting the previous
major release two years after the the new major release has been
published
The virt machine can have two UARTs and the second UART
can be used when host secure-mode support is enabled.
Signed-off-by: Yong Li
---
hw/riscv/virt.c | 4
include/hw/riscv/virt.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index b38b41
On 2023/04/24 18:29, Sriram Yagnaraman wrote:
-Original Message-
From: Akihiko Odaki
Sent: Sunday, 23 April 2023 06:18
Cc: Sriram Yagnaraman ; Jason Wang
; Dmitry Fleytman ;
Michael S . Tsirkin ; Alex Bennée
; Philippe Mathieu-Daudé ;
Thomas Huth ; Wainer dos Santos Moschetta
; Beraldo L
Am 24/04/2023 um 12:39 schrieb wanglian...@126.com:
> From: Wang Liang
>
> hmp_commit() calls blk_is_available() from a non-coroutine context (and in
> the main loop). blk_is_available() is a co_wrapper_mixed_bdrv_rdlock
> function, and in the non-coroutine context it calls AIO_WAIT_WHILE(),
>
The virt machine can have two UARTs and the second UART
can be used by the secure payload, firmware or OS residing
in secure world.
Signed-off-by: Yong Li
---
hw/riscv/virt.c | 4
include/hw/riscv/virt.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/hw/riscv/virt.c b/hw/ris
From: Wang Liang
hmp_commit() calls blk_is_available() from a non-coroutine context (and in
the main loop). blk_is_available() is a co_wrapper_mixed_bdrv_rdlock
function, and in the non-coroutine context it calls AIO_WAIT_WHILE(),
which crashes if the aio_context lock is not taken before.
Resolv
On 2023/01/16 20:18, Peter Maydell wrote:
On Sat, 14 Jan 2023 at 06:49, Akihiko Odaki wrote:
On 2023/01/14 14:23, Richard Henderson wrote:
On 1/8/23 22:22, Akihiko Odaki wrote:
libvirt uses "none" machine type to test KVM availability. Before this
change, QEMU used to pass 0 as machine type
Rest of counters that refer to pages has a _pages suffix.
And historically, this showed the number of full pages transferred.
The name "normal" refered to the fact that they were sent without any
optimization (compression, xbzrle, zero_page, ...).
Signed-off-by: Juan Quintela
Reviewed-by: Peter X
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/migration.c | 2 +-
migration/multifd.c | 2 +-
migration/ram.c | 5 -
migration/ram.h | 4 +---
4 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index
From: Peter Xu
Postcopy requires the memory support userfaultfd to work. Right now we
check it but it's a bit too late (when switching to postcopy migration).
Do that early right at enabling of postcopy.
Note that this is still only a best effort because ramblocks can be
dynamically created.
Using MgrationStats as type for ram_counters mean that we didn't have
to re-declare each value in another struct. The need of atomic
counters have make us to create MigrationAtomicStats for this atomic
counters.
Create RAMStats type which is a merge of MigrationStats and
MigrationAtomicStats remov
1 - 100 of 342 matches
Mail list logo
