On Mon, 2023-04-24 at 10:36 +0200, Emanuele Giuseppe Esposito wrote: > > Am 24/04/2023 um 10:15 schrieb Emanuele Giuseppe Esposito: > > > > Am 23/04/2023 um 13:02 schrieb wanglian...@126.com: > > > From: Wang Liang <wanglian...@inspur.com> > > > > > > We need to get the aio_context before calling the > > > blk_is_available. > > > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615 > > > Signed-off-by: Wang Liang <wanglian...@inspur.com> > > > > > > > Reviewed-by: Emanuele Giuseppe Esposito <eespo...@redhat.com> > > > > Sorry I forgot, if you need to resend can you add the cause of this > issue in the commit message? > Something along the lines of: > "hmp_commit() calls blk_is_available() from a non-coroutine context > (and > in the main loop). Since this is a co_wrapper_mixed_bdrv_rdlock > function, in this case it calls AIO_WAIT_WHILE(), which crashes if > the > aio_context lock is not taken before" > > Thank you, > Emanuele
Thanks for the detailed explanation. I'll resend the patch. Wang Liang
