The configure script used to compile some code which dereferences memory
with ubsan to verify the compiler can link with ubsan library which
detects dereferencing of uninitialized memory. However, as the
dereferenced memory was allocated in the same code, GCC can statically
detect the unitialized m
When virtualizing SMP system, kvm_arm_init_debug() will be called
multiple times. Check if the debug feature is already initialized when the
function is called; otherwise it will overwrite pointers to memory
allocated with the previous call and leak it.
Fixes: e4482ab7e3 ("target-arm: kvm - add su
On Tue, 4 Apr 2023 10:42:04 -0400
"Michael S. Tsirkin" wrote:
> On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote:
> > On Tue, 4 Apr 2023 08:46:15 -0400
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote:
> > > > On Mon, 3 Apr
On Tue, 4 Apr 2023 18:00:06 +0200
Yu Zhang wrote:
> > this patch targets corner case of early boot where
> > guest hasn't initialized ACPI subsystem yet and 'broken'
> > management asking to unplug device too early which leads
> > to device stuck in being unplugged state due to regression
> > in
On 04/04/2023 17.42, BALATON Zoltan wrote:
On Tue, 4 Apr 2023, Cédric Le Goater wrote:
[ adding Zoltan ]
On 4/4/23 16:00, Thomas Huth wrote:
On 05/02/2023 23.12, Mark Cave-Ayland wrote:
On 30/01/2023 20:45, Alex Bennée wrote:
Daniel P. Berrangé writes:
On Mon, Jan 30, 2023 at 11:47:02AM
On 09-03-23, 14:20, Viresh Kumar wrote:
> Hello,
>
> This patchset tries to update the vhost-user protocol to make it support
> special
> memory mapping required in case of Xen hypervisor.
>
> The first patch is mostly cleanup and second one introduces a new xen specific
> feature.
Can we apply
On 04.04.23 13:58, Markus Armbruster wrote:
query-cpu-definitions returns a list of CpuDefinitionInfo, but
documentation claims CpuDefInfo, which doesn't exist.
query-migrate-capabilities returns a list of
MigrationCapabilityStatus, but documentation claims
MigrationCapabilitiesStatus, which doe
Am 04/04/2023 um 17:33 schrieb Stefan Hajnoczi:
> There is no need for the AioContext lock in aio_wait_bh_oneshot().
> It's easy to remove the lock from existing callers and then switch from
> AIO_WAIT_WHILE() to AIO_WAIT_WHILE_UNLOCKED() in aio_wait_bh_oneshot().
>
> Document that the AioConte
On Wed, Mar 29, 2023 at 11:09 PM Johannes Thumshirn wrote:
>
> Add MEN z125 UART over MEN Chameleon Bus emulation.
>
> Signed-off-by: Johannes Thumshirn
Acked-by: Alistair Francis
Alistair
> ---
> hw/char/Kconfig | 6 +++
> hw/char/meson.build | 1 +
> hw/char/serial-mcb.c | 115 ++
On Wed, Apr 05, 2023 at 09:30:20AM +0200, Igor Mammedov wrote:
> On Tue, 4 Apr 2023 10:42:04 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote:
> > > On Tue, 4 Apr 2023 08:46:15 -0400
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Tue,
with Q35 using ACPI PCI hotplug by default, user's request to unplug
device is ignored when it's issued before guest OS has been booted.
And any additional attempt to request device hot-unplug afterwards
results in following error:
"Device XYZ is already in the process of unplug"
arguably it ca
On Wed, Apr 05, 2023 at 10:34:44AM +0200, Igor Mammedov wrote:
> with Q35 using ACPI PCI hotplug by default, user's request to unplug
> device is ignored when it's issued before guest OS has been booted.
> And any additional attempt to request device hot-unplug afterwards
> results in following err
This patchset tries to simplify the RVH related check and fix some code style
problems, such as problems for indentation, multi-line comments and lines with
over 80 characters.
The port is available here:
https://github.com/plctlab/plct-qemu/tree/plct-virtfix-upstream
v2:
* add comment to speci
Fix identation problems, and try to use the same indentation strategy
in the same file.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
Reviewed-by: LIU Zhiwei
Acked-by: Alistair Francis
---
target/riscv/arch_dump.c| 4 +-
target/riscv/cpu.c | 40
Fix lines with over 80 characters for both code and comments.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
Reviewed-by: LIU Zhiwei
Acked-by: Alistair Francis
---
target/riscv/cpu.c | 3 +-
target/riscv/cpu.h | 4 +-
target/riscv/cpu_helper.c| 3 +-
target/r
Fix formats for multi-lines comments.
Add spaces around single line comments(after "/*" and before "*/").
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
Acked-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Reviewed-by: Alistair Francis
---
target/riscv/arch_dump.c| 3 +
Directly use env->virt_enabled instead.
Suggested-by: LIU Zhiwei
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
Reviewed-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Reviewed-by: Alistair Francis
---
target/riscv/cpu.c| 2 +-
target/riscv/cpu.h| 1 -
target/riscv/c
On Wed, Mar 29, 2023 at 11:08 PM Johannes Thumshirn wrote:
>
> The MEN Chameleon Bus (MCB) is an on-chip bus system exposing IP Cores of an
> FPGA to a outside bus system like PCIe.
>
> Signed-off-by: Johannes Thumshirn
I don't know a lot about MEN Chameleon Bus, but this looks fine to me
Acked
On Wed, 5 Apr 2023 04:32:16 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Apr 05, 2023 at 09:30:20AM +0200, Igor Mammedov wrote:
> > On Tue, 4 Apr 2023 10:42:04 -0400
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote:
> > > > On Tue, 4 Apr
On Wed, 5 Apr 2023 04:47:48 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Apr 05, 2023 at 10:34:44AM +0200, Igor Mammedov wrote:
> > with Q35 using ACPI PCI hotplug by default, user's request to unplug
> > device is ignored when it's issued before guest OS has been booted.
> > And any additional at
On 4/5/23 02:53, Alistair Francis wrote:
On Mon, Mar 13, 2023 at 11:12 PM Hang Xu wrote:
Because the starting address of ram is not necessarily 0,
the remaining free space in ram is
ram_size - (start - ram_base) instead of ram_size-start.
I think this could be clearer. It's not clear here
with Q35 using ACPI PCI hotplug by default, user's request to unplug
device is ignored when it's issued before guest OS has been booted.
And any additional attempt to request device hot-unplug afterwards
results in following error:
"Device XYZ is already in the process of unplug"
arguably it ca
On Wed, 5 Apr 2023 04:47:48 -0400
"Michael S. Tsirkin" wrote:
[...]
> This is arguably a regression but not in this release yes?
> So I don't think it needs to block qemu release.
yep, it's 'old' regression introduced in earlier releases
> Fixes: cce8944cc9ef ("qdev-monitor: Forbid repeated devi
Add signature and signature-granularity properties in spike to specify the
target
signatrue file and the line size for signature data.
Recgonize the signature section between begin_signature and end_signature
symbols
when loading elf of ACT tests. Then dump signature data in signature section
j
ACT tests play an important role in riscv tests. This patch tries to
add related support to run ACT tests.
The port is available here:
https://github.com/plctlab/plct-qemu/tree/plct-act-upstream-v2
The ACT tests can be run on qemu-system-riscv32/64 with machine argument
"-M spike,signature=,signa
On 04.04.23 20:32, Hanna Czenczek wrote:
On 04.04.23 10:10, Vladimir Sementsov-Ogievskiy wrote:
On 03.04.23 16:33, Hanna Czenczek wrote:
(Sorry for the rather late reply... Thanks for the review!)
On 20.03.23 11:31, Vladimir Sementsov-Ogievskiy wrote:
On 17.03.23 20:50, Hanna Czenczek wrote:
On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote:
> > > PS:
> > > See commit message, Windows is not affected as it doesn't
> > > clear GPE status bits during ACPI initialization
> > > (at least the one version I've tested with, and I won't bet
> > > on this with other versions or stay
Viresh Kumar writes:
> On 09-03-23, 14:20, Viresh Kumar wrote:
>> Hello,
>>
>> This patchset tries to update the vhost-user protocol to make it support
>> special
>> memory mapping required in case of Xen hypervisor.
>>
>> The first patch is mostly cleanup and second one introduces a new xen
On Wed, Apr 05, 2023 at 11:38:56AM +0200, Igor Mammedov wrote:
> On Wed, 5 Apr 2023 04:47:48 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Apr 05, 2023 at 10:34:44AM +0200, Igor Mammedov wrote:
> > > with Q35 using ACPI PCI hotplug by default, user's request to unplug
> > > device is ignored
On 5/4/23 09:02, Akihiko Odaki wrote:
When virtualizing SMP system, kvm_arm_init_debug() will be called
multiple times. Check if the debug feature is already initialized when the
function is called; otherwise it will overwrite pointers to memory
allocated with the previous call and leak it.
Fixe
On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
>
> Viresh Kumar writes:
>
> > On 09-03-23, 14:20, Viresh Kumar wrote:
> >> Hello,
> >>
> >> This patchset tries to update the vhost-user protocol to make it support
> >> special
> >> memory mapping required in case of Xen hypervisor
Missed in commit 80485d88f9 ("target/arm: Restrict
v7A TCG cpus to TCG accel").
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/kvm-consts.h | 9 +++--
target/arm/cpu_tcg.c| 2 --
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/target/arm/kvm-consts.h b/target/arm/kvm
Remove unused KVM/Aarch32 definitions.
Philippe Mathieu-Daudé (2):
target/arm: Remove KVM AArch32 CPU definitions
hw/arm/virt: Restrict Cortex-A7 check to TCG
target/arm/kvm-consts.h | 9 +++--
hw/arm/virt.c | 2 ++
target/arm/cpu_tcg.c| 2 --
3 files changed, 5 insertions(
The Cortex-A7 core is only available when TCG is enabled (see
commit 80485d88f9 "target/arm: Restrict v7A TCG cpus to TCG accel").
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/virt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index ac626b3bef..1fe39c6
exp->common.blk cannot be NULL, nbd_export_delete() is only called from
blk_exp_unref() and in turn that can only happen after blk_exp_add()
has asserted exp->blk != NULL.
Signed-off-by: Paolo Bonzini
---
nbd/server.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --g
On Wed, Apr 05, 2023 at 11:42:56AM +0200, Igor Mammedov wrote:
> with Q35 using ACPI PCI hotplug by default, user's request to unplug
> device is ignored when it's issued before guest OS has been booted.
> And any additional attempt to request device hot-unplug afterwards
> results in following err
This series is part of the single binary effort.
All accelerator will share their per-vCPU context in
an opaque 'accel' pointer within the CPUState.
First handle HAX/NVMM/WHPX/HVF. KVM and TCG will follow
as two different (bigger) follow-up series.
Philippe Mathieu-Daudé (14):
accel: Document
On Windows hosts, cpu->hThread is assigned but never accessed:
remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops-mttcg.c | 4
accel/tcg/tcg-accel-ops-rr.c | 3 ---
target/i386/whpx/whpx-accel-ops.c | 3 ---
3 files changed, 10 deletions(-)
diff --git a/acc
Use a type definition instead of explicit structure.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hax/hax-i386.h| 10 +-
target/i386/hax/hax-all.c | 16
target/i386/hax/hax-posix.c | 4 ++--
target/i386/hax/hax-windows.c | 4 ++--
4 files changed, 17
hThread variable is only used by the HAX accelerator,
so move it to the accelerator specific context.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 1 -
target/i386/hax/hax-i386.h | 3 +++
target/i386/hax/hax-accel-ops.c | 2 +-
target/i386/hax/hax-all.c
These headers are meant to be include by any file to check
the availability of accelerators, thus are not accelerator
specific.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/hax.h | 2 ++
include/sysemu/kvm.h | 2 ++
include/sysemu/nvmm.h | 2 ++
include/sysemu/tcg.h | 2 ++
includ
When the vCPU thread finished its processing, destroy
it and signal its destruction to generic vCPU management
layer.
Add a sanity check for the vCPU accelerator context.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hax/hax-accel-ops.c | 3 +++
target/i386/hax/hax-all.c | 1 +
2
g_malloc0() can not fail. Use g_try_malloc0() instead.
https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/nvmm/nvmm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
All accelerators will share a single opaque context
in CPUState. Start by renaming 'hax_vcpu' as 'accelCPUState'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 2 +-
target/i386/hax/hax-accel-ops.c | 2 +-
target/i386/hax/hax-all.c | 18 +-
t
We want all accelerators to share the same opaque pointer in
CPUState. Start with the HAX context, renaming its forward
declarated structure 'hax_vcpu_state' as 'AccelvCPUState'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 7 +++
target/i386/hax/hax-i386.h | 3 ++
We want all accelerators to share the same opaque pointer in
CPUState. Rename NVMM 'qemu_vcpu' as 'AccelvCPUState'.
Replace g_try_malloc0() by g_try_new0() for readability.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/nvmm/nvmm-all.c | 34 +-
1 file chan
We want all accelerators to share the same opaque pointer in
CPUState. Rename WHPX 'whpx_vcpu' as 'AccelvCPUState'.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/whpx/whpx-all.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/target/i3
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/whpx/whpx-all.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c
index 2
We want all accelerators to share the same opaque pointer in
CPUState.
Rename the 'hvf_vcpu_state' structure as 'AccelvCPUState'.
Use the generic 'accel' field of CPUState instead of 'hvf'.
Replace g_malloc0() by g_new0() for readability.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/c
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/nvmm/nvmm-all.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c
index 97
hThread is only used on the error path in hax_kick_vcpu_thread().
Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support")
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hax/hax-all.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/i386/hax/hax-all.c b/target
"Michael S. Tsirkin" writes:
> On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
>>
>> Viresh Kumar writes:
>>
>> > On 09-03-23, 14:20, Viresh Kumar wrote:
>> >> Hello,
>> >>
>> >> This patchset tries to update the vhost-user protocol to make it support
>> >> special
>> >> memor
Signed-off-by: Paolo Bonzini
---
block/copy-before-write.c | 2 +-
block/copy-on-read.c | 8
block/io.c| 6 +++---
block/mirror.c| 10 +-
block/qcow2.c | 5 +++--
block/replication.c | 8
block/stream.c|
Provide coroutine versions of bdrv_is_allocated* and bdrv_block_status*,
since the underlying BlockDriver API is coroutine-based, and use
automatically-generated wrappers for the "mixed" versions.
Paolo
Paolo Bonzini (4):
block: rename the bdrv_co_block_status static function
block: complete
Include both coroutine and non-coroutine versions, the latter being
co_wrapper_mixed_bdrv_rdlock of the former.
Signed-off-by: Paolo Bonzini
---
block/io.c | 18 +-
include/block/block-io.h | 18 --
2 files changed, 17 insertions(+), 19 deletions(-)
bdrv_block_status exists as a wrapper for bdrv_block_status_above,
but the name of the (hypothetical) coroutine version, bdrv_co_block_status,
is squatted by a random static function. Rename it to bdrv_do_block_status.
Signed-off-by: Paolo Bonzini
---
block/io.c | 10 +-
1 file changed,
Signed-off-by: Paolo Bonzini
---
block/io.c | 53 ++--
include/block/block-io.h | 12 +
2 files changed, 14 insertions(+), 51 deletions(-)
diff --git a/block/io.c b/block/io.c
index 0aad0f57d8c7..cacde79a3e98 100644
--- a/block/io.c
+++ b
On Wed, Apr 05, 2023 at 11:24:43AM +0100, Alex Bennée wrote:
>
> "Michael S. Tsirkin" writes:
>
> > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote:
> >>
> >> Viresh Kumar writes:
> >>
> >> > On 09-03-23, 14:20, Viresh Kumar wrote:
> >> >> Hello,
> >> >>
> >> >> This patchset tri
On Tue, 4 Apr 2023 at 17:49, Paolo Bonzini wrote:
>
> The following changes since commit f00506aeca2f6d92318967693f8da8c713c163f3:
>
> Merge tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu into
> staging (2023-03-29 11:19:19 +0100)
>
> are available in the Git repository at:
>
> ht
Introduce a MemoryListener callback for address space map events.
This will require a change to the memory listener callbacks: while it
currently uses "self" as first argument for the callbacks, this new
approach is going to use an "opaque" member, effectively following the
model used for MemoryRe
Hi!
As mentioned in the last upstream virtio-networking meeting, one of
the factors that adds more downtime to migration is the handling of
the guest memory (pin, map, etc). At this moment this handling is
bound to the virtio life cycle (DRIVER_OK, RESET). In that sense, the
destination device wai
So let it be, with a delay of about a week.
Since no one from the qemu team replied to my final-release steps, I'm
making it available on my site instead:
http://www.corpit.ru/mjt/qemu/qemu-7.2.1.tar.xz
http://www.corpit.ru/mjt/qemu/qemu-7.2.1.tar.xz.sig - signed with my GPG key
http://www
On Wed, 5 Apr 2023, Thomas Huth wrote:
On 04/04/2023 17.42, BALATON Zoltan wrote:
On Tue, 4 Apr 2023, Cédric Le Goater wrote:
[ adding Zoltan ]
On 4/4/23 16:00, Thomas Huth wrote:
On 05/02/2023 23.12, Mark Cave-Ayland wrote:
On 30/01/2023 20:45, Alex Bennée wrote:
Daniel P. Berrangé write
On Wed, 5 Apr 2023 05:59:06 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote:
> > > > PS:
> > > > See commit message, Windows is not affected as it doesn't
> > > > clear GPE status bits during ACPI initialization
> > > > (at least the one version I
Queued, thanks.
Paolo
On Wed, Apr 05, 2023 at 02:03:32PM +0200, Igor Mammedov wrote:
> On Wed, 5 Apr 2023 05:59:06 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote:
> > > > > PS:
> > > > > See commit message, Windows is not affected as it doesn't
> > > > > clear G
> On 05-Apr-2023, at 5:57 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 05, 2023 at 02:03:32PM +0200, Igor Mammedov wrote:
>> On Wed, 5 Apr 2023 05:59:06 -0400
>> "Michael S. Tsirkin" wrote:
>>
>>> On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote:
>> PS:
>> See commit me
On Wed, 5 Apr 2023 06:02:29 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Apr 05, 2023 at 11:38:56AM +0200, Igor Mammedov wrote:
> > On Wed, 5 Apr 2023 04:47:48 -0400
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Apr 05, 2023 at 10:34:44AM +0200, Igor Mammedov wrote:
> > > > with Q35 usin
On Thu, Mar 9, 2023 at 9:50 AM Paolo Bonzini wrote:
> The value of the bdrv_file_open is sometimes checked to distinguish
> protocol and format drivers, but apart from that there is no difference
> between bdrv_file_open and bdrv_open.
>
> However, they can all be distinguished by the non-NULL .pr
On 05/04/2023 13.54, BALATON Zoltan wrote:
On Wed, 5 Apr 2023, Thomas Huth wrote:
On 04/04/2023 17.42, BALATON Zoltan wrote:
On Tue, 4 Apr 2023, Cédric Le Goater wrote:
[ adding Zoltan ]
On 4/4/23 16:00, Thomas Huth wrote:
On 05/02/2023 23.12, Mark Cave-Ayland wrote:
On 30/01/2023 20:45, Al
On Wed, Apr 05, 2023 at 12:16:34PM +0200, Paolo Bonzini wrote:
> exp->common.blk cannot be NULL, nbd_export_delete() is only called from
> blk_exp_unref() and in turn that can only happen after blk_exp_add()
> has asserted exp->blk != NULL.
Commit message is a bit imprecise (maybe due to refactori
Hi! This is the RFC about the memory issue I mentioned in our last KVM call.
In our use case, QEMU is used as a library, where RAM and Alias MemoryRegions
are created by listening to read/write events through MemoryRegionOps callbacks.
In this case, no read/write happened yet, so we did not have a
Introduce a MemoryListener callback for address space map events.
This will require a change to the memory listener callbacks: while it
currently uses "self" as first argument for the callbacks, this new
approach is going to use an "opaque" member, effectively following the
model used for MemoryRe
On Wed, Apr 05 2023, "David 'Digit' Turner" wrote:
> Add , used by hw/display/virtio-gpu-udmabuf.c
> Add , used by qga/commands-posix.c
> Add used by kvm-all.c, which requires
> the _BITUL() macro definition to be available.
>
> Without these, QEMU will not compile on Debian 10 systems.
Hm, I w
Add , used by hw/display/virtio-gpu-udmabuf.c
Add , used by qga/commands-posix.c
Add used by kvm-all.c, which requires
the _BITUL() macro definition to be available.
Without these, QEMU will not compile on Debian 10 systems.
The script has then been run against the official
6.2.8 kernel source t
The source file uses VIRTIO_F_VERSION_1 which is
not defined by on Debian 10.
The system-provided which
does not include the macro definition is included
through , so fix the issue by including
the standard-headers version before that.
Signed-off-by: David 'Digit' Turner
---
subprojects/libvh
cxl device typ3 size is read from the memory backend device, removing the
size option specified in cxl sample command.
Updating sample command to reflect target architecture as x86_64.
Signed-off-by: Raghu H
---
docs/system/devices/cxl.rst | 14 +++---
1 file changed, 7 insertions(+), 7
QEMU does not compile on an old Debian 10 system for the
following reasons:
- Several sources include recent kernel headers that are
not provided by this system, and not listed in
linux-headers/
- The libvhost-user.c source file ends up including a
system kernel header, instead of the up-to
On 05.04.23 14:57, Antonio Caggiano wrote:
Introduce a MemoryListener callback for address space map events.
Why?
--
Thanks,
David / dhildenb
Add the forgotten trailing newline.
Signed-off-by: Michael Tokarev
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index a18f052374..3d220d3955 100644
--- a/block.c
+++ b/block.c
@@ -7026,7 +7026,7 @@ void bdrv_img_create(const char *filename, co
On Wed, Apr 5, 2023 at 3:06 PM Cornelia Huck wrote:
> On Wed, Apr 05 2023, "David 'Digit' Turner" wrote:
>
> > Add , used by hw/display/virtio-gpu-udmabuf.c
> > Add , used by qga/commands-posix.c
> > Add used by kvm-all.c, which requires
> > the _BITUL() macro definition to be available.
> >
>
Philippe Mathieu-Daudé writes:
> g_malloc0() can not fail. Use g_try_malloc0() instead.
>
> https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/nvmm/nvmm-all.c | 2 +-
> 1 file
On 04.04.23 16:36, Peter Xu wrote:
On Mon, Apr 03, 2023 at 10:14:21PM +, Alexander Graf wrote:
Add an option for hostmem-file to start the memory object at an offset
into the target file. This is useful if multiple memory objects reside
inside the same target file, such as a device node.
In
On Wed, Apr 05, 2023 at 02:54:47PM +0300, Michael Tokarev wrote:
> So let it be, with a delay of about a week.
>
> Since no one from the qemu team replied to my final-release steps, I'm
> making it available on my site instead:
>
> http://www.corpit.ru/mjt/qemu/qemu-7.2.1.tar.xz
> http://www.
On 5/4/23 15:34, Michael Tokarev wrote:
Add the forgotten trailing newline.
Signed-off-by: Michael Tokarev
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
05.04.2023 16:58, Michael Roth wrote:
On Wed, Apr 05, 2023 at 02:54:47PM +0300, Michael Tokarev wrote:
So let it be, with a delay of about a week.
Since no one from the qemu team replied to my final-release steps, I'm
making it available on my site instead:
http://www.corpit.ru/mjt/qemu/qem
Use proper PCI device for net_tx_pkt provided to
net_tx_pkt_add_raw_fragment.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb.c | 8
hw/net/igb_core.c | 47 +--
hw/net/igb_core.h | 3 +++
3 files changed, 52 insertions(+), 6 deletions(-)
Use TX SCTP checksumming offload as supported by IGB devices.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index e1b99f312b..8cc8682c66 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -
Modern NICs are able to offload SCTP checksumming. SCTP calculates
checksums differently than TCP / UDP: no pseudo-header and CRC32C
algorithm are used.
Signed-off-by: Tomasz Dzieciol
---
hw/net/net_tx_pkt.c| 22 ++
hw/net/net_tx_pkt.h| 8
include/net/checks
Hi David,
On 05/04/23 15:23, David Hildenbrand wrote:
On 05.04.23 14:57, Antonio Caggiano wrote:
Introduce a MemoryListener callback for address space map events.
Why?
Please, have a look at the cover letter "[PATCH RFC 0/1] MemoryListener
address_space_map callback" with a detail explan
On 05.04.23 16:25, Antonio Caggiano wrote:
Hi David,
On 05/04/23 15:23, David Hildenbrand wrote:
On 05.04.23 14:57, Antonio Caggiano wrote:
Introduce a MemoryListener callback for address space map events.
Why?
Please, have a look at the cover letter "[PATCH RFC 0/1] MemoryListener
addre
On Sun, 2 Apr 2023 17:55:59 +
Lukas Straub wrote:
> This series refactors the ram compress code.
>
> It first removes ram.c dependencies from the core compress code, then
> moves it out to its own file. Finally, on the migration destination side
> the initialisation and cleanup of compress t
From: Axel Heider
Fix issue reported by Coverity.
Signed-off-by: Axel Heider
---
hw/timer/imx_epit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index 3a869782bc..0821c62cd1 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_ep
From: Axel Heider
Fix the limit check. If the limit is less than the compare value,
the timer can never reach this value, thus it will never fire.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1491
Signed-off-by: Axel Heider
---
hw/timer/imx_epit.c | 2 +-
1 file changed, 1 insertio
This patchset fixes the following issues:
- variable shadowing reported by Coverity
- fix check, see https://gitlab.com/qemu-project/qemu/-/issues/1491
Axel Heider (2):
hw/timer/imx_epit: don't shadow variable
hw/timer/imx_epit: fix limit check
hw/timer/imx_epit.c | 2 +-
1 file changed, 1 i
On Wed, Apr 05, 2023 at 02:44:13PM +, Lukas Straub wrote:
> On Sun, 2 Apr 2023 17:55:59 +
> Lukas Straub wrote:
>
> > This series refactors the ram compress code.
> >
> > It first removes ram.c dependencies from the core compress code, then
> > moves it out to its own file. Finally, on t
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Tue, 4 Apr 2023 at 14:25, Markus Armbruster wrote:
> >
> > Peter Maydell writes:
> >
> > > On Tue, 4 Apr 2023 at 09:25, Markus Armbruster wrote:
> > >> Hmm. We report it in query-status, which means it's relevant to QMP
> > >> clients. We
On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert wrote:
>
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > I think on balance I would go for:
> > * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct,
> >rather than merely renaming it
> > * if anybody comes along and sa
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert
> wrote:
> >
> > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > I think on balance I would go for:
> > > * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct,
> > >ra
Coroutine commands have to be declared as coroutine_fn, but the
marker does not show up in the qapi-comands-* headers; likewise, the
marshaling function calls the command and therefore must be coroutine_fn.
Static analysis would want coroutine_fn to match between prototype and
declaration, because
1 - 100 of 247 matches
Mail list logo
