On Wed, Apr 05, 2023 at 02:44:13PM +0000, Lukas Straub wrote: > On Sun, 2 Apr 2023 17:55:59 +0000 > Lukas Straub <lukasstra...@web.de> wrote: > > > This series refactors the ram compress code. > > > > It first removes ram.c dependencies from the core compress code, then > > moves it out to its own file. Finally, on the migration destination side > > the initialisation and cleanup of compress threads is moved out of ram.c > > to migration.c. This allows using COLO with compress enabled. > > > > This series is based on the following series: > > https://lore.kernel.org/qemu-devel/af76761aa6978071c5b8e9b872b697db465a5520.1680457631.git.lukasstra...@web.de/T/#t > > > > Hmm, I'm wondering if I should add postcopy+compress tests in this > series? Because if we start this, the test matrix really will explode.
Do you perhaps mean when compress added to the existing (and already large) postcopy test matrix? I assume we can still add one for vanilla postcopy+compress, so it still covers the major parts. Or, add the compress test with the postcopy test with most features enabled? The most comprehensive one in qtest should be: /x86_64/migration/postcopy/preempt/recovery/tls/psk That covers postcopy+preempt+tls, meanwhile there'll be an emulation of network failure too during postcopy and test recovering from it. -- Peter Xu
