Re: [PATCH v4 0/7] Pegasos2 fixes and audio output support

2023-02-28 Thread Bernhard Beschow
Am 27. Februar 2023 22:12:46 UTC schrieb "Philippe Mathieu-Daudé" : >On 27/2/23 18:47, BALATON Zoltan wrote: >> On Mon, 27 Feb 2023, Bernhard Beschow wrote: >>> Unfortunately my patches had changes merged in. This now makes it hard to >>> show what really changed (spoiler: nothing that affects

Re: [PATCH v7 03/10] target/riscv: allow MISA writes as experimental

2023-02-28 Thread Bin Meng
On Thu, Feb 23, 2023 at 2:53 AM Daniel Henrique Barboza wrote: > > At this moment, and apparently since ever, we have no way of enabling > RISCV_FEATURE_MISA. This means that all the code from write_misa(), all > the nuts and bolts that handles how to properly write this CSR, has > always been a n

[PATCH v2] qapi: Add 'acpi' field to 'query-machines' output

2023-02-28 Thread Peter Krempa
Report which machine types support ACPI so that management applications can properly use the 'acpi' property even on platforms such as ARM where support for ACPI depends on the machine type and thus checking presence of '-machine acpi=' in 'query-command-line-options' is insufficient. Signed-off-b

Re: Adopting abandoned patch?

2023-02-28 Thread Daniel P . Berrangé
On Mon, Feb 27, 2023 at 04:34:12PM -0500, Dinah B wrote: > It looks like the author didn't include a "Signed off" in their patch draft > and it doesn't look like Debian qemu-kvm maintainers ever merged it. > Does this change the patch adoption process? > > On Mon, Feb 27, 2023 at 4:23 PM Dinah B w

Re: [PATCH 2/3] qga: Add optional `merge-output` flag to guest-exec qapi

2023-02-28 Thread Marc-André Lureau
Hi On Tue, Feb 28, 2023 at 5:15 AM Daniel Xu wrote: > > Hi, > > On Mon, Feb 27, 2023, at 1:22 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Feb 24, 2023 at 8:31 AM Daniel Xu wrote: > >> > >> Currently, the captured output (via `capture-output`) is segregated into > >> separate GuestExecSta

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote: > > > I feel like we should have separate deprecation entries for the > > > i686 host support, and for qemu-system-i3

[PATCH] ui/cocoa: Override windowDidResignKey

2023-02-28 Thread Akihiko Odaki
This fixes pressed keys being stuck when the deck is clicked and the window loses focus. In the past, Gustavo Noronha Silva also had a patch to fix this issue though it only ungrabs mouse and does not release keys, and depends on another out-of-tree patch: https://github.com/akihikodaki/qemu/pull/

[PATCH] ui/cocoa: Override windowDidResignKey

2023-02-28 Thread Akihiko Odaki
This fixes pressed keys being stuck when the deck is clicked and the window loses focus. In the past, Gustavo Noronha Silva also had a patch to fix this issue though it only ungrabs mouse and does not release keys, and depends on another out-of-tree patch: https://github.com/akihikodaki/qemu/pull/

[PATCH] ui/cocoa: Override windowDidResignKey

2023-02-28 Thread Akihiko Odaki
This fixes pressed keys being stuck when the deck is clicked and the window loses focus. In the past, Gustavo Noronha Silva also had a patch to fix this issue though it only ungrabs mouse and does not release keys, and depends on another out-of-tree patch: https://github.com/akihikodaki/qemu/pull/

Re: [PATCH v4 0/4] target/i386: Add new CPU model SapphireRapids and new fast string op leaves

2023-02-28 Thread Xiaoyao Li
On 2/27/2023 6:13 PM, Paolo Bonzini wrote: Sapphire Rapids enablement patches got stuck on the doubts regarding properties for AMX support. However, for now there is no need to have anything but hardcoded values, because all Intel processors with AMX currently support exactly the same palettes a

Re: [PATCH v14 15/60] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode

2023-02-28 Thread David Woodhouse
On Mon, 2023-02-27 at 23:37 +0100, Philippe Mathieu-Daudé wrote: > > +extern int pc_machine_kvm_type(MachineState *machine, const char *vm_type); > > No 'extern' qualifier for function prototype please. Fixed in my tree. Thanks. smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH] virtio-balloon: optimize the virtio-balloon on the ARM platform.

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 03:26:56AM +, Yangming wrote: > > > Optimize the virtio-balloon feature on the ARM platform by adding a > > > variable to keep track of the current hot-plugged pc-dimm size, > > > instead of traversing the virtual machine's memory modules to count > > > the current RAM s

Re: [PATCH] virtio-balloon: optimize the virtio-balloon on the ARM platform.

2023-02-28 Thread David Hildenbrand
On 28.02.23 09:56, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 03:26:56AM +, Yangming wrote: Optimize the virtio-balloon feature on the ARM platform by adding a variable to keep track of the current hot-plugged pc-dimm size, instead of traversing the virtual machine's memory modules to

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote: > > > > I feel like we should have separate

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: > On 2/27/23 10:12, Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote: > > > I feel like we should have separate deprecation entries for the > > > i686 host support, and for qemu-system

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: > > Removing support for building on 32 bit systems seems like a pity - it's > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > and the maintainance overhead is quite small. > > It's not that small. Me

Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 08:39:49AM +0100, Thomas Huth wrote: > On 27/02/2023 19.38, Daniel P. Berrangé wrote: > > On Mon, Feb 27, 2023 at 12:10:48PM +0100, Thomas Huth wrote: > > > We're struggling quite badly with our CI minutes on the shared > > > gitlab runners, so we urgently need to think of w

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > > On Mon, Feb 27, 2023 at 11:50:07AM

[PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Eric Auger
According to g_tree_foreach() documentation: "The tree may not be modified while iterating over it (you can't add/remove items)." Since glib2 has removed its custom slice allocator and has switched to using system malloc, a SIGSEGV can be observed while running test-vmstate. With glibc + MALLOC_PE

Re: [PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 10:03:52AM +0100, Eric Auger wrote: > According to g_tree_foreach() documentation: > "The tree may not be modified while iterating over it (you can't > add/remove items)." > > Since glib2 has removed its custom slice allocator and has switched > to using system malloc, a SI

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Thomas Huth
On 28/02/2023 10.03, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote: On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: On 27/02/2023 21.12, Michael S. Tsirkin wrote: On

Re: [PATCH v2 2/2] hw/riscv: Move the dtb load bits outside of create_fdt()

2023-02-28 Thread Daniel Henrique Barboza
On 2/28/23 04:45, Bin Meng wrote: Move the dtb load bits outside of create_fdt(), and put it explicitly in sifive_u_machine_init() and virt_machine_init(). With such change create_fdt() does exactly what its function name tells us. Suggested-by: Daniel Henrique Barboza Signed-off-by: Bin Men

[PATCH v4] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Eric Auger
According to g_tree_foreach() documentation: "The tree may not be modified while iterating over it (you can't add/remove items)." compare_trees()/diff_tree() fail to respect this rule. Historically GLib2 used a slice allocator for the GTree APIs which did not immediately release the memory back to

Re: [PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Eric Auger
Hi Daniel, On 2/28/23 10:12, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 10:03:52AM +0100, Eric Auger wrote: >> According to g_tree_foreach() documentation: >> "The tree may not be modified while iterating over it (you can't >> add/remove items)." >> >> Since glib2 has removed its custom s

[PATCH v3] target/arm: Add raw_writes ops for register whose write induce TLB maintenance

2023-02-28 Thread Eric Auger
Some registers whose 'cooked' writefns induce TLB maintenance do not have raw_writefn ops defined. If only the writefn ops is set (ie. no raw_writefn is provided), it is assumed the cooked also work as the raw one. For those registers it is not obvious the tlb_flush works on KVM mode so better/safe

[PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread Longpeng(Mike)
From: Longpeng The kvm_irqchip_commit_routes() is a time-intensive operation, it needs scan and update all irqfds that are already assigned during each invocation, so more vectors means need more time to process them. For virtio-pci, we can just submit once when enabling vectors of a virtio-pci d

[PATCH v1 0/3] virtio-pci: optimize set_guest_notifier

2023-02-28 Thread Longpeng(Mike)
From: Longpeng This patchset optimizes the time-consuming operation in virtio_pci_set_guest_notifier, especially for the vhost-vdpa migration, the time spend on set_guest_notifier can reduce 87% in some cases. Longpeng (Mike) (3): virtio-pci: submit msi route changes in batch kvm-irqchip:

[PATCH v1 2/3] kvm-irqchip: use KVMRouteChange API to update msi route

2023-02-28 Thread Longpeng(Mike)
From: Longpeng The KVMRouteChange API is added by commit 9568690868e ("kvm-irqchip: introduce new API to support route change"). We can also apply it on kvm_irqchip_update_msi_route(), there are no functional changes and we can optimize the virtio-pci core base on this change in the next patch.

[PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread Longpeng(Mike)
From: Longpeng All unmasked vectors will be setup in msix_set_vector_notifiers(), which is a time-consuming operation because each vector need to be submit to KVM once. It's even worse if the VM has several devices and each devices has dozens of vectors. We can defer and commit the vectors in ba

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: > On 28/02/2023 10.03, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote: > > > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > > > > On Tue, Feb 28, 2023 at 08:49:09AM

Re: [PATCH 3/5] qmp: Added the helper stamp check.

2023-02-28 Thread Yuri Benditovich
On Mon, Feb 20, 2023 at 11:50 AM Daniel P. Berrangé wrote: > On Sun, Feb 19, 2023 at 06:20:58PM +0200, Andrew Melnychenko wrote: > > Added a function to check the stamp in the helper. > > eBPF helper should have a special symbol that generates during the build. > > QEMU checks the helper and dete

Re: [RFC PATCH 1/5] linux-headers: [kvm, arm64] add the necessary definitions to match host kernel

2023-02-28 Thread Miguel Luis
Hi Cornelia, > On 27 Feb 2023, at 15:49, Cornelia Huck wrote: > > On Mon, Feb 27 2023, Miguel Luis wrote: > >> From: Haibo Xu >> >> linux-headers define host properties needed for the VMM to interact with >> KVM, so let's include them *while* they're not available yet on linux >> upstream si

Re: [RFC PATCH v3 1/1] gitlab: Use plain docker in container-template.yml

2023-02-28 Thread Daniel P . Berrangé
On Mon, Feb 27, 2023 at 06:12:30PM -0300, Fabiano Rosas wrote: > Alex Bennée writes: > > > Fabiano Rosas writes: > > > >> Our dockerfiles no longer reference layers from other qemu images so > >> we can now use 'docker build' on them. > >> > >> Also reinstate the caching that was disabled due to

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 09:40:49AM +, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: > > On 28/02/2023 10.03, Michael S. Tsirkin wrote: > > > On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote: > > > > On Tue, Feb 28, 2023 at 03:19:20AM

Re: [RFC PATCH v3 1/1] gitlab: Use plain docker in container-template.yml

2023-02-28 Thread Daniel P . Berrangé
On Mon, Feb 27, 2023 at 12:11:10PM -0300, Fabiano Rosas wrote: > Our dockerfiles no longer reference layers from other qemu images so > we can now use 'docker build' on them. > > Also reinstate the caching that was disabled due to bad interactions > with certain runners. See commit 6ddc3dc7a8 ("te

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 05:39:35PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > The kvm_irqchip_commit_routes() is a time-intensive operation, it needs > scan and update all irqfds that are already assigned during each invocation, > so more vectors means need more time to process them. I th

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 05:39:35PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > The kvm_irqchip_commit_routes() is a time-intensive operation, it needs > scan and update all irqfds that are already assigned during each invocation, > so more vectors means need more time to process them. For v

Re: [RFC PATCH v3 1/1] gitlab: Use plain docker in container-template.yml

2023-02-28 Thread Alex Bennée
Fabiano Rosas writes: > Alex Bennée writes: > >> Fabiano Rosas writes: >> > > There are issues pointing to some general unreliability of the cache: > > https://github.com/moby/buildkit/issues/2274 > https://github.com/moby/buildkit/issues/1981 > > What is your docker version? Mine is 20.10.1

Re: [RFC PATCH v3 0/1] ci: Speed up container stage

2023-02-28 Thread Alex Bennée
Fabiano Rosas writes: > > What do you think? > > Fabiano Rosas (1): > gitlab: Use plain docker in container-template.yml > > .gitlab-ci.d/container-template.yml | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Queued to testing/next, thanks. -- Alex Bennée Virtualisation

Re: [PATCH 3/7] tests/lcitool: append user setting stanza to dockerfiles

2023-02-28 Thread Daniel P . Berrangé
On Fri, Feb 24, 2023 at 06:08:53PM +, Alex Bennée wrote: > For the cross-compilation use-case it is important to add the host > user to the dockerfile so we can map them to the docker environment > when cross-building files. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.d/cirrus/freebsd-

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Feb 28, 2023 at 09:40:49AM +, Daniel P. Berrangé wrote: >> On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: >> > On 28/02/2023 10.03, Michael S. Tsirkin wrote: >> > > On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote: >> > >

Re: [PATCH 4/7] tests/docker: add USER stanzas to non-lci images

2023-02-28 Thread Daniel P . Berrangé
On Fri, Feb 24, 2023 at 06:08:54PM +, Alex Bennée wrote: > These are flat but not generated by lcitool so we need to manually > update them with the `useradd` stanza. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-all-test-cross.docker | 5 + > tests/docker/do

Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 05:39:37PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > All unmasked vectors will be setup in msix_set_vector_notifiers(), which > is a time-consuming operation because each vector need to be submit to > KVM once. It's even worse if the VM has several devices and each

Re: [PATCH 5/7] tests/docker: use direct RUNC call to build containers

2023-02-28 Thread Daniel P . Berrangé
On Fri, Feb 24, 2023 at 06:08:55PM +, Alex Bennée wrote: > We don't really need stuff from docker.py to do the build as we have > everything we need with a direct call. We do rely on the dockerfiles > being able to tweak the UID/name mapping as the last step. > > Signed-off-by: Alex Bennée >

[PATCH v2 00/18] target/riscv: Various fixes to gdbstub and CSR access

2023-02-28 Thread Bin Meng
At present gdbstub reports an incorrect / incomplete CSR list in the target description XML, for example: - menvcfg is reported in 'sifive_u' machine - fcsr is missing in a F/D enabled processor The issue is caused by: - priv spec version check is missing when reporting CSRs - CSR predicate() rou

Re: [PATCH v4] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Juan Quintela
Eric Auger wrote: > According to g_tree_foreach() documentation: > "The tree may not be modified while iterating over it (you can't > add/remove items)." > > compare_trees()/diff_tree() fail to respect this rule. > Historically GLib2 used a slice allocator for the GTree APIs > which did not immedi

[PATCH v2 01/18] target/riscv: gdbstub: Check priv spec version before reporting CSR

2023-02-28 Thread Bin Meng
The gdbstub CSR XML is dynamically generated according to the result of the CSR predicate() result. This has been working fine until commit 7100fe6c2441 ("target/riscv: Enable privileged spec version 1.12") introduced the privilege spec version check in riscv_csrrw_check(). When debugging the 'sif

[PATCH v2 02/18] target/riscv: Add some comments to clarify the priority policy of riscv_csrrw_check()

2023-02-28 Thread Bin Meng
The priority policy of riscv_csrrw_check() was once adjusted in commit eacaf4401956 ("target/riscv: Fix priority of csr related check in riscv_csrrw_check") whose commit message says the CSR existence check should come before the access control check, but the code changes did not agree with the co

[PATCH v2 03/18] target/riscv: Use g_assert() for the predicate() NULL check

2023-02-28 Thread Bin Meng
At present riscv_csrrw_check() checks the CSR predicate() against NULL and throws RISCV_EXCP_ILLEGAL_INST if it is NULL. But this is a pure software check, and has nothing to do with the emulation of the hardware behavior, thus it is inappropriate to return illegal instruction exception when softwa

[PATCH v2 04/18] target/riscv: gdbstub: Minor change for better readability

2023-02-28 Thread Bin Meng
Use a variable 'base_reg' to represent cs->gdb_num_regs so that the call to ricsv_gen_dynamic_vector_xml() can be placed in one single line for better readability. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/gdbstub.c | 4 ++--

Re: [PATCH 6/7] tests/docker: use direct RUNC call to run test jobs

2023-02-28 Thread Daniel P . Berrangé
On Fri, Feb 24, 2023 at 06:08:56PM +, Alex Bennée wrote: > If we build them without the script we can certainly run them without > it. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Ber

[PATCH v2 05/18] target/riscv: gdbstub: Do not generate CSR XML if Zicsr is disabled

2023-02-28 Thread Bin Meng
There is no need to generate the CSR XML if the Zicsr extension is not enabled. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/gdbstub.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/riscv/gd

[PATCH v2 06/18] target/riscv: Coding style fixes in csr.c

2023-02-28 Thread Bin Meng
Fix various places that violate QEMU coding style: - correct multi-line comment format - indent to opening parenthesis Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/csr.c | 62 -- 1 f

Re: [RFC] CXL: TCG/KVM instruction alignment issue discussion default

2023-02-28 Thread Jonathan Cameron via
On Mon, 27 Feb 2023 11:06:47 + Jørgen Hansen wrote: > On 2/18/23 11:22, Gregory Price wrote: > > Breaking this off into a separate thread for archival sake. > > > > There's a bug with handling execution of instructions held in CXL > > memory - specifically when an instruction crosses a page

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > The question to answer: Is 32 bit x86 worth its upkeep? Two > sub-questions: 1. Is it worth the human attention? 2. Is it worth > (scarce!) CI minutes? 3. Is it worth arguing about? -- MST

Re: [PATCH 7/7] tests/gitlab: use kaniko to build images

2023-02-28 Thread Daniel P . Berrangé
On Fri, Feb 24, 2023 at 06:08:57PM +, Alex Bennée wrote: > Apparently the docker-in-docker approach has some flaws including > needing privileged mode to run and being quite slow. An alternative > approach is to use Google's kaniko tool. It also works across > different gitlab executors. Inter

Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 05:40:33AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 05:39:37PM +0800, Longpeng(Mike) wrote: > > From: Longpeng > > > > All unmasked vectors will be setup in msix_set_vector_notifiers(), which > > is a time-consuming operation because each vector need to b

Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread longpeng2--- via
在 2023/2/28 18:40, Michael S. Tsirkin 写道: On Tue, Feb 28, 2023 at 05:39:37PM +0800, Longpeng(Mike) wrote: From: Longpeng All unmasked vectors will be setup in msix_set_vector_notifiers(), which is a time-consuming operation because each vector need to be submit to KVM once. It's even worse

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Juan Quintela
"John Berberian, Jr" wrote: > ping. Is there anything I can do to help this get merged? Hi I have to get back from Marc/Daniel before proceed. You did an answer, but they didn't respond. What should we do here? Thanks, Juan. > Best regards, > John Berberian, Jr.

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Thomas Huth
On 28/02/2023 11.51, Michael S. Tsirkin wrote: On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: The question to answer: Is 32 bit x86 worth its upkeep? Two sub-questions: 1. Is it worth the human attention? 2. Is it worth (scarce!) CI minutes? 3. Is it worth arguing about?

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread longpeng2--- via
在 2023/2/28 18:17, Michael S. Tsirkin 写道: On Tue, Feb 28, 2023 at 05:39:35PM +0800, Longpeng(Mike) wrote: From: Longpeng The kvm_irqchip_commit_routes() is a time-intensive operation, it needs scan and update all irqfds that are already assigned during each invocation, so more vectors means

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Jan 31, 2023 at 02:01:07PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 17, 2023 at 9:07 PM John Berberian, Jr > wrote: > > > > Apologies for the late response, I was traveling most of yesterday. > > > > On 1/16/23 4:22 AM, Daniel P. Berrangé wrote: > > > When we introduce a new

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 12:12:22PM +0100, Thomas Huth wrote: > On 28/02/2023 11.51, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > > > The question to answer: Is 32 bit x86 worth its upkeep? Two > > > sub-questions: 1. Is it worth the human atten

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 12:11:05PM +0100, Juan Quintela wrote: > "John Berberian, Jr" wrote: > > ping. Is there anything I can do to help this get merged? > > Hi > > I have to get back from Marc/Daniel before proceed. > > You did an answer, but they didn't respond. > > What should we do here?

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread longpeng2--- via
在 2023/2/28 18:18, Michael S. Tsirkin 写道: On Tue, Feb 28, 2023 at 05:39:35PM +0800, Longpeng(Mike) wrote: From: Longpeng The kvm_irqchip_commit_routes() is a time-intensive operation, it needs scan and update all irqfds that are already assigned during each invocation, so more vectors means

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 06:24:02AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 12:12:22PM +0100, Thomas Huth wrote: > > On 28/02/2023 11.51, Michael S. Tsirkin wrote: > > > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > > > > The question to answer: Is 32 bit x8

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: >> The question to answer: Is 32 bit x86 worth its upkeep? Two >> sub-questions: 1. Is it worth the human attention? 2. Is it worth >> (scarce!) CI minutes? > > 3. Is it worth arguing about? If it

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Juan Quintela
Juan Quintela wrote: > "John Berberian, Jr" wrote: >> ping. Is there anything I can do to help this get merged? > > Hi > > I have to get back from Marc/Daniel before proceed. > > You did an answer, but they didn't respond. > > What should we do here? > > Thanks, Juan. Reviewed-by: Juan Quintela

Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 07:10:36PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > Oh, I really envy you because I can not use it in my workspace. Thank you > for your correction. :( I keep seeing these adverts for grammarly, try this maybe :) -- MST

Re: [PATCH 2/7] tests/dockerfiles: unify debian-toolchain references

2023-02-28 Thread Philippe Mathieu-Daudé
On 24/2/23 19:08, Alex Bennée wrote: We use the debian release number elsewhere so fix it for consistency along with the broken comment. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-toolchain.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ph

[PATCH] MAINTAINERS: Add Fan Ni as Compute eXpress Link QEMU reviewer

2023-02-28 Thread Jonathan Cameron via
Fan Ni has offered to help out with QEMU CXL emulation reviewing. Add him as a designated reviewer. Signed-off-by: Jonathan Cameron -- Thanks to Fan for stepping up after I requested help following Ben stepping down as co-maintainer. Fan base been active in testing and review recently so great t

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread longpeng2--- via
在 2023/2/28 19:20, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) 写道: 在 2023/2/28 18:17, Michael S. Tsirkin 写道: On Tue, Feb 28, 2023 at 05:39:35PM +0800, Longpeng(Mike) wrote: From: Longpeng The kvm_irqchip_commit_routes() is a time-intensive operation, it needs scan and up

Re: [PATCH 4/7] tests/docker: add USER stanzas to non-lci images

2023-02-28 Thread Philippe Mathieu-Daudé
On 24/2/23 19:08, Alex Bennée wrote: These are flat but not generated by lcitool so we need to manually update them with the `useradd` stanza. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-all-test-cross.docker | 5 + tests/docker/dockerfiles/debian-alpha-cross.docke

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 12:35:02PM +0100, Juan Quintela wrote: > Juan Quintela wrote: > > "John Berberian, Jr" wrote: > >> ping. Is there anything I can do to help this get merged? > > > > Hi > > > > I have to get back from Marc/Daniel before proceed. > > > > You did an answer, but they didn't re

Re: [PATCH 4/7] tests/docker: add USER stanzas to non-lci images

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 12:43:01PM +0100, Philippe Mathieu-Daudé wrote: > On 24/2/23 19:08, Alex Bennée wrote: > > These are flat but not generated by lcitool so we need to manually > > update them with the `useradd` stanza. > > > > Signed-off-by: Alex Bennée > > --- > > tests/docker/dockerfile

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 12:34:19PM +0100, Markus Armbruster wrote: > If it's not worth arguing, then we merge Thomas's patch. I don't mind but it's just a doc patch isn't it? If what we want to do is to stop doing make check on a 32 bit container and just to do make then let's patch the relevant y

Re: Fortnightly KVM call for 2023-02-07

2023-02-28 Thread Juan Quintela
Sean Christopherson wrote: > On Tue, Jan 24, 2023, Juan Quintela wrote: >> Please, send any topic that you are interested in covering in the next >> call in 2 weeks. >> >> We have already topics: >> - single qemu binary >> People on previous call (today) asked if Markus, Paolo and Peter could >

Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 09:01:46AM +, Daniel P. Berrangé wrote: > If we're merely wanting to drop CI support, we can do that any time and > deprecation is not required/expected. We should only be using deprecation > where we're explicitly intending that the code will cease to work. Good point

Re: [PATCH v15 3/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2023-02-28 Thread Kevin Wolf
Am 27.02.2023 um 20:14 hat Stefan Hajnoczi geschrieben: > On Mon, Feb 27, 2023 at 07:20:14PM +0100, Kevin Wolf wrote: > > Am 29.01.2023 um 11:28 hat Sam Li geschrieben: > > > Add zoned device option to host_device BlockDriver. It will be presented > > > only > > > for zoned host block devices. By

Re: [PATCH 1/7] configure: expose the direct container command

2023-02-28 Thread Philippe Mathieu-Daudé
On 24/2/23 19:08, Alex Bennée wrote: In the process of migrating away from using docker.py to build our containers we need to expose the command to the build environment. The script is still a useful way to probe which command works though. Signed-off-by: Alex Bennée --- configure | 3 +++ 1

Re: [PATCH 5/7] tests/docker: use direct RUNC call to build containers

2023-02-28 Thread Philippe Mathieu-Daudé
On 24/2/23 19:08, Alex Bennée wrote: We don't really need stuff from docker.py to do the build as we have everything we need with a direct call. We do rely on the dockerfiles being able to tweak the UID/name mapping as the last step. Signed-off-by: Alex Bennée --- tests/docker/Makefile.includ

Re: [PATCH 0/7] testing/next: docker.py removal and kaniko updates

2023-02-28 Thread Philippe Mathieu-Daudé
On 24/2/23 19:08, Alex Bennée wrote: This series attempts to remove our dependence on the docker.py script and build things directly with the appropriate tool. I've been noodling around with how we build images on gitlab to see if they can cache better because the normal case should be we don't n

Re: [PATCH] MAINTAINERS: Add Fan Ni as Compute eXpress Link QEMU reviewer

2023-02-28 Thread Philippe Mathieu-Daudé
On 28/2/23 12:39, Jonathan Cameron via wrote: Fan Ni has offered to help out with QEMU CXL emulation reviewing. Add him as a designated reviewer. Signed-off-by: Jonathan Cameron -- Thanks to Fan for stepping up after I requested help following Ben stepping down as co-maintainer. Fan base been

Re: [PATCH v15 3/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2023-02-28 Thread Sam Li
Kevin Wolf 于2023年2月28日周二 19:54写道: > > Am 27.02.2023 um 20:14 hat Stefan Hajnoczi geschrieben: > > On Mon, Feb 27, 2023 at 07:20:14PM +0100, Kevin Wolf wrote: > > > Am 29.01.2023 um 11:28 hat Sam Li geschrieben: > > > > Add zoned device option to host_device BlockDriver. It will be > > > > present

Re: [PATCH v2 02/18] target/riscv: Add some comments to clarify the priority policy of riscv_csrrw_check()

2023-02-28 Thread liweiwei
On 2023/2/28 18:40, Bin Meng wrote: The priority policy of riscv_csrrw_check() was once adjusted in commit eacaf4401956 ("target/riscv: Fix priority of csr related check in riscv_csrrw_check") whose commit message says the CSR existence check should come before the access control check, but th

Re: [PATCH v7 03/10] target/riscv: allow MISA writes as experimental

2023-02-28 Thread liweiwei
On 2023/2/23 02:51, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and bolts that handles how to properly write this CSR, has always been a no-op as well becaus

Re: [PATCH v1 1/3] virtio-pci: submit msi route changes in batch

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 07:39:06PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > 在 2023/2/28 19:20, Longpeng (Mike, Cloud Infrastructure Service Product > Dept.) 写道: > > > > > > 在 2023/2/28 18:17, Michael S. Tsirkin 写道: > > > On Tue, Feb 28, 2023 at 05:39:35PM

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-02-28 Thread Joao Martins
On 23/02/2023 21:50, Alex Williamson wrote: > On Thu, 23 Feb 2023 21:19:12 + > Joao Martins wrote: >> On 23/02/2023 21:05, Alex Williamson wrote: >>> On Thu, 23 Feb 2023 10:37:10 + >>> Joao Martins wrote: On 22/02/2023 22:10, Alex Williamson wrote: > On Wed, 22 Feb 2023 19:49

[PATCH v2 10/18] target/riscv: Avoid reporting odd-numbered pmpcfgX in the CSR XML for RV64

2023-02-28 Thread Bin Meng
At present the odd-numbered PMP configuration registers for RV64 are reported in the CSR XML by QEMU gdbstub. However these registers do not exist on RV64 so trying to access them from gdb results in 'E14'. Move the pmpcfgX index check from the actual read/write routine to the PMP CSR predicate()

[PATCH v2 07/18] target/riscv: Use 'bool' type for read_only

2023-02-28 Thread Bin Meng
The read_only variable is currently declared as an 'int', but it should really be a 'bool'. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/csr

[PATCH v2 08/18] target/riscv: Simplify {read, write}_pmpcfg() a little bit

2023-02-28 Thread Bin Meng
Use the register index that has already been calculated in the pmpcfg_csr_{read,write} call. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/csr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/risc

[PATCH v2 11/18] target/riscv: gdbstub: Turn on debugger mode before calling CSR predicate()

2023-02-28 Thread Bin Meng
Since commit 94452ac4cf26 ("target/riscv: remove fflags, frm, and fcsr from riscv-*-fpu.xml") the 3 FPU CSRs are removed from the XML target decription. The original intent of that commit was based on the assumption that the 3 FPU CSRs will show up in the riscv-csr.xml so the ones in riscv-*-fpu.x

[PATCH v2 09/18] target/riscv: Simplify getting RISCVCPU pointer from env

2023-02-28 Thread Bin Meng
Use env_archcpu() to get RISCVCPU pointer from env directly. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes since v1) target/riscv/csr.c | 36 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/target/r

Re: [PATCH v2 03/18] target/riscv: Use g_assert() for the predicate() NULL check

2023-02-28 Thread liweiwei
On 2023/2/28 18:40, Bin Meng wrote: At present riscv_csrrw_check() checks the CSR predicate() against NULL and throws RISCV_EXCP_ILLEGAL_INST if it is NULL. But this is a pure software check, and has nothing to do with the emulation of the hardware behavior, thus it is inappropriate to return i

Re: [PATCH 4/7] tests/docker: add USER stanzas to non-lci images

2023-02-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 24/2/23 19:08, Alex Bennée wrote: >> These are flat but not generated by lcitool so we need to manually >> update them with the `useradd` stanza. >> Signed-off-by: Alex Bennée >> --- >> tests/docker/dockerfiles/debian-all-test-cross.docker | 5 + >>

Re: [PATCH 4/7] tests/docker: add USER stanzas to non-lci images

2023-02-28 Thread Philippe Mathieu-Daudé
On 28/2/23 13:18, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 24/2/23 19:08, Alex Bennée wrote: These are flat but not generated by lcitool so we need to manually update them with the `useradd` stanza. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-all-test-cross

Re: [RFC PATCH 4/5] target/arm: enable feature ARM_FEATURE_EL2 if EL2 is supported

2023-02-28 Thread Miguel Luis
Hi Richard, > On 27 Feb 2023, at 18:24, Richard Henderson > wrote: > > On 2/27/23 06:37, Miguel Luis wrote: >> From: Haibo Xu >> KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2. >> EL2 bits on ID_AA64PFR0 state unsupported on the value 0b. >> Ref: >> https://lore.ke

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Philippe Mathieu-Daudé
On 28/2/23 09:59, Michael S. Tsirkin wrote: On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: On 2/27/23 10:12, Michael S. Tsirkin wrote: On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote: I feel like we should have separate deprecation entries for the i686 ho

Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 11:07:21AM +, Daniel P. Berrangé wrote: > IMHO it is not appropriate to criticize the writing of people > who may not have English as a first language. Sorry if I offended anyone. I do want change log messages to be clear and unambigous though since they are a permanen

Re: [RFC PATCH 5/5] arm/virt: provide virtualization extensions to the guest

2023-02-28 Thread Miguel Luis
Hi Richard, > On 27 Feb 2023, at 18:26, Richard Henderson > wrote: > > On 2/27/23 06:37, Miguel Luis wrote: >> -if (vms->virt && (kvm_enabled() || hvf_enabled())) { >> +if (vms->virt && (kvm_enabled() || hvf_enabled()) >> +&& !kvm_arm_el2_supported()) { > > The ordering of the

  1   2   3   4   >