Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> The device field is redundant, because QOM path always include device > >> ID when this ID exist. > > > > The

Re: [PATCH 09/18] target/riscv: Avoid reporting odd-numbered pmpcfgX in the CSR XML for RV64

On 2023/2/14 02:02, Bin Meng wrote: At present the odd-numbered PMP configuration registers for RV64 are reported in the CSR XML by QEMU gdbstub. However these registers do not exist on RV64 so trying to access them from gdb results in 'E14'. Move the pmpcfgX index check from the actual read/wr

Re: [PATCH v4 01/16] pci/shpc: set attention led to OFF on reset

On 13.02.23 17:16, Philippe Mathieu-Daudé wrote: On 13/2/23 15:00, Vladimir Sementsov-Ogievskiy wrote: 0 is not a valid state for the led. Let's start with OFF. "0 is not valid" so we should abort(value != 0) in shpc_set_status(), Signed-off-by: Vladimir Sementsov-Ogievskiy ---   hw/pci/shp

RE: [RFC 25/52] mips: Replace MachineState.smp access with topology helpers

> From: Zhao Liu > Sent: Monday, February 13, 2023 5:50 PM > To: Eduardo Habkost ; Marcel Apfelbaum > ; Philippe Mathieu-Daudé ; > Yanan Wang ; Michael S . Tsirkin > ; Richard Henderson ; Paolo > Bonzini ; Eric Blake ; Markus > Armbruster > Cc: qemu-devel@nongnu.org; Wang, Zhenyu Z ; Mi, > Dapeng

Re: [RFC 05/52] hw/core/machine: Rename machine-smp.c to machine-topo.c

On Mon, Feb 13, 2023 at 08:52:13PM +0800, wangyanan (Y) wrote: > Date: Mon, 13 Feb 2023 20:52:13 +0800 > From: "wangyanan (Y)" > Subject: Re: [RFC 05/52] hw/core/machine: Rename machine-smp.c to > machine-topo.c > > Hi Zhao， > 在 2023/2/13 17:49, Zhao Liu 写道: > > From: Zhao Liu > > > > Hybrid t

Re: [Patch 13/14] target/riscv: Simplify check for EEW = 64 in trans_rvv.c.inc

On 2/14/23 05:38, Weiwei Li wrote: Only V extension support EEW = 64 in these case: Zve64* extensions don't support EEW = 64 as commented "as commented" where? In the previous patch? Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- The code LGTM. Reviewed-by: Daniel Henriqu

[PULL 06/22] hw/misc/sga: Remove the deprecated "sga" device

It's been deprecated since QEMU v6.2, so it should be OK to finally remove this now. Message-Id: <20230209161540.1054669-1-th...@redhat.com> Reviewed-by: Juan Quintela Acked-by: Gerd Hoffmann Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - docs/about/deprecated.rst

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

On Tue, Feb 14, 2023 at 12:49 PM Daniel P. Berrangé wrote: > [quote] > The motivation for this series is that Python 3.6 was EOL at the end of > 2021; upstream tools are beginning to drop support for it, including > setuptools, pylint, mypy, etc. As time goes by, it becomes more > difficult to sup

Re: [PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

Am 14.02.2023 um 13:22 hat Stefano Garzarella geschrieben: > On Tue, Feb 14, 2023 at 12:56 PM Kevin Wolf wrote: > > > > Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben: > > > bdrv_append() is called with bs_top AioContext held, but > > > bdrv_attach_child_noperm() could change the AioCon

Re: [RFC v5 1/3] rcu: introduce rcu_read_is_locked()

Hi, Paolo! On 2023/2/2 下午6:59, Juan Quintela wrote: Chuang Xu wrote: add rcu_read_is_locked() to detect holding of rcu lock. Signed-off-by: Chuang Xu Reviewed-by: Juan Quintela Althought I think that petting a review from Paolo or anyone that knows more than RCU could be a good idea. --

Re: [PATCH 07/18] target/riscv: Simplify {read,write}_pmpcfg() a little bit

On 2023/2/14 02:02, Bin Meng wrote: Use the register index that has already been calculated in the pmpcfg_csr_{read,write} call. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Regards, Weiwei Li --- target/riscv/csr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH v10 46/59] hw/xen: Implement GNTTABOP_query_size

On 01/02/2023 14:31, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_gnttab.c | 19 +++ hw/i386/kvm/xen_gnttab.h | 2 ++ target/i386/kvm/xen-emu.c | 16 +++- 3 files changed, 36 insertions(+), 1 deletion(-)

[Patch 02/14] target/riscv: Fix the relationship between Zhinxmin and Zhinx

Just like zfh and zfhmin, Zhinxmin is part of Zhinx so Zhinxmin will be enabled when Zhinx is enabled Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c i

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

Markus Armbruster writes: > Daniel P. Berrangé writes: > >> On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: >>> On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: >>> > Daniel P. Berrangé writes: >>> > >>> > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Semen

[PULL 02/22] meson: Add missing libdw knobs

From: Ilya Leoshkevich Add the missing meson infrastructure bits for the new libdw dependency. Model them after the existing capstone knobs. Fixes: 7c10cb38ccb8 ("accel/tcg: Add debuginfo support") Reported-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Reviewed-by: Thomas Huth Message-Id: <

Re: [qemu-web PATCH] add language to tag

On 14/02/2023 13.25, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- _layouts/blog.html | 2 +- _layouts/home.html | 2 +- _layouts/page.html | 2 +- _plugins/alias_generator.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_layouts

[PULL 10/22] tests/qtest: Do not run lsi53c895a test if device is not present

From: Fabiano Rosas The tests are built once for all the targets, so as long as one QEMU binary is built with CONFIG_LSI_SCSI_PCI=y, this test will run. However some binaries might not include the device. So check this again in runtime. Signed-off-by: Fabiano Rosas Message-Id: <20230208194700.1

[Patch 10/14] target/riscv: Remove rebundunt check for zve32f and zve64f

Require_zve32/64f have been overlapped by require_rvf/require_scale_rvf Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvv.c.inc | 128 1 file changed, 21 insertions(+), 107 deletions(-) diff --git a/target/riscv/insn_trans/tran

[PATCH 04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code

The Q35 PCI host currently sets the PC machine's PCI bus attribute through global state, thereby assuming the machine to be a PC machine. The Q35 machine code already holds on to Q35's pci bus attribute, so can easily set its own property while preserving encapsulation. Signed-off-by: Bernhard Bes

Re: QAPI unions as branches / unifying struct and union types

Het Gala writes: > On 10/02/23 12:54 pm, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> [...] >> +## +# @MigrateAddress: +# +# The options available for communication transport mechanisms for migration +# +# Since 8.0 +## +{ 'union' : '

Re: [PATCH 14/18] target/riscv: Allow debugger to access {h, s}stateen CSRs

On 2023/2/14 11:06, Bin Meng wrote: At present {h,s}stateen CSRs are not reported in the CSR XML hence gdb cannot access them. Fix it by adjusting their predicate() routine logic so that the static config check comes before the run-time check, as well as addding a debugger check. Signed-off-b

Re: [Patch 12/14] target/riscv: Fix check for vectore load/store instructions when EEW=64

Nit in the title: I believe you meant vector. "Vettore" would be fine too. On 2/14/23 05:38, Weiwei Li wrote: The V extension supports all vector load and store instructions except the V extension does not support EEW=64 for index values when XLEN=32 (Section 18.3) Signed-off-by: Weiwei Li Sig

[PULL 05/10] hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value

From: Fiona Ebner Currently, VMXNET3_MAX_MTU itself (being 9000) is not considered a valid value for the MTU, but a guest running ESXi 7.0 might try to set it and fail the assert [0]. In the Linux kernel, dev->max_mtu itself is a valid value for the MTU and for the vmxnet3 driver it's 9000, so a

Re: [Patch 06/14] target/riscv: Add propertie check for Zvfh{min} extensions

On 2/14/23 05:38, Weiwei Li wrote: Add check for Zvfh and Zvfhmin Nit: Missing period in the end. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/cpu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a

[PATCH v4 4/4] tests/tcg/linux-test: Add linux-fork-trap test

Check that dying due to a signal does not deadlock. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/linux/linux-fork-trap.c | 51 + 1 file changed, 51 insertions(+) create mode 100644 tests/tcg/multiarch/linux

[PATCH v4 0/4] Fix deadlock when dying because of a signal

Based-on: <20230202005204.2055899-1-richard.hender...@linaro.org> ("[PATCH 00/14] linux-user/sparc: Handle missing traps") v3: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg03534.html v3 -> v4: Add printfs to the test in order to make the uncaught signals less scary:

[Patch 12/14] target/riscv: Fix check for vectore load/store instructions when EEW=64

The V extension supports all vector load and store instructions except the V extension does not support EEW=64 for index values when XLEN=32 (Section 18.3) Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvv.c.inc | 9 - 1 file changed, 4 insertio

Re: [PATCH 1/1] readline: fix hmp completion issue

On 07/02/2023 05.52, Dongli Zhang wrote: Subject: [PATCH 1/1] readline: fix hmp completion issue From: Dongli Zhang Date: 07/02/2023, 05.52 To: qemu-devel@nongnu.org CC: dgilb...@redhat.com, joe@oracle.com The auto completion does not work in some cases. Case 1. 1. (qemu) info reg 2. Pr

Re: [Patch 09/14] target/riscv: Replace check for F/D to Zve32f/Zve64d in trans_rvv.c.inc

On 2/14/23 05:38, Weiwei Li wrote: Check for Zve32f/Zve64d can overlap check for F/D Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/insn_trans/trans_rvv.c.inc | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Patch 06/14] target/riscv: Add propertie check for Zvfh{min} extensions

Add check for Zvfh and Zvfhmin Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 4797ef9c42..8fe76707a0 100644 --- a/target/riscv/cpu.c +++ b/target/riscv

[PULL 09/22] tests/qtest: Skip PXE tests for missing devices

From: Fabiano Rosas Check if the devices we're trying to add are present in the QEMU binary. They could have been removed from the build via Kconfig or the --without-default-devices option. Signed-off-by: Fabiano Rosas Message-Id: <20230208194700.11035-2-faro...@suse.de> Reviewed-by: Thomas Hut

[Patch 07/14] target/riscv: Indent fixes in cpu.c

Fix indent problems in vector related check Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 8fe76707a0..7

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

Am 14.02.2023 um 08:40 hat Markus Armbruster geschrieben: > I read this on Friday, and decided to let it sit until after the > weekend. Well, it's now Tuesday, and to be frank, it's still as > offensively flippant as it was on Friday. It shows either ignorance of > or cavalier disregard for the s

[PATCH v4 2/4] cpus: Make {start,end}_exclusive() recursive

Currently dying to one of the core_dump_signal()s deadlocks, because dump_core_and_abort() calls start_exclusive() two times: first via stop_all_tasks(), and then via preexit_cleanup() -> qemu_plugin_user_exit(). There are a number of ways to solve this: resume after dumping core; check cpu_in_exc

Re: [Patch 08/14] target/riscv: Simplify check for Zve32f and Zve64f

On 2/14/23 05:38, Weiwei Li wrote: Zve64f depends on Zve32f, so we can only check Zve32f in these cases Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/insn_trans/trans_rvv.c.inc | 8 ++-- 1 file changed, 2 insertions(

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: > On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > >> The device field is redundant, beca

[Patch 03/14] target/riscv: Simplify the check for Zfhmin and Zhinxmin

We needn't check Zfh and Zhinx in these instructions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvzfh.c.inc | 25 +++ 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvzfh.c.inc b/tar

Re: [PATCH v4 15/16] qapi: add HOTPLUG_STATE event

Philippe Mathieu-Daudé writes: > On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote: >> For PCIe and SHPC hotplug it's important to track led indicators, >> especially the power led. Add an event that helps. >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> qapi/qdev.json

Re: [PATCH 16/18] target/riscv: Drop priv level check in mseccfg predicate()

On 2023/2/14 12:12, Bin Meng wrote: riscv_csrrw_check() already does the generic privilege level check hence there is no need to do the specific M-mode access check in the mseccfg predicate(). With this change debugger can access the mseccfg CSR anytime. Signed-off-by: Bin Meng Reviewed-by:

[PATCH v4 1/4] linux-user: Always exit from exclusive state in fork_end()

fork()ed processes currently start with current_cpu->in_exclusive_context set, which is, strictly speaking, not correct, but does not cause problems (even assertion failures). With one of the next patches, the code begins to rely on this value, so fix it by always calling end_exclusive() in fork_e

Re: [PATCH 01/18] target/riscv: gdbstub: Check priv spec version before reporting CSR

On 2023/2/14 02:01, Bin Meng wrote: The gdbstub CSR XML is dynamically generated according to the result of the CSR predicate() result. This has been working fine until commit 7100fe6c2441 ("target/riscv: Enable privileged spec version 1.12") introduced the privilege spec version check in riscv

[PULL 02/10] net: Restore printing of the help text with "-nic help"

From: Thomas Huth Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions (it showed the available netdev backends), but this feature got broken during some refactoring in version 6.0. Let's restore the old behavior, and while we're at it, let's also print the available NIC mo

Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology

On 14/2/23 10:30, Zhao Liu wrote: On Mon, Feb 13, 2023 at 02:10:17PM +0100, Philippe Mathieu-Daudé wrote: Date: Mon, 13 Feb 2023 14:10:17 +0100 From: Philippe Mathieu-Daudé Subject: Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology On 13/2/23 10:49, Zhao Liu wrote: From: Zhao Liu For sm

Re: [PATCH v10 47/59] i386/xen: handle PV timer hypercalls

On 01/02/2023 14:31, David Woodhouse wrote: From: Joao Martins Introduce support for one shot and periodic mode of Xen PV timers, whereby timer interrupts come through a special virq event channel with deadlines being set through: 1) set_timer_op hypercall (only oneshot) 2) vcpu_op hypercall f

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: >> On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: >> > Daniel P. Berrangé writes: >> > >> > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy >> > > wrote: >> > >

Re: [PATCH 02/18] target/riscv: Correct the priority policy of riscv_csrrw_check()

On 2023/2/14 02:01, Bin Meng wrote: The priority policy of riscv_csrrw_check() was once adjusted in commit eacaf4401956 ("target/riscv: Fix priority of csr related check in riscv_csrrw_check") whose commit message says the CSR existence check should come before the access control check, but th

Re: [PATCH 12/18] target/riscv: Allow debugger to access user timer and counter CSRs

On 2023/2/14 09:09, Bin Meng wrote: At present user timer and counter CSRs are not reported in the CSR XML hence gdb cannot access them. Fix it by addding a debugger check in their predicate() routine. typo: adding Otherwise, Reviewed-by: Weiwei Li Regards, Weiwei Li Signed-off-by: Bin

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

On Tue, 14 Feb 2023 at 07:40, Markus Armbruster wrote: > I read this on Friday, and decided to let it sit until after the > weekend. Well, it's now Tuesday, and to be frank, it's still as > offensively flippant as it was on Friday. It shows either ignorance of > or cavalier disregard for the she

Re: [RFC 00/52] Introduce hybrid CPU topology

On Mon, Feb 13, 2023 at 10:14:22AM +, Alex Bennée wrote: > Date: Mon, 13 Feb 2023 10:14:22 + > From: Alex Bennée > Subject: Re: [RFC 00/52] Introduce hybrid CPU topology > > > Zhao Liu writes: > > > From: Zhao Liu > > > > Hi list, > > > > This RFC series is to introduce hybrid topolog

[PULL 13/22] test/qtest: Fix coding style in device-plug-test.c

From: Fabiano Rosas We should not mix declarations and statements in QEMU code. Signed-off-by: Fabiano Rosas Message-Id: <20230208194700.11035-7-faro...@suse.de> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/device-plug-test.c | 8 +--- 1 file changed, 5 insertions(

[PULL 04/22] build: deprecate --enable-gprof builds and remove from CI

From: Alex Bennée As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1338 Signed-off-by: Alex Bennée Message-Id: <

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

On Tue, Feb 14, 2023 at 8:51 AM Michael S. Tsirkin wrote: > > On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote: > > On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote: > > > > > > On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > > > > > > > VIRTIO_F_ORDER_PLATFORM indic

Re: [PATCH v2 4/4] tests/tcg/linux-test: Add linux-fork-trap test

Ilya Leoshkevich writes: > Check that dying due to a signal does not deadlock. > > Signed-off-by: Ilya Leoshkevich > Reviewed-by: Richard Henderson > --- > tests/tcg/multiarch/linux/linux-fork-trap.c | 48 + > 1 file changed, 48 insertions(+) > create mode 100644 tests/t

Re: [PATCH] cirrus.yml: Improve the windows_msys2_task

Thomas Huth writes: > There's no need to run a full-blown bash just to create a directory. > And we can skip the "cd build" each time by doing it once at the > beginning. > > Additionally, let's exclude some targets (that we already compile-test > with MinGW in the gitlab jobs) from the build,

[PATCH 02/12] hw/pci-host/q35: Fix contradicting .endianness assignment

Settle on little endian which is consistent with using pci_host_conf_le_ops. Fixes: bafc90bdc594 'q35: implement TSEG' Signed-off-by: Bernhard Beschow --- hw/pci-host/q35.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 83f2a98c71..3124cad60f 10064

Re: DMAR fault with qemu 7.2 and Ubuntu 22.04 base image

Thanks Peter for the reply. I tried to connect gdb to qemu and able to break 'vtd_iova_to_slpte()', I dumped the following with both Ubuntu 20.04 base image container which is the success case and Ubuntu 22.04 base image container which is failure case One thing I observed is the NvmeSQueue::dma_ad

[PATCH] target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes()

"note_size" can be smaller than sizeof(note), so unconditionally calling memset(notep, 0, sizeof(note)) could cause a memory corruption here in case notep has been allocated dynamically, thus let's use note_size as length argument for memset() instead. Fixes: 113d8f4e95 ("s390x: pv: Add dump suppo

[PATCH v2 05/12] bsd-user: Helper routines oidfmt

From: Stacey Son oidfmt uses undocumented system call to get the type of the sysctl. Co-Authored-by: Sean Bruno Signed-off-by: Sean Bruno Co-Authored-by: Juergen Lock Signed-off-by: Juergen Lock Co-Authored-by: Raphael Kubo da Costa Signed-off-by: Raphael Kubo da Costa Signed-off-by: Stace

[PATCH v2 04/12] bsd-user: various helper routines for sysctl

cap_memory - Caps the memory to just below MAXINT scale_to_target_pages - Account for difference in host / targe page size h2t_long_sat - converts a int64_t to a int32_t, saturating at max / min values h2t_ulong_sat - converts a uint64_t to a uint32_t, saturating at max value Signed-off-by: Warner

[PATCH 14/18] target/riscv: Allow debugger to access {h, s}stateen CSRs

At present {h,s}stateen CSRs are not reported in the CSR XML hence gdb cannot access them. Fix it by adjusting their predicate() routine logic so that the static config check comes before the run-time check, as well as addding a debugger check. Signed-off-by: Bin Meng --- target/riscv/csr.c |

Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU

Hello, [ adding the lists ] > +static void fb_bmc_i2c_init(AspeedMachineState *bmc) The same routine name is proposed in the tiogapass patch : https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1...@gmail.com/

[qemu-web PATCH] add language to tag

Signed-off-by: Paolo Bonzini --- _layouts/blog.html | 2 +- _layouts/home.html | 2 +- _layouts/page.html | 2 +- _plugins/alias_generator.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_layouts/blog.html b/_layouts/blog.html index b7fcdbf..89

[Patch 11/14] target/riscv: Add support for Zvfh/zvfhmin extensions

Zvfh supports vector float point instuctions with SEW = 16 and supports conversions between 8-bit integers adn binary16 values Zvfhmin supports vfwcvt.f.f.v and vfncvt.f.f.w instructions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvv.c.inc | 31

Re: [PULL 00/10] xenpvh machine

On Mon, 13 Feb 2023 at 22:34, Stefano Stabellini wrote: > > On Mon, 13 Feb 2023, Peter Maydell wrote: > > On Fri, 10 Feb 2023 at 22:27, Stefano Stabellini > > wrote: > > > > > > The following changes since commit > > > 90595cc9396bb910b148391fea2e78dd8c6c8b27: > > > > > > Merge tag 'migration

Re: [PATCH v4 15/16] qapi: add HOTPLUG_STATE event

On 14.02.23 11:56, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote: For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladimir Sementsov-Ogievskiy --

Re: [Patch 04/14] target/riscv: Add cfg properties for Zv* extension

On 2/14/23 05:38, Weiwei Li wrote: Add properties for Zve64d,Zvfh,Zvfhmin extension "for Zve64d,Zvfh,Zvfhmin extensions." Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/cpu.h | 3 +++ 1 file changed, 3 insertions(+) d

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

Daniel P. Berrangé writes: [...] > We don't have to drop python 3.6. It is a choice because > of a desire to be able to use some shiny new python > features without caring about back compat. I read this on Friday, and decided to let it sit until after the weekend. Well, it's now Tuesday, and t

Re: [PATCH] vhost: accept VIRTIO_F_ORDER_PLATFORM as a valid SVQ feature

On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote: > > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and > the device are ordered in a way described by the platform. Since vDPA > devices may be backed by a hardware devices, let's allow > VIRTIO_F_ORDER_PLATFORM. > > Signe

RE: [RFC 22/52] riscv: Replace MachineState.smp access with topology helpers

> From: Zhao Liu > Sent: Monday, February 13, 2023 5:50 PM > To: Eduardo Habkost ; Marcel Apfelbaum > ; Philippe Mathieu-Daudé ; > Yanan Wang ; Michael S . Tsirkin > ; Richard Henderson ; Paolo > Bonzini ; Eric Blake ; Markus > Armbruster > Cc: qemu-devel@nongnu.org; Wang, Zhenyu Z ; Mi, > Dapeng

Re: [Patch 05/14] target/riscv: Fix relationship between V, Zve*, F and D

On 2/14/23 05:38, Weiwei Li wrote: Add dependence chain: * V => Zve64d => Zve64f => Zve32f => F * V => Zve64d => D Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/tar

Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology

On Mon, Feb 13, 2023 at 02:10:17PM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 13 Feb 2023 14:10:17 +0100 > From: Philippe Mathieu-Daudé > Subject: Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology > > On 13/2/23 10:49, Zhao Liu wrote: > > From: Zhao Liu > > > > For smp systems, the p

[PATCH v2 12/12] bsd-user: Add -strict

Most of the time, it's useful to make our best effort, but sometimes we want to know right away when we don't implement something. First place we use it is for unknown syscalls. Signed-off-by: Warner Losh --- bsd-user/freebsd/os-syscall.c | 4 bsd-user/main.c | 5 - bsd-us

Re: [PATCH v4 16/16] qapi: introduce DEVICE_ON event

On 14.02.23 11:58, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote: We have DEVICE_DELETED event, that signals that device_del command is actually completed. But we don't have a counter-part for device_add. Still it's sensible for S

Re: [PATCH RESEND 01/18] machine: Fix comment of machine_parse_smp_config()

On Mon, Feb 13, 2023 at 09:31:53PM +0800, wangyanan (Y) wrote: > Date: Mon, 13 Feb 2023 21:31:53 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 01/18] machine: Fix comment of > machine_parse_smp_config() > > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu > > > > Now smp supp

Re: [PATCH RESEND 13/18] hw/i386/pc: Support smp.clusters for x86 PC machine

在 2023/2/13 17:36, Zhao Liu 写道: From: Zhuocheng Ding As module-level topology support is added to X86CPU, now we can enable the support for the cluster parameter on PC machines. With this support, we can define a 5-level x86 CPU topology with "-smp": -smp cpus=*,maxcpus=*,sockets=*,dies=*,clus

RE: [RFC 09/52] hw/machine: Introduce core type for hybrid topology

> From: Zhao Liu > Sent: Monday, February 13, 2023 5:50 PM > To: Eduardo Habkost ; Marcel Apfelbaum > ; Philippe Mathieu-Daudé ; > Yanan Wang ; Michael S . Tsirkin > ; Richard Henderson ; Paolo > Bonzini ; Eric Blake ; Markus > Armbruster > Cc: qemu-devel@nongnu.org; Wang, Zhenyu Z ; Mi, > Dapeng

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

Philippe Mathieu-Daudé writes: > On 14/2/23 12:49, Markus Armbruster wrote: >> Daniel P. Berrangé writes: [...] >>> What's the documented way to construct a QOM path, given only an ID as >>> input ? >> >> QOM paths a gap in our documentation, even though the composition tree >> structure has

Re: [PATCH 17/18] target/riscv: Group all predicate() routines together

On 2023/2/14 12:31, Bin Meng wrote: Move sstc()/sstc32() to where all predicate() routines live. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Regards, Weiwei Li --- target/riscv/csr.c | 108 ++--- 1 file changed, 54 insertions(+), 54 deletions

[PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems. Added Pipewire entry points for QEMU Pipewire audio backend Added wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns

[PULL 22/22] hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()

From: Philippe Mathieu-Daudé Use the SCLP_EVENT() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230212225144.58660-16-phi...@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- hw/s390x/event-facil

Re: [RFC 09/52] hw/machine: Introduce core type for hybrid topology

On Mon, Feb 13, 2023 at 02:13:40PM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 13 Feb 2023 14:13:40 +0100 > From: Philippe Mathieu-Daudé > Subject: Re: [RFC 09/52] hw/machine: Introduce core type for hybrid topology > > On 13/2/23 10:49, Zhao Liu wrote: > > From: Zhao Liu > > > > Under th

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy >> > wrote: >> >> The device field is redundant, because QOM path always include device >

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > Sunil, > > This patch is a bit confusing to me. You're using functions that doesn't exist > in the code base yet (build_madt and build_rhct) because they are introduced > in later patches. This also means that this patch is

Re: [PATCH v3 05/10] qmp: 'add_client' actually expects sockets

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Whether it is SPICE, VNC, D-Bus, or the socket chardev, they all > actually expect a socket kind or will fail in different ways at runtime. > > Throw an error early if the given 'add_client' fd is not a socket, and > close it to av

RE: [PATCH] memory: Optimize replay of guest mapping

>-Original Message- >From: Jason Wang >Sent: Tuesday, February 14, 2023 2:25 PM >To: Duan, Zhenzhong >Cc: qemu-devel@nongnu.org; m...@redhat.com; pet...@redhat.com; >pbonz...@redhat.com; richard.hender...@linaro.org; edua...@habkost.net; >marcel.apfelb...@gmail.com; da...@redhat.com; ph

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

Thomas Huth writes: > On 14/02/2023 08.40, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> [...] >> >>> We don't have to drop python 3.6. It is a choice because >>> of a desire to be able to use some shiny new python >>> features without caring about back compat. >> I read this on F

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

On Tue, Feb 14, 2023 at 11:43 AM Sunil V L wrote: > > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > > Sunil, > > > > This patch is a bit confusing to me. You're using functions that doesn't > > exist > > in the code base yet (build_madt and build_rhct) because they ar

Re: [PATCH v2 12/12] bsd-user: Add -strict

On 14/2/23 01:27, Warner Losh wrote: Most of the time, it's useful to make our best effort, but sometimes we want to know right away when we don't implement something. First place we use it is for unknown syscalls. Signed-off-by: Warner Losh --- bsd-user/freebsd/os-syscall.c | 4 bsd-us

Re: [PATCH 03/18] target/riscv: gdbstub: Minor change for better readability

On 2023/2/14 02:01, Bin Meng wrote: Use a variable 'base_reg' to represent cs->gdb_num_regs so that the call to ricsv_gen_dynamic_vector_xml() can be placed in one single line for better readability. Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Regards, Weiwei Li --- target/riscv/gdb

Re: [RFC 15/52] migration/postcopy-ram: Use generic topology name and helper

On Mon, Feb 13, 2023 at 11:16:13AM +0100, Juan Quintela wrote: > Date: Mon, 13 Feb 2023 11:16:13 +0100 > From: Juan Quintela > Subject: Re: [RFC 15/52] migration/postcopy-ram: Use generic topology name > and helper > > Zhao Liu wrote: > > From: Zhao Liu > > > > As the generic code, here we sho

Re: [Patch 03/14] target/riscv: Simplify the check for Zfhmin and Zhinxmin

On 2/14/23 05:38, Weiwei Li wrote: We needn't check Zfh and Zhinx in these instructions Nit: missing period in the end. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/insn_trans/trans_rvzfh.c.inc | 25 +++---

[PATCH 08/12] hw/pci-host/q35: Turn PCI hole properties into class properties

These properties are class properties in i440fx. No need to handle them differently in q35. Signed-off-by: Bernhard Beschow --- hw/pci-host/q35.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 468

[PATCH v5] hw/arm/smmuv3: Add GBPA register

GBPA register can be used to globally abort all transactions. It is described in the SMMU manual in "6.3.14 SMMU_GBPA". ABORT reset value is IMPLEMENTATION DEFINED, it is chosen to be zero(Do not abort incoming transactions). Other fields have default values of Use Incoming. If UPDATE is not set

[PATCH 09/12] hw/pci-host/q35: Rename local variable to more idiomatic "phb"

Variables of type PCIHostState* are typically named "phb" in QEMU. Follow this convention here as well for consistency. Signed-off-by: Bernhard Beschow --- hw/pci-host/q35.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c i

[PULL 08/22] Do not include "qemu/error-report.h" in headers that do not need it

Include it in the .c files instead that use the error reporting functions. Message-Id: <20230210111931.1115489-1-th...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/arm/allwinner-a10.h | 1 - include/qemu/vhost-user-s

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

On Tue, Feb 14, 2023 at 03:03:54PM +0100, Paolo Bonzini wrote: > On Tue, Feb 14, 2023 at 12:49 PM Daniel P. Berrangé > wrote: > > [quote] > > The motivation for this series is that Python 3.6 was EOL at the end of > > 2021; upstream tools are beginning to drop support for it, including > > setupt

[Patch 00/14] target/riscv: Some updates to float point related extensions

This patchset fixes some relationship for half-precise float point related extensions and vector related extensions. It also adds support for Zvhf{min} and Zve64d extensions. Specification for Zv* extensions can be found in: https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc The por

[PULL 07/22] include/hw: Do not include "hw/registerfields.h" in headers that don't need it

Include "hw/registerfields.h" in the .c files instead (if needed). Message-Id: <20230210112315.1116966-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/arm/smmuv3.h| 1 - include/hw/char/ibex_uart.h| 1 - include/hw/ssi/ibex_spi_host.

[Patch 05/14] target/riscv: Fix relationship between V, Zve*, F and D

Add dependence chain: * V => Zve64d => Zve64f => Zve32f => F * V => Zve64d => D Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index

Re: [PATCH v4 16/16] qapi: introduce DEVICE_ON event

Philippe Mathieu-Daudé writes: > On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote: >> We have DEVICE_DELETED event, that signals that device_del command is >> actually completed. But we don't have a counter-part for device_add. >> Still it's sensible for SHPC and PCIe-native hotplug, as there

<    1   2   3   4   5   >