On Mon, Feb 13, 2023 at 11:07:33AM +0100, Juan Quintela wrote:
> Date: Mon, 13 Feb 2023 11:07:33 +0100
> From: Juan Quintela
> Subject: Re: [RFC 15/52] migration/postcopy-ram: Use generic topology name
> and helper
>
> Zhao Liu wrote:
> > From: Zhao Liu
> >
> > As the generic code, here we sho
The following changes since commit f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b:
Merge tag 'migration-20230213-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging (2023-02-13 11:54:05 +)
are available in the git repository at:
https://github.com/jasowang/qemu.git tags/net-pu
Hi
On Tue, Feb 14, 2023 at 6:15 AM Yajun Wu wrote:
> After live migration with virtio block device, qemu crash at:
>
> #0 0x55914f46f795 in object_dynamic_cast_assert
> (obj=0x559151b7b090, typename=0x55914f80fbc4 "qio-channel",
> file=0x55914f80fb90 "/images/testvfe/sw/qemu.gerrit/
On 13/02/2023 22.07, Fabiano Rosas wrote:
The virtconsole device might not be present in the QEMU build that is
being tested.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/meson.build b/tests/qtes
On 2023/2/14 02:02, Bin Meng wrote:
There is no need to generate the CSR XML if the Zicsr extension
is not enabled.
Signed-off-by: Bin Meng
Reviewed-by: Weiwei Li
Regards,
Weiwei Li
---
target/riscv/gdbstub.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a
Check for Zve32f/Zve64d can overlap check for F/D
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/insn_trans/trans_rvv.c.inc | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
b/target/riscv/insn_trans/tran
Only V extension support EEW = 64 in these case: Zve64* extensions
don't support EEW = 64 as commented
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/insn_trans/trans_rvv.c.inc | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/target/riscv/
Expose Zve64d,Zvfh,Zvfhmin properties
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 73711d392d..2c71e22ea9 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/c
On 2023/2/14 02:02, Bin Meng wrote:
Fix various places that violate QEMU coding style:
- correct multi-line comment format
- indent to opening parenthesis
Signed-off-by: Bin Meng
Reviewed-by: Weiwei Li
Regards,
Weiwei Li
---
target/riscv/csr.c | 62
> From: Zhao Liu
> Sent: Monday, February 13, 2023 5:50 PM
> To: Eduardo Habkost ; Marcel Apfelbaum
> ; Philippe Mathieu-Daudé ;
> Yanan Wang ; Michael S . Tsirkin
> ; Richard Henderson ; Paolo
> Bonzini ; Eric Blake ; Markus
> Armbruster
> Cc: qemu-devel@nongnu.org; Wang, Zhenyu Z ; Mi,
> Dapeng
From: Fabiano Rosas
Signed-off-by: Fabiano Rosas
Message-Id: <20230208194700.11035-11-faro...@suse.de>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/meson.build b/tests/qtest/
On 2/14/23 05:38, Weiwei Li wrote:
Expose Zve64d,Zvfh,Zvfhmin properties
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/cpu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cp
On 2023/2/14 21:21, Daniel Henrique Barboza wrote:
On 2/14/23 05:38, Weiwei Li wrote:
Add dependence chain:
* V => Zve64d => Zve64f => Zve32f => F
* V => Zve64d => D
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu.c | 21 ++---
1 file change
On 14/02/2023 13.24, Paolo Bonzini wrote:
The homepage goes straight from h1 to h3, add the missing tag for use in screen
readers.
Signed-off-by: Paolo Bonzini
---
assets/css/style.css | 12
index.html | 3 +++
2 files changed, 15 insertions(+)
diff --git a/assets/
Deleting from and adding to the parent memory region seems to be the old
way of changing a memory region's address which is superseeded by
memory_region_set_address(). Moreover, memory_region_set_address() is
already used for tseg_window which is tseg_blackhole's counterpart in
SMM space.
Ammends:
Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben:
> bdrv_append() is called with bs_top AioContext held, but
> bdrv_attach_child_noperm() could change the AioContext of bs_top.
>
> bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from
> commit 2398747128 ("block: Don't poll
From: Fabiano Rosas
Signed-off-by: Fabiano Rosas
Message-Id: <20230208194700.11035-9-faro...@suse.de>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/qtest/drive_del-test.c | 65
1 file changed, 65 insertions(+)
diff --git a/tests/qtest/driv
After live migration with virtio block device, qemu crash at:
#0 0x55914f46f795 in object_dynamic_cast_assert
(obj=0x559151b7b090, typename=0x55914f80fbc4 "qio-channel", file=0x55914f80fb90
"/images/testvfe/sw/qemu.gerrit/include/io/channel.h", line=30,
func=0x55914f80fcb8 <__func_
On 2023/2/14 21:37, Daniel Henrique Barboza wrote:
On 2/14/23 05:38, Weiwei Li wrote:
Only V extension support EEW = 64 in these case: Zve64* extensions
don't support EEW = 64 as commented
"as commented" where? In the previous patch?
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wa
On 14/02/2023 08.40, Markus Armbruster wrote:
Daniel P. Berrangé writes:
[...]
We don't have to drop python 3.6. It is a choice because
of a desire to be able to use some shiny new python
features without caring about back compat.
I read this on Friday, and decided to let it sit until after
From: Fabiano Rosas
Do not include tests that require devices that are not available in
the QEMU build.
Signed-off-by: Fabiano Rosas
Acked-by: Michael S. Tsirkin
Message-Id: <20230208194700.11035-10-faro...@suse.de>
Signed-off-by: Thomas Huth
---
tests/qtest/bios-tables-test.c | 75 +
This patch prepares movement of the MemoryRegion pointers (which are set
through properties) into the host state. Moreover, it's usually the
parent device which maps the memory regions of its child devices into
its address space. Do the same in q35.
Signed-off-by: Bernhard Beschow
---
hw/pci-hos
Hi Philippe,
On Mon, Feb 13, 2023 at 7:26 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Mauro,
>
> On 13/2/23 18:41, Mauro Matteo Cascella wrote:
> > The guest can control the size of buf; an OOB write occurs when buf is 1 or
> > 2
> > bytes long. Only fill in the buffer as long as there is enough spa
On Mon, Feb 13, 2023 at 02:28:54PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 13 Feb 2023 14:28:54 +0100
> From: Philippe Mathieu-Daudé
> Subject: Re: [RFC 34/52] i386: Rename variable topo_info to apicid_topo
>
> On 13/2/23 10:50, Zhao Liu wrote:
> > From: Zhao Liu
> >
> > Since X86Apic
From: Ilya Leoshkevich
The code currently uses -nostartfiles, but this does not prevent
linking with libc. On Fedora there is no cross-libc, so the linking
step fails.
Fix by using the more comprehensive -nostdlib (that's also what
probe_target_compiler() checks for as well).
Fixes: 503e549e441
On 01/02/2023 14:31, David Woodhouse wrote:
From: David Woodhouse
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_gnttab.c | 31
hw/i386/kvm/xen_gnttab.h | 5
target/i386/kvm/xen-emu.c | 60 +++
3 files changed, 96 insert
On 2023/2/14 02:02, Bin Meng wrote:
Use env_archcpu() to get RISCVCPU pointer from env directly.
Signed-off-by: Bin Meng
Reviewed-by: Weiwei Li
Regards,
Weiwei Li
---
target/riscv/csr.c | 36
1 file changed, 12 insertions(+), 24 deletions(-)
diff
Hi Peter!
The following changes since commit f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b:
Merge tag 'migration-20230213-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging (2023-02-13 11:54:05 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git ta
This series mostly cleans up QOM-related initialization code. It also performs
some modernization and fixing.
The first patch originates from "PC and ICH9 clanups" series [1] which has been
dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
needs more work, so bring th
On Tue, Feb 14, 2023 at 05:36:32PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 14, 2023 at 5:34 PM Markus Armbruster wrote:
> >
> > marcandre.lur...@redhat.com writes:
> >
> > > From: Marc-André Lureau
> > >
> > > As per comment, presumably to avoid syscall in critical section.
> > >
>
Ilya Leoshkevich writes:
> Currently dying to one of the core_dump_signal()s deadlocks, because
> dump_core_and_abort() calls start_exclusive() two times: first via
> stop_all_tasks(), and then via preexit_cleanup() ->
> qemu_plugin_user_exit().
>
> There are a number of ways to solve this: res
On x86, there are two notifiers registered due to vtd-ir memory region
splitting the whole address space. During replay of the address space
for each notifier, the whole address space is scanned which is
unnecessory.
We only need to scan the space belong to notifier montiored space.
Signed-off-by
On 2/14/23 08:11, Philippe Mathieu-Daudé wrote:
Hi Pierrick,
On 13/2/23 17:13, Pierrick Bouvier wrote:
Windows implementation of setjmp/longjmp is done in
C:/WINDOWS/system32/ucrtbase.dll. Alas, on arm64, it seems to *always*
perform stack unwinding, which crashes from generated code.
By using
From: Thomas Huth
The code that collects the available NIC models is not really specific
to PCI anymore and will be required in the next patch, too, so let's
move this into a new separate function in net.c instead.
Signed-off-by: Thomas Huth
Signed-off-by: Jason Wang
---
hw/pci/pci.c | 2
bdrv_append() is called with bs_top AioContext held, but
bdrv_attach_child_noperm() could change the AioContext of bs_top.
bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from
commit 2398747128 ("block: Don't poll in bdrv_replace_child_noperm()").
bdrv_drained_begin() can call BDRV_
On 14.02.23 14:57, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
The device field is redundant, because QOM pat
在 2023/2/14 18:16, Zhao Liu 写道:
On Mon, Feb 13, 2023 at 09:18:05PM +0800, wangyanan (Y) wrote:
Date: Mon, 13 Feb 2023 21:18:05 +0800
From: "wangyanan (Y)"
Subject: Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology
Hi Zhao,
在 2023/2/13 17:49, Zhao Liu 写道:
From: Zhao Liu
For smp systems,
The variable is redundant to "phb" and is never used by its real type.
Signed-off-by: Bernhard Beschow
Reviewed-by: Thomas Huth
---
hw/i386/pc_q35.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index a5ff
The homepage goes straight from h1 to h3, add the missing tag for use in screen
readers.
Signed-off-by: Paolo Bonzini
---
assets/css/style.css | 12
index.html | 3 +++
2 files changed, 15 insertions(+)
diff --git a/assets/css/style.css b/assets/css/style.css
index 779b
On 2023/2/14 02:02, Bin Meng wrote:
It's worth noting that the vector CSR predicate() has a similar
run-time check logic to the FPU CSR. With the previous patch our
gdbstub can correctly report these vector CSRs via the CSR xml.
Commit 719d3561b269 ("target/riscv: gdb: support vector registers
On 2/14/23 05:38, Weiwei Li wrote:
Zvfh supports vector float point instuctions with SEW = 16
s/instuctions/instructions
and supports conversions between 8-bit integers adn binary16 values
s/adn/and
Zvfhmin supports vfwcvt.f.f.v and vfncvt.f.f.w instructions
Signed-off-by: Weiwei Li
On 2/14/23 05:38, Weiwei Li wrote:
Just like zfh and zfhmin, Zhinxmin is part of Zhinx so Zhinxmin
will be enabled when Zhinx is enabled
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/cpu.c | 7 +--
1 file changed, 5 i
QE uses the sim_vdpa device to test this patch and add "ctrl_vq=off"
in the qemu command line. Guest can find this device, there are no any
error messages in guest dmesg, and can migrate successfully.
Tested-by: Lei Yang
Eugenio Perez Martin 于2023年2月14日周二 14:53写道：
>
> On Tue, Jan 24, 2023 at 5:
On Tue, Feb 14, 2023 at 08:40:20AM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> [...]
>
> > We don't have to drop python 3.6. It is a choice because
> > of a desire to be able to use some shiny new python
> > features without caring about back compat.
>
> I read this on Frid
From: Joelle van Dyne
When the VM is stopped using the HMP command "stop", soon the handler will
stop reading from the vmnet interface. This causes a flood of
`VMNET_INTERFACE_PACKETS_AVAILABLE` events to arrive and puts the host CPU
at 100%. We fix this by removing the event handler from vmnet w
On 2/14/23 05:38, Weiwei Li wrote:
Zfhmin is part of Zfh, so Zfhmin will be enabled when Zfh is enabled
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
Zfhmin is part of Zfh, so Zfhmin will be enabled when Zfh is enabled
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 0dd2f0c753..eb0cd12a6a 100644
On 2023/2/14 02:02, Bin Meng wrote:
The read_only variable is currently declared as an 'int', but it
should really be a 'bool'.
Signed-off-by: Bin Meng
Reviewed-by: Weiwei Li
Regards,
Weiwei Li
---
target/riscv/csr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Doug Rabson
System call return values on FreeBSD are in a register (which is spelled
abi_long in qemu). This was being assigned into an int variable which
causes problems for 64bit targets.
Resolves: https://github.com/qemu-bsd-user/qemu-bsd-user/issues/40
Signed-off-by: Doug Rabson
Revie
From: Qiang Liu
This patch replaces hw_error to guest error log for [read|write]b
accesses when mode_16bit is enabled. This avoids aborting qemu.
Fixes: 1248f8d4cbc3 ("hw/lan9118: Add basic 16-bit mode support.")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1433
Reported-by: Qiang Liu
On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote:
>
> On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote:
> >
> > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and
> > the device are ordered in a way described by the platform. Since vDPA
> > devices may be backed by a har
Move sstc()/sstc32() to where all predicate() routines live.
Signed-off-by: Bin Meng
---
target/riscv/csr.c | 108 ++---
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 40aae9e7b3..37350b8a6d 1
On 14/2/23 13:17, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 14/2/23 12:49, Markus Armbruster wrote:
Daniel P. Berrangé writes:
[...]
What's the documented way to construct a QOM path, given only an ID as
input ?
QOM paths a gap in our documentation, even though the co
From: Fabiano Rosas
Don't include tests that require devices not available in the QEMU
binary.
Signed-off-by: Fabiano Rosas
Reviewed-by: Thomas Huth
Message-Id: <20230208194700.11035-6-faro...@suse.de>
Signed-off-by: Thomas Huth
---
tests/qtest/hd-geo-test.c | 38 +---
On 2/13/2023 3:14 AM, Eugenio Perez Martin wrote:
On Mon, Feb 13, 2023 at 7:51 AM Si-Wei Liu wrote:
On 2/8/2023 1:42 AM, Eugenio Pérez wrote:
Only create iova_tree if and when it is needed.
The cleanup keeps being responsible of last VQ but this change allows it
to merge both cleanup fun
From: Stacey Son
Connect up the sysarch system call.
Signed-off-by: Juergen Lock
Co-authored-by: Juergen Lock
Signed-off-by: Stacey Son
Reviewed-by: Warner Losh
Signed-off-by: Warner Losh
Reviewed-by: Richard Henderson
---
bsd-user/freebsd/os-syscall.c | 7 +++
1 file changed, 7 inser
Zve64f depends on Zve32f, so we can only check Zve32f
in these cases
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/insn_trans/trans_rvv.c.inc | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
b/target/ri
On Tue, Feb 14, 2023 at 12:56 PM Kevin Wolf wrote:
>
> Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben:
> > bdrv_append() is called with bs_top AioContext held, but
> > bdrv_attach_child_noperm() could change the AioContext of bs_top.
> >
> > bdrv_replace_node_noperm() calls bdrv_drained
On 2/14/23 08:14, Philippe Mathieu-Daudé wrote:
On 13/2/23 17:13, Pierrick Bouvier wrote:
When compiling for windows-arm64 using clang-15, it reports a sometimes
uninitialized variable. This seems to be a false positive, as a default
case guards switch expressions, preventing to return an uninit
Hi Pierrick,
On 13/2/23 17:13, Pierrick Bouvier wrote:
Windows implementation of setjmp/longjmp is done in
C:/WINDOWS/system32/ucrtbase.dll. Alas, on arm64, it seems to *always*
perform stack unwinding, which crashes from generated code.
By using alternative implementation built in mingw, we av
On 2023/2/14 02:02, Bin Meng wrote:
Since commit 94452ac4cf26 ("target/riscv: remove fflags, frm, and fcsr from
riscv-*-fpu.xml")
the 3 FPU CSRs are removed from the XML target decription. The
original intent of that commit was based on the assumption that
the 3 FPU CSRs will show up in the ri
On 14/2/23 00:29, Richard Henderson wrote:
On 2/12/23 12:47, Philippe Mathieu-Daudé wrote:
-static char *qdev_get_fw_dev_path_from_handler(BusState *bus,
DeviceState *dev)
+static char *qdev_get_fw_dev_path_from_handler(DeviceState *dev)
{
Object *obj = OBJECT(dev);
+ BusState *bus =
The pointers are set through the host device's properties and are only
used during its realization phase.
Signed-off-by: Bernhard Beschow
---
include/hw/pci-host/q35.h | 10 +++
hw/pci-host/q35.c | 56 +++
2 files changed, 33 insertions(+), 33 dele
On Tue, Feb 14, 2023 at 11:43 AM Zhenzhong Duan
wrote:
>
> On x86, there are two notifiers registered due to vtd-ir memory region
> splitting the whole address space. During replay of the address space
> for each notifier, the whole address space is scanned which is
> unnecessory.
>
> We only need
Daniel P. Berrangé writes:
> On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> The device field is redundant, because QOM path always include device
>> ID when this ID exist.
>
> The flipside to that view is that applications configuring QEMU are
> specifying the de
On Tue, Feb 14, 2023 at 09:35:44AM +0100, Thomas Huth wrote:
> On 14/02/2023 08.40, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > [...]
> >
> > > We don't have to drop python 3.6. It is a choice because
> > > of a desire to be able to use some shiny new python
> > > features wi
From: Fabiano Rosas
Signed-off-by: Fabiano Rosas
Message-Id: <20230208194700.11035-8-faro...@suse.de>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/qtest/device-plug-test.c | 33 +++--
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/t
q35_host_realize() has an errp parameter. Use that to be able to
propagate the error instead of terminating abruptly.
Signed-off-by: Bernhard Beschow
---
hw/pci-host/q35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 8f81debfa5
The boundaries of the PCI hole depend on a property only which doesn't
change at runtime. There is no need to reevaluate the boundaries
whenever the PCI configuration space changes.
While at it, move the pci_hole attribute into the host device since it
is only used there.
Signed-off-by: Bernhard
Although not used there, the attributes for Q35's "pci-hole64-size" and
"short_root_bus" properties currently reside in its child device. This
causes the default values to be overwritten during the child's
object_initialize() phase. Avoid this by moving both attributes into the
host device.
Signed
Fosshost is mostly dead and can be removed from the page, but lately QEMU
has received important sponsorships from GNOME and Azure, so mention them.
OSUOSL also provides OpenStack virtual machines to QEMU.
Our CI resources are sponsored by WorksOnArm, the IBM LinuxOne community
cloud and GitLab.
From: Fabiano Rosas
If we build with --without-default-devices, CONFIG_HPET and
CONFIG_PARALLEL are set to N, which makes the respective devices go
missing from acpi tables.
Signed-off-by: Fabiano Rosas
Reviewed-by: Thomas Huth
Message-Id: <20230208194700.11035-13-faro...@suse.de>
Signed-off-b
From: Laurent Vivier
In stream mode, if the server shuts down there is currently
no way to reconnect the client to a new server without removing
the NIC device and the netdev backend (or to reboot).
This patch introduces a reconnect option that specifies a delay
to try to reconnect with the same
On 2023/2/14 12:12, Bin Meng wrote:
At present with a debugger attached sstc CSRs can only be accssed
when CPU is in M-mode, or configured correctly.
Fix it by adjusting their predicate() routine logic so that the
static config check comes before the run-time check, as well as
addding a debugg
On Mon, Feb 13, 2023 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 13 Feb 2023 14:27:18 +0100
> From: Philippe Mathieu-Daudé
> Subject: Re: [RFC 33/52] i386: Rename init_topo_info() to
> init_apic_topo_info()
>
> On 13/2/23 10:50, Zhao Liu wrote:
> > From: Zhao Liu
> >
> > Re
在 2023/2/13 17:36, Zhao Liu 写道:
From: Zhao Liu
For function comments in this file, keep the comment style consistent
with other places.
Signed-off-by: Zhao Liu
---
include/hw/i386/topology.h | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --g
On 2/14/23 00:43, Sunil V L wrote:
On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote:
Sunil,
This patch is a bit confusing to me. You're using functions that doesn't exist
in the code base yet (build_madt and build_rhct) because they are introduced
in later patches. Thi
On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> >> The device field is redundant, because QOM path always include device
> >> ID when this ID exist.
> >
> > T
Hi
On Mon, Feb 13, 2023 at 8:20 PM Konstantin Kostiuk
wrote:
> Hi Marc-André,
>
> Can you please review this patch set?
>
> Best Regards,
> Konstantin Kostiuk.
>
>
> On Thu, Feb 9, 2023 at 10:50 AM Kfir Manor wrote:
>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/775
>>
>> The prob
On 13/2/23 17:13, Pierrick Bouvier wrote:
When compiling for windows-arm64 using clang-15, it reports a sometimes
uninitialized variable. This seems to be a false positive, as a default
case guards switch expressions, preventing to return an uninitialized
value, but clang seems unhappy with asser
On Tue, Feb 14, 2023 at 12:57:28PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy
> >> > wro
From: Kyle Evans
do_freebsd_sysctlbyname needs to translate the 'name' back down to a OID
so we can intercept the special ones. Do that and call the common wrapper
do_freebsd_sysctl_oid.
Signed-off-by: Kyle Evans
Reviewed-by: Warner Losh
Signed-off-by: Warner Losh
---
bsd-user/freebsd/os-sys
On 14/2/23 00:19, Richard Henderson wrote:
On 2/12/23 13:03, Philippe Mathieu-Daudé wrote:
On 12/2/23 23:47, Philippe Mathieu-Daudé wrote:
DeviceState::parent_bus is an internal field and should be
accessed by the qdev_get_parent_bus() helper. Replace all
uses in hw/ except the QDev uses in hw/
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> As per comment, presumably to avoid syscall in critical section.
>
> Fixes: 0210c3b39bef08 ("monitor: Use LOCK_GUARD macros")
> Signed-off-by: Marc-André Lureau
> ---
> monitor/fds.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
From: Fabiano Rosas
The virtconsole device might not be present in the QEMU build that is
being tested.
Signed-off-by: Fabiano Rosas
Message-Id: <20230213210738.9719-5-faro...@suse.de>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 6 +-
1 file changed,
At present seed CSR is not reported in the CSR XML hence gdb cannot
access it.
Fix it by addding a debugger check in its predicate() routine.
Signed-off-by: Bin Meng
---
target/riscv/csr.c | 4
1 file changed, 4 insertions(+)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 515
On Tue, Feb 14, 2023 at 08:02:08AM +0100, Eugenio Perez Martin wrote:
> On Tue, Feb 14, 2023 at 7:31 AM Jason Wang wrote:
> >
> > On Tue, Feb 14, 2023 at 3:19 AM Eugenio Pérez wrote:
> > >
> > > VIRTIO_F_ORDER_PLATFORM indicates that memory accesses by the driver and
> > > the device are ordered
On Mon, Feb 13, 2023 at 09:18:05PM +0800, wangyanan (Y) wrote:
> Date: Mon, 13 Feb 2023 21:18:05 +0800
> From: "wangyanan (Y)"
> Subject: Re: [RFC 06/52] hw/cpu: Introduce hybrid CPU topology
>
> Hi Zhao,
>
> 在 2023/2/13 17:49, Zhao Liu 写道:
> > From: Zhao Liu
> >
> > For smp systems, the parts
On 2/14/23 05:38, Weiwei Li wrote:
Fix indent problems in vector related check
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/cpu.c | 44 ++--
1 file changed, 22 insertions(+), 22 d
From: Eugenio Pérez
VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
Signed-off-by: Eug
On 8/2/23 20:47, Richard Henderson wrote:
On 2/7/23 14:07, Philippe Mathieu-Daudé wrote:
The previous commit removed the single call to
isa_register_portio_list() with dev=NULL. To be
sure we won't reintroduce such weird (ab)use,
add an assertion.
Signed-off-by: Philippe Mathieu-Daudé
Review
Anthony Perard recently reported some problems with Clang v6.0 from
Ubuntu Bionic (with regards to the -Wmissing-braces configure test).
Since we're not officially supporting that version of Ubuntu anymore,
we should better bump our minimum version check in the configure script
instead of using our
From: Ilya Leoshkevich
Static QEMU build fails on Debian Bullseye:
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libdw.a(debuginfod-client.o): in
function `__libdwfl_debuginfod_init':
(.text.startup+0x17): undefined reference to `dlopen'
The reason is that pkg-config does not suggest -ldl for
From: Christian Svensson
Increase the allocated buffer size to fit larger packets.
Given that jumboframes can commonly be up to 9000 bytes the closest suitable
value seems to be 16 KiB.
Tested by running qemu towards a Linux L2TPv3 endpoint and pushing
jumboframe traffic through the interfaces.
From: Fabiano Rosas
This test depends on the presence of the pcie-root-port device. Add a
build time dependency.
Signed-off-by: Fabiano Rosas
Message-Id: <20230208194700.11035-4-faro...@suse.de>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 3 ++-
1 file c
Nit: I believe you mean "redundant" in the title ^
On 2/14/23 05:38, Weiwei Li wrote:
Require_zve32/64f have been overlapped by require_rvf/require_scale_rvf
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/insn_trans/trans_rv
Juan Quintela writes:
> We used to synchronize all channels at the end of each RAM section
> sent. That is not needed, so preparing to only synchronize once every
> full round in latests patches.
>
> Notice that we initialize the property as true. We will change the
> default when we introduce
Hi
On Tue, Feb 14, 2023 at 5:34 PM Markus Armbruster wrote:
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > As per comment, presumably to avoid syscall in critical section.
> >
> > Fixes: 0210c3b39bef08 ("monitor: Use LOCK_GUARD macros")
> > Signed-off-by: Marc-Andr
Ilya Leoshkevich writes:
> fork()ed processes currently start with
> current_cpu->in_exclusive_context set, which is, strictly speaking, not
> correct, but does not cause problems (even assertion failures).
>
> With one of the next patches, the code begins to rely on this value, so
> fix it by
On Tue, Jan 24, 2023 at 5:32 PM Eugenio Pérez wrote:
>
> Since GUEST_ANNOUNCE is emulated the feature bit could be set without
> backend support. This happens in the vDPA case.
>
> However, backend vDPA parent may not have CVQ support. This causes an
> incoherent feature set, and the driver may
1 - 100 of 478 matches
Mail list logo
