On Mon, Feb 13, 2023 at 02:28:54PM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 13 Feb 2023 14:28:54 +0100 > From: Philippe Mathieu-Daudé <phi...@linaro.org> > Subject: Re: [RFC 34/52] i386: Rename variable topo_info to apicid_topo > > On 13/2/23 10:50, Zhao Liu wrote: > > From: Zhao Liu <zhao1....@intel.com> > > > > Since X86ApicidTopoInfo is only used for APIC ID related work, the > > common variable topo_info of X86ApicidTopoInfo type should be also > > renamed to better suit its purpose. > > > > Generic topology access should be obtained from MachineState.topo > > (for the whole machine) or CPUState.topo (for the current CPU), and > > apicid_topo (X86ApicidTopoInfo type) is only used to collaborate with > > APIC ID. > > > > Co-Developed-by: Zhuocheng Ding <zhuocheng.d...@intel.com> > > Signed-off-by: Zhuocheng Ding <zhuocheng.d...@intel.com> > > Signed-off-by: Zhao Liu <zhao1....@intel.com> > > --- > > hw/i386/x86.c | 38 ++++----- > > include/hw/i386/topology.h | 76 ++++++++--------- > > include/hw/i386/x86.h | 2 +- > > target/i386/cpu.c | 71 ++++++++-------- > > tests/unit/test-x86-apicid.c | 158 +++++++++++++++++------------------ > > 5 files changed, 173 insertions(+), 172 deletions(-) > > The 'id' suffix doesn't add a lot of value IMO. Anyway, > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> >
Thanks, it makes sense. I'll remove the id suffix. Zhao
