On 8/2/23 23:43, Titus Rwantare wrote:
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 18 ++
On 08/02/2023 20.46, Fabiano Rosas wrote:
This test depends on the presence of the pcie-root-port device. Add a
build time dependency.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/meson.build b/test
On 8/2/23 23:43, Titus Rwantare wrote:
Signed-off-by: Titus Rwantare
---
hw/i2c/core.c | 8 +---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 08/02/2023 20.46, Fabiano Rosas wrote:
The virtconsole device might not be present in the QEMU build that is
being tested.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/meson.build b/tests/qtes
On 08/02/2023 20.46, Fabiano Rosas wrote:
We should not mix declarations and statements in QEMU code.
Signed-off-by: Fabiano Rosas
---
tests/qtest/device-plug-test.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth
On 08/02/2023 20.46, Fabiano Rosas wrote:
Signed-off-by: Fabiano Rosas
---
tests/qtest/device-plug-test.c | 33 +++--
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 4f92617335..01
On 08/02/2023 20.46, Fabiano Rosas wrote:
Signed-off-by: Fabiano Rosas
---
tests/qtest/drive_del-test.c | 65
1 file changed, 65 insertions(+)
diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c
index 9a750395a9..8a6f3ac963 100644
---
On 08/02/2023 20.46, Fabiano Rosas wrote:
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index eccdfca235..c6dba4f87e 100644
--- a/tests/qtest/meson.build
+++ b/
Adds registry value VssOption with value 1 to QEMU Guest Agent VSS Provider
service registry key
Signed-off-by: Kfir Manor
---
qga/installer/qemu-ga.wxs | 4
1 file changed, 4 insertions(+)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 51340f7ecc..f7f145aa05 100
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/775
The problem, VSS backup type VSS-FULL (the only available VSS backup type
currently) can break other backups that use VSS-FULL(for example,
Bareos-Fullbackup).
Fix, add other backup types.
Implementation, put the desired backup type n
Query VSS backup type number (DWORD) from QEMU Guest Agent VSS Provider
registry key registry value VssOption
Translate the VSS backup type number (DWORD) into its VSS backup type
(VSS_BACKUP_TYPE)
Returns the queried VSS backup type if the program encounters unexpected
behaviors or values ret
Change requester_freeze so that the VSS backup type queried from the registry
Signed-off-by: Kfir Manor
---
qga/vss-win32/requester.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 27fdb9236b..163b3870b9 100
Oops yes I did. I will respin it.
Paolo
Il gio 9 feb 2023, 06:21 Thomas Huth ha scritto:
> On 08/02/2023 18.19, Paolo Bonzini wrote:
> > Test that it does not cause a SIGSEGV, and cover a valid configuration
> > as well.
> >
> > Signed-off-by: Paolo Bonzini
> > ---
> > tests/qtest/libqtest.c
Yeah it's the same but it should use errp. Sorry to both of you!
Paolo
Il gio 9 feb 2023, 08:09 Philippe Mathieu-Daudé ha
scritto:
> On 9/2/23 06:19, Thomas Huth wrote:
> > On 08/02/2023 18.19, Paolo Bonzini wrote:
> >> The following changes since commit
> >> ae2b5d8381a73b27f35f19c988d45c78bb4
On Wed, Feb 8, 2023 at 1:08 AM Philippe Mathieu-Daudé
wrote:
> TYPE_PIIX3_IDE is a PCI function inheriting from QOM
> TYPE_PCI_DEVICE. To be able to call the ISA specific
> ide_init_ioport_isa(), we call this function passing
> a NULL ISADevice argument. Remove this hack by calling
> the recently
On Thu, Feb 9, 2023 at 8:33 AM Alistair Francis
wrote:
>
> From: Alistair Francis
>
> This patch adds some active RISC-V members as reviewers to the
> MAINTAINERS file.
>
> Signed-off-by: Alistair Francis
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Bin Meng
On 2/9/2023 2:15 PM, Wang, Lei wrote:
On 2/9/2023 1:59 PM, Xiaoyao Li wrote:
On 2/9/2023 12:21 PM, Wang, Lei wrote:
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 88aa780566..e638a31d34 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -4377,6 +4377,28 @@ static bool x86_cpu_h
Test that it does not cause a SIGSEGV, and cover a valid configuration
as well.
Signed-off-by: Paolo Bonzini
---
tests/qtest/libqtest.c| 28 +-
tests/qtest/libqtest.h| 12 ++
tests/qtest/readconfig-test.c | 45 ---
3 fil
On 2/8/23 21:33, Alistair Francis wrote:
From: Alistair Francis
This patch adds some active RISC-V members as reviewers to the
MAINTAINERS file.
Signed-off-by: Alistair Francis
---
Reviewed-by: Daniel Henrique Barboza
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git
Avoid a SIGSEGV and return an error instead.
Reported-by: Thomas Huth
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1439
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index
The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768:
Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru into
staging (2023-02-08 10:40:06 +)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for y
On 2/9/23 9:07 AM, Juan Quintela wrote:
Gavin Shan wrote:
When dirty ring is enabled on ARM64, the backup bitmap may be used
to track the dirty pages in no-running-vcpu situations. The original
bitmap is the primary one, used for the dirty ring buffer. We need
the secondary bitmap to collect th
Reviewed-by: Frank Chang
On Thu, Feb 9, 2023 at 8:34 AM Alistair Francis <
alistair.fran...@opensource.wdc.com> wrote:
> From: Alistair Francis
>
> This patch adds some active RISC-V members as reviewers to the
> MAINTAINERS file.
>
> Signed-off-by: Alistair Francis
> ---
> MAINTAINERS | 3 ++
On 2/9/23 9:11 AM, Juan Quintela wrote:
Gavin Shan wrote:
Due to multiple capabilities associated with the dirty ring for different
architectures: KVM_CAP_DIRTY_{LOG_RING, LOG_RING_ACQ_REL} for x86 and
arm64 separately. There will be more to be done in order to support the
dirty ring for arm64.
On 2/9/23 02:52, Himanshu Chauhan wrote:
When MSECCFG.MML is set, after checking the address range in PMP if the
asked permissions are not same as programmed in PMP, the default
permissions are applied. This should only be the case when there
is no matching address is found.
This patch skips
Alex Bennée writes:
> Steven Sistare writes:
>
>> On 2/8/2023 1:43 AM, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare
>>> wrote:
Generalize hmp_split_at_comma() to take any delimiter character, rename
as strList_from_string(), and move it
On Wed, Feb 08, 2023 at 06:35:39PM +0100, Nina Schoetterl-Glausch wrote:
> On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
> > When the guest asks to change the polarity this change
> > is forwarded to the admin using QAPI.
> > The admin is supposed to take according decisions concerning
> >
Steve Sistare writes:
> Add some handy string list functions, for general use now, and for
> eventual use in the cpr/live update patches.
Submit them together with uses, please.
On 08/02/2023 20.26, Fabiano Rosas wrote:
Currently the isa-parallel driver is always added by the PC machines
regardless of the presence of the actual code in the build, which can
lead to a crash:
qemu-system-i386: unknown type 'isa-parallel'
Aborted (core dumped)
Signed-off-by: Fabiano Rosas
On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote:
> On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
> > Existing 'migrate' QAPI design enforces transport mechanism, ip address
> > of destination interface and corresponding port number in the form
> > of a unified string 'uri' pa
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri' parameter for initiating a migration stream.
This scheme has a significant flaw in it - double encoding of existing
URIs to extract mi
hmp_migrate() stores modified QAPI 'migrate' arguments from qdict
into well defined MigrateChannel struct with help of
migrate_channel_from_qdict().
hmp_migrate() also accepts uri string as modified QAPI a 'migrate'
argument (for backward compatibility).
Reviewed-by: Eric Blake
Reviewed-by: Marku
'migrate-incoming' QAPI design have been modified into well-defined
MigrateChannel struct to prevent multiple encoding of uri strings on
the destination side.'uri' parameter is kept for backward compatibility.
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gil
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file. Give external linkage, as
this function will be handy in coming commit for migration.
Minor correction:
g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)
Reviewed-by: Eric Blake
Modified 'migrate-incoming' QAPI design supports MigrateChannel parameters.
This well-defined struct replaces uri string to prevent multiple encodings.
(uri paramter is kept for backward compatibility).
socket_start_incoming_migration() has been deprecated and
socket_start_incoming_migration_inte
In existing senario, 'migrate' QAPI argument - string uri, is encoded
twice to extract migration parameters for stream connection. This is
not a good representation of migration wire protocol as it is a data
encoding scheme within a data encoding scheme. Qemu should be able to
directly work with re
This is v3 patchset for modified 'migrate' QAPI design for migration
connection.
Links to previous versions:
v1: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04339.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02106.html
Thanks to Eric for his quick and valuable su
On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
> Existing 'migrate' QAPI design enforces transport mechanism, ip address
> of destination interface and corresponding port number in the form
> of a unified string 'uri' parameter for initiating a migration stream.
> This scheme has a signi
On Wed, Feb 08, 2023 at 09:35:59AM +, Het Gala wrote:
> 'migrate-incoming' QAPI design have been modified into well-defined
> MigrateChannel struct to prevent multiple encoding of uri strings on
> the destination side.'uri' parameter is kept for backward compatibility.
>
> Suggested-by: Daniel
Hi Khadija,
the diffs below look fine now ... but unfortunately the commit description
is now lacking your "Signed-off-by" line as we require it for QEMU:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line
You can edit the commit
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote:
> In existing senario, 'migrate' QAPI argument - string uri, is encoded
> twice to extract migration parameters for stream connection. This is
> not a good representation of migration wire protocol as it is a data
> encoding scheme within a
Peter Maydell writes:
> On Tue, 7 Feb 2023 at 15:41, Markus Armbruster wrote:
>> We have a boatload of CONFIG_FOO macros that may only be used in
>> target-dependent code. We use generated config-poison.h to enforce.
>>
>> This is a bit annoying in the QAPI schema. Let me demonstrate with an
>
On Tue, Feb 07, 2023 at 10:48:43AM -0800, Steve Sistare wrote:
> Add some handy string list functions, for general use now, and for
> eventual use in the cpr/live update patches.
>
> Steve Sistare (4):
> qapi: strList_from_string
> qapi: QAPI_LIST_LENGTH
> qapi: strv_from_strList
> qapi: s
Hi Everyone,
Checking if there is any feedback on this.
Thanks
Manish Mishra
On 31/01/23 8:17 pm, manish.mishra wrote:
Hi Everyone,
I hope everyone is doing great. We wanted to check why we do not expose support
for HyperV features in Qemu similar to what we do for normal CPU features via
Thomas Huth writes:
> On 07/02/2023 16.39, Markus Armbruster wrote:
>> We have a boatload of CONFIG_FOO macros that may only be used in
>> target-dependent code. We use generated config-poison.h to enforce.
>> This is a bit annoying in the QAPI schema. Let me demonstrate with an
>> example: QMP
Daniel P. Berrangé writes:
> On Wed, Feb 08, 2023 at 06:35:39PM +0100, Nina Schoetterl-Glausch wrote:
[...]
>> I also wonder if you should add 'feature' : [ 'unstable' ].
>> On the upside, it would mark the event as unstable, but I don't know what the
>> consequences are exactly.
>
> The intent
Hey Thomas! I feel really confused because my patch file has all the
details that you mentioned. I wonder why it is not sending it the way it
did before.
On Thu, Feb 9, 2023, 3:39 PM Thomas Huth wrote:
>
> Hi Khadija,
>
> the diffs below look fine now ... but unfortunately the commit descripti
On Wed, 8 Feb 2023 at 09:14, Bastian Koppelmann
wrote:
>
> The following changes since commit 969d09c3a6186c0a4bc8a41db0c1aba1c76081fc:
>
> Merge tag 'pull-aspeed-20230207' of https://github.com/legoater/qemu into
> staging (2023-02-07 20:13:38 +)
>
> are available in the Git repository at:
Adding Kevin too.
I can't reproduce your issue. I tried the exact steps showed in your
mail, both with BLD_VERSION=20230205025034 (not anymore latest compose)
and BLD_VERSION=20230209025037 (currently latest), and the VM boots till
the login screen.
Talking with Kevin it looks like handle_aiocb_w
On Tue, 7 Feb 2023 at 18:47, Thomas Huth wrote:
>
> On 07/02/2023 17.51, Peter Maydell wrote:
> > The netdev-socket test intermittently fails on our s390x CI runner:
> >
> > 633/659 ERROR:../tests/qtest/netdev-socket.c:197:test_stream_unix:
> > assertion failed (resp == expect): ("st0: index=0,typ
Het Gala wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",",
On Thu, Feb 09, 2023 at 10:27:49AM +, Het Gala wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ","
Het Gala writes:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file.
Not an appropriate home.
If we have to split up a string in QAPI/QMP, we screwed up. Let me
explain.
In QAPI/QMP, data is not to be encoded in strings, it is to be
represent
On Wed, Feb 08, 2023 at 09:35:55AM +, Het Gala wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ","
On Wed, Feb 08, 2023 at 09:35:57AM +, Het Gala wrote:
> hmp_migrate() stores modified QAPI 'migrate' arguments from qdict
> into well defined MigrateChannel struct with help of
> migrate_channel_from_qdict().
> hmp_migrate() also accepts uri string as modified QAPI a 'migrate'
> argument (for b
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote:
> In existing senario, 'migrate' QAPI argument - string uri, is encoded
> twice to extract migration parameters for stream connection. This is
> not a good representation of migration wire protocol as it is a data
> encoding scheme within a
Het Gala writes:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", "
Markus Armbruster wrote:
> Het Gala writes:
>
>> renamed hmp_split_at_comma() --> str_split_at_comma()
>> Shifted helper function to qapi-util.c file.
>
> Not an appropriate home.
I don't have an opinion here.
> If we have to split up a string in QAPI/QMP, we screwed up. Let me
> explain.
>
>
On Thu, 2023-02-09 at 10:04 +, Daniel P. Berrangé wrote:
> On Wed, Feb 08, 2023 at 06:35:39PM +0100, Nina Schoetterl-Glausch wrote:
> > On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
> > > When the guest asks to change the polarity this change
> > > is forwarded to the admin using QAPI.
I introduced spurious files on my tree during a rebase:
commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
Author: Zhenzhong Duan
Date: Mon Oct 17 15:53:51 2022 +0800
multifd: Fix flush of zero copy page send request
Make IO channel flush call after the inflight request has been drained
On Thu, Feb 09, 2023 at 01:12:17PM +0100, Nina Schoetterl-Glausch wrote:
> On Thu, 2023-02-09 at 10:04 +, Daniel P. Berrangé wrote:
> > On Wed, Feb 08, 2023 at 06:35:39PM +0100, Nina Schoetterl-Glausch wrote:
> > > On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
> > > > When the guest as
On Thu, Feb 09, 2023 at 01:14:49PM +0100, Juan Quintela wrote:
> I introduced spurious files on my tree during a rebase:
>
> commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
> Author: Zhenzhong Duan
> Date: Mon Oct 17 15:53:51 2022 +0800
>
> multifd: Fix flush of zero copy page send request
On 2/9/23 13:14, Juan Quintela wrote:
I introduced spurious files on my tree during a rebase:
commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
Author: Zhenzhong Duan
Date: Mon Oct 17 15:53:51 2022 +0800
multifd: Fix flush of zero copy page send request
Make IO channel flush call af
It is just a big if in the middle of the function, and we need two
functions anways.
Signed-off-by: Juan Quintela
---
Reindent to make Phillipe happy (and CODING_STYLE)
---
migration/ram.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/migration
We are recalculating ram size continously, when we know that it don't
change during migration. Create a field in RAMState to track it.
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
---
migration/ram.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a
Hi
Changes on this series:
- Address review by Philippe.
- Added review by.
Please review.
[v3]
This is just a rebase on top of latest upstream and make
scripts/checkpatch.pl happy.
Please, review.
[v2]
I just resized this patch for latest upstream, we still have the same
trouble for huge gues
On Wed, 2023-02-08 at 20:23 +0100, Markus Armbruster wrote:
> Nina Schoetterl-Glausch writes:
>
> > On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
> > > When the guest asks to change the polarity this change
> > > is forwarded to the admin using QAPI.
> > > The admin is supposed to take a
"Duan, Zhenzhong" wrote:
> Hi Juan,
>
>>-Original Message-
>>From: Juan Quintela
>>Sent: Tuesday, February 7, 2023 8:57 AM
>>To: qemu-devel@nongnu.org
>>Cc: qemu-bl...@nongnu.org; Stefan Berger ;
>>Stefan Hajnoczi ; Halil Pasic ;
>>John Snow ; David Hildenbrand ;
>>Fam Zheng ; Thomas Huth
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> The generated code doesn't quite handle the conditional arguments.
> For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> conditions. See generated code in qmp_marshal_test_if_cmd().
>
> Note that if there are m
On 09/02/23 3:53 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote:
On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number i
On 2/9/23 13:28, Nina Schoetterl-Glausch wrote:
On Wed, 2023-02-08 at 20:23 +0100, Markus Armbruster wrote:
Nina Schoetterl-Glausch writes:
...
I also wonder if you should add 'feature' : [ 'unstable' ].
On the upside, it would mark the event as unstable, but I don't know what the
c
On 09/02/23 3:59 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri' parameter for initiating
On 2/8/23 19:40, Nina Schoetterl-Glausch wrote:
On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
The modification of the CPU attributes are done through a monitor
command.
It allows to move the core inside the topology tree to optimise
the cache usage in the case the host's hypervisor
On 09/02/23 4:01 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:59AM +, Het Gala wrote:
'migrate-incoming' QAPI design have been modified into well-defined
MigrateChannel struct to prevent multiple encoding of uri strings on
the destination side.'uri' parameter is kept for bac
On 09/02/23 4:10 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote:
In existing senario, 'migrate' QAPI argument - string uri, is encoded
twice to extract migration parameters for stream connection. This is
not a good representation of migration wire protoc
Eric Blake wrote:
> On Wed, Feb 08, 2023 at 02:30:05PM +0100, Juan Quintela wrote:
>> We used to synchronize all channels at the end of each RAM section
>> sent. That is not needed, so preparing to only synchronize once every
>> full round in latests patches.
>>
>> Notice that we initialize the
On Thu, Feb 09, 2023 at 06:41:41PM +0530, Het Gala wrote:
>
> On 09/02/23 3:59 pm, Daniel P. Berrangé wrote:
> > On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
> > > Existing 'migrate' QAPI design enforces transport mechanism, ip address
> > > of destination interface and corresponding
On Thu, Feb 09, 2023 at 06:44:40PM +0530, Het Gala wrote:
>
> On 09/02/23 4:01 pm, Daniel P. Berrangé wrote:
> > On Wed, Feb 08, 2023 at 09:35:59AM +, Het Gala wrote:
> > > 'migrate-incoming' QAPI design have been modified into well-defined
> > > MigrateChannel struct to prevent multiple encod
Eric Blake wrote:
> On Wed, Feb 08, 2023 at 02:30:10PM +0100, Juan Quintela wrote:
>> 0x80 is RAM_SAVE_FLAG_HOOK, it is in qemu-file now.
>> Bigger usable flag is 0x200, noticing that.
>> We can reuse RAM_SAVE_FLAG_FULL.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> migration/ram.c | 7 +--
>
On 09/02/23 5:32 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:55AM +, Het Gala wrote:
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file. Give external linkage, as
this function will be handy in coming commit for migration.
Min
On 09/02/23 5:30 pm, Markus Armbruster wrote:
Het Gala writes:
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file.
Not an appropriate home.
If we have to split up a string in QAPI/QMP, we screwed up. Let me
explain.
In QAPI/QMP, data is not
And called then in the wrong place.
Thanks to Avihai Horon for finding it.
Signed-off-by: Juan Quintela
---
migration/savevm.c | 50 +++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index e9cf
Hello Daniel and all,
resurrecting this series from end of last year,
do we think that this is the right approach and first step to be able to
provide good performance for virsh save and virsh restore?
For reference, our previous attempt to get the performance for our use case
(libvirt + qemu
On 9/2/23 13:26, Juan Quintela wrote:
It is just a big if in the middle of the function, and we need two
functions anways.
Signed-off-by: Juan Quintela
---
Reindent to make Phillipe happy (and CODING_STYLE)
---
migration/ram.c | 25 ++---
1 file changed, 14 insertions(+
On 09/02/23 5:35 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:57AM +, Het Gala wrote:
hmp_migrate() stores modified QAPI 'migrate' arguments from qdict
into well defined MigrateChannel struct with help of
migrate_channel_from_qdict().
hmp_migrate() also accepts uri string as
On Thu, Feb 09, 2023 at 10:23:43AM +, Daniel P. Berrangé wrote:
> On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote:
> > On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote:
> > > Existing 'migrate' QAPI design enforces transport mechanism, ip address
> > > of destination interfac
On 9/2/23 13:14, Juan Quintela wrote:
I introduced spurious files on my tree during a rebase:
commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
Author: Zhenzhong Duan
Date: Mon Oct 17 15:53:51 2022 +0800
multifd: Fix flush of zero copy page send request
Make IO channel flush call af
The npcm7xx_pwm-test produces a lot of output at V=1, which
means that on our CI tests the log files exceed the gitlab
500KB limit. Suppress the messages about exactly what is
being tested unless at V=2 and above.
This follows the pattern we use with qom-test.
Signed-off-by: Peter Maydell
---
An
Hi!
I usually build a static qemu-user binary from the git source using the
following
configure line:
export ARCH=m68k && ./configure --target-list=$ARCH-linux-user --static
--disable-rdma \
--disable-pie --disable-system --disable-xen
--disable-pvrdma \
On 09/02/23 5:39 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote:
In existing senario, 'migrate' QAPI argument - string uri, is encoded
twice to extract migration parameters for stream connection. This is
not a good representation of migration wire protoco
On 09/02/2023 14.50, Peter Maydell wrote:
The npcm7xx_pwm-test produces a lot of output at V=1, which
means that on our CI tests the log files exceed the gitlab
500KB limit. Suppress the messages about exactly what is
being tested unless at V=2 and above.
This follows the pattern we use with qom
On 09/02/23 5:42 pm, Juan Quintela wrote:
Markus Armbruster wrote:
Het Gala writes:
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file.
Not an appropriate home.
I don't have an opinion here.
If we have to split up a string in QAPI/QMP, we
On Thu, Feb 09, 2023 at 07:08:13PM +0530, Het Gala wrote:
>
> On 09/02/23 5:35 pm, Daniel P. Berrangé wrote:
> > On Wed, Feb 08, 2023 at 09:35:57AM +, Het Gala wrote:
> > > hmp_migrate() stores modified QAPI 'migrate' arguments from qdict
> > > into well defined MigrateChannel struct with help
"manish.mishra" writes:
> Hi Everyone,
>
> Checking if there is any feedback on this.
I've expanded the CC list to some relevant maintainers and people who
have touched that code in case this was missed.
> Thanks
>
> Manish Mishra
>
> On 31/01/23 8:17 pm, manish.mishra wrote:
>
> Hi Everyone
On Thu, Feb 09, 2023 at 07:24:48PM +0530, Het Gala wrote:
>
> On 09/02/23 5:39 pm, Daniel P. Berrangé wrote:
> > On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote:
> > > In existing senario, 'migrate' QAPI argument - string uri, is encoded
> > > twice to extract migration parameters for str
On Thu, 9 Feb 2023 at 13:54, John Paul Adrian Glaubitz
wrote:
>
> Hi!
>
> I usually build a static qemu-user binary from the git source using the
> following
> configure line:
>
> export ARCH=m68k && ./configure --target-list=$ARCH-linux-user --static
> --disable-rdma \
> --d
Alex Bennée writes:
> "manish.mishra" writes:
>
>> Hi Everyone,
>>
>> Checking if there is any feedback on this.
>
> I've expanded the CC list to some relevant maintainers and people who
> have touched that code in case this was missed.
>
>> Thanks
>>
>> Manish Mishra
>>
>> On 31/01/23 8:17 pm,
Hi!
On Thu, 2023-02-09 at 14:14 +, Peter Maydell wrote:
> The "Using getpwuid in statically linked applications" etc warnings
> are expected, so we can ignore those; this is the key error:
OK.
> > /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libdw.a(debuginfod-client.o): in
> > function `__libdwf
On Thu, Feb 09, 2023 at 01:14:12AM -0300, Leonardo Brás wrote:
> I got side-tracked on this issue.
>
> Is there any patch disabling multifd + postcopy, or would it be fine to go
> back
> working on a V2 for this one?
IMHO it'll always make sense to post a new version for the immediate crash.
Pe
On Thu, 9 Feb 2023 at 14:21, John Paul Adrian Glaubitz
wrote:
>
> Hi!
>
> On Thu, 2023-02-09 at 14:14 +, Peter Maydell wrote:
> > The "Using getpwuid in statically linked applications" etc warnings
> > are expected, so we can ignore those; this is the key error:
>
> OK.
>
> > > /usr/bin/ld: /u
1 - 100 of 281 matches
Mail list logo
