Het Gala <het.g...@nutanix.com> writes:
> renamed hmp_split_at_comma() --> str_split_at_comma() > Shifted helper function to qapi-util.c file. Give external linkage, as > this function will be handy in coming commit for migration. > > Minor correction: > g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> I think there has been a misunderstanding here about when to apply review tags. Looking at v2: Subject: [PATCH v2 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file Date: Wed, 8 Feb 2023 09:35:55 +0000 Message-Id: <20230208093600.242665-2-het.g...@nutanix.com> I don't see any of the above developers responding to the message with an explicit Reviewed-by tag email. We talk a bit about the process of applying tags in: https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review There are tools that can help. For example the b4 tool can fetch a series from the mailing list (via kernel.org archives) and collect the tags and apply them to the patches. It will also add Message-Id tags so you can go directly to the thread when the patch was last discussed. I would suggest you remove the tags and re-post a v4 of the series. -- Alex Bennée Virtualisation Tech Lead @ Linaro
