On 09/02/23 5:32 pm, Daniel P. Berrangé wrote:
On Wed, Feb 08, 2023 at 09:35:55AM +0000, Het Gala wrote:
renamed hmp_split_at_comma() --> str_split_at_comma()
Shifted helper function to qapi-util.c file. Give external linkage, as
this function will be handy in coming commit for migration.
Minor correction:
g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)
Suggested-by: Daniel P. Berrange <berra...@redhat.com>
Suggested-by: Manish Mishra <manish.mis...@nutanix.com>
Suggested-by: Aravind Retnakaran <aravind.retnaka...@nutanix.com>
Signed-off-by: Het Gala <het.g...@nutanix.com>
---
include/monitor/hmp.h | 1 -
include/qapi/util.h | 1 +
monitor/hmp-cmds.c | 19 -------------------
net/net-hmp-cmds.c | 2 +-
qapi/qapi-util.c | 19 +++++++++++++++++++
stats/stats-hmp-cmds.c | 2 +-
6 files changed, 22 insertions(+), 22 deletions(-)
I expect this patch can be dropped, since I don't believe it is
correct to be using it in patch 2. I left comments in that other
patch with more details.
Yes Daniel. This patch will be dropped in upcoming version of this
patchset.
With regards,
Daniel
Regards,
Het Gala
