Philippe Mathieu-Daudé writes:
> Hi Alex, Thomas.
>
> On 26/1/23 12:22, Alex Bennée wrote:
>> We don't need to play timing games to ensure one socat wins over the
>> other, just create the fifo they both can use before spawning the
>> processes. However in the process we need to disable two tes
On 2/6/23 12:57, Thomas Huth wrote:
On 01/02/2023 14.20, Pierre Morel wrote:
The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to
activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and
the topology facility in the host CPU model for the guest
in the case the topology is available in QEM
Paolo Bonzini writes:
> The library directory can change depending on the multilib setup of the host.
> It would be even better to detect it in configure with the same algorithm
> that Meson uses, but the important thing to avoid confusing developers is
> to have identical contents of scripts/m
On 6/2/23 14:11, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
Hi Alex, Thomas.
On 26/1/23 12:22, Alex Bennée wrote:
We don't need to play timing games to ensure one socat wins over the
other, just create the fifo they both can use before spawning the
processes. However in the process w
On Mon, Feb 06, 2023 at 06:17:50PM +0800, Bin Meng wrote:
> On Thu, Feb 2, 2023 at 12:54 PM Sunil V L wrote:
> >
> > Add few basic ACPI tables and DSDT with few devices in a
> > new file virt-acpi-build.c.
> >
> > These are mostly leveraged from arm64.
>
> There are lots of same ACPI codes existi
On 2/4/23 05:36, Akihiko Odaki wrote:
Signed-off-by: Akihiko Odaki
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
MAINTAINERS | 1 +
docs/system/device-emulation.rst | 1 +
docs/system/devices/igb.rst | 71
3 files changed, 7
g_hash_table_destroy() and g_hash_table_foreach_remove() (called by
curl_drop_all_sockets()) both require the table to be non-NULL, or will
print assertion failures (just print, no abort).
There are several paths in curl_open() that can lead to the out_noclean
label without s->sockets being alloca
Hi Connie,
On 2/3/23 14:44, Cornelia Huck wrote:
> Introduce a new cpu feature flag to control MTE support. To preserve
> backwards compatibility for tcg, MTE will continue to be enabled as
> long as tag memory has been provided.
>
> If MTE has been enabled, we need to disable migration, as we do
On 2/4/23 05:36, Akihiko Odaki wrote:
Based-on: <20230201033539.30049-1-akihiko.od...@daynix.com>
([PATCH v5 00/29] e1000x cleanups (preliminary for IGB))
For both series,
Tested-by: Cédric Le Goater
In a KVM guest with two VFs, one of which being pass-through in a nested KVM.
Thanks,
C.
On Mon, Feb 06, 2023 at 02:29:49PM +0100, Hanna Czenczek wrote:
> g_hash_table_destroy() and g_hash_table_foreach_remove() (called by
> curl_drop_all_sockets()) both require the table to be non-NULL, or will
> print assertion failures (just print, no abort).
>
> There are several paths in curl_ope
On 2/6/23 05:00, Cédric Le Goater wrote:
On 2/3/23 22:16, Philippe Mathieu-Daudé wrote:
part 1 [*] cover:
--
QEMU provides the QOM API for core objects.
Devices are modelled on top of QOM as QDev objects.
There is no point in using the lower level QOM API with
QDev; it makes the code more co
Mads Ynddal writes:
>> It will do. You could just call it update_guest_debug as it is an
>> internal static function although I guess that makes grepping a bit of a
>> pain.
>
> I agree. It should preferably be something unique, to ease grep'ing.
>
>> Is something being accidentally linked with
The microchip_icicle_kit, sifive_u, spike and virt boards are now doing
the same steps when '-kernel' is used:
- execute load_kernel()
- load init_rd()
- write kernel_cmdline
Let's fold everything inside riscv_load_kernel() to avoid code
repetition. To not change the behavior of boards that aren'
Next patch will move all calls to riscv_load_initrd() to
riscv_load_kernel(). Machines that want to load initrd will be able to
do via an extra flag to riscv_load_kernel().
This change will expose a sign-extend behavior that is happening in
load_elf_ram_sym() when running 32 bit guests [1]. This i
The only remaining caller is riscv_load_kernel_and_initrd() which
belongs to the same file.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Bin Meng
Reviewed-by: Alistair Francis
---
hw/riscv/boot.c | 80 -
Hi,
In this new version patch 1 was changed to extract the lower 32 bits of
the 64 bit address when running 32 bit CPUs. The difference now, in comparison
with what was being done in version 6, is that now we're doing that for
all uses of kernel_entry, not just the one resulting from load_elf_ram_
On 2/6/23 13:21, Thomas Huth wrote:
On 01/02/2023 14.20, Pierre Morel wrote:
The modification of the CPU attributes are done through a monitor
command.
It allows to move the core inside the topology tree to optimise
I'm not a native speaker, but "optimize" is more common, I think?
Yes. I
The 'virt' machine uses virtio-net-pci as a fallback when no other
network driver has been selected via command line. Select VIRTIO_NET
and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n
(due to e.g. --without-default-devices):
$ ./qemu-system-aarch64 -M virt -accel tcg -cpu ma
This machine explicitly selects the e1000e network adapter if no other
option was given in the command line. Make sure e1000e is present in
the build.
Signed-off-by: Fabiano Rosas
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 823f8b1
The sbsa-ref machine explicitly creates a VGA PCI device, so make sure
vga-pci.c is included in the build.
Signed-off-by: Fabiano Rosas
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 5022d519ea..74fceb419d 100644
--- a/hw/arm/Kconfig
The virt machine has IF_VIRTIO as block_default_type, which causes the
generic code to try to create a virtio-blk-pci device pair at
configure_blockdev()/qemu_create_cli_devices().
Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors
when PCI_DEVICES=n (due to e.g. --without-defau
Currently the isa-parallel driver is always added by default
regardless of the presence of the actual code in the build, which can
lead to a crash:
qemu-system-i386: unknown type 'isa-parallel'
Aborted (core dumped)
Check for the presence of the QOM class and do not include
isa-parallel by defaul
Machines that have "std" as default VGA display need to always build
vga-pci.c, otherwise we get a crash when CONFIG_PCI_DEVICES=n:
$ ./qemu-system-x86_64 -M q35 -vga std
qemu-system-x86_64: unknown type 'VGA'
Aborted (core dumped)
Signed-off-by: Fabiano Rosas
---
hw/i386/Kconfig | 2 +-
1 file
On 230205 1139, Philippe Mathieu-Daudé wrote:
> On 5/2/23 05:29, Alexander Bulekov wrote:
>
> > * Some device do not completely reset their state. This can lead to
> > non-reproducible crashes. However, in my local tests, most crashes
> > were reproducible. OSS-Fuzz shouldn't send us rep
On 1/18/23 20:47, Stefan Hajnoczi wrote:
> This is a preview of the iothread-vq-mapping parameter that assigns virtqueues
> to IOThreads. The syntax is implemented but multiple IOThreads are not
> actually
> supported yet. The purpose of this RFC is to reach agreement on the syntax and
> to prepar
We currently have a situation where disabling a Kconfig might result
in a runtime error when QEMU selects the corresponding device as a
default value for an option. But first a disambiguation:
Kconfig default::
a device "Foo" for which there's "config FOO default y" or "config X
imply FOO" in
When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.
Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
Signed-off-by: Alex Bennée
This machine hardcodes initialization of the USB device, so select the
corresponding Kconfig. It is not enough to have it as "default y if
XLNX_VERSAL" at usb/Kconfig because building --without-default-devices
disables the default selection resulting in:
$ ./qemu-system-aarch64 -M xlnx-zcu102
qemu
The i440fx machines uses the e1000 adapter as the default when no
other network card is configured.
Move the E1000_PCI entry in Kconfig from 'imply' to 'select' to avoid
the following situation:
./qemu-system-i386 -machine pc-i440fx-8.0
qemu-system-i386: Unsupported NIC model: e1000
Signed-off-b
This machine hardcodes the creation of the interrupt controller, so
make sure the dependency is explicitly described in the Kconfig.
Signed-off-by: Fabiano Rosas
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 552e3d04ee..823f8b11f1 10
The e1000e network adapter is the default network card for the q35
machine. Make sure that CONFIG is always selected for that machine.
Signed-off-by: Fabiano Rosas
---
hw/i386/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 1bf4
On 2/6/23 13:38, Thomas Huth wrote:
On 01/02/2023 14.20, Pierre Morel wrote:
S390x provides two more topology containers above the sockets,
books and drawers.
books and drawers are already handled via the entries in
CpuInstanceProperties, so this sentence looks like a wrong leftover now?
On 2/6/23 13:49, Daniel P. Berrangé wrote:
On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote:
On 01/02/2023 14.20, Pierre Morel wrote:
S390x provides two more topology containers above the sockets,
books and drawers.
Let's add these CPU attributes to the QAPI command query-cpu-fas
On Mon, Feb 06, 2023 at 06:29:46PM +0800, Bin Meng wrote:
> On Thu, Feb 2, 2023 at 12:54 PM Sunil V L wrote:
> >
> > Enable ACPI related config options to build ACPI subsystem
> > for virt machine.
> >
> > Signed-off-by: Sunil V L
> > ---
> > hw/riscv/Kconfig | 3 +++
> > 1 file changed, 3 inser
On Mon, 6 Feb 2023 at 14:14, Fabiano Rosas wrote:
>
> We currently have a situation where disabling a Kconfig might result
> in a runtime error when QEMU selects the corresponding device as a
> default value for an option. But first a disambiguation:
>
> Kconfig default::
> a device "Foo" for wh
On Mon, 6 Feb 2023 at 06:53, Eugenio Perez Martin wrote:
>
> On Sun, Feb 5, 2023 at 2:57 PM Stefan Hajnoczi wrote:
> >
> > On Sun, 5 Feb 2023 at 03:15, Eugenio Perez Martin
> > wrote:
> > >
> > > On Fri, Jan 27, 2023 at 4:18 PM Stefan Hajnoczi
> > > wrote:
> > > >
> > > > Dear QEMU, KVM, and
On Mon, 6 Feb 2023 at 14:10, Fabiano Rosas wrote:
>
> This machine hardcodes initialization of the USB device, so select the
> corresponding Kconfig. It is not enough to have it as "default y if
> XLNX_VERSAL" at usb/Kconfig because building --without-default-devices
> disables the default selecti
On Mon, 6 Feb 2023 at 14:10, Fabiano Rosas wrote:
>
> This machine hardcodes the creation of the interrupt controller, so
> make sure the dependency is explicitly described in the Kconfig.
>
> Signed-off-by: Fabiano Rosas
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --
On Mon, 6 Feb 2023 at 14:10, Fabiano Rosas wrote:
>
> The sbsa-ref machine explicitly creates a VGA PCI device, so make sure
> vga-pci.c is included in the build.
>
> Signed-off-by: Fabiano Rosas
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/
On Mon, 6 Feb 2023 at 03:33, Anton Yakovlev
wrote:
> If anything, I'm here. Not sure I'll have time to be a mentor, but if there
> are any questions I can answer, you're welcome.
Thank you, Anton!
Stefan
Hi guys,
If anything, I'm here. Not sure I'll have time to be a mentor, but if there
are any questions I can answer, you're welcome.
On 31.01.2023 16:35, Stefan Hajnoczi wrote:
On Sun, 29 Jan 2023 at 17:10, Stefan Hajnoczi wrote:
Hi Shreyansh, Gerd, and Laurent,
The last virtio-sound RFC wa
On 6/2/23 13:17, Philippe Mathieu-Daudé wrote:
Avoid having QOM objects poke at each other internals.
Instead, pass references using QOM link properties.
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Mark Cave-Ayland
---
hw/arm/armv7m.c | 4 ++--
hw/intc/armv7m_nvic.c | 3 ++-
target
On 6/2/23 14:29, Hanna Czenczek wrote:
g_hash_table_destroy() and g_hash_table_foreach_remove() (called by
curl_drop_all_sockets()) both require the table to be non-NULL, or will
print assertion failures (just print, no abort).
There are several paths in curl_open() that can lead to the out_nocl
On Sun, 5 Feb 2023 at 07:44, Dinah Baum wrote:
>
> QEMU configure script goes into an infinite error printing loop
> when in read only directory due to 'build' dir never being created.
>
> Checking if 'mkdir dir' succeeds and if the directory is
> writeable prevents this error.
>
> Resolves: https
> -Original Message-
> From: Richard Henderson
> Sent: Tuesday, January 31, 2023 11:46 PM
> To: Sid Manning ; qemu-devel@nongnu.org
> Cc: Mark Burton ; Brian Cain
> ; Matheus Bernardino
>
> Subject: Re: accel/tcg/translator.c question about translator_access
>
> WARNING: This email ori
On Mon, Feb 06, 2023 at 02:09:57PM +0100, Thomas Huth wrote:
> On 06/02/2023 13.49, Daniel P. Berrangé wrote:
> > On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote:
> > > On 01/02/2023 14.20, Pierre Morel wrote:
> > > > S390x provides two more topology containers above the sockets,
> > >
On 6/2/23 15:10, Alex Bennée wrote:
When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.
Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel
On 6/2/23 13:32, Paolo Bonzini wrote:
The library directory can change depending on the multilib setup of the host.
It would be even better to detect it in configure with the same algorithm
that Meson uses, but the important thing to avoid confusing developers is
to have identical contents of scr
Peter Maydell writes:
> On Mon, 6 Feb 2023 at 14:14, Fabiano Rosas wrote:
>>
>> We currently have a situation where disabling a Kconfig might result
>> in a runtime error when QEMU selects the corresponding device as a
>> default value for an option. But first a disambiguation:
>>
>> Kconfig def
On 6/2/23 15:08, Fabiano Rosas wrote:
Currently the isa-parallel driver is always added by default
regardless of the presence of the actual code in the build, which can
lead to a crash:
qemu-system-i386: unknown type 'isa-parallel'
Aborted (core dumped)
Check for the presence of the QOM class a
This test depends on the presence of the pcie-root-port device. Add a
build time dependency and a runtime check.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 3 ++-
tests/qtest/virtio-net-failover.c | 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/
Check if the devices we're trying to add are present in the QEMU
binary. They could have been removed from the build via Kconfig or the
--without-default-devices option.
Signed-off-by: Fabiano Rosas
---
tests/qtest/pxe-test.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/px
The tests are built once for all the targets, so as long as one QEMU
binary is built with CONFIG_LSI_SCSI_PCI=y, this test will
run. However some binaries might not include the device. So check this
again in runtime.
Signed-off-by: Fabiano Rosas
---
tests/qtest/fuzz-lsi53c895a-test.c | 4
1
Check that virtio-scsi-pci is present in the QEMU build before running
the tests.
Signed-off-by: Fabiano Rosas
---
tests/qemu-iotests/186 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/186 b/tests/qemu-iotests/186
index 072e54e62b..eaf13c7a33 100755
--- a/tests/qemu-iotes
Most of our tests assume the presence of default devices. When
building --without-default-devices or with individual CONFIGs
disabled, several tests fail.
I went through them one by one and did local changes to skip or avoid
including tests that require devices that are missing. With these
initial
Do not include tests that require devices that are not available in
the QEMU build.
Signed-off-by: Fabiano Rosas
---
tests/qtest/bios-tables-test.c | 75 --
1 file changed, 71 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
The QEMU binary can be built with a varied set of features/devices
which are opaque to the tests. Add a centralized point for parsing and
validating the command line.
Tests can now be skipped with the following pattern:
qts = qtest_init(args);
if (!qts) {
return;
}
For now, the only validati
Signed-off-by: Fabiano Rosas
---
tests/qtest/hexloader-test.c | 5 +
tests/qtest/meson.build | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/hexloader-test.c b/tests/qtest/hexloader-test.c
index 3023548041..3ab464f438 100644
--- a/tests/qtest/hexloade
If we build with --without-default-devices, CONFIG_HPET and
CONFIG_PARALLEL are set to N, which makes the respective devices go
missing from acpi tables.
Signed-off-by: Fabiano Rosas
---
I currently don't see a way of allowing the tests to pass in the
absence of these two configs. As far as I und
Don't include tests that require devices not available in the QEMU
binary.
Signed-off-by: Fabiano Rosas
---
tests/qtest/hd-geo-test.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c
Signed-off-by: Fabiano Rosas
---
tests/qtest/drive_del-test.c | 70
1 file changed, 70 insertions(+)
diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c
index 9a750395a9..6fa96fa94a 100644
--- a/tests/qtest/drive_del-test.c
+++ b/tests/qt
Signed-off-by: Fabiano Rosas
---
tests/qtest/device-plug-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 5a6afa2b57..931acbdf50 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/devic
On 6/2/23 15:00, Daniel Henrique Barboza wrote:
The microchip_icicle_kit, sifive_u, spike and virt boards are now doing
the same steps when '-kernel' is used:
- execute load_kernel()
- load init_rd()
- write kernel_cmdline
Let's fold everything inside riscv_load_kernel() to avoid code
repetitio
The virtconsole device might not be present in the QEMU build that is
being tested. Skip the test if that's the case.
Signed-off-by: Fabiano Rosas
---
tests/qtest/virtio-serial-test.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/virtio-serial-test.c b/tests/qtest/virtio-se
On 6/2/23 15:00, Daniel Henrique Barboza wrote:
Next patch will move all calls to riscv_load_initrd() to
riscv_load_kernel(). Machines that want to load initrd will be able to
do via an extra flag to riscv_load_kernel().
This change will expose a sign-extend behavior that is happening in
load_el
Philippe Mathieu-Daudé writes:
> On 6/2/23 15:10, Alex Bennée wrote:
>> When we re-factored we dropped the unlink() step which turns out to be
>> required for rmdir to do its thing. If we had been checking the return
>> value we would have noticed so lets do that with this fix.
>> Fixes: 68406d
On Mon, Feb 06, 2023 at 12:04:12PM -0300, Fabiano Rosas wrote:
> Do not include tests that require devices that are not available in
> the QEMU build.
>
> Signed-off-by: Fabiano Rosas
Acked-by: Michael S. Tsirkin
feel free to merge with rest of the patchset.
> ---
> tests/qtest/bios-tables-t
On 6/2/23 00:29, Mark Cave-Ayland wrote:
On 03/02/2023 11:36, Philippe Mathieu-Daudé wrote:
These patches are extracted from a QOM/QDev refactor series,
so they are preliminary cleanups noticed while working on it:
- Use correct type when calling qdev_prop_set_xxx()
- Unify some qdev propertie
On 6/2/23 16:04, Fabiano Rosas wrote:
The tests are built once for all the targets, so as long as one QEMU
binary is built with CONFIG_LSI_SCSI_PCI=y, this test will
run. However some binaries might not include the device. So check this
again in runtime.
Signed-off-by: Fabiano Rosas
---
tests
Hello,
On 1/20/23 13:25, Kevin Wolf wrote:
From: Xiang Zheng
Currently we fill the VIRT_FLASH memory space with two 64MB NOR images
when using persistent UEFI variables on virt board. Actually we only use
a very small(non-zero) part of the memory while the rest significant
large(zero) part of
On Sat, Feb 4, 2023, 6:34 AM Markus Armbruster wrote:
> John Snow writes:
>
> > Newer versions of pylint disable the "no-self-use" message by
> > default. Older versions don't, though. If we leave the suppressions in,
> > pylint yelps about useless options. Just tell pylint to shush.
> >
> > Sig
On Mon, Feb 06 2023, Eric Auger wrote:
> Hi,
>
> On 2/3/23 21:40, Richard Henderson wrote:
>> On 2/3/23 03:44, Cornelia Huck wrote:
>>> +static void aarch64_cpu_get_mte(Object *obj, Visitor *v, const char
>>> *name,
>>> + void *opaque, Error **errp)
>>> +{
>>> +
Hi Mark & Laurent,
In commit d811d61fbc6 Mark defined VIA_TIMER_FREQ as 470 / 6
(78.33) and in commit 6dca62a Laurent defined it as 783360.
What is the correct value?
Could we define it once in include/hw/misc/mac_via.h or
even include/hw/misc/mos6522.h?
Thanks,
Phil.
On 6/2/23 17:22, Philippe Mathieu-Daudé wrote:
Hi Mark & Laurent,
In commit d811d61fbc6 Mark defined VIA_TIMER_FREQ as 470 / 6
(78.33) and in commit 6dca62a Laurent defined it as 783360.
Also 470 / 6 in hw/misc/macio/cuda.c (commit 267002cd28).
What is the correct value?
Cou
On Mon, 6 Feb 2023 at 07:36, Hanna Czenczek wrote:
>
> Hi Stefan,
>
> For true virtio-fs migration, we need to migrate the daemon’s (back
> end’s) state somehow. I’m addressing you because you had a talk on this
> topic at KVM Forum 2021. :)
>
> As far as I understood your talk, the only standard
> -Original Message-
> From: Akihiko Odaki
> Sent: Saturday, 4 February 2023 05:36
> Cc: Jason Wang ; Dmitry Fleytman
> ; Michael S . Tsirkin ;
> Marcel Apfelbaum ; Alex Bennée
> ; Philippe Mathieu-Daudé ;
> Thomas Huth ; Wainer dos Santos Moschetta
> ; Beraldo Leal ; Cleber Rosa
> ; Laure
On Fri, Feb 03 2023, Richard Henderson wrote:
> On 2/3/23 03:44, Cornelia Huck wrote:
>> +static inline bool arm_machine_has_tag_memory(void)
>> +{
>> +#ifndef CONFIG_USER_ONLY
>> +Object *obj = object_dynamic_cast(qdev_get_machine(),
>> TYPE_VIRT_MACHINE);
>> +
>> +/* so far, only the v
On Mon, Feb 6, 2023 at 3:21 PM Stefan Hajnoczi wrote:
>
> On Mon, 6 Feb 2023 at 06:53, Eugenio Perez Martin wrote:
> >
> > On Sun, Feb 5, 2023 at 2:57 PM Stefan Hajnoczi wrote:
> > >
> > > On Sun, 5 Feb 2023 at 03:15, Eugenio Perez Martin
> > > wrote:
> > > >
> > > > On Fri, Jan 27, 2023 at 4:
Philippe Mathieu-Daudé writes:
> On 6/2/23 15:08, Fabiano Rosas wrote:
>> Currently the isa-parallel driver is always added by default
>> regardless of the presence of the actual code in the build, which can
>> lead to a crash:
>>
>> qemu-system-i386: unknown type 'isa-parallel'
>> Aborted (core
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG emulation to put one guest instruction in each TB,
which can be useful in some situations.
Create a new command line argument -one-insn-per-tb, so we ca
The command line option '-singlestep' and its HMP equivalent
the 'singlestep' command are very confusingly named, because
they have nothing to do with single-stepping the guest (either
via the gdb stub or by emulation of guest CPU architectural
debug facilities). What they actually do is put TCG in
The 'singlestep' HMP command is confusing, because it doesn't
actually have anything to do with single-stepping the CPU. What it
does do is force TCG emulation to put one guest instruction in each
TB, which can be useful in some situations.
Create a new HMP command 'one-insn-per-tb', so we can d
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG emulation to put one guest instruction in each TB,
which can be useful in some situations.
Create a new command line argument -one-insn-per-tb, so we ca
The 'singlestep' global variable is badly misnamed, because it has
nothing to do with single-stepping the emulation either via the gdb
stub or by emulation of architectural debug facilities. Instead what
it does is force TCG to put only one instruction into each TB.
Rename it to one_insn_per_tb, s
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG emulation to put one guest instruction in each TB,
which can be useful in some situations.
Create a new command line argument -one-insn-per-tb, so we ca
On Mon, 6 Feb 2023 at 11:47, Eugenio Perez Martin wrote:
>
> On Mon, Feb 6, 2023 at 3:21 PM Stefan Hajnoczi wrote:
> >
> > On Mon, 6 Feb 2023 at 06:53, Eugenio Perez Martin
> > wrote:
> > >
> > > On Sun, Feb 5, 2023 at 2:57 PM Stefan Hajnoczi wrote:
> > > >
> > > > On Sun, 5 Feb 2023 at 03:15,
Since V3:
- Rebased on upstream today.
- Refreshed DSDT.cxl due to changes upstream.
- Picked up tags from Gregory.
A small collection of misc fixes and tidying up pulled out from various
series. I've pulled this to the top of my queue of CXL related work
as they stand fine on their own and it wil
msix_init_exclusive_bar() can fail, so if it does cleanup the address space.
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
hw/mem/cxl_type3.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/m
Fix capitalization difference between struct name and typedef.
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
hw/pci-bridge/cxl_downstream.c | 2 +-
1 file c
From: Gregory Price
Current code sets to STORAGE_EXPRESS and then overrides it.
Reviewed-by: Davidlohr Bueso
Reviewed-by: Ira Weiny
Signed-off-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
hw/mem/cxl_type3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/me
From: Gregory Price
Remove usage of magic numbers when accessing capacity fields and replace
with CXL_CAPACITY_MULTIPLIER, matching the kernel definition.
Signed-off-by: Gregory Price
Reviewed-by: Davidlohr Bueso
Signed-off-by: Jonathan Cameron
---
v2:
Change to 256 * MiB and include qemu/un
Noticed as this prevents iASL disasembling the DSDT table.
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
hw/i386/acpi-build.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 1
Next patch will drop duplicate _UID entry so allow update.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/test
Dropping the ID effects this table in trivial fashion.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
---
tests/data/acpi/q35/DSDT.cxl| Bin 9578 -> 9564 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 files changed, 1 deletion(
From: Ira Weiny
Gcc requires constant versions of cpu_to_le* calls.
Add a 64 bit version.
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Ira Weiny
Signed-off-by: Jonathan Cameron
---
v2: Update comment (Ph
From: Ira Weiny
UUID's are defined as network byte order fields. No static initializer
was available for UUID's in their standard big endian format.
Define a big endian initializer for UUIDs.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Ira Weiny
Signed-off-by: Jonatha
From: Ira Weiny
The cel_uuid was programatically generated previously because there was
no static initializer for network order UUIDs.
Use the new network order initializer for cel_uuid. Adjust
cxl_initialize_mailbox() because it can't fail now.
Update specification reference.
Reviewed-by: Ph
Philippe Mathieu-Daudé writes:
> On 6/2/23 16:04, Fabiano Rosas wrote:
>> The tests are built once for all the targets, so as long as one QEMU
>> binary is built with CONFIG_LSI_SCSI_PCI=y, this test will
>> run. However some binaries might not include the device. So check this
>> again in runtim
On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote:
> During a subsystem reset the Topology-Change-Report is cleared
> by the machine.
> Let's ask KVM to clear the Modified Topology Change Report (MTCR)
> bit of the SCA in the case of a subsystem reset.
>
> Signed-off-by: Pierre Morel
> ---
>
On 2/6/23 07:13, Peter Maydell wrote:
So, questions:
(1) is this worth bothering with at all? We could just
name our global variable etc better, and document what
-singlestep actually does, and not bother with the new
names for the options/commands.
(2) if we do do it, do we retai
101 - 200 of 421 matches
Mail list logo
