Re: [PATCH 01/10] qga: Remove platform GUID definitions

2022-11-10 Thread Konstantin Kostiuk
On Thu, Nov 10, 2022 at 8:25 AM Akihiko Odaki wrote: > GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already > defined by MinGW-w64. They are not only unnecessary, but can lead to > duplicate definition errors at link time with some unknown condition. > What version of MinGW-w64 d

[PATCH] virtio-net: fix for heap-buffer-overflow

2022-11-10 Thread Xuan Zhuo
Run shell script: cat << EOF | valgrind qemu-system-i386 -display none -machine accel=qtest, -m \ 512M -M q35 -nodefaults -device virtio-net,netdev=net0 -netdev \ user,id=net0 -qtest stdio outl 0xcf8 0x8810 outl 0xcfc 0xc000 outl 0xcf8 0x8804 outl 0xcfc 0x01

Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Thomas Huth
On 09/11/2022 22.56, Philippe Mathieu-Daudé wrote: On 9/11/22 18:37, Thomas Huth wrote: If configuring with "--disable-system --disable-user --enable-guest-agent" the linking currently fails with: qga/qemu-ga.p/commands.c.o: In function `qmp_command_info': build/../../home/thuth/devel/qemu/qga/

[PATCH v2] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Thomas Huth
If configuring with "--disable-system --disable-user --enable-guest-agent" the linking currently fails with: qga/qemu-ga.p/commands.c.o: In function `qmp_command_info': build/../../home/thuth/devel/qemu/qga/commands.c:70: undefined reference to `qmp_command_name' build/../../home/thuth/devel/qemu

Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Thomas Huth
On 10/11/2022 06.49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 9/11/22 18:37, Thomas Huth wrote: If configuring with "--disable-system --disable-user --enable-guest-agent" the linking currently fails with: qga/qemu-ga.p/commands.c.o: In function `qmp_command_info': build/../

Re: [PATCH 1/4] rtl8139: Remove unused variable

2022-11-10 Thread Thomas Huth
On 09/11/2022 16.57, mreza...@redhat.com wrote: From: Miroslav Rezanina Variable send_count used in rtl8139_cplus_transmit_one function is only incremented but never read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Sig

Re: [PATCH 2/4] tulip: Remove unused variable

2022-11-10 Thread Thomas Huth
On 09/11/2022 16.57, mreza...@redhat.com wrote: From: Miroslav Rezanina Variable n used in tulip_idblock_crc function is only incremented but never read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Signed-off-by: Miros

Re: [PATCH 3/4] qemu-img: remove unused variable

2022-11-10 Thread Thomas Huth
On 09/11/2022 16.57, mreza...@redhat.com wrote: From: Miroslav Rezanina Variable block_count used in img_dd function is only incremented but never read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Signed-off-by: Mirosla

Re: [PATCH 4/4] host-libusb: Remove unused variable

2022-11-10 Thread Thomas Huth
On 09/11/2022 16.57, mreza...@redhat.com wrote: From: Miroslav Rezanina Variable unconnected used in usb_host_auto_check function is only incremented but never read as line where it is read was disabled since introducing the code. This causes 'Unused but set variable' warning on Clang 15.0.1 co

Re: [PATCH] Use a more portable way to enable target specific functions

2022-11-10 Thread Daniel P . Berrangé
On Thu, Nov 10, 2022 at 02:43:28PM +1100, Richard Henderson wrote: > On 11/10/22 09:03, Tom Stellard wrote: > > This adds function attributes for avx2, sse2, etc. specialized > > functions. These attributes are supported by both clang and gcc and > > are necessary in order to build the code with c

[PATCH] target/arm: added cortex-a55 CPU support for qemu-virt

2022-11-10 Thread Timofey Kutergin
cortex-a55 is one of newer armv8.2+ CPUs supporting native Privileged Access Never (PAN) feature. Using this CPU provides access to this feature without using fictious "max" CPU. Signed-off-by: Timofey Kutergin --- hw/arm/virt.c | 1 + target/arm/cpu64.c | 55 ++

Re: [PATCH] virtio-net: fix for heap-buffer-overflow

2022-11-10 Thread Jason Wang
On Thu, Nov 10, 2022 at 4:28 PM Xuan Zhuo wrote: > > Run shell script: > > cat << EOF | valgrind qemu-system-i386 -display none -machine > accel=qtest, -m \ > 512M -M q35 -nodefaults -device virtio-net,netdev=net0 -netdev \ > user,id=net0 -qtest stdio > outl 0xcf8 0x8810 >

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-10 Thread Peter Maydell
On Wed, 9 Nov 2022 at 21:42, Michael S. Tsirkin wrote: > > > diff --git a/hw/display/meson.build b/hw/display/meson.build > > > index adc53dd8b6..7a725ed80e 100644 > > > --- a/hw/display/meson.build > > > +++ b/hw/display/meson.build > > > @@ -38,10 +38,21 @@ softmmu_ss.add(when: 'CONFIG_NEXTCUBE

Re: [PATCH] virtio-net: fix for heap-buffer-overflow

2022-11-10 Thread Xuan Zhuo
On Thu, 10 Nov 2022 17:18:23 +0800, Jason Wang wrote: > On Thu, Nov 10, 2022 at 4:28 PM Xuan Zhuo wrote: > > > > Run shell script: > > > > cat << EOF | valgrind qemu-system-i386 -display none -machine > > accel=qtest, -m \ > > 512M -M q35 -nodefaults -device virtio-net,netdev=net0 -netde

Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 09:35, Thomas Huth wrote: On 10/11/2022 06.49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 9/11/22 18:37, Thomas Huth wrote: If configuring with "--disable-system --disable-user --enable-guest-agent" the linking currently fails with: qga/qemu-ga.p/commands.c.o: I

Re: [PATCH v2] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 09:36, Thomas Huth wrote: If configuring with "--disable-system --disable-user --enable-guest-agent" the linking currently fails with: qga/qemu-ga.p/commands.c.o: In function `qmp_command_info': build/../../home/thuth/devel/qemu/qga/commands.c:70: undefined reference to `qmp_command

Re: [PATCH for-7.2 v2 2/6] hw/nvme: fix cancellation of format operations

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 08:05, Klaus Jensen wrote: From: Klaus Jensen Cancelling a format operation neglects to set iocb->ret as well as clearing the iocb->aiocb after cancelling the underlying aiocb. Fix this. Fixes: 3bcf26d3d619 ("hw/nvme: reimplement format nvm to allow cancellation") Signed-off-by: K

Re: [PATCH for-7.2 v2 2/6] hw/nvme: fix cancellation of format operations

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 10:53, Philippe Mathieu-Daudé wrote: On 10/11/22 08:05, Klaus Jensen wrote: From: Klaus Jensen Cancelling a format operation neglects to set iocb->ret as well as clearing the iocb->aiocb after cancelling the underlying aiocb. Fix this. Fixes: 3bcf26d3d619 ("hw/nvme: reimplement f

[PATCH v1] virtio-net: fix for heap-buffer-overflow

2022-11-10 Thread Xuan Zhuo
Run shell script: cat << EOF | valgrind qemu-system-i386 -display none -machine accel=qtest, -m \ 512M -M q35 -nodefaults -device virtio-net,netdev=net0 -netdev \ user,id=net0 -qtest stdio outl 0xcf8 0x8810 outl 0xcfc 0xc000 outl 0xcf8 0x8804 outl 0xcfc 0x01

Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Thomas Huth
On 10/11/2022 10.49, Philippe Mathieu-Daudé wrote: On 10/11/22 09:35, Thomas Huth wrote: On 10/11/2022 06.49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 9/11/22 18:37, Thomas Huth wrote: If configuring with "--disable-system --disable-user --enable-guest-agent" the linking c

Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Philippe Mathieu-Daudé
On 10/11/22 07:23, Klaus Jensen wrote: From: Klaus Jensen Make nvme_check_constraints() return a bool and fix an invalid error propagation where the actual error is thrown away in favor of an unused local Error value. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 48 +

Re: [PATCH v2 2/2] hw/nvme: cleanup error reporting in nvme_init_pci()

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Replace the local Error variable with errp and ERRP_GUARD() and change > the return value to bool. > > Reviewed-by: Markus Armbruster > Signed-off-by: Klaus Jensen > --- > hw/nvme/ctrl.c | 23 ++- > 1 file changed, 10 insertion

Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Make nvme_check_constraints() return a bool and fix an invalid error > propagation where the actual error is thrown away in favor of an unused > local Error value. Is it? I think you're talking about ... > Signed-off-by: Klaus Jensen > --- > hw/

Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

2022-11-10 Thread Daniel P . Berrangé
On Thu, Nov 10, 2022 at 10:57:27AM +0100, Thomas Huth wrote: > On 10/11/2022 10.49, Philippe Mathieu-Daudé wrote: > > On 10/11/22 09:35, Thomas Huth wrote: > > > On 10/11/2022 06.49, Markus Armbruster wrote: > > > > Philippe Mathieu-Daudé writes: > > > > > > > > > On 9/11/22 18:37, Thomas Huth wr

[PATCH v2 07/10] virtiofsd: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the path to a lock file. Signed-off-by: Akihiko Odaki --- tools/virtiofsd/fuse_virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 9368e292e4..b9eeed85e6

[PATCH v2 02/10] util: Introduce qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() returns a dynamically allocated directory path that is appropriate for storing runtime files. It corresponds to "run" directory in Unix. With a tree-wide search, it was found that there are several cases where such a functionality is implemented so let's have one as a common

[PATCH v2 06/10] scsi: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the default paths. Signed-off-by: Akihiko Odaki --- scsi/qemu-pr-helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index 196b78c00d..adb7baecaa 100644 --- a/scsi/qemu-pr-hel

[PATCH v2 05/10] qga: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the default state directory. Signed-off-by: Akihiko Odaki --- qga/main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/qga/main.c b/qga/main.c index b3580508fa..dc875079f0 100644 --- a/qga/main.c +++ b/qga/main.c @@ -46,1

[PATCH v2 00/10] util: Introduce qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() returns a dynamically allocated directory path that is appropriate for storing runtime files. It corresponds to "run" directory in Unix. With a tree-wide search, it was found that there are several cases where such a functionality is implemented so let's have one as a common

[PATCH v2 04/10] contrib/rdmacm-mux: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the default Unix socket path. Signed-off-by: Akihiko Odaki --- contrib/rdmacm-mux/main.c | 22 ++ contrib/rdmacm-mux/meson.build | 2 +- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/contrib/rdmacm-mux/main.c

[PATCH v2 03/10] ivshmem-server: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the default PID file path. Signed-off-by: Akihiko Odaki --- contrib/ivshmem-server/main.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index 224d

[PATCH v2 10/10] spice-app: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() provides QEMU-specific fallback of runtime directory. Signed-off-by: Akihiko Odaki --- ui/spice-app.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/spice-app.c b/ui/spice-app.c index 7e71e18da9..feb162baa7 100644 --- a/ui/spice-app.c +++ b/ui/s

[PATCH v2 01/10] qga: Remove platform GUID definitions

2022-11-10 Thread Akihiko Odaki
GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already defined by MinGW-w64. They are not only unnecessary, but can lead to duplicate definition errors at link time with some unknown condition. Signed-off-by: Akihiko Odaki --- qga/commands-win32.c | 7 --- 1 file changed, 7 del

[PATCH v2 08/10] module: Use qemu_get_runtime_dir()

2022-11-10 Thread Akihiko Odaki
qemu_get_runtime_dir() is used to construct the path to module upgrades. Signed-off-by: Akihiko Odaki --- util/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 32e263163c..580658edf4 100644 --- a/util/module.c +++ b/util/module.c

[PATCH v2 09/10] util: Remove qemu_get_local_state_dir()

2022-11-10 Thread Akihiko Odaki
There are no users of the function anymore. Signed-off-by: Akihiko Odaki --- include/qemu/osdep.h | 8 util/oslib-posix.c | 6 -- util/oslib-win32.c | 10 -- 3 files changed, 24 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 86445aad25..f2

Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 11/8/22 15:37, Kevin Wolf wrote: > > The subtree drain was introduced in commit b1e1af394d9 as a way to avoid > > graph changes between finding the base node and changing the block graph > > as necessary on completion of the

Re: [PATCH] KVM: Add system call KVM_VERIFY_MSI to verify MSI vector

2022-11-10 Thread Marc Zyngier
On Wed, 09 Nov 2022 06:21:18 +, "chenxiang (M)" wrote: > > Hi Marc, > > > 在 2022/11/8 20:47, Marc Zyngier 写道: > > On Tue, 08 Nov 2022 08:08:57 +, > > chenxiang wrote: > >> From: Xiang Chen > >> > >> Currently the numbers of MSI vectors come from register PCI_MSI_FLAGS > >> which shou

Re: [PATCH 1/3] net: Move the code to collect available NIC models to a separate function

2022-11-10 Thread Thomas Huth
On 07/11/2022 18.34, Alex Bennée wrote: Thomas Huth writes: The code that collects the available NIC models is not really specific to PCI anymore and will be required in the next patch, too, so let's move this into a new separate function in net.c instead. Signed-off-by: Thomas Huth --- i

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Mark Cave-Ayland
On 09/11/2022 17:00, Peter Maydell wrote: This patchset converts the ps2 keyboard and mouse devices to 3-phase reset. The rationale here is that it would be nice to get rid of the device_class_set_parent_reset() function, which is used by legacy-reset subclasses which want to chain to their pare

RE: [PATCH v2 1/4] hw/virtio: incorporate backend features in features

2022-11-10 Thread Yajun Wu
Hi Alex, Sorry for the late response, I missed your mail. You can test together with dpdk and have reproduce. Steps: 1. DPDK git clone https://github.com/DPDK/dpdk.git git checkout v22.07 meson build -Dexamples=vhost_blk ninja -C build cd /tmp/ sudo dpdk/build/examples/dpdk-vhost_blk # it's a da

Re: [PATCH v2 2/9] block-copy: add missing coroutine_fn annotations

2022-11-10 Thread Paolo Bonzini
On Wed, Nov 9, 2022 at 1:24 PM Emanuele Giuseppe Esposito wrote: > > > What I do know is that it's extremely confusing to understand if a > > > function that is *not* marked as coroutine_fn is actually being called > > > also from coroutines or not. Agreed. This is a huge point in favor of pushin

Re: [PATCH 01/13] qed: Don't yield in bdrv_qed_co_drain_begin()

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 22:49 hat Stefan Hajnoczi geschrieben: > On Tue, Nov 08, 2022 at 01:37:26PM +0100, Kevin Wolf wrote: > > @@ -310,9 +309,20 @@ static void coroutine_fn > > qed_need_check_timer_entry(void *opaque) > > (void) ret; > > } > > > > +static void coroutine_fn qed_need_check_timer_

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Peter Maydell
On Thu, 10 Nov 2022 at 10:36, Mark Cave-Ayland wrote: > I haven't used the new ResettableClass myself previously, however it seems to > match > the excellent documentation at > https://qemu.readthedocs.io/en/latest/devel/reset.html > so feel free to add my Acked-by tag. > > One part that did sta

Re: [PATCH] net: stream: add a new option to automatically reconnect

2022-11-10 Thread Markus Armbruster
Laurent Vivier writes: > In stream mode, if the server shuts down there is currently > no way to reconnect the client to a new server without removing > the NIC device and the netdev backend (or to reboot). > > This patch introduces a reconnect option that specifies a delay > to try to reconnect

Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain

2022-11-10 Thread Vladimir Sementsov-Ogievskiy
On 11/10/22 13:16, Kevin Wolf wrote: Am 09.11.2022 um 17:52 hat Vladimir Sementsov-Ogievskiy geschrieben: On 11/8/22 15:37, Kevin Wolf wrote: The subtree drain was introduced in commit b1e1af394d9 as a way to avoid graph changes between finding the base node and changing the block graph as nece

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Thomas Huth
On 08/11/2022 10.43, Claudio Fontana wrote: On 11/8/22 09:59, Thomas Huth wrote: On 08/11/2022 09.52, Claudio Fontana wrote: On 11/8/22 09:42, Thomas Huth wrote: On 07/11/2022 13.27, Claudio Fontana wrote: should -net and -netdev be adapted too? "-netdev help" already works just fine ... an

Re: [PATCH] net: stream: add a new option to automatically reconnect

2022-11-10 Thread Daniel P . Berrangé
On Thu, Nov 10, 2022 at 12:22:21PM +0100, Markus Armbruster wrote: > Laurent Vivier writes: > > > In stream mode, if the server shuts down there is currently > > no way to reconnect the client to a new server without removing > > the NIC device and the netdev backend (or to reboot). > > > > This

[PATCH] tests/qtest/libqos/e1000e: Remove "other" interrupts

2022-11-10 Thread Akihiko Odaki
The "other" kind of interrupts are not used in the tests. Signed-off-by: Akihiko Odaki --- tests/qtest/libqos/e1000e.h | 1 - tests/qtest/libqos/e1000e.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/qtest/libqos/e1000e.h b/tests/qtest/libqos/e1000e.h index a22f5fdbad..3bf285af42 10

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Thomas Huth
On 08/11/2022 10.49, Claudio Fontana wrote: On 11/4/22 13:57, Thomas Huth wrote: Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions (it showed the available netdev backends), but this feature got broken during some refactoring in version 6.0. Let's restore the old behavi

[PATCH] tests/qtest/e1000e-test: De-duplicate constants

2022-11-10 Thread Akihiko Odaki
De-duplicate constants found in e1000e_send_verify() to avoid mismatch and improve readability. Signed-off-by: Akihiko Odaki --- tests/qtest/e1000e-test.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.

[PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses

2022-11-10 Thread Akihiko Odaki
Add a newline after E1000_TCTL write and make it clear that E1000_TCTL write is what enabling transmit. Signed-off-by: Akihiko Odaki --- tests/qtest/libqos/e1000e.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c index 80b3e3db90..0e5

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Mark Cave-Ayland
On 10/11/2022 11:22, Peter Maydell wrote: On Thu, 10 Nov 2022 at 10:36, Mark Cave-Ayland wrote: I haven't used the new ResettableClass myself previously, however it seems to match the excellent documentation at https://qemu.readthedocs.io/en/latest/devel/reset.html so feel free to add my Ack

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Claudio Fontana
On 11/10/22 12:35, Thomas Huth wrote: > On 08/11/2022 10.43, Claudio Fontana wrote: >> On 11/8/22 09:59, Thomas Huth wrote: >>> On 08/11/2022 09.52, Claudio Fontana wrote: On 11/8/22 09:42, Thomas Huth wrote: > On 07/11/2022 13.27, Claudio Fontana wrote: >> should -net and -netdev be a

Re: [PATCH for-7.2 1/5] block/mirror: Do not wait for active writes

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: > Waiting for all active writes to settle before daring to create a > background copying operation means that we will never do background > operations while the guest does anything (in write-blocking mode), and > therefore cannot converge. Yes, w

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Claudio Fontana
On 11/10/22 12:42, Thomas Huth wrote: > On 08/11/2022 10.49, Claudio Fontana wrote: >> On 11/4/22 13:57, Thomas Huth wrote: >>> Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions >>> (it showed the available netdev backends), but this feature got broken >>> during >>> some

Re: [PATCH for-7.2 2/5] block/mirror: Drop mirror_wait_for_any_operation()

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: > mirror_wait_for_free_in_flight_slot() is the only remaining user of > mirror_wait_for_any_operation(), so inline the latter into the former. > > Signed-off-by: Hanna Reitz Reviewed-by: Kevin Wolf

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Claudio Fontana
On 11/10/22 13:05, Claudio Fontana wrote: > On 11/10/22 12:42, Thomas Huth wrote: >> On 08/11/2022 10.49, Claudio Fontana wrote: >>> On 11/4/22 13:57, Thomas Huth wrote: Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions (it showed the available netdev backends),

Re: [PATCH for-7.2 3/5] block/mirror: Fix NULL s->job in active writes

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: > There is a small gap in mirror_start_job() before putting the mirror > filter node into the block graph (bdrv_append() call) and the actual job > being created. Before the job is created, MirrorBDSOpaque.job is NULL. > > It is possible that re

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Thomas Huth
On 10/11/2022 13.05, Claudio Fontana wrote: On 11/10/22 12:42, Thomas Huth wrote: On 08/11/2022 10.49, Claudio Fontana wrote: On 11/4/22 13:57, Thomas Huth wrote: Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions (it showed the available netdev backends), but this fea

Re: [PATCH v6 00/10] ASID support in vhost-vdpa net

2022-11-10 Thread Michael S. Tsirkin
On Tue, Nov 08, 2022 at 06:07:45PM +0100, Eugenio Pérez wrote: > Control VQ is the way net devices use to send changes to the device state, > like > the number of active queues or its mac address. > > QEMU needs to intercept this queue so it can track these changes and is able > to > migrate the

Re: [PATCH] virtio-blk: simplify virtio_blk_dma_restart_cb()

2022-11-10 Thread Michael S. Tsirkin
On Wed, Nov 02, 2022 at 02:23:37PM -0400, Stefan Hajnoczi wrote: > virtio_blk_dma_restart_cb() is tricky because the BH must deal with > virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() being called. > > There are two issues with the code: > > 1. virtio_blk_realize() should use qdev_add

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-10 Thread manish.mishra
Hi Everyone, Just a gentle reminder for review. :) Thanks Manish Mishra On 07/11/22 10:21 pm, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel fol

Re: [PATCH for-7.2 4/5] iotests/151: Test that active mirror progresses

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: > Before this series, a mirror job in write-blocking mode would pause > issuing background requests while active requests are in flight. Thus, > if the source is constantly in use by active requests, no actual > progress can be made. > > This se

Re: [PATCH for-7.2 5/5] iotests/151: Test active requests on mirror start

2022-11-10 Thread Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: > Have write requests happen to the source node right when we start a > mirror job. The mirror filter node may encounter MirrorBDSOpaque.job > being NULL, but this should not cause a segfault. > > Signed-off-by: Hanna Reitz Reviewed-by: Kevin

Re: [PATCH for-7.2 3/5] block/mirror: Fix NULL s->job in active writes

2022-11-10 Thread Hanna Reitz
On 10.11.22 13:10, Kevin Wolf wrote: Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben: There is a small gap in mirror_start_job() before putting the mirror filter node into the block graph (bdrv_append() call) and the actual job being created. Before the job is created, MirrorBDSOpaque.job is

Re: [PATCH 1/3] net: Move the code to collect available NIC models to a separate function

2022-11-10 Thread Thomas Huth
On 10/11/2022 11.35, Thomas Huth wrote: On 07/11/2022 18.34, Alex Bennée wrote: Thomas Huth writes: The code that collects the available NIC models is not really specific to PCI anymore and will be required in the next patch, too, so let's move this into a new separate function in net.c inst

[PATCH v2 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Thomas Huth
Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions (it showed the available netdev backends), but this feature got broken during some refactoring in version 6.0. Let's restore the old behavior, and while we're at it, let's also print the available NIC models here now since

[PATCH v2 3/3] net: Replace "Supported NIC models" with "Available NIC models"

2022-11-10 Thread Thomas Huth
Just because a NIC model is compiled into the QEMU binary does not necessary mean that it can be used with each and every machine. So let's rather talk about "available" models instead of "supported" models, just to avoid confusion. Reviewed-by: Claudio Fontana Signed-off-by: Thomas Huth --- ne

[PATCH v2 0/3] Fix the "-nic help" option

2022-11-10 Thread Thomas Huth
Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions, but since QEMU 6.0 it just complains that "help" is not a valid value here. This patch series fixes this problem and also extends the help output here to list the available NIC models, too. v2: - Add function comment in

[PATCH v2 1/3] net: Move the code to collect available NIC models to a separate function

2022-11-10 Thread Thomas Huth
The code that collects the available NIC models is not really specific to PCI anymore and will be required in the next patch, too, so let's move this into a new separate function in net.c instead. Signed-off-by: Thomas Huth --- include/net/net.h | 14 ++ hw/pci/pci.c | 29 +-

Re: [PATCH v6 01/10] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 6:22 AM Jason Wang wrote: > > On Wed, Nov 9, 2022 at 1:08 AM Eugenio Pérez wrote: > > > > This function used to trust in v->shadow_vqs != NULL to know if it must > > start svq or not. > > > > This is not going to be valid anymore, as qemu is going to allocate svq > > uncon

Re: [PATCH v6 00/10] ASID support in vhost-vdpa net

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 1:25 PM Michael S. Tsirkin wrote: > > On Tue, Nov 08, 2022 at 06:07:45PM +0100, Eugenio Pérez wrote: > > Control VQ is the way net devices use to send changes to the device state, > > like > > the number of active queues or its mac address. > > > > QEMU needs to intercept

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-10 Thread Claudio Fontana
On 11/10/22 13:23, Thomas Huth wrote: > On 10/11/2022 13.05, Claudio Fontana wrote: >> On 11/10/22 12:42, Thomas Huth wrote: >>> On 08/11/2022 10.49, Claudio Fontana wrote: On 11/4/22 13:57, Thomas Huth wrote: > Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier > vers

Re: [PATCH v6 05/10] vdpa: move SVQ vring features check to net/

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 6:40 AM Jason Wang wrote: > > > 在 2022/11/9 01:07, Eugenio Pérez 写道: > > The next patches will start control SVQ if possible. However, we don't > > know if that will be possible at qemu boot anymore. > > > If I was not wrong, there's no device specific feature that is check

Re: [PATCH v4 0/6] Only generate cluster node in PPTT when specified

2022-11-10 Thread Peter Maydell
On Wed, 2 Nov 2022 at 08:17, Michael S. Tsirkin wrote: > > On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote: > > From: Yicong Yang > > > > This series mainly change the policy for building a cluster topology node > > in PPTT. Previously we'll always build a cluster node in PPTT without

[PATCH] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15

2022-11-10 Thread Thomas Huth
Clang 15 from Fedora 37 complains: ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable] Int n; /* output bunch counter */ ^ 1 error generated. Remove the unused variable to silence the compiler warning.

Re: [PATCH v6 07/10] vdpa: Add asid parameter to vhost_vdpa_dma_map/unmap

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 6:51 AM Jason Wang wrote: > > On Wed, Nov 9, 2022 at 1:08 AM Eugenio Pérez wrote: > > > > So the caller can choose which ASID is destined. > > > > No need to update the batch functions as they will always be called from > > memory listener updates at the moment. Memory lis

Re: [PATCH v3 01/17] migration: Remove res_compatible parameter

2022-11-10 Thread Avihai Horon
On 08/11/2022 19:52, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela It was only used for RAM, and in that case, it means that this amount of data was sent for memory. Not clear for me,

Re: [PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-10 Thread Avihai Horon
On 08/11/2022 20:36, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we need to make sure that some block is dirty, but no

Re: [PATCH] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15

2022-11-10 Thread Cédric Le Goater
On 11/10/22 14:11, Thomas Huth wrote: Clang 15 from Fedora 37 complains: ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable] Int n; /* output bunch counter */ ^ 1 error generated. Remove the unus

Re: [PATCH v3 04/17] migration: Simplify migration_iteration_run()

2022-11-10 Thread Avihai Horon
On 08/11/2022 20:56, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Avihai Horon ---   migration/migration.c | 25 +

Re: [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description

2022-11-10 Thread Kevin Wolf
Am 08.11.2022 um 15:23 hat Alberto Faria geschrieben: > The nvme-io_uring BlockDriver's path option must point at the character > device of an NVMe namespace, not at an image file. > > Fixes: fd66dbd424f5 ("blkio: add libblkio block driver") > Suggested-by: Stefano Garzarella > Signed-off-by: Alb

Re: [PATCH v6 09/10] vdpa: Add listener_shadow_vq to vhost_vdpa

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 7:01 AM Jason Wang wrote: > > On Wed, Nov 9, 2022 at 1:08 AM Eugenio Pérez wrote: > > > > The memory listener that thells the device how to convert GPA to qemu's > > va is registered against CVQ vhost_vdpa. This series try to map the > > memory listener translations to ASI

Re: [PATCH v1 1/1] migration: Fix yank on postcopy multifd crashing guest after migration

2022-11-10 Thread Juan Quintela
Leonardo Bras wrote: D> When multifd and postcopy-ram capabilities are enabled, if a > migrate-start-postcopy is attempted, the migration will finish sending the > memory pages and then crash with the following error: > > qemu-system-x86_64: ../util/yank.c:107: yank_unregister_instance: Assertion

Re: [PATCH v3 05/17] vfio/migration: Fix wrong enum usage

2022-11-10 Thread Avihai Horon
On 08/11/2022 21:05, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: vfio_migration_init() initializes VFIOMigration->device_state using enum of VFIO migration protocol v2. Current implemented protocol is v1 s

Re: intermittent failures in iotest 108

2022-11-10 Thread Kevin Wolf
Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben: > Hello Kevin and all, > > I seem to be getting intermittent failures with mainline iotest 108. Is this > already known? > > ../configure --enable-tcg --enable-kvm --enable-modules --enable-debug > make -j > make -j check At least I haven'

Re: intermittent failures in iotest 108

2022-11-10 Thread Claudio Fontana
On 11/10/22 14:50, Kevin Wolf wrote: > Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben: >> Hello Kevin and all, >> >> I seem to be getting intermittent failures with mainline iotest 108. Is this >> already known? >> >> ../configure --enable-tcg --enable-kvm --enable-modules --enable-debug >

Re: [PATCH for-7.2] block/blkio: Set BlockDriver::has_variable_length to false

2022-11-10 Thread Kevin Wolf
Am 08.11.2022 um 15:44 hat Alberto Faria geschrieben: > Setting it to true can cause the device size to be queried from libblkio > in otherwise fast paths, degrading performance. Set it to false and > require users to refresh the device size explicitly instead. > > Fixes: 4c8f4fda0504 ("block/blki

Re: [PATCH v2 0/3] block: Start/end drain on correct AioContext

2022-11-10 Thread Kevin Wolf
Am 07.11.2022 um 16:13 hat Hanna Reitz geschrieben: > Hi, > > v1 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00389.html > > bdrv_replace_child_noperm() drains the child via > bdrv_parent_drained_{begin,end}_single(). When it removes a child, the > bdrv_parent_drai

[PATCH for-7.2] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg

2022-11-10 Thread Peter Maydell
On my machine, a debug build of QEMU takes about 260 seconds to complete this test, so with the current timeout value of 180 seconds it always times out. Double the timeout value to 360 so the test definitely has enough time to complete. Signed-off-by: Peter Maydell --- tests/avocado/boot_linux

[PATCH for-8.0 1/2] hw/misc/mos6522: Convert TYPE_MOS6522 to 3-phase reset

2022-11-10 Thread Peter Maydell
Convert the TYPE_MOS6522 parent class to use 3-phase reset. This is a prerequisite for converting its subclasses. Signed-off-by: Peter Maydell --- hw/misc/mos6522.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c index fe38c44426b

[PATCH for-8.0 2/2] hw/misc: Convert TYPE_MOS6522 subclasses to 3-phase reset

2022-11-10 Thread Peter Maydell
Convert the various subclasses of TYPE_MOS6522 to 3-phase reset. This removes some uses of device_class_set_parent_reset(), which we would eventually like to be able to get rid of. Signed-off-by: Peter Maydell --- include/hw/misc/mos6522.h | 2 +- hw/misc/mac_via.c | 26

[PATCH for-8.0 0/2] hw/misc: Convert MOS6522 devices to 3-phase reset

2022-11-10 Thread Peter Maydell
This patchset converts the TYPE_MOS6522 class and its subclasses to use 3-phase reset. This is part of the work I'm doing to clean up some of the reset-related code by getting rid of the device_class_set_parent_reset() function, which is used by legacy-reset subclasses which want to chain to their

Re: [PATCH for-7.2] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg

2022-11-10 Thread Alex Bennée
Peter Maydell writes: > On my machine, a debug build of QEMU takes about 260 seconds to > complete this test, so with the current timeout value of 180 seconds > it always times out. Double the timeout value to 360 so the test > definitely has enough time to complete. Queued to for-7.2/misc-fi

Re: intermittent failures in iotest 108

2022-11-10 Thread Claudio Fontana
On 11/10/22 14:51, Claudio Fontana wrote: > On 11/10/22 14:50, Kevin Wolf wrote: >> Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben: >>> Hello Kevin and all, >>> >>> I seem to be getting intermittent failures with mainline iotest 108. Is >>> this already known? >>> >>> ../configure --enable

Re: [PATCH] virtio-blk: simplify virtio_blk_dma_restart_cb()

2022-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2022 at 07:27:59AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 02, 2022 at 02:23:37PM -0400, Stefan Hajnoczi wrote: > > virtio_blk_dma_restart_cb() is tricky because the BH must deal with > > virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() being called. > > > > There

Re: [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download

2022-11-10 Thread Jan Richter
On 11/10/22 00:26, Philippe Mathieu-Daudé wrote: On 9/11/22 16:39, Daniel Henrique Barboza wrote: On 10/27/22 06:01, Daniel P. Berrangé wrote: On Thu, Oct 27, 2022 at 09:46:29AM +0200, Thomas Huth wrote: On 24/10/2022 11.02, Daniel P. Berrangé wrote: On Sat, Oct 22, 2022 at 02:03:50PM -0300

Re: QEMU | Heap-overflow in virtio_net_queue_enable (#1309)

2022-11-10 Thread Alexander Bulekov
On 221110 1453, Xuan Zhuo wrote: > On Thu, 10 Nov 2022 00:11:00 -0500, "Michael S. Tsirkin" > wrote: > > Xuan Zhuo pls take a look ASAP. > > > > On Thu, Nov 10, 2022 at 03:04:41AM +, Alexander Bulekov (@a1xndr) wrote: > > Alexander Bulekov created an issue: #1309 > > > > Hello, > > > > I bise

Re: [PATCH v6 10/10] vdpa: Always start CVQ in SVQ mode

2022-11-10 Thread Eugenio Perez Martin
On Thu, Nov 10, 2022 at 7:25 AM Jason Wang wrote: > > > 在 2022/11/9 01:07, Eugenio Pérez 写道: > > Isolate control virtqueue in its own group, allowing to intercept control > > commands but letting dataplane run totally passthrough to the guest. > > > I think we need to tweak the title to "vdpa: Alw

[PATCH] tests/stream-under-throttle: New test

2022-11-10 Thread Hanna Reitz
Test streaming a base image into the top image underneath two throttle nodes. This was reported to make qemu 7.1 hang (https://gitlab.com/qemu-project/qemu/-/issues/1215), so this serves as a regression test. Signed-off-by: Hanna Reitz --- This is a regression test for https://lists.nongnu.org/a

  1   2   3   >