Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

[Philippe Mathieu-Daudé]

On 10/11/22 07:23, Klaus Jensen wrote:

From: Klaus Jensen <k.jen...@samsung.com>

Make nvme_check_constraints() return a bool and fix an invalid error
propagation where the actual error is thrown away in favor of an unused
local Error value.

Signed-off-by: Klaus Jensen <k.jen...@samsung.com>
---
  hw/nvme/ctrl.c | 48 +++++++++++++++++++++++-------------------------
  1 file changed, 23 insertions(+), 25 deletions(-)

@@ -7586,7 +7585,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
                &pci_dev->qdev, n->parent_obj.qdev.id);

if (nvme_init_subsys(n, errp)) {

Similarly nvme_init_subsys() could return a boolean.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

-        error_propagate(errp, local_err);
          return;
      }
      nvme_init_state(n);