On 09/11/2022 16.57, mreza...@redhat.com wrote:
From: Miroslav Rezanina <mreza...@redhat.com>

Variable n used in tulip_idblock_crc function is only incremented but never 
read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.

Removing the variable to prevent the warning.

Signed-off-by: Miroslav Rezanina <mreza...@redhat.com>
---
  hw/net/tulip.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index b9e42c322a..c2b3b1bdfa 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -870,11 +870,10 @@ static const MemoryRegionOps tulip_ops = {
static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
  {
-    int word, n;
+    int word;
      int bit;
      unsigned char bitval, crc;
      const int len = 9;
-    n = 0;
      crc = -1;
for (word = 0; word < len; word++) {
@@ -887,7 +886,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
                  srom[len - 1] = (srom[len - 1] & 0xff00) | (unsigned 
short)crc;
                  break;
              }
-            n++;
              bitval = ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1);
              crc = crc << 1;
              if (bitval == 1) {

Reviewed-by: Thomas Huth <th...@redhat.com>


Reply via email to