Re: [PULL 12/12] accel: abort if we fail to load the accelerator plugin

2022-11-07 Thread Claudio Fontana
Hi all, and thanks Paolo for taking care of this series, I think I noticed something that seems off: On 11/6/22 09:51, Paolo Bonzini wrote: > From: Claudio Fontana > > if QEMU is configured with modules enabled, it is possible that the > load of an accelerator module will fail. > Exit in this

Re: [PULL v3 50/81] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically

2022-11-07 Thread Ani Sinha
On Mon, Nov 7, 2022 at 3:18 AM Bernhard Beschow wrote: > > > > On Sat, Nov 5, 2022 at 6:27 PM Michael S. Tsirkin wrote: >> >> From: Igor Mammedov >> >> Signed-off-by: Igor Mammedov >> Message-Id: <20221017102146.2254096-3-imamm...@redhat.com> >> Reviewed-by: Michael S. Tsirkin >> Signed-off-by

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Andrew Jones
On Mon, Nov 07, 2022 at 11:16:00AM +0530, Sunil V L wrote: > On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > > Hello Sunil! > > > > What about virt_machine_done() function? > > kernel_entry variable still points to the second flash started from > > virt_memmap[VIRT_FLASH].size /

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
On Mon, Nov 07, 2022 at 09:48:03AM +0100, Andrew Jones wrote: > On Mon, Nov 07, 2022 at 11:16:00AM +0530, Sunil V L wrote: > > On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > > > Hello Sunil! > > > > > > What about virt_machine_done() function? > > > kernel_entry variable still p

Re: [PULL 07/55] hw/virtio: move vm_running check to virtio_device_started

2022-11-07 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Mon, Oct 10, 2022 at 01:29:10PM -0400, Michael S. Tsirkin wrote: >> From: Alex Bennée >> >> All the boilerplate virtio code does the same thing (or should at >> least) of checking to see if the VM is running before attempting to >> start VirtIO. Push the logi

Re: [PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-11-07 Thread Eugenio Perez Martin
On Mon, Nov 7, 2022 at 8:51 AM Jason Wang wrote: > > On Thu, Nov 3, 2022 at 4:12 PM Eugenio Perez Martin > wrote: > > > > On Thu, Nov 3, 2022 at 4:21 AM Jason Wang wrote: > > > > > > On Wed, Nov 2, 2022 at 7:19 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Tue, Nov 1, 2022 at 9:10 A

Re: [PATCH v8 8/8] s390x/s390-virtio-ccw: add zpcii-disable machine property

2022-11-07 Thread Cédric Le Goater
Hello, On 9/2/22 19:27, Matthew Rosato wrote: The zpcii-disable machine property can be used to force-disable the use of zPCI interpretation facilities for a VM. By default, this setting will be off for machine 7.2 and newer. KVM will tell if the zPCI interpretation feature is available for t

Re: [PATCH v11 01/11] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties

2022-11-07 Thread Pierre Morel
On 11/6/22 12:37, Thomas Huth wrote: On 04/11/2022 15.57, Pierre Morel wrote: On 11/4/22 15:29, Thomas Huth wrote: On 04/11/2022 11.53, Cédric Le Goater wrote: On 11/4/22 11:16, Pierre Morel wrote: On 11/4/22 07:32, Thomas Huth wrote: On 03/11/2022 18.01, Pierre Morel wrote: Signed-o

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread maobibo
在 2022/11/6 22:39, Sunil V L 写道: > The pflash implementation currently assumes fixed size of the > backend storage. Due to this, the backend storage file needs to be > exactly of size 32M. Otherwise, there will be an error like below. > > "device requires 33554432 bytes, block backend provides

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-11-07 Thread Hanna Reitz
On 30.10.22 18:37, Nir Soffer wrote: On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: On 01.09.22 16:32, Nir Soffer wrote: > The checksum command compute a checksum for disk image content using the > blkhash library[1]. The blkhash library is not packaged yet, but it is

Re: [PATCH v8 8/8] s390x/s390-virtio-ccw: add zpcii-disable machine property

2022-11-07 Thread Thomas Huth
On 07/11/2022 10.53, Cédric Le Goater wrote: Hello, On 9/2/22 19:27, Matthew Rosato wrote: The zpcii-disable machine property can be used to force-disable the use of zPCI interpretation facilities for a VM.  By default, this setting will be off for machine 7.2 and newer. KVM will tell if the

Re: [PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup

2022-11-07 Thread Philippe Mathieu-Daudé
On 6/11/22 22:28, Richard Henderson wrote: Stefan reported for accel/tcg, and I reproduced on Ubuntu 22.04. Changes for v2: * Incorporate suggested changes to nanomips.c (phil, balaton). Thanks for v2, it was an optional review change request from my side, but I appreciate the change, the r

[PATCH] hw/sd/sdhci: reset data count in sdhci_buff_access_is_sequential()

2022-11-07 Thread Mauro Matteo Cascella
Make sure to reset data_count if it's equal to (or exceeds) block_size. This prevents an off-by-one read / write when accessing s->fifo_buffer in sdhci_read_dataport / sdhci_write_dataport, both called right after sdhci_buff_access_is_sequential. Fixes: CVE-2022-3872 Reported-by: RivenDell Report

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-11-07 Thread Hanna Reitz
On 30.10.22 18:38, Nir Soffer wrote: On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote: On 01.09.22 16:32, Nir Soffer wrote: > Add coroutine based loop inspired by `qemu-img convert` design. > > Changes compared to `qemu-img convert`: > > - State for the entire image is

Re: [PULL v3 00/81] pci,pc,virtio: features, tests, fixes, cleanups

2022-11-07 Thread Stefan Hajnoczi
Hi Michael and Igor, Looks like the ACPI commits broken the virtio-vga module: >>> QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=60 >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh >>> QTEST_QEMU_BINARY=./qemu-system-or1k >>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-d

Re: [PATCH] hw/sd/sdhci: reset data count in sdhci_buff_access_is_sequential()

2022-11-07 Thread Mauro Matteo Cascella
On Mon, Nov 7, 2022 at 11:35 AM Mauro Matteo Cascella wrote: > > Make sure to reset data_count if it's equal to (or exceeds) block_size. > This prevents an off-by-one read / write when accessing s->fifo_buffer > in sdhci_read_dataport / sdhci_write_dataport, both called right after > sdhci_buff_ac

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
On Mon, Nov 07, 2022 at 05:57:45PM +0800, maobibo wrote: > > > 在 2022/11/6 22:39, Sunil V L 写道: > > The pflash implementation currently assumes fixed size of the > > backend storage. Due to this, the backend storage file needs to be > > exactly of size 32M. Otherwise, there will be an error like

Re: [PATCH 1/1] tcg: add perfmap and jitdump

2022-11-07 Thread Alex Bennée
Ilya Leoshkevich writes: > Add ability to dump /tmp/perf-.map and jit-.dump. > The first one allows the perf tool to map samples to each individual > translation block. The second one adds the ability to resolve symbol > names, line numbers and inspect JITed code. > > Example of use: > > pe

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-11-07 Thread Hanna Reitz
On 30.10.22 18:38, Nir Soffer wrote: On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: On 01.09.22 16:32, Nir Soffer wrote: > Add simple tests creating an image with all kinds of extents, different > formats, different backing chain, different protocol, and different > imag

Re: [PATCH 1/3] net: Move the code to collect available NIC models to a separate function

2022-11-07 Thread Claudio Fontana
On 11/4/22 13:57, Thomas Huth wrote: > The code that collects the available NIC models is not really specific > to PCI anymore and will be required in the next patch, too, so let's > move this into a new separate function in net.c instead. > > Signed-off-by: Thomas Huth > --- > include/net/net.h

[RFC PATCH] hw/virtio: introduce virtio_device_should_start

2022-11-07 Thread Alex Bennée
The previous fix to virtio_device_started revealed a problem in its use by both the core and the device code. The core code should be able to handle the device "starting" while the VM isn't running to handle the restoration of migration state. To solve this duel use introduce a new helper for use b

Re: [RFC PATCH] hw/virtio: introduce virtio_device_should_start

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 12:14:07PM +, Alex Bennée wrote: > The previous fix to virtio_device_started revealed a problem in its > use by both the core and the device code. The core code should be able > to handle the device "starting" while the VM isn't running to handle > the restoration of mig

Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help"

2022-11-07 Thread Claudio Fontana
should -net and -netdev be adapted too? For audio, we now have support for help options in both -audiodev and -audio.. Thanks, Claudio On 11/4/22 13:57, Thomas Huth wrote: > Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions > (it showed the available netdev backends),

Re: [PATCH 3/3] net: Replace "Supported NIC models" with "Available NIC models"

2022-11-07 Thread Claudio Fontana
On 11/4/22 13:57, Thomas Huth wrote: > Just because a NIC model is compiled into the QEMU binary does not > necessary mean that it can be used with each and every machine. > So let's rather talk about "available" models instead of "supported" > models, just to avoid confusion. > > Signed-off-by: T

Re: [PULL v3 00/81] pci,pc,virtio: features, tests, fixes, cleanups

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 05:43:44AM -0500, Stefan Hajnoczi wrote: > Hi Michael and Igor, > Looks like the ACPI commits broken the virtio-vga module: > > >>> QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=60 > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh > >>> QTEST_QEM

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-07 Thread Michael S. Tsirkin
On Sun, Nov 06, 2022 at 10:16:41PM +0100, Bernhard Beschow wrote: > > > On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: > > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Message-Id: <20221017102146.2254096-2-imamm...@redhat.com> > Reviewed-by: Michael S. Tsi

Re: [PATCH 0/2] util/log: Make the per-thread flag immutable

2022-11-07 Thread Greg Kurz
On Sat, 5 Nov 2022 09:37:26 +1100 Richard Henderson wrote: > On 11/4/22 23:00, Greg Kurz wrote: > > While working on the "util/log: Always send errors to logfile when > > daemonized" > > series [1], I've encountered some issues with the per-thread flag. They stem > > from the code not being desi

Re: [PATCH 2/3] hvf: implement guest debugging on Apple Silicon hosts

2022-11-07 Thread Mads Ynddal
> On 4 Nov 2022, at 19.41, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > Support is added for single-stepping, software breakpoints, hardware > breakpoints and watchpoints. The code has been structured like the KVM > counterpart (and many parts are basically identical). > >

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-07 Thread Ani Sinha
On Mon, Nov 7, 2022 at 6:03 PM Michael S. Tsirkin wrote: > > On Sun, Nov 06, 2022 at 10:16:41PM +0100, Bernhard Beschow wrote: > > > > > > On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: > > > > From: Igor Mammedov > > > > Signed-off-by: Igor Mammedov > > Message-Id: <20221

Re: [PULL v3 50/81] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 02:06:23PM +0530, Ani Sinha wrote: > On Mon, Nov 7, 2022 at 3:18 AM Bernhard Beschow wrote: > > > > > > > > On Sat, Nov 5, 2022 at 6:27 PM Michael S. Tsirkin wrote: > >> > >> From: Igor Mammedov > >> > >> Signed-off-by: Igor Mammedov > >> Message-Id: <20221017102146.2254

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Mads Ynddal
> On 4 Nov 2022, at 19.40, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl', this is just code motion. > > Signed-off-by: Francesco Cagnin > --- > target/arm/debug_help

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 06:16:25PM +0530, Ani Sinha wrote: > On Mon, Nov 7, 2022 at 6:03 PM Michael S. Tsirkin wrote: > > > > On Sun, Nov 06, 2022 at 10:16:41PM +0100, Bernhard Beschow wrote: > > > > > > > > > On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: > > > > > > From: Igor Mam

[PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
The pflash implementation currently assumes fixed size of the backend storage. Due to this, the backend storage file needs to be exactly of size 32M. Otherwise, there will be an error like below. "device requires 33554432 bytes, block backend provides 4194304 bytes" Fix this issue by using the ac

Re: [PATCH 3/3] hvf: handle writes of MDSCR_EL1 and DBG*_EL1

2022-11-07 Thread Mads Ynddal
> On 4 Nov 2022, at 19.41, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > This proved to be required when debugging the Linux kernel's initial > code, as the Hypervisor framework was triggering 'EC_SYSTEMREGISTERTRAP' > VM exits after enabling trap exceptions with > 'hv_vcpu_

Re: [PATCH v2] vl: defuse PID file path resolve error

2022-11-07 Thread Hanna Reitz
On 31.10.22 10:47, Fiona Ebner wrote: Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") introduced a critical error when the PID file path cannot be resolved. Before this commit, it was possible to invoke QEMU when the PID file was a file created with mkstemp that was already unlinked at th

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Peter Maydell
On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: > > The pflash implementation currently assumes fixed size of the > backend storage. Due to this, the backend storage file needs to be > exactly of size 32M. Otherwise, there will be an error like below. > > "device requires 33554432 bytes, block backe

Re: [PATCH v10 2/9] s390x/cpu topology: reporting the CPU topology to the guest

2022-11-07 Thread Janis Schoetterl-Glausch
On Fri, 2022-10-28 at 12:00 +0200, Pierre Morel wrote: > > On 10/27/22 22:42, Janis Schoetterl-Glausch wrote: > > On Wed, 2022-10-12 at 18:21 +0200, Pierre Morel wrote: > > > The guest can use the STSI instruction to get a buffer filled > > > with the CPU topology description. > > > > > > Let us

Re: [PATCH 2/3] hvf: implement guest debugging on Apple Silicon hosts

2022-11-07 Thread Mads Ynddal
> On 4 Nov 2022, at 19.41, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > Support is added for single-stepping, software breakpoints, hardware > breakpoints and watchpoints. The code has been structured like the KVM > counterpart (and many parts are basically identical). >

Re: [PULL v2 31/82] vhost: Change the sequence of device start

2022-11-07 Thread Michael S. Tsirkin
On Sun, Nov 06, 2022 at 07:00:33PM +0100, Christian A. Ehrhardt wrote: > > Hi, > > On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S. Tsirkin wrote: > > On Sat, Nov 05, 2022 at 05:35:57PM +0100, Bernhard Beschow wrote: > > > > > > > > > On Wed, Nov 2, 2022 at 5:24 PM Michael S. Tsirkin wrote

intermittent failures in iotest 108

2022-11-07 Thread Claudio Fontana
Hello Kevin and all, I seem to be getting intermittent failures with mainline iotest 108. Is this already known? ../configure --enable-tcg --enable-kvm --enable-modules --enable-debug make -j make -j check ▶ 614/634 qcow2 108

[PATCH] hw/acpi: fix breakage due to missing aml stub definitions when acpi is off

2022-11-07 Thread Ani Sinha
Some HW architectures do not support acpi and CONFIG_ACPI is off for them. For those architectures, dummy stub function definitions help to resolve symbols. This change adds couple of dummy stub definitions so that symbols for those can be resolved and failures such as the following can be fixed fo

Re: [PATCH v10 2/9] s390x/cpu topology: reporting the CPU topology to the guest

2022-11-07 Thread Pierre Morel
On 11/7/22 14:20, Janis Schoetterl-Glausch wrote: On Fri, 2022-10-28 at 12:00 +0200, Pierre Morel wrote: On 10/27/22 22:42, Janis Schoetterl-Glausch wrote: On Wed, 2022-10-12 at 18:21 +0200, Pierre Morel wrote: The guest can use the STSI instruction to get a buffer filled with the CPU topo

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 14:06, Peter Maydell wrote: On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: The pflash implementation currently assumes fixed size of the backend storage. Due to this, the backend storage file needs to be exactly of size 32M. Otherwise, there will be an error like below. "device requ

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell wrote: > On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: > > > > The pflash implementation currently assumes fixed size of the > > backend storage. Due to this, the backend storage file needs to be > > exactly of size 32M. Otherwise, there will

Re: [PULL v2 0/9] loongarch-to-apply queue

2022-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/7] target-arm queue

2022-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/1] VFIO fix for v7.2-rc0

2022-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Alex Bennée
francesco.cag...@gmail.com writes: > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl', this is just code motion. > > Signed-off-by: Francesco Cagnin > --- > target/arm/debug_helper.c | 241 ++

Re: [RFC PATCH] hw/virtio: introduce virtio_device_should_start

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 12:14:07PM +, Alex Bennée wrote: > The previous fix to virtio_device_started revealed a problem in its > use by both the core and the device code. The core code should be able > to handle the device "starting" while the VM isn't running to handle > the restoration of mig

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 15:15, Alex Bennée wrote: francesco.cag...@gmail.com writes: From: Francesco Cagnin These helpers will be also used for HVF. Aside from reformatting a couple of comments for 'checkpatch.pl', this is just code motion. Signed-off-by: Francesco Cagnin --- target/arm/debug_helper.

[PATCH] tcg/loongarch64: Optimize immediate loading

2022-11-07 Thread Rui Wang
diff: Imm Before After addi.w rd, zero, 0 ori rd, zero, 0 lu52i.d rd, zero, 0 f800lu12i.w rd, -1 addi.w rd, zero, -2048 ori rd, rd, 2048lu32i.d rd, 0

[RFC PATCH] tests/docker: allow user to override check target

2022-11-07 Thread Alex Bennée
This is useful when trying to bisect a particular failing test behind a docker run. For example: make docker-test-clang@fedora \ TARGET_LIST=arm-softmmu \ CHECK_TARGET="meson test qtest-arm/qos-test" \ J=9 V=1 Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 2 ++ te

Re: [RFC PATCH] hw/virtio: introduce virtio_device_should_start

2022-11-07 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Mon, Nov 07, 2022 at 12:14:07PM +, Alex Bennée wrote: >> The previous fix to virtio_device_started revealed a problem in its >> use by both the core and the device code. The core code should be able >> to handle the device "starting" while the VM isn't runn

[PATCH] checkpatch: better pattern for inline comments

2022-11-07 Thread Michael S. Tsirkin
checkpatch is unhappy about this line: WARNING: Block comments use a leading /* on a separate line #50: FILE: hw/acpi/nvdimm.c:1074: + aml_equal(aml_sizeof(pckg), aml_int(1)) /* 1 element? */)); but there's nothing wrong with it - the check is just too simplistic. I

[PATCH v2 1/3] block: Make bdrv_child_get_parent_aio_context I/O

2022-11-07 Thread Hanna Reitz
We want to use bdrv_child_get_parent_aio_context() from bdrv_parent_drained_{begin,end}_single(), both of which are "I/O or GS" functions. Prior to 3ed4f708fe1, all the implementations were I/O code anyway. 3ed4f708fe1 has put block jobs' AioContext field under the job mutex, so to make child_job_

[PATCH v2 2/3] block-backend: Update ctx immediately after root

2022-11-07 Thread Hanna Reitz
blk_get_aio_context() asserts that blk->ctx is always equal to the root BDS's context (if there is a root BDS). Therefore, blk_do_set_aio_context() must update blk->ctx immediately after the root BDS's context has changed. Without this patch, the next patch would break iotest 238, because bdrv_dr

[PATCH v2 0/3] block: Start/end drain on correct AioContext

2022-11-07 Thread Hanna Reitz
Hi, v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00389.html bdrv_replace_child_noperm() drains the child via bdrv_parent_drained_{begin,end}_single(). When it removes a child, the bdrv_parent_drained_end_single() at its end will be called on an empty child, making

[PATCH v2 3/3] block: Start/end drain on correct AioContext

2022-11-07 Thread Hanna Reitz
bdrv_parent_drained_{begin,end}_single() are supposed to operate on the parent, not on the child, so they should not attempt to get the context to poll from the child but the parent instead. BDRV_POLL_WHILE(c->bs) does get the context from the child, so we should replace it with AIO_WAIT_WHILE() o

[PATCH v2] hw/acpi: fix breakage due to missing aml stub definitions when acpi is off

2022-11-07 Thread Ani Sinha
Some HW architectures do not support acpi and CONFIG_ACPI is off for them. For those architectures, dummy stub function definitions help to resolve symbols. This change adds couple of dummy stub definitions so that symbols for those can be resolved and failures such as the following can be fixed fo

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Alex Bennée
Sunil V L writes: > On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell wrote: >> On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: >> > >> > The pflash implementation currently assumes fixed size of the >> > backend storage. Due to this, the backend storage file needs to be >> > exactly of si

Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled

2022-11-07 Thread Alex Bennée
LIU Zhiwei writes: > On 2022/11/7 9:37, Alistair Francis wrote: >> On Thu, Oct 13, 2022 at 4:32 PM LIU Zhiwei >> wrote: >>> When icount is not enabled, there is no API in QEMU that can get the >>> guest instruction number. >>> >>> Translate the guest code in a way that each TB only has one in

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/11/22 14:06, Peter Maydell wrote: >> On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: >>> >>> The pflash implementation currently assumes fixed size of the >>> backend storage. Intentional. commit 06f1521795207359a395996c253c306f4ab7586e Author: Markus Armbru

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Peter Maydell
On Mon, 7 Nov 2022 at 14:08, Sunil V L wrote: > > On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell wrote: > > On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: > > > > > > The pflash implementation currently assumes fixed size of the > > > backend storage. Due to this, the backend storage file

[PATCH for 7.2 0/2] s390x/s390-virtio-ccw:

2022-11-07 Thread Cédric Le Goater
From: Cédric Le Goater Hello, This series removes the redundant "zpcii-disable" machine property and and introduces a GlobalProperty compat array to maintain the same behaviour on older machines. Thanks, C. Cédric Le Goater (2): Revert "s390x/s390-virtio-ccw: add zpcii-disable machine prope

[PATCH for 7.2 2/2] s390x/s390-virtio-ccw: Switch off zPCI enhancements on older machines

2022-11-07 Thread Cédric Le Goater
From: Cédric Le Goater zPCI enhancement features (interpretation and forward assist) were recently introduced to improve performance on PCI passthrough devices. To maintain the same behaviour on older Z machines, deactivate the features with the associated properties. Signed-off-by: Cédric Le Go

[PATCH for 7.2 1/2] Revert "s390x/s390-virtio-ccw: add zpcii-disable machine property"

2022-11-07 Thread Cédric Le Goater
From: Cédric Le Goater This reverts commit 59d1ce44396e3ad2330dc3261ff3da7ad3a16184. The "zpcii-disable" machine property is redundant with the "interpret" zPCI device property. Remove it for clarification. Signed-off-by: Cédric Le Goater --- include/hw/s390x/s390-virtio-ccw.h | 1 - hw/s390

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Daniel P . Berrangé
On Mon, Nov 07, 2022 at 03:50:44PM +, Alex Bennée wrote: > > Sunil V L writes: > > > On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell wrote: > >> On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: > >> > > >> > The pflash implementation currently assumes fixed size of the > >> > backend s

[PATCH v8 1/4] block: drop bdrv_detach_child()

2022-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy The only caller is bdrv_root_unref_child(), let's just do the logic directly in it. It simplifies further convertion of bdrv_root_unref_child() to transaction action. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block.c | 46 +

[PATCH v8 4/4] block: refactor bdrv_list_refresh_perms to allow any list of nodes

2022-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy We are going to increase usage of collecting nodes in a list to then update, and calling bdrv_topological_dfs() each time is not convenient, and not correct as we are going to interleave graph modifying with filling the node list. So, let's switch to a function

[PATCH v8 2/4] block: drop bdrv_remove_filter_or_cow_child

2022-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Drop this simple wrapper used only in one place. We have too many graph modifying functions even without it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-

[PATCH v8 3/4] block: bdrv_refresh_perms(): allow external tran

2022-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Allow passing external Transaction pointer, stop creating extra Transaction objects. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) dif

[PATCH v8 0/4] block: small refactorings

2022-11-07 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is 4-more simple already reviewed patches from "[PATCH v5 00/45] Transactional block-graph modifying API" [1] Called v8 because first part of [1] was recently merged as "[PATCH v7 for-7.2 00/15] block: cleanup backing and file handling" Vladimir Sementsov-Ogievskiy (4): block: d

[PATCH qemu.git v2 1/9] hw/timer/imx_epit: improve comments

2022-11-07 Thread ~axelheider
From: Axel Heider Fix typos, add background information Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index ec0fa440d7..4af730593f 100644 --- a/hw/timer/imx_epi

[PATCH qemu.git v2 3/9] hw/timer/imx_epit: simplify interrupt logic

2022-11-07 Thread ~axelheider
From: Axel Heider Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 8ec770f674..2e9dae0bc8 100644 --- a/hw/timer/imx_epit.c +++ b/hw/timer/imx_epit.

[PATCH qemu.git v2 0/9] hw/timer/imx_epit: imprive and fix compare timer handling

2022-11-07 Thread ~axelheider
This patch set improves the i.MX EPIT emulation: - fix #1263 for writes to CR also - do not persist CR.SWR bit - remove explicit fields cnt and freq - software reset clears the interrupt - general code and documentation improvements Axel Heider (9): hw/timer/imx_epit: improve comments hw/timer

[PATCH qemu.git v2 6/9] hw/timer/imx_epit: remove explicit fields cnt and freq

2022-11-07 Thread ~axelheider
From: Axel Heider The CNT register is a read-only register. There is no need to store it's value, it can be calculated on demand. The calculated frequency is needed temporarily only. Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 76 +++-- include/

[PATCH qemu.git v2 9/9] hw/timer/imx_epit: fix compare timer handling

2022-11-07 Thread ~axelheider
From: Axel Heider - fix #1263 - rework compare time handling - The compare timer has to run even if CR.OCIEN is not set, as SR.OCIF must be updated. - The compare timer fires exactly once when the compare value is less than the current value, but the reload values is less than the

[PATCH qemu.git v2 4/9] hw/timer/imx_epit: software reset clears the interrupt

2022-11-07 Thread ~axelheider
From: Axel Heider Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 2e9dae0bc8..5315d9633e 100644 --- a/hw/timer/imx_epit.c +++ b/hw/timer/imx_epit.c @@ -94,6 +94,10 @@ static void imx_epit_

[PATCH qemu.git v2 2/9] hw/timer/imx_epit: cleanup CR defines

2022-11-07 Thread ~axelheider
From: Axel Heider remove unused defines, add needed defines Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 4 ++-- include/hw/timer/imx_epit.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 4af730593f..8ec7

[PATCH qemu.git v2 7/9] hw/timer/imx_epit: factor out register write handlers

2022-11-07 Thread ~axelheider
From: Axel Heider Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 211 1 file changed, 115 insertions(+), 96 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index b0ef727efb..30280a9ac1 100644 --- a/hw/timer/imx_epit.c +++ b

[PATCH qemu.git v2 8/9] hw/timer/imx_epit: change reset handling

2022-11-07 Thread ~axelheider
From: Axel Heider - inline software reset - make hardware reset invoke software reset - simplify code flow Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 66 - 1 file changed, 23 insertions(+), 43 deletions(-) diff --git a/hw/timer/imx_epit.c

[PATCH qemu.git v2 5/9] hw/timer/imx_epit: do not persist CR.SWR bit

2022-11-07 Thread ~axelheider
From: Axel Heider Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 5315d9633e..6af460946f 100644 --- a/hw/timer/imx_epit.c +++ b/hw/timer/imx_epit.c @@ -191,8 +191,9 @@ s

Re: [PATCH for 7.2 0/2] s390x/s390-virtio-ccw:

2022-11-07 Thread Matthew Rosato
On 11/7/22 11:13 AM, Cédric Le Goater wrote: > From: Cédric Le Goater > > Hello, > > This series removes the redundant "zpcii-disable" machine property and > and introduces a GlobalProperty compat array to maintain the same > behaviour on older machines. > > Thanks, > > C. Thanks Cedric. For

[PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-07 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connectio

Re: [RFC PATCH] tests/docker: allow user to override check target

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 15:52, Alex Bennée wrote: This is useful when trying to bisect a particular failing test behind a docker run. For example: make docker-test-clang@fedora \ TARGET_LIST=arm-softmmu \ CHECK_TARGET="meson test qtest-arm/qos-test" \ J=9 V=1 Signed-off-by: Alex Bennée --

Re: [PATCH v2] hw/acpi: fix breakage due to missing aml stub definitions when acpi is off

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 16:27, Ani Sinha wrote: Some HW architectures do not support acpi and CONFIG_ACPI is off for them. For those architectures, dummy stub function definitions help to resolve symbols. This change adds couple of dummy stub definitions so that symbols for those can be resolved and failures

Re: [PATCH v3 0/7] memory: prevent dma-reentracy issues

2022-11-07 Thread Alexander Bulekov
On 221028 1516, Alexander Bulekov wrote: > These patches aim to solve two types of DMA-reentrancy issues: > > 1.) mmio -> dma -> mmio case > To solve this, we track whether the device is engaged in io by > checking/setting a flag within APIs used for MMIO access. > > 2.) bh -> dma write -> mmio c

Re: [PATCH v2] hw/acpi: fix breakage due to missing aml stub definitions when acpi is off

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 06:08:49PM +0100, Philippe Mathieu-Daudé wrote: > On 7/11/22 16:27, Ani Sinha wrote: > > Some HW architectures do not support acpi and CONFIG_ACPI is off for them. > > For > > those architectures, dummy stub function definitions help to resolve > > symbols. > > This change

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Andrew Jones
On Mon, Nov 07, 2022 at 04:19:10PM +, Daniel P. Berrangé wrote: > On Mon, Nov 07, 2022 at 03:50:44PM +, Alex Bennée wrote: > > > > Sunil V L writes: > > > > > On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell wrote: > > >> On Mon, 7 Nov 2022 at 13:03, Sunil V L wrote: > > >> > > >

Re: [PULL v2 31/82] vhost: Change the sequence of device start

2022-11-07 Thread Christian A. Ehrhardt
On Mon, Nov 07, 2022 at 08:30:32AM -0500, Michael S. Tsirkin wrote: > On Sun, Nov 06, 2022 at 07:00:33PM +0100, Christian A. Ehrhardt wrote: > > > > Hi, > > > > On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S. Tsirkin wrote: > > > On Sat, Nov 05, 2022 at 05:35:57PM +0100, Bernhard Beschow wro

Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Daniel P . Berrangé
On Mon, Nov 07, 2022 at 06:32:01PM +0100, Andrew Jones wrote: > On Mon, Nov 07, 2022 at 04:19:10PM +, Daniel P. Berrangé wrote: > > On Mon, Nov 07, 2022 at 03:50:44PM +, Alex Bennée wrote: > > > > > > Sunil V L writes: > > > > > > > On Mon, Nov 07, 2022 at 01:06:38PM +, Peter Maydell

Re: [PATCH 1/3] net: Move the code to collect available NIC models to a separate function

2022-11-07 Thread Alex Bennée
Thomas Huth writes: > The code that collects the available NIC models is not really specific > to PCI anymore and will be required in the next patch, too, so let's > move this into a new separate function in net.c instead. > > Signed-off-by: Thomas Huth > --- > include/net/net.h | 1 + > hw/

Re: [RFC PATCH] tests/docker: allow user to override check target

2022-11-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/11/22 15:52, Alex Bennée wrote: >> This is useful when trying to bisect a particular failing test behind >> a docker run. For example: >>make docker-test-clang@fedora \ >> TARGET_LIST=arm-softmmu \ >> CHECK_TARGET="meson test qtest-arm/qos-tes

Re: [PULL v2 31/82] vhost: Change the sequence of device start

2022-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2022 at 06:31:00PM +0100, Christian A. Ehrhardt wrote: > On Mon, Nov 07, 2022 at 08:30:32AM -0500, Michael S. Tsirkin wrote: > > On Sun, Nov 06, 2022 at 07:00:33PM +0100, Christian A. Ehrhardt wrote: > > > > > > Hi, > > > > > > On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S.

Re: [PATCH v10 1/9] s390x/cpu topology: core_id sets s390x CPU topology

2022-11-07 Thread Janis Schoetterl-Glausch
On Fri, 2022-10-28 at 11:30 +0200, Pierre Morel wrote: > > On 10/27/22 22:20, Janis Schoetterl-Glausch wrote: > > On Wed, 2022-10-26 at 10:34 +0200, Pierre Morel wrote: > > > > > > On 10/25/22 21:58, Janis Schoetterl-Glausch wrote: > > > > On Wed, 2022-10-12 at 18:20 +0200, Pierre Morel wrote: >

[PATCH] docs/cxl: Fix some typos

2022-11-07 Thread Davidlohr Bueso
Found while reading the doc. Signed-off-by: Davidlohr Bueso --- docs/system/devices/cxl.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst index abf7c1f24305..891bbd65d9d8 100644 --- a/docs/system/devices

Re: [PATCH] hw/sd/sdhci: reset data count in sdhci_buff_access_is_sequential()

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 11:35, Mauro Matteo Cascella wrote: Make sure to reset data_count if it's equal to (or exceeds) block_size. This prevents an off-by-one read / write when accessing s->fifo_buffer in sdhci_read_dataport / sdhci_write_dataport, both called right after sdhci_buff_access_is_sequential. Fi

[PATCH v2] checkpatch: better pattern for inline comments

2022-11-07 Thread Michael S. Tsirkin
checkpatch is unhappy about this line: WARNING: Block comments use a leading /* on a separate line #50: FILE: hw/acpi/nvdimm.c:1074: + aml_equal(aml_sizeof(pckg), aml_int(1)) /* 1 element? */)); but there's nothing wrong with it - the check is just too simplistic. I

Re: [PULL 00/12] Misc bugfix patches (+ improved module errors) for QEMU 7.2

2022-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/7] Trivial branch for 7.2 patches

2022-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

  1   2   3   >