On Mon, Nov 07, 2022 at 09:48:03AM +0100, Andrew Jones wrote: > On Mon, Nov 07, 2022 at 11:16:00AM +0530, Sunil V L wrote: > > On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > > > Hello Sunil! > > > > > > What about virt_machine_done() function? > > > kernel_entry variable still points to the second flash started from > > > virt_memmap[VIRT_FLASH].size / 2. > > > > > > > The base address of the flash has not changed to keep things flexible. So, I > > didn't change this portion of the code to keep the changes minimal. > > I think we should change virt_machine_done() to be consistent with > create_fdt_flash() and also add a comment in virt_flash_map() explaining > the base addresses are statically determined from virt_memmap[VIRT_FLASH], > but the sizes are variable and determined in virt_flash_map1(). >
Sure Drew. Let me update and send V2. Thanks Sunil > Thanks, > drew
