The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/pci.json.
Said commit explains the transforma
In QAPI, absent optional members are distinct from any present value.
We thus represent an optional schema member FOO as two C members: a
FOO with the member's type, and a bool has_FOO. Likewise for function
arguments.
However, has_FOO is actually redundant for a pointer-valued FOO, which
can be
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/block*.json.
Said commit explains the transfo
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/replay.json.
Said commit explains the transfo
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/virtio.json.
Said commit explains the transfo
Hi
On Tue, Oct 18, 2022 at 8:47 AM Miaoqian Lin wrote:
> We should use g_strfreev to free the memory allocated by g_strsplit().
> Use g_free() will cause a memory leak.
>
> Signed-off-by: Miaoqian Lin
> ---
> qga/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/q
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for
tests/qapi-schema/qapi-schema-test.json.
Said comm
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/ui.json.
Said commit explains the transformat
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/run-state.json.
Said commit explains the tran
Am 17.10.22 um 11:54 schrieb Zhang, Chen:
>
>
>> -Original Message-
>> From: Qemu-devel
>> On Behalf Of Fiona Ebner
>> Sent: Thursday, October 13, 2022 4:41 PM
>> To: qemu-devel@nongnu.org
>> Cc: dgilb...@redhat.com; quint...@redhat.com; berra...@redhat.com
>> Subject: [PATCH v2] migrati
On 18/10/22 06:46, Miaoqian Lin wrote:
We should use g_strfreev to free the memory allocated by g_strsplit().
Use g_free() will cause a memory leak.
Signed-off-by: Miaoqian Lin
---
qga/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index 5a
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/dump.json.
Said commit explains the transform
On 29/9/22 14:04, luzhipeng wrote:
From: lu zhipeng
Signed-off-by: lu zhipeng
---
contrib/elf2dmp/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index b9fc6d230c..d77b8f98f7 100644
--- a/contrib/elf2dmp/main.c
+++ b/contrib/elf2dmp
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/qdev.json and
qapi/qom.json.
Said commit expl
Dmitry Fomichev 于2022年10月17日周一 08:57写道：
>
> On Sun, 2022-10-16 at 22:51 +0800, Sam Li wrote:
> > Add a new zoned_host_device BlockDriver. The zoned_host_device option
> > accepts only zoned host block devices. By adding zone management
> > operations in this new BlockDriver, users can use the new
Damien Le Moal 于2022年10月17日周一 12:57写道：
>
> On 10/16/22 23:51, Sam Li wrote:
> > Add a new zoned_host_device BlockDriver. The zoned_host_device option
> > accepts only zoned host block devices. By adding zone management
> > operations in this new BlockDriver, users can use the new block
> > layer A
Am 16. Oktober 2022 14:15:09 UTC schrieb BALATON Zoltan :
>On Sun, 16 Oct 2022, Bernhard Beschow wrote:
>> Allows e500 boards to have their root file system reside on flash using
>> only builtin devices located in the eLBC memory region.
>>
>> Note that the flash memory area is only created when a
On Tue, Oct 18, 2022 at 3:46 PM Bernhard Beschow wrote:
>
> Am 16. Oktober 2022 14:15:09 UTC schrieb BALATON Zoltan :
> >On Sun, 16 Oct 2022, Bernhard Beschow wrote:
> >> Allows e500 boards to have their root file system reside on flash using
> >> only builtin devices located in the eLBC memory re
On Mon, Oct 17, 2022 at 05:15:35PM -0400, Peter Xu wrote:
> On Mon, Oct 17, 2022 at 12:38:30PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Oct 17, 2022 at 01:06:00PM +0530, manish.mishra wrote:
> > > Hi Daniel,
> > >
> > > I was thinking for some solutions for this so wanted to discuss that
> >
Stefan Hajnoczi 于2022年10月17日周一 22:44写道：
>
> On Sun, Oct 16, 2022 at 10:51:06PM +0800, Sam Li wrote:
> > Add a new zoned_host_device BlockDriver. The zoned_host_device option
> > accepts only zoned host block devices. By adding zone management
> > operations in this new BlockDriver, users can use t
On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote:
> This is all upstream. Namespaces with 'shared=on' *should* all be
> automatically attached to any hotplugged controller devices.
>
> With what setup is this not working for you?
Ah okay, I missed the 'shared=on' bit. Let me try again
Hi Stefano,
On 18/10/2022 02:26, Stefano Stabellini wrote:
On Sun, 16 Oct 2022, Julien Grall wrote:
Hi,
There seem to be some missing patches on xen-devel (including the cover
letter). Is that expected?
On 15/10/2022 06:07, Vikram Garhwal wrote:
Add a new machine xenpv which creates a IOREQ
Dmitry Fomichev 于2022年10月17日周一 08:57写道：
>
> On Sun, 2022-10-16 at 22:51 +0800, Sam Li wrote:
> > We have added new block layer APIs of zoned block devices.
> > Test it with:
> > Create a null_blk device, run each zone operation on it and see
> > whether reporting right zone information.
>
> change
* Eric Blake (ebl...@redhat.com) wrote:
> Assigning strlen() to a uint32_t and then asserting that it isn't too
> large doesn't catch the case of an input string 4G in length.
> Thankfully, the incoming strings can never be that large: if the
> export name or query is reflecting a string the client
At the moment, TFR() macro has a vague name and is not used
where it possibly could be. In order to make it more transparent
and useful, it was decided to refactor it to make it closer to
the similar one in glibc: TEMP_FAILURE_RETRY(). Now, macro
evaluates into an expression and is named RETRY_ON_E
Rename macro name to more transparent one and refactor
it to expression.
Signed-off-by: Nikita Ivanov
---
chardev/char-fd.c | 2 +-
chardev/char-pipe.c| 8 +---
include/qemu/osdep.h | 8 +++-
net/tap-bsd.c | 6 +++---
net/tap-linux.c| 2 +-
net/tap-solaris.c
There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h
which handles the same while loop.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415
Signed-off-by: Nikita Ivanov
---
block/file-posix.c| 37 -
chardev/char-pty.c| 4 +---
hw/
Damien Le Moal 于2022年10月17日周一 13:22写道：
>
> On 10/16/22 23:56, Sam Li wrote:
> > A zone append command is a write operation that specifies the first
> > logical block of a zone as the write position. When writing to a zoned
> > block device using zone append, the byte offset of writes is pointing
>
Dmitry Fomichev 于2022年10月17日周一 09:01写道：
>
> On Sun, 2022-10-16 at 23:05 +0800, Sam Li wrote:
> > This patch extends virtio-blk emulation to handle zoned device commands
> > by calling the new block layer APIs to perform zoned device I/O on
> > behalf of the guest. It supports Report Zone, four zon
On Mon, Oct 10, 2022 at 04:33:58PM +0300, Nikolay Borisov wrote:
> Implement support for a "file:" uri so that a migration can be initiated
> directly to a file from QEMU.
>
> Signed-off-by: Nikolay Borisov
> ---
> migration/file.c | 23 +++
> migration/file.h | 9
On Mon, Oct 10, 2022 at 04:33:58PM +0300, Nikolay Borisov wrote:
> Implement support for a "file:" uri so that a migration can be initiated
> directly to a file from QEMU.
Can we add a reminder here
Unlike other migration protocol backends, the 'file' protocol cannot
honour non-blocking mode.
Jiri Slaby writes:
> On 17. 10. 22, 16:13, Peter Maydell wrote:
>> * for situations where the guest has misprogrammed the device,
>> log that with qemu_log_mask(LOG_GUEST_ERROR, ...)
>> and continue with whatever the real hardware would do, or
>> some reasonable choice if the h/w
On Tue, Oct 18, 2022 at 12:44 PM Nikita Ivanov
wrote:
> Rename macro name to more transparent one and refactor
> it to expression.
>
> Signed-off-by: Nikita Ivanov
>
Reviewed-by: Marc-André Lureau
> ---
> chardev/char-fd.c | 2 +-
> chardev/char-pipe.c| 8 +---
> include/qemu/
Richard Henderson writes:
> On 10/18/22 01:27, LIU Zhiwei wrote:
>> Maybe I can run RISU on qemu-aarch64(x86) and qemu-aarch64(risc-v)
>> to check the RISC-V backend.
>
> This is a good start for debugging a tcg backend. It's not
> comprehensive, because RISU executes one instruction at a time
On Mon, 17 Oct 2022 at 21:57, Philippe Mathieu-Daudé wrote:
>
> On 16/10/22 14:27, Bernhard Beschow wrote:
> > pflash_cfi01_register() always returns with a non-NULL pointer (otherwise
> > it would crash internally). Therefore, the bodies of the if-statements
> > are unreachable.
>
> This is true,
On Sun, 16 Oct 2022 at 13:28, Bernhard Beschow wrote:
>
> Allows e500 boards to have their root file system reside on flash using
> only builtin devices located in the eLBC memory region.
>
> Note that the flash memory area is only created when a -pflash argument is
> given, and that the size is d
On Tue, 18 Oct 2022 at 10:21, Alex Bennée wrote:
>
>
> Jiri Slaby writes:
>
> > On 17. 10. 22, 16:13, Peter Maydell wrote:
> >> * for situations where the guest has misprogrammed the device,
> >> log that with qemu_log_mask(LOG_GUEST_ERROR, ...)
> >> and continue with whatever the real
On Tue, Oct 18, 2022 at 4:44 PM Nikita Ivanov wrote:
>
> Rename macro name to more transparent one and refactor
> it to expression.
>
> Signed-off-by: Nikita Ivanov
> ---
> chardev/char-fd.c | 2 +-
> chardev/char-pipe.c| 8 +---
> include/qemu/osdep.h | 8 +++-
> net/tap-bsd.
On Tue, Oct 18, 2022 at 02:23:56AM +0800, amarjargal wrote:
> The TABs should be replaced with spaces, to make sure that we have a
> consistent coding style with an indentation of 4 spaces everywhere.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/370
> Signed-off-by: amarjargal
> --
On 18.10.22 г. 12:10 ч., Daniel P. Berrangé wrote:
On Mon, Oct 10, 2022 at 04:33:58PM +0300, Nikolay Borisov wrote:
Implement support for a "file:" uri so that a migration can be initiated
directly to a file from QEMU.
Can we add a reminder here
Unlike other migration protocol backends,
On 4/10/22 05:00, Alexey Kardashevskiy wrote:
Anyone, ping?
On 27/09/2022 12:35, Alexey Kardashevskiy wrote:
Hi!
I am trying qemu-system-x86_64 with OVMF with the q35 machine, the
complete command line is below.
It works fine (including SEV on AMD EPYC), but these 2 parameters make
me wond
On Mon, Oct 10, 2022 at 04:34:00PM +0300, Nikolay Borisov wrote:
> This is required so that migration stream configuration is written
> to the migration stream. This would allow analyze-migration to
> parse enabled capabilities for the migration and adjust its behavior
> accordingly. This is in pre
On Mon, Oct 10, 2022 at 04:33:59PM +0300, Nikolay Borisov wrote:
> This is a counterpart to the 'file:' uri support for source migration,
> now a file can also serve as the source of an incoming migration.
As with the prvious patch, can we add a reminder:
Unlike other migration protocol backend
On 13/10/22 17:47, Alex Bennée wrote:
While the test-build test happily run for mingw the test-mingw case
runs more of the packaging inline with what our CI does. It however
fails if we don't find both compilers and expects to be run on a
docker image with both.
Remove that distinction and make
On Mon, Oct 10, 2022 at 04:34:01PM +0300, Nikolay Borisov wrote:
> The upcoming 'fixed-ram' feature would require qemu to write data at
> specific offsets of the file. This is currently missing so this patch
> adds it. I've chosen to implement it as a type-specific function rather
> than plumb it t
On Mon, Oct 10, 2022 at 04:34:02PM +0300, Nikolay Borisov wrote:
> Add a bunch of auxiliarry methods and a feature flag to work with
> SEEKABLE channels. Currently the only channel considered seekable is
> QIOChannelFile. Also add a bunch of helper functions to QEMUFile that
> can make use of t
10.10.2022 11:53, Helge Deller wrote:
On 10/9/22 08:08, WANG Xuerui wrote:
User space has been preferring this syscall for a while, due to its
closer match with C semantics, and newer platforms such as LoongArch
apparently have libc implementations that don't fallback to faccessat
so normal acce
If you run this single avocado test:
while ./build/x86/tests/venv/bin/avocado run
build/x86/tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd
; do true; done
then on my machine it will fail within 4 or 5 iterations. Has anybody
looked into this? Looking at a log from a f
On 12/10/22 20:56, Warner Losh wrote:
From: Muhammad Moinur Rahman
Some versions of FreeBSD now require sys/param.h for machine/pmap.h on
x86. Include them here to meet that requirement. It does no harm on
older versions, so there's no need to #ifdef it.
Signed-off-by: Muhammad Moinur Rahman
* Markus Armbruster (arm...@redhat.com) wrote:
> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> They are also a nuisance to work with. Recent commit "qapi: Start to
> elide redundant has_FOO in generated C" provided the means to elide
> them step by step. This is the step
On 11/10/22 17:46, Patrick Venture wrote:
This allows the devices to be more readily found and specified.
Without setting the id field, they can only be found by device type
name, which doesn't let you specify the second of the same device type
behind a bus.
Tested: Verified that by default the
Yajun Wu writes:
> vhost backend sends host notification for every VQ. If backend creates
> VQs in parallel, the VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG may
> arrive to QEMU in different order than incremental queue index order.
>
> For example VQ 1's message arrive earlier than VQ 0's:
> Afte
On 18.10.22 г. 13:14 ч., Daniel P. Berrangé wrote:
On Mon, Oct 10, 2022 at 04:34:02PM +0300, Nikolay Borisov wrote:
Add a bunch of auxiliarry methods and a feature flag to work with
SEEKABLE channels. Currently the only channel considered seekable is
QIOChannelFile. Also add a bunch of
On Tue, Oct 18, 2022 at 01:46:45PM +0300, Nikolay Borisov wrote:
>
>
> On 18.10.22 г. 13:14 ч., Daniel P. Berrangé wrote:
> > On Mon, Oct 10, 2022 at 04:34:02PM +0300, Nikolay Borisov wrote:
> > > Add a bunch of auxiliarry methods and a feature flag to work with
> > > SEEKABLE channels. Curre
On Tue, 18 Oct 2022, Bin Meng wrote:
On Tue, Oct 18, 2022 at 3:46 PM Bernhard Beschow wrote:
Am 16. Oktober 2022 14:15:09 UTC schrieb BALATON Zoltan :
On Sun, 16 Oct 2022, Bernhard Beschow wrote:
Allows e500 boards to have their root file system reside on flash using
only builtin devices loc
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> They are also a nuisance to work with. Recent commit "qapi: Start to
>> elide redundant has_FOO in generated C" provided the means to elide
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> >> They are also a nuisance to work with. Recent commit "qapi: Start to
> >> elide re
On Tue, 11 Oct 2022, BALATON Zoltan wrote:
On Mon, 3 Oct 2022, BALATON Zoltan wrote:
This series includes some clean ups to mac_newworld and mac_oldworld
to make them a bit simpler and more readable, It also removes the
shared mac.h file that turns out was more of a random collection of
unrelate
On Tuesday, October 4, 2022 10:56:44 PM CEST Christian Schoenebeck wrote:
> This series converts relevant 9p (test) client functions to use named
> function arguments. For instance
>
> do_walk_expect_error(v9p, "non-existent", ENOENT);
>
> becomes
>
> twalk({
> .client = v9p, .pa
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 10/18/22 08:01, Philippe Mathieu-Daudé wrote:
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
scripts/qapi/schema.py | 6 --
1 file changed, 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
Peter Maydell writes:
> On Tue, 18 Oct 2022 at 10:21, Alex Bennée wrote:
>>
>>
>> Jiri Slaby writes:
>>
>> > On 17. 10. 22, 16:13, Peter Maydell wrote:
>> >> * for situations where the guest has misprogrammed the device,
>> >> log that with qemu_log_mask(LOG_GUEST_ERROR, ...)
>> >>
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/
On Fri, Oct 14, 2022 at 01:29:51PM +0100, Joao Martins wrote:
> On 14/10/2022 12:28, Juan Quintela wrote:
> > Joao Martins wrote:
> >> On 13/10/2022 17:08, Juan Quintela wrote:
> >>> Oops. My understanding was that once the guest is stopped you can say
> >>> how big is it.
> >
> > Hi
> >
> >>
Log a guest error instead of a hardware error when
the guest tries to DMA to / from an invalid address.
Signed-off-by: Chris Friedt
---
hw/misc/edu.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 52afbd792a..a18f803815 100644
In the case that size1 was zero, because of the explicit
'end1 > addr' check, the range check would fail and the error
message would read as shown below. The correct comparison
is 'end1 >= addr'.
EDU: DMA range 0x4-0x3 out of bounds (0x4-0x40fff)!
At the opposite end, in the case that
This serves to make the local variables a bit less ambiguous.
The latter two arguments are named to match DMA_START, and
DMA_SIZE.
Signed-off-by: Chris Friedt
---
hw/misc/edu.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
ind
Since b68ba1ca5767 ("memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP
IOMMUTLBNotificationType"), vhost attempts to register DEVIOTLB_UNMAP
notifier. This latter is supported by the intel-iommu which supports
device-iotlb if the corresponding option is set. Then 958ec334bca3
("vhost: Unbreak SMMU and virt
On Tue, 18 Oct 2022 at 14:12, Stefan Berger wrote:
> On 10/18/22 08:01, Philippe Mathieu-Daudé wrote:
> > On 18/10/22 08:28, Markus Armbruster wrote:
> >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> >> They are also a nuisance to work with. Recent commit "qapi: Start to
Philippe Mathieu-Daudé writes:
> On 18/10/22 08:28, Markus Armbruster wrote:
>> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> They are also a nuisance to work with. Recent commit "qapi: Start to
>> elide redundant has_FOO in generated C" provided the means to elide
>> t
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>> > * Markus Armbruster (arm...@redhat.com) wrote:
>> >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> >> They are also a nuisance to work with. R
Philippe Mathieu-Daudé writes:
> On Tue, 18 Oct 2022 at 14:12, Stefan Berger wrote:
>> On 10/18/22 08:01, Philippe Mathieu-Daudé wrote:
>> > On 18/10/22 08:28, Markus Armbruster wrote:
>> >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> >> They are also a nuisance to wo
Philippe Mathieu-Daudé writes:
> On 18/10/22 08:28, Markus Armbruster wrote:
>> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> They are also a nuisance to work with. Recent commit "qapi: Start to
>> elide redundant has_FOO in generated C" provided the means to elide
>> t
> -Original Message-
> From: Qemu-devel
> [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nong
> nu.org] On Behalf Of Juan Quintela
> Sent: 14 October 2022 11:11
> To: kvm-devel ; qemu-devel@nongnu.org
> Subject: KVM Call for 2022-10-18
>
>
>
> Hi
>
> Please, send any
Queued, thanks.
Paolo
From: Venu Busireddy
Section 5.6.6.3 of VirtIO specification states, "Events will also
be reported via sense codes..." However, no sense data is sent when
VIRTIO_SCSI_EVT_RESET_RESCAN or VIRTIO_SCSI_EVT_RESET_REMOVED events
are reported (when disk hotplug/hotunplug events occur). SCSI layer
on So
This avoids the unfortunate effect of building pc-bios blobs
even for targets the user isn't interested in.
Due to the bi-arch nature of x86 and PPC firmware, check for the
desired target by hand, and don't just look for the compilation target
in $target_list.
Signed-off-by: Paolo Bonzini
---
c
From: Peter Maydell
In the SCSI subsystem we currently use the legacy functions
qdev_reset_all() and qbus_reset_all(). These perform a recursive
reset, starting from either a qbus or a qdev. However they do not
permit any of the devices in the tree to use three-phase reset,
because device reset
From: Peter Maydell
Currently the vwm_pvscsi controller resets individual SCSI devices
with the device_legacy_reset() function. The only difference between
this and device_cold_reset() is that device_legacy_reset() resets the
device but not any child qbuses it might have.
In this case, no SCSI
From: Richard Henderson
Restore pc_save while undoing any state change that may have
happened while decoding the instruction. Leave a TODO about
removing all of that when the table-based decoder is complete.
Cc: Paolo Bonzini
Suggested-by: Peter Maydell
Signed-off-by: Richard Henderson
Messa
From: Michal Privoznik
When determining the endiandness of the target architecture we're
building for a small program is compiled, which in an obfuscated
way declares two strings. Then, we look which string is in
correct order (using strings binary) and deduct the endiandness.
But using the strin
From: Richard Henderson
Use MMU_NESTED_IDX for each memory access, rather than
just a single translation to physical. Adjust svm_save_seg
and svm_load_seg to pass in mmu_idx.
This removes the last use of get_hphys so remove it.
Signed-off-by: Richard Henderson
Message-Id: <20221002172956.2657
From: Richard Henderson
Use probe_access_full in order to resolve to a host address,
which then lets us use a host cmpxchg to update the pte.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/279
Signed-off-by: Richard Henderson
Message-Id: <20221002172956.265735-9-richard.hender...@linar
From: Richard Henderson
We don't need one variable set per translation level,
which requires copying into pte/pte_addr for huge pages.
Standardize on pte/pte_addr for all levels.
Signed-off-by: Richard Henderson
Message-Id: <20221002172956.265735-8-richard.hender...@linaro.org>
Signed-off-by: P
From: Richard Henderson
Rather than recurse directly on mmu_translate, go through the
same softmmu lookup that we did for the page table walk.
This centralizes all knowledge of MMU_NESTED_IDX, with respect
to setup of TranslationParams, to get_physical_address.
Signed-off-by: Richard Henderson
ldq takes a pointer to the first byte to load the 64-bit word in;
ldo takes a pointer to the first byte of the ZMMReg. Make them
consistent, which will be useful in the new SSE decoder's
load/writeback routines.
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/tr
The new decoder is based on three principles:
- use mostly table-driven decoding, using tables derived as much as possible
from the Intel manual. Centralizing the decode the operands makes it
more homogeneous, for example all immediates are signed. All modrm
handling is in one function, an
Add generic code generation that takes care of preparing operands
around calls to decode.e.gen in a table-driven manner, so that ALU
operations need not take care of that.
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/decode-new.c.inc | 33 ++-
target/i386
The more complicated ones here are d6-d7, e6-e7, f7. The others
are trivial.
For LDDQU, using gen_load_sse directly might corrupt the register if
the second part of the load fails. Therefore, add a custom X86_TYPE_WM
value; like X86_TYPE_W it does call gen_load(), but it also rejects a
value of
These are both MMX and SSE/AVX instructions, except for vmovdqu. In both
cases the inputs and output is in s->ptr{0,1,2}, so the only difference
between MMX, SSE, and AVX is which helper to call.
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/decode-new.c.inc |
With all SSE (and AVX!) instructions now implemented in disas_insn_new,
it's possible to remove gen_sse, as well as the helpers for instructions
that now use gvec.
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
target/i386/ops_sse.h| 124 ---
target/i386/ops_sse_he
The new implementation of SSE will cover AVX from the get go, so include
the 24 extra comparison operators that are only available with the VEX
prefix.
Based on a patch by Paul Brook .
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
target/i386/ops_sse.h| 38 +++
1 - 100 of 214 matches
Mail list logo
