Am 17.10.22 um 11:54 schrieb Zhang, Chen:
>
>
>> -----Original Message-----
>> From: Qemu-devel <qemu-devel-bounces+chen.zhang=intel....@nongnu.org>
>> On Behalf Of Fiona Ebner
>> Sent: Thursday, October 13, 2022 4:41 PM
>> To: qemu-devel@nongnu.org
>> Cc: dgilb...@redhat.com; quint...@redhat.com; berra...@redhat.com
>> Subject: [PATCH v2] migration/channel-block: fix return value for
>> qio_channel_block_{readv, writev}
>>
>> in the error case. The documentation in include/io/channel.h states that -1
>> or
>> QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply passing
>> along the return value from the bdrv-functions has the potential to confuse
>> the call sides. Non-blocking mode is not implemented currently, so -1 it is.
>>
>> Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
>
> LGTM.
> Reviewed-by: Zhang Chen <chen.zh...@intel.com>
>
> But I found the same problem elsewhere, for example:
> "qio_channel_rdma_writev/readv", "qio_channel_buffer_writev/readv"...etc...
>
> Can you send other patches to fix it?
>
Thank you for the review! Unfortunately, I'll be pretty busy in the
coming weeks, because we have some releases coming up. But if nobody
else sends patches until those are done, I'll take a look then.
Best Regards,
Fiona
> Thanks
> Chen
>
>
