On 18/10/22 08:28, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with.  Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step.  This is the step for qapi/char.json.

Said commit explains the transformation in more detail.  The invariant
violations mentioned there do not occur here.

Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
---
  chardev/char-file.c    |  4 ++--
  chardev/char-socket.c  | 10 ++++------
  chardev/char-udp.c     |  1 -
  chardev/char.c         |  6 +-----
  tests/unit/test-char.c |  1 -
  scripts/qapi/schema.py |  1 -
  6 files changed, 7 insertions(+), 16 deletions(-)

Eventually s/char/chardev/ in subject.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Reply via email to