Re: A few QEMU questiosn

2022-10-06 Thread a b
Thanks a lot Peter for the clarification. It is very helpful. My naive understanding is that each MMU has only 1 TLB, why do we need an array of CPUTLBDescFast structures? How are these different CPUTLBDescFast data structures correlate with a hardware TLB? 220 typedef struct CPUTLB { 221 C

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > > > On 27/09/2022 23.21, Michael S. Tsirkin wrote: > > > > > On

[PATCH v3 0/5] io/command: implement portable spawn

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, This enables support of command spawning in the io/ subsystem on Windows. v3: - actually make it work :) (it seems I didn't test correctly earlier attempts) - add a patch for readv_writev() and partial IOs - add a patch to avoid some potential race in echo test -

[PATCH v3 1/5] osdep: make readv_writev() work with partial read/write

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau With a pipe or other reasons, read/write may return less than the requested bytes. This happens with the test-io-channel-command test on Windows. glib spawn code uses a binary pipe of 4096 bytes, and the first read returns that much (although more are requested), for some

[PATCH v3 3/5] io/command: use glib GSpawn, instead of open-coding fork/exec

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau Simplify qio_channel_command_new_spawn() with GSpawn API. This will allow to build for WIN32 in the following patches. As pointed out by Daniel Berrangé: there is a change in semantics here too. The current code only touches stdin/stdout/stderr. Any other FDs which do NOT

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Thu, 6 Oct 2022, Ani Sinha wrote: > > > On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > > > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 2022 at 10:31:39AM +0200, Thomas Huth wrote: > > > > > On 27/0

[PATCH v3 5/5] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau This has been tested under msys2 & windows 11. I haven't tried to make it work with other environments yet, but that should be enough to validate the channel-command implementation anyway. Signed-off-by: Marc-André Lureau --- tests/unit/test-io-channel-command.c | 32 ++

[PATCH v3 4/5] io/command: implement support for win32

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau The initial implementation was changing the pipe state created by GLib to PIPE_NOWAIT, but it turns out it doesn't work (read/write returns an error). Since reading may return less than the requested amount, it seems to be non-blocking already. However, the IO operation ma

Re: [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection

2022-10-06 Thread David Gibson
On Wed, Oct 05, 2022 at 06:20:41PM +0200, Laurent Vivier wrote: > From: Stefano Brivio > > Other errors are treated as failure by net_socket_connect_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception. > > Signed-off-by: Stefano Brivio > Signed-off-by:

Re: [PATCH v10 08/17] net: stream: Don't ignore EINVAL on netdev socket connection

2022-10-06 Thread David Gibson
On Wed, Oct 05, 2022 at 06:20:42PM +0200, Laurent Vivier wrote: > From: Stefano Brivio > > Other errors are treated as failure by net_stream_client_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception. > > Signed-off-by: Stefano Brivio > [lvivier: appli

[PATCH v3 2/5] tests/channel-helper: set blocking in main thread

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau The /io/channel/command/echo tests run the reader side and the writer side with the same underlying command channel. Setting the blocking mode of the fd/handles while the other end is already reading/writing may create issues (deadlock in win32 when earlier attempt of this

Re: [PATCH v10 05/17] net: introduce qemu_set_info_str() function

2022-10-06 Thread David Gibson
On Wed, Oct 05, 2022 at 06:20:39PM +0200, Laurent Vivier wrote: > Embed the setting of info_str in a function. > > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > include/net/net.h | 1 + > net/l2tpv3.c | 3 +-- > net/net.c | 17 - > net/slirp.c

Re: [PATCH 10/14] migration: Make PageSearchStatus part of RAMState

2022-10-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We used to allocate PSS structure on the stack for precopy when sending > pages. Make it static, so as to describe per-channel ram migration status. > > Here we declared RAM_CHANNEL_MAX instances, preparing for postcopy to use > it, even though this patch h

Re: [PATCH v3 2/5] tests/channel-helper: set blocking in main thread

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:12:19PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The /io/channel/command/echo tests run the reader side and the writer > side with the same underlying command channel. Setting the blocking mode > of the fd/handles while the other end is al

Re: [PATCH] coroutine: Drop coroutine_fn annotation from qemu_coroutine_self()

2022-10-06 Thread Kevin Wolf
Am 05.10.2022 um 19:52 hat Alberto Faria geschrieben: > qemu_coroutine_self() can be called from outside coroutine context, > returning the leader coroutine, and several such invocations currently > exist (mostly in qcow2 tracing calls). > > Signed-off-by: Alberto Faria Thanks, applied to the bl

Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-06 Thread Kevin Wolf
Am 05.10.2022 um 23:11 hat Paolo Bonzini geschrieben: > Il mer 5 ott 2022, 06:32 Kevin Wolf ha scritto: > > > Hm... blkdebug_debug_event() is called from bdrv_debug_event(), which is > > not coroutine_fn. And I think that it's not coroutine_fn is correct: > > For example, with 'qemu-img snapshot

Re: [PATCH v3 5/5] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2022 at 12:42 PM Daniel P. Berrangé wrote: > > On Thu, Oct 06, 2022 at 12:12:22PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This has been tested under msys2 & windows 11. I haven't tried to make > > it work with other environments yet, but th

[PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau This is an alternative configure-time solution to "[PATCH] net: print a more actionable error when slirp is not found". See also "If your networking is failing after updating to the latest git version of QEMU..." ML thread. Signed-off-by: Marc-André Lureau --- meson.bu

Re: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-10-06 Thread Fuad Tabba
Hi, <...> > diff --git a/mm/memfd_inaccessible.c b/mm/memfd_inaccessible.c > new file mode 100644 > index ..2d33cbdd9282 > --- /dev/null > +++ b/mm/memfd_inaccessible.c <...> > +struct file *memfd_mkinaccessible(struct file *memfd) > +{ > + struct inaccessible_data *data; > +

Re: [PATCH v3 1/5] osdep: make readv_writev() work with partial read/write

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:12:18PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > With a pipe or other reasons, read/write may return less than the > requested bytes. This happens with the test-io-channel-command test on > Windows. glib spawn code uses a binary pipe of 40

Re: [PATCH 10/14] migration: Make PageSearchStatus part of RAMState

2022-10-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Oct 05, 2022 at 07:51:34PM +0100, Dr. David Alan Gilbert wrote: > > > /* struct contains XBZRLE cache and a static page > > > used by the compression */ > > > static struct { > > > @@ -319,6 +359,11 @@ typedef struct { > > > struct RAMState { >

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Thomas Huth
On 06/10/2022 10.33, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This is an alternative configure-time solution to "[PATCH] net: print a more actionable error when slirp is not found". See also "If your networking is failing after updating to the latest git version of QEMU..." M

Re: [PATCH v3 4/5] io/command: implement support for win32

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:12:21PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The initial implementation was changing the pipe state created by GLib > to PIPE_NOWAIT, but it turns out it doesn't work (read/write returns an > error). Since reading may return less than

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

2022-10-06 Thread Fuad Tabba
Hi, I'm not sure if this patch or the last one might be the best place for it, but I think it would be useful to have a KVM_CAP associated with this. I am working on getting kvmtool to work with this, and I haven't found a clean way of getting it to discover whether mem_private is supported. Than

Re: [PATCH v3 5/5] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:12:22PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This has been tested under msys2 & windows 11. I haven't tried to make > it work with other environments yet, but that should be enough to > validate the channel-command implementation anywa

Re: [PATCH RFC] hw/cxl: type 3 devices can now present volatile or persistent memory

2022-10-06 Thread Jonathan Cameron via
On Wed, 5 Oct 2022 20:01:03 -0400 Gourry wrote: > Type 3 devices were hard-coded to always present as persistent memory devices. > This patch adds the "is_pmem" attribute which can be used to instantiate > a device as either a pmem or vmem. Hi Gourry, Great to see this. Missing Signed-off by

Re: [PATCH RFC] hw/cxl: type 3 devices can now present volatile or persistent memory

2022-10-06 Thread Jonathan Cameron via
On Thu, 6 Oct 2022 09:45:57 +0100 Jonathan Cameron wrote: > On Wed, 5 Oct 2022 20:01:03 -0400 > Gourry wrote: > > > Type 3 devices were hard-coded to always present as persistent memory > > devices. > > This patch adds the "is_pmem" attribute which can be used to instantiate > > a device as e

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:33:22PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is an alternative configure-time solution to "[PATCH] net: > print a more actionable error when slirp is not found". > > See also "If your networking is failing after updating to the l

[PATCH] linux-user: Fix more MIPS n32 syscall ABI issues

2022-10-06 Thread WANG Xuerui
In commit 80f0fe3a85 ("linux-user: Fix syscall parameter handling for MIPS n32") the ABI problem regarding offset64 on MIPS n32 was fixed, but still some cases remain where the n32 is incorrectly treated as any other 32-bit ABI that passes 64-bit arguments in pairs of GPRs. Fix by excluding TARGET_

[PATCH RESEND] linux-user: Fix struct statfs ABI on loongarch64

2022-10-06 Thread WANG Xuerui
Previously the 32-bit version was incorrectly chosen, leading to funny but incorrect output from e.g. df(1). Simply select the version corresponding to the 64-bit asm-generic definition. For reference, this program should produce the same output no matter natively compiled or not, for loongarch64

Re: [PATCH v8 8/8] KVM: Enable and expose KVM_MEM_PRIVATE

2022-10-06 Thread Fuad Tabba
Hi, On Thu, Sep 15, 2022 at 3:37 PM Chao Peng wrote: > > Expose KVM_MEM_PRIVATE and memslot fields private_fd/offset to > userspace. KVM will register/unregister private memslot to fd-based > memory backing store and response to invalidation event from > inaccessible_notifier to zap the existing

Re: [PATCH v3 5/5] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:46:17PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Oct 6, 2022 at 12:42 PM Daniel P. Berrangé > wrote: > > > > On Thu, Oct 06, 2022 at 12:12:22PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > This has been tested under msys2

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Christian Schoenebeck
On Donnerstag, 6. Oktober 2022 11:39:02 CEST Daniel P. Berrangé wrote: > On Thu, Oct 06, 2022 at 12:33:22PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This is an alternative configure-time solution to "[PATCH] net: > > print a more actionable error when slirp is

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Richard W.M. Jones
On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote: > qemu-nbd doesn't use io_uring to handle the backend IO, Would this be fixed by your (not yet upstream) libblkio driver for qemu? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my prog

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Wed, Oct 05, 2022 at 11:11:32AM -0400, Stefan Hajnoczi wrote: > On Tue, Oct 04, 2022 at 01:57:50AM +0200, Denis V. Lunev wrote: > > On 10/3/22 21:53, Stefan Hajnoczi wrote: > > > On Fri, Sep 30, 2022 at 05:24:11PM +0800, Ming Lei wrote: > > > > ublk-qcow2 is available now. > > > Cool, thanks for

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Christian Schoenebeck
On Donnerstag, 6. Oktober 2022 10:33:22 CEST marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is an alternative configure-time solution to "[PATCH] net: > print a more actionable error when slirp is not found". > > See also "If your networking is failing after updating to t

[PATCH] linux-user: Fix struct statfs ABI on loongarch64

2022-10-06 Thread WANG Xuerui
Previously the 32-bit version was incorrectly chosen, leading to funny but incorrect output from e.g. df(1). Simply select the version corresponding to the 64-bit asm-generic definition. For reference, this program should produce the same output no matter natively compiled or not, for loongarch64

Re: A few QEMU questiosn

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 08:34, a b wrote: > > Thanks a lot Peter for the clarification. It is very helpful. > > My naive understanding is that each MMU has only 1 TLB, why do we need an > array of CPUTLBDescFast structures? How are these different CPUTLBDescFast > data structures correlate with a

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Ani Sinha
On Thu, 6 Oct 2022, Ani Sinha wrote: > > > On Thu, 6 Oct 2022, Ani Sinha wrote: > > > > > > > On Wed, 28 Sep 2022, Michael S. Tsirkin wrote: > > > > > On Wed, Sep 28, 2022 at 11:39:36AM +0200, Thomas Huth wrote: > > > > On 28/09/2022 11.35, Michael S. Tsirkin wrote: > > > > > On Wed, Sep 28, 202

[PULL v3 00/52] testing, gdbstub, plugin and gitdm updates

2022-10-06 Thread Alex Bennée
The following changes since commit 1dcdc92c72af5311666df64f5f04d6600af262ed: Merge tag 'pull-hex-20221003' of https://github.com/quic/qemu into staging (2022-10-05 10:17:32 -0400) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-gdbstub-plugins-

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 12:12:07PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 6. Oktober 2022 11:39:02 CEST Daniel P. Berrangé wrote: > > On Thu, Oct 06, 2022 at 12:33:22PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > This is an alternative configu

Re: [PATCH v2] build-sys: error when slirp is not found and not disabled

2022-10-06 Thread Christian Schoenebeck via
On Donnerstag, 6. Oktober 2022 12:26:50 CEST Daniel P. Berrangé wrote: > On Thu, Oct 06, 2022 at 12:12:07PM +0200, Christian Schoenebeck wrote: > > On Donnerstag, 6. Oktober 2022 11:39:02 CEST Daniel P. Berrangé wrote: > > > On Thu, Oct 06, 2022 at 12:33:22PM +0400, marcandre.lur...@redhat.com wro

Re: [PATCH] hw/char/pl011: fix baud rate calculation

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 11:20, Baruch Siach wrote: > > The PL011 TRM says that "UARTIBRD = 0 is invalid and UARTFBRD is ignored > when this is the case". But the code looks at FBRD for the invalid case. > Fix this. > > Signed-off-by: Baruch Siach > --- > hw/char/pl011.c | 2 +- > 1 file changed, 1

Re: [PULL v2 00/53] testing, gdbstub, plugin and gitdm updates

2022-10-06 Thread Alex Bennée
Stefan Hajnoczi writes: > Hi Alex, > This pull request fails two CI jobs: > 1. https://gitlab.com/qemu-project/qemu/-/jobs/3132270506 > 2. https://gitlab.com/qemu-project/qemu/-/jobs/3132270625 > > Maybe there is an issue with the "tests/docker: update > fedora-win[32|64]-cross with lcitool" co

Re: [PATCH] linux-user: Fix struct statfs ABI on loongarch64

2022-10-06 Thread Philippe Mathieu-Daudé via
On 6/10/22 11:58, WANG Xuerui wrote: Previously the 32-bit version was incorrectly chosen, leading to funny but incorrect output from e.g. df(1). Simply select the version corresponding to the 64-bit asm-generic definition. For reference, this program should produce the same output no matter nat

Re: [PATCH RESEND] linux-user: Fix struct statfs ABI on loongarch64

2022-10-06 Thread Philippe Mathieu-Daudé via
On 6/10/22 12:07, WANG Xuerui wrote: Previously the 32-bit version was incorrectly chosen, leading to funny but incorrect output from e.g. df(1). Simply select the version corresponding to the 64-bit asm-generic definition. For reference, this program should produce the same output no matter nat

Re: [PATCH v3 5/5] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2022 at 2:14 PM Daniel P. Berrangé wrote: > On Thu, Oct 06, 2022 at 12:46:17PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Oct 6, 2022 at 12:42 PM Daniel P. Berrangé > wrote: > > > > > > On Thu, Oct 06, 2022 at 12:12:22PM +0400, marcandre.lur...@redhat.com > wrote:

Re: [PATCH] linux-user: Fix more MIPS n32 syscall ABI issues

2022-10-06 Thread Philippe Mathieu-Daudé via
On 6/10/22 10:55, WANG Xuerui wrote: In commit 80f0fe3a85 ("linux-user: Fix syscall parameter handling for MIPS n32") the ABI problem regarding offset64 on MIPS n32 was fixed, but still some cases remain where the n32 is incorrectly treated as any other 32-bit ABI that passes 64-bit arguments in

Re: [PATCH] docs/nuvoton: Update URL for images

2022-10-06 Thread Philippe Mathieu-Daudé via
On 4/10/22 07:00, Joel Stanley wrote: openpower.xyz was retired some time ago. The OpenBMC Jenkins is where images can be found these days. Signed-off-by: Joel Stanley --- docs/system/arm/nuvoton.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Tested-by: Philippe Mathieu-Daud

[PATCH v4 1/6] osdep: make readv_writev() work with partial read/write

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau With a pipe or other reasons, read/write may return less than the requested bytes. This happens with the test-io-channel-command test on Windows. glib spawn code uses a binary pipe of 4096 bytes, and the first read returns that much (although more are requested), for some

[PATCH v4 0/6] io/command: implement portable spawn

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, This enables support of command spawning in the io/ subsystem on Windows. v4: - add "util: make do_send_recv work with partial send/recv" patch - drop usage of SOCAT environment variable for tests - misc style fixes v3: - actually make it work :) (it seems I did

Re: [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-06 Thread Michael S. Tsirkin
On Wed, Oct 05, 2022 at 06:20:34PM +0200, Laurent Vivier wrote: > "-netdev socket" only supports inet sockets. > > It's not a complex task to add support for unix sockets, but > the socket netdev parameters are not defined to manage well unix > socket parameters. Looks good. Acked-by: Michael S.

[PATCH v4 2/6] util: make do_send_recv work with partial send/recv

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau According to msdn documentation and Linux man pages, send() should try to send as much as possible in blocking mode, while recv() may return earlier with a smaller available amount, we should try to continue send/recv from there. Signed-off-by: Marc-André Lureau --- uti

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Wed, Oct 05, 2022 at 08:21:45AM -0400, Stefan Hajnoczi wrote: > On Wed, 5 Oct 2022 at 00:19, Ming Lei wrote: > > > > On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote: > > > On Tue, 4 Oct 2022 at 05:44, Ming Lei wrote: > > > > > > > > On Mon, Oct 03, 2022 at 03:53:41PM -0400, Ste

[PATCH v4 3/6] tests/channel-helper: set blocking in main thread

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau The /io/channel/command/echo tests run the reader side and the writer side with the same underlying command channel. Setting the blocking mode of the fd/handles while the other end is already reading/writing may create issues (deadlock in win32 when earlier attempt of this

[PATCH v4 5/6] io/command: implement support for win32

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau The initial implementation was changing the pipe state created by GLib to PIPE_NOWAIT, but it turns out it doesn't work (read/write returns an error). Since reading may return less than the requested amount, it seems to be non-blocking already. However, the IO operation ma

[PATCH v4 4/6] io/command: use glib GSpawn, instead of open-coding fork/exec

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau Simplify qio_channel_command_new_spawn() with GSpawn API. This will allow to build for WIN32 in the following patches. As pointed out by Daniel Berrangé: there is a change in semantics here too. The current code only touches stdin/stdout/stderr. Any other FDs which do NOT

[PATCH v4 6/6] tests/unit: make test-io-channel-command work on win32

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau This has been tested under msys2 & windows 11. I haven't tried to make it work with other environments yet, but that should be enough to validate the channel-command implementation anyway. Here are the changes: - drop tests/ from fifo/pipe path, to avoid directory issues

Re: [PATCH v5 00/12] blkio: add libblkio BlockDriver

2022-10-06 Thread Stefano Garzarella
Hi Stefan, I tested this series with the vDPA block simulator in Linux v6.0. It worked well, but I had a segfault when blkio_map_mem_region() fails. In my case, it failed because I forgot to increase the `memlock` limit with `ulimit -l unlimited` since the simulator still requires locking all th

[PATCH] gitmodules: recurse by default

2022-10-06 Thread Michael S. Tsirkin
The most commmon complaint about submodules is that they don't follow when one switches branches in the main repo. Enable recursing into submodules by default to address that. Signed-off-by: Michael S. Tsirkin --- .gitmodules | 23 +++ 1 file changed, 23 insertions(+) diff -

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-10-06 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:36:51AM +0530, Ani Sinha wrote: > On Wed, Sep 28, 2022 at 9:28 AM Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 2022 at 08:38:54AM +0530, Ani Sinha wrote: > > > > I don't really care where we upload them but only having the > > > > latest version is just going to bre

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-06 Thread Akihiko Odaki
Thanks Peter and Elliot, Unfortunately Patchew seems to have failed to apply the patch to the current master. It would be nice if you rebase it to the current master. Actually I have a patch to add hardware support to ui/cocoa, but I have not submitted to the mailing list because it depends on a

Re: [PATCH v3 00/26] block: fix coroutine_fn annotations

2022-10-06 Thread Kevin Wolf
Am 22.09.2022 um 10:48 hat Paolo Bonzini geschrieben: > As discussed at KVM Forum 2022, I am reposting this series to > add more coroutine_fn annotations. Fixing the annotations > enables static analysis of which functions are coroutine-only > and which are mixed (coroutine/non-coroutine). > > A

Re: [PATCH v3] win32: set threads name

2022-10-06 Thread Marc-André Lureau
Hi Richard On Mon, Oct 3, 2022 at 11:39 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi > > On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson > wrote: > > > > On 9/30/22 07:03, marcandre.lur...@redhat.com wrote: > > > +static bool > > > +set_thread_description(HANDLE h, const cha

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 13:16, Akihiko Odaki wrote: > > Thanks Peter and Elliot, > > Unfortunately Patchew seems to have failed to apply the patch to the > current master. It would be nice if you rebase it to the current > master. I think this is probably mostly because the patch got sent in quoted

[PATCH] quorum: Remove unnecessary forward declaration

2022-10-06 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/quorum.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index 970f63d9f9..f9e6539ceb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -232,8 +232,6 @@ static bool quorum_has_too_much_io_failed(QuorumAIOCB *acb) retu

Re: [PATCH v2 1/2] include: update virtio_blk headers from Linux 5.19-rc2+

2022-10-06 Thread Stefan Hajnoczi
On Thu, Sep 29, 2022 at 05:48:20PM +0800, Sam Li wrote: > Use scripts/update-linux-headers.sh to update virtio-blk headers > from Dmitry's "virtio-blk:add support for zoned block devices" > linux patch. There is a link for more information: > https://github.com/dmitry-fomichev/virtblk-zbd > > Sign

Re: [PATCH] docs/nuvoton: Update URL for images

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 12:29, Philippe Mathieu-Daudé via wrote: > > On 4/10/22 07:00, Joel Stanley wrote: > > openpower.xyz was retired some time ago. The OpenBMC Jenkins is where > > images can be found these days. > > > > Signed-off-by: Joel Stanley > > --- > > docs/system/arm/nuvoton.rst | 4

Re: [PATCH 1/6] device-tree: add re-randomization helper function

2022-10-06 Thread Peter Maydell
On Fri, 30 Sept 2022 at 00:23, Jason A. Donenfeld wrote: > > When the system reboots, the rng-seed that the FDT has should be > re-randomized, so that the new boot gets a new seed. Several > architectures require this functionality, so export a function for > injecting a new seed into the given FD

Re: [PATCH 1/6] device-tree: add re-randomization helper function

2022-10-06 Thread Jason A. Donenfeld
Hi Peter, On Thu, Oct 6, 2022 at 7:16 AM Peter Maydell wrote: > > On Fri, 30 Sept 2022 at 00:23, Jason A. Donenfeld wrote: > > > > When the system reboots, the rng-seed that the FDT has should be > > re-randomized, so that the new boot gets a new seed. Several > > architectures require this func

Re: [PATCH] gitmodules: recurse by default

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 13:36, Michael S. Tsirkin wrote: > > The most commmon complaint about submodules is that > they don't follow when one switches branches in the > main repo. Enable recursing into submodules by default > to address that. Just to check, because the git docs are a bit unclear to

Re: [PATCH v2 1/2] include: update virtio_blk headers from Linux 5.19-rc2+

2022-10-06 Thread Peter Maydell
On Thu, 29 Sept 2022 at 11:14, Sam Li wrote: > > Use scripts/update-linux-headers.sh to update virtio-blk headers > from Dmitry's "virtio-blk:add support for zoned block devices" > linux patch. There is a link for more information: > https://github.com/dmitry-fomichev/virtblk-zbd > > Signed-off-by

Re: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-10-06 Thread Kirill A. Shutemov
On Thu, Oct 06, 2022 at 09:50:28AM +0100, Fuad Tabba wrote: > Hi, > > <...> > > > > diff --git a/mm/memfd_inaccessible.c b/mm/memfd_inaccessible.c > > new file mode 100644 > > index ..2d33cbdd9282 > > --- /dev/null > > +++ b/mm/memfd_inaccessible.c > > <...> > > > +struct file *mem

Re: [PATCH] quorum: Remove unnecessary forward declaration

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 14:13, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/quorum.c b/block/quorum.c > index 970f63d9f9..f9e6539ceb 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -232,8 +232,6 @@

Re: Minor tweak to wiki Linux build instructions.

2022-10-06 Thread Thomas Huth
On 10/07/2022 23.36, alar...@ddci.com wrote: On https://wiki.qemu.org/Hosts/Linux the list of recommended packages currently is a mix of RedHat and Debian names. I suggest the following instead: Recommended additional packages Package names are f

Re: [RFC PATCH 0/3] MIPS decodetree conversion attempt

2022-10-06 Thread Jiaxun Yang
> 2022年9月27日 11:33,Jiaxun Yang 写道: > > > >> 2022年9月26日 22:35,Philippe Mathieu-Daudé 写道: >> >> Hi Jiaxun, >> >> On Mon, Sep 26, 2022 at 4:44 PM Jiaxun Yang wrote: 2022年9月21日 13:41,Jiaxun Yang 写道: Hi, This is my attempt of converting MIPS translation code into d

[PATCH] qtest: start a VNC test

2022-10-06 Thread marcandre . lureau
From: Marc-André Lureau This is some of the simplest test we could perform, it simply connects to the VNC server via passed-in socket FDs and checks the connection can be established. Another series will make this test work on Windows as well. As always, more tests can be added later! :) Signe

Re: [PATCH] qtest: start a VNC test

2022-10-06 Thread Daniel P . Berrangé
On Thu, Oct 06, 2022 at 05:05:13PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is some of the simplest test we could perform, it simply connects > to the VNC server via passed-in socket FDs and checks the connection can > be established. > > Another series will m

Re: [PATCH v2] hw/net: npcm7xx_emc: set MAC in register space

2022-10-06 Thread Peter Maydell
On Mon, 3 Oct 2022 at 18:38, Patrick Venture wrote: > > The MAC address set from Qemu wasn't being saved into the register space. > > Reviewed-by: Hao Wu > Signed-off-by: Patrick Venture > --- > v2: only set the registers from qemu on reset > once registers set, only read and write to them

Re: [PATCH] linux-user: Fix more MIPS n32 syscall ABI issues

2022-10-06 Thread Jiaxun Yang
> 2022年10月6日 09:55,WANG Xuerui 写道: > > In commit 80f0fe3a85 ("linux-user: Fix syscall parameter handling for > MIPS n32") the ABI problem regarding offset64 on MIPS n32 was fixed, > but still some cases remain where the n32 is incorrectly treated as any > other 32-bit ABI that passes 64-bit ar

Re: [PATCH] qtest: start a VNC test

2022-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2022 at 5:43 PM Daniel P. Berrangé wrote: > On Thu, Oct 06, 2022 at 05:05:13PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > This is some of the simplest test we could perform, it simply connects > > to the VNC server via passed-in socket FDs

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Stefan Hajnoczi
On Thu, Oct 06, 2022 at 06:26:15PM +0800, Ming Lei wrote: > On Wed, Oct 05, 2022 at 11:11:32AM -0400, Stefan Hajnoczi wrote: > > On Tue, Oct 04, 2022 at 01:57:50AM +0200, Denis V. Lunev wrote: > > > On 10/3/22 21:53, Stefan Hajnoczi wrote: > > > > On Fri, Sep 30, 2022 at 05:24:11PM +0800, Ming Lei

Re: [PULL v3 00/52] testing, gdbstub, plugin and gitdm updates

2022-10-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH] hw/char/pl011: fix baud rate calculation

2022-10-06 Thread Baruch Siach
The PL011 TRM says that "UARTIBRD = 0 is invalid and UARTFBRD is ignored when this is the case". But the code looks at FBRD for the invalid case. Fix this. Signed-off-by: Baruch Siach --- hw/char/pl011.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/pl011.c b/hw/cha

Re: [PATCH] hw/char/pl011: fix baud rate calculation

2022-10-06 Thread Baruch Siach
Hi Peter, On Thu, Oct 06 2022, Peter Maydell wrote: > On Thu, 6 Oct 2022 at 11:20, Baruch Siach wrote: >> >> The PL011 TRM says that "UARTIBRD = 0 is invalid and UARTFBRD is ignored >> when this is the case". But the code looks at FBRD for the invalid case. >> Fix this. >> >> Signed-off-by: Baruc

Re: [PATCH v3 01/42] target/arm: Split s2walk_secure from ipa_secure in get_phys_addr

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:24, Richard Henderson wrote: > > The starting security state comes with the translation regime, > not the current state of arm_is_secure_below_el3(). > > Create a new local variable, s2walk_secure, which does not need > to be written back to result->attrs.secure -- we comp

Re: [PATCH v3 03/42] target/arm: Fix S2 disabled check in S1_ptw_translate

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:26, Richard Henderson wrote: > > Pass the correct stage2 mmu_idx to regime_translation_disabled, > which we computed afterward. > > Signed-off-by: Richard Henderson > --- > v3: Move earlier in the patch set. > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] gitmodules: recurse by default

2022-10-06 Thread Michael S. Tsirkin
On Thu, Oct 06, 2022 at 02:02:53PM +0100, Peter Maydell wrote: > On Thu, 6 Oct 2022 at 13:36, Michael S. Tsirkin wrote: > > > > The most commmon complaint about submodules is that > > they don't follow when one switches branches in the > > main repo. Enable recursing into submodules by default > >

Re: [PATCH v3 19/42] target/arm: Fix cacheattr in get_phys_addr_disabled

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:53, Richard Henderson wrote: > > Do not apply memattr or shareability for Stage2 translations. > Make sure to apply HCR_{DC,DCT} only to Regime_EL10, per the > pseudocode in AArch64.S1DisabledOutput. > > Signed-off-by: Richard Henderson > --- > v3: Do not use a switch or

Re: [PATCH v3 20/42] target/arm: Use tlb_set_page_full

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:44, Richard Henderson wrote: > > Adjust GetPhysAddrResult to fill in CPUTLBEntryFull, > so that it may be passed directly to tlb_set_page_full. > > The change is large, but mostly mechanical. The major > non-mechanical change is page_size -> lg_page_size. > Most of the ti

Re: [PATCH v3 15/42] target/arm: Remove env argument from combined_attrs_fwb

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:39, Richard Henderson wrote: > > This value is unused. > > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 21/42] target/arm: Enable TARGET_PAGE_ENTRY_EXTRA

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:54, Richard Henderson wrote: > > Copy attrs and sharability, into the TLB. This will eventually "shareability" is how the Arm ARM spells it. > be used by S1_ptw_translate to report stage1 translation failures, > and by do_ats_write to fill in PAR_EL1. > > Signed-off-by:

Re: [PATCH v3 22/42] target/arm: Use probe_access_full for MTE

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:50, Richard Henderson wrote: > > The CPUTLBEntryFull structure now stores the original pte attributes, as > well as the physical address. Therefore, we no longer need a separate > bit in MemTxAttrs, nor do we need to walk the tree of memory regions. > > Signed-off-by: Ric

Re: [PATCH v3 23/42] target/arm: Use probe_access_full for BTI

2022-10-06 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:38, Richard Henderson wrote: > > Add a field to TARGET_PAGE_ENTRY_EXTRA to hold the guarded bit. > In is_guarded_page, use probe_access_full instead of just guessing > that the tlb entry is still present. Also handles the FIXME about > executing from device memory. > > Si

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

2022-10-06 Thread Jarkko Sakkinen
On Thu, Sep 15, 2022 at 10:29:07PM +0800, Chao Peng wrote: > This new extension, indicated by the new flag KVM_MEM_PRIVATE, adds two > additional KVM memslot fields private_fd/private_offset to allow > userspace to specify that guest private memory provided from the > private_fd and guest_phys_addr

Re: [PATCH v2 2/2] virtio-blk: add zoned storage emulation for zoned devices

2022-10-06 Thread Stefan Hajnoczi
On Thu, Sep 29, 2022 at 05:48:21PM +0800, Sam Li wrote: > This patch extends virtio-blk emulation to handle zoned device commands > by calling the new block layer APIs to perform zoned device I/O on > behalf of the guest. It supports Report Zone, four zone oparations (open, > close, finish, reset),

Re: [PATCH v2 2/2] dump: fix kdump to work over non-aligned blocks

2022-10-06 Thread David Hildenbrand
On 05.09.22 14:57, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Rewrite get_next_page() to work over non-aligned blocks. When it encounters non aligned addresses, it will try to fill a page provided by the caller. This solves a kdump crash with "tpm-crb-cmd" RAM memory region, qe

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

2022-10-06 Thread Jarkko Sakkinen
On Thu, Oct 06, 2022 at 05:58:03PM +0300, Jarkko Sakkinen wrote: > On Thu, Sep 15, 2022 at 10:29:07PM +0800, Chao Peng wrote: > > This new extension, indicated by the new flag KVM_MEM_PRIVATE, adds two > > additional KVM memslot fields private_fd/private_offset to allow > > userspace to specify tha

Re: [PATCH] gitmodules: recurse by default

2022-10-06 Thread Philippe Mathieu-Daudé via
Hi Michael, On 6/10/22 13:39, Michael S. Tsirkin wrote: The most commmon complaint about submodules is that Typo "common" they don't follow when one switches branches in the main repo. Enable recursing into submodules by default to address that. Signed-off-by: Michael S. Tsirkin --- .git

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Thu, Oct 06, 2022 at 09:59:40AM -0400, Stefan Hajnoczi wrote: > On Thu, Oct 06, 2022 at 06:26:15PM +0800, Ming Lei wrote: > > On Wed, Oct 05, 2022 at 11:11:32AM -0400, Stefan Hajnoczi wrote: > > > On Tue, Oct 04, 2022 at 01:57:50AM +0200, Denis V. Lunev wrote: > > > > On 10/3/22 21:53, Stefan Ha

  1   2   3   >