On Sat, 1 Oct 2022 at 17:50, Richard Henderson <richard.hender...@linaro.org> wrote: > > The CPUTLBEntryFull structure now stores the original pte attributes, as > well as the physical address. Therefore, we no longer need a separate > bit in MemTxAttrs, nor do we need to walk the tree of memory regions. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > ---
> @@ -162,6 +143,13 @@ static uint8_t *allocation_tag_mem(CPUARMState *env, int > ptr_mmu_idx, > return NULL; > } > > + /* > + * Remember these values across the second lookup below, > + * which may invalidate this pointer via tlb resize. > + */ > + ptr_paddr = full->phys_addr; > + attrs = full->attrs; Can we set full = NULL here to catch any accidental attempts to use the pointer after this point? Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
