Hi Michael,

On 6/10/22 13:39, Michael S. Tsirkin wrote:
The most commmon complaint about submodules is that
Typo "common"

they don't follow when one switches branches in the
main repo. Enable recursing into submodules by default
to address that.

Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
---
  .gitmodules | 23 +++++++++++++++++++++++
  1 file changed, 23 insertions(+)
We have 3 kinds of submodule (or more?):
1/ required to *build* QEMU
2/ required to *test* QEMU
3/ only here for satisfies license of firmware blobs shipped with QEMU.

IIUC, long-term we want to move 3/ in another repository.

Could we only set "recurse=true" for 1/ ?

What is your use-case? Do we need it also for 2/ ?

diff --git a/.gitmodules b/.gitmodules
index aedd9a03d4..5f32332aff 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,69 +1,92 @@
  [submodule "roms/seabios"]
        path = roms/seabios
+       recurse = true
        url = https://gitlab.com/qemu-project/seabios.git/
  [submodule "roms/SLOF"]
        path = roms/SLOF
+       recurse = true
        url = https://gitlab.com/qemu-project/SLOF.git
  [submodule "roms/ipxe"]
        path = roms/ipxe
+       recurse = true
        url = https://gitlab.com/qemu-project/ipxe.git
  [submodule "roms/openbios"]
        path = roms/openbios
+       recurse = true
        url = https://gitlab.com/qemu-project/openbios.git
  [submodule "roms/qemu-palcode"]
        path = roms/qemu-palcode
+       recurse = true
        url = https://gitlab.com/qemu-project/qemu-palcode.git
  [submodule "roms/sgabios"]
        path = roms/sgabios
+       recurse = true
        url = https://gitlab.com/qemu-project/sgabios.git
  [submodule "dtc"]
        path = dtc
+       recurse = true
        url = https://gitlab.com/qemu-project/dtc.git
  [submodule "roms/u-boot"]
        path = roms/u-boot
+       recurse = true
        url = https://gitlab.com/qemu-project/u-boot.git
  [submodule "roms/skiboot"]
        path = roms/skiboot
+       recurse = true
        url = https://gitlab.com/qemu-project/skiboot.git
  [submodule "roms/QemuMacDrivers"]
        path = roms/QemuMacDrivers
+       recurse = true
        url = https://gitlab.com/qemu-project/QemuMacDrivers.git
  [submodule "ui/keycodemapdb"]
        path = ui/keycodemapdb
+       recurse = true
        url = https://gitlab.com/qemu-project/keycodemapdb.git
  [submodule "roms/seabios-hppa"]
        path = roms/seabios-hppa
+       recurse = true
        url = https://gitlab.com/qemu-project/seabios-hppa.git
  [submodule "roms/u-boot-sam460ex"]
        path = roms/u-boot-sam460ex
+       recurse = true
        url = https://gitlab.com/qemu-project/u-boot-sam460ex.git
  [submodule "tests/fp/berkeley-testfloat-3"]
        path = tests/fp/berkeley-testfloat-3
+       recurse = true
        url = https://gitlab.com/qemu-project/berkeley-testfloat-3.git
  [submodule "tests/fp/berkeley-softfloat-3"]
        path = tests/fp/berkeley-softfloat-3
+       recurse = true
        url = https://gitlab.com/qemu-project/berkeley-softfloat-3.git
  [submodule "roms/edk2"]
        path = roms/edk2
+       recurse = true
        url = https://gitlab.com/qemu-project/edk2.git
  [submodule "slirp"]
        path = slirp
+       recurse = true
        url = https://gitlab.com/qemu-project/libslirp.git
  [submodule "roms/opensbi"]
        path = roms/opensbi
+       recurse = true
        url =   https://gitlab.com/qemu-project/opensbi.git
  [submodule "roms/qboot"]
        path = roms/qboot
+       recurse = true
        url = https://gitlab.com/qemu-project/qboot.git
  [submodule "meson"]
        path = meson
+       recurse = true
        url = https://gitlab.com/qemu-project/meson.git
  [submodule "roms/vbootrom"]
        path = roms/vbootrom
+       recurse = true
        url = https://gitlab.com/qemu-project/vbootrom.git
  [submodule "tests/lcitool/libvirt-ci"]
        path = tests/lcitool/libvirt-ci
+       recurse = true
        url = https://gitlab.com/libvirt/libvirt-ci.git
  [submodule "subprojects/libvfio-user"]
        path = subprojects/libvfio-user
+       recurse = true
        url = https://gitlab.com/qemu-project/libvfio-user.git

Reply via email to