Re: Maximum QMP reply size

2022-09-19 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Sep 16, 2022 at 04:12:00PM +0100, Peter Maydell wrote: >> On Thu, 15 Sept 2022 at 16:21, Dr. David Alan Gilbert >> wrote: >> > >> > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> > > On Tue, 6 Sept 2022 at 20:41, John Snow wrote: >> > > > Hi, I suspect

Re: [PATCH v1 0/2] introduce qemu_socketpiar()

2022-09-19 Thread Guoyi Tu
Hi Peter, what do you think about this patches? If this could be merged in upstream, i will start to update the test codes On 8/23/22 15:50, t...@chinatelecom.cn wrote: From: Guoyi Tu Introduce qemu_socketpair() to create socket pair fd, and set the close-on-exec flag at default as with the

suport sr-iov to virtio-net

2022-09-19 Thread leohou
hi all, I want to support sr-iov to virtio-net, How about this feature?

suport sr-iov to virtio-net

2022-09-19 Thread leohou
hi all, I want to support sr-iov to virtio-net, How about this feature?

suport sr-iov to virtio-net

2022-09-19 Thread leohou
hi all, I want to support sr-iov to virtio-net, How about this feature?

suport sr-iov to virtio-net

2022-09-19 Thread leohou
hi all, Why can't I receive a subscription reply email?

Re: [PATCH v9 1/7] include: add zoned device structs

2022-09-19 Thread Sam Li
Damien Le Moal 于2022年9月19日 周一16:04写道: > On 9/19/22 09:50, Sam Li wrote: > > Stefan Hajnoczi 于2022年9月18日周日 04:17写道: > >> > >> On Thu, Sep 15, 2022 at 06:06:38PM +0800, Sam Li wrote: > >>> Eric Blake 于2022年9月15日周四 16:05写道: > > On Sat, Sep 10, 2022 at 01:27:53PM +0800, Sam Li wrote: > >>>

subscription

2022-09-19 Thread Leo Hou
Why can't I receive a subscription reply email?

Re: [PATCH 1/4] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_M68K

2022-09-19 Thread Richard Henderson
On 9/17/22 13:25, Mark Cave-Ayland wrote: The M68K_FEATURE_M68000 feature is misleading in that its name suggests the feature is defined just for Motorola 68000 CPUs, whilst in fact it is defined for all Motorola 680X0 CPUs. In order to avoid confusion with the other M68K_FEATURE_M680X0 constan

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-19 Thread Richard Henderson
On 9/18/22 00:29, Philippe Mathieu-Daudé wrote: On 17/9/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-19 Thread Richard Henderson
On 9/17/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Signed-off-by: Mark Cave-Ayland --- target/m

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-19 Thread Markus Armbruster
Claudio Fontana writes: > On 9/16/22 16:26, Markus Armbruster wrote: >> Claudio Fontana writes: >> >>> On 9/16/22 11:27, Markus Armbruster wrote: Claudio Fontana writes: [...] > diff --git a/block.c b/block.c > index bc85f46eed..8b610c6d95 100644 > --- a/block.c > +++ b/

Re: [PATCH v9 1/7] include: add zoned device structs

2022-09-19 Thread Damien Le Moal
On 9/19/22 09:50, Sam Li wrote: > Stefan Hajnoczi 于2022年9月18日周日 04:17写道: >> >> On Thu, Sep 15, 2022 at 06:06:38PM +0800, Sam Li wrote: >>> Eric Blake 于2022年9月15日周四 16:05写道: On Sat, Sep 10, 2022 at 01:27:53PM +0800, Sam Li wrote: > Signed-off-by: Sam Li > Reviewed-by: Stefan Haj

Re: [PATCH 3/4] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check

2022-09-19 Thread Richard Henderson
On 9/17/22 13:25, Mark Cave-Ayland wrote: Now that M68K_FEATURE_M68000 has been renamed to M68K_FEATURE_M68K it is easier to see that the privilege exception check is wrong: it is currently only generated for ColdFire CPUs when in fact it should also be generated for Motorola CPUs from the 6801

Re: [PATCH 1/1] s390x/tcg: Fix opcode for lzrf

2022-09-19 Thread David Hildenbrand
On 14.09.22 12:57, Christian Borntraeger wrote: Fix the opcode for Load and Zero Rightmost Byte (32). Cc: qemu-sta...@nongnu.org Reported-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Christian Borntraeger --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-19 Thread Claudio Fontana
On 9/19/22 10:17, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 9/16/22 16:26, Markus Armbruster wrote: >>> Claudio Fontana writes: >>> On 9/16/22 11:27, Markus Armbruster wrote: > Claudio Fontana writes: > > [...] > >> diff --git a/block.c b/block.c >> index bc8

Re: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-09-19 Thread David Hildenbrand
On 15.09.22 16:29, Chao Peng wrote: From: "Kirill A. Shutemov" KVM can use memfd-provided memory for guest memory. For normal userspace accessible memory, KVM userspace (e.g. QEMU) mmaps the memfd into its virtual address space and then tells KVM to use the virtual address to setup the mapping

Re: [PATCH v2 08/11] vfio/migration: Remove VFIO migration protocol v1

2022-09-19 Thread liulongfang via
On 2022/5/31 1:07, Avihai Horon Wrote: > Now that v2 protocol implementation has been added, remove the > deprecated v1 implementation. > "struct vfio_device_migration_info" still exists in vfio.h, why does qemu need to delete v1 implementation? > Signed-off-by: Avihai Horon > --- > hw/vfio/comm

[PATCH 2/3] virtio-net: update the default and max of rx/tx_queue_size

2022-09-19 Thread liuhaiwei
Set the max of tx_queue_size to 4096 even if the backends are not vhost-user. Set the default of rx/tx_queue_size to 2048 if the backends are vhost-user, otherwise to 4096. Signed-off-by: liuhaiwei --- hw/net/virtio-net.c | 40 ++-- 1 file changed, 30 inserti

[PATCH 1/3] virtio-net: fix max vring buf size when set ring num

2022-09-19 Thread liuhaiwei
Signed-off-by: liuhaiwei --- hw/virtio/virtio.c | 10 +++--- include/hw/virtio/virtio.h | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 5d607aeaa0..d93c20d747 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c

[PATCH 3/3] virtio-net: set the max of queue size to 4096

2022-09-19 Thread liuhaiwei
Signed-off-by: liuhaiwei --- hw/net/virtio-net.c | 8 hw/virtio/virtio.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index d63ef24e6a..df16995146 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3479,23 +

[PATCH] migration: Fix a potential guest memory corruption

2022-09-19 Thread Zhenzhong Duan
Imagine a rare case, after a dirty page is sent to compression threads's ring, dirty bitmap sync trigger right away and mark the same page dirty again and sent. Then the new page may be overwriten by stale page in compression threads's ring in the destination. So we need to ensure there is only on

Re: [PATCH v2 08/11] vfio/migration: Remove VFIO migration protocol v1

2022-09-19 Thread Philippe Mathieu-Daudé via
On Mon, May 30, 2022 at 7:56 PM Avihai Horon wrote: > > Now that v2 protocol implementation has been added, remove the > deprecated v1 implementation. Worth a note in docs/about/deprecated.rst? > Signed-off-by: Avihai Horon > --- > hw/vfio/common.c | 19 +- > hw/vfio/migration.c

Re: [PATCH 31/51] tests/qtest: Support libqtest to build and run on Windows

2022-09-19 Thread Bin Meng
Hi, On Thu, Sep 1, 2022 at 12:29 AM Marc-André Lureau wrote: > > Hi > > On Wed, Aug 24, 2022 at 2:46 PM Bin Meng wrote: >> >> From: Bin Meng >> >> At present the libqtest codes were written to depend on several >> POSIX APIs, including fork(), kill() and waitpid(). Unfortunately >> these APIs a

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-19 Thread Maksim Davydov
 Hi!14.09.2022, 21:25, "Vladimir Sementsov-Ogievskiy" :On 9/14/22 13:55, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable mac

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-19 Thread Philippe Mathieu-Daudé via
On 16/9/22 11:27, Markus Armbruster wrote: Claudio Fontana writes: improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *nam

Re: [PATCH 2/3] virtio-net: update the default and max of rx/tx_queue_size

2022-09-19 Thread Michael S. Tsirkin
On Mon, Sep 19, 2022 at 05:39:14AM -0400, liuhaiwei wrote: > Set the max of tx_queue_size to 4096 even if the backends > are not vhost-user. > > Set the default of rx/tx_queue_size to 2048 if the backends > are vhost-user, otherwise to 4096. > > Signed-off-by: liuhaiwei Pls include motivation

Re: [PATCH 1/3] virtio-net: fix max vring buf size when set ring num

2022-09-19 Thread Michael S. Tsirkin
On Mon, Sep 19, 2022 at 05:39:13AM -0400, liuhaiwei wrote: Pls write a commit log. Explain what is this patch fixing and why this is the correct fix. > Signed-off-by: liuhaiwei Please use your full first and last name. No anonymous contributions. > --- > hw/virtio/virtio.c | 10 +

Re: [PATCH 3/3] virtio-net: set the max of queue size to 4096

2022-09-19 Thread Michael S. Tsirkin
same comments as other patches. besides ... On Mon, Sep 19, 2022 at 05:39:15AM -0400, liuhaiwei wrote: > Signed-off-by: liuhaiwei > --- > hw/net/virtio-net.c | 8 > hw/virtio/virtio.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) coding style violations all over the place

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-19 Thread Maksim Davydov
Hi! 16.09.2022, 08:57, "Markus Armbruster" :Maksim Davydov writes:  This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable m

Re: [PATCH] target/riscv: Check the correct exception cause in vector GDB stub

2022-09-19 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/18 16:32, frank.ch...@sifive.com wrote: From: Frank Chang After RISCVException enum is introduced, riscv_csrrw_debug() returns RISCV_EXCP_NONE to indicate there's no error. RISC-V vector GDB stub should check the result against RISCV_EXCP_NONE instead

Re: [PULL 00/10] QAPI patches patches for 2022-09-07

2022-09-19 Thread Markus Armbruster
Gentle reminder, Victor :) Markus Armbruster writes: > Markus Armbruster writes: > >> Kevin Wolf writes: >> >>> Am 07.09.2022 um 17:03 hat Markus Armbruster geschrieben: The following changes since commit 946e9bccf12f2bcc3ca471b820738fb22d14fc80: Merge tag 'samuel-thiba

Re: [PATCH v2 08/11] vfio/migration: Remove VFIO migration protocol v1

2022-09-19 Thread Alex Williamson
On Mon, 19 Sep 2022 16:35:49 +0800 liulongfang wrote: > On 2022/5/31 1:07, Avihai Horon Wrote: > > Now that v2 protocol implementation has been added, remove the > > deprecated v1 implementation. > > "struct vfio_device_migration_info" still exists in vfio.h, > why does qemu need to delete v1 i

Re: [PATCH 5/5] target/loongarch: div if x/0 set dividend to 0

2022-09-19 Thread gaosong
在 2022/9/17 下午6:12, Richard Henderson 写道: On 9/17/22 11:12, gaosong wrote: 在 2022/9/17 下午4:59, Qi Hu 写道: On 2022/9/17 15:59, Song Gao wrote: div.d, div.du, div,w, div.wu, the LoongArch host if x/0  the result is 0. The message has a typo: "div,w" => "div.w" Also I don't know why we need

[PATCH] vhost-user-blk: fix the resize crash

2022-09-19 Thread Li Feng
If the os is not installed and doesn't have the virtio guest driver, the vhost dev isn't started, so the dev->vdev is NULL. Reproduce: mount a Win 2019 iso, go into the install ui, then resize the virtio-blk device, qemu crash. Signed-off-by: Li Feng --- hw/block/vhost-user-blk.c | 4 1 fi

[PATCH] virtio-net: set the max of queue size to 4096 according to the virtio specs, The maximum Queue Size value is 32768 : https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x

2022-09-19 Thread liuhaiwei
the limit of maximum of rx_queue_size and tx_queue to 1024 is so small as to affect our network performance when using the virtio-net and vhost , we cannot set the maximum size beyond 1k. why not enlarge the maximum size (such as 4096) when using the vhost backend? Signed-off-by: liuhaiwei ---

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-09-19 Thread Thomas Huth
On 06/09/2022 18.31, Patrick Venture wrote: The register tests walks all the registers to verify they are initially 0 when appropriate. However, if the MAC address is set in the register space, this should not be checked against 0. Reviewed-by: Hao Wu Change-Id: I02426e39bdab33ceedd42c49d23

[PULL 8/9] hw/loongarch: Support memory hotplug

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Add hotplug/unplug interface for memory device. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-9-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig | 2 + hw/loongarch/acpi-build.c | 32 +--- hw/lo

[PULL 7/9] hw/loongarch: Fix acpi ged irq number in dsdt table

2022-09-19 Thread Song Gao
From: Xiaojuan Yang In dsdt, acpi ged irq should use gsi number, and the VIRT_SCI_IRQ means it. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-8-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/acpi-build.c | 2 +- 1 file changed, 1 insert

[PULL 6/9] hw/loongarch: Add RAMFB to dynamic_sysbus_devices list

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Add RAMFB device to dynamic_sysbus_devices list so that it can be hotpluged to the machine. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-7-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/virt.c | 2 ++ 1 file changed

[PULL 5/9] hw/loongarch: Add hotplug handler for machine

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Add hotplug handler for LoongArch virt machine and now only support the dynamic sysbus device. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-6-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/virt.c | 32 ++

[PULL 9/9] hw/loongarch: Improve acpi dsdt table

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Cleanup the previous pci information in acpi dsdt table. And using the common acpi_dsdt_add_gpex function to build the gpex and pci information. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-10-yangxiaoj...@loongson.cn> Signed-off-by: Son

[PULL 1/9] hw/loongarch: Remove vga device when loongarch init

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Remove the vga device when loongarch machine init and we will support other display device in the future. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-2-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig | 1 -

[PULL 2/9] hw/loongarch: Support fw_cfg dma function

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Support fw_cfg dma function for LoongArch virt machine. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-3-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig | 1 + hw/loongarch/fw_cfg.c | 3 ++- hw/loongarch/virt.

[PULL 0/9] loongarch-to-apply queue

2022-09-19 Thread Song Gao
The following changes since commit d29201ff34a135cdfc197f4413c1c5047e4f58bb: Merge tag 'pull-hmp-20220915a' of https://gitlab.com/dagrh/qemu into staging (2022-09-17 10:31:11 -0400) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarc

Re: [PATCH] virtio-net: set the max of queue size to 4096 according to the virtio specs, The maximum Queue Size value is 32768 : https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.h

2022-09-19 Thread Michael S. Tsirkin
subject is unreasonably long. limit it to 50 characters. esp links do not belong there. Looks like this is a repost, ignoring most comments on the previous version. This kind of thing is ok as a conversation starter but then pls add RFC in the subject. On Mon, Sep 19, 2022 at 08:28:22AM -0400,

[PULL 3/9] hw/loongarch: Add interrupt information to FDT table

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Add interrupt information to FDT table, such as interrupt controller info, compatiable info, etc. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-4-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/virt.c | 29 +++

[PULL 4/9] hw/loongarch: Add platform bus support

2022-09-19 Thread Song Gao
From: Xiaojuan Yang Add platform bus support and add the bus information such as address, size, irq number to FDT table. Signed-off-by: Xiaojuan Yang Acked-by: Song Gao Message-Id: <20220908094623.73051-5-yangxiaoj...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig| 1

Re: [PATCH] tests/vm: update NetBSD to 9.3

2022-09-19 Thread Thomas Huth
On 06/09/2022 03.04, Brad Smith wrote: tests/vm: update NetBSD to 9.3 Signed-off-by: Brad Smith --- tests/vm/netbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index da6773ff59..aa54338dfa 100755 --- a/tests/vm/netbsd +++ b/tests/

Re: [PATCH v3 1/5] tests/x86: Add subtest with 'q35' machine type to device-plug-test

2022-09-19 Thread Denis V. Lunev
On 9/15/22 15:14, Michael Labiuk wrote: Configure pci bridge setting to plug pci device and unplug. Move common code for device removing to function. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 83 -- 1 file changed, 58 insertions(+), 25

[PATCH v3 4/4] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-09-19 Thread Antonio Caggiano
From: Dmitry Osipenko Host blobs don't need udmabuf, it's only needed by guest blobs. The host blobs are utilized by the Mesa virgl driver when persistent memory mapping is needed by a GL buffer, otherwise virgl driver doesn't use blobs. Persistent mapping support bumps GL version from 4.3 to 4.5

[PATCH v3 2/4] virtio-gpu: hostmem

2022-09-19 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- v2: Formatting fixes hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33 +

Re: [PATCH] tests/vm: update NetBSD to 9.3

2022-09-19 Thread Brad Smith
On September 19, 2022 9:05:31 a.m. Thomas Huth wrote: On 06/09/2022 03.04, Brad Smith wrote: tests/vm: update NetBSD to 9.3 Signed-off-by: Brad Smith --- tests/vm/netbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index da6773ff59.

Re: [PATCH v2 08/11] vfio/migration: Remove VFIO migration protocol v1

2022-09-19 Thread Philippe Mathieu-Daudé via
On Mon, Sep 19, 2022 at 1:57 PM Alex Williamson wrote: > > On Mon, 19 Sep 2022 16:35:49 +0800 > liulongfang wrote: > > > On 2022/5/31 1:07, Avihai Horon Wrote: > > > Now that v2 protocol implementation has been added, remove the > > > deprecated v1 implementation. > > > "struct vfio_device_migrat

[PATCH v3 3/4] virtio-gpu: Handle resource blob commands

2022-09-19 Thread Antonio Caggiano
Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko --- v2: Fix memory leaks and unm

[PATCH v3 1/4] virtio: Add shared memory capability

2022-09-19 Thread Antonio Caggiano
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David A

Re: [PATCH v3 2/5] tests/x86: Add 'q35' machine type to ivshmem-test

2022-09-19 Thread Denis V. Lunev
On 9/15/22 15:14, Michael Labiuk wrote: Configure pci bridge setting to test ivshmem on 'q35'. < empty line here is needed Signed-off-by: Michael Labiuk --- tests/qtest/ivshmem-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/ivshmem-tes

Re: [PATCH v3 4/5] tests/x86: Add 'q35' machine type to hotplug hd-geo-test

2022-09-19 Thread Denis V. Lunev
On 9/15/22 15:14, Michael Labiuk wrote: Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 148 ++ 1 file changed, 148 insertions(+

[PATCH v3 0/4] virtio-gpu: Blob resources

2022-09-19 Thread Antonio Caggiano
Add shared memory and support blob resource creation, mapping and unmapping through virglrenderer new stable APIs[0] when available. [0] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 Antonio Caggiano (1): virtio-gpu: Handle resource blob commands Dmitry Osipenko (1):

[PATCH v5 0/1] virtio-gpu: CONTEXT_INIT feature

2022-09-19 Thread Antonio Caggiano
This is a different attempt at upstreaming the work I have been doing to enable support for the Venus Virtio-GPU Vulkan driver. I believe the previous one [0] was a bit too much stuff in one place, therefore with this I would like to try a more fine-grained approach. I will just start by the CONT

[PATCH] build: remove extra parentheses causing missing rebuilds

2022-09-19 Thread Paolo Bonzini
Because of two stray parentheses at the end of the definition of ninja-cmd-goals, the test that is last in the .check-TESTSUITENAME.deps variable will not be rebuilt. Fix that. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile

Re: [PATCH qboot] Place setup_data at location specified by host

2022-09-19 Thread Paolo Bonzini
On Fri, Sep 16, 2022 at 3:42 PM Jason A. Donenfeld wrote: > QEMU places setup_data at a particular location, which cannot be > relocated due to it containing self references in absolute address > terms. For this reason, it supplies the intended location in > FW_CFG_SETUP_ADDR, which is what SeaBIO

[PATCH v5 1/1] virtio-gpu: CONTEXT_INIT feature

2022-09-19 Thread Antonio Caggiano
Create virgl renderer context with flags using context_id when valid. The feature can be enabled via the context_init config option. A warning message will be emitted and the feature will not be used when linking with virglrenderer versions without context_init support. Signed-off-by: Antonio Cagg

[PATCH] qboot: update to latest submodule

2022-09-19 Thread Paolo Bonzini
Include patch "Place setup_data at location specified by host" from Jason A. Donenfeld. Cc: Jason A. Donenfeld Signed-off-by: Paolo Bonzini --- roms/qboot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/qboot b/roms/qboot index a5300c4949..8ca302e86d 16 --- a/roms/q

Re: [kvm-unit-tests PATCH v4 07/12] arm: pmu: Basic event counter Tests

2022-09-19 Thread Zenghui Yu via
Hi Eric, A few comments when looking through the PMU test code (2 years after the series was merged). On 2020/4/3 15:13, Eric Auger wrote: Adds the following tests: - event-counter-config: test event counter configuration - basic-event-count: - programs counters #0 and #1 to count 2 required

Re: [kvm-unit-tests PATCH v4 08/12] arm: pmu: Test SW_INCR event count

2022-09-19 Thread Zenghui Yu via
Hi Eric, On 2020/4/3 15:13, Eric Auger wrote: +static void test_sw_incr(void) +{ + uint32_t events[] = {SW_INCR, SW_INCR}; + int i; + + if (!satisfy_prerequisites(events, ARRAY_SIZE(events))) + return; + + pmu_reset(); + + write_regn_el0(pmevtyper, 0,

Re: [kvm-unit-tests PATCH v4 10/12] arm: pmu: test 32-bit <-> 64-bit transitions

2022-09-19 Thread Zenghui Yu via
Hi Eric, On 2020/4/3 15:13, Eric Auger wrote: +static void test_chain_promotion(void) +{ [...] + /* start as MEM_ACCESS/CPU_CYCLES and move to CHAIN/MEM_ACCESS */ + pmu_reset(); + write_regn_el0(pmevtyper, 0, MEM_ACCESS | PMEVTYPER_EXCLUDE_EL0); + write_regn_el0(pmev

Re: [PATCH] qboot: update to latest submodule

2022-09-19 Thread Jason A. Donenfeld
FYI, that commit made it to: https://github.com/bonzini/qboot But wasn't pushed to: https://github.com/qemu/qboot https://gitlab.com/qemu-project/qboot https://git.qemu.org/?p=qboot.git;a=summary I have no idea what's canonical, except that the submodule in the qemu checkout seems to point to t

RE: [PATCH v6 1/2] Update AVX512 support for xbzrle_encode_buffer

2022-09-19 Thread Xu, Ling1
Hi, All, This is a "ping" email~. It seems that my patch has been ignored. So I "ping" this patchset. Link for the patch: https://lore.kernel.org/qemu-devel/20220826095719.2887535-2-ling1...@intel.com/ Best Regards Ling -Original Message- From: Xu, Ling1 Sent: Friday,

Re: [PATCH v3 2/5] tests/x86: Add 'q35' machine type to ivshmem-test

2022-09-19 Thread Michael Labiuk
On 9/19/22 16:13, Denis V. Lunev wrote: On 9/15/22 15:14, Michael Labiuk wrote: diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index 9611d05eb5..0f9755abc6 100644 --- a/tests/qtest/ivshmem-test.c +++ b/tests/qtest/ivshmem-test.c @@ -378,6 +378,32 @@ static void test_ivshmem

Re: [kvm-unit-tests PATCH v4 07/12] arm: pmu: Basic event counter Tests

2022-09-19 Thread Andrew Jones
On Mon, Sep 19, 2022 at 10:30:01PM +0800, Zenghui Yu wrote: > Hi Eric, > > A few comments when looking through the PMU test code (2 years after > the series was merged). Yes, these patches were merged long ago. Now you need to send patches, not comments. Thanks, drew

Re: [PATCH v6 2/2] i386: Add notify VM exit support

2022-09-19 Thread Peter Xu
On Mon, Sep 19, 2022 at 01:46:38PM +0800, Chenyi Qiang wrote: > > > On 9/17/2022 5:57 AM, Peter Xu wrote: > > On Thu, Sep 15, 2022 at 05:28:39PM +0800, Chenyi Qiang wrote: > > > There are cases that malicious virtual machine can cause CPU stuck (due > > > to event windows don't open up), e.g., in

Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups

2022-09-19 Thread Stefan Hajnoczi
On Fri, Sep 16, 2022 at 07:51:40AM +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Hi, > > > > This is an update to the previous series which fixes the last few > > niggling CI failures I was seeing. > > > >Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups > >

Re: [PULL 0/9] loongarch-to-apply queue

2022-09-19 Thread Stefan Hajnoczi
Hi Song Gao, Please push your GPG public key to a key server using "gpg --send-keys 0x40A2FFF239263EDF". That way others can search for and download your public key. Thanks, Stefan

Travis CI webhook returns HTTP 500

2022-09-19 Thread Stefan Hajnoczi
GitLab sends qemu.git push event webhooks to Travis CI. Recently the webhooks have been failing with HTTP 500 Internal Server Error. Do you know how to resolve this or who configured Travis CI webhooks for QEMU? Thanks, Stefan

Re: [PATCH v2 00/11] iotests: use vm.cmd()

2022-09-19 Thread Vladimir Sementsov-Ogievskiy
ping On 6/6/22 10:27, Vladimir Sementsov-Ogievskiy wrote: Hi all! Let's get rid of pattern result = self.vm.qmp(...) self.assert_qmp(result, 'return', {}) And switch to just self.vm.cmd(...) Supersedes: <20220408170214.45585-1-vsement...@openvz.org> ([RFC 0/2] introduce Q

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

2022-09-19 Thread Vladimir Sementsov-Ogievskiy
ping. Seems, all patches are reviewed On 7/26/22 23:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's the first part of "[PATCH v5 00/45] Transactional block-graph modifying API", updated and is fully reviewed by Hanna. v7: add r-bs and rebase on master Vladimir Sementsov-Ogievskiy (15):

[PATCH 0/3] Add a host power device

2022-09-19 Thread Jian Zhang
This patchset adds a host power device and added it into the g220a mahcine. The BMC have a important is to control the power of the host, usually it is nessary in a hardware platform. The BMC(soc) usually had a output pin to control the power of the host, and a input pin to get the power status of

[PATCH 1/3] hw/gpio/aspeed_gpio: Add gpios in/out init

2022-09-19 Thread Jian Zhang
Add gpios in/out init for aspeed gpio to add the ability to connect to other gpio devices. Based the qdev-core.h comments, If you want to connect a GPIO to other devices, you need to call qdev_init_gpio_in() or qdev_init_gpio_out(). ``` For input gpios: * * Outbound GPIO lines can be connected

[PATCH 2/3] hw/misc/host_power: Add a simple host power device

2022-09-19 Thread Jian Zhang
This Host Power device privide a simple power control logic for a host, like use a bmc to control the power of a host. This device has 2 gpio, one is input named "button", another gpio is output named "power-good", when button have a falling edge, invert the "power-good" gpio. Signed-off-by: Jian

[PATCH 3/3] hw/arm/aspeed: g220a: Add host-power device

2022-09-19 Thread Jian Zhang
Add power-button/power-good gpio connect between g220a BMC machind(soc gpio) and host. Tested: In qemu, use g220a image ~# ipmitool power status Chassis Power is off ~# ipmitool power on Chassis Power Control: Up/On ~# ipmitool power status Chassis Power is on ~# ipmitool power off Chassis Pow

[PULL 00/21] Misc patches for 2022-09-19

2022-09-19 Thread Paolo Bonzini
The following changes since commit d29201ff34a135cdfc197f4413c1c5047e4f58bb: Merge tag 'pull-hmp-20220915a' of https://gitlab.com/dagrh/qemu into staging (2022-09-17 10:31:11 -0400) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fet

Re: [PATCH v3 1/2] target/i386: Read 8 bytes from cvttps2pi/cvtps2pi memory operands

2022-09-19 Thread Paolo Bonzini
Hi, I think this is broken for big endian systems because ldq expects a pointer to xmm_t0.L(0) while ldo expects a pointer xmm_t0. I will fix the bug in my new AVX decoder though, where it is also present. So thanks for the report! Paolo On Tue, Aug 30, 2022 at 5:48 AM Ricky Zhou wrote: > > Bef

[PULL 06/21] coverity: put NUBus under m68k component

2022-09-19 Thread Paolo Bonzini
It is only used by the Q800 emulation, so put it under that architecture. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/COMPONENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md index fc16

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-19 Thread Christian Schoenebeck
On Freitag, 9. September 2022 15:10:48 CEST Christian Schoenebeck wrote: > On Donnerstag, 8. September 2022 13:23:53 CEST Linus Heckemann wrote: > > The previous implementation would iterate over the fid table for > > lookup operations, resulting in an operation with O(n) complexity on > > the numb

[PULL 02/21] target/i386: Raise #GP on unaligned m128 accesses when required.

2022-09-19 Thread Paolo Bonzini
Many instructions which load/store 128-bit values are supposed to raise #GP when the memory operand isn't 16-byte aligned. This includes: - Instructions explicitly requiring memory alignment (Exceptions Type 1 in the "AVX and SSE Instruction Exception Specification" section of the SDM) - Le

[PULL 08/21] tests: unit: simplify test-visitor-serialization list tests

2022-09-19 Thread Paolo Bonzini
test-visitor-serialization list tests is using an "if" to pick either the first element of the list or the next one. This was done presumably to mimic the code that creates the list, which has to fill in either the head pointer or the next pointer of the last element. However, the code in the ins

[PULL 07/21] smbios: sanitize type from external type before checking have_fields_bitmap

2022-09-19 Thread Paolo Bonzini
test_bit uses header->type as an offset; if the file incorrectly specifies a type greater than 127, smbios_entry_add will read and write garbage. To fix this, just pass the smbios data through, assuming the user knows what to do. Reported by Coverity as CID 1487255. Signed-off-by: Paolo Bonzini

Re: [PATCH v3 2/2] target/i386: Raise #GP on unaligned m128 accesses when required.

2022-09-19 Thread Paolo Bonzini
Hi, I will merge this patch already, but with simpler code that doesn't look at PREFIX_VEX. The changes to the helpers and the addition of the aligned argument help with the new decoder as well, and I will build on top of them in the next submission of the AVX patches. Thanks! Paolo On Sat, Sep

[PULL 05/21] coverity: add new RISC-V component

2022-09-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/COMPONENTS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md index 3aad9cdfaf..fc1608932e 100644 --- a/scripts/coverity-scan/COMPONENTS.md +++ b/scripts/coveri

[PULL 09/21] tests: test-qga: close socket on failure to connect

2022-09-19 Thread Paolo Bonzini
Reported by Coverity as CID 1432543. Signed-off-by: Paolo Bonzini --- tests/unit/test-qga.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c index a05a4628ed..d27ff94d13 100644 --- a/tests/unit/test-qga.c +++ b/tests/unit/test-qga.c @@ -32,6 +32,7

[PULL 13/21] tests/tcg: refine MMX support in SSE tests

2022-09-19 Thread Paolo Bonzini
Extend the support to memory operands, and skip MMX instructions that were introduced in SSE times, because they are now covered in test-mmx. Signed-off-by: Paolo Bonzini --- tests/tcg/i386/test-avx.py | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff

[PULL 01/21] KVM: use store-release to mark dirty pages as harvested

2022-09-19 Thread Paolo Bonzini
The following scenario can happen if QEMU sets more RESET flags while the KVM_RESET_DIRTY_RINGS ioctl is ongoing on another host CPU: CPU0 CPU1 CPU2 --

[PULL 12/21] tests/tcg: i386: add MMX and 3DNow! tests

2022-09-19 Thread Paolo Bonzini
Adjust the test-avx.py generator to produce tests specifically for MMX and 3DNow. Using a separate generator introduces some code duplication, but is a simpler approach because of test-avx's extra complexity to support 3- and 4-operand AVX instructions. If needed, a common library can be introduc

[PULL 16/21] target/i386: correctly mask SSE4a bit indices in register operands

2022-09-19 Thread Paolo Bonzini
SSE4a instructions EXTRQ and INSERTQ have two bit index operands, that can be immediates or taken from an XMM register. In both cases, the fields are 6-bit wide and the top two bits in the byte are ignored. translate.c is doing that correctly for the immediate case, but not for the XMM case, so f

[PULL 04/21] spapr_pci: fix leak in spapr_phb_vfio_get_loc_code

2022-09-19 Thread Paolo Bonzini
Overwriting "path" in the second call to g_strdup_printf() causes a memory leak, even if the variable itself is g_autofree. Reported by Coverity as CID 1460454. Signed-off-by: Paolo Bonzini --- hw/ppc/spapr_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/sp

[PULL 14/21] tests/tcg: remove old SSE tests

2022-09-19 Thread Paolo Bonzini
The new testsuite is much more comprehensive, so remove the old one; it is also buggy (the pinsrw test uses incorrect constraints, with = instead of +, and the golden output for the fxsave tests differs depending on how the C library uses SSE and AVX instructions). Signed-off-by: Paolo Bonzini --

[PULL 17/21] target/i386: fix INSERTQ implementation

2022-09-19 Thread Paolo Bonzini
INSERTQ is defined to not modify any bits in the lower 64 bits of the destination, other than the ones being replaced with bits from the source operand. QEMU instead is using unshifted bits from the source for those bits. Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h| 10 +-

[PULL 21/21] qboot: update to latest submodule

2022-09-19 Thread Paolo Bonzini
Include patch "Place setup_data at location specified by host" from Jason A. Donenfeld. Cc: Jason A. Donenfeld Signed-off-by: Paolo Bonzini --- roms/qboot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/qboot b/roms/qboot index a5300c4949..8ca302e86d 16 --- a/roms/q

[PULL 19/21] target/i386: introduce insn_get_addr

2022-09-19 Thread Paolo Bonzini
The "O" operand type in the Intel SDM needs to load an 8- to 64-bit unsigned value, while insn_get is limited to 32 bits. Extract the code out of disas_insn and into a separate function. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 36 ++

  1   2   >