Gentle reminder, Victor :) Markus Armbruster <arm...@redhat.com> writes:
> Markus Armbruster <arm...@redhat.com> writes: > >> Kevin Wolf <kw...@redhat.com> writes: >> >>> Am 07.09.2022 um 17:03 hat Markus Armbruster geschrieben: >>>> The following changes since commit >>>> 946e9bccf12f2bcc3ca471b820738fb22d14fc80: >>>> >>>> Merge tag 'samuel-thibault' of https://people.debian.org/~sthibault/qemu >>>> into staging (2022-09-06 08:31:24 -0400) >>>> >>>> are available in the Git repository at: >>>> >>>> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-09-07 >>>> >>>> for you to fetch changes up to 6e7a37ffc230d06852f1a8893097331d39df77c9: >>>> >>>> qapi: fix examples of events missing timestamp (2022-09-07 15:10:13 >>>> +0200) >>>> >>>> ---------------------------------------------------------------- >>>> QAPI patches patches for 2022-09-07 >>>> >>>> ---------------------------------------------------------------- >>>> Victor Toso (10): >>>> qapi: fix example of query-ballon command >>>> qapi: fix example of query-vnc command >>>> qapi: fix example of query-dump-guest-memory-capability command >>>> qapi: fix example of BLOCK_JOB_READY event >>>> qapi: fix example of NIC_RX_FILTER_CHANGED event >>>> qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event >>>> qapi: fix example of MEM_UNPLUG_ERROR event >>>> qapi: fix examples of blockdev-add with qcow2 >>> >>> NACK, this patch is wrong. >>> >>> 'file' is a required member (defined in BlockdevOptionsGenericFormat), >>> removing it makes the example invalid. 'data-file' is only an additional >>> optional member to be used for external data files (i.e. when the guest >>> data is kept separate from the metadata in the .qcow2 file). >> >> I'll respin with #8 dropped. Thank you! > > Too late, it's already merged. > > Victor, could you fix on top? Or would you like me to revert the patch?
