Re: [PATCH v3 1/4] include/qemu: rename Windows context definitions to expose bitness

On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov wrote: > > Context structure in 64-bit Windows differs from 32-bit one and it > should be reflected in its name. > > Signed-off-by: Viktor Prutyanov > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau > --- > contrib/elf2dmp/

Re: [PATCH v3 2/4] dump/win_dump: add helper macros for Windows dump header access

On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov wrote: > > Perform read access to Windows dump header fields via helper macros. > This is preparation for the next 32-bit guest Windows dump support. > > Signed-off-by: Viktor Prutyanov Reviewed-by: Marc-André Lureau > --- > dump/win_dump.c |

Re: [PATCH v3 3/4] include/qemu: add 32-bit Windows dump structures

Hi On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov wrote: > > These structures are required to produce 32-bit guest Windows Complete > Memory Dump. Add 32-bit Windows dump header, CPU context and physical > memory descriptor structures along with corresponding definitions. > > Signed-off-by: Vi

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

On Apr 6 08:14, Cédric Le Goater wrote: > Hello Klaus, > > On 3/31/22 18:57, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add slave mode functionality for the Aspeed I2C controller. This is > > implemented by creating an Aspeed I2C Slave device that attaches to the > > bus. > > > > This

Re: [PATCH 0/2] Remove PCIE root bridge LSI on powernv

On Mon, Mar 21, 2022 at 04:33:55PM +0100, Frederic Barrat wrote: > The powernv8/powernv9/powernv10 machines allocate a LSI for their root > port bridge, which is not the case on real hardware. The default root > port implementation in qemu requests a LSI. Since the powernv > implementation derives

[PATCH v4 0/6] Support exporting BDSs via VDUSE

Hi all, Last few months ago, VDUSE (vDPA Device in Userspace) [1] has been merged into Linux kernel as a framework that make it possible to emulate a vDPA device in userspace. This series aimed at implementing a VDUSE block backend based on the qemu-storage-daemon infrastructure. To support that,

[PATCH v4 2/6] linux-headers: Add vduse.h

This adds vduse header to linux headers so that the relevant VDUSE API can be used in subsequent patches. Signed-off-by: Xie Yongji --- linux-headers/linux/vduse.h | 306 scripts/update-linux-headers.sh | 2 +- 2 files changed, 307 insertions(+), 1 deletion

[PATCH v4 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

VDUSE [1] is a linux framework that makes it possible to implement software-emulated vDPA devices in userspace. This adds a library as a subproject to help implementing VDUSE backends in QEMU. [1] https://www.kernel.org/doc/html/latest/userspace-api/vduse.html Signed-off-by: Xie Yongji --- MAIN

[PATCH v4 6/6] libvduse: Add support for reconnecting

To support reconnecting after restart or crash, VDUSE backend might need to resubmit inflight I/Os. This stores the metadata such as the index of inflight I/O's descriptors to a shm file so that VDUSE backend can restore them during reconnecting. Signed-off-by: Xie Yongji --- block/export/vduse-

[PATCH v4 5/6] vduse-blk: Add vduse-blk resize support

To support block resize, this uses vduse_dev_update_config() to update the capacity field in configuration space and inject config interrupt on the block resize callback. Signed-off-by: Xie Yongji Reviewed-by: Stefan Hajnoczi --- block/export/vduse-blk.c | 20 1 file change

Re: [PATCH v3 4/4] dump/win_dump: add 32-bit guest Windows support

Hi On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov wrote: > > Before this patch, 'dump-guest-memory -w' was accepting only 64-bit > dump header provided by guest through vmcoreinfo and thus was unable > to produce 32-bit guest Windows dump. So, add 32-bit guest Windows > dumping support. > > Si

Re: [PATCH] acpi: Bodge acpi_index migration

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Apr 05, 2022 at 08:06:58PM +0100, Dr. David Alan Gilbert (git) wrote: > > The patch is fine but pls repost as text not as > application/octet-stream. Let me try and figure out how; this is the same git send-email I've used for years; it's ou

[PATCH v4 1/6] block: Support passing NULL ops to blk_set_dev_ops()

This supports passing NULL ops to blk_set_dev_ops() so that we can remove stale ops in some cases. Signed-off-by: Xie Yongji --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index e0e1aff4b1..35457a6a1d 10

[PATCH v4 4/6] vduse-blk: implements vduse-blk export

This implements a VDUSE block backends based on the libvduse library. We can use it to export the BDSs for both VM and container (host) usage. The new command-line syntax is: $ qemu-storage-daemon \ --blockdev file,node-name=drive0,filename=test.img \ --export vduse-blk,node-name=drive0,i

[PATCH] acpi: Bodge acpi_index migration

binS1iWwfufXq.bin Description: Binary data

Re: [PATCH] acpi: Bodge acpi_index migration

* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: Hmm no, still bad mimetype -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[PATCH] hw/vfio/common: Fix a small boundary issue of a trace

From: Xiang Chen Right now the trace of vfio_region_sparse_mmap_entry is as follows: vfio_region_sparse_mmap_entry sparse entry 0 [0x1000 - 0x9000] Actually the range it wants to show is [0x1000 - 0x8fff]???so fix it. Signed-off-by: Xiang Chen --- hw/vfio/common.c | 2 +- 1 file changed, 1 ins

[PATCH] acpi: Bodge acpi_index migration

From: "Dr. David Alan Gilbert" The 'acpi_index' field is a statically configured field, which for some reason is migrated; this never makes much sense because it's command line static. However, on piix4 it's conditional, and the condition/test function ends up having the wrong pointer passed to

Re: [PATCH] acpi: Bodge acpi_index migration

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Apr 05, 2022 at 08:06:58PM +0100, Dr. David Alan Gilbert (git) wrote: > > The patch is fine but pls repost as text not as > application/octet-stream. I've just reposted it with a fudged header that should be fine. ( 20220406083531.10217-1-dg

Re: [PATCH 20/32] include: move dump_in_progress() to runstate.h

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Along with other state tracking functions. Rename it for consistency. > > Signed-off-by: Marc-André Lureau > --- > include/qemu-common.h | 4 > include/sysemu/runstate.h | 1 + > dump/dump.c | 4 ++-- > mon

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

On 4/6/22 09:40, Klaus Jensen wrote: On Apr 6 08:14, Cédric Le Goater wrote: Hello Klaus, On 3/31/22 18:57, Klaus Jensen wrote: From: Klaus Jensen Add slave mode functionality for the Aspeed I2C controller. This is implemented by creating an Aspeed I2C Slave device that attaches to the bus.

Re: [PATCH] acpi: Bodge acpi_index migration

* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 5 Apr 2022 20:06:58 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > The 'acpi_index' field is a statically configured field, which for > > some reason is migrated; this never makes much s

Re: [PATCH 0/2] Remove PCIE root bridge LSI on powernv

On 06/04/2022 09:52, Michael S. Tsirkin wrote: On Mon, Mar 21, 2022 at 04:33:55PM +0100, Frederic Barrat wrote: The powernv8/powernv9/powernv10 machines allocate a LSI for their root port bridge, which is not the case on real hardware. The default root port implementation in qemu requests a L

Re: [PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > According to GLib API: > g_get_current_time has been deprecated since version 2.62 and should not > be used in newly-written code. GTimeVal is not year-2038-safe. Use > g_get_real_time() instead. > > Signed-off-by: Marc-André Lurea

Re: [RFC PATCH 1/1] kvm-all.c: hint Valgrind that kvm_get_one_reg() inits memory

On Tue, Apr 05, 2022 at 10:04:39AM -0300, Daniel Henrique Barboza wrote: > There is a lot of Valgrind warnings about conditional jump depending on > unintialized values like this one (taken from a pSeries guest): > > Conditional jump or move depends on uninitialised value(s) > at 0xB011DC: kv

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

On Apr 6 10:52, Cédric Le Goater wrote: > On 4/6/22 09:40, Klaus Jensen wrote: > > On Apr 6 08:14, Cédric Le Goater wrote: > > > Hello Klaus, > > > > > > On 3/31/22 18:57, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > > > > > Add slave mode functionality for the Aspeed I2C controller.

Re: [RFC PATCH 1/1] kvm-all.c: hint Valgrind that kvm_get_one_reg() inits memory

On Tue, Apr 05, 2022 at 03:30:26PM +0100, Peter Maydell wrote: > On Tue, 5 Apr 2022 at 14:07, Daniel Henrique Barboza > wrote: > > > > There is a lot of Valgrind warnings about conditional jump depending on > > unintialized values like this one (taken from a pSeries guest): > > > > Conditional ju

Re: [PATCH for-7.1 1/1] hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c

On Tue, Apr 05, 2022 at 05:34:16PM -0300, Daniel Henrique Barboza wrote: > spapr_nvdimm_flush_completion_cb() and flush_worker_cb() are using the > DRC object returned by spapr_drc_index() without checking it for NULL. > In this case we would be dereferencing a NULL pointer when doing > SPAPR_NVDIM

Re: [PATCH] acpi: Bodge acpi_index migration

On Wed, 6 Apr 2022 09:35:31 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The 'acpi_index' field is a statically configured field, which for > some reason is migrated; this never makes much sense because it's > command line static. that's true only for the f

Re: [PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62

Hi On Wed, Apr 6, 2022 at 1:08 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > According to GLib API: > > g_get_current_time has been deprecated since version 2.62 and should not > > be used in newly-written code. GTimeVal is not year-203

Re: [PATCH] acpi: Bodge acpi_index migration

* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 6 Apr 2022 09:35:31 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > The 'acpi_index' field is a statically configured field, which for > > some reason is migrated; this never makes much sense beca

Re: [PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62

On Wed, Apr 6, 2022 at 1:35 PM Marc-André Lureau wrote: > > Hi > > On Wed, Apr 6, 2022 at 1:08 PM Markus Armbruster wrote: > > > > marcandre.lur...@redhat.com writes: > > > > > From: Marc-André Lureau > > > > > > According to GLib API: > > > g_get_current_time has been deprecated since version 2

Re: [RFC PATCH 3/4] hw/i2c: add slave mode for aspeed_i2c

On 4/6/22 11:16, Klaus Jensen wrote: On Apr 6 10:52, Cédric Le Goater wrote: On 4/6/22 09:40, Klaus Jensen wrote: On Apr 6 08:14, Cédric Le Goater wrote: Hello Klaus, On 3/31/22 18:57, Klaus Jensen wrote: From: Klaus Jensen Add slave mode functionality for the Aspeed I2C controller. This

Re: [PATCH] acpi: Bodge acpi_index migration

* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 09:35:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > The 'acpi_index' field is a statically configured field, whi

Re: [RFC PATCH 2/7] aspeed: i2c: Add ctrl_global_rsvd property

Hello Joe, On 3/31/22 06:32, Joe Komlodi wrote: The Aspeed I2C controller is used across other SKUs that have different reserved bits for the ctrl_global_rsvd register. So some AST2600 SoCs can not set the new/old modes and the clock divider ? Signed-off-by: Joe Komlodi Change-Id: I606c59

Re: [RFC PATCH 6/7] aspeed: i2c: Add PKT_DONE IRQ to trace

Klaus, On 3/31/22 06:32, Joe Komlodi wrote: Signed-off-by: Joe Komlodi Change-Id: I566eb09f4b9016e24570572f367627f6594039f5 --- hw/i2c/aspeed_i2c.c | 3 +++ hw/i2c/trace-events | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c in

Re: [PATCH v1] hw/ppc: change indentation to spaces from TABs

On Tue, Apr 5, 2022 at 10:36 PM Guo Zhi wrote: > > There are still some files in the QEMU PPC code base that use TABs for > indentation instead of using spaces. > The TABs should be replaced so that we have a consistent coding style. > > If this patch is applied, issue: > > https://gitlab.com/qe

Re: [RFC PATCH 1/7] hw/registerfields: Add shared fields macros

On 3/31/22 06:32, Joe Komlodi wrote: Occasionally a peripheral will have different operating modes, where the MMIO layout changes, but some of the register fields have the same offsets and behaviors. To help support this, we add SHARED_FIELD_XX macros that create SHIFT, LENGTH, and MASK macros f

[PATCH] migration: Fix operator type

From: "Dr. David Alan Gilbert" Clang spotted an & that should have been an &&; fix it. Reported by: David Binderman / https://gitlab.com/dcb Fixes: 65dacaa04fa ("migration: introduce save_normal_page()") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/963 Signed-off-by: Dr. David Alan Gi

Re: [RFC PATCH 4/7] aspeed: i2c: Use reg array instead of individual vars

On 3/31/22 06:32, Joe Komlodi wrote: Using a register array will allow us to represent old-mode and new-mode I2C registers by using the same underlying register array, instead of adding an entire new set of variables to represent new mode. I agree with this change. Please do it first before int

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Tuesday 05 Apr 2022 at 18:03:21 (+), Sean Christopherson wrote: > On Tue, Apr 05, 2022, Quentin Perret wrote: > > On Monday 04 Apr 2022 at 15:04:17 (-0700), Andy Lutomirski wrote: > > > >> - it can be very useful for protected VMs to do shared=>private > > > >>conversions. Think of a VM

Re: [RFC PATCH 0/7] aspeed: i2c: Add new mode support

Hello Joe, On 3/31/22 06:32, Joe Komlodi wrote: Hi all, This series migrates the Aspeed I2C controller to use the register API, I like the idea but it's an earthquake in the I2C model and they are other patchsets on the way. Let's wait a bit before changing it all. and then adds new mode su

Re: [PATCH 13/32] error-report: replace deprecated g_get_current_time() with glib >= 2.62

Marc-André Lureau writes: > On Wed, Apr 6, 2022 at 1:35 PM Marc-André Lureau > wrote: >> >> Hi >> >> On Wed, Apr 6, 2022 at 1:08 PM Markus Armbruster wrote: >> > >> > marcandre.lur...@redhat.com writes: >> > >> > > From: Marc-André Lureau >> > > >> > > According to GLib API: >> > > g_get_curre

Re: [PATCH 32/32] Remove qemu-common.h include from most units

First of all: thank you so much for completing the "empty out qemu-common.h" job! This is what's left: #ifndef QEMU_COMMON_H #define QEMU_COMMON_H /* Copyright string for -version arguments, About dialogs, etc */ #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ "Fabric

Re: [PATCH 32/32] Remove qemu-common.h include from most units

On Wed, 6 Apr 2022 at 11:45, Markus Armbruster wrote: > > First of all: thank you so much for completing the "empty out > qemu-common.h" job! > > This is what's left: > > #ifndef QEMU_COMMON_H > #define QEMU_COMMON_H > > /* Copyright string for -version arguments, About dialogs, etc */

Re: Fix a potential Use-after-free in virtio_iommu_handle_command() (v6.2.0).

On Fri, Feb 25, 2022 at 11:58:43AM +0800, wli...@stu.xidian.edu.cn wrote: > Hi all, > > Here is a new patch with Signed-off-by tags. > The old one is wrong for it did't have Signed-off-by tags. > I am looking forward to your confirmation. > > Thanks, > Wentao > From 8ece42bda1099a9a0df584cac2478

Re: FSFreeze on Windows VM

Hi Shelly, Can you provide your version of Guest Agent? Is it built from upstream or some VirtIO-Win release? Previously we had some issues related to wrong error messages from Guest Agent. Best Regards, Konstantin Kostiuk. On Tue, Mar 29, 2022 at 6:24 PM Shelly Kagan wrote: > Hi all, > I'm h

Re: [PATCH] migration: Fix operator type

On Wed, 6 Apr 2022 at 11:31, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Clang spotted an & that should have been an &&; fix it. > > Reported by: David Binderman / https://gitlab.com/dcb > Fixes: 65dacaa04fa ("migration: introduce save_normal_page()") > Resolves: ht

Re: [PATCH] migration: Fix operator type

On Wed, Apr 06, 2022 at 11:25:15AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Clang spotted an & that should have been an &&; fix it. > > Reported by: David Binderman / https://gitlab.com/dcb > Fixes: 65dacaa04fa ("migration: introduce save_normal_page()") >

[PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires initiator=X when hmat=on. Unsetting this flag allows to create more complex memory topologies by having m

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Tuesday 05 Apr 2022 at 10:51:36 (-0700), Andy Lutomirski wrote: > Let's try actually counting syscalls and mode transitions, at least > approximately. For non-direct IO (DMA allocation on guest side, not straight > to/from pagecache or similar): > > Guest writes to shared DMA buffer. Assume

Re: [PATCH v2 1/9] qemu/int128: add int128_urshift

On 4/5/22 14:55, Lucas Mateus Castro(alqotel) wrote: From: Matheus Ferst Implement an unsigned right shift for Int128 values and add the same tests cases of int128_rshift in the unit test. Signed-off-by: Matheus Ferst Signed-off-by: Lucas Mateus Castro (alqotel) --- include/qemu/int128.h|

Re: [PATCH for-7.1 01/18] hw/arm/exynos4210: Use TYPE_OR_IRQ instead of custom OR-gate device

On 4/4/22 10:46, Peter Maydell wrote: The Exynos4210 SoC device currently uses a custom device "exynos4210.irq_gate" to model the OR gate that feeds each CPU's IRQ line. We have a standard TYPE_OR_IRQ device for this now, so use that instead. (This is a migration compatibility break, but that i

Re: [PATCH for-7.1 03/18] hw/arm/exynos4210: Put a9mpcore device into state struct

On 4/4/22 10:46, Peter Maydell wrote: The exynos4210 SoC mostly creates its child devices as if it were board code. This includes the a9mpcore object. Switch that to a new-style "embedded in the state struct" creation, because in the next commit we're going to want to refer to the object again

Re: [PATCH for-7.1 04/18] hw/arm/exynos4210: Drop int_gic_irq[] from Exynos4210Irq struct

On 4/4/22 10:46, Peter Maydell wrote: The only time we use the int_gic_irq[] array in the Exynos4210Irq struct is in the exynos4210_realize() function: we initialize it with the GPIO inputs of the a9mpcore device, and then a bit later on we connect those to the outputs of the internal combiner.

Re: [PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

On Wed, 6 Apr 2022 14:29:56 +0200 Brice Goglin wrote: > From: Brice Goglin > > The "Memory Proximity Domain Attributes" structure of the ACPI HMAT > has a "Processor Proximity Domain Valid" flag that is currently > always set because Qemu -numa requires initiator=X when hmat=on. > > Unsetting

Re: [PATCH for-7.1 05/18] hw/arm/exynos4210: Coalesce board_irqs and irq_table

On 4/4/22 10:46, Peter Maydell wrote: The exynos4210 code currently has two very similar arrays of IRQs: * board_irqs is a field of the Exynos4210Irq struct which is filled in by exynos4210_init_board_irqs() with the appropriate qemu_irqs for each IRQ the board/SoC can assert * irq_t

Re: [PATCH for-7.1 06/18] hw/arm/exynos4210: Fix code style nit in combiner_grp_to_gic_id[]

On 4/4/22 10:46, Peter Maydell wrote: Fix a missing set of spaces around '-' in the definition of combiner_grp_to_gic_id[]. We're about to move this code, so fix the style issue first to keep checkpatch happy with the code-motion patch. Signed-off-by: Peter Maydell --- hw/intc/exynos4210_gic.c

Re: [PATCH for-7.1 07/18] hw/arm/exynos4210: Move exynos4210_init_board_irqs() into exynos4210.c

On 4/4/22 10:46, Peter Maydell wrote: The function exynos4210_init_board_irqs() currently lives in exynos4210_gic.c, but it isn't really part of the exynos4210.gic device -- it is a function that implements (some of) the wiring up of interrupts between the SoC's GIC and combiner components. This

Re: [PATCH for-7.1 08/18] hw/arm/exynos4210: Put external GIC into state struct

On 4/4/22 10:46, Peter Maydell wrote: Switch the creation of the external GIC to the new-style "embedded in state struct" approach, so we can easily refer to the object elsewhere during realize. Signed-off-by: Peter Maydell --- include/hw/arm/exynos4210.h | 2 ++ include/hw/intc/exynos4

Re: [PATCH for-7.1 09/18] hw/arm/exynos4210: Drop ext_gic_irq[] from Exynos4210Irq struct

On 4/4/22 10:46, Peter Maydell wrote: The only time we use the ext_gic_irq[] array in the Exynos4210Irq struct is during realize of the SoC -- we initialize it with the input IRQs of the external GIC device, and then connect those to outputs of other devices further on in realize (including in th

Re: [PATCH for-7.1 10/18] hw/arm/exynos4210: Move exynos4210_combiner_get_gpioin() into exynos4210.c

On 4/4/22 10:46, Peter Maydell wrote: The function exynos4210_combiner_get_gpioin() currently lives in exynos4210_combiner.c, but it isn't really part of the combiner device itself -- it is a function that implements the wiring up of some interrupt sources to multiple combiner inputs. Move it to

Re: [PATCH for-7.1 11/18] hw/arm/exynos4210: Delete unused macro definitions

On 4/4/22 10:46, Peter Maydell wrote: Delete a couple of #defines which are never used. Signed-off-by: Peter Maydell --- include/hw/arm/exynos4210.h | 4 1 file changed, 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH for-7.1 12/18] hw/arm/exynos4210: Use TYPE_SPLIT_IRQ in exynos4210_init_board_irqs()

On 4/4/22 10:46, Peter Maydell wrote: In exynos4210_init_board_irqs(), use the TYPE_SPLIT_IRQ device instead of qemu_irq_split(). Signed-off-by: Peter Maydell --- include/hw/arm/exynos4210.h | 9 hw/arm/exynos4210.c | 41 + 2 files change

Re: [PATCH for-7.1 13/18] hw/arm/exynos4210: Fill in irq_table[] for internal-combiner-only IRQ lines

On 4/4/22 10:46, Peter Maydell wrote: In exynos4210_init_board_irqs(), the loop that handles IRQ lines that are in a range that applies to the internal combiner only creates a splitter for those interrupts which go to both the internal combiner and to the external GIC, but it does nothing at all

Re: [PATCH for-7.1 14/18] hw/arm/exynos4210: Connect MCT_G0 and MCT_G1 to both combiners

On 4/4/22 10:46, Peter Maydell wrote: Currently for the interrupts MCT_G0 and MCT_G1 which are the only ones in the input range of the external combiner and which are also wired to the external GIC, we connect them only to the internal combiner and the external GIC. This seems likely to be a bug,

Re: [PATCH for-7.1 15/18] hw/arm/exynos4210: Don't connect multiple lines to external GIC inputs

On 4/4/22 10:46, Peter Maydell wrote: The combiner_grp_to_gic_id[] array includes the EXT_GIC_ID_MCT_G0 and EXT_GIC_ID_MCT_G1 multiple times. This means that we will connect multiple IRQs up to the same external GIC input, which is not permitted. We do the same thing in the code in exynos4210_ini

Re: [PATCH for-7.1 16/18] hw/arm/exynos4210: Fold combiner splits into exynos4210_init_board_irqs()

On 4/4/22 10:46, Peter Maydell wrote: At this point, the function exynos4210_init_board_irqs() splits input IRQ lines to connect them to the input combiner, output combiner and external GIC. The function exynos4210_combiner_get_gpioin() splits some of the combiner input lines further to connect

Re: [PATCH for-7.1 17/18] hw/arm/exynos4210: Put combiners into state struct

On 4/4/22 10:46, Peter Maydell wrote: Switch the creation of the combiner devices to the new-style "embedded in state struct" approach, so we can easily refer to the object elsewhere during realize. Signed-off-by: Peter Maydell --- include/hw/arm/exynos4210.h | 3 ++ include/hw/int

Re: [PATCH for-7.1 18/18] hw/arm/exynos4210: Drop Exynos4210Irq struct

On 4/4/22 10:46, Peter Maydell wrote: The only time we use the int_combiner_irq[] and ext_combiner_irq[] arrays in the Exynos4210Irq struct is during realize of the SoC -- we initialize them with the input IRQs of the combiner devices, and then connect those to outputs of other devices in exynos4

Re: iotest40 problem

On 3/31/22 16:46, John Snow wrote: On Thu, Mar 31, 2022, 10:37 AM John Snow > wrote: On Thu, Mar 31, 2022, 6:47 AM Li Zhang mailto:lizh...@suse.de>> wrote: On 3/31/22 08:10, Hanna Reitz wrote: > On 29.03.22 18:49, Li Zhang wrote: >> Up

Re: [PATCH qemu] ppc/vof: Fix uninitialized string tracing

On 4/6/22 01:50, Alexey Kardashevskiy wrote: There are error paths which do not initialize propname but the trace_exit label prints it anyway. This initializes the problem string. Spotted by Coverity CID 1487241. Signed-off-by: Alexey Kardashevskiy --- Reviewed-by: Daniel Henrique Barboza

Re: [PATCH 12/32] qga: replace deprecated g_get_current_time()

On 3/23/22 16:57, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau According to GLib API: g_get_current_time has been deprecated since version 2.62 and should not be used in newly-written code. GTimeVal is not year-2038-safe. Use g_get_real_time() instead. Signed-off-by: Marc-Andr

[BUG]QEMU jump into interrupt when single-stepping on aarch64

Dear, folks, I try to debug Linux kernel with QEMU in single-stepping mode on aarch64 platform, the added breakpoint hits but after I type `step`, the gdb always jumps into interrupt. My env: gdb-10.2 qemu-6.2.0 host kernel: 5.10.84 VM kernel: 5.10.84 The steps

Re: iotest40 problem

On Wed, Apr 6, 2022, 10:53 AM Li Zhang wrote: > On 3/31/22 16:46, John Snow wrote: > > > > > > On Thu, Mar 31, 2022, 10:37 AM John Snow > > wrote: > > > > > > > > On Thu, Mar 31, 2022, 6:47 AM Li Zhang > > wrote: > > > > On 3/31/2

Re: [PATCH v3 3/4] include/qemu: add 32-bit Windows dump structures

Hi On Wed, Apr 6, 2022 at 10:51 AM Marc-André Lureau wrote: > > Hi > > On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov > wrote: > > > > These structures are required to produce 32-bit guest Windows Complete > > Memory Dump. Add 32-bit Windows dump header, CPU context and physical > > memory de

Re: [PATCH v3 4/4] dump/win_dump: add 32-bit guest Windows support

Hi On Wed, Apr 6, 2022 at 11:00 AM Marc-André Lureau wrote: > > Hi > > On Fri, Mar 25, 2022 at 11:51 PM Viktor Prutyanov > wrote: > > > > Before this patch, 'dump-guest-memory -w' was accepting only 64-bit > > dump header provided by guest through vmcoreinfo and thus was unable > > to produce 32

Re: [PATCH] hw/vfio/common: Fix a small boundary issue of a trace

On 4/6/22 10:14, chenxiang via wrote: From: Xiang Chen Right now the trace of vfio_region_sparse_mmap_entry is as follows: vfio_region_sparse_mmap_entry sparse entry 0 [0x1000 - 0x9000] Actually the range it wants to show is [0x1000 - 0x8fff]，so fix it. Signed-off-by: Xiang Chen --- hw/v

Re: [PATCH] [PATCH RFC v3] Implements Backend Program conventions for vhost-user-scsi

On Tue, Apr 05, 2022 at 07:22:38AM -0500, Sakshi Kaushik wrote: Thanks for the patch! Comments below: > Signed-off-by: Sakshi Kaushik > --- > contrib/vhost-user-scsi/vhost-user-scsi.c | 76 +++ > 1 file changed, 51 insertions(+), 25 deletions(-) > > diff --git a/contrib/vho

[PATCH 1/2] block/throttle-groups: use QEMU_CLOCK_REALTIME for qtest too

Virtual clock just doesn't tick for iotests, and throttling just not work. Let's use realtime clock. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/throttle-groups.c | 4 1 file changed, 4 deletions(-) diff --git a/block/throttle-groups.c b/block/throttle-groups.c index fb203c3ced..

[PATCH for-7.1 0/2] throttle-groups: use QEMU_CLOCK_REALTIME

Hi all! Honestly, I don't know why QEMU_CLOCK_VIRTUAL is used here. Comment say that that's specially for throttle tests, but the simple test (patch 02) just hangs because QEMU_CLOCK_VIRTUAL clock just doesn't tick in this environment.. And if we change the clock to QEMU_CLOCK_REALTIME, new test w

[PATCH 2/2] iotests: add throttle test

Add simple test for throttle filter driver. Without previous "block/throttle-groups: use QEMU_CLOCK_REALTIME for qtest too" commit the test hangs forever, because previously used VIRTUAL clock just doesn't tick for iotests. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/test

Re: [PATCH] acpi: Bodge acpi_index migration

On Wed, Apr 06, 2022 at 10:44:18AM +0100, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan

Re: [PATCH v1] configure: judge build dir permission

On Tue, Apr 05, 2022 at 09:48:20PM +0800, Guo Zhi wrote: > If this patch is applied, issue: > > https://gitlab.com/qemu-project/qemu/-/issues/321 > > can be closed. > > Signed-off-by: Guo Zhi > --- > configure | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/con

Re: [PATCH v1] configure: judge build dir permission

On Wed, 6 Apr 2022 at 16:37, Stefan Hajnoczi wrote: > > On Tue, Apr 05, 2022 at 09:48:20PM +0800, Guo Zhi wrote: > > If this patch is applied, issue: > > > > https://gitlab.com/qemu-project/qemu/-/issues/321 > > > > can be closed. > > > > Signed-off-by: Guo Zhi > > --- > > configure | 8 +++-

Re: [PATCH] acpi: Bodge acpi_index migration

On Wed, 6 Apr 2022 10:38:51 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 09:35:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > The 'acpi_index' field is a statically confi

Re: [PATCH v2 5/7] block/block-copy: block_copy(): add timeout_ns parameter

01.04.2022 16:16, Hanna Reitz wrote: -static void coroutine_fn block_copy_async_co_entry(void *opaque) -{ -    block_copy_common(opaque); +    ret = call_state->ret; + +    return ret; But here we still need to free call_state, right? Right, will fix. -- Best regards, Vladimir

Re: [PATCH] acpi: Bodge acpi_index migration

* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 6 Apr 2022 10:38:51 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan Gilber

[PATCH] [PATCH RFC v4] Implements Backend Program conventions for vhost-user-scsi

Signed-off-by: Sakshi Kaushik --- contrib/vhost-user-scsi/vhost-user-scsi.c | 78 +++ 1 file changed, 52 insertions(+), 26 deletions(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c index 4f6e3e2a24..0c38c2988c 100644 ---

Re: [PATCH] acpi: Bodge acpi_index migration

On Wed, 6 Apr 2022 17:11:09 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 10:38:51 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > >

Re: [BUG]QEMU jump into interrupt when single-stepping on aarch64

On 4/6/22 09:30, Shuai Xue wrote: Dear, folks, I try to debug Linux kernel with QEMU in single-stepping mode on aarch64 platform, the added breakpoint hits but after I type `step`, the gdb always jumps into interrupt. My env: gdb-10.2 qemu-6.2.0 host kernel: 5.10.84

Re: [RFC PATCH 0/4] hw/i2c: i2c slave mode support

> On Apr 5, 2022, at 11:07 PM, Klaus Jensen wrote: > > On Apr 5 20:52, Peter Delevoryas wrote: >> >> >>> On Mar 31, 2022, at 9:57 AM, Klaus Jensen wrote: >>> >>> From: Klaus Jensen >>> >>> Hi all, >>> >>> This RFC series adds I2C "slave mode" support for the Aspeed I2C >>> controller as

[PATCH v4 0/4] dump: add 32-bit guest Windows support

From: Viktor Prutyanov Since 32-bit versions of Windows still exist, there is a need to take live and crash dumps of such guests along with 64-bit guests. So, add an ability for 'dump-guest-memory -w' to take dumps from 32-bit guest. When running the command QEMU consumes 32-bit Complete Memory D

[PATCH v4 1/4] include/qemu: rename Windows context definitions to expose bitness

Context structure in 64-bit Windows differs from 32-bit one and it should be reflected in its name. Signed-off-by: Viktor Prutyanov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- contrib/elf2dmp/main.c | 6 +++--- dump/win_dump.c | 14 +++---

[PATCH v4 2/4] dump/win_dump: add helper macros for Windows dump header access

Perform read access to Windows dump header fields via helper macros. This is preparation for the next 32-bit guest Windows dump support. Signed-off-by: Viktor Prutyanov Reviewed-by: Marc-André Lureau --- dump/win_dump.c | 100 +++- 1 file changed, 65

[PATCH v4 3/4] include/qemu: add 32-bit Windows dump structures

These structures are required to produce 32-bit guest Windows Complete Memory Dump. Add 32-bit Windows dump header, CPU context and physical memory descriptor structures along with corresponding definitions. Signed-off-by: Viktor Prutyanov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-An

[PATCH v4 4/4] dump/win_dump: add 32-bit guest Windows support

Before this patch, 'dump-guest-memory -w' was accepting only 64-bit dump header provided by guest through vmcoreinfo and thus was unable to produce 32-bit guest Windows dump. So, add 32-bit guest Windows dumping support. Signed-off-by: Viktor Prutyanov Reviewed-by: Philippe Mathieu-Daudé Reviewe

Re: [PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

On 2/28/22 4:39 AM, Dov Murik wrote: > > > On 28/02/2022 11:31, Daniel P. Berrangé wrote: >> On Mon, Feb 28, 2022 at 09:30:14AM +, Dov Murik wrote: >>> Add a new field 'cpu0-id' to the response of query-sev-capabilities QMP >>> command. The value of the field is the base64-encoded unique ID

Re: [RFC v2 1/8] blkio: add io_uring block driver using libblkio

Am 05.04.2022 um 17:33 hat Stefan Hajnoczi geschrieben: > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for > high-performance disk I/O. It currently supports io_uring with > additional drivers planned. > > One of the reasons for developing libblkio is that other applications > bes

[RFC PATCH] tests/qtest: properly initialise the vring used idx

Eric noticed while attempting to enable the vhost-user-blk-test for Aarch64 that that things didn't work unless he put in a dummy guest_malloc() at the start of the test. Without it qvirtio_wait_used_elem() would assert when it reads a junk value for idx resulting in: qvirtqueue_get_buf: idx:240

  1   2   >