On Wed, 6 Apr 2022 at 11:45, Markus Armbruster <arm...@redhat.com> wrote: > > First of all: thank you so much for completing the "empty out > qemu-common.h" job! > > This is what's left: > > #ifndef QEMU_COMMON_H > #define QEMU_COMMON_H > > /* Copyright string for -version arguments, About dialogs, etc */ > #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ > "Fabrice Bellard and the QEMU Project developers" > > /* Bug reporting information for --help arguments, About dialogs, etc */ > #define QEMU_HELP_BOTTOM \ > "See <https://qemu.org/contribute/report-a-bug> for how to report > bugs.\n" \ > "More information on the QEMU project at <https://qemu.org>." > > #endif
> Rename the header? Or replace the macros by variables, and move their > declarations elsewhere? Not demands; this series is lovely progress as > is. We should put those in a qemu/copyright.h, I think. Leaving a "qemu-common.h" around is an open invitation to people throwing more random stuff into it again in future. As you say, we can totally do this as a later followup. thanks -- PMM
