First of all: thank you so much for completing the "empty out
qemu-common.h" job!
This is what's left:
#ifndef QEMU_COMMON_H
#define QEMU_COMMON_H
/* Copyright string for -version arguments, About dialogs, etc */
#define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \
"Fabrice Bellard and the QEMU Project developers"
/* Bug reporting information for --help arguments, About dialogs, etc */
#define QEMU_HELP_BOTTOM \
"See <https://qemu.org/contribute/report-a-bug> for how to report
bugs.\n" \
"More information on the QEMU project at <https://qemu.org>."
#endif
Rename the header? Or replace the macros by variables, and move their
declarations elsewhere? Not demands; this series is lovely progress as
is.
Ani Sinha <a...@anisinha.ca> writes:
> On Wed, Mar 23, 2022 at 9:32 PM <marcandre.lur...@redhat.com> wrote:
>
>> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>
>
> Empty patch descriptions are not a good idea. Please explain why this
> removal does not break things and maybe why the header got included
> initiatively.
Something like
The previous commits moved most of qemu-common.h's contents
elsewhere. Most inclusions are now useless. Remove them.
would do for me.
