Re: [PATCH v3 05/10] vdpa-dev: implement the realize interface

2022-03-29 Thread Stefano Garzarella
On Tue, Mar 29, 2022 at 7:16 AM Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > On Sat, Mar 19, 2022 at 03:20:07PM +0800, Longpeng(Mike) wrote: > > >From: Longpeng > > > > > [snap] > > > > static void vhost_vdpa_device_unrealize(DeviceState *dev) > > >@@ -66,6 +197,7 @@ sta

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-29 Thread Kshitij Suri
On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing. Thank you for your review and I apologise for that since I am fairly new to upstreaming. As per what I read version updates should be do

[PATCH 1/2] NVDIMM: rename NVDIMM::label_size to NVDIMM::lsa_size

2022-03-29 Thread Robert Hoo
Per recent spec[1], change struct NVDIMMDevice::label_size semanteme to describe the label's size in LSA (Label Storage Area). Instead, use new 'lsa_size' for the total size of LSA. [1]: UEFI spec v2.9, "Label Storage Area Description" in section 13.19. Signed-off-by: Robert Hoo Reviewed-by: Liu

[PATCH 0/2] Init vNVDIMM LSA if applicable

2022-03-29 Thread Robert Hoo
QEMU option "-device nvdimm,...,label-size=" designates a vNVDIMM with Label Storage Area (LSA), where stores the namespace labels and conforms to some format and rules defined by NVDIMM label protocol[1]. Recent guest Kernel, will by validating LSA to determine if the NVDIMM is label-capable. So

[PATCH 2/2] NVDIMM: Init vNVDIMM's LSA index block if it hasn't been

2022-03-29 Thread Robert Hoo
Since v2.7, QEMU has supported the emulation of NVDIMM's labels. With -device nvdimm,...,lsa-size=, the vNVDIMM to guest has this capability. But if the emulated LSA area isn't initialized, guest Kernel can't enumerate it correctly. This patch is to initialize/format the vNVDIMM's LSA, if it has b

Re: [PATCH v3 1/2] aspeed/hace: Support AST2600 HACE

2022-03-29 Thread Steven Lee
The 03/25/2022 15:08, Joel Stanley wrote: > Hi Steven, > > I've pointed out some small things like spelling fixes, and made a > suggestion to split the change into multiple patches. > > Aside from that, I need your help to understand what your change is > trying to do. > Hi Joel, Thanks for th

[PATCH v3 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-29 Thread Kshitij Suri
Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri Reviewed-by: Daniel P. Berrangé --- meson.build| 9 - meson_options.txt

[PATCH v3 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-29 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

[PATCH for-7.0] virtio: fix --enable-vhost-user build on non-Linux

2022-03-29 Thread Paolo Bonzini
The vhost-shadow-virtqueue.c build requires include files from linux-headers/, so it cannot be built on non-Linux systems. Fortunately it is only needed by vhost-vdpa, so move it there. Signed-off-by: Paolo Bonzini --- hw/virtio/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH for-7.0] virtio: fix --enable-vhost-user build on non-Linux

2022-03-29 Thread Jason Wang
On Tue, Mar 29, 2022 at 3:36 PM Paolo Bonzini wrote: > > The vhost-shadow-virtqueue.c build requires include files from > linux-headers/, so it cannot be built on non-Linux systems. We need decouple this dependency in the future. > Fortunately it is only needed by vhost-vdpa, so move it there.

On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Markus Armbruster
Kshitij Suri writes: > On 29/03/22 12:12 pm, Markus Armbruster wrote: >> If I count correctly, this is the fifth posting tagged "v2". Don't do >> that, please, as it's quite confusing. >> > Thank you for your review and I apologise for that since I am fairly > new to upstreaming. As per what I r

Re: [PATCH v1 5/9] wctablet: add appropriate unregister handler

2022-03-29 Thread Marc-André Lureau
On Tue, Mar 29, 2022 at 1:15 AM Maxim Davydov wrote: > > Attempt to finalize msmouse after initalization brings to segmentation > fault in QTAILQ_REMOVE. > > Signed-off-by: Maxim Davydov Reviewed-by: Marc-André Lureau > --- > chardev/wctablet.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH v1 4/9] msmouse: add appropriate unregister handler

2022-03-29 Thread Marc-André Lureau
On Tue, Mar 29, 2022 at 1:15 AM Maxim Davydov wrote: > > Attempt to finalize msmouse after initalization brings to segmentation > fault in QTAILQ_REMOVE. > > Signed-off-by: Maxim Davydov Reviewed-by: Marc-André Lureau > --- > chardev/msmouse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 de

Re: [PATCH v2 2/2] spapr: Move nested KVM hypercalls under a TCG only config.

2022-03-29 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of March 26, 2022 8:11 am: > These are the spapr virtual hypervisor implementation of the nested > KVM API. They only make sense when running with TCG. Reviewed-by: Nicholas Piggin > > Signed-off-by: Fabiano Rosas > --- > hw/ppc/spapr_hcall.c | 26 +++

Re: [PATCH v2 1/2] spapr: Move hypercall_register_softmmu

2022-03-29 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of March 26, 2022 8:11 am: > I'm moving this because next patch will add more code under the ifdef > and it will be cleaner if we keep them together. > > Also switch the ifdef branches to make it more convenient to add code > under CONFIG_TCG in the next patch

Re: [PATCH 0/2] ppc: fix vcpu hotunplug leak in spapr_realize_vcpu

2022-03-29 Thread Cédric Le Goater
On 3/29/22 03:24, David Gibson wrote: On Mon, Mar 28, 2022 at 09:59:16AM -0300, Daniel Henrique Barboza wrote: Hi, This is a memory leak found by Valgrind when testing vcpu hotplug/unplug in pSeries guests. Other vcpu hotplug/unplug leaks are still present in the common code (one in the KVM th

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Hanna Reitz
On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in st

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 1:29 pm, Markus Armbruster wrote: Kshitij Suri writes: On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing. Thank you for your review and I apologise for that since I am fai

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Daniel P . Berrangé
On Tue, Mar 29, 2022 at 09:59:55AM +0200, Markus Armbruster wrote: > Kshitij Suri writes: > > > On 29/03/22 12:12 pm, Markus Armbruster wrote: > >> If I count correctly, this is the fifth posting tagged "v2". Don't do > >> that, please, as it's quite confusing. > >> > > Thank you for your review

Re: [PATCH] tests/lcitool: Do not use a hard-coded /usr/bin/python3 as python interpreter

2022-03-29 Thread Daniel P . Berrangé
On Tue, Mar 29, 2022 at 08:39:58AM +0200, Thomas Huth wrote: > When running "make lcitool-refresh", this currently uses the hard-coded > /usr/bin/python3 from the script's shebang line for running Python. > That's bad, since neither /usr/bin/python3 is guaranteed to exist, nor > does it honor the p

Re: [PATCH for-7.0] virtio: fix --enable-vhost-user build on non-Linux

2022-03-29 Thread Eugenio Perez Martin
On Tue, Mar 29, 2022 at 9:38 AM Paolo Bonzini wrote: > > The vhost-shadow-virtqueue.c build requires include files from > linux-headers/, so it cannot be built on non-Linux systems. > Fortunately it is only needed by vhost-vdpa, so move it there. > Thanks for the catch! Acked-by: Eugenio Pérez

[PATCH v2 1/2] qcow2: Improve refcount structure rebuilding

2022-03-29 Thread Hanna Reitz
When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1]. There is no good reason for that except that it means we will not have to rewrite any refblocks we alread

[PATCH v2 2/2] iotests/108: Test new refcount rebuild algorithm

2022-03-29 Thread Hanna Reitz
One clear problem with how qcow2's refcount structure rebuild algorithm used to be before "qcow2: Improve refcount structure rebuilding" was that it is prone to failure for qcow2 images on block devices: There is generally unused space after the actual image, and if that exceeds what one refblock c

[PATCH v2 0/2] qcow2: Improve refcount structure rebuilding

2022-03-29 Thread Hanna Reitz
Hi, v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg00651.html Since it’s been a while since v1, let me reproduce parts from that cover letter here: When the qcow2 refcount structure is broken to a point where we cannot rely on any information from it (because it sh

Re: [PATCH 0/2] ppc: fix vcpu hotunplug leak in spapr_realize_vcpu

2022-03-29 Thread Daniel Henrique Barboza
On 3/29/22 05:36, Cédric Le Goater wrote: On 3/29/22 03:24, David Gibson wrote: On Mon, Mar 28, 2022 at 09:59:16AM -0300, Daniel Henrique Barboza wrote: Hi, This is a memory leak found by Valgrind when testing vcpu hotplug/unplug in pSeries guests. Other vcpu hotplug/unplug leaks are still

[PATCH for-7.0] main-loop: Disable GLOBAL_STATE_CODE() assertions

2022-03-29 Thread Hanna Reitz
These assertions are very useful for developers to find bugs, and so they have indeed pointed us towards bugs already. For users, it is not so useful to find these bugs. We should probably not enable them in releases until we are sufficiently certain that they will not fire during normal operatio

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 2:31 pm, Daniel P. Berrangé wrote: On Tue, Mar 29, 2022 at 09:59:55AM +0200, Markus Armbruster wrote: Kshitij Suri writes: On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 09:03, Markus Armbruster wrote: > A cover letter (git format-patch --cover-letter) lets you write an > introduction to the whole series. Simple series may not need an > introduction, but complex ones do. I always use one except when the > "series" is a single patch. Note

[RFC PATCH] docs/devel: add some notes on the binfmt-image-debian targets

2022-03-29 Thread Alex Bennée
We document some of this on the wiki but lets move it into our official developer notes documentation. Signed-off-by: Alex Bennée Cc: Paolo Bonzini --- docs/devel/testing.rst | 38 ++ 1 file changed, 38 insertions(+) diff --git a/docs/devel/testing.rst b/doc

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2022 11:54, Hanna Reitz wrote: On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts ou

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 3:18 pm, Peter Maydell wrote: On Tue, 29 Mar 2022 at 09:03, Markus Armbruster wrote: A cover letter (git format-patch --cover-letter) lets you write an introduction to the whole series. Simple series may not need an introduction, but complex ones do. I always use one except when

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 10:55, Kshitij Suri wrote: > On 29/03/22 3:18 pm, Peter Maydell wrote: > > Note that a multi-patch series always needs a cover letter, > > even if its contents are quite brief. Some of the automatic > > tooling gets confused by multi-patch series with no cover letter. > > Co

Re: [PATCH v7 02/17] qdev: unplug blocker for devices

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:31PM -0400, Jagannathan Raman wrote: > Add blocker to prevent hot-unplug of devices > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/qdev-core.h | 29 + > hw/core/q

Re: [PATCH-for-7.0] hw/pvrdma: Protect against buggy or malicious guest driver

2022-03-29 Thread Philippe Mathieu-Daudé
On 22/3/22 13:27, Marcel Apfelbaum wrote: Hi Yuval On Mon, Mar 21, 2022 at 2:11 PM Yuval Shaia wrote: Guest driver might execute HW commands when shared buffers are not yet allocated. This might happen on purpose (malicious guest) or because some other guest/host address mapping. We need to p

Re: [PATCH for-7.0] main-loop: Disable GLOBAL_STATE_CODE() assertions

2022-03-29 Thread Philippe Mathieu-Daudé
On 29/3/22 11:35, Hanna Reitz wrote: These assertions are very useful for developers to find bugs, and so they have indeed pointed us towards bugs already. For users, it is not so useful to find these bugs. We should probably not enable them in releases until we are sufficiently certain that th

Re: [PATCH] tests/lcitool: Do not use a hard-coded /usr/bin/python3 as python interpreter

2022-03-29 Thread Philippe Mathieu-Daudé
On 29/3/22 08:39, Thomas Huth wrote: When running "make lcitool-refresh", this currently uses the hard-coded /usr/bin/python3 from the script's shebang line for running Python. That's bad, since neither /usr/bin/python3 is guaranteed to exist, nor does it honor the python interpreter that the use

Re: [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation

2022-03-29 Thread Christian Schoenebeck
On Dienstag, 15. März 2022 11:10:25 CEST Christian Schoenebeck wrote: > Currently the implementation of 'Twalk' does not behave exactly as specified > by the 9p2000 protocol specification. Actual fix is patch 5; see the > description of that patch for details of what this overall fix and series > i

Re: [PATCH v7 08/17] vfio-user: instantiate vfio-user context

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:37PM -0400, Jagannathan Raman wrote: > create a context with the vfio-user library to run a PCI device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 82

Re: [PATCH v7 07/17] vfio-user: define vfio-user-server object

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:36PM -0400, Jagannathan Raman wrote: ## > diff --git a/include/hw/remote/machine.h b/include/hw/remote/machine.h > index 8d0fa98d33..2fcb9dada5 100644 > --- a/include/hw/remote/machine.h > +++ b/include/hw/remote/machine.h > @@ -26,6 +26,12 @@ struct RemoteMachineSta

Re: [PULL 0/4] Darwin patches for 2022-03-29

2022-03-29 Thread Philippe Mathieu-Daudé
ailable in the Git repository at: https://github.com/philmd/qemu.git tags/darwin-20220329 for you to fetch changes up to a4fd374364d4e23e0861273aaf7ff2ebddd57a17: ui/console: Check console before emitting GL event (2022-03-29 00:19

[PATCH for-7.1] tests: Drop perl-Test-Harness from the CI containers / VMs

2022-03-29 Thread Thomas Huth
The perl test harness is not necessary anymore since commit 3d2f73ef75 ("build: use "meson test" as the test harness"). Thus remove it from tests/lcitool/projects/qemu.yml, run "make lcitool-refresh" and manually clean the remaining docker / vm files that are not managed by lcitool yet. Signed-off

[PULL 0/3] MIPS patches for 2022-03-29

2022-03-29 Thread Philippe Mathieu-Daudé
d/qemu.git tags/mips-20220329 for you to fetch changes up to 77d119dd335f910c7f953a265726e3753c69a0bb: qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32 (2022-03-29 00:51:55 +0200) MIPS patches qu

Re: [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32

2022-03-29 Thread Philippe Mathieu-Daudé
On 29/3/22 04:05, WANG Xuerui wrote: On 3/29/22 07:39, Philippe Mathieu-Daudé wrote: On 28/3/22 22:49, Andreas K. Hüttel wrote: With the command line flag -mplt and a recent toolchain, ELF binaries generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc three-stage bootstrap in a mi

[PULL 3/3] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32

2022-03-29 Thread Philippe Mathieu-Daudé
From: Andreas K. Hüttel With the command line flag -mplt and a recent toolchain, ELF binaries generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot fail since the binfmt-misc magic does not match anymore. Also other

[PULL 1/3] memory: Make memory_region_readd_subregion() properly handle mapped aliases

2022-03-29 Thread Philippe Mathieu-Daudé
From: David Hildenbrand memory_region_readd_subregion() wants to readd a region by first removing it and then readding it. For readding, it doesn't use one of the memory_region_add_*() variants, which is why fail to re-increment the mr->mapped_via_alias counters, resulting in the assert(alias->ma

Re: [PATCH for-7.1] tests: Drop perl-Test-Harness from the CI containers / VMs

2022-03-29 Thread Philippe Mathieu-Daudé
On 29/3/22 12:28, Thomas Huth wrote: The perl test harness is not necessary anymore since commit 3d2f73ef75 ("build: use "meson test" as the test harness"). Thus remove it from tests/lcitool/projects/qemu.yml, run "make lcitool-refresh" and manually clean the remaining docker / vm files that are

[PULL 2/3] target/mips: Fix address space range declaration on n32

2022-03-29 Thread Philippe Mathieu-Daudé
From: WANG Xuerui This bug is probably lurking there for so long, I cannot even git-blame my way to the commit first introducing it. Anyway, because n32 is also TARGET_MIPS64, the address space range cannot be determined by looking at TARGET_MIPS64 alone. Fix this by only declaring 48-bit addres

Re: [PATCH for-7.0] tests/tcg: really fix path to target configuration

2022-03-29 Thread Philippe Mathieu-Daudé
On 29/3/22 12:45, Paolo Bonzini wrote: This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific Makefile variables path for user-mode", 2022-01-12) but it also used the wrong path; default.mak is used for config/devices, not config/targets. I remember having tested this, so mayb

Re: [PATCH for-7.0] main-loop: Disable GLOBAL_STATE_CODE() assertions

2022-03-29 Thread Hanna Reitz
On 29.03.22 12:17, Philippe Mathieu-Daudé wrote: On 29/3/22 11:35, Hanna Reitz wrote: These assertions are very useful for developers to find bugs, and so they have indeed pointed us towards bugs already.  For users, it is not so useful to find these bugs.  We should probably not enable them in

[PATCH for-7.0] tests/tcg: really fix path to target configuration

2022-03-29 Thread Paolo Bonzini
This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific Makefile variables path for user-mode", 2022-01-12) but it also used the wrong path; default.mak is used for config/devices, not config/targets. While at it, explain what the inclusion is about. Cc: Alex Bennée Cc: Philippe

Re: [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation

2022-03-29 Thread Greg Kurz
On Tue, 29 Mar 2022 12:21:13 +0200 Christian Schoenebeck wrote: > On Dienstag, 15. März 2022 11:10:25 CEST Christian Schoenebeck wrote: > > Currently the implementation of 'Twalk' does not behave exactly as specified > > by the 9p2000 protocol specification. Actual fix is patch 5; see the > > des

Re: [RFC PATCH 1/6] softfloat: add uint128_to_float* conversion methods

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: +p->frac_hi = shl_double(hi, lo, shift); +if (N > 64) { +p->frac_lo = shl_double(lo, 0, shift); +} shl_double(x, 0, n) -> x << n. You could also assign to frac_lo before frac_hi and drop the N > 64 test,

Re: [PATCH v3 2/3] util/main-loop: Introduce the main loop into QOM

2022-03-29 Thread Nicolas Saenz Julienne
Hi Markus, On Wed, 2022-03-16 at 15:28 +0100, Markus Armbruster wrote: > Nicolas Saenz Julienne writes: > > > 'event-loop-base' provides basic property handling for all 'AioContext' > > based event loops. So let's define a new 'MainLoopClass' that inherits > > from it. This will permit tweaking

Re: [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32

2022-03-29 Thread Laurent Vivier
Le 29/03/2022 à 01:39, Philippe Mathieu-Daudé a écrit : On 28/3/22 22:49, Andreas K. Hüttel wrote: With the command line flag -mplt and a recent toolchain, ELF binaries generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc three-stage bootstrap in a mips-unknown-linux-gnu qemu-user

Re: [RFC PATCH 2/6] softfloat: add int128_to_float* conversion methods

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Based on parts_sint_to_float, implements parts_sint_to_float2 that receives a 128-bit signed integer via int64_t and uint64_t arguments. Signed-off-by: Matheus Ferst --- fpu/softfloat-parts.c.inc | 37 +++

Re: [PATCH] chardev: avoid use-after-free when client disconnect

2022-03-29 Thread Marc-André Lureau
Hi On Mon, Mar 28, 2022 at 12:22 PM Hogan Wang via wrote: > IOWatchPoll object did not hold the @ioc and @src objects reference, > then io_watch_poll_prepare execute in IO thread, if IOWatchPoll > removed by mian thread, io_watch_poll_prepare may execute at last > chance and access the freed @io

Re: [PATCH v5 1/8] migration: Export ram_transferred_ram()

2022-03-29 Thread David Edmondson
On Thursday, 2022-03-10 at 16:34:47 +01, Juan Quintela wrote: > Subject: Re: [PATCH v5 1/8] migration: Export ram_transferred_ram() The function is "ram_transferred_add()". > Signed-off-by: Juan Quintela Reviewed-by: David Edmondson > --- > migration/ram.h | 2 ++ > migration/ram.c | 2 +- >

Re: [RFC PATCH 3/6] softfloat: add float*_to_uint128 conversion methods

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: +static uint64_t partsN(float_to_uint2)(FloatPartsN *p, FloatRoundMode rmode, + int scale, float_status *s, uint64_t *lo) +{ +int flags = 0; +uint64_t hi; I think most of this would read cleane

Re: [PATCH 1/2] scripts/qemu-gdb/mtree.py: Int128 are decimal rather than hex

2022-03-29 Thread David Edmondson
Ping? On Monday, 2022-02-21 at 16:49:47 GMT, David Edmondson wrote: > When parsing QEMU's native Int128 type, do not attempt to convert from > hexadecimal. > > Fixes: 8037fa55ac ("scripts/qemugdb/mtree.py: fix up mtree dump") > Signed-off-by: David Edmondson > --- > scripts/qemugdb/mtree.py | 2

Re: [PULL 0/4] Darwin patches for 2022-03-29

2022-03-29 Thread Hanna Reitz
qemu into staging (2022-03-28 10:16:33 +0100) are available in the Git repository at:    https://github.com/philmd/qemu.git tags/darwin-20220329 for you to fetch changes up to a4fd374364d4e23e0861273aaf7ff2ebddd57a17:    ui/console: Check console before emitting GL event (2022-03-29 00:1

Re: [RFC PATCH 4/6] softfloat: add float*_to_int128 conversion methods

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: +static int64_t partsN(float_to_sint2)(FloatPartsN *p, FloatRoundMode rmode, + int scale, float_status *s, uint64_t *lo) +{ +int flags = 0; +uint64_t hi; Similar comment about 'lo' vs '*lo'. +

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-29 Thread Hanna Reitz
On 29.03.22 11:55, Vladimir Sementsov-Ogievskiy wrote: 29.03.2022 11:54, Hanna Reitz wrote: On 28.03.22 12:24, Vladimir Sementsov-Ogievskiy wrote: 28.03.2022 11:09, Hanna Reitz wrote: On 28.03.22 09:44, Hanna Reitz wrote: On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote: 24.03.2022 17:0

Re: [RFC PATCH 5/6] target/ppc: implement xscv[su]qqp

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implement the following PowerISA v3.1 instructions: xscvsqqp: VSX Scalar Convert with round Signed Quadword to Quad-Precision xscvuqqp: VSX Scalar Convert with round Unsigned Quadword to Quad-Precis

Re: [RFC PATCH 6/6] target/ppc: implement xscvqp[su]qz

2022-03-29 Thread Richard Henderson
On 3/28/22 14:14, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implement the following PowerISA v3.1 instructions: xscvqpsqz: VSX Scalar Convert with round to zero Quad-Precision to Signed Quadword xscvqpuqz: VSX Scalar Convert with round to zero Quad-Precision to

Re: [PATCH for-7.0] main-loop: Disable GLOBAL_STATE_CODE() assertions

2022-03-29 Thread Emanuele Giuseppe Esposito
Am 29/03/2022 um 11:35 schrieb Hanna Reitz: > These assertions are very useful for developers to find bugs, and so > they have indeed pointed us towards bugs already. For users, it is not > so useful to find these bugs. We should probably not enable them in > releases until we are sufficiently

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: > Assign separate address space for each device in the remote processes. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/remote/iommu.h | 18 > h

[PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Laurent Vivier
If the migration is over before we cancel it, we are waiting in a loop a state that never comes because the state is already "completed". To avoid an infinite loop, skip the test if the migration is "completed" before we were able to cancel it. Signed-off-by: Laurent Vivier --- tests/qtest/virt

Re: [PATCH 1/4] s390x: follow qdev tree to detect SCSI device on a CCW bus

2022-03-29 Thread Thomas Huth
On 28/03/2022 16.30, Paolo Bonzini wrote: Do not make assumptions on the parent type of the SCSIDevice, instead use object_dynamic_cast all the way up to the CcwDevice. This is cleaner because there is no guarantee that the bus is on a virtio-scsi device; that is only the case for the default co

[PATCH v2 0/1] fix vcpu hotunplug leak in spapr_realize_vcpu

2022-03-29 Thread Daniel Henrique Barboza
Hi, This second version squashes the two patches of v1 together, as requested by David. v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06552.html Daniel Henrique Barboza (1): hw/ppc: free env->tb_env in spapr_unrealize_vcpu() hw/ppc/ppc.c| 7 +++ hw/ppc/sp

[PATCH v2 1/1] hw/ppc: free env->tb_env in spapr_unrealize_vcpu()

2022-03-29 Thread Daniel Henrique Barboza
The timebase is allocated during spapr_realize_vcpu() and it's not freed. This results in memory leaks when doing vcpu unplugs: ==636935== ==636935== 144 (96 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 6 ,461 of 8,135 ==636935==at 0x4897468: calloc (vg_replace_ma

Re: [PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Thomas Huth
On 29/03/2022 14.42, Laurent Vivier wrote: If the migration is over before we cancel it, we are waiting in a loop a state that never comes because the state is already "completed". To avoid an infinite loop, skip the test if the migration is "completed" before we were able to cancel it. Signed-

Re: [PATCH v7 14/17] vfio-user: handle PCI BAR accesses

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:43PM -0400, Jagannathan Raman wrote: > @@ -324,6 +325,170 @@ static void dma_unregister(vfu_ctx_t *vfu_ctx, > vfu_dma_info_t *info) > trace_vfu_dma_unregister((uint64_t)info->iova.iov_base); > } > > +static size_t vfu_object_bar_rw(PCIDevice *pci_dev, int pci_

Re: [PATCH v4 1/1] fix cmpxchg and lock cmpxchg instruction

2022-03-29 Thread 李玮
On Wed, Mar 23, 2022 at 9:37 AM Wei Li wrote: > This patch fixes a bug reported on issues #508. > The problem is cmpxchg and lock cmpxchg would touch accumulator when > the comparison is equal. > > Signed-off-by: Wei Li > --- > target/i386/tcg/translate.c | 41 +-

Re: [PATCH 3/4] python/qmp-shell: relicense as LGPLv2+

2022-03-29 Thread Fam Zheng
On 2022-03-25 16:04, John Snow wrote: > qmp-shell is presently licensed as GPLv2 (only). I intend to include > this tool as an add-on to an LGPLv2+ library package hosted on > PyPI.org. I've selected LGPLv2+ to maximize compatibility with other > licenses while retaining a copyleft license. > > To

Re: [PATCH V6 21/27] vfio-pci: cpr part 3 (intx)

2022-03-29 Thread Fam Zheng
On 2021-08-06 14:43, Steve Sistare wrote: > Preserve vfio INTX state across cpr restart. Preserve VFIOINTx fields as > follows: > pin : Recover this from the vfio config in kernel space > interrupt : Preserve its eventfd descriptor across exec. > unmask : Ditto > route.irq : This could per

Re: [PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 13:47, Thomas Huth wrote: > > On 29/03/2022 14.42, Laurent Vivier wrote: > > If the migration is over before we cancel it, we are > > waiting in a loop a state that never comes because the state > > is already "completed". > > > > To avoid an infinite loop, skip the test if

Re: [PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Thomas Huth
On 29/03/2022 15.23, Peter Maydell wrote: On Tue, 29 Mar 2022 at 13:47, Thomas Huth wrote: On 29/03/2022 14.42, Laurent Vivier wrote: If the migration is over before we cancel it, we are waiting in a loop a state that never comes because the state is already "completed". To avoid an infinite

Re: [PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 14:25, Thomas Huth wrote: > > On 29/03/2022 15.23, Peter Maydell wrote: > > On Tue, 29 Mar 2022 at 13:47, Thomas Huth wrote: > >> > >> On 29/03/2022 14.42, Laurent Vivier wrote: > >>> If the migration is over before we cancel it, we are > >>> waiting in a loop a state that

Re: [PATCH] tests/qtest: failover: fix infinite loop

2022-03-29 Thread Thomas Huth
On 29/03/2022 15.27, Peter Maydell wrote: On Tue, 29 Mar 2022 at 14:25, Thomas Huth wrote: On 29/03/2022 15.23, Peter Maydell wrote: On Tue, 29 Mar 2022 at 13:47, Thomas Huth wrote: On 29/03/2022 14.42, Laurent Vivier wrote: If the migration is over before we cancel it, we are waiting in

Re: [PATCH 2/4] virtio-ccw: move vhost_ccw_scsi to a separate file

2022-03-29 Thread Thomas Huth
On 28/03/2022 16.30, Paolo Bonzini wrote: Remove unecessary use of #ifdef CONFIG_VHOST_SCSI, instead just use a separate file and a separate rule in meson.build. Signed-off-by: Paolo Bonzini --- hw/s390x/meson.build | 1 + hw/s390x/vhost-scsi-ccw.c | 64 ++

[PATCH v3 0/2] Added option to take screenshot with screendump as PNG

2022-03-29 Thread Kshitij Suri
This patch series aims to add PNG support using libpng to screendump method. Currently screendump only supports PPM format, which is uncompressed and not standardised. PATCH 1 phases out CONFIG_VNC_PNG parameter and replaces it with CONFIG_PNG which detects libpng support. PATCH 2 contains core l

[PATCH v3 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-29 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

[PATCH v3 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-29 Thread Kshitij Suri
Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri Reviewed-by: Daniel P. Berrangé --- meson.build| 9 - meson_options.txt

[PULL 0/2] Build bugfixes for QEMU 7.0, 2022-03-29

2022-03-29 Thread Paolo Bonzini
The following changes since commit f345abe36527a8b575482bb5a0616f43952bf1f4: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-03-25 10:14:47 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch c

[PULL 1/2] virtio: fix --enable-vhost-user build on non-Linux

2022-03-29 Thread Paolo Bonzini
The vhost-shadow-virtqueue.c build requires include files from linux-headers/, so it cannot be built on non-Linux systems. Fortunately it is only needed by vhost-vdpa, so move it there. Acked-by: Eugenio Pérez Acked-by: Jason Wang Signed-off-by: Paolo Bonzini --- hw/virtio/meson.build | 4 ++--

[PULL 2/2] tests/tcg: really fix path to target configuration

2022-03-29 Thread Paolo Bonzini
This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific Makefile variables path for user-mode", 2022-01-12) but it also used the wrong path; default.mak is used for config/devices, not config/targets. While at it, explain what the inclusion is about. Cc: Alex Bennée Reviewed-by:

Re: [PATCH v7 07/17] vfio-user: define vfio-user-server object

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 6:21 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:36PM -0400, Jagannathan Raman wrote: > ## >> diff --git a/include/hw/remote/machine.h b/include/hw/remote/machine.h >> index 8d0fa98d33..2fcb9dada5 100644 >> --- a/include/hw/remote/machine.h >> +++ b/inclu

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: >> Assign separate address space for each device in the remote processes. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagan

Re: Plugins Not Reporting AArch64 SVE Memory Operations

2022-03-29 Thread Aaron Lindsay via
On Mar 28 16:30, Alex Bennée wrote: > > Aaron Lindsay writes: > > > Hi folks, > > > > I see there has been some previous discussion [1] about 1.5 years ago > > around the fact that AArch64 SVE instructions do not emit any memory > > operations via the plugin interface, as one might expect them t

Re: [PULL 0/3] MIPS patches for 2022-03-29

2022-03-29 Thread Peter Maydell
ging (2022-03-28 10:16:33 +0100) > > are available in the Git repository at: > > https://github.com/philmd/qemu.git tags/mips-20220329 > > for you to fetch changes up to 77d119dd335f910c7f953a265726e3753c69a0bb: > > qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION

Re: [PATCH v6 15/19] vfio-user: handle device interrupts

2022-03-29 Thread Stefan Hajnoczi
On Sat, Mar 26, 2022 at 11:47:36PM +, Jag Raman wrote: > > > > On Mar 7, 2022, at 5:24 AM, Stefan Hajnoczi wrote: > > > > On Thu, Feb 17, 2022 at 02:49:02AM -0500, Jagannathan Raman wrote: > >> Forward remote device's interrupts to the guest > >> > >> Signed-off-by: Elena Ufimtseva > >> S

Re: [PATCH 5/5] s390x/tcg: fix format-truncation warning

2022-03-29 Thread Thomas Huth
On 28/03/2022 12.22, Marc-André Lureau wrote: Hi On Mon, Mar 28, 2022 at 12:59 PM Thomas Huth wrote: On 28/03/2022 10.47, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../target/s390x/tcg/translate.c: In function ‘s390x_translate_init’: ../target/s390x/tcg/translate.c:224:64:

Re: [PATCH v7 16/17] vfio-user: handle reset of remote device

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:45PM -0400, Jagannathan Raman wrote: > Adds handler to reset a remote device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 20 > 1 file changed, 20 ins

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Stefan Hajnoczi
On Tue, Mar 29, 2022 at 02:12:40PM +, Jag Raman wrote: > > On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: > >> +void remote_iommu_del_device(PCIDevice *pci_dev) > >> +{ > >> +int pci_bdf; > >> + > >> +if (!remo

[PULL 0/4] Block patches for 7.0-rc2

2022-03-29 Thread Hanna Reitz
The following changes since commit 44064550d98a680e2ff55fdd783ac19d850ac8ca: Merge tag 'darwin-20220329' of https://github.com/philmd/qemu into staging (2022-03-29 15:17:53 +0100) are available in the Git repository at: https://gitlab.com/hreitz/qemu.git tags/pull-block-2022-03-2

[PULL 4/4] iotests: Fix status checks

2022-03-29 Thread Hanna Reitz
An iotest's 'paused' condition is fickle; it will be reported as true whenever the job is drained, for example, or when it is in the process of completing. 030 and 041 contain such checks, we should replace them by checking the job status instead. (As was done for 129 in commit f9a6256b48f29c2816

[PULL 2/4] main-loop: Disable GLOBAL_STATE_CODE() assertions

2022-03-29 Thread Hanna Reitz
These assertions are very useful for developers to find bugs, and so they have indeed pointed us towards bugs already. For users, it is not so useful to find these bugs. We should probably not enable them in releases until we are sufficiently certain that they will not fire during normal operatio

Re: [PATCH 1/3] target/arm: Check VSTCR.SW when assigning the stage 2 output PA space

2022-03-29 Thread Richard Henderson
On 3/27/22 08:24, Rémi Denis-Courmont wrote: Le sunnuntaina 27. maaliskuuta 2022, 12.34.26 EEST Idan Horowitz a écrit : As per the AArch64.SS2OutputPASpace() psuedo-code in the ARMv8 ARM when the PA space of the IPA is non secure, the output PA space is secure if and only if all of the bits VTCR

[PULL 3/4] block/stream: Drain subtree around graph change

2022-03-29 Thread Hanna Reitz
When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd() however will drain, and so the actual bas

Re: [PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-03-29 Thread Paolo Bonzini
Queued, thanks. Paolo

  1   2   3   >