Re: [PATCH v1 3/3] virtio-mem: Set "unplugged-inaccessible=auto" for the 6.2 machine on x86

2021-12-08 Thread Pankaj Gupta
> Set the new default to "auto", keeping it set to "on" for compat > machines. This property is only available for x86 targets. > > TODO: once 6.2 was released and we have compat machines, target the next > QEMU release. > > Signed-off-by: David Hildenbrand > --- > hw/i386/pc.c |

Re: [PATCH v7 1/7] net/vmnet: add vmnet dependency and customizable option

2021-12-08 Thread Markus Armbruster
Vladislav Yaroshchuk writes: > If you meant patch series cover letter, it exists, see > https://patchew.org/QEMU/20211207101828.22033-1-yaroshchuk2...@gmail.com/ Never arrived here. Since the list archive has it, the problem must be on my end. Thanks!

Re: [PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-08 Thread Thomas Huth
On 07/12/2021 18.23, Laurent Vivier wrote: Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature.

Re: [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/7/21 21:40, John Snow wrote: > Clang doesn't recognize that the variable is being "used" and will emit > a warning: > > ../ui/clipboard.c:47:34: error: variable 'old' set but not used > [-Werror,-Wunused-but-set-variable] > g_autoptr(QemuClipboardInfo) old = NULL; >

Re: [PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-08 Thread Laurent Vivier
On 08/12/2021 09:39, Thomas Huth wrote: On 07/12/2021 18.23, Laurent Vivier wrote: Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the

Re: [PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-08 Thread Thomas Huth
On 08/12/2021 09.52, Laurent Vivier wrote: On 08/12/2021 09:39, Thomas Huth wrote: On 07/12/2021 18.23, Laurent Vivier wrote: Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the

Re: [PATCH] s390x/ipl: support extended kernel command line size

2021-12-08 Thread Thomas Huth
On 22/11/2021 12.29, Marc Hartmayer wrote: In the past s390 used a fixed command line length of 896 bytes. This has changed with the Linux commit 5ecb2da660ab ("s390: support command lines longer than 896 bytes"). There is now a parm area indicating the maximum command line size. This parm area h

Re: [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable

2021-12-08 Thread Daniel P . Berrangé
On Tue, Dec 07, 2021 at 03:40:38PM -0500, John Snow wrote: > Clang doesn't recognize that the variable is being "used" and will emit > a warning: > > ../ui/clipboard.c:47:34: error: variable 'old' set but not used > [-Werror,-Wunused-but-set-variable] > g_autoptr(QemuClipboardInfo) old =

Re: [PATCH v2 1/2] spice: Update QXLInterface for spice >= 0.15.0

2021-12-08 Thread Daniel P . Berrangé
On Tue, Dec 07, 2021 at 03:40:37PM -0500, John Snow wrote: > spice updated the spelling (and arguments) of "attache_worker" in > 0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations > compilations from reporting build errors. > > See also: > https://gitlab.freedesktop.org/spice/spice

Re:[PATCH] mirror: Avoid assertion failed in mirror_run

2021-12-08 Thread wang.yi59
>[CC-ing qemu-block, Vladimir, Kevin, and John – when sending patches, >please look into the MAINTAINERS file or use the >scripts/get_maintainer.pl script to find out who to CC on them. It’s >very to overlook patches on qemu-devel :/] > >On 07.12.21 11:56, Yi Wang wrote: >> From: Long YunJia

Re: [qemu-web PATCH v4] Add Sponsors page

2021-12-08 Thread Thomas Huth
On 24/11/2021 11.30, Philippe Mathieu-Daudé wrote: Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/2

Re: [PATCH 06/12] target/s390x: add zpci-interp to cpu models

2021-12-08 Thread Christian Borntraeger
Am 07.12.21 um 22:04 schrieb Matthew Rosato: The zpci-interp feature is used to specify whether zPCI interpretation is to be used for this guest. Signed-off-by: Matthew Rosato --- target/s390x/cpu_features_def.h.inc | 1 + target/s390x/gen-features.c | 2 ++ target/s390x/kvm/kvm.c

Re: [PATCH 01/12] s390x/pci: use a reserved ID for the default PCI group

2021-12-08 Thread Thomas Huth
On 07/12/2021 22.04, Matthew Rosato wrote: The current default PCI group being used can technically collide with a real group ID passed from a hostdev. Let's instead use a group ID that comes from a special pool (0xF0-0xFF) that is architected to be reserved for simulated devices. Maybe mentio

Re: [PATCH 02/12] s390x/pci: don't use hard-coded dma range in reg_ioat

2021-12-08 Thread Thomas Huth
On 07/12/2021 22.04, Matthew Rosato wrote: Instead use the values from clp info, they will either be the hard-coded values or what came from the host driver via vfio. Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Signed-off-b

Re: [PATCH v5 3/4] failover: fix unplug pending detection

2021-12-08 Thread Ani Sinha
On Wed, Dec 8, 2021 at 1:20 PM Thomas Huth wrote: > > On 08/12/2021 08.36, Michael S. Tsirkin wrote: > > On Fri, Nov 19, 2021 at 10:07:17AM +0100, Laurent Vivier wrote: > >> Failover needs to detect the end of the PCI unplug to start migration > >> after the VFIO card has been unplugged. > >> > >>

Re: [PATCH 07/12] s390x/pci: enable for load/store intepretation

2021-12-08 Thread Thomas Huth
On 07/12/2021 22.04, Matthew Rosato wrote: Use the associated vfio feature ioctl to enable interpretation for devices when requested. As part of this process, we must use the host function handle rather than a QEMU-generated one -- this is provided as part of the ioctl payload. Signed-off-by: M

Re: [PATCH 08/12] s390x/pci: don't fence interpreted devices without MSI-X

2021-12-08 Thread Thomas Huth
On 07/12/2021 22.04, Matthew Rosato wrote: Lack of MSI-X support is not an issue for interpreted passthrough devices, so let's let these in. This will allow, for example, ISM devices to be passed through -- but only when interpretation is available and being used. Signed-off-by: Matthew Rosato

Re: [PATCH v5 3/4] failover: fix unplug pending detection

2021-12-08 Thread Michael S. Tsirkin
On Wed, Dec 08, 2021 at 08:50:34AM +0100, Thomas Huth wrote: > On 08/12/2021 08.36, Michael S. Tsirkin wrote: > > On Fri, Nov 19, 2021 at 10:07:17AM +0100, Laurent Vivier wrote: > > > Failover needs to detect the end of the PCI unplug to start migration > > > after the VFIO card has been unplugged.

Re: [PATCH 09/12] s390x/pci: enable adapter event notification for interpreted devices

2021-12-08 Thread Thomas Huth
On 07/12/2021 22.04, Matthew Rosato wrote: Use the associated vfio feature ioctl to enable adapter event notification and forwarding for devices when requested. This feature will be set up with or without firmware assist based upon the 'intassist' setting. Signed-off-by: Matthew Rosato --- h

Re: [PATCH 7/7] hw/riscv: Use error_fatal for SoC realisation

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/8/21 07:42, Alistair Francis wrote: > From: Alistair Francis > > When realising the SoC use error_fatal instead of error_abort as the > process can fail and report useful information to the user. > > Currently a user can see this: > >$ ../qemu/bld/qemu-system-riscv64 -M sifive_u -S -m

Re: [PATCH 1/7] hw/intc: sifive_plic: Add a reset function

2021-12-08 Thread Philippe Mathieu-Daudé
Hi Alistair, On 12/8/21 07:42, Alistair Francis wrote: > From: Alistair Francis > > Signed-off-by: Alistair Francis > --- > hw/intc/sifive_plic.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c > index 877e76877c..35f097799a

Re: [PATCH] tests/docker: add libfuse3 development headers

2021-12-08 Thread Beraldo Leal
On Tue, Dec 07, 2021 at 04:00:25PM +, Stefan Hajnoczi wrote: > The FUSE exports feature is not built because most container images do > not have libfuse3 development headers installed. Add the necessary > packages to the Dockerfiles. > > Cc: Hanna Reitz > Cc: Richard W.M. Jones > Signed-off-

[PATCH 0/3] target/ppc: Minor fixes to exception code

2021-12-08 Thread Fabiano Rosas
These are just some minor fixes to the exception code that I collected over the past few months. Fabiano Rosas (3): target/ppc: Fix MPCxxx FPU interrupt address target/ppc: Remove 603e exception model target/ppc: Set 601v exception model id target/ppc/cpu-qom.h | 2 -- target/ppc/cpu_

[PATCH 2/3] target/ppc: Remove 603e exception model

2021-12-08 Thread Fabiano Rosas
The 603e uses the same exception code as 603 so we don't need a dedicated entry for it. This is only a removal of redundant code, no functional change. Signed-off-by: Fabiano Rosas --- target/ppc/cpu-qom.h | 2 -- target/ppc/cpu_init.c| 32 ++-- target/ppc/e

[PATCH 1/3] target/ppc: Fix MPCxxx FPU interrupt address

2021-12-08 Thread Fabiano Rosas
The Floating-point Unavailable and Decrementer interrupts are being registered at the same 0x900 address. The FPU should be at 0x800 instead. Verified on MPC555, MPC860 and MPC885 user manuals. Reported-by: BALATON Zoltan Signed-off-by: Fabiano Rosas --- target/ppc/cpu_init.c | 4 ++-- 1 file

[PATCH 3/3] target/ppc: Set 601v exception model id

2021-12-08 Thread Fabiano Rosas
The exception model id for 601v has been removed without mention why. I assume it was inadvertent and restore it here. Fixes: b632a148b6 ("target-ppc: Use QOM method dispatch for MMU fault handling") Signed-off-by: Fabiano Rosas --- target/ppc/cpu_init.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH v8 1/4] qtest/libqos: add a function to initialize secondary PCI buses

2021-12-08 Thread Laurent Vivier
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and PCI_SUBORDINATE_BUS (algorithm from seabios) Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- include/hw/pci/pci_bridge.h | 8 +++ tests/qtest/libqos/pci.c| 119 tests/qtest/libqo

[PATCH v8 4/4] tests/libqtest: add a migration test with two couples of failover devices

2021-12-08 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 282 ++ 1 file changed, 282 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c index e998a546b031..4b2ba8a106b1 100644 --- a/tes

[PATCH v8 3/4] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-08 Thread Laurent Vivier
Add some tests to check the state of the machine if the migration is cancelled while we are using virtio-net failover. Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 282 ++ 1 file changed, 282 insertions(+) diff --git a/

[PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover

2021-12-08 Thread Laurent Vivier
This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine b

[PATCH v8 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-08 Thread Laurent Vivier
Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature. Signed-off-by: Laurent Vivier --- tests/qte

Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address

2021-12-08 Thread Thomas Huth
On 03/12/2021 13.25, Cédric Le Goater wrote: On 12/3/21 11:40, Peter Maydell wrote: On Fri, 3 Dec 2021 at 10:32, Thomas Huth wrote: I guess it's an accidential NULL pointer dereference somewhere in the u-boot code ... which will be quite hard to track down when the first page of memory is mark

Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address

2021-12-08 Thread Cédric Le Goater
On 12/8/21 14:07, Thomas Huth wrote: On 03/12/2021 13.25, Cédric Le Goater wrote: On 12/3/21 11:40, Peter Maydell wrote: On Fri, 3 Dec 2021 at 10:32, Thomas Huth wrote: I guess it's an accidential NULL pointer dereference somewhere in the u-boot code ... which will be quite hard to track down

Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address

2021-12-08 Thread Thomas Huth
On 08/12/2021 14.15, Cédric Le Goater wrote: On 12/8/21 14:07, Thomas Huth wrote: On 03/12/2021 13.25, Cédric Le Goater wrote: On 12/3/21 11:40, Peter Maydell wrote: On Fri, 3 Dec 2021 at 10:32, Thomas Huth wrote: I guess it's an accidential NULL pointer dereference somewhere in the u-boot

Re: [PATCH v6 4/4] tests: qtest: Add virtio-iommu test

2021-12-08 Thread Thomas Huth
On 27/11/2021 08.29, Eric Auger wrote: Add the framework to test the virtio-iommu-pci device and tests exercising the attach/detach, map/unmap API. Signed-off-by: Eric Auger Tested-by: Jean-Philippe Brucker Reviewed-by: Jean-Philippe Brucker --- v5 -> v6: - changed the expected value for do

Re: [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/8/21 10:11, Daniel P. Berrangé wrote: > On Tue, Dec 07, 2021 at 03:40:38PM -0500, John Snow wrote: >> Clang doesn't recognize that the variable is being "used" and will emit >> a warning: >> >> ../ui/clipboard.c:47:34: error: variable 'old' set but not used >> [-Werror,-Wunused-but-set-var

Re: [RFC PATCH v2] blog post: how to get your new feature up-streamed

2021-12-08 Thread Thomas Huth
On 06/12/2021 15.14, Alex Bennée wrote: Experience has shown that getting new functionality up-streamed can be a somewhat painful process. Lets see if we can collect some of our s/Lets/Let's/ community knowledge into a blog post describing some best practices for getting code accepted. Signe

[ANNOUNCE] QEMU 6.2.0-rc4 is now available

2021-12-08 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 6.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-6.2.0-rc4.tar.xz http://downlo

[PATCH] block/nvme: fix infinite loop in nvme_free_req_queue_cb()

2021-12-08 Thread Stefan Hajnoczi
When the request free list is exhausted the coroutine waits on q->free_req_queue for the next free request. Whenever a request is completed a BH is scheduled to invoke nvme_free_req_queue_cb() and wake up waiting coroutines. 1. nvme_get_free_req() waits for a free request: while (q->free_req_

Re: [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable

2021-12-08 Thread John Snow
On Wed, Dec 8, 2021, 4:11 AM Daniel P. Berrangé wrote: > On Tue, Dec 07, 2021 at 03:40:38PM -0500, John Snow wrote: > > Clang doesn't recognize that the variable is being "used" and will emit > > a warning: > > > > ../ui/clipboard.c:47:34: error: variable 'old' set but not used > [-Werror,-Wunu

Re: [PATCH v9 2/3] cpu-throttle: implement vCPU throttle

2021-12-08 Thread Hyman
在 2021/12/6 18:10, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:46AM +0800, huang...@chinatelecom.cn wrote: +static uint64_t dirtylimit_pct(unsigned int last_pct, + uint64_t quota, + uint64_t current) +{ +uint64_t limit_pct = 0; +

[PATCH v3] docs: Introducing pseries documentation.

2021-12-08 Thread lagarcia
From: Leonardo Garcia The purpose of this document is to substitute the content currently available in the QEMU wiki at [0]. This initial version does contain some additional content as well. Whenever this documentation gets upstream and is reflected in [1], the QEMU wiki will be edited to point

Re: [PATCH v9 2/3] cpu-throttle: implement vCPU throttle

2021-12-08 Thread Hyman
在 2021/12/8 23:36, Hyman 写道: 在 2021/12/6 18:10, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:46AM +0800, huang...@chinatelecom.cn wrote: +static uint64_t dirtylimit_pct(unsigned int last_pct, +   uint64_t quota, +   uint64_t current) +{

Re: [PATCH v3] docs: Introducing pseries documentation.

2021-12-08 Thread Leonardo Augusto Guimarães Garcia
Argh! Disregard this patch. It fails to build. I'll send v4 fixing this. On 12/8/21 12:47, lagar...@linux.ibm.com wrote: > From: Leonardo Garcia > > The purpose of this document is to substitute the content currently > available in the QEMU wiki at [0]. This initial version does contain > some ad

Re: [PATCH 1/7] migration: Drop dead code of ram_debug_dump_bitmap()

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > I planned to add "#ifdef DEBUG_POSTCOPY" around the function too because > otherwise it'll be compiled into qemu binary even if it'll never be used. > Then > I found that maybe it's easier to just drop it for good.. > > Signed-off-by: Peter Xu Yeh, it wa

Re: [PATCH] block/nvme: fix infinite loop in nvme_free_req_queue_cb()

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/8/21 16:22, Stefan Hajnoczi wrote: > When the request free list is exhausted the coroutine waits on > q->free_req_queue for the next free request. Whenever a request is > completed a BH is scheduled to invoke nvme_free_req_queue_cb() and wake > up waiting coroutines. > > 1. nvme_get_free_req

Re: [PATCH 2/7] migration: Don't return for postcopy_chunk_hostpages()

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It always return zero, because it just can't go wrong so far. Simplify the > code with no functional change. > > Signed-off-by: Peter Xu OK, I was wondering if the discard_send_finish could fail, but I chased it another 3 or 4 levels and nothing returns a

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Eric DeVolder
On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. OK sent some more comments. It will take another pass for

[PATCH v4] docs: Introducing pseries documentation.

2021-12-08 Thread lagarcia
From: Leonardo Garcia The purpose of this document is to substitute the content currently available in the QEMU wiki at [0]. This initial version does contain some additional content as well. Whenever this documentation gets upstream and is reflected in [1], the QEMU wiki will be edited to point

Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address

2021-12-08 Thread Cédric Le Goater
On 12/8/21 14:19, Thomas Huth wrote: On 08/12/2021 14.15, Cédric Le Goater wrote: On 12/8/21 14:07, Thomas Huth wrote: On 03/12/2021 13.25, Cédric Le Goater wrote: On 12/3/21 11:40, Peter Maydell wrote: On Fri, 3 Dec 2021 at 10:32, Thomas Huth wrote: I guess it's an accidential NULL pointer

Re: [PATCH 3/7] migration: Drop postcopy_chunk_hostpages()

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This function calls three functions: > > - postcopy_discard_send_init(ms, block->idstr); > - postcopy_chunk_hostpages_pass(ms, block); > - postcopy_discard_send_finish(ms); > > However only the 2nd function call is meaningful. It's major role is to m

[PATCH 2/3] docs: Rename ppc-spapr-hcalls.txt to ppc-spapr-hcalls.rst.

2021-12-08 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/specs/{ppc-spapr-hcalls.txt => ppc-spapr-hcalls.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/specs/{ppc-spapr-hcalls.txt => ppc-spapr-hcalls.rst} (100%) diff --git a/docs/specs/ppc-spapr-hcalls.txt b/docs/s

[PATCH 3/3] Link new ppc-spapr-hcalls.rst file to pseries.rst.

2021-12-08 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/system/ppc/pseries.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst index e46f09d4c8..56f5942e13 100644 --- a/docs/system/ppc/pseries.rst +++ b/docs/sys

[PATCH 1/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/specs/ppc-spapr-hcalls.txt | 92 - 1 file changed, 57 insertions(+), 35 deletions(-) diff --git a/docs/specs/ppc-spapr-hcalls.txt b/docs/specs/ppc-spapr-hcalls.txt index 93fe3da91b..c69dae535b 100644

[PATCH 0/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread lagarcia
From: Leonardo Garcia Along with this change, hook the new rst file into the pseries documentation. Leonardo Garcia (3): docs: rSTify ppc-spapr-hcalls.txt docs: Rename ppc-spapr-hcalls.txt to ppc-spapr-hcalls.rst. Link new ppc-spapr-hcalls.rst file to pseries.rst. docs/specs/ppc-spapr-hc

[PATCH for-7.0] hw: Add compat machines for 7.0

2021-12-08 Thread Cornelia Huck
Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13

Re: dozens of qemu/kvm VMs getting into stuck states since kernel ~5.13

2021-12-08 Thread Chris Murphy
On Tue, Dec 7, 2021 at 5:25 PM Sean Christopherson wrote: > > On Tue, Dec 07, 2021, Chris Murphy wrote: > > cc: qemu-devel > > > > Hi, > > > > I'm trying to help progress a very troublesome and so far elusive bug > > we're seeing in Fedora infrastructure. When running dozens of qemu-kvm > > VMs si

Re: [PATCH 2/7] hw/intc: sifive_plic: Cleanup the write function

2021-12-08 Thread Richard Henderson
On 12/7/21 10:42 PM, Alistair Francis wrote: From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- hw/intc/sifive_plic.c | 82 +-- 1 file changed, 33 insertions(+), 49 deletions(-) diff --git a/hw/intc/sifive_plic.c b/hw/i

Re: [PATCH for-7.0] hw: Add compat machines for 7.0

2021-12-08 Thread Cédric Le Goater
On 12/8/21 18:02, Cornelia Huck wrote: Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck Acked-by: Cédric Le Goater Thanks, C. --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw

Re: [PATCH 0/3] target/ppc: Minor fixes to exception code

2021-12-08 Thread Richard Henderson
On 12/8/21 4:30 AM, Fabiano Rosas wrote: These are just some minor fixes to the exception code that I collected over the past few months. Fabiano Rosas (3): target/ppc: Fix MPCxxx FPU interrupt address target/ppc: Remove 603e exception model target/ppc: Set 601v exception model id ta

Re: [PATCH 4/7] migration: Do chunk page in postcopy_each_ram_send_discard()

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Right now we loop ramblocks for twice, the 1st time chunk the dirty bits with > huge page information; the 2nd time we send the discard ranges. That's not > necessary - we can do them in a single loop. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Al

Re: [PATCH 06/12] target/s390x: add zpci-interp to cpu models

2021-12-08 Thread Matthew Rosato
On 12/8/21 5:16 AM, Christian Borntraeger wrote: Am 07.12.21 um 22:04 schrieb Matthew Rosato: The zpci-interp feature is used to specify whether zPCI interpretation is to be used for this guest. Signed-off-by: Matthew Rosato ---   target/s390x/cpu_features_def.h.inc | 1 +   target/s390x/gen-fe

Re: [PATCH 5/7] migration: Drop return code for disgard ram process

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It will just never fail. Drop those return values where they're constantly > zeros. > > A tiny touch-up on the tracepoint so trace_ram_postcopy_send_discard_bitmap() > is called after the logic itself (which sounds more reasonable). > > Signed-off-by: Pete

Re: [PATCH 6/7] migration: Dump sub-cmd name in loadvm_process_command tp

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It'll be easier to read the name rather than index of sub-cmd when debugging. > > Signed-off-by: Peter Xu > --- > migration/savevm.c | 2 +- > migration/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration

Re: [PATCH 1/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread Daniel Henrique Barboza
On 12/8/21 13:59, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/specs/ppc-spapr-hcalls.txt | 92 - 1 file changed, 57 insertions(+), 35 deletions(-) diff --git a/docs/specs/ppc-spapr-hcalls.txt b/docs/specs/pp

Re: [RFC PATCH v2 0/5] virtio: early detect 'modern' virtio

2021-12-08 Thread Michael S. Tsirkin
On Fri, Nov 12, 2021 at 03:57:44PM +0100, Halil Pasic wrote: > This is an early RFC for a transport specific early detecton of > modern virtio, which is most relevant for transitional devices on big > endian platforms, when drivers access the config space before > FEATURES_OK is set. > > The most

Re: [PATCH 2/3] docs: Rename ppc-spapr-hcalls.txt to ppc-spapr-hcalls.rst.

2021-12-08 Thread Daniel Henrique Barboza
On 12/8/21 13:59, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- Reviewed-by: Daniel Henrique Barboza docs/specs/{ppc-spapr-hcalls.txt => ppc-spapr-hcalls.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/specs/{ppc-spap

Re: [PATCH 3/3] Link new ppc-spapr-hcalls.rst file to pseries.rst.

2021-12-08 Thread Daniel Henrique Barboza
On 12/8/21 13:59, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- Reviewed-by: Daniel Henrique Barboza docs/system/ppc/pseries.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc

Re: [RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

2021-12-08 Thread Michael S. Tsirkin
On Wed, Dec 08, 2021 at 01:20:10PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > Hi guys, > > This patch introduces vhost-vdpa-net device, which is inspired > by vhost-user-blk and the proposal of vhost-vdpa-blk device [1]. > > I've tested this patch on Huawei's offload card: > ./x86_64-sof

Re: [PATCH 09/12] s390x/pci: enable adapter event notification for interpreted devices

2021-12-08 Thread Matthew Rosato
On 12/8/21 6:29 AM, Thomas Huth wrote: On 07/12/2021 22.04, Matthew Rosato wrote: Use the associated vfio feature ioctl to enable adapter event notification and forwarding for devices when requested.  This feature will be set up with or without firmware assist based upon the 'intassist' setting

Re: [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN

2021-12-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > The enablement of postcopy listening has a few steps, add a few tracepoints to > be there ready for some basic measurements for them. > > Signed-off-by: Peter Xu > --- > migration/savevm.c | 5 - > migration/trace-events | 2 +- > 2 files changed,

[PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-08 Thread Fabiano Rosas
We cannot have TCG code in powerpc_excp because the function is called from kvm-only code via ppc_cpu_do_interrupt: ../target/ppc/excp_helper.c:463:29: error: implicit declaration of function ‘cpu_ldl_code’ [-Werror=implicit-function-declaration] Fortunately, the Alignment interrupt is not amon

[PATCH 2/6] target/arm: Move arm_pamax out of line

2021-12-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/internals.h | 19 +-- target/arm/helper.c| 22 ++ 2 files changed, 23 insertions(+), 18 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 89f7610ebc..27d2fcd26c 100644 --- a/targ

[PATCH for-7.0 0/6] target/arm: Implement LVA, LPA, LPA2 features

2021-12-08 Thread Richard Henderson
These features are all related and relatively small. Testing so far has been limited to booting a kernel with 64k pages and VA and PA set to 52 bits, which excercises LVA and LPA. There is not yet upstream support for LPA2, probably because it's an ARMv8.7 addition. r~ Richard Henderson (6):

[PATCH 5/6] target/arm: Implement FEAT_LPA

2021-12-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu-param.h | 2 +- target/arm/cpu64.c | 2 +- target/arm/helper.c| 19 --- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h index 5f9c288b1a..b59d505761 100644

[PATCH 1/6] target/arm: Fault on invalid TCR_ELx.TxSZ

2021-12-08 Thread Richard Henderson
Without FEAT_LVA, the behaviour of programming an invalid value is IMPLEMENTATION DEFINED. With FEAT_LVA, programming an invalid minimum value requires a Translation fault. It is most self-consistent to choose to generate the fault always. Signed-off-by: Richard Henderson --- target/arm/helper

[PATCH 4/6] target/arm: Implement FEAT_LVA

2021-12-08 Thread Richard Henderson
This feature is relatively small, as it applies only to 64k pages and thus requires no additional changes to the table descriptor walking algorithm, only a change to the minimum TSZ (which is the inverse of the maximum virtual address space size). Signed-off-by: Richard Henderson --- target/arm/

[PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS

2021-12-08 Thread Richard Henderson
This field controls the output (intermediate) physical address size of the translation process. V8 requires to raise an AddressSize fault if the page tables are programmed incorrectly, such that any intermediate descriptor address, or the final translated address, is out of range. Add an outputsi

[PATCH 6/6] target/arm: Implement FEAT_LPA2

2021-12-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 +++ target/arm/internals.h | 2 ++ target/arm/cpu64.c | 2 ++ target/arm/helper.c| 80 +++--- 4 files changed, 83 insertions(+), 13 deletions(-) diff --git a/target/arm/cpu.h b/tar

Re: [PATCH v6 01/18] exec/memop: Adding signedness to quad definitions

2021-12-08 Thread Alistair Francis
On Sun, Nov 28, 2021 at 11:59 PM Frédéric Pétrot wrote: > > Renaming defines for quad in their various forms so that their signedness is > now explicit. > Done using git grep as suggested by Philippe, with a bit of hand edition to > keep assignments aligned. > > Signed-off-by: Frédéric Pétrot > R

Re: [PATCH v6 07/18] target/riscv: setup everything for rv64 to support rv128 execution

2021-12-08 Thread Alistair Francis
On Mon, Nov 29, 2021 at 12:08 AM Frédéric Pétrot wrote: > > This patch adds the support of the '-cpu rv128' option to > qemu-system-riscv64 so that we can indicate that we want to run rv128 > executables. > Still, there is no support for 128-bit insns at that stage so qemu fails > miserably (as ex

Re: [PATCH 6/7] migration: Dump sub-cmd name in loadvm_process_command tp

2021-12-08 Thread Peter Xu
On Wed, Dec 08, 2021 at 06:41:22PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > It'll be easier to read the name rather than index of sub-cmd when > > debugging. > > > > Signed-off-by: Peter Xu > > --- > > migration/savevm.c | 2 +- > > migration/trace-ev

Re: [PATCH 1/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread David Gibson
On Wed, Dec 08, 2021 at 03:54:40PM -0300, Daniel Henrique Barboza wrote: > > > On 12/8/21 13:59, lagar...@linux.ibm.com wrote: > > From: Leonardo Garcia > > > > Signed-off-by: Leonardo Garcia > > --- > > docs/specs/ppc-spapr-hcalls.txt | 92 - > > 1 file chan

Re: [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN

2021-12-08 Thread Peter Xu
On Wed, Dec 08, 2021 at 07:46:20PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > The enablement of postcopy listening has a few steps, add a few tracepoints > > to > > be there ready for some basic measurements for them. > > > > Signed-off-by: Peter Xu > > ---

Re: [PATCH v9 09/10] target/ppc: PMU Event-Based exception support

2021-12-08 Thread David Gibson
On Wed, Dec 01, 2021 at 12:17:33PM -0300, Daniel Henrique Barboza wrote: > From: Gustavo Romero > > Following up the rfebb implementation, this patch adds the EBB exception > support that are triggered by Performance Monitor alerts. This exception > occurs when an enabled PMU condition or event h

Re: [PATCH v9 10/10] target/ppc/excp_helper.c: EBB handling adjustments

2021-12-08 Thread David Gibson
On Wed, Dec 01, 2021 at 12:17:34PM -0300, Daniel Henrique Barboza wrote: > The current logic is only considering event-based exceptions triggered > by the performance monitor. This is true now, but we might want to add > support for external event-based exceptions in the future. > > Let's make it

Re: [RFC PATCH v2 07/44] i386/kvm: Squash getting/putting guest state for TDX VMs

2021-12-08 Thread Xiaoyao Li
On 8/26/2021 6:24 PM, Gerd Hoffmann wrote: On Wed, Jul 07, 2021 at 05:54:37PM -0700, isaku.yamah...@gmail.com wrote: From: Sean Christopherson Ignore get/put state of TDX VMs as accessing/mutating guest state of producation TDs is not supported. Why silently ignore instead of returning an er

Re: [PATCH 1/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread Warner Losh
On Wed, Dec 8, 2021 at 6:51 PM David Gibson wrote: > On Wed, Dec 08, 2021 at 03:54:40PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 12/8/21 13:59, lagar...@linux.ibm.com wrote: > > > From: Leonardo Garcia > > > > > > Signed-off-by: Leonardo Garcia > > > --- > > > docs/specs/ppc-spapr

Re: [PATCH v4 10/22] target/riscv: Implement AIA CSRs for 64 local interrupts on RV32

2021-12-08 Thread Anup Patel
On Thu, Nov 4, 2021 at 10:13 AM Alistair Francis wrote: > > On Tue, Oct 26, 2021 at 5:10 PM Anup Patel wrote: > > > > The AIA specification adds new CSRs for RV32 so that RISC-V hart can > > support 64 local interrupts on both RV32 and RV64. > > > > Signed-off-by: Anup Patel > > --- > > target/

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Ani Sinha
On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: > > This implements a PCI device for ACPI ERST. This implements the > non-NVRAM "mode" of operation for ERST as it is supported by > Linux and Windows. Few more comments on this patch ... > > Signed-off-by: Eric DeVolder > --- > hw/acpi/Kcon

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Ani Sinha
On Wed, Dec 8, 2021 at 10:08 PM Eric DeVolder wrote: > > > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of operation for ERST as it is supported by

Re: [PATCH v4 11/22] target/riscv: Implement AIA hvictl and hviprioX CSRs

2021-12-08 Thread Anup Patel
On Thu, Nov 4, 2021 at 10:19 AM Alistair Francis wrote: > > On Tue, Oct 26, 2021 at 5:39 PM Anup Patel wrote: > > > > The AIA hvictl and hviprioX CSRs allow hypervisor to control > > interrupts visible at VS-level. This patch implements AIA hvictl > > and hviprioX CSRs. > > > > Signed-off-by: Anu

Re: [PATCH 2/6] target/arm: Move arm_pamax out of line

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/9/21 00:11, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 19 +-- > target/arm/helper.c| 22 ++ > 2 files changed, 23 insertions(+), 18 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS

2021-12-08 Thread Philippe Mathieu-Daudé
Hi Richard, On 12/9/21 00:11, Richard Henderson wrote: > This field controls the output (intermediate) physical address size > of the translation process. V8 requires to raise an AddressSize > fault if the page tables are programmed incorrectly, such that any > intermediate descriptor address, or

Re: [PATCH 1/3] docs: rSTify ppc-spapr-hcalls.txt

2021-12-08 Thread Cédric Le Goater
-When the guest runs in "real mode" (in powerpc lingua this means -with MMU disabled, ie guest effective == guest physical), it only -has access to a subset of memory and no IOs. +H_LOGICAL_MEMOP (0xf001) + -PAPR provides a set of hypervisor calls to perform cacheable or +W

Re: [PATCH 1/3] target/ppc: Fix MPCxxx FPU interrupt address

2021-12-08 Thread Cédric Le Goater
On 12/8/21 13:30, Fabiano Rosas wrote: The Floating-point Unavailable and Decrementer interrupts are being registered at the same 0x900 address. The FPU should be at 0x800 instead. Verified on MPC555, MPC860 and MPC885 user manuals. Reported-by: BALATON Zoltan Signed-off-by: Fabiano Rosas R

Re: [PATCH 3/3] target/ppc: Set 601v exception model id

2021-12-08 Thread Cédric Le Goater
On 12/8/21 13:30, Fabiano Rosas wrote: The exception model id for 601v has been removed without mention why. I assume it was inadvertent and restore it here. Fixes: b632a148b6 ("target-ppc: Use QOM method dispatch for MMU fault handling") Signed-off-by: Fabiano Rosas Reviewed-by: Cédric Le Go