On Tue, Dec 07, 2021 at 03:40:38PM -0500, John Snow wrote:
> Clang doesn't recognize that the variable is being "used" and will emit
> a warning:
>
> ../ui/clipboard.c:47:34: error: variable 'old' set but not used
> [-Werror,-Wunused-but-set-variable]
> g_autoptr(QemuClipboardInfo) old = NULL;
> ^
> 1 error generated.
>
> OK, fine. Just do things the old way.
>
> Signed-off-by: John Snow <js...@redhat.com>
> ---
> ui/clipboard.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ui/clipboard.c b/ui/clipboard.c
> index d7b008d62a..9ab65efefb 100644
> --- a/ui/clipboard.c
> +++ b/ui/clipboard.c
> @@ -44,12 +44,11 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
>
> void qemu_clipboard_update(QemuClipboardInfo *info)
> {
> - g_autoptr(QemuClipboardInfo) old = NULL;
> assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
>
> notifier_list_notify(&clipboard_notifiers, info);
>
> - old = cbinfo[info->selection];
> + g_free(cbinfo[info->selection]);
This is a ref counted data type - it can't use g_free:
https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg04890.html
> cbinfo[info->selection] = qemu_clipboard_info_ref(info);
> }
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
