Re: [PATCH v6 0/5] hw/arm/virt: Introduce cpu topology support

2021-09-03 Thread wangyanan (Y)
On 2021/9/2 23:56, Peter Maydell wrote: On Tue, 24 Aug 2021 at 13:20, Yanan Wang wrote: This new version is based on patch series [1] which introduces some fix and improvement for smp parsing. Description: Once the view of an accurate virtual cpu topology is provided to guest, with a well-de

Re: [PATCH v2 01/35] acpi: add helper routines to initialize ACPI tables

2021-09-03 Thread Igor Mammedov
On Thu, 2 Sep 2021 14:56:00 +0200 Eric Auger wrote: > Hi Igor, > > On 7/8/21 5:45 PM, Igor Mammedov wrote: > > Patch introduces acpi_init_table()/acpi_table_composed() API > > that hides pointer/offset arithmetic from user as opposed > > to build_header(), to prevent errors caused by it [1]. > >

Re: [PATCH v2 01/35] acpi: add helper routines to initialize ACPI tables

2021-09-03 Thread Eric Auger
Hi Igor, On 9/3/21 9:12 AM, Igor Mammedov wrote: > On Thu, 2 Sep 2021 14:56:00 +0200 > Eric Auger wrote: > >> Hi Igor, >> >> On 7/8/21 5:45 PM, Igor Mammedov wrote: >>> Patch introduces acpi_init_table()/acpi_table_composed() API >>> that hides pointer/offset arithmetic from user as opposed >>>

Re: [PATCH v6 0/5] hw/arm/virt: Introduce cpu topology support

2021-09-03 Thread Peter Maydell
On Fri, 3 Sept 2021 at 08:05, wangyanan (Y) wrote: > > > On 2021/9/2 23:56, Peter Maydell wrote: > > On Tue, 24 Aug 2021 at 13:20, Yanan Wang wrote: > >> This new version is based on patch series [1] which introduces some > >> fix and improvement for smp parsing. > >> > >> Description: > >> Once

Re: [PULL v3 0/8] Fuzzing Patches for 2021-09-01

2021-09-03 Thread Peter Maydell
On Wed, 1 Sept 2021 at 12:50, Alexander Bulekov wrote: > > Hello Peter, > > The following changes since commit ec397e90d21269037280633b6058d1f280e27667: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20210901-2' into staging > (2021-09-01 08:33:02 +0100) > > are

Re: [PATCH v6 0/5] hw/arm/virt: Introduce cpu topology support

2021-09-03 Thread wangyanan (Y)
On 2021/9/3 15:25, Peter Maydell wrote: On Fri, 3 Sept 2021 at 08:05, wangyanan (Y) wrote: On 2021/9/2 23:56, Peter Maydell wrote: On Tue, 24 Aug 2021 at 13:20, Yanan Wang wrote: This new version is based on patch series [1] which introduces some fix and improvement for smp parsing. Desc

Re: [RFC 0/5] VirtIO RDMA

2021-09-03 Thread 魏俊吉
> On Sep 3, 2021, at 8:57 AM, Jason Wang wrote: > > On Thu, Sep 2, 2021 at 9:07 PM Junji Wei wrote: >> >> Hi all, >> >> This RFC aims to reopen the discussion of Virtio RDMA. >> Now this is based on Yuval Shaia's RFC "VirtIO RDMA" >> which implemented a frame for Virtio RDMA and a simple >>

Re: [PATCH v4 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages()

2021-09-03 Thread David Hildenbrand
On 03.09.21 00:28, Peter Xu wrote: On Thu, Sep 02, 2021 at 03:14:31PM +0200, David Hildenbrand wrote: Let's factor out prefaulting/populating to make further changes easier to review. While at it, use the actual page size of the ramblock, which defaults to qemu_real_host_page_size for anonymous

Re: [PATCH v2 31/35] acpi: arm/virt: build_spcr: use acpi_init_table()/acpi_table_composed() instead of build_header()

2021-09-03 Thread Igor Mammedov
On Thu, 2 Sep 2021 17:49:55 +0200 Eric Auger wrote: > Hi Igor, > > On 7/8/21 5:46 PM, Igor Mammedov wrote: > > it replaces error-prone pointer arithmetic for build_header() API, > > with 2 calls to start and finish table creation, > > which hides offsets magic from API user. > > > > while at it

Re: [PATCH v4 8/9] migration/ram: Factor out populating pages readable in ram_block_populate_pages()

2021-09-03 Thread David Hildenbrand
That'll be good enough for live snapshot as uffd-wp works for zero pages, however I'm just afraid it may stop working for some new users of it when zero pages won't suffice. I thought about that as well. But snapshots/migration will read all memory either way and consume real memory when there i

[PATCH v2 3/5] configure: Remove options that can be handled via meson_options.txt instead

2021-09-03 Thread Thomas Huth
These trivial options can now be handled via the new generic code that parses meson_options.txt. Note: It's OK that we do not pass the "option=auto" settings from the configure script to meson anymore since all related options use "auto" as default value in meson_options.txt already. Reviewed-by:

[PATCH v2 0/5] Use meson_options.txt in the configure script

2021-09-03 Thread Thomas Huth
It's cumbersome to maintain the build options twice, one time in the configure script and one time in meson_options.txt. Thus let's add some logic to the configure script to look at the meson_options.txt file instead of handling every option twice. Note: Unlike Paolo's earlier version (which can b

[PATCH v2 2/5] meson_options.txt: Switch the default value for the vnc option to 'auto'

2021-09-03 Thread Thomas Huth
There is no reason why VNC should always be enabled and not be set to the default value. We already switched the setting in the "configure" script in commit 3a6a1256d4 ("configure: Allow vnc to get disabled with --without-default-features"), so let's do that in meson_options.txt now, too. Signed-o

[PATCH v2 1/5] configure: Add the possibility to read options from meson_options.txt

2021-09-03 Thread Thomas Huth
To avoid double maintenance between the configure script and meson_options.txt, add some simple logic in the configure script to read the options from meson_options.txt. Signed-off-by: Thomas Huth --- configure | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff

[PATCH v2 5/5] meson_options.txt: Document that "configure" reads this file, too

2021-09-03 Thread Thomas Huth
Add a comment that meson_options.txt is also parsed by the configure script and that the options need a certain layout for this to succeed. Signed-off-by: Thomas Huth --- meson_options.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/meson_options.txt b/meson_options.txt index 2c89e

[PATCH v2 4/5] configure: Get help text from meson_options.txt

2021-09-03 Thread Thomas Huth
It's cumbersome to maintain the option help texts twice, once in the "configure" script and once in meson_options.txt. So let's add some logic to the configure script to read most of the help texts from meson_options.txt. Signed-off-by: Thomas Huth --- configure | 95 ++--

[PATCH v2 1/1] hw/arm/aspeed: Add Fuji machine type

2021-09-03 Thread pdel
From: Peter Delevoryas This adds a new machine type "fuji-bmc" based on the following device tree: https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dts Most of the i2c devices are not there, they're added here: https://github.com/facebook/openbmc/blob/he

[PATCH v2 0/1] hw/arm/aspeed: Add Fuji machine type

2021-09-03 Thread pdel
From: Peter Delevoryas v2: - Added supported i2c devices (lm75, tmp75, tmp422, 24c64, 24c02) - Switched flash model to mx66l1g45g (128MB) - Completely separated fuji class definition from ast2600-evb - Removed image acceptance test Link: https://github.com/peterdelevoryas/qemu/tree/aspee

Re: [RFC v9 14/29] vfio: Introduce helpers to DMA map/unmap a RAM section

2021-09-03 Thread Kunkun Jiang
Hi Eric, On 2021/4/11 20:08, Eric Auger wrote: Let's introduce two helpers that allow to DMA map/unmap a RAM section. Those helpers will be called for nested stage setup in another call site. Also the vfio_listener_region_add/del() structure may be clearer. Signed-off-by: Eric Auger --- v8 -

Re: [PATCH v6 2/6] qmp: add QMP command x-debug-virtio-status

2021-09-03 Thread Michael S. Tsirkin
On Mon, Jul 12, 2021 at 06:35:33AM -0400, Jonah Palmer wrote: > From: Laurent Vivier > > This new command shows the status of a VirtIODevice > (features, endianness and number of virtqueues) > > Next patch will improve output by decoding feature bits. > > Signed-off-by: Laurent Vivier > Signed

Re: How does qemu detect the completion of interrupt execution?

2021-09-03 Thread Duo jia
I understand the hardware,but How to achieve this function with qemu?, For example, this interrupt is not allowed to be nested. When the new interrupt comes, how can I detect that the interrupt is executing? Peter Maydell 于2021年9月2日周四 下午3:43写道: > On Thu, 2 Sept 2021 at 03:18, Duo jia wrote: >

Re: [PATCH v5 2/2] memory: Have 'info mtree' remove duplicated Address Space information

2021-09-03 Thread Philippe Mathieu-Daudé
On 9/2/21 11:55 PM, Peter Xu wrote: > Hi, Phil, > > On Thu, Sep 02, 2021 at 08:26:04AM +0200, Philippe Mathieu-Daudé wrote: >> address-space shared 4 times: > > I commented on the format of the output, I saw that it's switched back to the > v1. Any reason? The code uses the format you asked,

Re: [PATCH v4 7/9] migration: Simplify alignment and alignment checks

2021-09-03 Thread David Hildenbrand
On 03.09.21 00:32, Peter Xu wrote: On Thu, Sep 02, 2021 at 03:14:30PM +0200, David Hildenbrand wrote: diff --git a/migration/migration.c b/migration/migration.c index bb909781b7..ae97c2c461 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -391,7 +391,7 @@ int migrate_send_rp_me

[PULL 00/22] testing and plugin updates

2021-09-03 Thread Alex Bennée
The following changes since commit 079b1252e9de384385c9da910262312ec2e574c8: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210901' into staging (2021-09-01 17:45:38 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-for-6.2-0

[PULL 02/22] gitlab-ci: Merge "build-disabled" with "build-without-default-features"

2021-09-03 Thread Alex Bennée
From: Thomas Huth Both jobs are testing more or less the same thing (building QEMU with features disabled), so we are wasting precious CI cycles here by doing this twice. Merge the jobs by using --without-default-features by default and just adding some additional --disable-... switches which are

[PULL 03/22] gitlab-ci: Remove superfluous "dnf install" statement

2021-09-03 Thread Alex Bennée
From: Thomas Huth The container already features meson and ninja, so there is no need to try to install it with dnf again. Signed-off-by: Thomas Huth Reviewed-by: Willian Rampazzo Message-Id: <20210730143809.717079-3-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20210806141015.248

[PULL 09/22] plugins: allow plugin arguments to be passed directly

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Passing arguments to plugins had to be done through "arg=". This is redundant and introduces confusion especially when the argument has a name and value (e.g. `-plugin plugin_name,arg="argname=argvalue"`). This allows passing plugin arguments directly e.g: `-plugin plu

[PULL 01/22] plugins/execlog: removed unintended "s" at the end of log lines.

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210803151428.125323-1-ma.mando...@gmail.com> Message-Id: <20210806141015.2487502-2-alex.ben...@linaro.org> Cc: qemu-sta...@nongnu.org diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.

[PULL 11/22] plugins/hotpages: introduce sortby arg and parsed bool args correctly

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Since plugin arguments now expect boolean arguments, a plugin argument name "sortby" now expects a value of "read", "write", or "address". "io" arg is now expected to be passed as a full-form boolean parameter, i.e. "io=on|true|yes|off|false|no" Signed-off-by: Mahmoud Mand

[PULL 04/22] gitlab-ci: Fix ..._RUNNER_AVAILABLE variables and document them

2021-09-03 Thread Alex Bennée
From: Thomas Huth The patch that recently introduced the S390X_RUNNER_AVAILABLE variable in custom-runners.yml missed that the bottom half of the file is rather about aarch64 than s390x. Thus rename the S390X_RUNNER_AVAILABLE to AARCH64_RUNNER_AVAILABLE in those jobs. Finally mention both variab

[PULL 08/22] docs/devel/tcg-plugins: added cores arg to cache plugin

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Message-Id: <20210803151301.123581-3-ma.mando...@gmail.com> Signed-off-by: Alex Bennée diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 047bf4ada7..2d29a8972b 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel

[PULL 07/22] plugins: sort exported symbol list

2021-09-03 Thread Alex Bennée
This will make it easier to add new exported functions. Signed-off-by: Alex Bennée diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index 40b4ff3821..dee7610387 100644 --- a/plugins/qemu-plugins.symbols +++ b/plugins/qemu-plugins.symbols @@ -1,37 +1,37 @@ { - qemu_plugi

[PULL 15/22] plugins/howvec: adapting to the new argument passing scheme

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Correctly parsing plugin argument since they now must be provided as full-form boolean parameters, e.g.: -plugin ./contrib/plugins/libhowvec.so,verbose=on,inline=on Also, introduced the argument "count" that accepts one opt to count individually at a time. Signed-off-b

[PATCH V2 07/21] vhost-vdpa: don't cleanup twice in vhost_vdpa_add()

2021-09-03 Thread Jason Wang
The previous vhost_net_cleanup is sufficient for freeing, calling vhost_vdpa_del() in this case will lead an extra round of free. Note that this kind of "double free" is safe since vhost_dev_cleanup() zero the whole structure. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vh

[PULL 06/22] plugins/cache: supported multicore cache modelling

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Multicore L1 cache modelling is introduced and is supported for both full system emulation and linux-user. For full-system emulation, L1 icache and dcache are maintained for each available core, since this information is exposed to the plugin through `qemu_plugin_n_vcpus()`

[PATCH V2 01/21] vhost-vdpa: remove unused variable "acked_features"

2021-09-03 Thread Jason Wang
"acked_features" is unused, let's remove that. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 19187dce8c..72829884d7 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -29,7 +29,6 @@ typedef struct

[PULL 05/22] plugins: do not limit exported symbols if modules are active

2021-09-03 Thread Alex Bennée
From: Paolo Bonzini On Mac --enable-modules and --enable-plugins are currently incompatible, because the Apple -Wl,-exported_symbols_list command line options prevents the export of any symbols needed by the modules. On x86 -Wl,--dynamic-list does not have this effect, but only because the -Wl

[PATCH V2 14/21] vhost-vdpa: prepare for the multiqueue support

2021-09-03 Thread Jason Wang
Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue model. So we need to simply use virtqueue index as the vhost virtqueue index. This is a must for multiqueue to work for vhost-vdpa. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PULL 18/22] tests/plugins/insn: made arg inline not positional and parse it as bool

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Made argument "inline" not positional, this has two benefits. First is that we adhere to how QEMU passes args generally, by taking the last value of an argument and drop the others. And the second is that this sets up a framework for potentially adding new args easily. Sign

[PULL 19/22] tests/plugins/mem: introduce "track" arg and make args not positional

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour This commit makes the plugin adhere to the new plugins arg-passing scheme by expecting full-form boolean args instead of short-form booleans. This necessitates that we introduce a new argument, here "track", to accept "r", "w", or "rw". Also, it makes arguments not position

[PATCH V2 06/21] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()

2021-09-03 Thread Jason Wang
The VhostVDPAState is just allocated by qemu_new_net_client() via g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for sure, let's remove this unnecessary check in vhost_vdpa_add(). Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 4 1 file changed, 4 deletions(-) diff --git a

[PULL 12/22] plugins/hotblocks: Added correct boolean argument parsing

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20210730135817.17816-5-ma.mando...@gmail.com> diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 4b08340143..062200a7a4 100644 --- a/contrib/plugins/

[PULL 17/22] tests/plugins/bb: adapt to the new arg passing scheme

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20210730135817.17816-10-ma.mando...@gmail.com> diff --git a/tests/plugin/bb.c b/tests/plugin/bb.c index de09bdde4e..7d470a1011 100644 --- a/tests/plugin/bb.c +++ b/tests/plugi

[PATCH V2 00/21] vhost-vDPA multiqueue

2021-09-03 Thread Jason Wang
Hi All: This patch implements the multiqueue support for vhost-vDPA. The most important requirement si the control virtqueue support. The virtio-net and vhost-net core are tweak to support control virtqueue as if what data queue pairs are done: a dedicated vhost_net device which is coupled with th

[PULL 21/22] docs/deprecated: deprecate passing plugin args through `arg=`

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Message-Id: <20210802134414.52037-1-ma.mando...@gmail.com> Reviewed-by: Alex Bennée [AJB: fixed up move of deprecated.rst] Signed-off-by: Alex Bennée diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 1e1a5e96ad..6e88a

[PATCH V2 09/21] vhost-vdpa: tweak the error label in vhost_vdpa_add()

2021-09-03 Thread Jason Wang
Introduce new error label to avoid the unnecessary checking of net pointer. Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/vhost-vdpa.c b/net

[PATCH V2 02/21] vhost-vdpa: correctly return err in vhost_vdpa_set_backend_cap()

2021-09-03 Thread Jason Wang
We should return error code instead of zero, otherwise there's no way for the caller to detect the failure. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 4fa414fee

[PATCH V2 17/21] vhost-net: control virtqueue support

2021-09-03 Thread Jason Wang
We assume there's no cvq in the past, this is not true when we need control virtqueue support for vhost-user backends. So this patch implements the control virtqueue support for vhost-net. As datapath, the control virtqueue is also required to be coupled with the NetClientState. The vhost_net_start

[PULL 20/22] tests/plugins/syscalls: adhere to new arg-passing scheme

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20210730135817.17816-13-ma.mando...@gmail.com> diff --git a/tests/plugin/syscall.c b/tests/plugin/syscall.c index 6dd71092e1..484b48de49 100644 --- a/tests/plugin/syscall.c ++

[PULL 22/22] docs/devel: be consistent about example plugin names

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Some plugins were prefixed with `.c`, some were not. Since the name is essentially the full-name of the plugin file, it's logical to include the extension. Signed-off-by: Mahmoud Mandour Message-Id: <20210830121534.656559-1-ma.mando...@gmail.com> Reviewed-by: Alex Bennée

[PATCH V2 04/21] vhost: use unsigned int for nvqs

2021-09-03 Thread Jason Wang
Switch to use unsigned int for nvqs since it's not expected to be negative. Reviewed-by: Eli Cohen Signed-off-by: Jason Wang --- include/hw/virtio/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 045d0fd9f2..

[PATCH V2 03/21] vhost_net: remove the meaningless assignment in vhost_net_start_one()

2021-09-03 Thread Jason Wang
The nvqs and vqs have been initialized during vhost_net_init() and are not expected to change during the life cycle of vhost_net structure. So this patch removes the meaningless assignment. Reviewed-by: Eli Cohen Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 3 --- 1 file changed, 3 deleti

[PATCH V2 15/21] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *

2021-09-03 Thread Jason Wang
This patch switches to let net_vhost_vdpa_init() to return NetClientState *. This is used for the callers to allocate multiqueue NetClientState for multiqueue support. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff

[PATCH V2 05/21] vhost_net: do not assume nvqs is always 2

2021-09-03 Thread Jason Wang
This patch switches to initialize dev.nvqs from the VhostNetOptions instead of assuming it was 2. This is useful for implementing control virtqueue support which will be a single vhost_net structure with a single cvq. Note that nvqs is still set to 2 for all users and this patch does not change fu

[PATCH V2 11/21] vhost-vdpa: remove the unncessary queue_index assignment

2021-09-03 Thread Jason Wang
The queue_index of NetClientState should be assigned in set_netdev() afterwards, so trying to net_vhost_vdpa_init() is meaningless. This patch removes this. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vhos

[PULL 14/22] plugins/hwprofile: adapt to the new plugin arguments scheme

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Parsing boolean arguments correctly (e.g. pattern=on or source=false). Introduced a new "track" argument that takes a [read|write] value. This substitutes passing read or write to "arg=" that is deprecated. Also, matches are now taken one by one through the "match" argument

[PATCH V2 08/21] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

2021-09-03 Thread Jason Wang
Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 3213e69d63..b43df00a85 100644 --- a/net/vhost-vdpa.c +

[PATCH V2 12/21] vhost-vdpa: open device fd in net_init_vhost_vdpa()

2021-09-03 Thread Jason Wang
This path switches to open device fd in net_init_vhost_vpda(). This is used to prepare for the multiqueue support. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/net/vhos

[PATCH V2 19/21] vhost: record the last virtqueue index for the virtio device

2021-09-03 Thread Jason Wang
This patch introduces a new field in the vhost_dev structure to record the last virtqueue index for the virtio device. This will be useful for the vhost backends with 1:N model to start or stop the device after all the vhost_dev structures were started or stopped. Signed-off-by: Jason Wang --- h

[PATCH V2 10/21] vhost-vdpa: fix the wrong assertion in vhost_vdpa_init()

2021-09-03 Thread Jason Wang
Vhost_vdpa_add() can fail for various reasons, so the assertion of the succeed is wrong. Instead, we should free the NetClientState and propagate the error to the caller Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 5 - 1 file changed, 4 insertions(+), 1

[PULL 13/22] plugins/lockstep: make socket path not positional & parse bool arg

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20210730135817.17816-6-ma.mando...@gmail.com> diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index aa75b390b1..5cddf31c70 100644 --- a/docs/devel/tcg-plu

[PATCH V2 13/21] vhost-vdpa: classify one time request

2021-09-03 Thread Jason Wang
Vhost-vdpa uses one device multiqueue queue (pairs) model. So we need to classify the one time request (e.g SET_OWNER) and make sure those request were only called once per device. This is used for multiqueue support. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 52 +++

[PULL 16/22] docs/tcg-plugins: new passing parameters scheme for cache docs

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20210730135817.17816-9-ma.mando...@gmail.com> diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 7b1dece024..fcc460bf7b 100644 --- a/docs/devel/tcg-plu

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-09-03 Thread Valeriy Vdovin
On Tue, 24 Aug 2021 08:48:31 +0200 Marcus Armbruster wrote: >Eduardo Habkost writes: > >> On Mon, Aug 23, 2021 at 9:35 AM Markus Armbruster wrote: >>> >>> Eduardo Habkost writes: >>> >>> > On Wed, Aug 11, 2021 at 9:44 AM Thomas Huth wrote: >>> >> >>> >> On 11/08/2021 15.40, Eduardo Habkost wr

[PULL 10/22] plugins/api: added a boolean parsing plugin api

2021-09-03 Thread Alex Bennée
From: Mahmoud Mandour This call will help boolean argument parsing since arguments are now passed to plugins as a name and value. Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Message-Id: <20210730135817.17816-3-ma.mando...@gmail.com> [AJB: add to symbols] Signed-off-by: Alex Bennée

[PATCH V2 18/21] virito-net: use "qps" instead of "queues" when possible

2021-09-03 Thread Jason Wang
Most of the time, "queues" really means queue pairs. So this patch switch to use "qps" to avoid confusion. Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 6 +- hw/net/virtio-net.c| 150 - include/hw/virtio/virtio-net.h | 4 +- 3 fil

[PATCH V2 16/21] net: introduce control client

2021-09-03 Thread Jason Wang
This patch introduces a boolean for the device has control queue which can accepts control command via network queue. The first user would be the control virtqueue support for vhost. Signed-off-by: Jason Wang --- include/net/net.h | 5 + net/net.c | 24 +--- 2 f

[PATCH 1/2] vfio/pci: Fix vfio-pci sub-page MMIO BAR mmaping in live migration

2021-09-03 Thread Kunkun Jiang
We expand MemoryRegions of vfio-pci sub-page MMIO BARs to vfio_pci_write_config to improve IO performance. The MemoryRegions of destination VM will not be expanded successful in live migration, because their addresses have been updated in vmstate_load_state (vfio_pci_load_config). Remove the restr

[PATCH 0/2] vfio: Some fixes about vfio-pci MMIO RAM mapping

2021-09-03 Thread Kunkun Jiang
This series include patches as below: Patch 1: - Deleted a check to fix vfio-pci sub-page MMIO BAR mmaping in live migration Patch 2: - Added a trace point to informe users when a MMIO RAM ection less than PAGE_SIZE Kunkun Jiang (2): vfio/pci: Fix vfio-pci sub-page MMIO BAR mmaping in live mi

[PATCH V2 20/21] virtio-net: vhost control virtqueue support

2021-09-03 Thread Jason Wang
This patch implements the control virtqueue support for vhost. This requires virtio-net to figure out the datapath queue pairs and control virtqueue via is_datapath and pass the number of those two types of virtqueues to vhost_net_start()/vhost_net_stop(). Signed-off-by: Jason Wang --- hw/net/vi

[PATCH 2/2] vfio/common: Add trace point when a MMIO RAM section less than PAGE_SIZE

2021-09-03 Thread Kunkun Jiang
The MSI-X structures of some devices and other non-MSI-X structures are in the same BAR. They may share one host page, especially in the case of large page granularity, suck as 64K. For example, MSIX-Table size of 82599 NIC is 0x30 and the offset in Bar 3(size 64KB) is 0x0. If host page size is 64

[PATCH V2 21/21] vhost-vdpa: multiqueue support

2021-09-03 Thread Jason Wang
This patch implements the multiqueue support for vhost-vdpa. This is done simply by reading the number of queue pairs from the config space and initialize the datapath and control path net client. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 2 +- net/vhost-vdpa.c | 104 +++

Re: [PATCH v2 01/20] docs/system: ppc: Update the URL for OpenPOWER firmware images

2021-09-03 Thread Greg Kurz
On Thu, 2 Sep 2021 15:09:09 +0200 Cédric Le Goater wrote: > This also fixes a small skiboot/skiroot typo and removes the links to > the specific POWER8 and POWER9 images since the firmware images can be > used to run all machines. > > Signed-off-by: Cédric Le Goater > --- > Reviewed-by: Greg

Re: [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips

2021-09-03 Thread Greg Kurz
On Thu, 2 Sep 2021 15:09:10 +0200 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > Reviewed-by: Greg Kurz > v2: fixed assert value ... > > hw/ppc/pnv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index 03c86508d2f7..71e45515f1

Re: [PATCH v2 0/1] hw/arm/aspeed: Add Fuji machine type

2021-09-03 Thread Cédric Le Goater
On 9/3/21 10:20 AM, p...@fb.com wrote: > From: Peter Delevoryas > > v2: > - Added supported i2c devices (lm75, tmp75, tmp422, 24c64, 24c02) > - Switched flash model to mx66l1g45g (128MB) > - Completely separated fuji class definition from ast2600-evb > - Removed image acceptance test > >

Re: [PATCH v2 1/1] hw/arm/aspeed: Add Fuji machine type

2021-09-03 Thread Cédric Le Goater
On 9/3/21 10:20 AM, p...@fb.com wrote: > From: Peter Delevoryas > > This adds a new machine type "fuji-bmc" based on the following device tree: > > https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dts > > Most of the i2c devices are not there, they're add

Re: [PATCH v4 7/9] migration: Simplify alignment and alignment checks

2021-09-03 Thread David Hildenbrand
On 03.09.21 10:47, David Hildenbrand wrote: On 03.09.21 00:32, Peter Xu wrote: On Thu, Sep 02, 2021 at 03:14:30PM +0200, David Hildenbrand wrote: diff --git a/migration/migration.c b/migration/migration.c index bb909781b7..ae97c2c461 100644 --- a/migration/migration.c +++ b/migration/migration.

Re: [PATCH v4 7/9] migration: Simplify alignment and alignment checks

2021-09-03 Thread David Hildenbrand
On 03.09.21 12:07, David Hildenbrand wrote: On 03.09.21 10:47, David Hildenbrand wrote: On 03.09.21 00:32, Peter Xu wrote: On Thu, Sep 02, 2021 at 03:14:30PM +0200, David Hildenbrand wrote: diff --git a/migration/migration.c b/migration/migration.c index bb909781b7..ae97c2c461 100644 --- a/mig

Re: How does qemu detect the completion of interrupt execution?

2021-09-03 Thread Peter Maydell
On Fri, 3 Sept 2021 at 09:33, Duo jia wrote: > > I understand the hardware,but How to achieve this function with qemu?, > > For example, this interrupt is not allowed to be nested. When the new > interrupt comes, how can I detect that the interrupt is executing? That depends on the hardware. I c

[PATCH v6 01/11] block/io: bring request check to bdrv_co_(read, write)v_vmstate

2021-09-03 Thread Vladimir Sementsov-Ogievskiy via
Only qcow2 driver supports vmstate. In qcow2 these requests go through .bdrv_co_p{read,write}v_part handlers. So, let's do our basic check for the request on vmstate generic handlers. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/io.c | 18 -- 1

[PATCH v6 03/11] block: use int64_t instead of uint64_t in driver read handlers

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili

[PATCH v6 00/11] 64bit block-layer: part II

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
Hi all! Sorry for a long delay :( Finally, here is v6. v6: rebase on new rbd handlers and backup-top renamed to copy-before-write. Also: 01: add Eric's r-b tweak commit msg to not mention sheepdog 02: add Eric's r-b 03: tweak commit msg drop extra type conversion in raw_co_pwrite_zeroes

[PATCH v6 09/11] block: make BlockLimits::max_pdiscard 64bit

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are going to support 64 bit discard requests. Now update the limit variable. It's absolutely safe. The variable is set in some drivers, and used in bdrv_co_pdiscard(). Update also max_pdiscard variable in bdrv_co_pdiscard(), so that bdrv_co_pdiscard() is now prepared for 64bit requests. The rem

[PATCH v6 07/11] block: use int64_t instead of int in driver write_zeroes handlers

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili

[PATCH v6 02/11] qcow2: check request on vmstate save/load path

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We modify the request by adding an offset to vmstate. Let's check the modified request. It will help us to safely move .bdrv_co_preadv_part and .bdrv_co_pwritev_part to int64_t type of offset and bytes. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/block_

[PATCH v6 04/11] block: use int64_t instead of uint64_t in driver write handlers

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili

[PATCH v6 06/11] block: make BlockLimits::max_pwrite_zeroes 64bit

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are going to support 64 bit write-zeroes requests. Now update the limit variable. It's absolutely safe. The variable is set in some drivers, and used in bdrv_co_do_pwrite_zeroes(). Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so that bdrv_co_do_pwrite_zeroes() is now pre

[PATCH v6 10/11] block: use int64_t instead of int in driver discard handlers

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili

[PATCH v6 05/11] block: use int64_t instead of uint64_t in copy_range driver handlers

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili

[PATCH v6 08/11] block/io: allow 64bit write-zeroes requests

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
Now that all drivers are updated by previous commit, we can drop two last limiters on write-zeroes path: INT_MAX in bdrv_co_do_pwrite_zeroes() and bdrv_check_request32() in bdrv_co_pwritev_part(). Now everything is prepared for implementing incredibly cool and fast big-write-zeroes in NBD and qcow

[PATCH v6 11/11] block/io: allow 64bit discard requests

2021-09-03 Thread Vladimir Sementsov-Ogievskiy
Now that all drivers are updated by the previous commit, we can drop the last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard(). Now everything is prepared for implementing incredibly cool and fast big-discard requests in NBD and qcow2. And any other driver which wants it of course. Signed-

Re: [PATCH v1 1/3] hw/riscv: virt: Don't use a macro for the PLIC configuration

2021-09-03 Thread Bin Meng
On Fri, Sep 3, 2021 at 2:50 PM Alistair Francis wrote: > > From: Alistair Francis > > Using a macro for the PLIC configuration doesn't make the code any > easier to read. Instead it makes it harder to figure out what is going > on, so let's remove it. > > Signed-off-by: Alistair Francis > --- >

Re: How does qemu detect the completion of interrupt execution?

2021-09-03 Thread Duo jia
I do some support on STM8 arch, the reference manual link is: > > > https://www.st.com/resource/en/reference_manual/cd00218714-stm8l050j3-stm8l051f3-stm8l052c6-stm8l052r8-mcus-and-stm8l151l152-stm8l162-stm8al31-stm8al3l-lines-stmicroelectronics.pdf Chapter 12 describes interrupts as blow: [image:

[PATCH 00/28] glib: Replace g_memdup() by g_memdup2_qemu()

2021-09-03 Thread Philippe Mathieu-Daudé
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large value

[PATCH 01/28] hw/hyperv/vmbus: Remove unused vmbus_load/save_req()

2021-09-03 Thread Philippe Mathieu-Daudé
vmbus_save_req() and vmbus_load_req() are not used. Remove them to avoid maintaining dead code. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/hyperv/vmbus.h | 3 -- hw/hyperv/vmbus.c | 59 --- 2 files changed, 62 deletions(-) diff --git a/incl

[PATCH 05/28] block/qcow2-bitmap: Replace g_memdup() by g_memdup2_qemu()

2021-09-03 Thread Philippe Mathieu-Daudé
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large value

[PATCH 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-09-03 Thread Philippe Mathieu-Daudé
When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ... g_memdup() has been updated by g_memdup2() to fix eventual

[PATCH 06/28] softmmu: Replace g_memdup() by g_memdup2_qemu()

2021-09-03 Thread Philippe Mathieu-Daudé
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large value

[PATCH 04/28] accel/tcg: Replace g_memdup() by g_memdup2_qemu()

2021-09-03 Thread Philippe Mathieu-Daudé
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large value

[PATCH 07/28] hw/9pfs: Replace g_memdup() by g_memdup2_qemu()

2021-09-03 Thread Philippe Mathieu-Daudé
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large value

  1   2   3   4   5   >