Re: [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips

[Greg Kurz]

On Thu, 2 Sep 2021 15:09:10 +0200
Cédric Le Goater <c...@kaod.org> wrote:

> Signed-off-by: Cédric Le Goater <c...@kaod.org>
> ---
> 

Reviewed-by: Greg Kurz <gr...@kaod.org>

>  v2: fixed assert value ...
> 
>  hw/ppc/pnv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 03c86508d2f7..71e45515f136 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -723,6 +723,8 @@ static uint64_t pnv_chip_get_ram_size(PnvMachineState 
> *pnv, int chip_id)
>          return QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
>      }
>  
> +    assert(pnv->num_chips > 1);
> +
>      ram_per_chip = (machine->ram_size - 1 * GiB) / (pnv->num_chips - 1);
>      return chip_id == 0 ? 1 * GiB : QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
>  }