Hi Cédric,
On 8/6/21 8:00 PM, Cédric Le Goater wrote:
> It includes support for the POWER10 processor and the QEMU platform.
1/ Can you include the output of 'git shortlog v6.4..820d43c0' here?
>
> Built from submodule.
2/ Could we have a CI job building this, during 6.2 cycle?
(See .gitlab
Signed-off-by: LIU Zhiwei
---
target/riscv/csr.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 9a4ed18ac5..ea62d9e653 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -1422,11 +1422,11 @@ RISCVException riscv_csrr
On 8/9/21 5:37 AM, David Gibson wrote:
> On Fri, Aug 06, 2021 at 08:00:40PM +0200, Cédric Le Goater wrote:
>> It includes support for the POWER10 processor and the QEMU platform.
>>
>> Built from submodule.
>>
>> Signed-off-by: Cédric Le Goater
>
> Applied to ppc-for-6.2, thanks.
FYI asked descr
We are currently in progress of retiring this bug tracker here... could
you please open a new ticket on gitlab instead:
https://gitlab.com/qemu-project/qemu/-/issues
Thanks and sorry for the inconvenience.
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notificat
+Peter for overall style recommendation.
On 8/9/21 8:08 AM, Thomas Huth wrote:
> On 07/08/2021 13.09, Philippe Mathieu-Daudé wrote:
>> We are going to modify this function, fix its style first.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> disas/nios2.c | 53 +---
On 2021/8/6 上午3:09, Richard Henderson wrote:
On 8/4/21 4:53 PM, LIU Zhiwei wrote:
+static bool gen_arith_simm_tl(DisasContext *ctx, arg_i *a,
+ void (*func)(TCGv, TCGv, TCGv))
+{
+ TCGv dest = gpr_dst(ctx, a->rd);
+ TCGv src1 = gpr_src_s(ctx, a->rs1);
+ TC
On 8/7/21 10:25 PM, Alexander Bulekov wrote:
> On 210807 1019, Philippe Mathieu-Daudé wrote:
>> On 8/7/21 12:23 AM, Alexander Bulekov wrote:
>>> Encapsulation offload (offload mode 1) is a valid mode present in the
>>> kernel that isn't implemented in QEMU, yet.
>>>
>>> https://lore.kernel.org/lkml
On 8/8/21 10:04 PM, Guenter Roeck wrote:
> Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched
> the silicon revision for AST2600 to revision A1. On revision A1, the first
> Ethernet interface is operational. Enable it.
Indeed.
I see that commit ba56f464f0c ("ARM: dts: aspe
On 2021/8/6 上午6:17, Richard Henderson wrote:
On 8/4/21 4:53 PM, LIU Zhiwei wrote:
static bool trans_srli(DisasContext *ctx, arg_srli *a)
{
+ if (ctx->uxl32) {
+ return trans_srliw(ctx, a);
+ }
return gen_shifti(ctx, a, tcg_gen_shr_tl);
}
First, trans_srliw begins wit
On 2021/8/6 上午6:18, Richard Henderson wrote:
On 8/4/21 4:53 PM, LIU Zhiwei wrote:
Don't overwrite global source register after
https://lists.gnu.org/archive/html/qemu-riscv/2021-07/msg00058.html.
Signed-off-by: LIU Zhiwei
---
target/riscv/translate.c | 46 +++
Hello Phil,
On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
> Hi Cédric,
>
> On 8/6/21 8:00 PM, Cédric Le Goater wrote:
>> It includes support for the POWER10 processor and the QEMU platform.
>
> 1/ Can you include the output of 'git shortlog v6.4..820d43c0' here?
OK. See attachement.
>>
>> Bu
On Mon, 9 Aug 2021 at 07:45, Cédric Le Goater wrote:
>
> On 8/8/21 10:04 PM, Guenter Roeck wrote:
> > Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched
> > the silicon revision for AST2600 to revision A1. On revision A1, the first
> > Ethernet interface is operational. Enab
On 8/9/21 9:55 AM, Cédric Le Goater wrote:
> Hello Phil,
>
> On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
>> Hi Cédric,
>>
>> On 8/6/21 8:00 PM, Cédric Le Goater wrote:
>>> It includes support for the POWER10 processor and the QEMU platform.
>>
>> 1/ Can you include the output of 'git shortlog
On 8/9/21 10:06 AM, Philippe Mathieu-Daudé wrote:
> On 8/9/21 9:55 AM, Cédric Le Goater wrote:
>> Hello Phil,
>>
>> On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
>>> Hi Cédric,
>>>
>>> On 8/6/21 8:00 PM, Cédric Le Goater wrote:
It includes support for the POWER10 processor and the QEMU plat
On 8/9/21 10:01 AM, Joel Stanley wrote:
> On Mon, 9 Aug 2021 at 07:45, Cédric Le Goater wrote:
>>
>> On 8/8/21 10:04 PM, Guenter Roeck wrote:
>>> Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched
>>> the silicon revision for AST2600 to revision A1. On revision A1, the first
On 8/9/21 10:14 AM, Cédric Le Goater wrote:
> On 8/9/21 10:06 AM, Philippe Mathieu-Daudé wrote:
>> On 8/9/21 9:55 AM, Cédric Le Goater wrote:
>>> Hello Phil,
>>>
>>> On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
Hi Cédric,
On 8/6/21 8:00 PM, Cédric Le Goater wrote:
> It includ
On 8/9/21 10:18 AM, Philippe Mathieu-Daudé wrote:
> On 8/9/21 10:14 AM, Cédric Le Goater wrote:
>> On 8/9/21 10:06 AM, Philippe Mathieu-Daudé wrote:
>>> On 8/9/21 9:55 AM, Cédric Le Goater wrote:
Hello Phil,
On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
> Hi Cédric,
>
diff --git a/tests/qemu-iotests/common.qemu
b/tests/qemu-iotests/common.qemu
index 0fc52d20d7..cbca757b49 100644
--- a/tests/qemu-iotests/common.qemu
+++ b/tests/qemu-iotests/common.qemu
@@ -85,7 +85,12 @@ _timed_wait_for()
timeout=yes
QEMU_STATUS[$h]=0
- while IFS= read -t ${QE
> -Original Message-
> From: Markus Armbruster
> Sent: Saturday, August 7, 2021 7:32 PM
> To: Zhang, Chen
> Cc: Jason Wang ; Eric Blake ;
> Dr. David Alan Gilbert ; qemu-dev de...@nongnu.org>; Daniel P.Berrangé ; Gerd
> Hoffmann ; Li Zhijian ; Lukas
> Straub
> Subject: Re: [PULL V3 f
Fix the following build failure on musl raised since version 6.0.0 and
https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
because musl does not define FALLOC_FL_ZERO_RANGE:
../block/export/fuse.c: In function 'fuse_fallocate':
../block/export/fuse.c:563:23: erro
Cc: th...@redhat.com
Fixes: 4e960974d4ee ("xive: Add trace events")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/519
Signed-off-by: Cédric Le Goater
---
hw/intc/trace-events | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/intc/trace-events b/hw/intc/tr
From: John Snow
Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method
signatures as part of its duplicate checking algorithm. This check does
not listen to pragmas, so the only way to disable it is to turn it off
completely or increase the minimum duplicate lines so that it does
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Acked-by: John Snow
---
python/qemu/machine/qtest.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/qtest.py b/python/q
This series adds the option to attach gdbserver and valgrind
to the QEMU binary running in qemu_iotests.
It also allows to redirect QEMU binaries output of the python tests
to the stdout, instead of a log file.
Patches 1-9 introduce the -gdb option to both python and bash tests,
10-14 extend the
Define -gdb flag and GDB_OPTIONS environment variable
to python tests to attach a gdbserver to each qemu instance.
This patch only adds and parses this flag, it does not yet add
the implementation for it.
if -gdb is not provided but $GDB_OPTIONS is set, ignore the
environment variable.
Signed-off
Remove read timer in test script when GDB_OPTIONS are set,
so that the bash tests won't timeout while running gdb.
The only limitation here is that running a script with gdbserver
will make the test output mismatch with the expected
results, making the test fail.
Signed-off-by: Emanuele Giuseppe
Also add a new _qmp_timer field to the QEMUMachine class.
Let's change the default socket timeout to None, so that if
a subclass needs to add a timer, it can be done by modifying
this private field.
At the same time, restore the timer to be 15 seconds in iotests.py, to
give an upper bound to the
Introduce the "Debugging a test case" section, in preparation
to the additional flags that will be added in the next patches.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
docs/devel/testing.rst | 8
1 file changed, 8 in
As with gdbserver, valgrind delays the test execution, so
the default QMP socket timeout and the generic class
Timeout in iotests.py timeouts too soon.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py |
Attaching gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotest
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index e176a84620..e7e3
If -gdb and -valgrind are both defined, return an error.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iote
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 8359f2ae37..01e1919873 100644
--- a/docs/d
On 03.08.2021 18:05, Michael S. Tsirkin wrote:
On Mon, Jul 19, 2021 at 05:21:38PM +0300, Denis Plotnikov wrote:
On vhost-user-blk migration, qemu normally sends a number of commands
to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
Qemu sends VHOST_USER_SET_FEATURES to enable
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/testing.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 01e1919873..8ebcf85a31 100644
--- a/docs/devel/te
Currently, the check script only parses the option and sets the
VALGRIND_QEMU environmental variable to "y".
Add another local python variable that prepares the command line,
identical to the one provided in the test scripts.
Because the python script does not know in advance the valgrind
PID to a
Using the flag -p, allow the qemu binary to print to stdout.
Also create the common function _close_qemu_log_file() to
avoid accessing machine.py private fields directly and have
duplicate code.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max
When using -valgrind on the script tests, it generates a log file
in $TEST_DIR that is either read (if valgrind finds problems) or
otherwise deleted. Provide the same exact behavior when using
-valgrind on the python tests.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov
On vhost-user-blk migration, qemu normally sends a number of commands
to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and
VHOST_USER_SET_VRING_ADDR per each started ring to enable "used ring"
data logging.
The issue is
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
docs/devel/testing.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 8ebcf85a31..4a0abbf23d 100644
--- a/docs/devel/test
Hi,
> As a side note(not strictly related to this fix) should we continue
> joining reproducer patches with the fixes? In order to test the
> reproducer, you need to cleave the fix off the patch. At the same time
> we don't want to mess up bisection, so does it make sense to have the
> reproduce
On Sat, Aug 07, 2021 at 12:36:13PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann writes:
>
> > Helps making qemu more modular,
> > see commit messages for details.
> >
> > Depends on the "modules: add meta-data database" patch series.
>
> This series is about HMP. Do we have equivalent functi
On Fri, 6 Aug 2021 at 15:43, Alexander Bulekov wrote:
> As a side note(not strictly related to this fix) should we continue
> joining reproducer patches with the fixes? In order to test the
> reproducer, you need to cleave the fix off the patch. At the same time
> we don't want to mess up bisectio
On 8/6/21 4:42 PM, Alexander Bulekov wrote:
> On 210804 1451, Qiang Liu wrote:
>> xlnx_dp_read allows an out-of-bounds read at its default branch because
>> of an improper index.
>>
>> According to
>> https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html
>> (DP Mod
Thank you for all the insightful comments about the separated patches.
This would be my first time to format a serial of patches. Does it
look like below?
[PATCH v3 00/2] title
[PATCH v3 01/2] fix
[PATCH v3 02/2] test
Best,
Qiang
On Mon, Aug 9, 2021 at 11:24 AM Peter Maydell wrote:
>
>
Looks good. Some cosmetics:
On Mon, Aug 09, 2021 at 12:03:30PM +0300, Denis Plotnikov wrote:
> On vhost-user-blk migration, qemu normally sends a number of commands
> to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
> Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging
On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote:
>
nits: please write something in the commit message
> Signed-off-by: LIU Zhiwei
> ---
> target/riscv/csr.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 9a4ed18ac5.
On 210809 1131, Philippe Mathieu-Daudé wrote:
> On 8/6/21 4:42 PM, Alexander Bulekov wrote:
> > On 210804 1451, Qiang Liu wrote:
> >> xlnx_dp_read allows an out-of-bounds read at its default branch because
> >> of an improper index.
> >>
> >> According to
> >> https://www.xilinx.com/html_docs/regis
On 8/9/21 10:50 AM, Fabrice Fontaine wrote:
> Fix the following build failure on musl raised since version 6.0.0 and
> https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
> because musl does not define FALLOC_FL_ZERO_RANGE:
>
> ../block/export/fuse.c: In function
On 8/9/21 10:52 AM, Cédric Le Goater wrote:
> Cc: th...@redhat.com
> Fixes: 4e960974d4ee ("xive: Add trace events")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/519
> Signed-off-by: Cédric Le Goater
> ---
> hw/intc/trace-events | 10 +-
> 1 file changed, 5 insertions(+), 5 de
Le 09/08/2021 à 10:52, Cédric Le Goater a écrit :
> Cc: th...@redhat.com
> Fixes: 4e960974d4ee ("xive: Add trace events")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/519
> Signed-off-by: Cédric Le Goater
> ---
> hw/intc/trace-events | 10 +-
> 1 file changed, 5 insertions(+)
On 8/9/21 11:33 AM, Qiang Liu wrote:
> Thank you for all the insightful comments about the separated patches.
> This would be my first time to format a serial of patches. Does it
> look like below?
> [PATCH v3 00/2] title
> [PATCH v3 01/2] fix
> [PATCH v3 02/2] test
Exactly. Otherwise,
On 2021/8/9 下午5:35, Bin Meng wrote:
On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote:
nits: please write something in the commit message
OK
Signed-off-by: LIU Zhiwei
---
target/riscv/csr.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/riscv/csr.c b/targ
From: Alyssa Ross
The logic before was
if not get_option('gnutls').auto() or have_system
Which is equivalent to
if get_option('gnutls').enabled() or get_option('gnutls').disabled() or
have_system
This means that the check for gnutls is performed even if gnutls is
disabled, wh
The following changes since commit dee64246ded3aa7dbada68b96ce1c64e5bea327d:
Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging (2021-08-06
10:28:33 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-ups
On Tue, 25 Aug 2020 at 20:03, Alistair Francis wrote:
>
> From: Anup Patel
>
> We extend RISC-V virt machine to allow creating a multi-socket
> machine. Each RISC-V virt machine socket is a NUMA node having
> a set of HARTs, a memory instance, a CLINT instance, and a PLIC
> instance. Other device
On 8/9/21 8:12 AM, Thomas Huth wrote:
> On 07/08/2021 13.09, Philippe Mathieu-Daudé wrote:
>> Since commit 12b6e9b27d4 ("disas: Clean up CPUDebug initialization")
>> the disassemble_info->bfd_endian enum is set for all targets in
>> target_disas(). We can directly call print_insn_nios2() and simpli
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 724ce76a0e..a8a601776d 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -539,9 +539,9 @@ static Guest
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 27baf17d6c..2ad8593b82 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -514,7 +514,7 @@ DEFINE_GUI
In case when the function fails to get parent device data,
the parent_dev_info variable will be initialized, but not freed.
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win
See also https://gitlab.com/qemu-project/qemu/-/issues/520
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #520
https://gitlab.com/qemu-project/qemu/-/issues/520
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bu
To prevent memory leaks, always try to free initialized variables.
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 2ad8593b82..724ce76a0e 1
On Mon, Aug 9, 2021 at 5:45 PM LIU Zhiwei wrote:
>
>
> On 2021/8/9 下午5:35, Bin Meng wrote:
> > On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote:
> > nits: please write something in the commit message
> OK
> >
> >> Signed-off-by: LIU Zhiwei
> >> ---
> >> target/riscv/csr.c | 6 +-
> >> 1 fi
https://gitlab.com/qemu-project/qemu/-/issues/520
... thanks!
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #520
https://gitlab.com/qemu-project/qemu/-/issues/520
** Changed in: qemu
Status: Incomplete => Invalid
--
You received this bug notification because you are a memb
Re-opened in the new bug tracker here: https://gitlab.com/qemu-
project/qemu/-/issues/520
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #520
https://gitlab.com/qemu-project/qemu/-/issues/520
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
Fix the following build failure on musl raised since version 6.0.0 and
https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
because musl does not define FALLOC_FL_ZERO_RANGE:
../block/export/fuse.c: In function 'fuse_fallocate':
../block/export/fuse.c:563:23: erro
Hi,
> A PS/2 keyboard has a separate command reply queue that is
> independant of the key queue. This prevents that command replies
> and keyboard input mix. Keyboard command replies take precedence
> over queued keystrokes. A new keyboard command removes any
> remaining command replies from the
Hi Volker
On Sat, Aug 7, 2021 at 11:32 PM Volker Rümelin wrote:
> Since commit 584af1f1d9 (ui/gtk: add a keyboard fifo to the VTE
> consoles) a GTK VTE console chardev backend relies on the
> connected chardev frontend to call qemu_chr_fe_accept_input()
> whenever it can receive new characters.
On Tue, 7 Jul 2015 at 16:49, Alexander Graf wrote:
>
> From: Nikunj A Dadhania
>
> Each hardware instance has a platform unique location code. The OF
> device tree that describes a part of a hardware entity must include
> the “ibm,loc-code” property with a value that represents the location
> co
Mahmoud Mandour writes:
> This post introduces the new TCG plugin `cache` that's used for cache
> modelling. This plugin is a part of my GSoC 2021 participation.
>
> Signed-off-by: Mahmoud Mandour
> ---
>
> v1 -> v2:
> Elaborated some more in the introduction and broken up some
> sente
On 06.08.21 21:16, Eric Blake wrote:
On Fri, Aug 06, 2021 at 11:38:48AM +0200, Max Reitz wrote:
Finalizing the job may cause its AioContext to change. This is noted by
job_exit(), which points at job_txn_apply() to take this fact into
account.
However, job_completed() does not necessarily invo
On 06.08.21 21:39, Eric Blake wrote:
On Fri, Aug 06, 2021 at 11:38:52AM +0200, Max Reitz wrote:
Callers should be able to specify whether they want job_cancel_sync() to
force-cancel the job or not.
In fact, almost all invocations do not care about consistency of the
result and just want the job
Hi,
> +static bool ps2_keyboard_cqueue_needed(void *opaque)
> +{
> +PS2KbdState *s = opaque;
> +
> +return s->common.queue.cwptr != -1; /* the queue is mostly empty */
> +}
> +
> +static const VMStateDescription vmstate_ps2_keyboard_cqueue = {
> +.name = "ps2kbd/command_reply_queue",
On Tue, 29 Jun 2021 at 19:48, Klaus Jensen wrote:
>
> From: Heinrich Schuchardt
>
> The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
> paths. Add a new namespace property "eui64", that provides the user the
> option to specify the EUI-64.
Hi; Coverity complains about so
Hi Alex,
在 2021/8/3 22:19, Alex Williamson 写道:
> On Tue, 3 Aug 2021 16:43:07 +0800
> "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)"
> wrote:
>
>> Hi Alex,
>>
>> We found that the msix_load() will cost 40~50ms if the VF has 60+ interrupts,
>> the following code cost too much for ea
On 8/9/21 11:51 AM, Fabrice Fontaine wrote:
> Fix the following build failure on musl raised since version 6.0.0 and
> https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
> because musl does not define FALLOC_FL_ZERO_RANGE:
>
> ../block/export/fuse.c: In function
On 06.08.21 16:16, Vivek Goyal wrote:
On Fri, Jul 30, 2021 at 05:01:25PM +0200, Max Reitz wrote:
We only need to drop/switch our credentials for the (f)setxattr() call
alone, not for the openat() or fchdir() around it.
(Right now, this may not be that big of a problem, but with inodes being
ide
For U-mode CSRs, read-only check is also needed.
Signed-off-by: LIU Zhiwei
---
target/riscv/csr.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 9a4ed18ac5..360e4bfa33 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/cs
On Mon, Aug 9, 2021 at 6:37 PM LIU Zhiwei wrote:
>
> For U-mode CSRs, read-only check is also needed.
>
> Signed-off-by: LIU Zhiwei
> ---
> target/riscv/csr.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 9a4ed18a
On Sat, 24 Jul 2021 at 10:00, Paolo Bonzini wrote:
>
> This new adaptor visitor takes a single field of the adaptee, and exposes it
> with a different name.
>
> This will be used for QOM alias properties. Alias targets can of course
> have a different name than the alias property itself (e.g. a m
From: Klaus Jensen
Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While
we set most of the fields, we do not explicitly set the rsvd2 field in
the NvmeIdNsDescr header.
Fix this by explicitly zero-initializing the variables.
Reported-by: Coverity (CID 1458835, 1459295 and 1459
On Aug 9 11:18, Peter Maydell wrote:
> On Tue, 29 Jun 2021 at 19:48, Klaus Jensen wrote:
> >
> > From: Heinrich Schuchardt
> >
> > The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
> > paths. Add a new namespace property "eui64", that provides the user the
> > option to
On 8/9/21 12:43 PM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While
> we set most of the fields, we do not explicitly set the rsvd2 field in
> the NvmeIdNsDescr header.
>
> Fix this by explicitly zero-initializing the variables.
On 06.08.21 20:25, Vivek Goyal wrote:
On Fri, Jul 30, 2021 at 05:01:28PM +0200, Max Reitz wrote:
[..]
@@ -1335,12 +1359,18 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t
parent,
return;
}
+res = lo_inode_fd(dir, &dir_fd);
+if (res < 0) {
+saverr
On 06.08.21 16:41, Vivek Goyal wrote:
On Fri, Jul 30, 2021 at 05:01:26PM +0200, Max Reitz wrote:
We are planning to add file handles to lo_inode objects as an
alternative to lo_inode.fd. That means that everywhere where we
currently reference lo_inode.fd, we will have to open a temporary file
d
Hi Kostiantyn,
On 8/9/21 11:48 AM, Kostiantyn Kostiuk wrote:
> Signed-off-by: Kostiantyn Kostiuk
I'm not sure what you are trying to do here, fix a memory leak?
> ---
> qga/commands-win32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qga/commands-win32.c b/qga
On vhost-user-blk migration, qemu normally sends a number of commands
to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and
VHOST_USER_SET_VRING_ADDR per each started ring to enable "used ring"
data logging.
The issue is
On 09.08.2021 12:34, Michael S. Tsirkin wrote:
Looks good. Some cosmetics:
all comments addressed in already sent v4
On Mon, Aug 09, 2021 at 12:03:30PM +0300, Denis Plotnikov wrote:
On vhost-user-blk migration, qemu normally sends a number of commands
to enable logging if VHOST_USER_PROTOCO
On Aug 9 12:47, Philippe Mathieu-Daudé wrote:
> On 8/9/21 12:43 PM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While
> > we set most of the fields, we do not explicitly set the rsvd2 field in
> > the NvmeIdNsDescr header.
>
On Thu, Aug 05, 2021 at 12:00:05PM -0700, Jiang Wang . wrote:
On Tue, Aug 3, 2021 at 11:49 PM Stefano Garzarella wrote:
On Wed, Aug 4, 2021 at 8:41 AM Stefano Garzarella
wrote:
>
> On Tue, Aug 03, 2021 at 11:58:27AM -0700, Jiang Wang . wrote:
> >On Wed, Jul 7, 2021 at 10:27 AM Stefano Garzare
From: Klaus Jensen
Hi Peter,
The following changes since commit dee64246ded3aa7dbada68b96ce1c64e5bea327d:
Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging (2021-08-06
10:28:33 +0100)
are available in the Git repository at:
git://git.infrad
From: Klaus Jensen
Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While
we set most of the fields, we do not explicitly set the rsvd2 field in
the NvmeIdNsDescr header.
Fix this by explicitly zero-initializing the variables.
Reported-by: Coverity (CID 1458835, 1459295 and 1459
On Thu, Aug 05, 2021 at 03:34:26PM -0400, Eduardo Habkost wrote:
> The macro never worked and never will, because the
> AcpiGedX86State type never existed.
>
> Signed-off-by: Eduardo Habkost
> -#define ACPI_GED_X86(obj) \
> -OBJECT_CHECK(AcpiGedX86State, (obj), TYPE_ACPI_GED_X86)
Oops. Lef
On Thu, Aug 05, 2021 at 12:07:02PM -0700, Jiang Wang . wrote:
On Wed, Aug 4, 2021 at 1:13 AM Stefano Garzarella wrote:
On Tue, Aug 03, 2021 at 11:41:32PM +, Jiang Wang wrote:
>Datagram sockets are connectionless and unreliable.
>The sender does not know the capacity of the receiver
>and ma
On 8/9/21 1:27 PM, Philippe Mathieu-Daudé wrote:
> On 8/9/21 11:51 AM, Fabrice Fontaine wrote:
>> Fix the following build failure on musl raised since version 6.0.0 and
>> https://gitlab.com/qemu-project/qemu/-/commit/4ca37a96a75aafe7a37ba51ab1912b09b7190a6b
>> because musl does not define FALLOC_F
On Wed, 17 Feb 2021 at 23:40, Richard Henderson
wrote:
>
> From: Taylor Simpson
>
> Add hexagon to disas/meson.build
> Add disas/hexagon.c
> Add hexagon to include/disas/dis-asm.h
>
> Signed-off-by: Taylor Simpson
> Tested-by: Philippe Mathieu-Daudé
> Reviewed-by: Philippe Mathieu-Daudé
> Mess
On Wed, Aug 04 2021, Matthew Rosato wrote:
> On 8/4/21 8:30 PM, Jared Rossi wrote:
>> I've exercised the error paths and it appears to all work correctly.
>>
>> On 7/19/21 11:09 AM, Jared Rossi wrote:
>>> I will take a look and see if I can exercise the error paths.
>>>
>>> Regards,
>>>
>>> Jare
On oss-fuzz, we build twice, to put together a build that is portable to
the runner containers. On gitlab ci, this is wasteful and contributes to
timeouts on the build-oss-fuzz job. Avoid building twice on gitlab, at
the remote cost of potentially missing some cases that break oss-fuzz
builds.
Sig
On Fri, 18 Dec 2015 at 16:53, Daniel P. Berrange wrote:
>
> Switch from using g_base64_decode over to qbase64_decode
> in order to get error checking of the base64 input data.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Daniel P. Berrange
> ---
> qga/commands-posix.c | 11 +--
> qga/co
If the guest command fails to be spawned, then we would leak the decoded
base64 input used for the command's stdin feed.
Signed-off-by: Daniel P. Berrangé
---
qga/commands.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/commands.c b/qga/commands.c
index a6491d2cf8..
1 - 100 of 273 matches
Mail list logo
