This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/424
** Changed in: qemu
Status: Incomplete => Expired
** Bu
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/425
** Changed in: qemu
Status: Incomplete => Expired
** Bu
Laurent's patch has been included here:
https://gitlab.com/qemu-project/qemu/-/commit/6e1c0d7b951e19c53b8467e8bc4b71ee73a394ea
So I assume we can mark this as fixed now.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member o
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/426
** Changed in: qemu
Status: Incomplete => Expired
** Bu
On 6/17/21 7:37 AM, Gerd Hoffmann wrote:
> Hi,
>
However, please correct me if I'm wrong, I understand that an accelerator
as a
module will add an overhead that some user won't be willing to pay. So,
give
them the option to have built-in accelerators seems a good ide
On Thu, Jun 17, 2021 at 07:22:36AM +0200, Markus Armbruster wrote:
> Valeriy Vdovin writes:
>
> > Introducing new qapi method 'query-kvm-cpuid'. This method can be used to
>
> It's actually a QMP command. There are no "qapi methods".
>
> > get virtualized cpu model info generated by QEMU durin
*** This bug is a duplicate of bug 1022023 ***
https://bugs.launchpad.net/bugs/1022023
This is an automated cleanup. This bug report got closed because it
is a duplicate.
** Changed in: qemu
Importance: Wishlist => Undecided
** Changed in: qemu
Status: New => Expired
--
You rec
*** This bug is a duplicate of bug 1903470 ***
https://bugs.launchpad.net/bugs/1903470
This is an automated cleanup. This bug report got closed because it
is a duplicate.
** Changed in: qemu
Importance: Wishlist => Undecided
** Changed in: qemu
Status: New => Expired
--
You rec
*** This bug is a duplicate of bug 1022023 ***
https://bugs.launchpad.net/bugs/1022023
This is an automated cleanup. This bug report got closed because it
is a duplicate.
** Changed in: qemu
Importance: Wishlist => Undecided
** Changed in: qemu
Status: New => Expired
--
You rec
*** This bug is a duplicate of bug 530077 ***
https://bugs.launchpad.net/bugs/530077
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/490484
Title:
running 64bit client
*** This bug is a duplicate of bug 132720 ***
https://bugs.launchpad.net/bugs/132720
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/206818
Title:
qemulator.py crashed
On Mon, Jun 14 2021, Richard Henderson wrote:
> The PSW_MASK_CC component of psw.mask was not handled properly
> in the creation or restoration of signal frames.
>
>
> r~
>
>
> Richard Henderson (5):
> target/s390x: Expose load_psw and get_psw_mask to cpu.h
> target/s390x: Do not modify cpu s
On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote:
On 16/06/2021 20:34, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/15/21 20:29, BALATON Zoltan wrote:
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented
On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote:
On 16/06/2021 20:26, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/16/21 07:09, BALATON Zoltan wrote:
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented
From: Zhenzhong Duan
Based on the description of error_setg(), the local variable err in
qemu_maybe_daemonize() should be initialized to NULL.
Without fix, the uninitialized *errp triggers assert failure which
doesn't show much valuable information.
Before the fix:
qemu-system-x86_64: ../util/e
On Wed, Jun 16, 2021 at 06:22:19PM +0200, Philippe Mathieu-Daudé wrote:
> Introduce the qcrypto_tls_creds_check_endpoint() helper
> to access QCryptoTLSCreds internal 'endpoint' field.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/crypto/tlscreds.h | 14 ++
> crypto/tlscr
On Wed, Jun 16, 2021 at 06:22:20PM +0200, Philippe Mathieu-Daudé wrote:
> Avoid accessing QCryptoTLSCreds internals by using
> the qcrypto_tls_creds_check_endpoint() helper.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/nbd.c| 6 +++---
> blockdev-nbd.c | 6 +++---
> 2 files change
From: Mark Cave-Ayland
The datasheet sequence tables confirm that when a target selection fails, only
the INTR_DC interrupt flag should be asserted.
Signed-off-by: Mark Cave-Ayland
Fixes: cf47a41e05 ("esp: latch individual bits in ESP_RINTR register")
Message-Id: <20210518212511.21688-2-mark.ca
Using qemu_opts_absorb_qdict, and then checking for any leftover options,
is redundant because there is already a function that does the same,
qemu_opts_from_qdict. qemu_opts_from_qdict consumes the whole dictionary
and therefore can just return an error message if an option fails to validate.
Th
The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2:
Merge remote-tracking branch
'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-06-14
15:59:13 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-ups
From: Mark Cave-Ayland
When processing a command to select a target and send a CDB, the ESP device
maintains a sequence step register so that if an error occurs the host can
determine which part of the selection/CDB submission sequence failed.
The old Linux 2.6 driver is really pedantic here: it
From: Mark Cave-Ayland
The current implementation only resumes DMA transfers when incoming data is
received from the target device, but this is also required for non-DMA transfers
with the next set of non-DMA changes.
Rather than duplicate the DMA/non-DMA dispatch logic in the initial transfer
s
From: Mark Cave-Ayland
Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data
transfers" added a version check for use with VMSTATE_*_TEST macros to allow
migration from older QEMU versions. Unfortunately the version check fails to
work in its current form since if the VMStat
Apple has deprecated sasl.h functions in OS X 10.11. Therefore,
all files that use SASL API need to disable -Wdeprecated-declarations.
Remove the only use that is outside vnc-auth-sasl.c and add the
relevant #pragma GCC diagnostic there.
Signed-off-by: Paolo Bonzini
Message-Id: <20210604120915.2
From: Mark Cave-Ayland
After each PDMA write transfer the MacOS CDROM driver waits until the FIFO is
empty
(i.e. its contents have been written out to the SCSI bus) by polling the FIFO
count
register until it reads 0. This doesn't work with the current PDMA write
implementation which waits unti
From: David Hildenbrand
We can create shared anonymous memory via
"-object memory-backend-ram,share=on,..."
which is, for example, required by PVRDMA for mremap() to work.
Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we
have to use MADV_REMOVE: MADV_DONTNEED will only
The LUN is selected with an IDENTIFY message, and persists
until the next message out phase. Instead of passing it to
do_busid_cmd, store it in ESPState. Because do_cmd can simply
skip the message out phase if cmdfifo_cdb_offset is zero, it
can now be used for the S without ATN cases as well.
Re
From: Maxim Levitsky
When the device doesn't support the VPD block limits page, we emulate it even
for SCSI passthrough.
As a part of the emulation we need to add it to the 'Supported VPD Pages'
The code that does this adds it to the page, but it doesn't increase the length
of the data to be co
From: Mark Cave-Ayland
This commit from nearly 10 years ago is now broken due to the improvements
in esp emulation (or perhaps was never correct). It shows up as a bug
in detecting the CDROM drive under MacOS. The error is caused by the
MacOS CDROM driver sending this CDB with an "S without ATN"
From: Peng Liang
Based on the description of error_setg(), the local variable err in
qemu_init_subsystems() should be initialized to NULL.
Fixes: efd7ab22fb ("vl: extract qemu_init_subsystems")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peng Liang
Message-Id: <20210610131729.3906565-1-liangpen..
From: David Hildenbrand
Let's pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal(),
preparing for passing additional flags.
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Eduardo Habkost for memory backend and machine
core
Signed-off-by: David Hildenbrand
Message-Id: <202105101143
From: David Hildenbrand
Let's drop the "shared" parameter from ram_block_add() and properly
store it in the flags of the ram block instead, such that
qemu_ram_is_shared() properly succeeds on all ram blocks that were mapped
MAP_SHARED.
We'll use this information next to fix some cases with share
From: David Hildenbrand
We want to reserve a memory region without actually populating memory.
Let's factor that out.
Reviewed-by: Igor Kotrasinski
Acked-by: Murilo Opsfelder Araujo
Reviewed-by: Richard Henderson
Reviewed-by: Peter Xu
Acked-by: Eduardo Habkost for memory backend and machine
From: David Hildenbrand
Let's forward ram_flags instead, renaming
memory_region_init_ram_shared_nomigrate() into
memory_region_init_ram_flags_nomigrate().
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Acked-by: Eduardo Habkost for memory backend and machine
core
Signed-off-by: Da
From: Mark Cave-Ayland
The initial implementation of non-DMA transfers was based upon analysis of
traces
from the MacOS toolbox ROM for handling unaligned reads but missed one key
aspect - during a non-DMA transfer from the target, the bus service interrupt
should be raised for every single byte
From: David Hildenbrand
Let's pass flags instead of bools to prepare for passing other flags and
update the documentation of qemu_ram_mmap(). Introduce new QEMU_MAP_
flags that abstract the mmap() PROT_ and MAP_ flag handling and simplify
it.
We expose only flags that are currently supported by
From: David Hildenbrand
Let's factor out calculating the size of the guard page and rename the
variable to make it clearer that this pagesize only applies to the
guard page.
Reviewed-by: Peter Xu
Acked-by: Murilo Opsfelder Araujo
Acked-by: Eduardo Habkost for memory backend and machine
core
From: Mark Cave-Ayland
Commit 799d90d818 "esp: transition to message out phase after SATN and stop
command" added logic to correctly handle extended messages for DMA requests
but not for PDMA requests.
Apply the same logic in esp_do_dma() to do_dma_pdma_cb() so that extended
messages terminated
From: David Hildenbrand
Let's print the new property.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Eduardo Habkost
Reviewed-by: Markus Armbruster
Acked-by: Eduardo Habkost for memory backend and machine
core
Cc: Markus Armbruster
Cc: Eric Blake
Cc:
From: David Hildenbrand
We want to activate memory within a reserved memory region, to make it
accessible. Let's factor that out.
Reviewed-by: Richard Henderson
Acked-by: Murilo Opsfelder Araujo
Reviewed-by: Peter Xu
Acked-by: Eduardo Habkost for memory backend and machine
core
Signed-off-b
From: David Hildenbrand
Let's introduce RAM_NORESERVE, allowing mmap'ing with MAP_NORESERVE. The
new flag has the following semantics:
"
RAM is mmap-ed with MAP_NORESERVE. When set, reserving swap space (or huge
pages if applicable) is skipped: will bail out if not supported. When not
set, the O
From: David Hildenbrand
Let's provide a way to control the use of RAM_NORESERVE via memory
backends using the "reserve" property which defaults to true (old
behavior).
Only Linux currently supports clearing the flag (and support is checked at
runtime, depending on the setting of "/proc/sys/vm/ov
From: Richard Henderson
We will shortly convert lockable.h to _Generic, and we cannot
have two compatible types in the same expansion. Wrap QemuMutex
in a struct, and unwrap in qemu-thread-posix.c.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Thomas Huth
Message-Id:
On Jun 14 21:59, Gollu Appalanaidu wrote:
Add the controller identifiers list CNS 0x13, available list of ctrls
in NVM Subsystem that may or may not be attached to namespaces.
In Identify Ctrl List of the CNS 0x12 and 0x13 no endian conversion
for the nsid field.
These two CNS values shows affe
From: David Hildenbrand
Let's pass in ram flags just like we do with qemu_ram_alloc_from_file(),
to clean up and prepare for more flags.
Simplify the documentation of passed ram flags: Looking at our
documentation of RAM_SHARED and RAM_PMEM is sufficient, no need to be
repetitive.
Reviewed-by:
From: David Hildenbrand
We return information on the currently configured memory backends and
don't configure them, so decribe what the currently set properties
express.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Eduardo Habkost
Reviewed-by: Markus Armbruster
Suggested-by: Markus Armbru
From: Richard Henderson
_Static_assert is part of C11, which is now required.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Thomas Huth
Message-Id: <20210614233143.1221879-9-richard.hender...@linaro.org>
Signed-off-by: Paolo Bonzini
---
configure | 18
From: David Hildenbrand
Let's print the property.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Eduardo Habkost
Reviewed-by: Markus Armbruster
Acked-by: Eduardo Habkost for memory backend and machine
core
Cc: Markus Armbruster
Cc: Eric Blake
Cc: Igo
From: David Hildenbrand
Let's include the property, which can be helpful when debugging,
for example, to spot misuse of MAP_PRIVATE which can result in some ugly
corner cases (e.g., double-memory consumption on shmem).
Use the same description we also use for describing the property.
Reviewed-b
On Wed, Jun 16, 2021 at 06:22:22PM +0200, Philippe Mathieu-Daudé wrote:
> Avoid accessing QCryptoTLSCreds internals by using
> the qcrypto_tls_creds_check_endpoint() helper.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> migration/tls.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletion
From: Lara Lazier
The combination of unset CD and set NW bit in CR0 is illegal.
CR0[63:32] are also reserved and need to be zero.
(AMD64 Architecture Programmer's Manual, V2, 15.5)
Signed-off-by: Lara Lazier
Message-Id: <20210616123907.17765-4-laramglaz...@gmail.com>
Signed-off-by: Paolo Bonzin
From: Lara Lazier
Zero VMRUN intercept and ASID should cause an immediate VMEXIT
during the consistency checks performed by VMRUN.
(AMD64 Architecture Programmer's Manual, V2, 15.5)
Signed-off-by: Lara Lazier
Message-Id: <20210616123907.17765-3-laramglaz...@gmail.com>
Signed-off-by: Paolo Bonzi
From: Richard Henderson
Now that the minimum gcc version is 7.5, we can use C11.
This will allow lots of cleanups to the code, currently
hidden behind macros in include/qemu/compiler.h.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by:
From: David Hildenbrand
RAM_SHARED now also properly indicates shared anonymous memory. Let's check
that flag for anonymous memory as well, to restore the proper mapping.
Fixes: 06329ccecfa0 ("mem: add share parameter to memory-backend-ram")
Reviewed-by: Peter Xu
Signed-off-by: David Hildenbran
On Wed, Jun 16, 2021 at 09:21:45PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/16/21 9:12 PM, Richard Henderson wrote:
> > On 6/16/21 9:22 AM, Philippe Mathieu-Daudé wrote:
> >> Introduce the qcrypto_tls_creds_check_endpoint() helper
> >> to avoid accessing QCryptoTLSCreds internal 'endpoint' field
From: Richard Henderson
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Thomas Huth
Message-Id: <20210614233143.1221879-3-richard.hender...@linaro.org>
Signed-off-by: Paolo Bonzini
---
fpu/softfloat.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions
From: Richard Henderson
All previous users now use C11 _Generic.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Message-Id: <20210614233143.1221879-8-richard.hender...@linaro.org>
Signed-off-by: Paolo Bonzini
---
include/qemu/compiler.h | 40 ---
On Wed, Jun 16, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote:
> Code consuming the "crypto/tlscreds*.h" APIs doesn't need
> to access its internals. Move the structure definitions to
> the "tlscredspriv.h" private header (only accessible by
> implementations). The public headers (in inclu
From: Richard Henderson
Move the declarations from thread-win32.h into thread.h
and remove the macro redirection from thread-posix.h.
This will be required by following cleanups.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Thomas Huth
Message-Id: <20210614233143.122
From: David Hildenbrand
Let's support RAM_NORESERVE via MAP_NORESERVE on Linux. The flag has no
effect on most shared mappings - except for hugetlbfs and anonymous memory.
Linux man page:
"MAP_NORESERVE: Do not reserve swap space for this mapping. When swap
space is reserved, one has the gua
On Wednesday, 16 June, 2021, 04:36:09 pm IST, Marcel Apfelbaum
wrote:
>From: Marcel Apfelbaum
>diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>index f59879e257..dadab4966b 100644
>--- a/hw/rdma/vmw/pvrdma_cmd.c
>+++ b/hw/rdma/vmw/pvrdma_cmd.c
>@@ -38,6 +38,12 @@ static void *pv
From: Richard Henderson
This is both more and less complicated than our expansion
using __builtin_choose_expr and __builtin_types_compatible_p.
The expansion through QEMU_MAKE_LOCKABLE_ doesn't work because
we're not emumerating all of the types within the same _Generic,
which results in errors
On Wed, Jun 16, 2021 at 06:22:21PM +0200, Philippe Mathieu-Daudé wrote:
> Avoid accessing QCryptoTLSCreds internals by using
> the qcrypto_tls_creds_check_endpoint() helper.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> chardev/char-socket.c | 18 ++
> 1 file changed, 6 inser
Hi,
> Do we need to be able to unload modules that we previously loaded? Or is this
> not a realistic requirement?
Surely doable, but it's work and needs infrastructure we don't have
right now. We must be able to unregister everything modules can
register, which is only partly the case today.
From: David Hildenbrand
Let's include the new property. Instead of relying on CONFIG_LINUX,
let's try to unconditionally grab the property and treat errors as
"does not exist".
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Eduardo Habkost
Reviewed-by: Markus Armbruster
Acked-by: Eduardo Ha
Currently it not possible to create tests that have KVM as a hard
requirement on a host that doesn't support KVM for tested target
binary (modulo going through the trouble of compiling out
the offending test case).
Following scenario makes test fail when it's run on non x86 host:
qemu-system-x86
On Tue, 15 Jun 2021 at 21:50, Eric Blake wrote:
>
> The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2:
>
> Merge remote-tracking branch
> 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging
> (2021-06-14 15:59:13 +0100)
>
> are available in the Git rep
Introducing new QMP command 'query-kvm-cpuid'. This command can be used to
get virtualized cpu model info generated by QEMU during VM initialization in
the form of cpuid representation.
Diving into more details about virtual CPU generation: QEMU first parses '-cpu'
command line option. From there
From: David Michael
The meson.build file defines supported_cpus which does not contain
x32, and x32 is not one of meson's stable built-in values:
https://mesonbuild.com/Reference-tables.html#cpu-families
Signed-off-by: David Michael
Message-Id: <878s3jrzm0@gmail.com>
Signed-off-by: Paolo Bo
On 16/06/21 15:46, Max Reitz wrote:
Given that the checkpatch complaint is only a warning, I think it’s OK
to keep the comment as it is here, and perhaps optionally fix all
comments in block_int.h in a follow-up. I don’t think we need to fix
existing comments, but, well, it wouldn’t be wrong.
Alexandre IOOSS writes:
> [[PGP Signed Part:Undecided]]
> On 6/15/21 6:47 PM, Alexandre IOOSS wrote:
>> On 6/15/21 10:22 AM, Alex Bennée wrote:
>>> Mahmoud Mandour writes:
On 14/06/2021 11:01, Alexandre Iooss wrote:
> +}
> +
> +/**
> + * Log instruction execution
> + *
On Wed, Jun 16, 2021 at 02:47:35PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/16/21 1:58 PM, Qiang Liu wrote:
> > Thx. I learned a lot about contributing to QEMU from this discussion!
>
> I think this was a misunderstanding with Gerd, the maintainer.
Indeed.
> Maintainers use some tools to ease
From: Lara Lazier
Added cpu_svm_has_intercept to reduce duplication when checking the
corresponding intercept bit outside of cpu_svm_check_intercept_param
Signed-off-by: Lara Lazier
Message-Id: <20210616123907.17765-2-laramglaz...@gmail.com>
Signed-off-by: Paolo Bonzini
---
target/i386/cpu.h
From: Richard Henderson
Create macros for file+line expansion in qemu_rec_mutex_unlock
like we have for qemu_mutex_unlock.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210614233143.1221879-5-richard.hender...@linaro.org>
Signed-o
From: Lara Lazier
When the selective CR0 write intercept is set, all writes to bits in
CR0 other than CR0.TS or CR0.MP cause a VMEXIT.
Signed-off-by: Lara Lazier
Message-Id: <20210616123907.17765-5-laramglaz...@gmail.com>
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/sysemu/misc_helper.c |
From: Klaus Jensen
Jakub noticed[1] that, when using pin-based interrupts, the device will
unconditionally deasssert when any CQEs are acknowledged. However, the
pin should not be deasserted if other completion queues still holds
unacknowledged CQEs.
The bug is an artifact of commit ca247d35098d
On Wed, Jun 16, 2021 at 12:43:49PM +0200, Philippe Mathieu-Daudé wrote:
> While the SB16 seems to work up to 48000 Hz, the "Sound Blaster Series
> Hardware Programming Guide" limit the sampling range from 4000 Hz to
> 44100 Hz (Section 3-9, 3-10: Digitized Sound I/O Programming, tables
> 3-2 and 3-
On Wed, Jun 16, 2021 at 11:14:11PM +0900, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki
> ---
> audio/audio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 534278edfed..6eba208cdba 100644
> --- a/audio/audio.c
> +++ b/a
On Wed, Jun 16, 2021 at 11:17:21PM +0900, Akihiko Odaki wrote:
> Before commit 7d6948cd98cf5ad8a3458a4ce7fdbcb79bcd1212, it was coded to
> retrieve the initial output stream format settings, modify the frame
> rate, and set again. However, I removed a frame rate modification code by
> mistake in th
On Jun 17 12:08, Klaus Jensen wrote:
From: Klaus Jensen
Jakub noticed[1] that, when using pin-based interrupts, the device will
unconditionally deasssert when any CQEs are acknowledged. However, the
pin should not be deasserted if other completion queues still holds
unacknowledged CQEs.
The bu
On 6/17/21 11:48 AM, Gerd Hoffmann wrote:
> Hi,
>
>> Do we need to be able to unload modules that we previously loaded? Or is
>> this not a realistic requirement?
>
> Surely doable, but it's work and needs infrastructure we don't have
> right now. We must be able to unregister everything modu
Philippe Mathieu-Daudé writes:
> On 6/15/21 4:17 PM, Peter Maydell wrote:
>> On Tue, 15 Jun 2021 at 14:42, Paolo Bonzini wrote:
>>>
>>> The following changes since commit 894fc4fd670aaf04a67dc7507739f914ff4bacf2:
>>>
>>> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request'
On 03/06/21 20:52, Richard Henderson wrote:
On 6/3/21 10:12 AM, Peter Maydell wrote:
+softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c',
'aml-build-stub.c', 'ghes-stub.c'))
softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss)
softmmu_ss.add(when: 'CONFIG_ALL', if_true:
Patchew URL:
https://patchew.org/QEMU/20210617093134.900014-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210617093134.900014-1-pbonz...@redhat.com
Subject: [PULL 00/45] Memory, i386, compilat
On 17/06/2021 19:16, BALATON Zoltan wrote:
On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote:
On 16/06/2021 20:34, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/15/21 20:29, BALATON Zoltan wrote:
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote:
The PAPR platfor
Philippe Mathieu-Daudé writes:
> The --without-default-devices configure option removes the
> 'default=y' from Kconfig files. It is useful to test missing
> Kconfig dependencies for users wanting to have QEMU (system)
> binaries with a particular subset of machines builtin.
>
> If a machine can
You recently started using
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Please consider anorhter Content-Transfer-Encoding instead.
quoted-printable should do.
"Zhang, Chen" writes:
[...]
> No, net-filter is an independent module, although colo must use
Valeriy Vdovin writes:
> On Thu, Jun 17, 2021 at 07:22:36AM +0200, Markus Armbruster wrote:
>> Valeriy Vdovin writes:
>>
>> > Introducing new qapi method 'query-kvm-cpuid'. This method can be used to
>>
>> It's actually a QMP command. There are no "qapi methods".
>>
>> > get virtualized cpu
On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote:
On 17/06/2021 19:16, BALATON Zoltan wrote:
On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote:
On 16/06/2021 20:34, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/15/21 20:29, BALATON Zoltan wrote:
On Tue, 15 Jun 2021
Virgl relies on callbacks provided by the OpenGL display, and such a
display may rely on eglMakeCurrent. eglMakeCurrent will fail if the
given context is current to some other thread. The easiest way to avoid
such a failure is to call the OpenGL display in a single thread. As all
operations except
On 17/06/2021 12.42, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
The --without-default-devices configure option removes the
'default=y' from Kconfig files. It is useful to test missing
Kconfig dependencies for users wanting to have QEMU (system)
binaries with a particular subset of mach
Laurent Vivier writes:
> Le 14/06/2021 à 16:42, Alex Bennée a écrit :
>> Signed-off-by: Alex Bennée
>>
>> ---
>> v2
>> - fix typo in summary :-O
>> ---
>> linux-user/trace-events | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/trace-events b/linux-us
Full series reviewed, all comments addressed.
Corey, could you take this via your tree?
Regards,
Phil.
This is a respin of Zoltan's patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html
Since v4:
- removed assertion in i2c_do_start_transfer (Richard)
- added Richard R-b tags
lm832x_key_event() is specific go LM832x devices, not to the
I2C bus API. Move it out of "i2c.h" to a new header.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i2c/i2c.h | 3 ---
include/hw/input/lm832x.h | 26
Define TYPE_LM8323 in the public "hw/input/lm832x.h"
header and use it in hw/arm/nseries.c.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/input/lm832x.h | 2 ++
hw/arm/nseries.c | 2 +-
hw/input/lm832x.c | 1 -
3 fi
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Reviewed-by: BALATON Zoltan
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/sm501.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 8789722ef27..f276276f7f1 100644
Since its introduction in commit 6fc7f77fd2 i2c_start_transfer()
uses incorrectly the direction of the transfer (the last argument
is called 'is_recv'). Fix by inverting the argument, we now have
is_recv = !is_write.
Fixes: 6fc7f77fd2 ("introduce aux-bus")
Reported-by: BALATON Zoltan
Reviewed-by:
Instead of using the confuse i2c_send_recv(), rewrite to directly
call i2c_recv() & i2c_send(), resulting in code easier to review.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/sm501.c | 9 +
1 file changed, 5 insertions(+)
Other functions from I2C slave API are named "i2c_slave_XXX()".
Follow that pattern with set_address(). Add docstring along.
No logical change.
Patch created mechanically using:
$ sed -i s/i2c_set_slave_address/i2c_slave_set_address/ \
$(git grep -l i2c_set_slave_address)
Reviewed-by: Rich
It took me a while to find this model datasheet, since it is
an OCR scan. Add a reference to save other developers time.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i2c/ppc4xx_i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw
1 - 100 of 413 matches
Mail list logo
