Patchew URL: https://patchew.org/QEMU/20210617093134.900014-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210617093134.900014-1-pbonz...@redhat.com Subject: [PULL 00/45] Memory, i386, compilation, bugfix changes for 2021-06-17 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210617093134.900014-1-pbonz...@redhat.com -> patchew/20210617093134.900014-1-pbonz...@redhat.com Switched to a new branch 'test' 76c1d1c configure: Remove probe for _Static_assert bb7b711 qemu/compiler: Remove QEMU_GENERIC bb5b937 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC f12590d util: Use unique type for QemuRecMutex in thread-posix.h bad1bfa util: Pass file+line to qemu_rec_mutex_unlock_impl cce4c5d util: Use real functions for thread-posix QemuRecMutex bc05aa3 softfloat: Use _Generic instead of QEMU_GENERIC f09e1b8 configure: Use -std=gnu11 e3dddf2 target/i386: Added Intercept CR0 writes check 0d849e8 target/i386: Added consistency checks for CR0 76dcd43 target/i386: Added consistency checks for VMRUN intercept and ASID 567459b target/i386: Refactored intercept checks into cpu_svm_has_intercept b4e527e configure: map x32 to cpu_family x86_64 for meson 8163813 hmp: Print "reserve" property of memory backends with "info memdev" 567770f qmp: Include "reserve" property of memory backends 0512c46 hmp: Print "share" property of memory backends with "info memdev" 11f6aaf qmp: Include "share" property of memory backends f2bf2ce qmp: Clarify memory backend properties returned via query-memdev f4a1776 hostmem: Wire up RAM_NORESERVE via "reserve" property 16cee78 util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux adf9a93 memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap() 1b69bfd util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap() a527698 softmmu/memory: Pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal() 4f00790 softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate() 5289155 softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd() 8edf57d util/mmap-alloc: Factor out activating of memory to mmap_activate() 991926b util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve() c3819fc util/mmap-alloc: Factor out calculation of the pagesize for the guard page 917d149 softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory 9e6a704 softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory 2a1a5ba softmmu/physmem: Mark shared anonymous memory RAM_SHARED f0c8ef8 esp: store lun coming from the MESSAGE OUT phase 689f708 esp: fix migration version check in esp_is_version_5() d2adf20 esp: correctly accumulate extended messages for PDMA 26a1d08 esp: revert 75ef849696 "esp: correctly fill bus id with requested lun" d48286b esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately 195cadb esp: handle non-DMA transfers from the target one byte at a time cbd0dea esp: allow non-DMA callback in esp_transfer_data() initial transfer 6c54d24 esp: only set ESP_RSEQ at the start of the select sequence 1567f98 esp: only assert INTR_DC interrupt flag if selection fails 2bedf0a runstate: Initialize Error * to NULL 51adfa2 block/scsi: correctly emulate the VPD block limits page 72a6110 qemu-config: use qemu_opts_from_qdict 0c0076a vl: Fix an assert failure in error path f427609 vnc: avoid deprecation warnings for SASL on OS X === OUTPUT BEGIN === 1/45 Checking commit f42760961c6d (vnc: avoid deprecation warnings for SASL on OS X) 2/45 Checking commit 0c0076a4935e (vl: Fix an assert failure in error path) 3/45 Checking commit 72a6110a41c2 (qemu-config: use qemu_opts_from_qdict) 4/45 Checking commit 51adfa2fb1de (block/scsi: correctly emulate the VPD block limits page) 5/45 Checking commit 2bedf0a004fd (runstate: Initialize Error * to NULL) 6/45 Checking commit 1567f98b866c (esp: only assert INTR_DC interrupt flag if selection fails) 7/45 Checking commit 6c54d2493304 (esp: only set ESP_RSEQ at the start of the select sequence) 8/45 Checking commit cbd0deae8cff (esp: allow non-DMA callback in esp_transfer_data() initial transfer) 9/45 Checking commit 195cadbab65e (esp: handle non-DMA transfers from the target one byte at a time) 10/45 Checking commit d48286bd0534 (esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately) 11/45 Checking commit 26a1d08d933f (esp: revert 75ef849696 "esp: correctly fill bus id with requested lun") 12/45 Checking commit d2adf20b0668 (esp: correctly accumulate extended messages for PDMA) 13/45 Checking commit 689f70888315 (esp: fix migration version check in esp_is_version_5()) 14/45 Checking commit f0c8ef85d8c3 (esp: store lun coming from the MESSAGE OUT phase) 15/45 Checking commit 2a1a5ba6a929 (softmmu/physmem: Mark shared anonymous memory RAM_SHARED) 16/45 Checking commit 9e6a70412da8 (softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory) 17/45 Checking commit 917d1492b37c (softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory) 18/45 Checking commit c3819fc58a75 (util/mmap-alloc: Factor out calculation of the pagesize for the guard page) WARNING: architecture specific defines should be avoided #33: FILE: util/mmap-alloc.c:87: +#if defined(__powerpc64__) && defined(__linux__) total: 0 errors, 1 warnings, 79 lines checked Patch 18/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/45 Checking commit 991926bca089 (util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()) WARNING: architecture specific defines should be avoided #39: FILE: util/mmap-alloc.c:93: +#if defined(__powerpc64__) && defined(__linux__) total: 0 errors, 1 warnings, 76 lines checked Patch 19/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/45 Checking commit 8edf57d883b5 (util/mmap-alloc: Factor out activating of memory to mmap_activate()) 21/45 Checking commit 5289155a8882 (softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd()) 22/45 Checking commit 4f0079014b3d (softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate()) 23/45 Checking commit a52769898b3e (softmmu/memory: Pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal()) 24/45 Checking commit 1b69bfd71a31 (util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap()) 25/45 Checking commit adf9a9329811 (memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()) 26/45 Checking commit 16cee789337c (util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux) WARNING: architecture specific defines should be avoided #113: FILE: util/mmap-alloc.c:90: +#if defined(__linux__) total: 0 errors, 1 warnings, 108 lines checked Patch 26/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/45 Checking commit f4a1776bf512 (hostmem: Wire up RAM_NORESERVE via "reserve" property) 28/45 Checking commit f2bf2cec1eca (qmp: Clarify memory backend properties returned via query-memdev) 29/45 Checking commit 11f6aaf8fa96 (qmp: Include "share" property of memory backends) 30/45 Checking commit 0512c4667293 (hmp: Print "share" property of memory backends with "info memdev") 31/45 Checking commit 567770f5834f (qmp: Include "reserve" property of memory backends) 32/45 Checking commit 8163813a3ee9 (hmp: Print "reserve" property of memory backends with "info memdev") 33/45 Checking commit b4e527ea0246 (configure: map x32 to cpu_family x86_64 for meson) 34/45 Checking commit 567459bb087d (target/i386: Refactored intercept checks into cpu_svm_has_intercept) 35/45 Checking commit 76dcd43c252c (target/i386: Added consistency checks for VMRUN intercept and ASID) 36/45 Checking commit 0d849e8b36ce (target/i386: Added consistency checks for CR0) 37/45 Checking commit e3dddf2cc81b (target/i386: Added Intercept CR0 writes check) WARNING: Block comments should align the * on each line #27: FILE: target/i386/tcg/sysemu/misc_helper.c:88: + /* + * If we reach this point, the CR0 write intercept is disabled. total: 0 errors, 1 warnings, 15 lines checked Patch 37/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 38/45 Checking commit f09e1b86bc08 (configure: Use -std=gnu11) 39/45 Checking commit bc05aa3683f2 (softfloat: Use _Generic instead of QEMU_GENERIC) ERROR: spaces required around that '*' (ctx:WxO) #26: FILE: fpu/softfloat.c:689: + _Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #26: FILE: fpu/softfloat.c:689: + _Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #27: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #27: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #32: FILE: fpu/softfloat.c:693: + _Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #32: FILE: fpu/softfloat.c:693: + _Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #33: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #33: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #34: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #34: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #43: FILE: fpu/softfloat.c:897: + _Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #43: FILE: fpu/softfloat.c:897: + _Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #44: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #44: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #49: FILE: fpu/softfloat.c:901: + _Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #49: FILE: fpu/softfloat.c:901: + _Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #50: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #50: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #51: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #51: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ total: 20 errors, 0 warnings, 32 lines checked Patch 39/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/45 Checking commit cce4c5d00991 (util: Use real functions for thread-posix QemuRecMutex) WARNING: line over 80 characters #67: FILE: include/qemu/thread.h:34: +int qemu_rec_mutex_trylock_impl(QemuRecMutex *mutex, const char *file, int line); total: 0 errors, 1 warnings, 69 lines checked Patch 40/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 41/45 Checking commit bad1bfa87974 (util: Pass file+line to qemu_rec_mutex_unlock_impl) WARNING: line over 80 characters #31: FILE: include/qemu/thread.h:35: +void qemu_rec_mutex_unlock_impl(QemuRecMutex *mutex, const char *file, int line); total: 0 errors, 1 warnings, 47 lines checked Patch 41/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/45 Checking commit f12590d5a5e1 (util: Use unique type for QemuRecMutex in thread-posix.h) 43/45 Checking commit bb5b9371bfe0 (include/qemu/lockable: Use _Generic instead of QEMU_GENERIC) ERROR: spaces required around that '*' (ctx:WxO) #121: FILE: include/qemu/lockable.h:70: + _Generic((x), QemuLockable *: (x), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #121: FILE: include/qemu/lockable.h:70: + _Generic((x), QemuLockable *: (x), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #122: FILE: include/qemu/lockable.h:71: + void *: qemu_null_lockable(x), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #122: FILE: include/qemu/lockable.h:71: + void *: qemu_null_lockable(x), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #123: FILE: include/qemu/lockable.h:72: + QemuMutex *: qemu_make_lockable(x, QML_OBJ_(x, mutex)), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #123: FILE: include/qemu/lockable.h:72: + QemuMutex *: qemu_make_lockable(x, QML_OBJ_(x, mutex)), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #124: FILE: include/qemu/lockable.h:73: + QemuRecMutex *: qemu_make_lockable(x, QML_OBJ_(x, rec_mutex)), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #124: FILE: include/qemu/lockable.h:73: + QemuRecMutex *: qemu_make_lockable(x, QML_OBJ_(x, rec_mutex)), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #125: FILE: include/qemu/lockable.h:74: + CoMutex *: qemu_make_lockable(x, QML_OBJ_(x, co_mutex)), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #125: FILE: include/qemu/lockable.h:74: + CoMutex *: qemu_make_lockable(x, QML_OBJ_(x, co_mutex)), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #126: FILE: include/qemu/lockable.h:75: + QemuSpin *: qemu_make_lockable(x, QML_OBJ_(x, spin))) ^ ERROR: spaces required around that ':' (ctx:OxW) #126: FILE: include/qemu/lockable.h:75: + QemuSpin *: qemu_make_lockable(x, QML_OBJ_(x, spin))) ^ ERROR: spaces required around that '*' (ctx:WxO) #142: FILE: include/qemu/lockable.h:87: + _Generic((x), QemuLockable *: (x), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #142: FILE: include/qemu/lockable.h:87: + _Generic((x), QemuLockable *: (x), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #143: FILE: include/qemu/lockable.h:88: + QemuMutex *: QML_OBJ_(x, mutex), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #143: FILE: include/qemu/lockable.h:88: + QemuMutex *: QML_OBJ_(x, mutex), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #144: FILE: include/qemu/lockable.h:89: + QemuRecMutex *: QML_OBJ_(x, rec_mutex), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #144: FILE: include/qemu/lockable.h:89: + QemuRecMutex *: QML_OBJ_(x, rec_mutex), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #145: FILE: include/qemu/lockable.h:90: + CoMutex *: QML_OBJ_(x, co_mutex), \ ^ ERROR: spaces required around that ':' (ctx:OxW) #145: FILE: include/qemu/lockable.h:90: + CoMutex *: QML_OBJ_(x, co_mutex), \ ^ ERROR: spaces required around that '*' (ctx:WxO) #146: FILE: include/qemu/lockable.h:91: + QemuSpin *: QML_OBJ_(x, spin)) ^ ERROR: spaces required around that ':' (ctx:OxW) #146: FILE: include/qemu/lockable.h:91: + QemuSpin *: QML_OBJ_(x, spin)) ^ total: 22 errors, 0 warnings, 120 lines checked Patch 43/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 44/45 Checking commit bb7b711069b8 (qemu/compiler: Remove QEMU_GENERIC) 45/45 Checking commit 76c1d1c235e8 (configure: Remove probe for _Static_assert) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210617093134.900014-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
