[PULL 02/17] docs: fix references to docs/devel/atomics.rst

2021-06-02 Thread Thomas Huth
From: Stefano Garzarella Commit 15e8699f00 ("atomics: convert to reStructuredText") converted docs/devel/atomics.txt to docs/devel/atomics.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/atomics.txt/atomics.rst/ $(git grep -l docs/

[PULL 00/17] doc updates and CentOS 7 removal

2021-06-02 Thread Thomas Huth
Hi Peter! The following changes since commit 52848929b70dcf92a68aedcfd90207be81ba3274: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210528-pull-request' into staging (2021-05-30 20:10:30 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-

[PULL 07/17] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé Message-Id: <20210514120415.1368922-3-berra...@redhat.com> Reviewed-by: Thomas Huth Re

[PULL 01/17] docs: fix references to docs/devel/tracing.rst

2021-06-02 Thread Thomas Huth
From: Stefano Garzarella Commit e50caf4a5c ("tracing: convert documentation to rST") converted docs/devel/tracing.txt to docs/devel/tracing.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/tracing.txt/tracing.rst/ $(git grep -l docs

[PULL 05/17] docs: fix references to docs/devel/s390-dasd-ipl.rst

2021-06-02 Thread Thomas Huth
From: Stefano Garzarella Commit cc3d15a5ea ("docs: rstfy s390 dasd ipl documentation") converted docs/devel/s390-dasd-ipl.txt to docs/devel/s390-dasd-ipl.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/s390-dasd-ipl.txt/s390-dasd-i

[PULL 03/17] docs: fix references to docs/devel/build-system.rst

2021-06-02 Thread Thomas Huth
From: Stefano Garzarella Commit a14f0bf165 ("docs: convert build system documentation to rST") converted docs/devel/build-system.txt to docs/devel/build-system.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/build-system.txt/build-

[PULL 04/17] docs: fix references to docs/specs/tpm.rst

2021-06-02 Thread Thomas Huth
From: Stefano Garzarella Commit 6e8a3ff6ed ("docs/specs/tpm: reST-ify TPM documentation") converted docs/specs/tpm.txt to docs/specs/tpm.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/tpm.txt/tpm.rst/ $(git grep -l docs/specs/tpm.

[PULL 12/17] crypto: drop used conditional check

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé The condition being tested has never been set since the day the code was first introduced. Reviewed-by: Willian Rampazzo Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Message-Id: <20210514120415.1368922-8-berra...@redhat.com> Signed-off-by: Thomas H

[PULL 09/17] crypto: drop back compatibility typedefs for nettle

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé Now that we only support modern nettle, we don't need to have local typedefs to mask the real nettle types. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Message-Id: <20210514120415.1368922-5-berra...@redhat.com> Reviewed-by

[PULL 06/17] block/ssh: Bump minimum libssh version to 0.8.7

2021-06-02 Thread Thomas Huth
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. So from the RHEL-7 perspective, we do not have to support libssh v0.7 anymore now. Let's look at the versions from other distributions and operating

[PULL 15/17] configure: bump min required glib version to 2.56

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé The glib version was not previously constrained by RHEL-7 since it rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of these are old enough that they are outside our platform support matrix now.

[PULL 11/17] crypto: bump min gnutls to 3.5.18, dropping RHEL-7 support

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gnutls version Per repology, current shipping versions are: RHEL

[PULL 10/17] crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gcrypt version and assume that HMAC is always supported Per repology, current

[PULL 08/17] crypto: bump min nettle to 3.4, dropping RHEL-7 support

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required nettle version and drop a lot of backwards compatibility code for 2.x series of

[PULL 17/17] configure: bump min required CLang to 6.0 / XCode 10.0

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé Several distros have been dropped since the last time we bumped the minimum required CLang version. Per repology, currently shipping versions are: RHEL-8: 10.0.1 Debian Buster: 7.0.1 openSUSE Leap 15.2: 9.0.1 Ubuntu LTS 18.04: 6.0.0 Ubuntu LTS

[PULL 14/17] tests/docker: drop CentOS 7 container

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Reviewed-by: Thomas Huth Acked-by: Alex Bennée Reviewed-by: Willian Rampazzo Signed-off-by: Daniel P. Berrangé Message

[PULL 16/17] configure: bump min required GCC to 7.5.0

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Buster: 8.3.0 openSUSE Leap 15.2: 7.5.0 Ubuntu LTS 18.04: 7.5.0 Ubuntu LTS 20.

Re: [RFC PATCH 2/5] target/ppc: powerpc_excp: Remove dump_syscall_vectored

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 06:46:46PM -0300, Fabiano Rosas wrote: > This function is identical to dump_syscall, so use the latter for > system call vectored as well. > > Signed-off-by: Fabiano Rosas Applied to ppc-for-6.1, thanks. > --- > target/ppc/excp_helper.c | 14 +- > 1 file cha

[PULL 13/17] tests/vm: convert centos VM recipe to CentOS 8

2021-06-02 Thread Thomas Huth
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé Message-Id: <20210514120415.1368922-9-berra...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Thomas Huth --- tests/vm/centos | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tests/vm/cen

Re: [RFC PATCH 3/5] target/ppc: powerpc_excp: Consolidade TLB miss code

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 06:46:47PM -0300, Fabiano Rosas wrote: > The only difference in the code for Instruction fetch, Data load and > Data store TLB miss errors is that when called from an unsupported > processor (i.e. not one of 602, 603, 603e, G2, 7x5 or 74xx), they > abort with a message speci

Re: [RFC PATCH 1/5] target/ppc: powerpc_excp: Move lpes code to where it is used

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 06:46:45PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas Applied to ppc-for-6.1. > --- > target/ppc/excp_helper.c | 47 +--- > 1 file changed, 25 insertions(+), 22 deletions(-) > > diff --git a/target/ppc/excp_helper.c b/

Re: [PATCH v2 1/2] block-backend: add drained_poll

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 09:05, Sergio Lopez wrote: Allow block backends to poll their devices/users to check if they have been quiesced when entering a drained section. This will be used in the next patch to wait for the NBD server to be completely quiesced. Suggested-by: Kevin Wolf Reviewed-by: Kevin Wolf

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-02 Thread David Gibson
On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: > On Thu, 27 May 2021, David Gibson wrote: > > On Tue, May 25, 2021 at 12:08:45PM +0200, BALATON Zoltan wrote: > > > On Tue, 25 May 2021, David Gibson wrote: > > > > On Mon, May 24, 2021 at 12:55:07PM +0200, BALATON Zoltan wrote: > > >

[PATCH V2 0/2] vhost-vDPA: vq notification map support

2021-06-02 Thread Jason Wang
Hi All: This series tries to implement doorbell mapping support for vhost-vDPA. Tested with virtio-pci vDPA driver. Please review. Changes since V1: - use dev->vq_index to calculate the virtqueue index - remove the unused host_notifier_set Jason Wang (2): vhost-vdpa: skip ram device from the

[PATCH V2 1/2] vhost-vdpa: skip ram device from the IOTLB mapping

2021-06-02 Thread Jason Wang
vDPA is not tie to any specific hardware, for safety and simplicity, vhost-vDPA doesn't allow MMIO area to be mapped via IOTLB. Only the doorbell could be mapped via mmap(). So this patch exclude skip the ram device from the IOTLB mapping. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 1

[PATCH V2 2/2] vhost-vdpa: map virtqueue notification area if possible

2021-06-02 Thread Jason Wang
This patch implements the vq notification mapping support for vhost-vDPA. This is simply done by using mmap()/munmap() for the vhost-vDPA fd during device start/stop. For the device without notification mapping support, we fall back to eventfd based notification gracefully. Signed-off-by: Jason Wa

Re: [PATCH 1/2] vhost-vdpa: don't initialize backend_features

2021-06-02 Thread Jason Wang
Hi Gautam: 在 2021/6/2 下午3:38, Gautam Dawar 写道: Hi Jason, Pls see my comments inline marked by GD>> Regards, Gautam -Original Message- From: Jason Wang Sent: Wednesday, June 2, 2021 9:01 AM To: m...@redhat.com; qemu-devel@nongnu.org Cc: Gautam Dawar ; l...@redhat.com; Jason Wang ; qe

Re: [RFC PATCH] plugins/api: expose symbol lookup to plugins

2021-06-02 Thread Alex Bennée
Mahmoud Mandour writes: > On Tue, Jun 1, 2021 at 4:58 PM Alex Bennée wrote: > > This is a quality of life helper for plugins so they don't need to > re-implement symbol lookup when dumping an address. The strings are > constant so don't need to be duplicated. One minor tweak is to return >

Re: [PATCH v6 12/14] target/ppc: Implement vcfuged instruction

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 02:09:22PM -0700, Richard Henderson wrote: > On 6/1/21 12:35 PM, matheus.fe...@eldorado.org.br wrote: > > +++ b/target/ppc/translate/vector-impl.c.inc > > @@ -0,0 +1,56 @@ > > +/* > > + * Power ISA decode for Vector Facility instructions > > + * > > + * Copyright (c) 2021 In

Re: [PATCH v6 00/14] Base for adding PowerPC 64-bit instructions

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 04:35:14PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > This series provides the basic infrastructure for adding the new 32/64-bit > instructions in Power ISA 3.1 to target/ppc. Applied to ppc-for-6.1. > > v6: > - Rebase on ppc-for-6.1; > - Fix r

Re: [PATCH v6 14/14] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 01:57:25PM -0700, Richard Henderson wrote: > On 6/1/21 12:35 PM, matheus.fe...@eldorado.org.br wrote: > > --- a/target/ppc/translate/fixedpoint-impl.c.inc > > +++ b/target/ppc/translate/fixedpoint-impl.c.inc > > @@ -1,4 +1,4 @@ > > -/* > > +/* > >* Power ISA decode f

Re: [PATCH] target/ppc: fix single-step exception regression

2021-06-02 Thread David Gibson
On Tue, Jun 01, 2021 at 01:27:20PM -0700, Richard Henderson wrote: > On 6/1/21 11:02 AM, Luis Pires wrote: > > +if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) { > > +/* We have not updated nip yet, so do it now */ > > +gen_update_nip(ctx, nip); > > +

Re: [PATCH 2/2] block-copy: refactor copy_range handling

2021-06-02 Thread Stefan Hajnoczi
On Fri, May 28, 2021 at 05:16:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -183,6 +184,7 @@ static BlockCopyTask > *block_copy_task_create(BlockCopyState *s, > .call_state = call_state, > .offset = offset, > .bytes = bytes, > +.copy_range = s->use_copy_ra

Re: [PATCH] target/arm: Mark LDS{MIN,MAX} as signed operations

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > The operands to tcg_gen_atomic_fetch_s{min,max}_i64 must > be signed, so that the inputs are properly extended. > Zero extend the result afterward, as needed. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/364 > Signed-off-by: Richard Henderson Reviewe

Re: [PATCH 0/2] block-copy: small fix and refactor

2021-06-02 Thread Stefan Hajnoczi
On Fri, May 28, 2021 at 05:16:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > This is my suggestion how to refactor block-copy to avoid extra atomic > operations in > "[PATCH v2 0/7] block-copy: protect block-copy internal structures" > > Vladimir Sementsov-Ogievskiy (2): > block

[PATCH 1/9] Add module metadata macros, add qxl module annotations

2021-06-02 Thread Gerd Hoffmann
Stealing an idea from the linux kernel: Place module metadata in an .modinfo elf section. This patch adds macros and qxl module annotations as example. Signed-off-by: Gerd Hoffmann --- include/qemu/module.h | 18 ++ hw/display/qxl.c | 4 2 files changed, 22 insertion

[PATCH 3/9] virtio-gpu module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/vhost-user-gpu-pci.c | 1 + hw/display/vhost-user-gpu.c | 1 + hw/display/vhost-user-vga.c | 1 + hw/display/virtio-gpu-base.c| 1 + hw/display/virtio-gpu-gl.c | 3 +++ hw/display/virtio-gpu-pci-gl.c | 3 +++ hw/display/virtio-gpu-pci.

[PATCH 6/9] usb-redir module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 6a75b0dc4ab2..4ec9326e0582 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -2608,6 +2608,7 @@ static const TypeInfo usbredir_dev_info = {

[PATCH 2/9] add qemu-modinfo utility

2021-06-02 Thread Gerd Hoffmann
For now only dump metadata. TODO: * store in some file format (json?). * make qemu parse it, replace hard-coded lists in util/module.c * fix windows (seems to not have glob). * do we need non-elf support? Signed-off-by: Gerd Hoffmann --- qemu-modinfo.c | 182

[PATCH 0/9] [RFC] store module metadata in .modinfo elf section

2021-06-02 Thread Gerd Hoffmann
This patch series stores module metadata in a .modinfo elf section and adds a utility to read it. For now the utility just prints the meta data. The plan is to store this in some file and have qemu read it. Background is that the hard-coded lists in util/module.c are somewhat ugly and also would

[PATCH 4/9] chardev module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- chardev/baum.c | 1 + chardev/spice.c | 4 2 files changed, 5 insertions(+) diff --git a/chardev/baum.c b/chardev/baum.c index 5deca778bc44..79d618e35045 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -680,6 +680,7 @@ static const TypeInfo char_braille

[PATCH 5/9] audio module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- audio/spiceaudio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index 999bfbde47c5..a8d370fe6f31 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -317,3 +317,5 @@ static void register_audio_spice(void)

[PATCH 8/9] ui module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/egl-headless.c | 4 ui/gtk.c | 4 ui/sdl2.c | 4 ui/spice-app.c| 3 +++ ui/spice-core.c | 4 5 files changed, 19 insertions(+) diff --git a/ui/egl-headless.c b/ui/egl-headless.c index da377a74af69..bb94deb568c0 100644

[PATCH 9/9] s390x module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/s390x/virtio-ccw-gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/s390x/virtio-ccw-gpu.c b/hw/s390x/virtio-ccw-gpu.c index 75a9e4bb3908..5868a2a07093 100644 --- a/hw/s390x/virtio-ccw-gpu.c +++ b/hw/s390x/virtio-ccw-gpu.c @@ -59,6 +59,7 @@ static

[PATCH 7/9] ccid module annotations

2021-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-emulated.c | 1 + hw/usb/ccid-card-passthru.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 5c76bed77aa0..6c8c0355e099 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/cc

Re: [PATCH v2 1/2] GitLab: Add "Bug" issue reporting template

2021-06-02 Thread Stefan Hajnoczi
On Fri, May 21, 2021 at 01:38:17PM -0400, John Snow wrote: > diff --git a/.gitlab/issue_templates/bug.md b/.gitlab/issue_templates/bug.md > new file mode 100644 > index 000..67a02a3ffcf > --- /dev/null > +++ b/.gitlab/issue_templates/bug.md > @@ -0,0 +1,61 @@ > + > + > +## Host environment

Re: [PATCH v7 04/27] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > As noted by qemu-plugins.h, enum qemu_plugin_cb_flags is > currently unused -- plugins can neither read nor write > guest registers. No objection to this - although we hopefully will introduce the ability to read registers at some point. I saw no indication that the

Re: [PATCH v7 27/27] tests/tcg: Increase timeout for TCI

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > The longest test at the moment seems to be a (slower) > aarch64 host, for which test-mmap takes 64 seconds. > > Reviewed-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > configure | 3 +++ > tests/tc

Re: [PATCH v2 2/2] GitLab: Add "Feature Request" issue template.

2021-06-02 Thread Stefan Hajnoczi
On Fri, May 21, 2021 at 01:38:18PM -0400, John Snow wrote: > Based on Peter Krempa's libvirt template, feature.md. > > CC: Peter Krempa > Signed-off-by: John Snow > --- > .gitlab/issue_templates/feature_request.md | 32 ++ > 1 file changed, 32 insertions(+) > create mode 10

Re: [RFC v4 01/14] target/s390x: meson: add target_user_arch

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana > Si

Re: [RFC v4 06/14] target/s390x: start moving TCG-only code to tcg/

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > move everything related to translate, as well as HELPER code in tcg/ > > mmu_helper.c stays put for now, as it contains both TCG and KVM code. > > The internal.h file is renamed to s390x-internal.h, because of the > risk of collision with other files w

Re: [PATCH v2 01/26] s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling

2021-06-02 Thread David Hildenbrand
On 01.06.21 23:27, Richard Henderson wrote: On 5/17/21 7:27 AM, David Hildenbrand wrote: @@ -634,6 +664,9 @@ uint64_t HELPER(clfxb)(CPUS390XState *env, uint64_t h, uint64_t l, uint32_t m34) s390_restore_bfp_rounding_mode(env, old_mode); handle_exceptions(env, xxc_from_m34(m34),

Re: [RFC v3 17/29] vhost: Shadow virtqueue buffers forwarding

2021-06-02 Thread Jason Wang
在 2021/5/20 上午12:28, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. The exposed addresses are the qemu's virtual address, so devices with IOMMU that does not allow full mapping of qemu's address space does not work at the moment. Also for simplicity it onl

Re: [RFC v3 25/29] vhost: Add custom IOTLB translations to SVQ

2021-06-02 Thread Jason Wang
在 2021/5/20 上午12:28, Eugenio Pérez 写道: Use translations added in IOVAReverseMaps in SVQ if the vhost device does not support the mapping of the full qemu's virtual address space. In other cases, Shadow Virtqueue still uses the qemu's virtual address of the buffer pointed by the descriptor, whic

Re: [RFC v3 00/29] vDPA software assisted live migration

2021-06-02 Thread Jason Wang
在 2021/5/20 上午12:28, Eugenio Pérez 写道: This series enable shadow virtqueue for vhost-vdpa devices. This is a new method of vhost devices migration: Instead of relay on vhost device's dirty logging capability, SW assisted LM intercepts dataplane, forwarding the descriptors between VM and device.

Re: [RFC v4 07/14] target/s390x: move sysemu-only code out to cpu-sysemu.c

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/cpu-sysemu.c | 304 ++ > target/s390x/cpu.c| 282 ++- > target/s390x/meson.build | 1 + >

Re: [RFC v4 08/14] target/s390x: split cpu-dump from helper.c

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: Please add a line as to *why* you are splitting this off; that is not clear if you look at this change individually. > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/cpu-dump.c | 131 +++

Re: [RFC v4 09/14] target/s390x: make helper.c sysemu-only

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > Now that we have moved cpu-dump functionality out of helper.c, > we can make the module sysemu-only. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/helper.c| 4 > target/s390x/meson.build | 2 +- > 2 f

Re: [RFC v5 1/6] qmp: add QMP command x-debug-query-virtio

2021-06-02 Thread Jonah Palmer
On 3/24/21 2:31 PM, Dr. David Alan Gilbert wrote: * Jonah Palmer (jonah.pal...@oracle.com) wrote: From: Laurent Vivier --- /dev/null +++ b/qapi/virtio.json @@ -0,0 +1,68 @@ +## +# = Virtio devices +## + +## +# @VirtioType: +# +# An enumeration of Virtio device types. +# +# Since: 6.0 +##

Re: [PATCH v7 11/27] tcg/tci: Use ffi for calls

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > This requires adjusting where arguments are stored. > Place them on the stack at left-aligned positions. > Adjust the stack frame to be at entirely positive offsets. > > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richar

[RFC PATCH] tests/vm: expose --source-path to scripts to find extra files

2021-06-02 Thread Alex Bennée
Currently the centos8 image expects to run an in-src build to find the kick starter file. Fix this. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 1 + tests/vm/basevm.py| 4 tests/vm/centos.aarch64 | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/

Re: [RFC v4 14/14] MAINTAINERS: update s390x directories

2021-06-02 Thread Philippe Mathieu-Daudé
On 5/24/21 4:52 AM, Cho, Yu-Chen wrote: > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directories: > > target/s390x/kvm/ > target/s390x/tcg/ > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > MAINTAINERS | 8 +++- > 1 file changed, 3 i

Re: [RFC v4 10/14] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > this will allow to remove the kvm stubs. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/diag.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/s390x/diag.c b/target/s390x/diag.

Re: [PULL 00/24] x86 queue, 2021-06-01

2021-06-02 Thread Peter Maydell
On Tue, 1 Jun 2021 at 19:10, Eduardo Habkost wrote: > > The following changes since commit 52848929b70dcf92a68aedcfd90207be81ba3274: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20210528-pull-request' into staging (2021-05-30 > 20:10:30 +0100) > > are available in the Git reposi

Re: [PATCH] xio3130_downstream: Set the maximum link width and speed

2021-06-02 Thread Haozhong Zhang
On 05/28/21 01:06, Haozhong Zhang wrote: > The current implementation leaves 0 in the maximum link width (MLW) > and speed (MLS) fields of the PCI_EXP_LNKCAP register of a xio3130 > downstream port device. As a consequence, when that downstream port > negotiates the link width and speed with its do

Re: [RFC v4 11/14] target/s390x: remove kvm-stub.c

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > all function calls are protected by kvm_enabled(), > so we should not need the stubs. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/kvm-stub.c | 126 --- > target/s390x/mes

Re: [RFC PATCH] plugins/api: expose symbol lookup to plugins

2021-06-02 Thread Philippe Mathieu-Daudé
On 6/2/21 10:43 AM, Alex Bennée wrote: > > Mahmoud Mandour writes: > >> On Tue, Jun 1, 2021 at 4:58 PM Alex Bennée wrote: >> >> This is a quality of life helper for plugins so they don't need to >> re-implement symbol lookup when dumping an address. The strings are >> constant so don't need

Re: [RFC v4 14/14] MAINTAINERS: update s390x directories

2021-06-02 Thread Cornelia Huck
On Mon, May 24 2021, "Cho, Yu-Chen" wrote: > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directories: > > target/s390x/kvm/ > target/s390x/tcg/ > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > MAINTAINERS | 8 +++- > 1 file changed,

Re: [PATCH] target/i386/sev: Ensure sev_fw_errlist is sync with update-linux-headers

2021-06-02 Thread Philippe Mathieu-Daudé
This patch was supposed to go via Eduardo's tree but he missed it, can it go via qemu-trivial instead? On 2/19/21 7:01 PM, Philippe Mathieu-Daudé wrote: > Ensure sev_fw_errlist[] is updated after running > the update-linux-headers.sh script. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Base

Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events

2021-06-02 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 3/18/21 4:39 PM, Philippe Mathieu-Daudé wrote: > ping? > > On 3/7/21 8:48 AM, Philippe Mathieu-Daudé wrote: >> MemoryRegion names is cached on first call to memory_region_name(), >> so displaying the name is trace events is cheap. Add it for read / >> write ops. >> >> Sign

Re: GSoC Intro - TUI interface for QMP

2021-06-02 Thread Bruno Piazera Larsen
On 24/05/2021 14:34, John Snow wrote: On 5/24/21 9:32 AM, Stefan Hajnoczi wrote: On Sat, May 22, 2021 at 12:32:00AM +0530, Niteesh G. S. wrote: Welcome Niteesh :) I look forward to working with you this summer. By end of this summer, I would like to get a basic TUI with some desirable feat

Re: [PATCH v2 01/28] softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_float_to_uint. Reimplement > float128_to_uint{32,64}{_round_to_zero} with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 02/28] softfloat: Move int_to_float to softfloat-parts.c.inc

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_sint_to_float. > Reimplement int{32,64}_to_float128 with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [RFC v4 11/14] target/s390x: remove kvm-stub.c

2021-06-02 Thread Thomas Huth
On 02/06/2021 12.44, Cornelia Huck wrote: On Mon, May 24 2021, "Cho, Yu-Chen" wrote: all function calls are protected by kvm_enabled(), so we should not need the stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/kvm-stub.c | 126 --

Re: [RFC v5 1/6] qmp: add QMP command x-debug-query-virtio

2021-06-02 Thread Dr. David Alan Gilbert
* Jonah Palmer (jonah.pal...@oracle.com) wrote: > > On 3/24/21 2:31 PM, Dr. David Alan Gilbert wrote: > > * Jonah Palmer (jonah.pal...@oracle.com) wrote: > > > From: Laurent Vivier > > > > > > > > > > --- /dev/null > > > +++ b/qapi/virtio.json > > > @@ -0,0 +1,68 @@ > > > +## > > > +# = Virtio

Re: [PATCH v2 03/28] softfloat: Move uint_to_float to softfloat-parts.c.inc

2021-06-02 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_uint_to_float. > Reimplement uint64_to_float128 with FloatParts128. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 83 --- > fpu/softfloat-parts.c.inc | 23 +++ > 2 files change

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-02 Thread Andrew Jones
On Wed, Jun 02, 2021 at 11:09:32AM +1000, Gavin Shan wrote: > Hi Drew, > > On 6/1/21 5:50 PM, Andrew Jones wrote: > > On Tue, Jun 01, 2021 at 03:30:04PM +0800, Gavin Shan wrote: > > > We possibly populate empty nodes where memory isn't included and might > > > be hot added at late time. The FDT me

Re: [PATCH v6 01/19] i386: keep hyperv_vendor string up-to-date

2021-06-02 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Apr 22, 2021 at 06:11:12PM +0200, Vitaly Kuznetsov wrote: >> When cpu->hyperv_vendor is not set manually we default to "Microsoft Hv" >> and in 'hv_passthrough' mode we get the information from the host. This >> information is stored in cpu->hyperv_vendor_id[] ar

Re: [PATCH 2/2] block-copy: refactor copy_range handling

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 12:12, Stefan Hajnoczi wrote: On Fri, May 28, 2021 at 05:16:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -183,6 +184,7 @@ static BlockCopyTask *block_copy_task_create(BlockCopyState *s, .call_state = call_state, .offset = offset, .bytes = bytes, +

Re: [PATCH v2 0/2] nbd/server: Quiesce server on drained section

2021-06-02 Thread Kevin Wolf
Am 02.06.2021 um 08:05 hat Sergio Lopez geschrieben: > Before switching between AioContexts we need to make sure that we're > fully quiesced ("nb_requests == 0" for every client) when entering the > drained section. Otherwise, coroutines may be run in the wrong context > after the switch, leading t

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 09:05, Sergio Lopez wrote: Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the drained section. To do this, we set "quiescing = true" for every client on ".drained_begin" to prevent new coroutines

Re: [PATCH v4 2/8] hw/pxb: Add a bypass iommu property

2021-06-02 Thread Eric Auger
Hi Xingang, On 5/25/21 5:49 AM, Wang Xingang wrote: > From: Xingang Wang > > This add a bypass_iommu property for pci_expander_bridge. > The property can be used as: > qemu -device pxb-pcie,bus_nr=0x10,addr=0x1,bypass_iommu=true > > Signed-off-by: Xingang Wang Reviewed-by: Eric Auger Eric > --

Re: [PATCH v4 1/8] hw/pci/pci_host: Allow bypass iommu for pci host

2021-06-02 Thread Eric Auger
Hi Xingang, On 5/25/21 5:49 AM, Wang Xingang wrote: > From: Xingang Wang > > This add a bypass_iommu property for pci host, which indicates > whether devices attached to the pci root bus will bypass iommu. > In pci_device_iommu_address_space(), add a bypass_iommu check > to avoid getting iommu ad

Re: [PATCH 0/2] block-copy: small fix and refactor

2021-06-02 Thread Kevin Wolf
Am 02.06.2021 um 11:13 hat Stefan Hajnoczi geschrieben: > On Fri, May 28, 2021 at 05:16:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > This is my suggestion how to refactor block-copy to avoid extra atomic > > operations in > > "[PATCH v2 0/7] block-copy: protect block-copy i

Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 15:38, Valeriy Vdovin wrote: Introducing new qapi method 'query-kvm-cpuid'. This method can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. [..] "ebx": 0, }, { "eax": 13, "edx": 12313841

Re: [PATCH v4 3/8] hw/arm/virt: Add a machine option to bypass iommu for primary bus

2021-06-02 Thread Eric Auger
Hi Xingang, On 5/25/21 5:50 AM, Wang Xingang wrote: > From: Xingang Wang > > This add a bypass_iommu option for arm virt machine, > the option can be used in this manner: > qemu -machine virt,iommu=smmuv3,bypass_iommu=true This still looks confusing to me. On one hand we say that for the virt mac

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-02 Thread BALATON Zoltan
On Wed, 2 Jun 2021, David Gibson wrote: On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: On Thu, 27 May 2021, David Gibson wrote: On Tue, May 25, 2021 at 12:08:45PM +0200, BALATON Zoltan wrote: On Tue, 25 May 2021, David Gibson wrote: On Mon, May 24, 2021 at 12:55:07PM +0200, B

Re: [PATCH v4] docs/secure-coding-practices: Describe how to use 'null-co' block driver

2021-06-02 Thread Kevin Wolf
Am 01.06.2021 um 18:25 hat Philippe Mathieu-Daudé geschrieben: > Document that security reports must use 'null-co,read-zeroes=on' > because otherwise the memory is left uninitialized (which is an > on-purpose performance feature). > > Reviewed-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Phi

Re: [RFC PATCH 5/5] target/ppc: powerpc_excp: Move interrupt raising code to QOM

2021-06-02 Thread Bruno Piazera Larsen
On 01/06/2021 18:46, Fabiano Rosas wrote: This patch introduces a new way to dispatch the emulated interrupts in powerpc_excp. It leverages the QEMU object model to store the implementations for each interrupt and link them to their identifier from POWERPC_EXCP enum. The processor-specific code

DROP Re: [PATCH v3 00/35] block: publish backup-top filter

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
Actually, I should rebase it now on Kevin's block branch. So, ignore this, I'll resend. 01.06.2021 19:49, Vladimir Sementsov-Ogievskiy wrote: Hi all! v3: Keep x-perf.copy-range backup option. So, additional function is added to set copy_range in block-copy after creation. And if we do so, it'

Re: [RFC PATCH 02/12] exec/memattrs: Add attribute/error for address alignment

2021-06-02 Thread Stefan Hajnoczi
On Thu, May 20, 2021 at 01:09:09PM +0200, Philippe Mathieu-Daudé wrote: > A bus master might specify the 'aligned' attribute to enforce > a transaction using aligned address. If the address is not > aligned, the accessor will return MEMTX_UNALIGNED_ERROR. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [RFC PATCH 12/12] hw/virtio: Display error if vring flag field is not aligned

2021-06-02 Thread Stefan Hajnoczi
On Thu, May 20, 2021 at 01:09:19PM +0200, Philippe Mathieu-Daudé wrote: > { > VRingMemoryRegionCaches *caches = vring_get_region_caches(vq); > hwaddr pa = offsetof(VRingAvail, flags); > +MemTxAttrs attrs = { .aligned = 1 }; > +MemTxResult res; > > if (!caches) { >

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Sergio Lopez
On Wed, Jun 02, 2021 at 03:06:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2021 09:05, Sergio Lopez wrote: > > Before switching between AioContexts we need to make sure that we're > > fully quiesced ("nb_requests == 0" for every client) when entering the > > drained section. > > > > To

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 15:44, Sergio Lopez wrote: On Wed, Jun 02, 2021 at 03:06:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: 02.06.2021 09:05, Sergio Lopez wrote: Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the d

[PATCH] s390x/kvm: remove unused gs handling

2021-06-02 Thread Cornelia Huck
With commit 0280b3eb7c05 ("s390x/kvm: use cpu model for gscb on compat machines"), we removed any calls to kvm_s390_get_gs() in favour of a different mechanism. Let's remove the unused kvm_s390_get_gs(), and with it the now unneeded cap_gs as well. Signed-off-by: Cornelia Huck --- target/s390x/

[PATCH v2] target/ppc: fix single-step exception regression

2021-06-02 Thread Luis Pires
Commit 6086c75 (target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN) broke the generation of exceptions when CPU_SINGLE_STEP or CPU_BRANCH_STEP were set, due to nip always being reset to the address of the current instruction. This fix leaves nip untouched when generating the exception. Si

Re: [PATCH v3 5/5] blkdebug: protect rules and suspended_reqs with a lock

2021-06-02 Thread Emanuele Giuseppe Esposito
On 01/06/2021 10:39, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 17:50, Emanuele Giuseppe Esposito wrote: Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito ---   block/blkdebug.c | 53   1 file changed, 40 insertions(

Re: [PATCH v4 5/8] hw/pci: Add pci_bus_range to get bus number range

2021-06-02 Thread Eric Auger
Hi Xingang, On 5/25/21 5:50 AM, Wang Xingang wrote: > From: Xingang Wang > > This helps to get the bus number range of a pci bridge hierarchy. > > Signed-off-by: Xingang Wang > --- > hw/pci/pci.c | 15 +++ > include/hw/pci/pci.h | 1 + > 2 files changed, 16 insertions(+) >

Re: [PATCH] s390x/kvm: remove unused gs handling

2021-06-02 Thread Thomas Huth
On 02/06/2021 14.50, Cornelia Huck wrote: With commit 0280b3eb7c05 ("s390x/kvm: use cpu model for gscb on compat machines"), we removed any calls to kvm_s390_get_gs() in favour of a different mechanism. Let's remove the unused kvm_s390_get_gs(), and with it the now unneeded cap_gs as well. Sign

[PATCH v4 00/35] block: publish backup-top filter

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
Hi all! v4: rebase on Kevin's block branch v3: Keep x-perf.copy-range backup option. So, additional function is added to set copy_range in block-copy after creation. And if we do so, it's better to set "compress" option same way instead of handling x-deprecated-compress option. 8: rebased on no

  1   2   3   4   >