Re: [RFC v9 24/29] hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA invalidation

2021-05-13 Thread Kunkun Jiang
Hi Eric, On 2021/4/11 20:09, Eric Auger wrote: Let's propagate the leaf attribute throughout the invalidation path. This hint is used to reduce the scope of the invalidations to the last level of translation. Not enforcing it induces large performance penalties in nested mode. Signed-off-by: Er

Re: [RFC PATCH v2 2/6] hw/arm/virt: DT: Add cpu-map

2021-05-13 Thread wangyanan (Y)
On 2021/5/13 14:58, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:41PM +0800, Yanan Wang wrote: From: Andrew Jones Support device tree CPU topology descriptions. Signed-off-by: Andrew Jones Signed-off-by: Yanan Wang --- hw/arm/virt.c | 41

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

2021-05-13 Thread Laurent Vivier
Le 13/05/2021 à 08:11, Katsuhiro Ueno a écrit : > Ping. cc Gerd > 2021-04-27 11:02 Katsuhiro Ueno : >> >> Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN, >> RO, and YEN. Before this commit, these keys did not work as expected >> when a jp106 keyboard was connected to the

Re: [Phishing Risk] [External] Re: [Virtio-fs] vhost-user reconnection and crash recovery

2021-05-13 Thread Jiachen Zhang
Hi Stefan and Sebastien, I think I should give some background context from my perspective. For the virtiofsd crash reconnection (recovery) to QEMU, as said by Stefan, we discussed the possible implementation on the bi-weekly virtio-fs call. I had also sent an RFC patch to the virtio-fs mail-list

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-13 Thread Gautam Dawar
https://qemu-devel.nongnu.narkive.com/jUimpLt0/patch-vhost-net-initialize-acked-features-to-a-safe-value-during-ack This review of a patch that introduced "acked_features = backend_features" behaviour suggests that acked_features should be 0 by default, but it ended up pushing it as it is now (as

Re: [Virtio-fs] host-user reconnection and crash recovery

2021-05-13 Thread Dr. David Alan Gilbert
* Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > Hi Stefan and Sebastien, > > I think I should give some background context from my perspective. > > For the virtiofsd crash reconnection (recovery) to QEMU, as said by > Stefan, we discussed the possible implementation on the bi-weekly

[RFC PATCH 0/9] Initial support for machine creation via QMP

2021-05-13 Thread Mirela Grujic
The direction for this work has been set in the discussion thread: "About creating machines on the command line" in January/February 2021: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01839.html https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01070.html To customize a machine

[RFC PATCH 1/9] vl: Allow finer control in advancing machine through phases

2021-05-13 Thread Mirela Grujic
In addition to the existing preconfig approach, which allows configuring the machine via QMP before the machine is initialized, we need the ability to configure the machine right after it's initialized. This patch will enable doing that in a scalable fashion as follows. The basic idea is to group

[RFC PATCH 3/9] rename MachineInitPhase enumeration constants

2021-05-13 Thread Mirela Grujic
This renaming is a second phase in getting the code ready for defining MachineInitPhase in qapi (enumeration constants are going to be generated and prefixed with a name derived from the enumeration type, i.e. MACHINE_INIT_PHASE_. Signed-off-by: Mirela Grujic --- include/hw/qdev-core.h | 10

[RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command

2021-05-13 Thread Mirela Grujic
The command takes the target initialization phase as the argument and triggers QEMU to advance the machine to the target phase (i.e. execute all initialization steps required to enter the target phase). This command would be used as an alternative to 'next-machine-phase' if it's more convenient to

[RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-13 Thread Mirela Grujic
Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that will query current machine init phase. Since in the existing definition of enum Machi

[RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command

2021-05-13 Thread Mirela Grujic
The command returns current machine initialization phase. >From now on, the MachineInitPhase enum is generated. Signed-off-by: Mirela Grujic --- qapi/machine.json | 54 ++ include/hw/qdev-core.h | 29 +--- hw/core/machine-qmp-cmds.

[RFC PATCH 8/9] qapi: Introduce 'allow-init-config' option

2021-05-13 Thread Mirela Grujic
This option will be used to select the commands which are allowed to execute during the MACHINE_INIT_PHASE_INITIALIZED machine phase. Signed-off-by: Mirela Grujic --- docs/sphinx/qapidoc.py | 2 +- include/qapi/qmp/dispatch.h | 1 + softmmu/qdev-monitor.c | 5 + scripts/qapi/com

[RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command

2021-05-13 Thread Mirela Grujic
This command will be used to control via QMP the advancing of machine through initialization phases. The feature is needed to enable the machine configuration via QMP. The command triggers QEMU to advance the machine to the next init phase, i.e. to execute initialization steps required to enter th

[RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability

2021-05-13 Thread Mirela Grujic
The existing code had to be restructured to make room for adding checks that are specific to the machine phases. The fix is related to the way that commands with the 'allow-preconfig' option are treated. Commands labelled with the 'allow-preconfig' option were meant to be allowed during the 'prec

[RFC PATCH 9/9] qapi: Allow some commands to be executed in machine 'initialized' phase

2021-05-13 Thread Mirela Grujic
The following commands are allowed to execute during the machine 'initialized' phase (enabled with 'allow-init-config' option): 1) query-machine-phase 2) next-machine-phase 3) advance-machine-phase 3) device_add Note: for device_add command in qdev.json adding the 'allow-init-config' option has no

Re: [PATCH 26/72] softfloat: Convert float128_silence_nan to parts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > This is the minimal change that also introduces float128_params, > float128_unpack_raw, and float128_pack_raw without running into > unused symbol Werrors. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c| 96

Re: [External] Re: [Virtio-fs] host-user reconnection and crash recovery

2021-05-13 Thread Jiachen Zhang
On Thu, May 13, 2021 at 4:26 PM Dr. David Alan Gilbert wrote: > * Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > > Hi Stefan and Sebastien, > > > > I think I should give some background context from my perspective. > > > > For the virtiofsd crash reconnection (recovery) to QEMU, as sa

Re: [PATCH 27/72] softfloat: Convert float128_default_nan to parts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 01/10] python/console_socket: avoid one-letter variable

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > Fixes pylint warnings. > > Signed-off-by: John Snow > Reviewed-by: Cleber Rosa > --- > python/qemu/console_socket.py | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 02/10] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull)

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > One less file resource to manage, and it helps quiet some pylint >= > 2.8.0 warnings about not using a with-context manager for the open call. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 6 ++ > 1 file changed, 2 insertions(+), 4 dele

Re: [PATCH 08/10] iotests: use 'with open()' where applicable

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/12/21 11:46 PM, John Snow wrote: > More pylint 2.8.x warning hushing: use open's context manager where it's > applicable to do so to avoid a warning. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Rev

Re: [vhost-user] Expectations around reconnection

2021-05-13 Thread Philippe Mathieu-Daudé
Cc'ing few developers On 5/11/21 3:33 PM, Boeuf, Sebastien wrote: > Hi All, > > In the context of vhost-user, I was wondering how a reconnection should > be handled from the VMM perspective? > > In particular, I'm looking at the OVS-DPDK use case using the client > mode (meaning QEMU acts as th

Re: [PATCH 31/72] softfloat: Move sf_canonicalize to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > At the same time, convert to pointers, rename to parts$N_canonicalize > and define a macro for parts_canonicalize using QEMU_GENERIC. You also changed the ordering of checks and the likely/unlikey conditions which would be worth mentioning why in the commit. Otherwi

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/11/21 3:09 PM, BALATON Zoltan wrote: > On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 5/11/21 1:28 PM, BALATON Zoltan wrote: >>> On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remove the isa_get_irq(NULL) call to

Re: [ANNOUNCE] libblkio v0.1.0 preview release

2021-05-13 Thread Stefan Hajnoczi
On Thu, May 06, 2021 at 12:33:24PM +0200, Kevin Wolf wrote: > Am 06.05.2021 um 10:46 hat Stefan Hajnoczi geschrieben: > > On Wed, May 05, 2021 at 06:46:36PM +0200, Kevin Wolf wrote: > > > Am 05.05.2021 um 18:19 hat Stefan Hajnoczi geschrieben: > > > > On Tue, May 04, 2021 at 03:44:23PM +0200, Kevin

[Bug 1913969] Re: unable to migrate non shared storage when TLS is used

2021-05-13 Thread Dr. David Alan Gilbert
cc;ing in eblake Eric: Following that libvirt issue it looks like it's block related; something weird happening where only some of the disks are syncing? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [PATCH 32/72] softfloat: Move round_canonical to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > At the same time, convert to pointers, renaming to parts$N_uncanon, > and define a macro for parts_uncanon using QEMU_GENERIC. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

[PATCH v3 01/22] hw/usb/ccid: remove references to NSS

2021-05-13 Thread Daniel P . Berrangé
The NSS package was previously pre-requisite for building CCID related features, however, this became obsolete when the libcacard library was spun off to a separate project: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author: Marc-André Lureau Date: Sun Aug 30 11:48:40 2015 +020

[PATCH v3 03/22] tests/docker: use project specific container registries

2021-05-13 Thread Daniel P . Berrangé
Since Docker Hub has started to enforce pull rate limits on clients, it is preferrable to use project specific container registries where they are available. Fedora and OpenSUSE projects provide registries. The images in these registries are also refreshed on a more regular basis than the ones in

[PATCH v3 04/22] tests/docker: use explicit docker.io registry

2021-05-13 Thread Daniel P . Berrangé
It is good practice to use an explicit registry for referencing the base image. This is because some distros will inject their own registries into the search path. For example registry.fedoraproject.org comes ahead of docker.io. Using an explicit registry avoids wasting time querying multiple regis

[PATCH v3 06/22] tests/docker: fix sorting in package lists

2021-05-13 Thread Daniel P . Berrangé
This will make diffs in later patches clearer. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos8.docker | 2 +- tests/docker/dockerfiles/fedora.docker| 4 ++-- tests/docker/dockerf

[PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-05-13 Thread Daniel P . Berrangé
Currently the tests/docker/dockerfiles/*Dockerfile recipes are all hand written by contributors. There is a common design pattern, but the set of packages listed for installation leaves alot to be desired - There is no consistency at all across distros - Many potential build deps are not listed

[PATCH v3 11/22] tests/docker: expand centos8 package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos8.docker | 66 + 1 file changed, 66 insertions(+) diff --git a/test

[PATCH v3 08/22] tests/docker: fix mistakes in fedora package list

2021-05-13 Thread Daniel P . Berrangé
libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 05/22] tests/docker: remove FEATURES env var from templates

2021-05-13 Thread Daniel P . Berrangé
In preparation for switching to auto-generated dockerfiles, remove the FEATURES env variable. The equivalent functionality can be achieved in most cases by just looking for existance of a binary. The cases which don't correspond to binaries are simply dropped because configure/meson will probe for

[PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-05-13 Thread Daniel P . Berrangé
librados-dev is not required by QEMU directly, only librbd-dev. glusterfs-common is not directly needed by QEMU. QEMU uses ncursesw only on non-Windows hosts. The clang package is clang 10. flex and bison are not required by QEMU. Standardize on nmap ncat implementation to match Fedora/CentOS.

[PATCH v3 02/22] tests/docker: don't use BUILDKIT in GitLab either

2021-05-13 Thread Daniel P . Berrangé
Using BUILDKIT breaks with certain container registries such as CentOS, with docker build reporting an error such as failed to solve with frontend dockerfile.v0: failed to build LLB: failed to load cache key: unexpected status code https://registry.centos.org/v2/centos/manifests/7: 403 F

[PATCH v3 19/22] tests/docker: auto-generate ubuntu1804 with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu1804.docker | 247 - 2 files changed, 143 insertions(+), 1

[PATCH v3 12/22] tests/docker: expand fedora package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 28 +- 1 file changed, 27 insertions(+), 1 deletion(-) di

[PATCH v3 13/22] tests/docker: expand ubuntu1804 package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/ubuntu1804.docker | 61 +- 1 file changed, 60 insertions(+), 1 deletion(-) di

[PATCH v3 20/22] tests/docker: auto-generate ubuntu2004 with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 6 + tests/docker/dockerfiles/ubuntu2004.docker | 249 - 2 files changed, 144 insertions(+), 1

[PATCH v3 15/22] tests/docker: expand opensuse-leap package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/opensuse-leap.docker | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) di

[PATCH v3 07/22] tests/docker: fix mistakes in centos package lists

2021-05-13 Thread Daniel P . Berrangé
mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. spice-glib-devel is not use in QEMU at all, but spice-protocol is. We also need the -devel package for spice-server, not the runtime. There is no need to specifically refer to python36, we can just use python3 as in other dis

[PATCH v3 16/22] tests/docker: add script for automating container refresh

2021-05-13 Thread Daniel P . Berrangé
This introduces https://gitlab.com/libvirt/libvirt-ci as a git submodule at tests/docker/libvirt-ci This submodule only needs to be checked out when needing to re-generate the files in tests/docker/dockerfiles. When a new build pre-requisite is needed for QEMU, it should be added to the libvi

[PATCH v3 10/22] tests/docker: remove mingw packages from Fedora

2021-05-13 Thread Daniel P . Berrangé
There are dedicated containers providing mingw packages for Fedora. Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 27 -- 1 file changed, 27 deletions(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedor

Re: [PATCH 33/72] softfloat: Use uadd64_carry, usub64_borrow in softfloat-macros.h

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Use compiler support for carry arithmetic. Didn't we have a series that attempted to take advantage of compiler support for Int128? Is the compiler end up smart enough to use 128 bit wide ops if it can? > Signed-off-by: Richard Henderson Anyway: Reviewed-by: Ale

[PATCH v3 14/22] tests/docker: expand ubuntu2004 package list

2021-05-13 Thread Daniel P . Berrangé
This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/ubuntu2004.docker | 50 +- 1 file changed, 48 insertions(+), 2 deletions(-) d

Re: [PATCH 34/72] softfloat: Move addsub_floats to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > In preparation for implementing multiple sizes. Rename to parts_addsub, > split out parts_add/sub_normal for future reuse with muladd. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 16/22] tests/docker: add script for automating container refresh

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 11:55 AM, Daniel P. Berrangé wrote: > This introduces > > https://gitlab.com/libvirt/libvirt-ci > > as a git submodule at tests/docker/libvirt-ci > > This submodule only needs to be checked out when needing to re-generate > the files in tests/docker/dockerfiles. > > When a new buil

[PATCH] qtest: add a QOM object for qtest

2021-05-13 Thread Paolo Bonzini
The qtest server right now can only be created using the -qtest and -qtest-log options. Allow an alternative way to create it using "-object qtest,chardev=...,log=...". This is part of the long term plan to make more (or all) of QEMU configurable through QMP and preconfig mode. Signed-off-by: Pa

[PATCH v3 18/22] tests/docker: auto-generate fedora with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py| 1 + tests/docker/dockerfiles/fedora.docker | 248 ++--- 2 files changed, 138 insertions(+), 111 d

Re: [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros

2021-05-13 Thread Daniel P . Berrangé
Since posting I realized I made a mistake in considering Debian Stretch versions, as we've already dropped Stretch from supported platforms. I also made a mistake in analysing Clang versions in Ubuntu/Debian as I didn't realize they ship many versions in parallel. I should have been looking at the

Re: [PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 11:55 AM, Daniel P. Berrangé wrote: > librados-dev is not required by QEMU directly, only librbd-dev. > > glusterfs-common is not directly needed by QEMU. > > QEMU uses ncursesw only on non-Windows hosts. > > The clang package is clang 10. > > flex and bison are not required by QEMU.

[PATCH v3 17/22] tests/docker: auto-generate centos8 with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py | 2 +- tests/docker/dockerfiles/centos8.docker | 232 +--- 2 files changed, 129 insertions(+), 105

Re: [PATCH 35/72] softfloat: Implement float128_add/sub via parts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Replace the existing Berkeley implementation with the > FloatParts implementation. > > Signed-off-by: Richard Henderson Nice ;-) Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 12:15 PM, Daniel P. Berrangé wrote: > On Thu, May 13, 2021 at 12:12:33PM +0200, Philippe Mathieu-Daudé wrote: >> On 5/13/21 11:55 AM, Daniel P. Berrangé wrote: >>> librados-dev is not required by QEMU directly, only librbd-dev. >>> >>> glusterfs-common is not directly needed by QEMU. >>>

Re: [PATCH 36/72] softfloat: Move mul_floats to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_mul. > Reimplement float128_mul with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

[PATCH v3 21/22] tests/docker: auto-generate opensuse-leap with lcitool

2021-05-13 Thread Daniel P . Berrangé
This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles-refresh.py | 1 + tests/docker/dockerfiles/opensuse-leap.docker | 233 ++ 2 files changed, 127 insertions(+)

[PATCH v3 22/22] tests/docker: remove ubuntu container

2021-05-13 Thread Daniel P . Berrangé
This duplicates the ubuntu2004 container but with an inconsistent set of packages. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/containers.yml| 5 -- tests/docker/dockerfiles/ubuntu.docker | 69 -- 2 files changed, 7

Re: [PATCH v3 07/22] tests/docker: fix mistakes in centos package lists

2021-05-13 Thread Philippe Mathieu-Daudé
On 5/13/21 11:55 AM, Daniel P. Berrangé wrote: > mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. > > spice-glib-devel is not use in QEMU at all, but spice-protocol is. > We also need the -devel package for spice-server, not the runtime. > > There is no need to specifically

Re: [PATCH 34/72] softfloat: Move addsub_floats to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > In preparation for implementing multiple sizes. Rename to parts_addsub, > split out parts_add/sub_normal for future reuse with muladd. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v6 42/82] target/arm: Implement SVE2 HISTCNT, HISTSEG

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:07, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200416173109.8856-1-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > v2: Fix overlap between output and input vectors. > v4: Fix histseg counting (zhiwe

Re: [PATCH v6 45/82] target/arm: Implement SVE2 gather load insns

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:17, Richard Henderson wrote: > > From: Stephen Long > > Add decoding logic for SVE2 64-bit/32-bit gather non-temporal > load insns. > > 64-bit > * LDNT1SB > * LDNT1B (vector plus scalar) > * LDNT1SH > * LDNT1H (vector plus scalar) > * LDNT1SW > * LDNT1W (vector plus scal

Re: [PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

2021-05-13 Thread Daniel P . Berrangé
On Thu, May 13, 2021 at 12:12:33PM +0200, Philippe Mathieu-Daudé wrote: > On 5/13/21 11:55 AM, Daniel P. Berrangé wrote: > > librados-dev is not required by QEMU directly, only librbd-dev. > > > > glusterfs-common is not directly needed by QEMU. > > > > QEMU uses ncursesw only on non-Windows host

Re: [PATCH v4 22/31] target/ppc: Implement PNOP

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: +### Prefixed No-operation Instruction + +&PNOP invalid_suffix:bool +@PNOP 01 11 -- 00 \ +&PNOP + +{ + ## Invalid suffixes: Branch inst

Re: [PATCH v6 46/82] target/arm: Implement SVE2 FMMLA

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:07, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200422165503.13511-1-stepl...@quicinc.com> > [rth: Fix indexing in helpers, expand macro to straight functions.] > Signed-off-by: Richard Henderson > --- > target/arm/

Re: [PATCH v6 43/82] target/arm: Implement SVE2 XAR

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:58, Richard Henderson wrote: > > In addition, use the same vector generator interface for AdvSIMD. > This fixes a bug in which the AdvSIMD insn failed to clear the > high bits of the SVE register. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks

Re: [PATCH 37/72] softfloat: Move muladd_floats to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_muladd. > Implement float128_muladd with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v6 47/82] target/arm: Implement SVE2 SPLICE, EXT

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:13, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200423180347.9403-1-stepl...@quicinc.com> > [rth: Rename the trans_* functions to *_sve2.] > Signed-off-by: Richard Henderson > --- > target/arm/sve.decode | 11 +

Re: [PATCH v6 44/82] target/arm: Implement SVE2 scatter store insns

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:01, Richard Henderson wrote: > > From: Stephen Long > > Add decoding logic for SVE2 64-bit/32-bit scatter non-temporal > store insns. > > 64-bit > * STNT1B (vector plus scalar) > * STNT1H (vector plus scalar) > * STNT1W (vector plus scalar) > * STNT1D (vector plus scalar

Re: [PATCH v5 49/81] target/arm: Pass separate addend to FCMLA helpers

2021-05-13 Thread Peter Maydell
On Fri, 16 Apr 2021 at 22:58, Richard Henderson wrote: > > For SVE, we potentially have a 4th argument coming from the > movprfx instruction. Currently we do not optimize movprfx, > so the problem is not visible. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h | 20

Re: [PATCH 39/72] softfloat: Use add192 in mul128To256

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > We can perform the operation in 6 total adds instead of 8. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Tested-by: Alex Bennée > --- > include/fpu/softfloat-macros.h | 37 +++--- > 1 file changed, 12 insertions(+), 2

Re: [PATCH v4 23/31] TCG: add tcg_constant_tl

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Used in D/DS/X-form load/store implementation. Signed-off-by: Matheus Ferst --- include/tcg/tcg-op.h | 2 ++ 1 file changed, 2 insertions(+) Ah, thanks. Queuing to tcg-next. r~

Re: [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-05-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210513095519.1213675-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210513095519.1213675-1-berra...@redhat.com Subject: [PATCH v3 00/22] tests/docker: st

Re: [PATCH v6 50/82] target/arm: Split out formats for 2 vectors + 1 index

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:10, Richard Henderson wrote: > > Currently only used by FMUL, but will shortly be used more. > > Signed-off-by: Richard Henderson > --- > target/arm/sve.decode | 14 ++ Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 48/82] target/arm: Pass separate addend to {U, S}DOT helpers

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:57, Richard Henderson wrote: > > For SVE, we potentially have a 4th argument coming from the > movprfx instruction. Currently we do not optimize movprfx, > so the problem is not visible. > > Signed-off-by: Richard Henderson > --- > v4: Fix double addition (zhiwei). > --

Re: [PATCH v4 25/31] target/ppc: Implement prefixed integer load instructions

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: +PLBZ 01 10 0--.-- .. \ +100010 . . @PLS_D Mind the indentation; looks like this got perturbed by prefixing "P". r~

Re: [PATCH 40/72] softfloat: Tidy mul128By64To192

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Clean up the formatting and variables; no functional change. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

2021-05-13 Thread Vladimir Sementsov-Ogievskiy
12.05.2021 20:43, Max Reitz wrote: pylint complains that discards1_sha256 and all_discards_sha256 are first set in non-__init__ methods. These variables are not really class-variables anyway, so let them instead be returned by start_postcopy(), thus silencing pylint. Suggested-by: Vladimir Seme

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

2021-05-13 Thread Steven Price
On 12/05/2021 18:45, Catalin Marinas wrote: > On Wed, May 12, 2021 at 04:46:48PM +0100, Steven Price wrote: >> On 10/05/2021 19:35, Catalin Marinas wrote: >>> On Fri, May 07, 2021 at 07:25:39PM +0100, Catalin Marinas wrote: On Thu, May 06, 2021 at 05:15:25PM +0100, Steven Price wrote: > On

Re: [PATCH v6 51/82] target/arm: Split out formats for 3 vectors + 1 index

2021-05-13 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:10, Richard Henderson wrote: > > Used by FMLA and DOT, but will shortly be used more. > Split FMLA from FMLS to avoid an extra sub field; > similarly for SDOT from UDOT. > > Signed-off-by: Richard Henderson > --- > target/arm/sve.decode | 29 +++

Re: [PATCH 41/72] softfloat: Introduce sh[lr]_double primitives

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Have x86_64 assembly for them, with a fallback. > This avoids shuffling values through %cl in the x86 case. > > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat-macros.h | 36 > fpu/softfloat.c| 102 ++

[Bug 1908832] Re: jack audio dev produces no sound

2021-05-13 Thread Thomas Huth
Ticket has been moved here (thanks, José!): https://gitlab.com/qemu-project/qemu/-/issues/278 ... thus closing this on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #278 https://gitlab.com/qemu-project/qemu/-/issues/278 ** Changed in: qemu Status: Incomplete =

Re: [PATCH v4 28/31] target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: +static bool do_set_bool_cond(DisasContext *ctx, arg_X_bi *a, bool neg, bool rev) +{ +REQUIRE_INSNS_FLAGS2(ctx, ISA310); +uint32_t mask = 0x08 >> (a->bi & 0x03); +TCGv temp = tcg_temp_new(); + +tcg_gen_extu_i32_tl(temp, cpu

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-13 Thread Vladimir Sementsov-Ogievskiy
12.05.2021 12:59, Daniel P. Berrangé wrote: On Wed, May 12, 2021 at 12:40:03PM +0300, Roman Kagan wrote: On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: Detecting monitor by current coroutine work

Re: [PATCH 42/72] softfloat: Move div_floats to softfloat-parts.c.inc

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Rename to parts$N_div. > Implement float128_div with FloatParts128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 43/72] softfloat: Split float_to_float

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Split out parts_float_to_ahp and parts_float_to_float. > Convert to pointers. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 44/72] softfloat: Convert float-to-float conversions with float128

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Introduce parts_float_to_float_widen and parts_float_to_float_narrow. > Use them for float128_to_float{32,64} and float{32,64}_to_float128. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 29/31] target/ppc: Implement cfuged instruction

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: +while (i) { +n = ctz64(mask); +if (n > i) { +n = i; +} + +m = (1ll << n) - 1; +if (bit) { +right = ror64(right | (src & m), n); +} else { +left = ror64

Re: [PATCH v4 30/31] target/ppc: Implement vcfuged instruction

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode | 7 target/ppc/translate.c | 1 + target/ppc/translate/vector-impl.c.inc | 50 ++ 3 files ch

[PATCH] migration/rdma: Fix cm_event used before being initialized

2021-05-13 Thread Li Zhijian
A segmentation fault was triggered when i try to abort a postcopy + rdma migration. since rdma_ack_cm_event releases a uninitialized cm_event in thise case. like below: 2496 ret = rdma_get_cm_event(rdma->channel, &cm_event); 2497 if (ret) { 2498 perror("rdma_get_cm_event after rdm

Re: [PATCH v4 31/31] target/ppc: Move addpcis to decodetree

2021-05-13 Thread Richard Henderson
On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode | 6 ++ target/ppc/translate.c | 9 - target/ppc/translate/fixedpoint-impl.c.inc | 7 +++ 3 files chan

Re: [PATCH v4 28/31] target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions

2021-05-13 Thread Matheus K. Ferst
On 13/05/2021 08:01, Richard Henderson wrote: On 5/12/21 1:54 PM, matheus.fe...@eldorado.org.br wrote: +static bool do_set_bool_cond(DisasContext *ctx, arg_X_bi *a, bool neg, bool rev) +{ +    REQUIRE_INSNS_FLAGS2(ctx, ISA310); +    uint32_t mask = 0x08 >> (a->bi & 0x03); +    TCGv temp = tcg_t

RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-13 Thread Jonathan Cameron
Hi All, Cc list is a bit of guess, so please add anyone else who might be interested in this topic. This came up in discussion of the CXL emulation series a while back and I've finally gotten around to looking more closely at it (having carried a local hack in the meantime). https://lore.kernel.

[Bug 1917661] Re: qemu gdb wrong registers group for riscv64

2021-05-13 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Richard Henderson
On 5/12/21 2:23 PM, Alex Bennée wrote: Richard Henderson writes: Reorg everything using QEMU_GENERIC and multiple inclusion to reduce the amount of code duplication between the formats. The use of QEMU_GENERIC means that we need to use pointers instead of structures, which means that even th

Re: [PULL 0/5] Miscellaneous patches for 2021-05-12

2021-05-13 Thread Thomas Huth
On 12/05/2021 18.33, Peter Maydell wrote: On Wed, 12 May 2021 at 17:24, Markus Armbruster wrote: The following changes since commit a5ccdccc97d6e0d75282ede5b866cf694e9602b0: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20210510-pull-request' into staging (2021-05-12 14:45:21 +010

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-13 Thread BALATON Zoltan
On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/11/21 3:09 PM, BALATON Zoltan wrote: On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 5/11/21 1:28 PM, BALATON Zoltan wrote: On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remo

[Bug 1916269] Re: TCG: QEMU incorrectly raises exception on SSE4.2 CRC32 instruction

2021-05-13 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

  1   2   3   4   >