Hi all!
Here are some good refactorings and new (qemu-img check) checks for
qcow2.
v2:
Fix wording and typos found by Eric, and add r-bs to all except 08.
08: move g_try_malloc down
Vladimir Sementsov-Ogievskiy (10):
qcow2-refcount: improve style of check_refcounts_l2()
qcow2: compressed rea
Split fix_l2_entry_by_zero() out of check_refcounts_l2() to be
reused in further patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 87 +-
1 file changed, 60 insertions(+), 27 deletions(-)
diff --git a
Add helper to parse compressed l2_entry and use it everywhere instead
of open-coding.
Note, that in most places we move to precise coffset/csize instead of
sector-aligned. Still it should work good enough for updating
refcounts.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
We'll reuse the function to fix wrong L2 entry bitmap. Support it now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refc
- don't use same name for size in bytes and in entries
- use g_autofree for l2_table
- add whitespace
- fix block comment style
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 47 +-
1 file changed, 24
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2.h | 1 +
block/qcow2-refcount.c | 12 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index c0e1e83796..b8b1093b61 100644
--- a/block/qcow2.h
++
Check subcluster bitmap of the l2 entry for different types of
clusters:
- for compressed it must be zero
- for allocated check consistency of two parts of the bitmap
- for unallocated all subclusters should be unallocated
(or zero-plain)
For unallocated clusters we can safely fix the entry
- use g_autofree for l1_table
- better name for size in bytes variable
- reduce code blocks nesting
- whitespaces, braces, newlines
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 98 +-
1 file changed, 50 insertions(+), 48 del
Philippe Mathieu-Daudé writes:
> Introduce the 'query-accels' QMP command which returns a list
> of built-in accelerator names.
>
> - Accelerator is a QAPI enum of all existing accelerators,
>
> - AcceleratorInfo is a QAPI structure providing accelerator
> specific information. Currently the co
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2.h | 1 +
block/qcow2-refcount.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/block/qcow2.h b/block/qcow2.h
index b8b1093b61..58fd7f1678 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -58
Split checking for reserved bits out of aligned offset check.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2.h | 1 +
block/qcow2-refcount.c | 10 +-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2
Let's pass the whole L2 entry and not bother with
L2E_COMPRESSED_OFFSET_SIZE_MASK.
It also helps further refactoring that adds generic
qcow2_parse_compressed_l2_entry() helper.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
block/qcow2.h | 1 -
block/qcow2-clu
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/138
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/142
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/141
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/140
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/139
** Changed in: qemu
Status: New => Expired
** Bug watch
Peter Maydell writes:
> On Sun, 2 May 2021 at 21:31, Philippe Mathieu-Daudé wrote:
>>
>> The TYPE_NAND device is bus-less, thus isn't reset automatically.
>> Register a reset handler to get reset with the machine.
>>
>> Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus")
>> Signed-off-by: Phi
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| Otherwise some of the 'resp' will be leaked to guest.
|
| diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
| index 9e6660c7ab..6a332d601f 100644
|
| +memset(&resp, 0, sizeof(resp));
| if (info.capset_index == 0) {
28.04.2021 22:50, Vladimir Sementsov-Ogievskiy wrote:
28.04.2021 20:03, Kevin Wolf wrote:
Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben:
Hi all!
And here is v4.
Thanks, applied to the block branch.
Thanks! And thanks a lot for reviewing!
Though the error message sh
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| Call 'vugbm_buffer_destroy' in error path to avoid resource leak.
|
| Signed-off-by: Li Qiang
| ---
| contrib/vhost-user-gpu/vhost-user-gpu.c | 1 +
| 1 file changed, 1 insertion(+)
|
| diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c
b/contrib/
From: Philippe Mathieu-Daudé
Introduce the TYPE_SUN4M_MACHINE and have all sun4m
machines inherit it.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-2-f4...@amsat.org>
Signed-off-by: Mark Cave-Ayland
---
qemu-sparc-20210505
for you to fetch changes up to 10fb1340b161682d64320a5976f88f68472410bf:
hw/sparc*: Move cpu_check_irqs() to target/sparc/ (2021-05-04 22:45:53 +0100)
qemu-s
From: Philippe Mathieu-Daudé
We are going to move this code, fix its style first.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-6-f4...@amsat.org>
Signed-off-by: Mark Cave-Ayland
---
hw/sparc/sun4m.c | 1
From: Philippe Mathieu-Daudé
Remove the sun4m_hwdefs[] array by moving assigning the
structure fields directly in each machine class_init()
function.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-7-f4...@amsat.org>
Signed-off-by: Mark Ca
From: Philippe Mathieu-Daudé
Instead of passing the sun4m_hwdef structure via
machine_init(), store it into the MachineClass.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-3-f4...@amsat.org>
Signed-off-by:
From: Philippe Mathieu-Daudé
Factor out the class_init code common to all machines
to sun4m_machine_class_init().
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-4-f4...@amsat.org>
Signed-off-by: Mark Cave-A
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: KONRAD Frederic
Reviewed-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
Message-Id: <20210428141655.387430-3-f4...@amsat.org>
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sparc64.c | 1 -
1 file changed,
From: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20210503171303.822501-5-f4...@amsat.org>
Signed-off-by: Mark Cave-Ayland
---
hw/sparc/sun4m.c | 100 +--
1
From: Philippe Mathieu-Daudé
When building without the leon3 machine, we get this link failure:
/usr/bin/ld: target_sparc_int32_helper.c.o: in function `leon3_irq_manager':
target/sparc/int32_helper.c:172: undefined reference to `leon3_irq_ack'
This is because the leon3_irq_ack() is declare
From: Philippe Mathieu-Daudé
Since cpu_check_irqs() doesn't reference to anything outside
of CPUSPARCState, it better belongs to the architectural code
in target/, rather than the hardware specific code in hw/.
Note: while we moved the trace events, we don't rename them.
Remark: this allows us
From: Philippe Mathieu-Daudé
We are going to move this code, fix its style first.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: KONRAD Frederic
Reviewed-by: Mark Cave-Ayland
Reviewed-by: Richard Henderson
Message-Id: <20210428141655.387430-4-f4...@amsat.org>
Signed-off-by: Mark Cave-Ayl
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| Check whether the 'res' has already been attach_backing to avoid
| memory leak.
|
| Signed-off-by: Li Qiang
| ---
| contrib/vhost-user-gpu/vhost-user-gpu.c | 5 +
| 1 file changed, 5 insertions(+)
|
| diff --git a/contrib/vhost-user-gpu/vhost-use
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| If the guest trigger following sequences, the attach_backing will be leaked:
|
| vg_resource_create_2d
| vg_resource_attach_backing
| vg_resource_unref
|
| This patch fix this by freeing 'res->iov' in vg_resource_destroy.
|
| Signed-
On 29/04/2021 09:26, Jason Wang wrote:
>
> 在 2021/4/28 下午6:14, Michael S. Tsirkin 写道:
>> On Tue, Apr 27, 2021 at 03:02:34PM +0100, Dr. David Alan Gilbert wrote:
>>> * Laurent Vivier (lviv...@redhat.com) wrote:
In the failover case configuration, virtio_net_device_realize() uses an
add_mi
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
| index 6a332d601f..c669d73a1d 100644
| --- a/contrib/vhost-user-gpu/virgl.c
| +++ b/contrib/vhost-user-gpu/virgl.c
| @@ -108,9 +108,16 @@ virgl_cmd_resource_unref(VuGpu *g,
|
There are only two drivers supporting vmstate: qcow2 and sheepdog.
Sheepdog is deprecated. In qcow2 these requests go through
.bdrv_co_p{read,write}v_part handlers.
So, let's do our basic check for the request on vmstate generic
handlers.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io
Hi all!
v5: rebase on master, fix block comments style and over-80 line.
01: s/{}/()/ in subject, so that email not to be mangled.
part II aims to update block drivers to int64_t.
I remind that main aim of this update of the whole block-layer to 64bit
is to implement 64bit write-zeroes NBD reque
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
We are going to convert .bdrv_co_preadv_part and .bdrv_co_pwritev_part
to int64_t type for offset and bytes parameters (as it's already done
for generic block/io.c layer).
In qcow2 .bdrv_co_preadv_part is used in some places, so let's add
corresponding checks and assertions.
Signed-off-by: Vladim
We modify the request by adding an offset to vmstate. Let's check the
modified request. It will help us to safely move .bdrv_co_preadv_part
and .bdrv_co_pwritev_part to int64_t type of offset and bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int.h | 3 +++
block/io.
We are going to support 64 bit write-zeroes requests. Now update the
limit variable. It's absolutely safe. The variable is set in some
drivers, and used in bdrv_co_do_pwrite_zeroes().
Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so
that bdrv_co_do_pwrite_zeroes() is now pre
Now, when all drivers are updated by previous commit, we can drop two
last limiters on write-zeroes path: INT_MAX in
bdrv_co_do_pwrite_zeroes() and bdrv_check_request32() in
bdrv_co_pwritev_part().
Now everything is prepared for implementing incredibly cool and fast
big-write-zeroes in NBD and qco
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
We are going to support 64 bit discard requests. Now update the
limit variable. It's absolutely safe. The variable is set in some
drivers, and used in bdrv_co_pdiscard().
Update also max_pdiscard variable in bdrv_co_pdiscard(), so that
bdrv_co_pdiscard() is now prepared to 64bit requests. The rema
Now, when all drivers are updated by previous commit, we can drop the
last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard().
Now everything is prepared for implementing incredibly cool and fast
big-discard requests in NBD and qcow2. And any other driver which wants
it of course.
Signed-off
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| If 'virgl_cmd_get_capset' set 'max_size' to 0,
| the 'virgl_renderer_fill_caps' will write the data after the 'resp'.
| This patch avoid this by checking the returned 'max_size'.
|
| Signed-off-by: Li Qiang
| ---
| contrib/vhost-user-gpu/virgl.c | 4 +
+-- On Tue, 4 May 2021, Li Qiang wrote --+
| diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
| index c669d73a1d..a16a311d80 100644
| --- a/contrib/vhost-user-gpu/virgl.c
| +++ b/contrib/vhost-user-gpu/virgl.c
| @@ -287,8 +287,11 @@ virgl_resource_attach_backing(VuGpu *g
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
Hi!
Kindly remind. Didn't you forget? I'm responsible for these two tests, let me
know if you don't have time, and I'll resend this series :)
29.03.2021 16:26, Max Reitz wrote:
Hi,
When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
far does not cover named tests. That is
Commit 3108a15cf (block: introduce bdrv_drop_filter()) introduced uninitialized
variable to_cow_parent in bdrv_replace_node_common function that is used only
when
detach_subchain is true. It is used in two places. First if block properly
initialize
the variable and second block use it.
However,
05.05.2021 10:59, Miroslav Rezanina wrote:
Commit 3108a15cf (block: introduce bdrv_drop_filter()) introduced uninitialized
variable to_cow_parent in bdrv_replace_node_common function that is used only
when
detach_subchain is true. It is used in two places. First if block properly
initialize
the
Patchew URL:
https://patchew.org/QEMU/20210505075001.45041-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210505075001.45041-1-vsement...@virtuozzo.com
Subject: [PATCH v5 00/11] 64bit bloc
05.05.2021 11:06, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20210505075001.45041-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210505075001.45041-1-vsement...@vi
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/152
** Changed in: qemu
Status: New => Expired
** Bug watch
Thanks for opening the new ticket. Let's close this one here as WontFix
- since we will only look at the new issue now instead.
** Changed in: qemu
Status: Incomplete => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/151
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/149
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/143
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/150
** Changed in: qemu
Status: Triaged => Expired
** Bug w
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/145
** Changed in: qemu
Status: Triaged => Expired
** Bug w
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/144
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/148
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/146
** Changed in: qemu
Status: Triaged => Expired
** Bug w
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/147
** Changed in: qemu
Status: New => Expired
** Bug watch
Peter Maydell writes:
[...]
> In summary, we have a few options:
>
> (1) Expand "assertions always fatal" to test code, and add "panics"
> models of the g_assertion_message* functions. Remove all the calls
> to g_test_set_nonfatal_assertions().
>
> (2) Aim to expand the ability to use g_test_set
On 3/8/21 3:02 PM, Alex Bennée wrote:
>
> Claudio Fontana writes:
>
>> Hi,
>>
>> anything else for me to do here?
>
> It looks to me that this series is looking pretty good. Every patch has
> at least one review so I think it's just waiting on the maintainers to
> pick it up.
>
> Paolo/Richard
On Mon, 2021-04-19 at 17:22 +0100, Alex Bennée wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
>
> Generally it's a good idea to reference where these are coming from, is
> it a current kernel patch in flight or from an release we haven't synced
> up to yet?
Hi!
As Paolo ex
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1925417
Title:
Cannot boot from EFI image on aarch64
Status in QEMU:
Invalid
Bug description:
I
On Mon, 2021-04-19 at 17:29 +0100, Alex Bennée wrote:
> Maxim Levitsky writes:
>
> > Signed-off-by: Maxim Levitsky
> > ---
> > accel/kvm/kvm-all.c | 25 +++
> > gdbstub.c| 59
> > include/sysemu/kvm.h | 13 ++
> >
On 04/05/2021 20.33, John Snow wrote:
[...]
- Gitlab will automatically close issues that reference the gitlab issue
tracker from the commit message, but it won't apply the "Merged" label, so
it's at risk of falling out of sync.
Closed issues retain their "Workflow::" labels, but won't show up
On Mon, Apr 19, 2021 at 10:55:34AM +0200, Emanuele Giuseppe Esposito wrote:
No commit description. What about write thresholds makes them thread
unsafe? Without a commit description reviewers have to reverse-engineer
the patch to figure out the author's intention, which can lead to
misunderstandin
On Mon, Apr 19, 2021 at 10:55:35AM +0200, Emanuele Giuseppe Esposito wrote:
> For simplicity, use bdrv_drained_begin/end to avoid concurrent
> writes to the write threshold, or reading it while it is being set.
> qmp_block_set_write_threshold is protected by the BQL.
>
> Reviewed-by: Stefan Hajnoc
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/154
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/157
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/156
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/153
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/155
** Changed in: qemu
Status: New => Expired
** Bug watch
Hello,
The POWER10 DD2 CPU adds an extra LPCR[HAIL] bit which is a requirement
to support the scv instruction on PowerNV POWER10 platforms (glibc-2.33).
These changes add a POWER10 DD2 CPU and switch the default chip model
of the powernv10 machine to use this CPU. This to make sure that the
machi
The chip model of the powernv10 machine now uses the latest POWER10
DD2 CPU. The DD1 chip model is undefined and considered invalid.
Signed-off-by: Cédric Le Goater
---
include/hw/ppc/pnv.h | 2 +-
hw/ppc/pnv.c | 2 +-
hw/ppc/pnv_core.c| 2 +-
3 files changed, 3 insertions(+), 3 dele
The POWER10 DD2 CPU adds an extra LPCR[HAIL] bit. The required change
of the LPCR mask impacts all the POWER10 family. It is incorrect for
DD1 but it does not break the modeling.
Setting the HAIL bit is a requirement to support the scv instruction
on PowerNV POWER10 platforms since glibc-2.33.
Si
Hi
On Wed, May 5, 2021 at 12:03 PM P J P wrote:
> +-- On Tue, 4 May 2021, Li Qiang wrote --+
> | diff --git a/contrib/vhost-user-gpu/virgl.c
> b/contrib/vhost-user-gpu/virgl.c
> | index c669d73a1d..a16a311d80 100644
> | --- a/contrib/vhost-user-gpu/virgl.c
> | +++ b/contrib/vhost-user-gpu/virgl.
P J P 于2021年5月5日周三 下午3:24写道：
>
> +-- On Tue, 4 May 2021, Li Qiang wrote --+
> | Otherwise some of the 'resp' will be leaked to guest.
> |
> | diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
> | index 9e6660c7ab..6a332d601f 100644
> |
> | +memset(&resp, 0, sizeof(re
Hi
On Wed, May 5, 2021 at 9:21 AM Li Qiang wrote:
> These security issue is low severity and is similar with the
> virtio-vga/virtio-gpu device. All of them can be triggered by
> the guest user.
>
> Li Qiang (7):
> vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info
> vhost-us
P J P 于2021年5月5日周三 下午3:39写道：
>
> +-- On Tue, 4 May 2021, Li Qiang wrote --+
> | Check whether the 'res' has already been attach_backing to avoid
> | memory leak.
> |
> | Signed-off-by: Li Qiang
> | ---
> | contrib/vhost-user-gpu/vhost-user-gpu.c | 5 +
> | 1 file changed, 5 insertions(+)
> |
P J P 于2021年5月5日周三 下午3:48写道：
>
> +-- On Tue, 4 May 2021, Li Qiang wrote --+
> | diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
> | index 6a332d601f..c669d73a1d 100644
> | --- a/contrib/vhost-user-gpu/virgl.c
> | +++ b/contrib/vhost-user-gpu/virgl.c
> | @@ -108,9 +108,
From: Mahmoud Mandour
Freed the values stored in the hash table ``hotblocks``
returned by ``g_hash_table_get_values()`` by freeing the sorted
list and destroyed the hash table afterward.
Signed-off-by: Mahmoud Mandour
Signed-off-by: Alex Bennée
Message-Id: <20210422005043.3569-2-ma.mando...@gm
From: Mahmoud Mandour
Allocated ``pages`` hash table through ``g_hash_table_new_full`` to
add a freeing function & destroyed the hash table on exit.
Signed-off-by: Mahmoud Mandour
Signed-off-by: Alex Bennée
Message-Id: <20210422005043.3569-3-ma.mando...@gmail.com>
---
contrib/plugins/hotpages
From: Yonggang Luo
Reorder the function symbols that consistence with qemu-plugins.h
Signed-off-by: Yonggang Luo
Signed-off-by: Alex Bennée
Message-Id: <2021031818.434-2-luoyongg...@gmail.com>
---
plugins/qemu-plugins.symbols | 25 -
1 file changed, 12 insertions(+
Hi,
This is my current plugins queue. It has a few fixes from Yonggang and
Mahmoud as well as some minor tweaks to the TCG tracing. I've also
marked an intention to deprecate following the discussion we had in:
Subject: trace_FOO_tcg bit-rotted?
Date: Tue, 06 Apr 2021 17:00:20 +0100
Message
These are generic trace points in common helper functions used by all
front ends. They mainly serve as additional in-tree examples of TCG
trace points and can be used to compare and contrast with getting
similar information from the TCG plugins.
Signed-off-by: Alex Bennée
---
tcg/tcg-op.c | 8 +
Marc-André Lureau 于2021年5月5日周三 下午5:08写道：
>
> Hi
>
> On Wed, May 5, 2021 at 12:03 PM P J P wrote:
>>
>> +-- On Tue, 4 May 2021, Li Qiang wrote --+
>> | diff --git a/contrib/vhost-user-gpu/virgl.c
>> b/contrib/vhost-user-gpu/virgl.c
>> | index c669d73a1d..a16a311d80 100644
>> | --- a/contrib/vhost
Marc-André Lureau 于2021年5月5日周三 下午5:10写道：
>
> Hi
>
> On Wed, May 5, 2021 at 9:21 AM Li Qiang wrote:
>>
>> These security issue is low severity and is similar with the
>> virtio-vga/virtio-gpu device. All of them can be triggered by
>> the guest user.
>>
>> Li Qiang (7):
>> vhost-user-gpu: fix me
From: Yonggang Luo
Signed-off-by: Yonggang Luo
Signed-off-by: Alex Bennée
Message-Id: <2021031818.434-3-luoyongg...@gmail.com>
---
include/qemu/qemu-plugin.h | 187 ++---
1 file changed, 92 insertions(+), 95 deletions(-)
diff --git a/include/qemu/qemu-plugi
Currently attempts to add a new TCG trace events results in failures
to build. Previous discussions have suggested maybe it's time to mark
the feature as deprecated and push people towards using plugins.
Signed-off-by: Alex Bennée
Cc: Luis Vilanova
Cc: Stefan Hajnoczi
---
docs/devel/tcg-plugin
TCG types will be transformed into the appropriate host types later on
in the tool. For example adding the following trace point:
tcg goto_ptr(TCGv_ptr ptr) "", "ptr=%p"
would trigger:
ValueError: Error at /home/alex/lsrc/qemu.git/./trace-events:149: Argument
type 'TCGv_ptr' is not allowed.
On Wed, May 05, 2021 at 10:22:57AM +0100, Alex Bennée wrote:
> Currently attempts to add a new TCG trace events results in failures
> to build. Previous discussions have suggested maybe it's time to mark
> the feature as deprecated and push people towards using plugins.
>
> Signed-off-by: Alex Ben
Hi
On Wed, May 5, 2021 at 1:24 PM Li Qiang wrote:
> Marc-André Lureau 于2021年5月5日周三 下午5:08写道：
> >
> > Hi
> >
> > On Wed, May 5, 2021 at 12:03 PM P J P wrote:
> >>
> >> +-- On Tue, 4 May 2021, Li Qiang wrote --+
> >> | diff --git a/contrib/vhost-user-gpu/virgl.c
> b/contrib/vhost-user-gpu/virgl.
Hi
On Wed, May 5, 2021 at 1:28 PM Li Qiang wrote:
> Marc-André Lureau 于2021年5月5日周三 下午5:10写道：
> >
> > Hi
> >
> > On Wed, May 5, 2021 at 9:21 AM Li Qiang wrote:
> >>
> >> These security issue is low severity and is similar with the
> >> virtio-vga/virtio-gpu device. All of them can be triggered
1 - 100 of 511 matches
Mail list logo
