Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> Introduce the 'query-accels' QMP command which returns a list
> of built-in accelerator names.
>
> - Accelerator is a QAPI enum of all existing accelerators,
>
> - AcceleratorInfo is a QAPI structure providing accelerator
> specific information. Currently the common structure base
> provides the name of the accelerator, while the specific
> part is empty, but each accelerator can expand it.
>
> - 'query-accels' QMP command returns a list of @AcceleratorInfo
>
> For example on a KVM-only build we get:
>
> { "execute": "query-accels" }
> {
> "return": [
> {
> "name": "qtest"
> },
> {
> "name": "kvm"
> }
> ]
> }
>
> Note that we can't make the enum values or union branches conditional
> because of target-specific poisoning of accelerator definitions.
Let me try to complete this argument;
If we did, enum Accelerator could only be used in target-specific
code. But we want to use it in generic code, too.
Which generic code exactly?
> Reviewed-by: Eric Blake <ebl...@redhat.com>
> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
> Tested-by: Alex Bennée <alex.ben...@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Patch looks good to me.
