Peter Maydell <peter.mayd...@linaro.org> writes: > On Sun, 2 May 2021 at 21:31, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> >> The TYPE_NAND device is bus-less, thus isn't reset automatically. >> Register a reset handler to get reset with the machine. >> >> Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus") >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- > > Personally I would just revert 7426aa72c36 rather than introduce > a new use of qemu_register_reset()...
I think this depends on what you dislike more, qemu_register_reset() or sysbus. Neither is deprecated, both have more than a hundred users. One more user doesn't matter all that much for either. I happen to dislike sysbus more, but my opinion on this is yet another thin that doesn't matter all that much :)