Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-26 Thread Viresh Kumar
On 25-03-21, 17:16, Arnd Bergmann wrote: > On Wed, Mar 24, 2021 at 8:33 AM Viresh Kumar wrote: > > +static void vi2c_handle_ctrl(VuDev *dev, int qidx) > > +{ > > +VuVirtq *vq = vu_get_queue(dev, qidx); > > +struct i2c_msg msg; > > +struct virtio_i2c_out_hdr *out_hdr; > > +struct vi

Re: [PATCH 0/6] Add debug interface to kick/call on purpose

2021-03-26 Thread Jason Wang
在 2021/3/26 下午1:44, Dongli Zhang 写道: The virtio device/driver (e.g., vhost-scsi or vhost-net) may hang due to the loss of doorbell kick, e.g., https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.html ... or due to the loss of IRQ, e.g., as fixed by linux kernel commit fe200ae48ef5

Re: [PATCH 7/7] block/nbd: stop manipulating in_flight counter

2021-03-26 Thread Roman Kagan
On Tue, Mar 16, 2021 at 09:37:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.03.2021 19:08, Roman Kagan wrote: > > On Mon, Mar 15, 2021 at 11:15:44PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 15.03.2021 09:06, Roman Kagan wrote: > > > > As the reconnect logic no longer interferes

[Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-03-26 Thread Christian Ehrhardt 
Thanks David, I have no threadripper around atm, I think I can next week get hands on an EPYC Rome, but that isn't 100% the same. But gladly you tried this on the latest qemu 5.2 and since it is failing there as well it might be worth to also report it upstream. That is a great community which

[PATCH v4 0/4] yank: Add chardev tests and fixes

2021-03-26 Thread Lukas Straub
Hello Everyone, These patches increase test coverage for yank, add tests and fix bugs and crashes in yank in combination with chardev-change. Please Review. Regards, Lukas Straub Changes: -v4: -test: fix CharChangeTestConfig structs on stack going out of scope -test: move after bugfixes -v3:

[PATCH v4 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new

2021-03-26 Thread Lukas Straub
Move object_property_try_add_child out of chardev_new into it's callers. This is a preparation for the next patches to fix yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- chardev/char.c | 42 -

[PATCH v4 2/4] chardev/char.c: Always pass id to chardev_new

2021-03-26 Thread Lukas Straub
Always pass the id to chardev_new, since it is needed to register the yank instance for the chardev. Also, after checking that nothing calls chardev_new with id=NULL, assert() that id!=NULL. This fixes a crash when using chardev-change to change a chardev to chardev-socket, which attempts to regis

[PATCH v4 4/4] tests: Add tests for yank with the chardev-change case

2021-03-26 Thread Lukas Straub
Add tests for yank with the chardev-change case. Signed-off-by: Lukas Straub --- MAINTAINERS| 1 + tests/unit/meson.build | 3 +- tests/unit/test-yank.c | 199 + 3 files changed, 202 insertions(+), 1 deletion(-) create mode 100644 tests/un

Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP

2021-03-26 Thread Jason Wang
在 2021/3/25 下午5:00, Yuri Benditovich 写道: Hi Jason, This was discussed earlier on the previous series of patches. https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01829.html There were strong objections from both Daniel and Michael and I feel that the series was rejected. There was Mich

[PATCH v4 3/4] chardev: Fix yank with the chardev-change case

2021-03-26 Thread Lukas Straub
When changing from chardev-socket (which supports yank) to chardev-socket again, it fails, because the new chardev attempts to register a new yank instance. This in turn fails, as there still is the yank instance from the current chardev. Also, the old chardev shouldn't unregister the yank instance

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-26 Thread Howard Spoelstra
Hi Bin, (I forgot to reply to all) > > In answer to your questions: > > > > 1. Yes, slirp works on Windows 10 with this setup. > > 2. Yes, in Linux both tap and slirp work. > > Thanks! Just to be clear, the above testing was performed with commit > 969e50b61a285b0cc8dea6d4d2ade3f758d5ecc7, rig

Re: [PATCH v2 00/10] Acceptance Test: introduce base class for Linux based tests

2021-03-26 Thread Auger Eric
Hi Wainer, On 3/25/21 8:45 PM, Wainer dos Santos Moschetta wrote: > Hi, > > On 3/23/21 7:15 PM, Cleber Rosa wrote: >> This introduces a base class for tests that need to interact with a >> Linux guest.  It generalizes the "boot_linux.py" code, already been >> used by the "virtiofs_submounts.py" a

Re: [PATCH 0/7] block/nbd: decouple reconnect from drain

2021-03-26 Thread Roman Kagan
On Wed, Mar 17, 2021 at 11:35:31AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.03.2021 09:06, Roman Kagan wrote: > > The reconnection logic doesn't need to stop while in a drained section. > > Moreover it has to be active during the drained section, as the requests > > that were caught in-fligh

Re: [PATCH v4 0/4] yank: Add chardev tests and fixes

2021-03-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1616744509.git.lukasstra...@web.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1616744509.git.lukasstra...@web.de Subject: [PATCH v4 0/4] yank: Add chardev tests and

Re: [PATCH v4 0/4] yank: Add chardev tests and fixes

2021-03-26 Thread Lukas Straub
On Fri, 26 Mar 2021 01:09:46 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/cover.1616744509.git.lukasstra...@web.de/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-i

[Bug 1921468] Re: [UBUNTU 20.04] KVM guest fails to find zipl boot menu index

2021-03-26 Thread Frank Heimes
** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: ubuntu-z-systems Importance: Undecided Status: New ** Changed in: ubuntu-z-systems Assignee: (unassigned) => Skipper Bug Screeners (skipper-screen-team) ** Changed in: qe

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-26 Thread BALATON Zoltan
On Fri, 26 Mar 2021, Howard Spoelstra wrote: On Fri, Mar 26, 2021 at 2:50 AM Bin Meng wrote: Hi Howard, On Fri, Mar 26, 2021 at 1:35 AM Peter Maydell wrote: (adding the relevant people to the cc list) On Thu, 25 Mar 2021 at 17:26, Howard Spoelstra wrote: Hi, When running qemu-system-p

Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-26 Thread Arnd Bergmann
On Fri, Mar 26, 2021 at 8:14 AM Viresh Kumar wrote: > On 25-03-21, 17:16, Arnd Bergmann wrote: > > On Wed, Mar 24, 2021 at 8:33 AM Viresh Kumar > > wrote: > > > > It looks like you are not handling endianness conversion here. As far as I > > can tell, the protocol requires little-endian data, b

Re: [PATCH v4 1/4] virtio:add support in configure interrupt

2021-03-26 Thread Jason Wang
在 2021/3/25 下午3:15, Cindy Lu 写道: +enum virtio_config_status { +VIRTIO_CONFIG_SUPPORT, +VIRTIO_CONFIG_WORK, +VIRTIO_CONFIG_STOP, +VIRTIO_CONFIG_STATUS_UNKNOWN, Any reason for this extra state? I think we can know whether the config interrupt is being used through a Thanks The

Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-26 Thread Arnd Bergmann
On Fri, Mar 26, 2021 at 7:01 AM Viresh Kumar wrote: > On 25-03-21, 17:16, Arnd Bergmann wrote: > > On Wed, Mar 24, 2021 at 8:33 AM Viresh Kumar > > wrote: > > > > > +static uint8_t vi2c_xfer(VuDev *dev, struct i2c_msg *msg) > > > +{ > > > +VuI2c *i2c = container_of(dev, VuI2c, dev.parent); >

Re: Fail to create sev-guest object on 6.0.0-rc0

2021-03-26 Thread Paolo Bonzini
On 25/03/21 21:31, Tom Lendacky wrote: On 3/25/21 1:51 PM, Brijesh Singh wrote: Hi All, It seems creating the sev-guest object is broken rc0 tag. The following command is no longer able to create the sev-guest object $QEMU \  -machine ...,confidential-guest-support=sev0 \  -object sev-gues

Re: [PATCH 0/3] s390x: modularize virtio-gpu-ccw

2021-03-26 Thread Gerd Hoffmann
Hi, > Compared to Daniels suggestion, I find that one conceptually clearer, > and even more flexible. Implementation-wise I find this patch-set > simpler. Given we are in fixes-only mode I think we should go for the simple solution. Should be easy enough to revert in case we want replace this

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-26 Thread Jason Wang
在 2021/3/26 下午4:21, BALATON Zoltan 写道: On Fri, 26 Mar 2021, Howard Spoelstra wrote: On Fri, Mar 26, 2021 at 2:50 AM Bin Meng wrote: Hi Howard, On Fri, Mar 26, 2021 at 1:35 AM Peter Maydell wrote: (adding the relevant people to the cc list) On Thu, 25 Mar 2021 at 17:26, Howard Spoelstra

Re: [PATCH] MAINTAINERS: add/replace backups for some s390 areas

2021-03-26 Thread Christian Borntraeger
On 25.03.21 14:55, Matthew Rosato wrote: S390 PCI currently has no backup, add one. Add an additional backup for vfio-ccw and refresh the backup for vfio-ap. Signed-off-by: Matthew Rosato Acked-by: Christian Borntraeger --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 de

Re: Bug with Windows tap network when running qemu-system-ppc with Mac OS 9 guest

2021-03-26 Thread Bin Meng
On Fri, Mar 26, 2021 at 4:49 PM Jason Wang wrote: > > > 在 2021/3/26 下午4:21, BALATON Zoltan 写道: > > On Fri, 26 Mar 2021, Howard Spoelstra wrote: > >> On Fri, Mar 26, 2021 at 2:50 AM Bin Meng wrote: > >>> > >>> Hi Howard, > >>> > >>> On Fri, Mar 26, 2021 at 1:35 AM Peter Maydell > >>> wrote: > >>>

Re: [PATCH] linux-user: allow NULL msg in recvfrom

2021-03-26 Thread Laurent Vivier
Le 26/03/2021 à 05:05, Zach Reizner a écrit : > The kernel allows a NULL msg in recvfrom so that he size of the next > message may be queried before allocating a correctly sized buffer. This > change allows the syscall translator to pass along the NULL msg pointer > instead of returning early with

Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP

2021-03-26 Thread Yuri Benditovich
On Fri, Mar 26, 2021 at 10:51 AM Jason Wang wrote: > > > 在 2021/3/25 下午5:00, Yuri Benditovich 写道: > > Hi Jason, > > > > This was discussed earlier on the previous series of patches. > > https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01829.html > > There were strong objections from both D

Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP

2021-03-26 Thread Jason Wang
在 2021/3/26 下午5:09, Yuri Benditovich 写道: On Fri, Mar 26, 2021 at 10:51 AM Jason Wang wrote: 在 2021/3/25 下午5:00, Yuri Benditovich 写道: Hi Jason, This was discussed earlier on the previous series of patches. https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01829.html There were strong

Re: [PATCH] Document qemu-img options data_file and data_file_raw

2021-03-26 Thread Max Reitz
On 01.03.21 18:28, Connor Kuehl wrote: The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original wording

[PATCH v3 1/7] ui: add clipboard infrastructure

2021-03-26 Thread Gerd Hoffmann
Add some infrastructure to manage the clipboard in qemu. TODO: Add API docs. Signed-off-by: Gerd Hoffmann --- include/ui/clipboard.h | 68 +++ ui/clipboard.c | 92 ++ ui/meson.build | 1 + 3 files changed, 161

[PATCH v3 2/7] ui/vdagent: core infrastructure

2021-03-26 Thread Gerd Hoffmann
The vdagent protocol allows the guest agent (spice-vdagent) and the spice client exchange messages to implement features which require guest cooperation, for example clipboard support. This is a qemu implementation of the spice client side. This allows the spice guest agent talk to qemu directly

Re: [PATCH for-6.0 1/4] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev()

2021-03-26 Thread Auger Eric
Hi Peter, On 3/25/21 4:33 PM, Peter Maydell wrote: > The function machine_class_allow_dynamic_sysbus_dev() is currently > undocumented; add a doc comment. > > Signed-off-by: Peter Maydell > --- > include/hw/boards.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/inclu

[PATCH v3 0/7] ui: add vdagent implementation and clipboard support.

2021-03-26 Thread Gerd Hoffmann
Fist sketch of cut+paste support for vnc. On the guest side we are going to reuse the spice vdagent, so things should work out-of-the-box with guests in the wild. So this patch set brings a qemu implemenation of the vdagent protocol. Beside that there is the clipboard infrastructure of course.

[PATCH v3 5/7] ui/vnc: clipboard support

2021-03-26 Thread Gerd Hoffmann
This patch adds support for cut+paste to the qemu vnc server, which allows the vnc client exchange clipbaord data with qemu and other peers like the qemu vdagent implementation. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 24 ui/vnc-clipboard.c | 323 +

[PATCH v3 6/7] ui/gtk: move struct GtkDisplayState to ui/gtk.h

2021-03-26 Thread Gerd Hoffmann
Want place gtk clipboard code in a separate C file, which in turn requires GtkDisplayState being in a header file. So move it. No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 57 ui/gtk.c | 55 --

[PATCH v3 4/7] ui/vdagent: add clipboard support

2021-03-26 Thread Gerd Hoffmann
This patch adds support for clipboard messages to the qemu vdagent implementation, which allows the guest exchange clipboard data with qemu. Clipboard support can be enabled/disabled using the new 'clipboard' parameter for the vdagent chardev. Default is off. Signed-off-by: Gerd Hoffmann --- c

[PATCH v3 7/7] ui/gtk: add clipboard support

2021-03-26 Thread Gerd Hoffmann
This patch adds clipboard support to the qemu gtk ui. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 10 +++ ui/gtk-clipboard.c | 192 + ui/gtk.c | 1 + ui/meson.build | 2 +- 4 files changed, 204 insertions(+), 1 deletion(-)

[PATCH v3 3/7] ui/vdagent: add mouse support

2021-03-26 Thread Gerd Hoffmann
This patch adds support for mouse messages to the vdagent implementation. This can be enabled/disabled using the new 'mouse' parameter for the vdagent chardev. Default is on. Signed-off-by: Gerd Hoffmann --- chardev/char.c | 3 + ui/vdagent.c | 150 +

Re: [PATCH for-6.0 2/4] machine: Provide a function to check the dynamic sysbus whitelist

2021-03-26 Thread Auger Eric
Hi Peter, On 3/25/21 4:33 PM, Peter Maydell wrote: > Provide a new function dynamic_sysbus_dev_allowed() which checks > the per-machine whitelist of dynamic sysbus devices and returns > a boolean result indicating whether the device is whitelisted. > We can use this in the implementation of valida

Re: [PATCH for-6.0 3/4] hw/arm/virt: Only try to add valid dynamic sysbus devices to platform bus

2021-03-26 Thread Auger Eric
Hi Peter, On 3/25/21 4:33 PM, Peter Maydell wrote: > The virt machine device plug callback currently calls > platform_bus_link_device() for any sysbus device. This is overly > broad, because platform_bus_link_device() will unconditionally grab > the IRQs and MMIOs of the device it is passed, whet

Re: [PATCH for-6.0 4/4] hw/ppc/e500plat: Only try to add valid dynamic sysbus devices to platform bus

2021-03-26 Thread Auger Eric
On 3/25/21 4:33 PM, Peter Maydell wrote: > The e500plat machine device plug callback currently calls > platform_bus_link_device() for any sysbus device. This is overly > broad, because platform_bus_link_device() will unconditionally grab > the IRQs and MMIOs of the device it is passed, whether

Re: [PATCH v3 0/7] ui: add vdagent implementation and clipboard support.

2021-03-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210326092448.367016-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210326092448.367016-1-kra...@redhat.com Subject: [PATCH v3 0/7] ui: add vdagent implement

[PATCH for-6.0] hw/usb/hcd-ehci: Fix crash when showing help of EHCI devices

2021-03-26 Thread Thomas Huth
QEMU crashes with certain targets when trying to show the help output of EHCI devices: $ ./qemu-system-aarch64 -device ich9-usb-ehci1,help qemu-system-aarch64: ../../devel/qemu/softmmu/physmem.c:1154: phys_section_add: Assertion `map->sections_nb < TARGET_PAGE_SIZE' failed. Aborted (core dumped)

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-26 Thread Vladimir Sementsov-Ogievskiy
25.03.2021 19:57, Valeriy Vdovin wrote: Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual cpu generation: QEMU first

[PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
ObjectType and ObjectOptions are defined in a target-independent file, therefore they do not have access to target-specific configuration symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, pef-guest and sev-guest are currently omitted when compiling the generated QAPI files. In additi

[Bug 1920752] Re: USB SoundCard Passthrough not working on arm64

2021-03-26 Thread Gerd Hoffmann
Can you record usb traffic (add pcap= to usb-host)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920752 Title: USB SoundCard Passthrough not working on arm64 Status in QEMU: New Bug descripti

Re: [PATCH V3] target/riscv: Align the data type of reset vector address

2021-03-26 Thread Dylan Jhong
On Fri, Mar 26, 2021 at 04:19:09AM +0800, Alistair Francis wrote: > On Thu, Mar 25, 2021 at 5:43 AM Dylan Jhong wrote: > > > > Signed-off-by: Dylan Jhong > > Signed-off-by: Ruinland ChuanTzu Tsai > > --- > > target/riscv/cpu.c | 6 +- > > target/riscv/cpu.h | 2 +- > > 2 files changed, 6 in

Re: [PULL 0/2] Block patches

2021-03-26 Thread Peter Maydell
On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi wrote: > > The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' > into staging (2021-03-23 23:47:30 +) > > are available in the Git repositor

Re: [PATCH for-6.0 1/4] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev()

2021-03-26 Thread Peter Maydell
On Fri, 26 Mar 2021 at 09:27, Auger Eric wrote: > > Hi Peter, > > On 3/25/21 4:33 PM, Peter Maydell wrote: > > The function machine_class_allow_dynamic_sysbus_dev() is currently > > undocumented; add a doc comment. > > > > Signed-off-by: Peter Maydell > > --- > > include/hw/boards.h | 14 +++

Re: [PATCH for-6.0 1/4] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev()

2021-03-26 Thread Auger Eric
Hi Peter, On 3/26/21 11:20 AM, Peter Maydell wrote: > On Fri, 26 Mar 2021 at 09:27, Auger Eric wrote: >> >> Hi Peter, >> >> On 3/25/21 4:33 PM, Peter Maydell wrote: >>> The function machine_class_allow_dynamic_sysbus_dev() is currently >>> undocumented; add a doc comment. >>> >>> Signed-off-by: P

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Markus Armbruster
Paolo Bonzini writes: > ObjectType and ObjectOptions are defined in a target-independent file, > therefore they do not have access to target-specific configuration > symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, > pef-guest and sev-guest are currently omitted when compiling the

Re: [PATCH V3] target/riscv: Align the data type of reset vector address

2021-03-26 Thread Peter Maydell
On Fri, 26 Mar 2021 at 10:21, Dylan Jhong wrote: > Currently, there is no structure like "qdev_prop_target_ulong". > So, we still need to use an if-else condition to determine the attributes of > the 5th parameter. > Something like this: > #if defined(TARGET_RISCV32) > DEFINE_PROP_UNS

Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Vladimir Sementsov-Ogievskiy
10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1]. There is no good reason for that except that it means we will not ha

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
On 26/03/21 11:57, Markus Armbruster wrote: 'rng-random': 'RngRandomProperties', 'secret': 'SecretProperties', 'secret_keyring': 'SecretKeyringProperties', - 'sev-guest': { 'type': 'SevGuestProperties',

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Markus Armbruster
Paolo Bonzini writes: > On 26/03/21 11:57, Markus Armbruster wrote: >>> 'rng-random': 'RngRandomProperties', >>> 'secret': 'SecretProperties', >>> 'secret_keyring': 'SecretKeyringProperties', >>> - 'sev-guest':

Re: [Qemu-devel] [PULL v5 39/43] hw/hppa: Implement DINO system board

2021-03-26 Thread Richard Henderson
On 3/25/21 5:17 PM, Philippe Mathieu-Daudé wrote: +/* Set up windows into PCI bus memory. */ +for (i = 1; i < 31; i++) { +uint32_t addr = 0xf000 + i * DINO_MEM_CHUNK_SIZE; +char *name = g_strdup_printf("PCI Outbound Window %d", i); +memory_region_init_alias(&s

Re: [PATCH v5 10/10] target/ppc: Validate hflags with CONFIG_DEBUG_TCG

2021-03-26 Thread Richard Henderson
On 3/25/21 2:47 AM, David Gibson wrote: On Wed, Mar 24, 2021 at 11:12:20AM +1100, David Gibson wrote: On Tue, Mar 23, 2021 at 12:43:40PM -0600, Richard Henderson wrote: Verify that hflags was updated correctly whenever we change cpu state that is used by hflags. Signed-off-by: Richard Henderso

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-26 Thread Gerd Hoffmann
Hi, > eg a trace point "dma_map_wait" gets mapped to probes in many > .stp files, once per target, because we need to match based on > the executable path: > > probe qemu.system.x86_64.dma_map_wait = > process("/usr/libexec/qemu-system-x86_64").mark("dma_map_wait") > probe qemu.system.x86_

[PULL 0/9] Fixes 20210326 patches

2021-03-26 Thread Gerd Hoffmann
The following changes since commit 9e2e9fe3df9f539f8b6941ceb96d25355fdae47e: Update version for v6.0.0-rc0 release (2021-03-24 19:50:49 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20210326-pull-request for you to fetch changes up to

[PULL 3/9] vhost-user-gpu: fix vugbm_device_init fallback

2021-03-26 Thread Gerd Hoffmann
From: Marc-André Lureau vugbm implements GBM device wrapping, udmabuf and memory fallback. However, the fallback/detection logic is flawed, as if "/dev/udmabuf" failed to be opened, it will not initialize vugbm and crash later. Rework the vugbm_device_init() logic to initialize correctly in all

[PULL 2/9] vhost-user-gpu: glFlush before notifying clients

2021-03-26 Thread Gerd Hoffmann
From: Marc-André Lureau For similar reasons as commit 3af1671852 ("spice: flush on GL update before notifying client"), vhost-user-gpu must ensure the GL state is flushed before sharing its rendering result. Signed-off-by: Marc-André Lureau Message-Id: <20210312100108.2706195-3-marcandre.lur...

[PULL 6/9] s390x: move S390_ADAPTER_SUPPRESSIBLE

2021-03-26 Thread Gerd Hoffmann
The definition S390_ADAPTER_SUPPRESSIBLE was moved to "cpu.h", per suggestion of Thomas Huth. From interface design perspective, IMHO, not a good thing as it belongs to the public interface of css_register_io_adapters(). We did this because CONFIG_KVM requeires NEED_CPU_H and Thomas, and other comm

[PULL 1/9] usb: Remove "-usbdevice ccid"

2021-03-26 Thread Gerd Hoffmann
From: Thomas Huth "-usbdevice ccid" was not documented and -usbdevice itself was marked as deprecated before QEMU v6.0. And searching for "-usbdevice ccid" in the internet does not show any useful results, so likely nobody was using the ccid device via the -usbdevice option. Remove it now. Signe

[PULL 7/9] s390x: add have_virtio_ccw

2021-03-26 Thread Gerd Hoffmann
Introduce a symbol which can be used to prevent ccw modules being loaded into system emulators without ccw support. Signed-off-by: Gerd Hoffmann Reviewed-by: Halil Pasic Tested-by: Halil Pasic Message-Id: <20210317095622.2839895-3-kra...@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/s390x/v

[PULL 5/9] hw/usb/hcd-ehci-sysbus: Free USBPacket on instance finalize()

2021-03-26 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé When building with --enable-sanitizers we get: Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0x5618479ec7cf in malloc (qemu-system-aarch64+0x233b7cf) #1 0x7f675745f958 in g_malloc (/lib64/libglib-2.0.so.0+0x58958) #2 0x561847f02ca2 i

[PULL 4/9] vhost-user-gpu: fix cursor move/update

2021-03-26 Thread Gerd Hoffmann
From: Marc-André Lureau "move" is incorrectly initialized. Fix it by using a switch statement and also treating unknown commands with a fallback. Signed-off-by: Marc-André Lureau Message-Id: <20210312100108.2706195-5-marcandre.lur...@redhat.com> Signed-off-by: Gerd Hoffmann --- contrib/vhost

[PULL 8/9] s390x: modularize virtio-gpu-ccw

2021-03-26 Thread Gerd Hoffmann
Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may not be installed along with the qemu package leads to problems. Namely if the hw-display-virtio-gp

[PULL 9/9] hw/usb/hcd-ehci: Fix crash when showing help of EHCI devices

2021-03-26 Thread Gerd Hoffmann
From: Thomas Huth QEMU crashes with certain targets when trying to show the help output of EHCI devices: $ ./qemu-system-aarch64 -device ich9-usb-ehci1,help qemu-system-aarch64: ../../devel/qemu/softmmu/physmem.c:1154: phys_section_add: Assertion `map->sections_nb < TARGET_PAGE_SIZE' failed. Ab

Re: [RFC PATCH-for-6.1 00/10] hw/misc: Add memory_region_add_subregion_aliased() helper

2021-03-26 Thread Richard Henderson
On 3/25/21 6:27 PM, Philippe Mathieu-Daudé wrote: This series introduce the memory_region_add_subregion_aliased() helper which basically create a device which maps a subregion multiple times. I must say, the example mtree changes are persuasive. I'll look in more detail later. r~

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-26 Thread Richard Henderson
On 3/25/21 7:47 PM, Robert Hoo wrote: On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: On 3/24/21 9:15 PM, Robert Hoo wrote: +} else if (env->xcr0 & XFEATURE_AVX) { This is normally a 2-bit test. I beg your pardon. What 2 bits? I forget the names, but isn't the usual te

Re: [PATCH] linux-user: allow NULL msg in recvfrom

2021-03-26 Thread Laurent Vivier
Le 26/03/2021 à 05:05, Zach Reizner a écrit : > The kernel allows a NULL msg in recvfrom so that he size of the next > message may be queried before allocating a correctly sized buffer. This > change allows the syscall translator to pass along the NULL msg pointer > instead of returning early with

Re: [PATCH] linux-user: allow NULL msg in recvfrom

2021-03-26 Thread Peter Maydell
On Fri, 26 Mar 2021 at 13:24, Laurent Vivier wrote: > > Le 26/03/2021 à 05:05, Zach Reizner a écrit : > > The kernel allows a NULL msg in recvfrom so that he size of the next > > message may be queried before allocating a correctly sized buffer. This > > change allows the syscall translator to pas

Re: [PATCH 1/2] hw/riscv: sifive_u: Allow passing custom DTB

2021-03-26 Thread Bin Meng
On Wed, Mar 24, 2021 at 9:41 PM Bin Meng wrote: > > Hi Anup, > > On Thu, Oct 22, 2020 at 1:34 PM Anup Patel wrote: > > > > Extend sifive_u machine to allow passing custom DTB using "-dtb" > > command-line parameter. This will help users pass modified DTB > > or Linux SiFive DTB to sifive_u machin

[PATCH v3 1/1] docs/devel: Add VFIO device migration documentation

2021-03-26 Thread Tarun Gupta
Document interfaces used for VFIO device migration. Added flow of state changes during live migration with VFIO device. Tested by building docs with the new vfio-migration.rst file. v3: - Add introductory line about VM migration in general. - Remove occurcences of vfio_pin_pages() to describe pinn

Re: [RFC v11 45/55] target/arm: cpu-sve: new module

2021-03-26 Thread Claudio Fontana
On 3/25/21 7:48 PM, Claudio Fontana wrote: > On 3/25/21 7:40 PM, Richard Henderson wrote: >> On 3/23/21 9:46 AM, Claudio Fontana wrote: >>> extract the SVE-related cpu object properties and functions, >>> and move them to a separate module. >>> >>> Disentangle SVE from pauth that is a separate, TCG

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-26 Thread Peter Maydell
ping for review? thanks -- PMM On Fri, 19 Mar 2021 at 16:24, Peter Maydell wrote: > > In commit 81b3ddaf8772ec we fixed a use of uninitialized data > in read_tcnt(). However this change wasn't enough to placate > Coverity, which is not smart enough to see that if we read a > 2 bit field and then

Re: [PATCH] linux-user: allow NULL msg in recvfrom

2021-03-26 Thread Laurent Vivier
Le 26/03/2021 à 14:28, Peter Maydell a écrit : > On Fri, 26 Mar 2021 at 13:24, Laurent Vivier wrote: >> >> Le 26/03/2021 à 05:05, Zach Reizner a écrit : >>> The kernel allows a NULL msg in recvfrom so that he size of the next >>> message may be queried before allocating a correctly sized buffer. T

Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements

2021-03-26 Thread Max Reitz
On 23.03.21 19:19, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patches 1-2) - it is possible to do "./check -- ../../../tests/qemu

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Tom Lendacky
On 3/26/21 5:03 AM, Paolo Bonzini wrote: > ObjectType and ObjectOptions are defined in a target-independent file, > therefore they do not have access to target-specific configuration > symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, > pef-guest and sev-guest are currently omitted wh

Re: [PATCH v3 2/3] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-03-26 Thread Shivaprasad G Bhat
On 3/25/21 7:21 AM, David Gibson wrote: On Wed, Mar 24, 2021 at 09:34:06AM +0530, Aneesh Kumar K.V wrote: On 3/24/21 8:37 AM, David Gibson wrote: On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote: The patch adds support for the SCM flush hcall for the nvdimm devices. ... col

Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Max Reitz
On 26.03.21 12:48, Vladimir Sementsov-Ogievskiy wrote: 10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1].  There is no

Re: [PATCH] net/npcm7xx_emc.c: Fix handling of receiving packets when RSDR not set

2021-03-26 Thread Peter Maydell
On Fri, 19 Mar 2021 at 19:51, Doug Evans wrote: > > Turning REG_MCMDR_RXON is enough to start receiving packets. > > Signed-off-by: Doug Evans > --- > hw/net/npcm7xx_emc.c | 4 +++- > tests/qtest/npcm7xx_emc-test.c | 30 +- > 2 files changed, 24 insertions(

Re: [PATCH] hw/display/xlnx_dp: Free FIFOs adding xlnx_dp_finalize()

2021-03-26 Thread Peter Maydell
On Tue, 23 Mar 2021 at 18:30, Philippe Mathieu-Daudé wrote: > > When building with --enable-sanitizers we get: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x5618479ec7cf in malloc (qemu-system-aarch64+0x233b7cf) > #1 0x7f675745f958 in g_malloc (/lib64/libglib-2.

Re: [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid()

2021-03-26 Thread Peter Maydell
On Thu, 25 Mar 2021 at 14:27, Zenghui Yu wrote: > > They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement > translate callback") but never actually used. Drop them. > > Signed-off-by: Zenghui Yu > --- Applied to target-arm.next, thanks. -- PMM

[PATCH] iotests/116: Fix reference output

2021-03-26 Thread Max Reitz
15ce94a68ca ("block/qed: bdrv_qed_do_open: deal with errp") has improved the qed driver's error reporting, though sadly did not add a test for it. The good news are: There already is such a test, namely 116. The bad news are: Its reference output was not adjusted, and so now it fails. Let's fix th

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-26 Thread Robert Hoo
On Fri, 2021-03-26 at 07:11 -0600, Richard Henderson wrote: > On 3/25/21 7:47 PM, Robert Hoo wrote: > > On Thu, 2021-03-25 at 06:39 -0600, Richard Henderson wrote: > > > On 3/24/21 9:15 PM, Robert Hoo wrote: > > > > > > +} else if (env->xcr0 & XFEATURE_AVX) { > > > > > > > > > > This is no

Re: [PATCH] target/arm: Make number of counters in PMCR follow the CPU

2021-03-26 Thread Richard Henderson
On 3/11/21 10:59 AM, Peter Maydell wrote: Currently we give all the v7-and-up CPUs a PMU with 4 counters. This means that we don't provide the 6 counters that are required by the Arm BSA (Base System Architecture) specification if the CPU supports the Virtualization extensions. Instead of havin

Re: [PATCH] iotests/116: Fix reference output

2021-03-26 Thread Eric Blake
On 3/26/21 9:14 AM, Max Reitz wrote: > 15ce94a68ca ("block/qed: bdrv_qed_do_open: deal with errp") has improved > the qed driver's error reporting, though sadly did not add a test for > it. > The good news are: There already is such a test, namely 116. > The bad news are: Its reference output was n

[PATCH v3 0/5] qemu-iotests: quality of life improvements

2021-03-26 Thread Paolo Bonzini
This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patches 1-2) - it is possible to do "./check -- ../../../tests/qemu-iotests/055 args..." and specify arbitra

[PATCH v3 1/5] qemu-iotests: do not buffer the test output

2021-03-26 Thread Paolo Bonzini
Instead of buffering the test output into a StringIO, patch it on the fly by wrapping sys.stdout's write method. This can be done unconditionally, even if using -d, which makes execute_unittest a bit simpler. Signed-off-by: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Eman

[PATCH v3 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv

2021-03-26 Thread Paolo Bonzini
In the next patch, "check" will learn how to execute a test script without going through TestRunner. To enable this, keep only the text output and subprocess handling in the TestRunner; move into TestEnv the logic to prepare for running a subprocess. Reviewed-by: Vladimir Sementsov-Ogievskiy Sig

[PATCH v3 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts

2021-03-26 Thread Paolo Bonzini
Python test scripts that use unittest consist of multiple tests. unittest.main allows selecting which tests to run, but currently this is not possible because the iotests wrapper ignores sys.argv. unittest.main command line options also allow the user to pick the desired options for verbosity, fai

[PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-26 Thread Paolo Bonzini
Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only run a specific subtest. Move the trailing

[PATCH v3 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment

2021-03-26 Thread Paolo Bonzini
Due to a typo, in this case the SOCK_DIR was not being created. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Tested-by: Emanuele Giuseppe Esposito Message-Id: <20210323181928.311862-6-pbonz...@redhat.com> --- tests/qemu-iotests/testenv.py | 2 +- 1 file changed, 1 ins

Re: [PATCH v2 1/3] hw/display/bcm2835_fb: Resize console on reset

2021-03-26 Thread Peter Maydell
On Tue, 23 Mar 2021 at 16:14, Philippe Mathieu-Daudé wrote: > > We want to remove the bcm2835_fb_reset() call in bcm2835_fb_realize() > but doing triggers: > > hw/display/bcm2835_fb.c:131:13: runtime error: store to null pointer of > type 'uint32_t' (aka 'unsigned int') > SUMMARY: UndefinedBe

Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Vladimir Sementsov-Ogievskiy
26.03.2021 16:47, Max Reitz wrote: On 26.03.21 12:48, Vladimir Sementsov-Ogievskiy wrote: 10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at

Re: [PATCH 2/2] Support monitor chardev hotswap with QMP

2021-03-26 Thread Markus Armbruster
Li Zhang writes: > Hi, > > Any comments about this patch? I wanted to review this before my Easter break, but I'm out of time :( When I'm back (April 6), I'll check whether it still needs review, but I do hope somebody else can look at it sooner.

Re: [PATCH 1/2] Fix the segment fault when calling yank_register_instance

2021-03-26 Thread Markus Armbruster
Looks like a bug fix. Lukas, can you take care of it in time for 6.0? Li Zhang writes: > From: Li Zhang > > When executing the QMP commands "chardev-change" to change the > backend device to socket, it will cause a segment fault because > it assumes chr->label as non-NULL in function yank_regi

Re: [PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-26 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote: >> If OOB is disabled, events received in monitor_qmp_event will be handled >> in the main context. Thus, we must not acquire a qmp_queue_lock there, >> as the dispatcher coroutine holds one over a yield po

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
On 26/03/21 13:27, Markus Armbruster wrote: ... until Kevin added some when he QAPIfied. Looks like this (copied from qemu-qmp-ref.7)[*]: SevGuestProperties (Object) Properties for sev-guest objects. Members sev-device: string (optional) SEV device to use

  1   2   3   >