From: Zihao Chang
This patch provides a new qmp to reload display configuration
without restart VM, but only reloading the vnc tls certificates
is implemented.
Example:
{"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true}}
Signed-off-by: Zihao Chang
Message-Id: <20210316
Windows guests using the "Basic Display Adapter" don't parse the
"Established timings III" block. They also don't parse any edid
extension.
So prefer the "Standard Timings" block to store the display resolutions
in edid_fill_modes(). Also reorder the mode list, so more exotic
resolutions (specif
From: Zihao Chang
This patch add vnc_display_reload_certs() to support
update x509 certificates.
Signed-off-by: Zihao Chang
Reviewed-by: Daniel P. Berrangé
Message-Id: <20210316075845.1476-3-changzih...@huawei.com>
Signed-off-by: Gerd Hoffmann
---
include/ui/console.h | 1 +
ui/vnc.c
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Test args-name-clash covers command parameter name clash. This
> effectively covers struct member name clash as well. The next commit
> will make paramater name clash impossible. Convert args-name-clash
parameter
> from testing command to testing
John Snow writes:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> Member name 'u' and names starting with 'has-' or 'has_' are reserved
>> for the generator. check_type() enforces this, covered by tests
>> reserved-member-u and reserved-member-has.
>> These tests neglect to cover optional memb
From: Hyman Huang(黄勇)
when execute the following test command:
$ ./guestperf-batch.py --auto-converge \
--auto-converge-step {percent} ...
test aborts and error message be throwed as the following:
"Parameter 'x-cpu-throttle-increment' is unexpected"
The reason is that 'x-cpu-throttle-increm
We do not move psci.c to tcg/ because we expect other
hypervisors to use it (waiting for HVF enablement).
Signed-off-by: Claudio Fontana
Cc: Alexander Graf
---
target/arm/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/target/arm/meson.build b/target/arm/meson.build
index 01
we need as a result to move switch_mode too,
so we put an implementation into cpu_user and cpu_sysemu.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h| 2 +
target/arm/cpu-common.c | 192 +++
target/arm/cpu-sysemu.c | 30 ++
target/arm/cpu-user.
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Struct members, including command arguments, event data, and union
> inline base members, should use '-', not '_'. Enforce this. Fix the
> fixable offenders (all in tests/), and add the remainder to pragma
> member-name-exceptions.
>
> Signed-off-by
at least the armv7m one should go away with proper
configuration changes (only enabling possible boards for KVM).
Signed-off-by: Claudio Fontana
---
target/arm/kvm/helper-stubs.c | 27 +++
target/arm/kvm/meson.build| 3 +++
target/arm/meson.build| 1 +
3 fil
move work is needed later on to split things into
tcg-specific portions and kvm-specific portions of this
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
---
target/arm/internals.h | 8 ++-
target/arm/cpu-sysemu.c | 105
target/arm/cpu.c
this should go away once the configuration and hw/arm is clean
Signed-off-by: Claudio Fontana
---
hw/arm/boot.c | 5 -
target/arm/arm-powerctl.c | 8 +---
target/arm/kvm/helper-stubs.c | 6 ++
3 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/hw/arm/
Signed-off-by: Claudio Fontana
---
target/arm/cpu-mmu.h| 3 +-
target/arm/cpu-mmu-sysemu.c | 149
2 files changed, 101 insertions(+), 51 deletions(-)
diff --git a/target/arm/cpu-mmu.h b/target/arm/cpu-mmu.h
index fdedc8fb92..01b060613a 100644
--- a/
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Enum members should use '-', not '_'. Enforce this. Fix the fixable
> offenders (all in tests/), and add the remainder to pragma
> member-name-exceptions.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Princip
Signed-off-by: Claudio Fontana
---
target/arm/cpu-mmu.c| 95 +
target/arm/tcg/helper.c | 95 -
2 files changed, 95 insertions(+), 95 deletions(-)
diff --git a/target/arm/cpu-mmu.c b/target/arm/cpu-mmu.c
index f46
Signed-off-by: Claudio Fontana
---
target/arm/cpu-common.c | 41 +
target/arm/tcg/helper.c | 29 -
target/arm/meson.build | 1 +
3 files changed, 42 insertions(+), 29 deletions(-)
create mode 100644 target/arm/cpu-common.c
di
and arm_phys_excp_target_el since it is tied up inside the
same #ifdef block.
aarch64_sync_32_to_64 and aarch64_sync_64_to_32 are
mixed in with the TCG helpers, but they shouldn't, as they
are needed for KVM too.
kvm_arch_get_registers()
{
if (!is_a64(env)) {
aarch64_sync_64_to_32(env
this function is used for kvm too, add it to the
cpu-common module.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-common.c | 11 +++
target/arm/tcg/helper.c | 11 ---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/target/arm/cpu-common.c b/target/arm/cpu-com
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
---
target/arm/cpu-common.c | 42 +
target/arm/tcg/helper.c | 41
2 files changed, 42 insertions(+), 41 deletions(-)
diff --git a/target/arm/cpu-common.
cpu.c,
cpu32.c,
cpu64.c,
tcg/sysemu/tcg-cpu.c,
all need a good cleanup when it comes to included header files.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.c| 8 ++--
target/arm/cpu32.c | 14 --
target/arm/cpu64.c | 6 --
targ
it is required by arch-dump.c and cpu.c, so apparently
we need this for KVM too
Signed-off-by: Claudio Fontana
---
target/arm/cpu-common.c | 43 +
target/arm/tcg/helper.c | 33 ---
2 files changed, 43 insertions(+), 33 deletions
move exception code out of tcg/
as we need part of it for KVM too.
put the exception code into separate cpu modules as appropriate,
including:
cpu-sysemu.c
tcg/tcg-cpu.c
tcg/sysemu/tcg-cpu.c
to avoid naming confusion with the existing cpu_tcg.c,
containg cpu models definitions for 32bit TCG-only
of note, cpreg lists were previously initialized by TCG first,
and then thrown away and replaced with the data coming from KVM.
Now we just initialize once, either for TCG or for KVM.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.c | 32 ++--
target/arm/kvm.c
provide helper functions there to initialize 32bit models,
and export the a15 cpu model.
We still need to keep around a15 until we sort out the board configurations.
cpu.c will continue to contain the common parts between
32 and 64.
Note that we need to build cpu32 also for TARGET_AARCH64,
becau
sve_tests_sve_max_vq_8,
sve_tests_sve_off,
test_query_cpu_model_expansion
all require TCG to run. Skip them for KVM-only builds.
Signed-off-by: Claudio Fontana
---
tests/qtest/arm-cpu-features.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/arm-cpu-features.c
There might be more than just KVM and TCG in the future,
so where appropriate, replace broad "else" statements
with the appropriate if (accel_enabled()) check.
Also invert some checks for !kvm_enabled() or !tcg_enabled()
where it seems appropriate to do so.
Note that to make qtest happy we need t
Signed-off-by: Claudio Fontana
---
target/arm/cpregs.h | 54 ++---
target/arm/cpregs.c | 60 ++
target/arm/tcg/cpregs.c | 253 ++--
3 files changed, 241 insertions(+), 126 deletions(-)
diff --git a/target/arm/cpregs.h b/target/arm/cpregs.
After this patch it is possible to build only kvm:
./configure --disable-tcg --enable-kvm
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sysemu.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/target/arm/cpu-sysemu.c b/target/arm/cpu-sysemu.c
index eb928832a
on ARM we currently list and build all machines, even when
building KVM-only, without TCG.
Until we fix this (and we only list and build machines that are
compatible with KVM), only test specifically using the "virt"
machine in this case.
Signed-off-by: Claudio Fontana
Cc: Philippe Mathieu-Daudé
This reverts commit 6e937ba7f8fb90d66cb3781f7fed32fb4239556a
This change breaks quickly at startup, as all interfaces in boards
are checked in vl.c in select_machine():
{
GSList *machines = object_class_get_list(TYPE_MACHINE, false);
}
In order to restrict v8M IDAU to TCG,
we need to first disa
The QEMU PSCI implementation is not used for KVM,
we do not need the kvm constants header.
Signed-off-by: Claudio Fontana
---
target/arm/arm-powerctl.h | 2 --
target/arm/psci.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/target/arm/arm-powerctl.h b/target/arm/arm-powerctl.h
ind
on ARM we currently list and build all machines, even when
building KVM-only, without TCG.
Until we fix this (and we only list and build machines that are
compatible with KVM), only test specifically using the "virt"
machine in this case.
Signed-off-by: Claudio Fontana
Cc: Philippe Mathieu-Daudé
cpu-vfp.c: vfp_get_fpsr and vfp_set_fpsr are needed also for KVM,
so create a new cpu-vfp.c
tcg/cpu-vfp.c: vfp_get_fpscr_from_host and vv are TCG-only, so we
move the implementation to tcg/cpu-vfp.c
kvm/helper-stubs.c: vfp_get_fpscr_from_host and vv stubs for KVM.
Signe
Skip the test_device_intro_concrete for now for ARM KVM-only build,
as on ARM we currently build devices for ARM that are not
compatible with a KVM-only build.
We can remove this workaround when we fix this in KConfig etc,
and we only list and build machines that are compatible with KVM
for KVM-on
test is TCG-only.
Signed-off-by: Claudio Fontana
Cc: Philippe Mathieu-Daudé
---
tests/qtest/bios-tables-test.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index e020c83d2a..bd7b85909c 100644
--- a/tests/qtest/bios-ta
we need this for KVM too.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sysemu.c | 60
target/arm/cpu-user.c | 5
target/arm/tcg/helper.c | 61 -
3 files changed, 65 insertions(+), 61 deletions(-)
diff
move init, realizefn and reset code into it.
Signed-off-by: Claudio Fontana
---
target/arm/internals.h | 1 -
target/arm/cpu-sysemu.c| 32 --
target/arm/cpu.c | 48 ++
target/arm/kvm/kvm-cpu.c | 128 +
target/arm/kvm
move init, realizefn and reset code into it.
Signed-off-by: Claudio Fontana
Cc: Paolo Bonzini
---
target/arm/tcg/tcg-cpu.h| 4 ++-
target/arm/cpu.c| 44 ++
target/arm/tcg/sysemu/tcg-cpu.c | 27
target/arm/tcg/tcg-cpu-models.c | 1
Signed-off-by: Claudio Fontana
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/cpu-sysemu.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/target/arm/cpu-sysemu.c b/target/arm/cpu-sysemu.c
index 126263dbf4..eb928832a9 100644
--- a/target/arm/cpu-sysemu.
restrict zcr_el1, zcr_el2, zcr_no_el2, zcr_el3 reginfo,
as well as related SVE functions.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h | 7 ---
target/arm/tcg/cpu-sve.h | 7 +++
linux-user/syscall.c | 4
target/arm/cpu-exceptions-aa64.c
this will allow us to restrict more code to TARGET_AARCH64
Signed-off-by: Claudio Fontana
---
target/arm/helper-a64.h | 2 ++
target/arm/helper.h | 1 -
target/arm/arch_dump.c | 12 +++-
target/arm/cpu.c| 1 -
target/arm/cpu64.c | 4
target/arm/tcg/helper.c | 1
When building a subset of targets, we don't need to install
a bunch of unrelated files. This series restrict the installed
blobs to what is simply required.
Combined with Paolo's series converting pc-bios/Makefile to
Meson, this should reduce the (CI) build cycles some more.
RFC because there is p
and adapt the code including the header references,
and trace-events / trace.h
Signed-off-by: Claudio Fontana
---
meson.build | 2 +-
target/arm/cpu.h | 2 +-
target/arm/{ => kvm}/kvm-consts.h | 0
target/arm/{ => kvm}/kvm_arm.h| 0
target/arm/kvm/t
Pointer Authentication is an AARCH64-only ARMv8.3 optional
extension, whose cpu properties can be separated out in its own module.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h | 13 +---
target/arm/tcg/cpu-pauth.h | 38 ++
target/arm/cpu.c | 3
when TARGET_AARCH64 is not defined, it is helpful to make
is_aa64() and arm_el_is_aa64 macros defined to "false".
This way we can make more code TARGET_AARCH64-only.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h| 37 -
target/arm/cpu-mmu-sys
As we want to conditionally install blob files,
declare them using a source set.
Signed-off-by: Philippe Mathieu-Daudé
---
pc-bios/meson.build | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index f2b32598af7..1c4074bcb0d 1
Signed-off-by: Claudio Fontana
---
target/arm/cpu.c | 4
target/arm/kvm/kvm-cpu.c | 1 +
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 5a76461e5b..5e0f6bd01d 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -778,10 +778
modules under tcg/ are only built for CONFIG_TCG anyway.
Signed-off-by: Claudio Fontana
---
target/arm/tcg/vfp_helper.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/arm/tcg/vfp_helper.c b/target/arm/tcg/vfp_helper.c
index 521719f327..0cc6c85270 100644
--- a/target/arm/tcg/vfp_
extract the exception handling code from cpu-sysemu,
and split it into general arm code and an AArch64-specific part.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-exceptions-aa64.h | 32 +
target/arm/cpu.h | 4 -
target/arm/arch_dump.c | 1 +
target/arm/cpu-ex
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Laszlo Ersek
Cc: Philippe Mathieu-Daudé
---
pc-bios/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index 1c4074bcb0d..d270d8516c9 100644
--- a/pc-bios/meson.build
+++ b/pc-
we need to be careful not to use
if (tcg_enabled())
here, because of the VMSTATE definitions in machine.c,
which are only protected by CONFIG_TCG, and thus
it would break the --enable-tcg --enable-kvm build.
Signed-off-by: Claudio Fontana
---
target/arm/tcg/tcg-cpu.h| 1 +
target/arm/
XXX Someone who really understands which properties should be added
where should review this attentively.
What goes into cpu leaf class initialization?
What goes into arm_post_init / accel_cpu?
What goes into arm_cpu_finalize_features / aarch64_cpu_finalize_features?
Should there be shift of more
Yes, I have:
commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6 (HEAD -> master, origin/master,
origin/HEAD)
Merge: c95bd5ff16 cffb446e8f
Author: Peter Maydell
Date: Mon Mar 22 18:50:25 2021 +
Or another branch?
--
You received this bug notification becau
put the KVM-specific and TCG-specific functionality
in the respective subdirectories kvm/ and tcg/
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sve.h | 2 +-
target/arm/kvm/cpu-sve.h | 30 +++
target/arm/tcg/cpu-sve.h | 24 ++
target/arm/cpu-sve.c | 166 +
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Stefan Weil
---
pc-bios/meson.build | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index d270d8516c9..007cf9d2afb 100644
--- a/pc-bios/meson.build
+++ b/pc-bios/meson.build
@@ -60,7
Hi Peter,
On Tue, Mar 23, 2021 at 12:28 PM Peter Maydell wrote:
>
> I just got this running 'make check-acceptance': does it
> ring a bell with anybody?
>
> [etc]
> Fetching asset from
> tests/acceptance/replay_kernel.py:ReplayKernelSlow.test_mips64el_malta_5KEc_cpio
> Fetching asset from
> tests
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Richard Henderson
Cc: Helge Deller
---
meson.build | 2 ++
pc-bios/meson.build | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 10c21ef52af..a7f3b60d08e 100644
--- a/meson.build
+++ b
extract the SVE-related cpu object properties and functions,
and move them to a separate module.
Disentangle SVE from pauth that is a separate, TCG-only feature.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sve.h | 40 +
target/arm/cpu.h | 22 +--
target/arm/cpu-sve.c
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Edgar E. Iglesias
---
meson.build | 2 ++
pc-bios/meson.build | 9 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index a7f3b60d08e..e3418815b04 100644
--- a/meson.build
+++ b/meson.build
@@
John Snow writes:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> check_type() fails to reject optional members with reserved names,
>> because it neglects to strip off the leading '*'. Fix that.
>> The stripping in check_name_str() is now useless. Drop.
>> Also drop the "no leading '*'" asse
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Palmer Dabbelt
Cc: Alistair Francis
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Cc: qemu-ri...@nongnu.org
---
meson.build | 2 ++
pc-bios/meson.build | 13 +
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/meso
all the features in arm_cpu_finalize_features are actually
TARGET_AARCH64-only, since KVM is now only supported on 64bit.
Therefore move the function to cpu64, and rename it to
aarch64_cpu_finalize_features.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h | 3 +-
target/arm/kvm/kvm
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Richard Henderson
---
meson.build | 2 ++
pc-bios/meson.build | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 5c85a15364d..b5b8892fe7a 100644
--- a/meson.build
+++ b/meson.build
@@ -9
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: David Gibson
Cc: Greg Kurz
Cc: qemu-...@nongnu.org
Cc: Mark Cave-Ayland
Cc: Hervé Poussineau
Cc: Cédric Le Goater
Cc: BALATON Zoltan
---
meson.build | 2 ++
pc-bios/meson.build | 21 +
2 files changed, 15 insertions(
it is needed just once, so just move the CONFIG_TCG check in place.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-mmu.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/target/arm/cpu-mmu.c b/target/arm/cpu-mmu.c
index c6ac90a61e..9969bc9d30 100644
--- a/target/ar
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Havard Skinnemoen
Cc: Tyrone Ting
Cc: qemu-...@nongnu.org
---
meson.build | 2 ++
pc-bios/meson.build | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index b5b8892fe7a..10c21ef52af 100644
As it is pointless to build ROMs/BIOS for user-only emulation,
restrict this directory to system-mode emulation.
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index e484670c5b7..457a07047b1 1
I think there's additional cleanup to be done here, where we can
move these two files from top-level to either accel/tcg/ or softmmu/.
But that will have to wait for the next devel cycle.
Changes from Phil's v2: Update MAINTAINERS.
r~
Richard Henderson (3):
exec: Rename exec-vary.c as page-v
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Cornelia Huck
Cc: Thomas Huth
Cc: qemu-s3...@nongnu.org
---
meson.build | 2 ++
pc-bios/meson.build | 9 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 4b614b30ed9..fccda30ffc7 100644
- Original Message -
> From: "Peter Maydell"
> To: "QEMU Developers"
> Cc: "Cleber Rosa"
> Sent: Tuesday, March 23, 2021 11:23:30 AM
> Subject: 'make check-acceptance' odd error: "'bytes' object has no attribute
> 'encode'"
>
> I just got this running 'make check-acceptance': does i
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
---
meson.build | 2 ++
pc-bios/meson.build | 9 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index fccda30ffc7..addea8c39d7 100644
--- a/meson.build
John Snow writes:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> Flat union tag values get checked twice: as enum member name, and as
>> union branch name. The former accepts leading digits, the latter
>> doesn't. The restriction feels arbitrary. Skip the latter check.
>> This can expose c_
Am 23.03.21 um 16:51 schrieb Philippe Mathieu-Daudé:
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Stefan Weil
---
pc-bios/meson.build | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index d270d8516c9..007cf9d2afb 100644
--
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Paolo Bonzini
Cc: Eduardo Habkost
Cc: Michael S. Tsirkin
Cc: Marcel Apfelbaum
---
meson.build | 2 ++
pc-bios/meson.build | 23 ++-
2 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/meson.build b/meson.bu
Cc'ing avocado-devel@
On 3/23/21 4:23 PM, Peter Maydell wrote:
> I just got this running 'make check-acceptance': does it
> ring a bell with anybody?
>
> [etc]
> Fetching asset from
> tests/acceptance/replay_kernel.py:ReplayKernelSlow.test_mips64el_malta_5KEc_cpio
> Fetching asset from
> tests/ac
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Union branche names should use '-', not '_'. Enforce this. The only
branch
> offenders are in tests/. Fix them.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
23.03.2021 18:29, Paolo Bonzini wrote:
On 23/03/21 15:34, Vladimir Sementsov-Ogievskiy wrote:
+ def __init__(self, *args, **kwargs):
+ super().__init__(stream=ReproducibleTextTestRunner.output, *args,
**kwargs)
over-79 line (PEP8)
Ok, thanks.
+
+def execute_unittest(argv, debug=
We want to remove the bcm2835_fb_reset() call in bcm2835_fb_realize()
but doing triggers:
hw/display/bcm2835_fb.c:131:13: runtime error: store to null pointer of type
'uint32_t' (aka 'unsigned int')
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
hw/display/bcm2835_fb.c:131:13 in
A
Arguably the target_cpu_copy_regs function for each architecture is
misnamed as a number of the architectures also take the opportunity to
fill out the TaskState structure. This could arguably be factored out
into common code but that would require a wider audit of the
architectures. For now just r
Hi Greg,
After your previous reply on this thread we started considering to provide this
interface and framework/functionality through a userspace service instead of a
kernel interface.
The latest iteration on this evolving patch-set doesn’t have strong reasons for
living in the kernel anymore
Since v1:
Resize console on reset to create the surface, see:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg794307.html
Philippe Mathieu-Daudé (3):
hw/display/bcm2835_fb: Resize console on reset
hw/display/bcm2835_fb: Use bcm2835_fb_reconfigure in bcm2835_fb_reset
hw/display/bcm2835_
>>From the semihosting point of view what we want to know is the current
mode of the processor. Unify this into a single helper and allow us to
use the same GET/SET_ARG helpers for the rest of the code. Having the
helper will also be useful later.
Note: we aren't currently testing riscv32 due to m
Directly use bcm2835_fb_reconfigure() instead of open coding it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/bcm2835_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
index 3e63d58e0b2..a9c2e57d1c6 100644
---
When QDev objects have their DeviceReset handler set, they
shouldn't worry about calling it at realization stage (it
is handled by hw/core/qdev.c::device_set_realized).
Remove the pointless/confusing bcm2835_fb_reset() call.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/bcm2835_fb.c | 2
23.03.2021 16:06, Paolo Bonzini wrote:
In the next patch, "check" will learn how to execute a test script without
going through TestRunner. To enable this, keep only the text output
and subprocess handling in the TestRunner; move into TestEnv the logic
to prepare for running a subprocess.
Signe
On Tue, 23 Mar 2021 16:04:11 +0100
Thomas Lamprecht wrote:
> On 23.03.21 15:55, Vitaly Cheptsov wrote:
> >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin написал(а):
> >>
> >> The issue is with people who installed a VM using 5.1 qemu,
> >> migrated to 5.2, booted there and set a config on a dev
On 03/23/21 16:51, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Laszlo Ersek
> Cc: Philippe Mathieu-Daudé
> ---
> pc-bios/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/meson.build b/pc-bios/meson.build
> inde
On 23/03/2021 16.51, Philippe Mathieu-Daudé wrote:
As it is pointless to build ROMs/BIOS for user-only emulation,
restrict this directory to system-mode emulation.
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mes
On 23/03/21 16:51, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Richard Henderson
---
meson.build | 2 ++
pc-bios/meson.build | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 5c85a15364d..b5b889
From: Laurent Vivier
And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,
use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw
for the tests that use iothreads.
Signed-off-by: Laurent Vivier
Reviewed-by: Thomas Huth
Message-Id: <20210319202335.2397060
On 23/03/21 16:51, Philippe Mathieu-Daudé wrote:
As we want to conditionally install blob files,
declare them using a source set.
Signed-off-by: Philippe Mathieu-Daudé
---
pc-bios/meson.build | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/pc-bios/meson.build b
exec-vary.c is about variable page size handling,
rename it page-vary.c. Currently this file is target
specific (built once for each target), comment this.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210322112427.4045204-2-f4...@amsat.org>
[rth: Update MAINTAINERS]
Signed-off-by: Richard
From: Laurent Vivier
Rather than checking if the machine is an s390x to use virtio-blk-ccw
instead of virtio-blk-pci, use the alias virtio-blk that is set to
the expected target.
This also enables the use of virtio-blk-device for targets without
PCI or CCW.
Signed-off-by: Laurent Vivier
Tested
Eric Blake writes:
> On 3/23/21 4:40 AM, Markus Armbruster wrote:
>> Type names should be CamelCase. Enforce this. The only offenders are
>> in tests/. Fix them. Add test type-case to cover the new error.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>
>> +++ b/scripts/qapi/expr.py
>> @@ -6
In the next commit we will extract the generic code out of
page-vary.c, only keeping the target specific code. Both
files will use the same TargetPageBits structure, so make
its declaration in a shared header.
As the common header can not use target specific types,
use a uint64_t to hold the page
In d0f26e68a0 ("gitlab: force enable docs build in Fedora, Ubuntu,
Debian") we made sure we can build the documents on more than one
system. However we don't want to build documents all the time as it's
a waste of cycles (and energy). So lets reduce the total amount of
documentation we build while
pci_irq_handler documents that it must be called with 0 <= irq_num <=
3 and level either 0 or 1. Add assertions that the caller has passed
us in valid arguments.
In particular, if a device model fails to set the PCI_INTERRUPT_PIN
field in its config space correctly to indicate that it has an
inte
In bbc17caf81f, we used an alias attribute to allow target_page
to be declared const, and yet be initialized late.
This fails when using LTO with several versions of gcc.
The compiler looks through the alias and decides that the const
variable is statically initialized to zero, then propagates tha
On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote:
> Hi Greg,
>
> After your previous reply on this thread we started considering to provide
> this interface and framework/functionality through a userspace service
> instead of a kernel interface.
> The latest iteration on t
201 - 300 of 562 matches
Mail list logo
