Re: [PATCH 04/38] target/riscv: 16-bit Addition & Subtraction Instructions

2021-02-18 Thread LIU Zhiwei
On 2021/2/13 2:03, Richard Henderson wrote: On 2/12/21 7:02 AM, LIU Zhiwei wrote: +if (a->rd && a->rs1 && a->rs2) { +#ifdef TARGET_RISCV64 +f64(vece, offsetof(CPURISCVState, gpr[a->rd]), +offsetof(CPURISCVState, gpr[a->rs1]), +offsetof(CPURISCVState, gpr[a->rs

Re: [PATCH 04/38] target/riscv: 16-bit Addition & Subtraction Instructions

2021-02-18 Thread LIU Zhiwei
On 2021/2/13 3:02, Richard Henderson wrote: On 2/12/21 7:02 AM, LIU Zhiwei wrote: +static void tcg_gen_simd_add16(TCGv d, TCGv a, TCGv b) +{ +TCGv t1 = tcg_temp_new(); +TCGv t2 = tcg_temp_new(); + +tcg_gen_andi_tl(t1, a, ~0x); +tcg_gen_add_tl(t2, a, b); +tcg_gen_add_tl

Re: [PATCH] qsd: Document FUSE exports

2021-02-18 Thread Max Reitz
On 17.02.21 17:26, Eric Blake wrote: On 2/17/21 5:58 AM, Max Reitz wrote: Implementing FUSE exports required no changes to the storage daemon, so we forgot to document them there. Considering that both NBD and vhost-user-blk exports are documented in its man page (and NBD exports in its --help

Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()

2021-02-18 Thread Christian Schoenebeck
On Montag, 15. Februar 2021 15:06:41 CET Christian Schoenebeck wrote: > On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote: > > From: qemu_oss--- via > > > > So far the qos subsystem of the qtest framework had the limitation > > that only one instance of the same official QEMU (QMP) dri

Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()

2021-02-18 Thread Paolo Bonzini
On 18/02/21 10:10, Christian Schoenebeck wrote: On Montag, 15. Februar 2021 15:06:41 CET Christian Schoenebeck wrote: On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote: From: qemu_oss--- via So far the qos subsystem of the qtest framework had the limitation that only one instance o

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Thomas Huth
On 18/02/2021 03.22, Halil Pasic wrote: Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may not be installed along with the qemu package leads to pr

Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()

2021-02-18 Thread Christian Schoenebeck
On Donnerstag, 18. Februar 2021 10:14:12 CET Paolo Bonzini wrote: > On 18/02/21 10:10, Christian Schoenebeck wrote: > > On Montag, 15. Februar 2021 15:06:41 CET Christian Schoenebeck wrote: > >> On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote: > >>> From: qemu_oss--- via > >>> > >>>

Re: [PATCH 0/3] virtio-net: graceful drop of vhost for TAP

2021-02-18 Thread Daniel P . Berrangé
On Tue, Feb 09, 2021 at 10:04:30AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 09, 2021 at 02:51:05PM +, Daniel P. Berrangé wrote: > > On Tue, Feb 09, 2021 at 09:34:20AM -0500, Michael S. Tsirkin wrote: > > > On Thu, Feb 04, 2021 at 10:29:12PM +0200, Yuri Benditovich wrote: > > > > This set

Re: [PATCH 0/3] virtio-net: graceful drop of vhost for TAP

2021-02-18 Thread Daniel P . Berrangé
On Wed, Feb 10, 2021 at 02:19:59PM +0800, Jason Wang wrote: > > On 2021/2/9 下午11:04, Michael S. Tsirkin wrote: > > On Tue, Feb 09, 2021 at 02:51:05PM +, Daniel P. Berrangé wrote: > > > On Tue, Feb 09, 2021 at 09:34:20AM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Feb 04, 2021 at 10:29:12P

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Philippe Mathieu-Daudé
On 2/17/21 9:46 PM, Cleber Rosa wrote: > On Thu, Feb 11, 2021 at 05:19:45PM +, Alex Bennée wrote: >> These tests make sure we can boot the Xen hypervisor with a Dom0 >> kernel using the guest-loader. We currently have to use a kernel I >> built myself because there are issues using the Debian k

[PULL 01/23] hw/virtio/pci: include vdev name in registered PCI sections

2021-02-18 Thread Alex Bennée
When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id: <202102

[PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile)

2021-02-18 Thread Alex Bennée
The following changes since commit 1af5629673bb5c1592d993f9fb6119a62845f576: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210216' into staging (2021-02-17 14:44:18 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-plu

[PULL 12/23] target/mips: Create mips_io_recompile_replay_branch

2021-02-18 Thread Alex Bennée
From: Richard Henderson Move the code from accel/tcg/translate-all.c to target/mips/cpu.c. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208233906.479571-4-richard.hender...@linaro.org> Message-Id: <

[PULL 10/23] exec: Move TranslationBlock typedef to qemu/typedefs.h

2021-02-18 Thread Alex Bennée
From: Richard Henderson This also means we don't need an extra declaration of the structure in hw/core/cpu.h. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208233906.479571-2-richard.hender...@linaro

[PULL 04/23] contrib: Don't use '#' flag of printf format

2021-02-18 Thread Alex Bennée
From: zhouyang I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the misuse of '#' flag of printf format Signed-off-by: zhouyang Signed-off-by: Alex Bennée Message-Id: <20210118031004.1662363-2-zhouyang...@huawei.com> Mes

[PULL 03/23] plugins: new hwprofile plugin

2021-02-18 Thread Alex Bennée
This is a plugin intended to help with profiling access to various bits of system hardware. It only really makes sense for system emulation. It takes advantage of the recently exposed helper API that allows us to see the device name (memory region name) associated with a device. You can specify a

[PULL 07/23] contrib: space required after that ','

2021-02-18 Thread Alex Bennée
From: zhouyang I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: space required after that ',' Signed-off-by: zhouyang Signed-off-by: Alex Bennée Message-Id: <20210118031004.1662363-5-zhouyang...@h

[PULL 06/23] contrib: Add spaces around operator

2021-02-18 Thread Alex Bennée
From: zhouyang I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: spaces required around that '*' Signed-off-by: zhouyang Signed-off-by: Alex Bennée Message-Id: <20210118031004.1662363-4-zhouyang...

[PULL 22/23] tests/plugin: allow memory plugin to do both inline and callbacks

2021-02-18 Thread Alex Bennée
This is going to be useful for acceptance tests that check both types are being called the same number of times, especially when icount is enabled. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210213130325.14781-23-alex.ben...@lina

[PULL 02/23] plugins: add API to return a name for a IO device

2021-02-18 Thread Alex Bennée
This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée Reviewed-by: Clement Deschamps Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Message-Id: <20210213130325.14781-3-alex.ben...@linaro.org> diff --git a/include/qemu/qemu-plugin.h b/inclu

[PULL 15/23] tests/acceptance: add a new set of tests to exercise plugins

2021-02-18 Thread Alex Bennée
This is just a simple test to count the instructions executed by a kernel. However a later test will detect a failure condition when icount is enabled. Signed-off-by: Alex Bennée Tested-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210213130325.14781-16-alex

[PULL 11/23] accel/tcg: Create io_recompile_replay_branch hook

2021-02-18 Thread Alex Bennée
From: Richard Henderson Create a hook in which to split out the mips and sh4 ifdefs from cpu_io_recompile. [AJB: s/stoped/stopped/] Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208233906.479571-3-r

[PULL 21/23] tests/acceptance: add a new tests to detect counting errors

2021-02-18 Thread Alex Bennée
The insn plugin has a simple heuristic to detect if an instruction is detected running twice in a row. Check the plugin log after the run and pass accordingly. Signed-off-by: Alex Bennée Tested-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210213130325.14781

[PULL 05/23] contrib: Fix some code style problems, ERROR: "foo * bar" should be "foo *bar"

2021-02-18 Thread Alex Bennée
From: zhouyang I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: zhouyang Signed-off-by: Alex Bennée Message-Id: <20210118031004.1662363-3-zhouyang..

[PULL 18/23] accel/tcg: re-factor non-RAM execution code

2021-02-18 Thread Alex Bennée
There is no real need to use CF_NOCACHE here. As long as the TB isn't linked to other TBs or included in the QHT or jump cache then it will only get executed once. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210213130325.14781-19-alex.ben...@linaro.org> diff --git a

[PULL 19/23] accel/tcg: remove CF_NOCACHE and special cases

2021-02-18 Thread Alex Bennée
Now we no longer generate CF_NOCACHE blocks we can remove a bunch of the special case handling for them. While we are at it we can remove the unused tb->orig_tb field and save a few bytes on the TB structure. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210213130325.1

[PULL 08/23] contrib: Open brace '{' following struct go on the same line

2021-02-18 Thread Alex Bennée
From: zhouyang I found some style problems whil check the code using checkpatch.pl. This commit fixs the issue below: ERROR: that open brace { should be on the previous line Signed-off-by: zhouyang Signed-off-by: Alex Bennée Message-Id: <20210118031004.1662363-6-zhouyang...@huawei.com> Message

[PULL 14/23] tests/plugin: expand insn test to detect duplicate instructions

2021-02-18 Thread Alex Bennée
A duplicate insn is one that is appears to be executed twice in a row. This is currently possible due to -icount and cpu_io_recompile() causing a re-translation of a block. On it's own this won't trigger any tests though. The heuristics that the plugin use can't deal with the x86 rep instruction w

[PULL 16/23] accel/tcg: actually cache our partial icount TB

2021-02-18 Thread Alex Bennée
When we exit a block under icount with instructions left to execute we might need a shorter than normal block to take us to the next deterministic event. Instead of creating a throwaway block on demand we use the existing compile flags mechanism to ensure we fetch (or compile and fetch) a block wit

[PULL 13/23] target/sh4: Create superh_io_recompile_replay_branch

2021-02-18 Thread Alex Bennée
From: Richard Henderson Move the code from accel/tcg/translate-all.c to target/sh4/cpu.c. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208233906.479571-5-richard.hender...@linaro.org> Message-Id: <2

[PULL 23/23] tests/acceptance: add a memory callback check

2021-02-18 Thread Alex Bennée
This test makes sure that the inline and callback based memory checks count the same number of accesses. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210213130325.14781-24-alex.ben...@linaro.org> diff --git a/tests/acceptance/tcg_plugins.py b/tests/acceptance/tc

[PULL 09/23] accel/tcg/plugin-gen: fix the call signature for inline callbacks

2021-02-18 Thread Alex Bennée
A recent change to the handling of constants in TCG changed the pattern of ops emitted for a constant add. We no longer emit a mov and the constant can be applied directly to the TCG_op_add arguments. This was causing SEGVs when running the insn plugin with arg=inline. Fix this by updating copy_add

[PULL 20/23] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-18 Thread Alex Bennée
When icount is enabled and we recompile an MMIO access we end up double counting the instruction execution. To avoid this we introduce the CF_MEMI cflag which only allows memory instrumentation for the next TB (which won't yet have been counted). As this is part of the hashed compile flags we will

[PULL 17/23] accel/tcg: cache single instruction TB on pending replay exception

2021-02-18 Thread Alex Bennée
Again there is no reason to jump through the nocache hoops to execute a single instruction block. We do have to add an additional wrinkle to the cpu_handle_interrupt case to ensure we let through a TB where we have specifically disabled icount for the block. As the last user of cpu_exec_nocache we

RE: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback

2021-02-18 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: 16 November 2020 18:14 > To: eric.auger@gmail.com; eric.au...@redhat.com; > qemu-devel@nongnu.org; qemu-...@nongnu.org; > alex.william...@redhat.com > Cc: peter.mayd...@linaro.org; jean-phili...@lin

Re: [PATCH] Correct CRIS TCG register lifetime management

2021-02-18 Thread Edgar E. Iglesias
On Thu, Feb 18, 2021 at 08:56:43AM +, Stefan Sandström wrote: > From: Stefan Sandstrom > > Add and fix deallocation of temporary TCG registers in CRIS code > generation. Thanks Stefan, Unfortunately, this patch does not apply. I'm not sure why. Perhaps it got corrupted by the email systems

Re: [PATCH v2 5/6] qapi: Add support for aliases

2021-02-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.02.2021 um 16:23 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Introduce alias definitions for object types (structs and unions). This >> > allows using the same QAPI type and visitor for many syntax variations >> > that exist in the external repres

Re: [RFC PATCH 0/3] hw/pflash_cfi01: Reduce memory consumption when flash image is smaller than region

2021-02-18 Thread David Edmondson
On Tuesday, 2021-02-16 at 15:53:48 GMT, David Edmondson wrote: > On Tuesday, 2021-02-16 at 16:44:58 +01, Philippe Mathieu-Daudé wrote: > >> On 2/16/21 4:22 PM, David Edmondson wrote: >>> On Tuesday, 2021-02-16 at 16:03:05 +01, Philippe Mathieu-Daudé wrote: >>> I am not a block expert, but I

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 10:23:16 +0100 Thomas Huth wrote: > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > module, which provides the type virtio-gpu-device, packaging the > > hw-display-virtio-gpu module as a separate package that may or may not > > be installed along wit

Re: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback

2021-02-18 Thread Auger Eric
Hi Shameer, On 2/18/21 11:19 AM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger [mailto:eric.au...@redhat.com] >> Sent: 16 November 2020 18:14 >> To: eric.auger@gmail.com; eric.au...@redhat.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; >>

Re: [PATCH 08/24] DAX: virtio-fs: Fill in slave commands for mapping

2021-02-18 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Feb 09, 2021 at 07:02:08PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Fill in definitions for map, unmap and sync commands. > > > > Signed-off-by: Dr. David Alan Gilbert > > with fix by misono.to

Re: Measuring the impact of buffer copy for virtio-gpu guests

2021-02-18 Thread Gerd Hoffmann
On Wed, Feb 17, 2021 at 01:46:28PM +, Alex Bennée wrote: > Hi Gerd, > > I was in a discussion with the AGL folks today talking about approaches > to achieving zero-copy when running VirGL virtio guests. AIUI (which is > probably not very much) the reasons for copy can be due to a number of > r

[PATCH] virtio-iommu: Default to bypass during boot

2021-02-18 Thread Jean-Philippe Brucker
Currently the virtio-iommu device must be programmed before it allows DMA from any PCI device. This can make the VM entirely unusable when a virtio-iommu driver isn't present, for example in a bootloader that loads the OS from storage. Similarly to the other vIOMMU implementations, default to DMA

Re: [PULL 00/35] hexagon initial commit

2021-02-18 Thread Peter Maydell
On Wed, 17 Feb 2021 at 23:40, Richard Henderson wrote: > > The following changes since commit f0f75dc174b6c79eb78a161d1c0921f82d7f1bf0: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-02-17 13:04:48 +) > > are available in the Git repository

RE: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback

2021-02-18 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 18 February 2021 10:42 > To: Shameerali Kolothum Thodi ; > eric.auger@gmail.com; qemu-devel@nongnu.org; qemu-...@nongnu.org; > alex.william...@redhat.com > Cc: peter.mayd...@linaro.org; jacob.jun..

Re: [Rust-VMM] Call for Google Summer of Code 2021 project ideas

2021-02-18 Thread Andreea Florescu
On 2/17/21 1:20 PM, Stefan Hajnoczi wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > Thanks, I have published the rust-vmm project ideas on the wiki: > htt

[PULL 2/2] usb/pcap: set flag_setup

2021-02-18 Thread Gerd Hoffmann
Without that wireshark complains about invalid control setup data for non-control transfers. Signed-off-by: Gerd Hoffmann Message-Id: <20210216144939.841873-1-kra...@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/usb/pcap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/pcap.c b/

[PULL 1/2] usb-host: use correct altsetting in usb_host_ep_update

2021-02-18 Thread Gerd Hoffmann
From: Nick Rosbrook In order to keep track of the alternate setting that should be used for a given interface, the USBDevice struct keeps an array of alternate setting values, which is indexed by the interface number. In usb_host_set_interface, when this array is updated, usb_host_ep_update is ca

Re: [PATCH] usb-host: use correct altsetting in usb_host_ep_update

2021-02-18 Thread Gerd Hoffmann
On Thu, Feb 11, 2021 at 11:05:41AM -0500, Nick Rosbrook wrote: > Hi, > > Just wanted to ping this. Patchwork link is here: > https://patchwork.kernel.org/project/qemu-devel/patch/20210201213021.500277-1-rosbro...@ainfosec.com/. Pull request sent now. Not much usb activity these days ... thanks,

[PULL 0/2] Usb 20210218 patches

2021-02-18 Thread Gerd Hoffmann
The following changes since commit 18543229fd7a2c79dcd6818c7b1f0f62512b5220: Merge remote-tracking branch 'remotes/cleber-gitlab/tags/python-next-pull-r= equest' into staging (2021-02-16 14:37:57 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-202

Re: [PATCH 01/24] DAX: vhost-user: Rework slave return values

2021-02-18 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Feb 09, 2021 at 07:02:01PM +, Dr. David Alan Gilbert (git) wrote: > > +static uint64_t vhost_user_slave_handle_vring_host_notifier( > > +struct vhost_dev *dev, > > + VhostUserVringArea *area, > > +

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Cornelia Huck
On Thu, 18 Feb 2021 11:34:38 +0100 Halil Pasic wrote: > On Thu, 18 Feb 2021 10:23:16 +0100 > Thomas Huth wrote: > > > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > > module, which provides the type virtio-gpu-device, packaging the > > > hw-display-virtio-gpu module

Re: [PATCH 1/5] qcow2-bitmap: make bytes_covered_by_bitmap_cluster() public

2021-02-18 Thread Denis V. Lunev
On 2/16/21 7:45 PM, Vladimir Sementsov-Ogievskiy wrote: > Rename bytes_covered_by_bitmap_cluster() to > bdrv_dirty_bitmap_serialization_coverage() and make it public. It is > needed as we are going to make load_bitmap_data() public in the next > commit. > > Signed-off-by: Vladimir Sementsov-Ogievsk

Editing QEMU POWER Platform wiki page

2021-02-18 Thread Leonardo Augusto Guimarães Garcia
Hi there, I would like to edit the wiki page at [0] as it contains some outdated information. Could anyone that has access to the wiki please help me create a user so that I can edit it? 0. https://wiki.qemu.org/Documentation/Platforms/POWER Cheers, Leo

Re: [PATCH] usb-host: use correct altsetting in usb_host_ep_update

2021-02-18 Thread Nick Rosbrook
On Thu, Feb 18, 2021 at 12:52:51PM +0100, Gerd Hoffmann wrote: > On Thu, Feb 11, 2021 at 11:05:41AM -0500, Nick Rosbrook wrote: > > Hi, > > > > Just wanted to ping this. Patchwork link is here: > > https://patchwork.kernel.org/project/qemu-devel/patch/20210201213021.500277-1-rosbro...@ainfosec.com

Re: [PULL 00/19] riscv-to-apply queue

2021-02-18 Thread Peter Maydell
On Thu, 18 Feb 2021 at 01:59, Alistair Francis wrote: > > The following changes since commit 1af5629673bb5c1592d993f9fb6119a62845f576: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210216' into staging > (2021-02-17 14:44:18 +) > > are available in the Gi

Re: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback

2021-02-18 Thread Auger Eric
Hi Shameer, On 2/18/21 12:46 PM, Shameerali Kolothum Thodi wrote: > > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 18 February 2021 10:42 >> To: Shameerali Kolothum Thodi ; >> eric.auger@gmail.com; qemu-devel@nongnu.org; qemu-...@nongnu

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Gerd Hoffmann
Hi, > > The explanation is simple. Unlike most devices, the ccw devices aren't > > portable. In particular both css.c and css.h includes "cpu.h", and > > virtio-ccw-gpu.c includes "qemu/osdep.h". Furthermore osdep.h contains: > > #ifdef NEED_CPU_H > > #include CONFIG_TARGET > > #else > > #includ

Re: [PATCH v2 4/6] qapi: Apply aliases in qobject-input-visitor

2021-02-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.02.2021 um 16:32 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > When looking for an object in a struct in the external representation, >> > check not only the currently visited struct, but also whether an alias >> > in the current StackObject matches

Re: [PATCH 2/5] parallels.txt: fix bitmap L1 table description

2021-02-18 Thread Denis V. Lunev
On 2/16/21 7:45 PM, Vladimir Sementsov-Ogievskiy wrote: > Actually L1 table entry offset is in 512 bytes sectors. Fix the spec. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > docs/interop/parallels.txt | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git

[PATCH v4] net/macos: implement vmnet-based netdev

2021-02-18 Thread phillip . ennen
From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via the tun

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-18 Thread Cornelia Huck
On Wed, 17 Feb 2021 15:39:36 +0100 Halil Pasic wrote: > On Tue, 16 Feb 2021 16:54:05 +0100 > Cornelia Huck wrote: > > > On Tue, 16 Feb 2021 15:19:45 +0100 > > Halil Pasic wrote: > > > > > On Tue, 16 Feb 2021 12:18:30 +0100 > > > Cornelia Huck wrote: > > > > > > > The virtio standard s

[PATCH 0/3] Some SMMUv3 bug fixes

2021-02-18 Thread Eric Auger
Hi, This series fixes three issues: - top SID computation overflow when handling SMMU_CMD_CFGI_ALL - internal IOTLB handling (changes related to range invalidation) - smmu_iotlb_inv_iova with asid = -1 - non power of 2 invalidation range handling. Best Regards Eric This series can be found

[PATCH 3/3] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling

2021-02-18 Thread Eric Auger
If the whole SID range (32b) is invalidated (SMMU_CMD_CFGI_ALL), @end overflows and we fail to handle the command properly. Once this gets fixed, the current code really is awkward in the sense it loops over the whole range instead of removing the currently cached configs through a hash table look

[PATCH 2/3] hw/arm/smmuv3: Enforce invalidation on a power of two range

2021-02-18 Thread Eric Auger
As of today, the driver can invalide a number of pages that is not a power of 2. However IOTLB unmap notifications and internal IOTLB invalidations work with masks leading to erroneous invalidations. In case the range is not a power of 2, split invalidations into power of 2 invalidations. When lo

[PATCH 1/3] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set

2021-02-18 Thread Eric Auger
If the asid is not set, do not attempt to locate the key directly as all inserted keys have a valid asid. Use g_hash_table_foreach_remove instead. Signed-off-by: Eric Auger --- hw/arm/smmu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/smmu-common.c b/hw/arm

Re: [PULL 00/19] riscv-to-apply queue

2021-02-18 Thread Bin Meng
On Thu, Feb 18, 2021 at 9:26 PM Peter Maydell wrote: > > On Thu, 18 Feb 2021 at 01:59, Alistair Francis > wrote: > > > > The following changes since commit 1af5629673bb5c1592d993f9fb6119a62845f576: > > > > Merge remote-tracking branch > > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210216'

[PATCH] net: eepro100: validate various address values

2021-02-18 Thread P J P
From: Prasad J Pandit While processing controller commands, eepro100 emulator gets command unit(CU) base address OR receive unit (RU) base address OR command block (CB) address from guest. If these values are not checked, it may lead to an infinite loop kind of issues. Add checks to avoid it. Re

Re: [PATCH] Correct CRIS TCG register lifetime management

2021-02-18 Thread Stefan Sandström
Hi Edgar, Yes, it seems like our mail-server messed it up. I’ve tried to resend it, but I’m not sure if mails directly from sendmail are let through to outside addresses. Please let me know if you’ve got the last mail (sent a few minutes ago). Best regards, -stefan > On 18 Feb 2021, at 11:2

[PATCH] Correct CRIS TCG register lifetime management

2021-02-18 Thread Stefan Sandström
From: Stefan Sandstrom Add and fix deallocation of temporary TCG registers in CRIS code generation. Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc Signed-off-by: Stefan Sandstrom --- target/cris/translate.c | 146 ++-- target/cris/translate_v10.c

[PATCH] virtio-iommu: Handle non power of 2 range invalidations

2021-02-18 Thread Eric Auger
Unmap notifiers work with an address mask assuming an invalidation range of a power of 2. Nothing mandates this in the VIRTIO-IOMMU spec. So in case the range is not a power of 2, split it into several invalidations. Signed-off-by: Eric Auger --- hw/virtio/virtio-iommu.c | 23 ++

Re: [PATCH] net: eepro100: validate various address values

2021-02-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210218140629.373646-1-ppan...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210218140629.373646-1-ppan...@redhat.com Subject: [PATCH] net: eepro100: validate vario

Re: [PULL 00/19] riscv-to-apply queue

2021-02-18 Thread Peter Maydell
On Thu, 18 Feb 2021 at 14:07, Bin Meng wrote: > On Thu, Feb 18, 2021 at 9:26 PM Peter Maydell > wrote: > > Fails to compile, 32 bit hosts: > > > > ../../hw/riscv/virt.c: In function 'virt_machine_init': > > ../../hw/riscv/virt.c:621:43: error: comparison is always false due to > > limited range

Re: [PATCH] net: eepro100: validate various address values

2021-02-18 Thread Peter Maydell
On Thu, 18 Feb 2021 at 14:13, P J P wrote: > > From: Prasad J Pandit > > While processing controller commands, eepro100 emulator gets > command unit(CU) base address OR receive unit (RU) base address > OR command block (CB) address from guest. If these values are not > checked, it may lead to an

Re: [RFC PATCH v2 1/3] vfio: Move the saving of the config space to the right place in VFIO migration

2021-02-18 Thread Kirti Wankhede
On 12/9/2020 1:39 PM, Shenming Lu wrote: On ARM64 the VFIO SET_IRQS ioctl is dependent on the VM interrupt setup, if the restoring of the VFIO PCI device config space is before the VGIC, an error might occur in the kernel. So we move the saving of the config space to the non-iterable process,

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Thomas Huth
On 18/02/2021 11.34, Halil Pasic wrote: On Thu, 18 Feb 2021 10:23:16 +0100 Thomas Huth wrote: Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may

Re: [RFC PATCH v2 1/3] vfio: Move the saving of the config space to the right place in VFIO migration

2021-02-18 Thread Kirti Wankhede
On 1/27/2021 3:06 AM, Alex Williamson wrote: On Thu, 10 Dec 2020 10:21:21 +0800 Shenming Lu wrote: On 2020/12/10 2:34, Alex Williamson wrote: On Wed, 9 Dec 2020 13:29:47 +0100 Cornelia Huck wrote: On Wed, 9 Dec 2020 16:09:17 +0800 Shenming Lu wrote: On ARM64 the VFIO SET_IRQS io

[PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address()

2021-02-18 Thread Philippe Mathieu-Daudé
Taking notes while reviewing commit 671a0a1265a ("use MMUAccessType instead of int in mmu_translate"). Since v1: - Do not provide unuseful MMU index argument (Richard) Missing review: patch 3 (Remove unused 'int access_type' argument) Philippe Mathieu-Daudé (5): target/sh4: Fix code style for

[PATCH v2 1/5] target/sh4: Fix code style for checkpatch.pl

2021-02-18 Thread Philippe Mathieu-Daudé
We are going to move this code, fix its style first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/sh4/helper.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/target/sh4/helper.c b/target/sh4/

[PATCH v2 2/5] target/sh4: Replace magic value by MMUAccessType definitions

2021-02-18 Thread Philippe Mathieu-Daudé
Replace the 0/1/2 magic values by the corresponding MMUAccessType. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/sh4/helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/sh4/helper.c b/target/sh4/helper.c index fc

[PATCH v2 3/5] target/sh4: Remove unused 'int access_type' argument

2021-02-18 Thread Philippe Mathieu-Daudé
get_mmu_address() and get_physical_address() don't use their 'int access_type' argument: remove it along with ACCESS_INT in superh_cpu_tlb_fill(). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/sh4/helper.c | 15 +++ 1 file changed, 7 insertions(+),

[PATCH v2 5/5] target/sh4: Remove unused definitions

2021-02-18 Thread Philippe Mathieu-Daudé
Remove these confusing and unused definitions. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/sh4/cpu.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index 714e3b56413..01c43440822 100644 --- a/target/sh4/cpu

[PATCH v2 4/5] target/sh4: Let get_physical_address() use MMUAccessType access_type

2021-02-18 Thread Philippe Mathieu-Daudé
superh_cpu_tlb_fill() already provides a access_type variable of type MMUAccessType, and it is passed along, but casted as integer and renamed 'rw'. Simply replace 'int rw' by 'MMUAccessType access_type'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/sh4/helper

Re: [PATCH] Correct CRIS TCG register lifetime management

2021-02-18 Thread Philippe Mathieu-Daudé
Hi Stefan, On 2/18/21 1:16 PM, Stefan Sandström wrote: > Hi Edgar, > > Yes, it seems like our mail-server messed it up. > > I’ve tried to resend it, but I’m not sure if mails directly from sendmail are > let through to outside addresses. Please let me know if you’ve got the last > mail (sent

[PATCH] hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node

2021-02-18 Thread Bin Meng
From: Bin Meng Per devicetree spec v0.3 [1] chapter 2.3.5: The #address-cells and #size-cells properties are not inherited from ancestors in the devicetree. They shall be explicitly defined. If missing, a client program should assume a default value of 2 for #address-cells, and a value of 1 for

Re: [PATCH 2/7] block/qcow2: introduce cache for compressed writes

2021-02-18 Thread Max Reitz
On 11.02.21 13:49, Vladimir Sementsov-Ogievskiy wrote: you may jump first to my last inline answer 10.02.2021 20:07, Max Reitz wrote: On 29.01.21 17:50, Vladimir Sementsov-Ogievskiy wrote: Compressed writes and O_DIRECT are not friends: they works too slow, because compressed writes does many

Re: [PATCH v2 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-18 Thread Vivek Goyal
On Wed, Feb 17, 2021 at 06:30:44PM -0500, Vivek Goyal wrote: > fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse > server to enable posix acls. > > Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable > posix acl support. By default it is disabled as of n

Re: [PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile)

2021-02-18 Thread Peter Maydell
On Thu, 18 Feb 2021 at 09:47, Alex Bennée wrote: > > The following changes since commit 1af5629673bb5c1592d993f9fb6119a62845f576: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210216' into staging > (2021-02-17 14:44:18 +) > > are available in the Git rep

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Cleber Rosa
On Wed, Feb 17, 2021 at 10:22:50PM +, Alex Bennée wrote: > > I think the solution is to use archive links here. There is a snapshot > archive of sid (we've used it in the past) but I suspect there isn't an > archive of old stable packages for a reason. > If the packages you need are available

[PATCH 1/2] sev: use explicit indices for mapping firmware error codes to strings

2021-02-18 Thread Connor Kuehl
This can help lower any margin for error when making future additions to the list, especially if they're made out of order. While doing so, make capitalization of ASID consistent with its usage in the SEV firmware spec (Asid -> ASID). Signed-off-by: Connor Kuehl --- target/i386/sev.c | 46 +

[PATCH 0/2] SEV firmware error list touchups

2021-02-18 Thread Connor Kuehl
Connor Kuehl (2): sev: use explicit indices for mapping firmware error codes to strings sev: add missing firmware error conditions target/i386/sev.c | 48 --- 1 file changed, 25 insertions(+), 23 deletions(-) -- 2.29.2

[PATCH 2/2] sev: add missing firmware error conditions

2021-02-18 Thread Connor Kuehl
The SEV userspace header[1] exports a couple of other error conditions that aren't listed in QEMU's SEV implementation, so let's just round out the list. [1] linux-headers/linux/psp-sev.h Signed-off-by: Connor Kuehl --- target/i386/sev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tar

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Cleber Rosa
On Thu, Feb 18, 2021 at 10:43:54AM +0100, Philippe Mathieu-Daudé wrote: > On 2/17/21 9:46 PM, Cleber Rosa wrote: > > On Thu, Feb 11, 2021 at 05:19:45PM +, Alex Bennée wrote: > >> These tests make sure we can boot the Xen hypervisor with a Dom0 > >> kernel using the guest-loader. We currently ha

Re: [PATCH 0/2] SEV firmware error list touchups

2021-02-18 Thread Philippe Mathieu-Daudé
On 2/18/21 4:16 PM, Connor Kuehl wrote: > Connor Kuehl (2): > sev: use explicit indices for mapping firmware error codes to strings > sev: add missing firmware error conditions > > target/i386/sev.c | 48 --- > 1 file changed, 25 insertions(+), 23 d

[PATCH v2 00/38] ppc: qemu: Convert qemu-ppce500 to driver model and enable additional driver support

2021-02-18 Thread Bin Meng
At present when building qemu-ppce500 the following warnings are seen: = WARNING == This board does not use CONFIG_DM. CONFIG_DM will be compulsory starting with the v2020.01 release. Failure to update may result in board removal. UPD include/generated

Re: [PATCH 3/7] block/qcow2: use compressed write cache

2021-02-18 Thread Max Reitz
On 11.02.21 13:53, Vladimir Sementsov-Ogievskiy wrote: 10.02.2021 20:11, Max Reitz wrote: On 29.01.21 17:50, Vladimir Sementsov-Ogievskiy wrote: Introduce a new option: compressed-cache-size, with default to 64 clusters (to be not less than 64 default max-workers for backup job). Signed-off-by

Re: [PATCH 1/1] hw/s390x: fix build for virtio-9p-ccw

2021-02-18 Thread Cornelia Huck
On Thu, 18 Feb 2021 04:40:59 +0100 Halil Pasic wrote: > Commit 2c44220d05 ("meson: convert hw/arch*"), which migrated the old > Makefile.objs to meson.build accidentally excluded virtio-ccw-9p.c and > thus the virtio-9p-ccw device from the build (and potentially also > included the file virtio-

Re: [PATCH v2 4/6] qapi: Apply aliases in qobject-input-visitor

2021-02-18 Thread Kevin Wolf
Am 18.02.2021 um 14:39 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 17.02.2021 um 16:32 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > When looking for an object in a struct in the external representation, > >> > check not only the currently visited s

Re: [PATCH] net: eepro100: validate various address values

2021-02-18 Thread Stefan Weil
Am 18.02.21 um 15:41 schrieb Peter Maydell: On Thu, 18 Feb 2021 at 14:13, P J P wrote: From: Prasad J Pandit While processing controller commands, eepro100 emulator gets command unit(CU) base address OR receive unit (RU) base address OR command block (CB) address from guest. If these values

Re: [PATCH] Correct CRIS TCG register lifetime management

2021-02-18 Thread Richard Henderson
On 2/18/21 12:56 AM, Stefan Sandström wrote: > From: Stefan Sandstrom > > Add and fix deallocation of temporary TCG registers in CRIS code > generation. > > Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc > Signed-off-by: Stefan Sandstrom > --- > target/cris/translate.c | 146 +

  1   2   3   >