Hi Eric, > -----Original Message----- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 18 February 2021 10:42 > To: Shameerali Kolothum Thodi <shameerali.kolothum.th...@huawei.com>; > eric.auger....@gmail.com; qemu-devel@nongnu.org; qemu-...@nongnu.org; > alex.william...@redhat.com > Cc: peter.mayd...@linaro.org; jacob.jun....@linux.intel.com; Zengtao (B) > <prime.z...@hisilicon.com>; jean-phili...@linaro.org; t...@semihalf.com; > pet...@redhat.com; nicoleots...@gmail.com; vivek.gau...@arm.com; > yi.l....@intel.com; zhangfei....@gmail.com; yuzenghui > <yuzeng...@huawei.com>; qubingbing <qubingb...@hisilicon.com> > Subject: Re: [RFC v7 26/26] vfio/pci: Implement return_page_response page > response callback > [...]
> > Also, I just noted that this patch breaks the dev hot add/del functionality. > > device_add works fine but device_del is not removing the dev cleanly.Thank > you for reporting this! > > The test matrix becomes bigger and bigger :-( I Need to write some > avocado-vt tests or alike. > > I am currently working on the respin. At the moment I investigate the > DPDK issue that you reported and I was able to reproduce. Ok. Good to know that it is reproducible. > I intend to rebase on top of Jean-Philippe's > [PATCH v12 00/10] iommu: I/O page faults for SMMUv3 > > Is that good enough for your SVA integration or do you want I prepare a > rebase on some extended code? Could you please try to base it on https://jpbrucker.net/git/linux/log/?h=sva/current I think that has the latest from Jean-Philippe and will be easy to add uacce/zip specific patches to test SVA/vSVA. Thanks, Shameer > Thanks > > Eric > > > > The below one fixes it. Please check. > > > > Thanks, > > Shameer > > > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > > index 797acd9c73..92c1d48316 100644 > > --- a/hw/vfio/pci.c > > +++ b/hw/vfio/pci.c > > @@ -3470,6 +3470,7 @@ static void vfio_instance_finalize(Object *obj) > > vfio_display_finalize(vdev); > > vfio_bars_finalize(vdev); > > vfio_region_finalize(&vdev->dma_fault_region); > > + vfio_region_finalize(&vdev->dma_fault_response_region); > > g_free(vdev->emulated_config_bits); > > g_free(vdev->rom); > > /* > > @@ -3491,6 +3492,7 @@ static void vfio_exitfn(PCIDevice *pdev) > > vfio_unregister_err_notifier(vdev); > > vfio_unregister_ext_irq_notifiers(vdev); > > vfio_region_exit(&vdev->dma_fault_region); > > + vfio_region_exit(&vdev->dma_fault_response_region); > > pci_device_set_intx_routing_notifier(&vdev->pdev, NULL); > > if (vdev->irqchip_change_notifier.notify) { > > > kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_not > > > > > >
