Re: [PATCH v3 5/5] vhost-vdpa: add callback function for configure interrupt

2021-01-27 Thread Jason Wang
On 2021/1/27 下午3:51, Cindy Lu wrote: + /*set the fd call back to vdpa driver*/ I guess checkpatch.pl might warn here. Please try to silent checkpath.pl before submitting patches. Actually I do have run this script, but seems not warned here. I will pay attention next time Oh right, I

Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary

2021-01-27 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 1/26/21 5:09 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 1/26/21 3:57 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > In this series we deselect a bunch of features when they > not required, so less

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote: > > On Tue, 26 Jan 2021 10:35:02 + > Stefan Hajnoczi wrote: > The patch looks pretty good to me. It just seems to be missing a change in > lo_create(): > > fd = openat(parent_inode->fd, name, (fi->flags | O_CREAT) & ~O_NOFOLLOW, >

[PATCH] target/i86: implement PKS

2021-01-27 Thread Paolo Bonzini
Protection Keys for Supervisor-mode pages is a simple extension of the PKU feature that QEMU already implements. For supervisor-mode pages, protection key restrictions come from a new MSR. The MSR has no XSAVE state associated to it. PKS is only respected in long mode. However, in principle it

[PULL 0/9] Gitlab-CI and testing improvements

2021-01-27 Thread Thomas Huth
Hi Peter, the following changes since commit 9cd69f1a270235b652766f00b94114f48a2d603f: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2021-01-25-1' into staging (2021-01-26 09:51:02 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pul

[PULL 1/9] tests/docker: Install static libc package in CentOS 7

2021-01-27 Thread Thomas Huth
From: Philippe Mathieu-Daudé We need to install the static libc package to be able to run the TCG tests: $ make check-tcg ... BUILD TCG tests for x86_64-softmmu BUILD x86_64-softmmu guest-tests with cc /usr/bin/ld: hello: warning: allocated section `.notes' not in segment /us

[PULL 3/9] gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit

2021-01-27 Thread Thomas Huth
Since the meson build system rework, the configure script prefers the git submodules over the system libraries. So we are testing compilation with capstone, fdt and libslirp as a submodule all over the place, burning CPU cycles by recompiling these third party modules and wasting some network bandw

[PULL 8/9] docs/devel: Explain how acceptance tests can be skipped

2021-01-27 Thread Thomas Huth
From: Wainer dos Santos Moschetta Documented under the "Acceptance tests using the Avocado Framework" section in testing.rst how environment variables are used to skip tests. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20210115210022.417996-1-waine...@redhat.com> Reviewed-by: Thomas

[PULL 4/9] configure: Only check for audio drivers if system-mode is selected

2021-01-27 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Acked-by: Gerd Hoffmann Message-Id: <20210122204441.2145197-2-phi...@redhat.com> Acked-by: Paolo Bonzini Signed-off-by: Thomas Huth --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --g

[PULL 5/9] meson: Do not build optional libraries by default

2021-01-27 Thread Thomas Huth
From: Philippe Mathieu-Daudé The following libraries will be selected if a feature requires it: - capstone - fdt - SLiRP Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210122204441.2145197-5-phi...@redhat.com> Acked-by: Paolo Bonzini Signed-off-by: Thomas Hu

[PULL 2/9] gitlab-ci: Test building linux-user targets on CentOS 7

2021-01-27 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add a configuration tested by Peter Maydell (see [1] and [2]) but not covered in our CI [3]: [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o ../linux-user/strace.c: In fu

[PULL 9/9] libqtest: Rework qtest_rsp()

2021-01-27 Thread Thomas Huth
From: Markus Armbruster qtest_rsp() is used in two different ways: (1) return some arguments to caller, which the caller must free, and (2) return no arguments to caller. Passing non-zero @expected_args gets you (1), and passing zero gets you (2). Having "the return value must be freed" depend

[PULL 7/9] gitlab-ci.yml: Avoid recompiling the sources in the test jobs

2021-01-27 Thread Thomas Huth
Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object files as an artifact from the previous

[PULL 6/9] gitlab-ci.yml: Exclude some redundant targets in build-without-default-features

2021-01-27 Thread Thomas Huth
The build-without-default-features job is running quite long and sometimes already hits the 1h time limit. Exclude some targets which do not provide additional test coverage here (since we e.g. also already test other targets of the same type, just with different endianess, or a 64-bit superset) to

Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux

2021-01-27 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 04:38:57PM -0500, John Snow wrote: > On 1/19/21 8:41 AM, Thomas Huth wrote: > > On 18/01/2021 11.33, Daniel P. Berrangé wrote: > > > On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote: > > > > Alpine Linux[1] is a security-oriented, lightweight Linux distribution >

[PATCH] ui: fix spice display regression

2021-01-27 Thread marcandre . lureau
From: Marc-André Lureau Since commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4 ("vl: remove separate preconfig main_loop"), spice initialization is a bit dodgy, and the client get stuck waiting for server events. The initialization order changed, so that qemu_spice_display_start() is called befor

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-27 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 05:24:10PM +, Alex Bennée wrote: > > Stefan Weil writes: > > > Am 25.01.21 um 23:35 schrieb Richard Henderson: > >> On 1/25/21 11:02 AM, Stefan Weil wrote: > >>> Am 25.01.21 um 20:02 schrieb Richard Henderson: > On 1/25/21 8:58 AM, Stefan Weil wrote: > > I ha

Re: Handling multiple inheritance [for CXL]

2021-01-27 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 01:33:52PM -0800, Ben Widawsky wrote: > I'm working on CXL 2.0 type 3 memory devices [1]. In short, these are PCIe > devices > that have persistent memory on them. As such, it would be nice to inherit from > both a PCI_DEVICE class as well as an NVDIMM device class. > > Tr

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Stefan Hajnoczi
On Tue, Jan 26, 2021 at 06:16:04PM +0100, Greg Kurz wrote: > On Tue, 26 Jan 2021 10:35:02 + > Stefan Hajnoczi wrote: > > > A well-behaved FUSE client does not attempt to open special files with > > FUSE_OPEN because they are handled on the client side (e.g. device nodes > > are handled by cli

Re: [PATCH] ui: fix spice display regression

2021-01-27 Thread Marc-André Lureau
Hi On Wed, Jan 27, 2021 at 2:03 PM wrote: > > From: Marc-André Lureau > > Since commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4 ("vl: remove > separate preconfig main_loop"), spice initialization is a bit dodgy, and > the client get stuck waiting for server events. > > The initialization order c

Re: [PATCH v2] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-27 Thread Stefano Garzarella
On Mon, Jan 25, 2021 at 08:25:05PM +0100, Eugenio Pérez wrote: Address space is destroyed without proper removal of its listeners with current code. They are expected to be removed in virtio_device_instance_finalize [1], but qemu calls it through object_deinit, after address_space_destroy call th

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 10:25:28 +0100 Miklos Szeredi wrote: > On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote: > > > > On Tue, 26 Jan 2021 10:35:02 + > > Stefan Hajnoczi wrote: > > > The patch looks pretty good to me. It just seems to be missing a change in > > lo_create(): > > > > fd = o

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 11:20 AM Greg Kurz wrote: > > On Wed, 27 Jan 2021 10:25:28 +0100 > Miklos Szeredi wrote: > > > On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote: > > > > > > On Tue, 26 Jan 2021 10:35:02 + > > > Stefan Hajnoczi wrote: > > > > > The patch looks pretty good to me. It jus

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/21/21 5:15 PM, Igor Mammedov wrote: Add documentation for '-machine memory-backend' CLI option and how to use it. And document that x-use-canonical-path-for-ramblock-id, is considered to be stable to make sure it won't go away by accident. x- was intended for unstable/iternal properties, a

Re: [PATCH v5 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-27 Thread Max Reitz
On 26.01.21 22:28, John Snow wrote: On 1/18/21 5:57 AM, Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory.  Of course, most of them do not pass, so there is an extensive skip list for now.  (The only files that do pass are 209, 254, 283,

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > Add documentation for '-machine memory-backend' CLI option and > how to use it. > > And document that x-use-canonical-path-for-ramblock-id, > is considered to be stable to make sure it won't go away by accident. > > x- was intended

Re: [PATCH] ui: fix spice display regression

2021-01-27 Thread Paolo Bonzini
On 27/01/21 11:18, Marc-André Lureau wrote: Hi On Wed, Jan 27, 2021 at 2:03 PM wrote: From: Marc-André Lureau Since commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4 ("vl: remove separate preconfig main_loop"), spice initialization is a bit dodgy, and the client get stuck waiting for server e

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > And document that x-use-canonical-path-for-ramblock-id, > > is consider

[PULL 2/3] vnc: send extended desktop resize on update requests

2021-01-27 Thread Gerd Hoffmann
Unlike other pseudo-encodings these don't break gtk-vnc because older versions don't suport the extended desktop resize extension in the first place. Signed-off-by: Gerd Hoffmann Tested-by: Laszlo Ersek Message-Id: <20210125104041.495274-3-kra...@redhat.com> --- ui/vnc.c | 3 +++ 1 file changed

[PULL 3/3] hw/display/vmware_vga: Remove dependency on VNC header

2021-01-27 Thread Gerd Hoffmann
From: Peter Maydell In commit 2f487a3d40faff1 we fixed a problem observed with using the vmware-vga device and the VNC UI frontend in a belt-and-braces manner: * we made the VNC frontend handle non-multiple-of-16 surface widths * we rounded up the vmware-vga display width to a multiple of 16 H

[PULL 0/3] Ui 20210127 patches

2021-01-27 Thread Gerd Hoffmann
The following changes since commit 9cd69f1a270235b652766f00b94114f48a2d603f: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2021-01-25= -1' into staging (2021-01-26 09:51:02 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-202

[PULL 1/3] Revert "vnc: move initialization to framebuffer_update_request"

2021-01-27 Thread Gerd Hoffmann
This reverts commit 9e1632ad07ca49de99da4bb231e9e2f22f2d8df5. Older gtk-vnc versions can't deal with non-incremental update requests sending pseudo-encodings, so trying to send full server state (including desktop size, cursor etc. which is done using pseudo-encodings) doesn't fly. Return to old

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Stefan Hajnoczi
On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: > From: Leonardo Garcia > > Currently, as IOMMU and ATS are not supported, if a user mistakenly set > any of them and tries to mount the vhost-user filesystem inside the > guest, whenever the user tries to access the mount po

Re: [RFC PATCH v2 2/3] vfio: Set the priority of the VFIO VM state change handler explicitly

2021-01-27 Thread Shenming Lu
On 2021/1/27 5:36, Alex Williamson wrote: > On Wed, 9 Dec 2020 16:09:18 +0800 > Shenming Lu wrote: > >> In the VFIO VM state change handler, VFIO devices are transitioned >> in the _SAVING state, which should keep them from sending interrupts. > > Is this comment accurate? It's my expectation t

[PATCH v3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Stefan Hajnoczi
A well-behaved FUSE client does not attempt to open special files with FUSE_OPEN because they are handled on the client side (e.g. device nodes are handled by client-side device drivers). The check to prevent virtiofsd from opening special files is missing in a few cases, most notably FUSE_OPEN. A

Re: [RFC PATCH v2 3/3] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-01-27 Thread Shenming Lu
On 2021/1/27 5:36, Alex Williamson wrote: > On Wed, 9 Dec 2020 16:09:19 +0800 > Shenming Lu wrote: > >> Different from the normal situation when the guest starts, we can >> know the max unmasked vetctor (at the beginning) after msix_load() >> in VFIO migration. So in order to avoid ineffectively

Re: [PATCH 3/7] ppc/pnv: Use skiboot addresses to load kernel and ramfs

2021-01-27 Thread Murilo Opsfelder Araújo
On Tuesday, January 26, 2021 2:10:55 PM -03 Cédric Le Goater wrote: > The current settings are useful to load large kernels (with debug) but > it moves the initrd image in a memory region not protected by > skiboot. If skiboot is compiled with DEBUG=1, memory poisoning will > corrupt the initrd. >

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: > On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé wrote: > > > > On Tue, Jan 26, 2021 at 04:32:08PM +, Peter Maydell wrote: > > > ** (tests/test-crypto-tlscredsx509:35180): CRITICAL **: 16:23:34.590: > > > Failed to sign certifica

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Leonardo Augusto Guimarães Garcia
On 1/27/21 8:19 AM, Stefan Hajnoczi wrote: On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Currently, as IOMMU and ATS are not supported, if a user mistakenly set any of them and tries to mount the vhost-user filesystem inside the guest, whenever t

[PATCH v2] tcg/tci: Fix some unaligned memory accesses

2021-01-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- v2: Use inline functions from qemu/bswap.h instead of memcpy as suggested by Richard. tcg/tci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tcg/tci.c b/tcg/tci.c index 42354d8ebb..ddbb259e1d 100644 --- a/tcg/tci.c +++ b/tcg/t

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Christian Schoenebeck
On Mittwoch, 27. Januar 2021 13:17:23 CET Daniel P. Berrangé wrote: > On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: > > On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé wrote: > > > On Tue, Jan 26, 2021 at 04:32:08PM +, Peter Maydell wrote: > > > > ** (tests/test-crypto-tlscr

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 01:35:37PM +0100, Christian Schoenebeck wrote: > On Mittwoch, 27. Januar 2021 13:17:23 CET Daniel P. Berrangé wrote: > > On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: > > > On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé > wrote: > > > > On Tue, Jan 26, 2

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-27 Thread Alex Bennée
Daniel P. Berrangé writes: > On Tue, Jan 26, 2021 at 05:24:10PM +, Alex Bennée wrote: >> >> Stefan Weil writes: >> >> > Am 25.01.21 um 23:35 schrieb Richard Henderson: >> >> On 1/25/21 11:02 AM, Stefan Weil wrote: >> >>> Am 25.01.21 um 20:02 schrieb Richard Henderson: >> On 1/25/21

Re: [PATCH v5 00/11] virtio-mem: vfio support

2021-01-27 Thread Michael S. Tsirkin
On Thu, Jan 21, 2021 at 12:05:29PM +0100, David Hildenbrand wrote: > A virtio-mem device manages a memory region in guest physical address > space, represented as a single (currently large) memory region in QEMU, > mapped into system memory address space. Before the guest is allowed to use > memory

Re: [PATCH] vfio/migrate: Move switch of dirty tracking into vfio_memory_listener

2021-01-27 Thread Paolo Bonzini
On 11/01/21 08:34, Keqian Zhu wrote: +static void vfio_listener_log_start(MemoryListener *listener, +MemoryRegionSection *section, +int old, int new) +{ +VFIOContainer *container = container_of(listener, VFIOContainer, li

Re: [PATCH v4 0/2] System Generation ID driver and VMGENID backend

2021-01-27 Thread Michael S. Tsirkin
On Thu, Jan 21, 2021 at 10:28:16AM +, Catangiu, Adrian Costin wrote: > On 12/01/2021, 14:49, "Michael S. Tsirkin" wrote: > > On Tue, Jan 12, 2021 at 02:15:58PM +0200, Adrian Catangiu wrote: > > The first patch in the set implements a device driver which exposes a > > read-only dev

Re: [PATCH 1/6] qapi: Add interfaces for alias support to Visitor

2021-01-27 Thread Markus Armbruster
Kevin Wolf writes: > This adds functions to the Visitor interface that can be used to define > aliases and alias scopes. > > Signed-off-by: Kevin Wolf > --- > include/qapi/visitor-impl.h | 12 > include/qapi/visitor.h | 37 + > qapi/qapi-vis

Re: [PATCH v3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 12:21 PM Stefan Hajnoczi wrote: } > @@ -1654,9 +1677,11 @@ static void update_open_flags(int writeback, int > allow_direct_io, > static void lo_create(fuse_req_t req, fuse_ino_t parent, const char *name, >mode_t mode, struct fuse_file

Re: [PATCH 2/6] qapi: Remember alias definitions in qobject-input-visitor

2021-01-27 Thread Markus Armbruster
Kevin Wolf writes: > This makes qobject-input-visitor remember the currently valid aliases in > each StackObject. It doesn't actually allow using the aliases yet. > > Signed-off-by: Kevin Wolf > --- > qapi/qobject-input-visitor.c | 115 +++ > 1 file changed, 115

[PATCH] hw/block/nvme: drain namespaces on sq deletion

2021-01-27 Thread Klaus Jensen
From: Klaus Jensen For most commands, when issuing an AIO, the BlockAIOCB is stored in the NvmeRequest aiocb pointer when the AIO is issued. The purpose of storing this is to allow the AIO to be cancelled when deleting submission queues (it is currently not used for Abort). Since the addition of

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 11:34:52 +0100 Miklos Szeredi wrote: > On Wed, Jan 27, 2021 at 11:20 AM Greg Kurz wrote: > > > > On Wed, 27 Jan 2021 10:25:28 +0100 > > Miklos Szeredi wrote: > > > > > On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote: > > > > > > > > On Tue, 26 Jan 2021 10:35:02 + > > >

Re: [PATCH 3/6] qapi: Simplify full_name_nth() in qobject-input-visitor

2021-01-27 Thread Markus Armbruster
Kevin Wolf writes: > Instead of counting how many elements from the top of the stack we need > to ignore until we find the thing we're interested in, we can just > directly pass the StackObject pointer because all callers already know > it. > > We only need a different way now to tell if we want

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 2:49 PM Greg Kurz wrote: > > On Wed, 27 Jan 2021 11:34:52 +0100 > Miklos Szeredi wrote: > > Another solution specifically for O_CREAT without O_EXCL would be to > > turn it into an exclusive create. > > Would this added O_EXCL then appear on the client side, e.g. to > gue

Re: [PATCH v3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Stefan Hajnoczi
On Wed, Jan 27, 2021 at 02:01:54PM +0100, Miklos Szeredi wrote: > On Wed, Jan 27, 2021 at 12:21 PM Stefan Hajnoczi wrote: > } > > @@ -1654,9 +1677,11 @@ static void update_open_flags(int writeback, int > > allow_direct_io, > > static void lo_create(fuse_req_t req, fuse_ino_t parent

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Stefan Hajnoczi
On Wed, Jan 27, 2021 at 09:30:35AM -0300, Leonardo Augusto Guimarães Garcia wrote: > On 1/27/21 8:19 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: > > > From: Leonardo Garcia > > > > > > Currently, as IOMMU and ATS are not supported, if a

Re: [RFC PATCH v2 2/3] vfio: Set the priority of the VFIO VM state change handler explicitly

2021-01-27 Thread Alex Williamson
On Wed, 27 Jan 2021 19:20:06 +0800 Shenming Lu wrote: > On 2021/1/27 5:36, Alex Williamson wrote: > > On Wed, 9 Dec 2020 16:09:18 +0800 > > Shenming Lu wrote: > > > >> In the VFIO VM state change handler, VFIO devices are transitioned > >> in the _SAVING state, which should keep them from sen

Re: [RFC PATCH v2 3/3] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-01-27 Thread Alex Williamson
On Wed, 27 Jan 2021 19:27:35 +0800 Shenming Lu wrote: > On 2021/1/27 5:36, Alex Williamson wrote: > > On Wed, 9 Dec 2020 16:09:19 +0800 > > Shenming Lu wrote: > > > >> Different from the normal situation when the guest starts, we can > >> know the max unmasked vetctor (at the beginning) after

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: How does a mgmt app know which machine types need to use this option ? The machine type names are opaque strings,

Re: [PATCH v3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 3:14 PM Stefan Hajnoczi wrote: > > On Wed, Jan 27, 2021 at 02:01:54PM +0100, Miklos Szeredi wrote: > > The problem here is there can also be a race between the open and the > > subsequent lo_do_lookup(). > > > > At this point it's probably enough to verify that fuse_entry_

Re: [PATCH] virtio: move 'use-disabled-flag' property to hw_compat_4_2

2021-01-27 Thread Dr. David Alan Gilbert
* Stefano Garzarella (sgarz...@redhat.com) wrote: > On Mon, Jan 18, 2021 at 04:03:12PM +, Dr. David Alan Gilbert wrote: > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > > Commit 9d7bd0826f introduced a new 'use-disabled-flag' property > > > set to true by default. > > > To allow the mi

Re: [PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-27 Thread Christian Schoenebeck
On Freitag, 15. Januar 2021 14:50:17 CET Christian Schoenebeck wrote: > On Freitag, 15. Januar 2021 14:42:24 CET Greg Kurz wrote: > > I've already moved my repositories to gitlab for extra CI coverage, > > and I won't use the ones at github anymore. > > > > Signed-off-by: Greg Kurz > > Reviewed-

Re: [PATCH] virtio: move 'use-disabled-flag' property to hw_compat_4_2

2021-01-27 Thread Stefano Garzarella
On Wed, Jan 27, 2021 at 02:28:13PM +, Dr. David Alan Gilbert wrote: * Stefano Garzarella (sgarz...@redhat.com) wrote: On Mon, Jan 18, 2021 at 04:03:12PM +, Dr. David Alan Gilbert wrote: > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > Commit 9d7bd0826f introduced a new 'use-disabl

seems currently QEMU doesn't support file backend for RAM memory region on Windows

2021-01-27 Thread Wu, Wentong
There is a doc about the API of memory-mapped file on Windows https://docs.microsoft.com/en-us/previous-versions/ms810613(v=msdn.10)?redirectedfrom=MSDN, not sure anyone is working on it. Thanks Wentong

[PATCH] docs/interop/qmp-spec: Document the request queue limit

2021-01-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- docs/interop/qmp-spec.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt index cdf5842555..b0e8351d5b 100644 --- a/docs/interop/qmp-spec.txt +++ b/docs/interop/qmp-spec.txt @@ -

Re: [PATCH v3 2/8] meson: move up hw subdir (specifically before trace subdir)

2021-01-27 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 01:50:22PM +0100, Gerd Hoffmann wrote: > Needed so trace/meson.build can see > stuff done in hw/*/meson.build. > > Signed-off-by: Gerd Hoffmann > --- > meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > inde

Re: [PATCH v3 1/8] meson: add trace_events_config[]

2021-01-27 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 01:50:21PM +0100, Gerd Hoffmann wrote: > It's an array of dicts, where each dict holds the configuration for one > trace-events file. For now just fill it from trace_events_subdirs. > > Signed-off-by: Gerd Hoffmann > --- > meson.build | 1 + > trace/meson.build |

Re: [PATCH v3 3/8] meson: add module_trace & module_trace_src

2021-01-27 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 01:50:23PM +0100, Gerd Hoffmann wrote: > module_trace is a dict which keeps track of the trace source files for a > module. > > module_trace_src collects the trace source files for a given trace-events > file, > which then either added to the source set or to a new module_

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 15:09:50 +0100 Miklos Szeredi wrote: > On Wed, Jan 27, 2021 at 2:49 PM Greg Kurz wrote: > > > > On Wed, 27 Jan 2021 11:34:52 +0100 > > Miklos Szeredi wrote: > > > > Another solution specifically for O_CREAT without O_EXCL would be to > > > turn it into an exclusive create.

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 03:24:26PM +0100, Michal Privoznik wrote: > On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > > > On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > > > > > > > How does a mgmt app know

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 4:09 PM Greg Kurz wrote: > > On Wed, 27 Jan 2021 15:09:50 +0100 > Miklos Szeredi wrote: > > The semantics of O_CREATE are that it can fail neither because the > > file exists nor because it doesn't. This doesn't matter if the > > exported tree is not modified outside of a

Re: [PATCH v3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 14:14:30 + Stefan Hajnoczi wrote: > On Wed, Jan 27, 2021 at 02:01:54PM +0100, Miklos Szeredi wrote: > > On Wed, Jan 27, 2021 at 12:21 PM Stefan Hajnoczi > > wrote: > > } > > > @@ -1654,9 +1677,11 @@ static void update_open_flags(int writeback, int > > > al

Re: [PATCH v3 4/8] meson: move qxl trace events to separate file

2021-01-27 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 01:50:24PM +0100, Gerd Hoffmann wrote: > Move qxl trace events to separate trace-events-qxl file. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/qxl-render.c | 1 + > hw/display/qxl.c| 1 + > hw/display/meson.build | 5 +++ > hw/display/trace-

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Igor Mammedov
On Wed, 27 Jan 2021 15:24:26 +0100 Michal Privoznik wrote: > On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > >> On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > > >> > >> How does a mgmt app know whic

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 16:22:49 +0100 Miklos Szeredi wrote: > On Wed, Jan 27, 2021 at 4:09 PM Greg Kurz wrote: > > > > On Wed, 27 Jan 2021 15:09:50 +0100 > > Miklos Szeredi wrote: > > > The semantics of O_CREATE are that it can fail neither because the > > > file exists nor because it doesn't. Th

[PATCH v6] Add support for pvpanic pci device

2021-01-27 Thread Mihai Carabas
This patchset adds support for pvpanic pci device. v3: - patch 1: made pvpanic isa device available only for PC, compile pvpanic-test only when isa device is present - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE, PVPANIC_PCI_DEVICE, added VMSTATE_PCI_DEVICE, removed INTERFACE_

[PATCH v6 4/4] tests/qtest: add a test case for pvpanic-pci

2021-01-27 Thread Mihai Carabas
Add a test case for pvpanic-pci device. The scenario is the same as pvpanic ISA device, but is using the PCI bus. Signed-off-by: Mihai Carabas Acked-by: Thomas Huth Reviewed-by: Peter Maydell Signed-off-by: Mihai Carabas --- tests/qtest/meson.build| 1 + tests/qtest/pvpanic-pci-test.

[PATCH v6 3/4] pvpanic : update pvpanic spec document

2021-01-27 Thread Mihai Carabas
Add pvpanic PCI device support details in docs/specs/pvpanic.txt. Signed-off-by: Mihai Carabas Reviewed-by: Peter Maydell --- docs/specs/pvpanic.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index a90fbca..8

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 4:35 PM Greg Kurz wrote: > > On Wed, 27 Jan 2021 16:22:49 +0100 > Miklos Szeredi wrote: > > > On Wed, Jan 27, 2021 at 4:09 PM Greg Kurz wrote: > > > > > > On Wed, 27 Jan 2021 15:09:50 +0100 > > > Miklos Szeredi wrote: > > > > The semantics of O_CREATE are that it can fai

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Leonardo Augusto Guimarães Garcia
On 1/27/21 8:19 AM, Stefan Hajnoczi wrote: On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Currently, as IOMMU and ATS are not supported, if a user mistakenly set any of them and tries to mount the vhost-user filesystem inside the guest, whenever t

[PATCH v6 1/4] hw/misc/pvpanic: split-out generic and bus dependent code

2021-01-27 Thread Mihai Carabas
To ease the PCI device addition in next patches, split the code as follows: - generic code (read/write/setup) is being kept in pvpanic.c - ISA dependent code moved to pvpanic-isa.c Also, rename: - ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE. - TYPE_PVPANIC -> TYPE_PVPANIC_ISA. - MemoryRegion io -> mr

[PATCH v6 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-27 Thread Mihai Carabas
Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c where the PCI specific routines reside and update the build system with the new files and config structure. Signed-off-by: Mihai Carabas Reviewed-by: Gerd Hoffmann Reviewed-by: Peter Maydell Signed-off-by: Mihai Carab

Re: [Virtio-fs] [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-27 Thread Miklos Szeredi
On Wed, Jan 27, 2021 at 4:47 PM Miklos Szeredi wrote: > > On Wed, Jan 27, 2021 at 4:35 PM Greg Kurz wrote: > > > > On Wed, 27 Jan 2021 16:22:49 +0100 > > Miklos Szeredi wrote: > > > > > On Wed, Jan 27, 2021 at 4:09 PM Greg Kurz wrote: > > > > > > > > On Wed, 27 Jan 2021 15:09:50 +0100 > > > > M

Re: [PATCH v6 01/14] block: return status from bdrv_append and friends

2021-01-27 Thread Alberto Garcia
On Sat 16 Jan 2021 10:51:56 PM CET, Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in

Re: [PATCH 1/6] migration: Fix and clean up around @tls-authz

2021-01-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Dec 17, 2020 at 02:07:01PM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Dec 14, 2020 at 11:14:34AM +0100, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Fri, Nov 13, 2020 at 07:52:31AM +0100, Mar

Re: [PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-27 Thread Greg Kurz
On Wed, 27 Jan 2021 15:33:51 +0100 Christian Schoenebeck wrote: > On Freitag, 15. Januar 2021 14:50:17 CET Christian Schoenebeck wrote: > > On Freitag, 15. Januar 2021 14:42:24 CET Greg Kurz wrote: > > > I've already moved my repositories to gitlab for extra CI coverage, > > > and I won't use the

Re: [PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-27 Thread Laurent Vivier
Le 27/01/2021 à 17:02, Greg Kurz a écrit : > On Wed, 27 Jan 2021 15:33:51 +0100 > Christian Schoenebeck wrote: > >> On Freitag, 15. Januar 2021 14:50:17 CET Christian Schoenebeck wrote: >>> On Freitag, 15. Januar 2021 14:42:24 CET Greg Kurz wrote: I've already moved my repositories to gitlab

Re: [PATCH] tcg/tci: Restrict tci_write_reg16() to 64-bit hosts

2021-01-27 Thread Laurent Vivier
Le 23/01/2021 à 11:30, Stefan Weil a écrit : > Am 23.01.21 um 10:41 schrieb Philippe Mathieu-Daudé: > >> Restrict tci_write_reg16() to 64-bit hosts to fix on 32-bit ones: >> >>    [520/1115] Compiling C object libqemu-arm-linux-user.fa.p/tcg_tci.c.o >>    FAILED: libqemu-arm-linux-user.fa.p/tcg_tc

Re: [PATCHv2] configure: replace --enable/disable-git-update with --with-git-submodules

2021-01-27 Thread Daniel P . Berrangé
On Tue, Jan 19, 2021 at 12:20:46PM -0500, Dan Streetman wrote: > Replace the --enable-git-update and --disable-git-update configure params > with the param --with-git-submodules=(update|validate|ignore) to > allow 3 options for building from a git repo. > > This is needed because downstream packag

Re: [PATCH] net/slirp.c: Fix spelling error in error message

2021-01-27 Thread Laurent Vivier
Le 25/01/2021 à 17:08, Philippe Mathieu-Daudé a écrit : > On 1/22/21 1:42 AM, dje--- via wrote: >> DNS should be DHCP >> >> Signed-off-by: Doug Evans >> --- >> net/slirp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Philippe Mathieu-Daudé > > Applied to my trivi

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Dr. David Alan Gilbert
* Leonardo Augusto Guimarães Garcia (lagar...@linux.ibm.com) wrote: > On 1/27/21 8:19 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: > > > From: Leonardo Garcia > > > > > > Currently, as IOMMU and ATS are not supported, if a user mistakenly

Re: [PATCH] MAINTAINERS: Update 9pfs tree URL

2021-01-27 Thread Christian Schoenebeck
On Mittwoch, 27. Januar 2021 17:07:38 CET Laurent Vivier wrote: > Le 27/01/2021 à 17:02, Greg Kurz a écrit : > > On Wed, 27 Jan 2021 15:33:51 +0100 > > > > Christian Schoenebeck wrote: > >> On Freitag, 15. Januar 2021 14:50:17 CET Christian Schoenebeck wrote: > >>> On Freitag, 15. Januar 2021 14:

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 13:17 schrieb Daniel P. Berrangé: On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé wrote: On Tue, Jan 26, 2021 at 04:32:08PM +, Peter Maydell wrote: ** (tests/test-crypto-tlscredsx509:35180): CRITICAL **: 16:23

Re: [PATCH v20 01/20] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-01-27 Thread Jag Raman
Hi Cedric, > On Jan 25, 2021, at 11:57 AM, Cédric Le Goater wrote: > > Hello, > > Thanks for this patchset. I have a slightly "off topic" question > but I don't want to distract the maintainers from merging any of > this. Feel free to ignore. > > I understand that this framework is targetti

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-01-27 Thread Laszlo Ersek
On 01/27/21 12:19, Stefan Hajnoczi wrote: > On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: >> From: Leonardo Garcia >> >> Currently, as IOMMU and ATS are not supported, if a user mistakenly set >> any of them and tries to mount the vhost-user filesystem inside the >> guest

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 05:44:59PM +0100, Stefan Weil wrote: > Am 27.01.21 um 13:17 schrieb Daniel P. Berrangé: > > > On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: > > > On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé > > > wrote: > > > > On Tue, Jan 26, 2021 at 04:32:08PM +000

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/27/21 4:35 PM, Igor Mammedov wrote: On Wed, 27 Jan 2021 15:24:26 +0100 Michal Privoznik wrote: On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: How does

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 17:53 schrieb Daniel P. Berrangé: In $QEMU.git/crypto/init.c can you uncomment the "#define DEBUG_GNUTLS" line and then re-build and re-run the test case. There's a bunch of debug logs in code paths from gnutls_x509_crt_privkey_sign that might give us useful info. Regards, Danie

Re: Handling multiple inheritance [for CXL]

2021-01-27 Thread Ben Widawsky
On 21-01-27 10:06:48, Daniel P. Berrangé wrote: > On Tue, Jan 26, 2021 at 01:33:52PM -0800, Ben Widawsky wrote: > > I'm working on CXL 2.0 type 3 memory devices [1]. In short, these are PCIe > > devices > > that have persistent memory on them. As such, it would be nice to inherit > > from > > bot

Re: [PATCH v4 1/7] qapi/block-core: Add retry option for error action

2021-01-27 Thread Eric Blake
On 12/15/20 6:30 AM, Jiahui Cen wrote: > Add a new error action 'retry' to support retry on errors. > > Signed-off-by: Jiahui Cen > Signed-off-by: Ying Fang > --- > blockdev.c | 2 ++ > qapi/block-core.json | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > +++ b/qapi/blo

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-27 Thread Richard Henderson
On 1/26/21 8:53 PM, Stefan Weil wrote: > And the remaining TODO assertions are a good indicator that the current tests > are incomplete for native TCG because they obviously don't cover all TCG > opcodes. If the symbol appears in target/, then the opcode can be produced. I've just shown you how

  1   2   3   >