On Tue, Jan 19, 2021 at 12:20:46PM -0500, Dan Streetman wrote: > Replace the --enable-git-update and --disable-git-update configure params > with the param --with-git-submodules=(update|validate|ignore) to > allow 3 options for building from a git repo. > > This is needed because downstream packagers, e.g. Debian, Ubuntu, etc, > also keep the source code in git, but do not want to enable the > 'git_update' mode; with the current code, that's not possible even > if the downstream package specifies --disable-git-update. > > The previous parameters are deprecated but still available; the > --enable-git-update parameter maps to --with-git-submodules=update and > --disable-git-update parameter maps to --with-git-submodules=validate. > > The configure script behavior is slightly modified, where previously > the dtc, capstone, and slirp submodules were not validated when > --disable-git-update was specified (but were updated with git-update > enabled), now they are validated when using --with-git-submodules=validate > and are only ignored when using --with-git-submodules=ignore. > > Signed-off-by: Dan Streetman <ddstr...@canonical.com> > --- > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg04799.html > changes since v1: > - add --help output explaining --with-git-submodules valid values > - validate dtc, capstone, slirp submodules also > - update commit description text > > Makefile | 24 ++----------------- > configure | 51 ++++++++++++++++++++++++++++++---------- > scripts/git-submodule.sh | 34 ++++++++++++++++++++------- > 3 files changed, 66 insertions(+), 43 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> I'll queue this with a batch of misc changes i have pending. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
