Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/01/21 14:58, Markus Armbruster wrote: >>> qemu_machine_opts ("-M") >>> qemu_find_opts_singleton("machine") >> >> Gone since your commit 4988a4ea4d "vl: switch -M parsing to keyval". > > Which is part of this series and not yet included in QEMU. Hence the > comm

Re: [PATCH v3 02/25] qapi: backup: add perf.use-copy-range parameter

2021-01-20 Thread Max Reitz
On 20.01.21 07:09, Vladimir Sementsov-Ogievskiy wrote: 19.01.2021 23:21, Eric Blake wrote: On 10/26/20 12:17 PM, Vladimir Sementsov-Ogievskiy wrote: Experiments show, that copy_range is not always making things faster. So, to make experimentation simpler, let's add a parameter. Some more perf p

Re: [PATCH] qmp-shell: Suppress banner and prompt when stdin is not a TTY

2021-01-20 Thread Dov Murik
Hi John, On 19/01/2021 22:02, John Snow wrote: On 1/17/21 2:27 AM, Dov Murik wrote: Detect whether qmp-shell's standard input is not a TTY; in such case, assume a non-interactive mode, which suppresses the welcome banner and the "(QEMU)" prompt.  This allows for easier consumption of qmp-shell'

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/01/21 16:56, Markus Armbruster wrote: >>> +if (!is_help && warn_on_flag) { >>> +warn_report("short-form boolean option '%s%s' deprecated", >>> prefix, *name); >>> +error_printf("Please use %s=%s instead\n", *name, *value);

Re: [PATCH v2] RFC: sphinx: adopt kernel readthedoc theme

2021-01-20 Thread Bin Meng
On Wed, Jan 20, 2021 at 3:41 PM wrote: > > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours > > The "rtd" theme from readthedocs

[Bug 1872644] Re: MacOS host qemu-system-x86_64 -cpu host not working

2021-01-20 Thread Sitsofe Wheeler
I found that things were unstable unless the following were also added -cpu Nehalem,-rdtscp (the CPU can be higher than Nehalem but obviously your host CPU actually has to be equal or greater too) -rdtscp is a known issue that has since been workedaround (see bug #1894836 ). -- You received thi

Re: eMMC support

2021-01-20 Thread Cédric Le Goater
On 9/17/20 8:25 AM, Cédric Le Goater wrote: > On 9/17/20 2:55 AM, Joel Stanley wrote: >> On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: >>> >>> Hi Philippe, >>> >>> >>> >>> We are looking to add eMMC support, I searched the mailing list and found a >>> series posted on eMMC by “Vincent Pala

Re: [PATCH] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 7:07 AM, Alexander Bulekov wrote: > Disks work differently depending on the x86 machine type (SATA vs PATA). > Additionally, we should fuzz the atapi code paths, which might contain > vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and > cdrom generic-fuzzer configs for

Re: [PATCH 7/9] meson: Do not configure audio if system-mode is not selected

2021-01-20 Thread Gerd Hoffmann
> > +## > > +# Disable features only meaningful for system-mode emulation > > +if test "$softmmu" = "no"; then > > +audio_drv_list="" > > +fi > > + Acked-by: Gerd Hoffmann > > ## > > # Some versions of Mac OS X

Re: [PATCH v2 12/36] block: refactor bdrv_child* permission functions

2021-01-20 Thread Kevin Wolf
Am 19.01.2021 um 19:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.01.2021 21:09, Kevin Wolf wrote: > > Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Split out non-recursive parts, and refactor as block graph transaction > > > action. > > > > > > Signed-off-by:

Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-20 Thread BALATON Zoltan
On Wed, 20 Jan 2021, Philippe Mathieu-Daudé wrote: On 1/20/21 12:06 AM, BALATON Zoltan wrote: On Tue, 19 Jan 2021, Richard Henderson wrote: My recent change for caching tcg constants has, in a number of cases, overflowed the statically allocated array of temporaries.  Change to dynamic allocati

[PATCH v2] ide: set an upper limit to nb_sectors

2021-01-20 Thread P J P
From: Prasad J Pandit Set an upper limit to number of sectors on an IDE disk media. This is to ensure that logical block addresses (LBA) and nb_sector arguments remain within INT_MAX range. Suggested-by: Paolo Bonzini Signed-off-by: Prasad J Pandit --- hw/ide/core.c | 27 +

Re: [PATCH] usb: add pcap support.

2021-01-20 Thread Gerd Hoffmann
Hi, > > diff --git a/hw/usb/pcap.c b/hw/usb/pcap.c > > new file mode 100644 > > index ..d3162d65e5fe > > --- /dev/null > > +++ b/hw/usb/pcap.c > > @@ -0,0 +1,242 @@ > > Missing license. Good point. > > +struct pcap_hdr { > > QEMU_PACKED? > > > +struct pcaprec_hdr { > > QEMU_PAC

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Pierre Morel
On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check. Removing this fence, however, reveals additional deficiencies in the s390x PCI interception layer that prevent ISM

Re: [PATCH] hw/block/nvme: fix zone write finalize

2021-01-20 Thread Klaus Jensen
On Jan 12 10:42, Klaus Jensen wrote: > From: Klaus Jensen > > The zone write pointer is unconditionally advanced, even for write > faults. Make sure that the zone is always transitioned to Full if the > write pointer reaches zone capacity. > > Signed-off-by: Klaus Jensen > Cc: Dmitry Fomichev

Re: [PATCH v4 0/3] support NVMe smart critial warning injection

2021-01-20 Thread Klaus Jensen
On Jan 15 11:26, zhenwei pi wrote: > v3 -> v4: > - Drop "Fix overwritten bar.cap". (Already fixed) > > - Avoid to enqueue the duplicate event. > > - Several minor changes for coding style & function/variable name. > > v2 -> v3: > - Introduce "Persistent Memory Region has become read-only or >

[PATCHv8 0/3] arm-virt: add secure pl061 for reset/power down

2021-01-20 Thread Maxim Uvarov
v8: - use gpio 0 and 1, align dtb with kernel gpio-restart, gpio-poweroff, change define names, trigger on upper front. (Peter Maydell). v7: - same as v6, but resplit patches: patch 2 no function changes and refactor gpio setup for virt platfrom and patch 3 adds secure gpio. v6: -

[PATCHv8 1/3] hw: gpio: implement gpio-pwr driver for qemu reset/poweroff

2021-01-20 Thread Maxim Uvarov
Implement gpio-pwr driver to allow reboot and poweroff machine. This is simple driver with just 2 gpios lines. Current use case is to reboot and poweroff virt machine in secure mode. Secure pl066 gpio chip is needed for that. Signed-off-by: Maxim Uvarov Reviewed-by: Hao Wu --- hw/gpio/Kconfig

[PATCHv8 2/3] arm-virt: refactor gpios creation

2021-01-20 Thread Maxim Uvarov
No functional change. Just refactor code to better support secure and normal world gpios. Signed-off-by: Maxim Uvarov --- hw/arm/virt.c | 64 ++- 1 file changed, 43 insertions(+), 21 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 96

[PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-20 Thread Maxim Uvarov
Add secure pl061 for reset/power down machine from the secure world (Arm Trusted Firmware). Connect it with gpio-pwr driver. Signed-off-by: Maxim Uvarov --- hw/arm/Kconfig| 1 + hw/arm/virt.c | 47 +++ include/hw/arm/virt.h | 2 ++ 3 file

Re: [PATCH v2 01/12] vhost-user-blk: fix blkcfg->num_queues endianness

2021-01-20 Thread Michael S. Tsirkin
On Mon, Dec 07, 2020 at 05:20:19PM +, Stefan Hajnoczi wrote: > Treat the num_queues field as virtio-endian. On big-endian hosts the > vhost-user-blk num_queues field was in the wrong endianness. > > Move the blkcfg.num_queues store operation from realize to > vhost_user_blk_update_config() so

Re: [PATCH] qmp-shell: Suppress banner and prompt when stdin is not a TTY

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 10:25:25AM +0200, Dov Murik wrote: > Hi John, > > On 19/01/2021 22:02, John Snow wrote: > > On 1/17/21 2:27 AM, Dov Murik wrote: > > > Detect whether qmp-shell's standard input is not a TTY; in such case, > > > assume a non-interactive mode, which suppresses the welcome ban

Re: [PATCH] usb: Fix clang build

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 12:20:43AM +0100, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 1/20/21 12:07 AM, Eric Blake wrote: > > ../hw/usb/dev-uas.c:157:31: error: field 'status' with variable sized type > > 'uas_iu' not at the end of a struct or class is a GNU extension > > [-Werror,-Wgnu-vari

Re: [PATCH] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Thomas Huth
On 20/01/2021 07.07, Alexander Bulekov wrote: Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both

Re: [PATCH v2] RFC: sphinx: adopt kernel readthedoc theme

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 11:41:02AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours

Re: [PATCH v2 12/36] block: refactor bdrv_child* permission functions

2021-01-20 Thread Vladimir Sementsov-Ogievskiy
20.01.2021 12:09, Kevin Wolf wrote: Am 19.01.2021 um 19:30 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.01.2021 21:09, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Split out non-recursive parts, and refactor as block graph transaction action. Sign

Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature

2021-01-20 Thread Igor Mammedov
On Tue, 19 Jan 2021 11:30:52 -0500 Eduardo Habkost wrote: > On Tue, Jan 19, 2021 at 04:27:56PM +, David Edmondson wrote: > > On Tuesday, 2021-01-19 at 10:20:56 -05, Eduardo Habkost wrote: > > > > > Hi, > > > > > > Thanks for the patch. Getting rid of special -feature/+feature > > > behavi

Re: [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults

2021-01-20 Thread Igor Mammedov
On Tue, 19 Jan 2021 16:41:42 + Daniel P. Berrangé wrote: > On Tue, Jan 19, 2021 at 11:35:18AM -0500, Eduardo Habkost wrote: > > On Tue, Jan 19, 2021 at 04:28:26PM +, Daniel P. Berrangé wrote: > > > On Tue, Jan 19, 2021 at 02:22:05PM +, David Edmondson wrote: > > > > Currently "-cp

Re: [PATCH v2 12/36] block: refactor bdrv_child* permission functions

2021-01-20 Thread Kevin Wolf
Am 20.01.2021 um 10:56 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.01.2021 12:09, Kevin Wolf wrote: > > Am 19.01.2021 um 19:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 19.01.2021 21:09, Kevin Wolf wrote: > > > > Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben:

Re: [PATCH] hostmem: Don't report pmem attribute if unsupported

2021-01-20 Thread Igor Mammedov
On Tue, 19 Jan 2021 13:35:35 +0100 Michal Privoznik wrote: > When management applications (like Libvirt) want to check whether > memory-backend-file.pmem is supported they can list object > properties using 'qom-list-properties'. However, 'pmem' is > declared always (and thus reported always) and

Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature

2021-01-20 Thread Daniel P . Berrangé
On Tue, Jan 19, 2021 at 11:30:52AM -0500, Eduardo Habkost wrote: > On Tue, Jan 19, 2021 at 04:27:56PM +, David Edmondson wrote: > > On Tuesday, 2021-01-19 at 10:20:56 -05, Eduardo Habkost wrote: > > > > > Hi, > > > > > > Thanks for the patch. Getting rid of special -feature/+feature > > > beh

Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature

2021-01-20 Thread David Edmondson
On Wednesday, 2021-01-20 at 10:59:24 +01, Igor Mammedov wrote: > On Tue, 19 Jan 2021 11:30:52 -0500 > Eduardo Habkost wrote: > >> On Tue, Jan 19, 2021 at 04:27:56PM +, David Edmondson wrote: >> > On Tuesday, 2021-01-19 at 10:20:56 -05, Eduardo Habkost wrote: >> > >> > > Hi, >> > > >> > > T

Re: [PATCH] fuzz: ignore address_space_map is_write flag

2021-01-20 Thread Darren Kenny
On Wednesday, 2021-01-20 at 01:02:55 -05, Alexander Bulekov wrote: > We passed an is_write flag to the fuzz_dma_read_cb function to > differentiate between the mapped DMA regions that need to be populated > with fuzzed data, and those that don't. We simply passed through the > address_space_map is_

Re: [PATCH] pci: add romsize property

2021-01-20 Thread David Edmondson
On Tuesday, 2021-01-19 at 17:51:32 +01, Philippe Mathieu-Daudé wrote: > +pflash > > On 12/18/20 7:27 PM, Paolo Bonzini wrote: >> This property can be useful for distros to set up known-good ROM sizes for >> migration purposes. The VM will fail to start if the ROM is too large, >> and migration co

Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature

2021-01-20 Thread David Edmondson
On Wednesday, 2021-01-20 at 10:08:03 GMT, Daniel P. Berrangé wrote: > On Tue, Jan 19, 2021 at 11:30:52AM -0500, Eduardo Habkost wrote: >> On Tue, Jan 19, 2021 at 04:27:56PM +, David Edmondson wrote: >> > On Tuesday, 2021-01-19 at 10:20:56 -05, Eduardo Habkost wrote: >> > >> > > Hi, >> > > >>

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-20 Thread Igor Mammedov
On Fri, 15 Jan 2021 10:36:05 +0100 Michal Privoznik wrote: > On 1/15/21 12:46 AM, Igor Mammedov wrote: > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > And document that x-use-canonical-path-for-ramblock-id, > > is considered to be stable to make sure

[PATCH v4 11.5/23] iotests/129: Limit backup's max-chunk/max-workers

2021-01-20 Thread Max Reitz
Right now, this does not change anything, because backup ignores max-chunk and max-workers. However, as soon as backup is switched over to block-copy for the background copying process, we will need it to keep 129 passing. Signed-off-by: Max Reitz --- Hi Vladimir, would you be OK with this? ---

[PATCH v3] sphinx: adopt kernel readthedoc theme

2021-01-20 Thread marcandre . lureau
From: Marc-André Lureau The default "alabaster" sphinx theme has a couple shortcomings: - the navbar moves along the page - the search bar is not always at the same place - it lacks some contrast and colours The "rtd" theme from readthedocs.org is a popular third party theme used notably by the

Re: [PATCH v3] sphinx: adopt kernel readthedoc theme

2021-01-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210120102556.125012-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210120102556.125012-1-marcandre.lur...@redhat.com Subject: [PATCH v3] sphinx:

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Max Reitz
On 19.01.21 20:22, Vladimir Sementsov-Ogievskiy wrote: 19.01.2021 21:40, Max Reitz wrote: On 16.01.21 22:46, Vladimir Sementsov-Ogievskiy wrote: Hi Max! I applied my series onto yours 129-fixing and found, that 129 fails for backup. And setting small max-chunk and even max-workers to 1 doesn't

[PATCH v9 00/11] migration: bring improved savevm/loadvm/delvm to QMP

2021-01-20 Thread Daniel P . Berrangé
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html v5: ht

[PATCH v9 01/11] block: push error reporting into bdrv_all_*_snapshot functions

2021-01-20 Thread Daniel P . Berrangé
The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers are reporting the same error message, but with slightly different text. In the future there will be more error scenarios

[PATCH v9 05/11] block: allow specifying name of block device for vmstate storage

2021-01-20 Thread Daniel P . Berrangé
Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block device to store the state in. Reviewed-by: Eric B

[PATCH v9 06/11] block: rename and alter bdrv_all_find_snapshot semantics

2021-01-20 Thread Daniel P . Berrangé
Currently bdrv_all_find_snapshot() will return 0 if it finds a snapshot, -1 if an error occurs, or if it fails to find a snapshot. New callers to be added want to distinguish between the error scenario and failing to find a snapshot. Rename it to bdrv_all_has_snapshot and make it return -1 on erro

[PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Daniel P . Berrangé
From: Philippe Mathieu-Daudé Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe Mathieu-Daudé --- include/migratio

[PATCH v9 03/11] migration: stop returning errno from load_snapshot()

2021-01-20 Thread Daniel P . Berrangé
None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns a boolean value. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé [PMD: Return false/true instead of -1/0, docu

[PATCH v9 07/11] migration: control whether snapshots are ovewritten

2021-01-20 Thread Daniel P . Berrangé
The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- include/migrati

[PATCH v9 10/11] iotests: add support for capturing and matching QMP events

2021-01-20 Thread Daniel P . Berrangé
When using the _launch_qemu and _send_qemu_cmd functions from common.qemu, any QMP events get mixed in with the output from the commands and responses. This makes it difficult to write a test case as the ordering of events in the output is not stable. This introduces a variable 'capture_events' w

[PATCH v9 04/11] block: add ability to specify list of blockdevs during snapshot

2021-01-20 Thread Daniel P . Berrangé
When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not have a single correct answer. Thus there needs to

[PATCH v9 09/11] migration: introduce a delete_snapshot wrapper

2021-01-20 Thread Daniel P . Berrangé
Make snapshot deletion consistent with the snapshot save and load commands by using a wrapper around the blockdev layer. The main difference is that we get upfront validation of the passed in device list (if any). Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 13 ++

[PATCH v9 08/11] migration: wire up support for snapshot device selection

2021-01-20 Thread Daniel P . Berrangé
Modify load_snapshot/save_snapshot to accept the device list and vmstate node name parameters previously added to the block layer. Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 18 -- migration/savevm.c | 30 ++ monitor

Re: What are libvhost-user locking requirements

2021-01-20 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Hi, > > Current virtiofsd code uses libvhost-user and I am assuming virtiofsd-rs > uses it too. I am wondering what are the locking requirements for > this library. No, virtiofsd-rs uses the rust crate: https://github.com/rust-vmm/vhost-user-backend I g

[PATCH v2 0/1] spapr_caps.c: check user input before warning about TCG only caps

2021-01-20 Thread Daniel Henrique Barboza
changes from v1: - check command line input to decide if the warning will be shown instead of setting capabilities based on running with TCG or not. - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg04890.html Daniel Henrique Barboza (1): spapr_caps.c: check user input befor

[PATCH v9 11/11] migration: introduce snapshot-{save, load, delete} QMP commands

2021-01-20 Thread Daniel P . Berrangé
savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downside, however, libvirt and ap

Re: [RFC PATCH v2 19/20] stubs/vmstate: Add VMSTATE_END_OF_LIST to vmstate_user_mode_cpu_dummy

2021-01-20 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Add a name and end marker to the vmstate_user_mode_cpu_dummy variable. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > stubs/vmstate.c | 7 ++- > 1 file chang

[PATCH v2 1/1] spapr_caps.c: check user input before warning about TCG only caps

2021-01-20 Thread Daniel Henrique Barboza
Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing when introducing cap-ccf-assist. These warning messages, although benign to the machine launch, can make users a bit confused. E.g: $ sudo ./ppc64-softmmu/q

Re: [RFC PATCH v2 01/20] migration/vmstate: Restrict vmstate_dummy to user-mode

2021-01-20 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > On 1/19/21 2:50 PM, Peter Maydell wrote: > > On Sun, 17 Jan 2021 at 19:24, Philippe Mathieu-Daudé > > wrote: > >> > >> 'vmstate_dummy' is special and only used for user-mode. Rename > >> it to something more specific. > >> It was introduced rest

Re: [PATCH 1/1] spapr_caps.c: disable KVM specific caps when running with TCG

2021-01-20 Thread Greg Kurz
On Wed, 20 Jan 2021 11:24:45 +1100 David Gibson wrote: > On Tue, Jan 19, 2021 at 05:58:24PM -0300, Daniel Henrique Barboza wrote: > > Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and > > cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing > > when introduci

Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-20 Thread Niklas Cassel
On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > refactors the zone write check function to return status codes in a > different order if there are multiple zone write violations that apply. >

Re: [PATCH v2 1/1] spapr_caps.c: check user input before warning about TCG only caps

2021-01-20 Thread Greg Kurz
On Wed, 20 Jan 2021 07:54:06 -0300 Daniel Henrique Barboza wrote: > Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and > cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing > when introducing cap-ccf-assist. > > These warning messages, although benign to the

[PATCH v4 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-20 Thread Mihai Carabas
Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c where the PCI specific routines reside and update the build system with the new files and config structure. Signed-off-by: Mihai Carabas Reviewed-by: Gerd Hoffmann Reviewed-by: Peter Maydell --- docs/specs/pci-ids.tx

[PATCH v4 3/4] pvpanic : update pvpanic spec document

2021-01-20 Thread Mihai Carabas
Add pvpanic PCI device support details in docs/specs/pvpanic.txt. Signed-off-by: Mihai Carabas Reviewed-by: Peter Maydell --- docs/specs/pvpanic.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index a90fbca..8

[PATCH v4] Add support for pvpanic pci device

2021-01-20 Thread Mihai Carabas
This patchset adds support for pvpanic pci device. v3: - patch 1: made pvpanic isa device available only for PC, compile pvpanic-test only when isa device is present - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE, PVPANIC_PCI_DEVICE, added VMSTATE_PCI_DEVICE, removed INTERFACE_

[PATCH v4 4/4] tests/qtest: add a test case for pvpanic-pci

2021-01-20 Thread Mihai Carabas
Add a test case for pvpanic-pci device. The scenario is the same as pvpanic ISA device, but is using the PCI bus. Signed-off-by: Mihai Carabas Acked-by: Thomas Huth Reviewed-by: Peter Maydell --- tests/qtest/meson.build| 1 + tests/qtest/pvpanic-pci-test.c | 94 +++

[PATCH v4 1/4] hw/misc/pvpanic: split-out generic and bus dependent code

2021-01-20 Thread Mihai Carabas
To ease the PCI device addition in next patches, split the code as follows: - generic code (read/write/setup) is being kept in pvpanic.c - ISA dependent code moved to pvpanic-isa.c Also, rename: - ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE. - TYPE_PVPANIC -> TYPE_PVPANIC_ISA. - MemoryRegion io -> mr

Re: [PATCH v4 11.5/23] iotests/129: Limit backup's max-chunk/max-workers

2021-01-20 Thread Vladimir Sementsov-Ogievskiy
20.01.2021 13:20, Max Reitz wrote: Right now, this does not change anything, because backup ignores max-chunk and max-workers. However, as soon as backup is switched over to block-copy for the background copying process, we will need it to keep 129 passing. Signed-off-by: Max Reitz --- Hi Vlad

Re: Fwd: VirtioSound device emulation implementation

2021-01-20 Thread Shreyansh Chouhan
I wasn't really able to clearly understand how I will use QEMU VIrtqueues exactly. So, I decided that I will start implementing the part that I already understand. I think once I have something implemented I'll have a better chance at understanding this. I am currently writing the boilerplate code

Re: [RFC PATCH V3 0/8] hw/block/nvme: support multi-path for ctrl/ns

2021-01-20 Thread Minwoo Im
On 21-01-20 08:52:14, Klaus Jensen wrote: > On Jan 20 09:44, Minwoo Im wrote: > > On 21-01-19 19:18:16, Klaus Jensen wrote: > > > On Jan 20 02:01, Minwoo Im wrote: > > > > Hello, > > > > > > > > This patch series is third one to support multi-controller and namespace > > > > sharing in multi-path.

Re: [PATCH 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-20 Thread Yan Vugenfirer
> On 15 Jan 2021, at 8:34 PM, Mihai Carabas wrote: > > Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c > where the PCI specific routines reside and update the build system with the > new > files and config structure. > > Signed-off-by: Mihai Carabas > --- > doc

Re: [RFC 0/5] pc: support user provided NIC naming/indexing

2021-01-20 Thread Igor Mammedov
On Sun, 17 Jan 2021 05:59:18 -0500 "Michael S. Tsirkin" wrote: > On Fri, Jan 15, 2021 at 02:59:02AM +0100, Igor Mammedov wrote: > > On Wed, 13 Jan 2021 07:09:56 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 22, 2020 at 06:39:29PM -0500, Igor Mammedov wrote: > > > > > > > > Se

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Markus Armbruster
John Snow writes: > Modify visit_module to pass the module itself instead of just its > name. This allows for future patches to centralize some > module-interrogation behavior within the QAPISchemaModule class itself, > cutting down on duplication between gen.py and schema.py. We've been tempted

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/19/21 6:54 PM, Laurent Vivier wrote: > From: Shu-Chun Weng > > IPV6_ADDR_PREFERENCES (RFC5014: Source address selection) was not supported. > > Signed-off-by: Shu-Chun Weng > Reviewed-by: Laurent Vivier > Message-Id: <20201218193213.3566856-4-...@google.com> > Signed-off-by: Laurent Vivie

Re: [PATCH v3] sphinx: adopt kernel readthedoc theme

2021-01-20 Thread Bin Meng
On Wed, Jan 20, 2021 at 6:26 PM wrote: > > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours > > The "rtd" theme from readthedocs

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Paolo Bonzini
On 20/01/21 09:03, Markus Armbruster wrote: The detour should be avoided, because QemuOpts should be avoided. Using the appropriate visitor, we get: char *optarg | | v = qobject_input_visitor_new_str(string, NULL, errp) | visit_type_q_obj_set

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Paolo Bonzini
On 20/01/21 09:42, Markus Armbruster wrote: The alternative is to *outlaw* parameters "help" and "?" in QemuOpts. I'd be cool with that. > My solution would be to deprecate the QMP "change vnc" command, and postpone switching -vnc to qemu_opts_parse_noisily to 6.2. QMP command 'change' was dep

Re: [PATCH 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-20 Thread Mihai Carabas
+device_class_set_props(dc, pvpanic_pci_properties); + +pc->realize = pvpanic_pci_realizefn; +pc->vendor_id = PCI_VENDOR_ID_REDHAT; +pc->device_id = PCI_DEVICE_ID_REDHAT_PVPANIC; Please fill out subsystem and subsystem vendor IDs as well: pc->subsystem_vendor_id pc->subsystem_i

How to run crypto benchmarks tests?

2021-01-20 Thread Philippe Mathieu-Daudé
Hi, Using the following "build tools and doc" config: ../configure --disable-system --disable-user ... TLS priority: "NORMAL" GNUTLS support: YES libgcrypt: NO nettle: YES

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/01/21 09:03, Markus Armbruster wrote: >> The detour should be avoided, because QemuOpts should be avoided. Using >> the appropriate visitor, we get: >> char *optarg >> | >> | v = qobject_input_visitor_new_str(string, NULL, errp)

[PATCH v5 4/4] tests/qtest: add a test case for pvpanic-pci

2021-01-20 Thread Mihai Carabas
Add a test case for pvpanic-pci device. The scenario is the same as pvpanic ISA device, but is using the PCI bus. Signed-off-by: Mihai Carabas Acked-by: Thomas Huth Reviewed-by: Peter Maydell --- tests/qtest/meson.build| 1 + tests/qtest/pvpanic-pci-test.c | 94 +++

[PATCH v5 3/4] pvpanic : update pvpanic spec document

2021-01-20 Thread Mihai Carabas
Add pvpanic PCI device support details in docs/specs/pvpanic.txt. Signed-off-by: Mihai Carabas Reviewed-by: Peter Maydell --- docs/specs/pvpanic.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index a90fbca..8

[PATCH v5 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-20 Thread Mihai Carabas
Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c where the PCI specific routines reside and update the build system with the new files and config structure. Signed-off-by: Mihai Carabas Reviewed-by: Gerd Hoffmann Reviewed-by: Peter Maydell --- docs/specs/pci-ids.tx

[PATCH v5] Add support for pvpanic pci device

2021-01-20 Thread Mihai Carabas
This patchset adds support for pvpanic pci device. v3: - patch 1: made pvpanic isa device available only for PC, compile pvpanic-test only when isa device is present - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE, PVPANIC_PCI_DEVICE, added VMSTATE_PCI_DEVICE, removed INTERFACE_

[PATCH v5 1/4] hw/misc/pvpanic: split-out generic and bus dependent code

2021-01-20 Thread Mihai Carabas
To ease the PCI device addition in next patches, split the code as follows: - generic code (read/write/setup) is being kept in pvpanic.c - ISA dependent code moved to pvpanic-isa.c Also, rename: - ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE. - TYPE_PVPANIC -> TYPE_PVPANIC_ISA. - MemoryRegion io -> mr

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/01/21 09:42, Markus Armbruster wrote: >> The alternative is to *outlaw* parameters "help" and "?" in QemuOpts. >> I'd be cool with that. > >>> My solution would be to deprecate the QMP "change vnc" command, and >>> postpone switching -vnc to qemu_opts_parse_noisily t

Re: How to run crypto benchmarks tests?

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 01:50:48PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > Using the following "build tools and doc" config: > > ../configure --disable-system --disable-user > ... > TLS priority: "NORMAL" >GNUTLS sup

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

2021-01-20 Thread Igor Mammedov
On Fri, 15 Jan 2021 10:20:23 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Thu, 7 Jan 2021 16:14:49 +0100 > > Vitaly Kuznetsov wrote: > > > >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > >> requires listing all currently supported enlightenmen

Re: [PATCH] machine: add missing doc for memory-backend option

2021-01-20 Thread Igor Mammedov
On Thu, 14 Jan 2021 20:38:01 +0100 Paolo Bonzini wrote: > On 11/01/21 23:27, Igor Mammedov wrote: > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > PS: > > While at it add a comment to x-use-canonical-path-for-ramblock-id, > > to make sure it won't go

Re: [PATCH v2 13/22] tcg/i386: Split out constraint sets to tcg-target-con-set.h

2021-01-20 Thread Peter Maydell
On Tue, 19 Jan 2021 at 23:48, Richard Henderson wrote: > > On 1/19/21 5:27 AM, Peter Maydell wrote: > > On Fri, 15 Jan 2021 at 21:20, Richard Henderson > > wrote: > >> > >> This exports the constraint sets from tcg_target_op_def to > >> a place we will be able to manipulate more in future. > >> >

Re: [PATCH 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-20 Thread Gerd Hoffmann
Hi, > > +pc->realize = pvpanic_pci_realizefn; > > +pc->vendor_id = PCI_VENDOR_ID_REDHAT; > > +pc->device_id = PCI_DEVICE_ID_REDHAT_PVPANIC; > > Please fill out subsystem and subsystem vendor IDs as well: > pc->subsystem_vendor_id > pc->subsystem_id Not needed, when left blank they

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Peter Maydell
On Wed, 20 Jan 2021 at 05:28, Alejandro Jimenez wrote: > On 1/19/2021 4:34 PM, Peter Maydell wrote: > > Test cases aren't very exciting, but was it really intentional > > to change the default behaviour? > My intention was to preserve the default behavior. Perhaps Paolo wanted > to reduce the numb

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Max Reitz
On 20.01.21 11:39, Max Reitz wrote: On 19.01.21 20:22, Vladimir Sementsov-Ogievskiy wrote: 19.01.2021 21:40, Max Reitz wrote: On 16.01.21 22:46, Vladimir Sementsov-Ogievskiy wrote: Hi Max! I applied my series onto yours 129-fixing and found, that 129 fails for backup. And setting small max-ch

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-20 Thread Igor Mammedov
On Fri, 15 Jan 2021 10:02:04 + Peter Maydell wrote: > On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote: > > > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > And document that x-use-canonical-path-for-ramblock-id, > > is considered to be stable to

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-20 Thread Alberto Garcia
On Mon 18 Jan 2021 11:22:49 AM CET, Vladimir Sementsov-Ogievskiy wrote: >> This is still an RFC but you can see the idea. > > Good idea and I glad to see that my patches help:) > > Hmm, still, removing a filter which want to unshare WRITE even when > doesn't have any parents will be a problem anywa

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 12:28:14AM -0500, Alejandro Jimenez wrote: > > > On 1/19/2021 4:34 PM, Peter Maydell wrote: > > On Tue, 15 Dec 2020 at 18:11, Paolo Bonzini wrote: > > > From: Alejandro Jimenez > > > > > > The current default action of pausing a guest after a panic event > > > is receiv

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-20 Thread Vladimir Sementsov-Ogievskiy
20.01.2021 16:51, Alberto Garcia wrote: On Mon 18 Jan 2021 11:22:49 AM CET, Vladimir Sementsov-Ogievskiy wrote: This is still an RFC but you can see the idea. Good idea and I glad to see that my patches help:) Hmm, still, removing a filter which want to unshare WRITE even when doesn't have an

Re: [PATCH v3 06/17] qapi: centralize is_[user|system|builtin]_module methods

2021-01-20 Thread Markus Armbruster
John Snow writes: > Define what a module is and define what kind of a module it is once and > for all, in one place. > > Signed-off-by: John Snow > --- > docs/sphinx/qapidoc.py | 2 +- > scripts/qapi/gen.py| 21 +++-- > scripts/qapi/schema.py | 28 ++

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Paolo Bonzini
On 19/01/21 22:34, Peter Maydell wrote: We used to default to 'pause' and now we default to 'poweroff'. We noticed this because it broke an in-flight test case for the pvpanic-pci device from Mihai (which was expecting to see the device in 'pause' state and found it was now in 'poweroff'). Test

Re: How to run crypto benchmarks tests?

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 2:06 PM, Daniel P. Berrangé wrote: > On Wed, Jan 20, 2021 at 01:50:48PM +0100, Philippe Mathieu-Daudé wrote: >> Hi, >> >> Using the following "build tools and doc" config: >> >> ../configure --disable-system --disable-user >> ... >> T

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Matthew Rosato
On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check.  Removing this fence, however, reveals additional deficiencies in the s390x

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Paolo Bonzini
On 20/01/21 13:59, Markus Armbruster wrote: Verbose please. Do you think we should delay the conversion of -M/-accel/-object to keyval until 6.2? I concurred with "it's up for discussion". I'm happy do discuss, of course. What are the boolean parameters, and is there *any* evidence of use

  1   2   3   4   >