Re: [PATCH v2] meson: fix ncurses detection on macOS

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 11:17 PM, Chris Hofstaedtler wrote: > Without this, meson fails with "curses package not usable" when using ncurses > 6.2. Apparently the wide functions (addwstr, etc) are hidden behind the extra > define, and meson does not define it at that detection stage. > > Regression from b01a4f

Re: [PATCH v3 4/8] hw/pci-host/bonito: Fixup pci.lomem mapping

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/24/20 4:17 AM, Jiaxun Yang wrote: > The original mapping had wrong base address. TBO this rational is a bit scarce ;) I sent a patch implementing the REMAP register: https://www.mail-archive.com/qemu-devel@nongnu.org/msg769751.html If this isn't enough with a Linux kernel because it expect

Re: [PATCH v2 3/3] sam460ex: Clean up irq mapping

2021-01-01 Thread Peter Maydell
On Thu, 31 Dec 2020 at 20:55, BALATON Zoltan wrote: > The SoC is called 460EX (despite having a PPC 440 core not 460 one) but I > think you've looked at the right data sheet and it's just a typo. I also > don't know how the board is wired so I think in this case I prefer > dropping this patch and

Re: [PULL 00/30] Block patches

2021-01-01 Thread Peter Maydell
On Fri, 18 Dec 2020 at 15:12, Max Reitz wrote: > > The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2020-12-17 > 18:53:36 +) > > are available in the Git repository

Re: [PATCH v3 4/8] hw/pci-host/bonito: Fixup pci.lomem mapping

2021-01-01 Thread Jiaxun Yang
在 2021/1/1 下午7:07, Philippe Mathieu-Daudé 写道: On 12/24/20 4:17 AM, Jiaxun Yang wrote: The original mapping had wrong base address. TBO this rational is a bit scarce ;) Yes. I was just trying to get Linux work as I was programing facing the kernel, not the hardware ;-( I asked Loongson guys

Re: [Qemu-devel] [PULL 0/1] RDMA queue

2021-01-01 Thread Peter Maydell
On Fri, 18 Dec 2020 at 19:00, Marcel Apfelbaum wrote: > > The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging > (2020-12-18 11:12:35 +) > > are available in the G

Re: [PATCH 01/25] esp: checkpatch fixes

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 52 ++- > 1 file changed, 31 insertions(+), 21 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 02/25] esp: add trace event when receiving a TI command

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > This enables us to determine whether the command being issued is for a DMA or > a > non-DMA transfer. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c| 1 + > hw/scsi/trace-events | 1 + > 2 files changed, 2 insertions(+) Reviewed

Re: [PATCH 03/25] esp: fix esp_reg_read() trace event

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > Move the trace event to the end of the function so that it correctly reports > the returned value if it doesn't come directly from the rregs array. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 18 -- > 1 file changed,

Re: [PATCH 04/25] esp: add PDMA trace events

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > This will become more useful later when trying to debug mixed FIFO and PDMA > requests. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c| 6 ++ > hw/scsi/trace-events | 4 > 2 files changed, 10 insertions(+) Reviewed-by: P

Re: [PATCH 06/25] esp: introduce esp_get_tc() and esp_set_tc()

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > This simplifies reading and writing the TC register value without having to > manually shift each individual 8-bit value. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 34 ++ > 1 file changed, 22 inserti

Re: [PULL 00/33] QAPI patches patches for 2020-12-19

2021-01-01 Thread Peter Maydell
On Sat, 19 Dec 2020 at 10:55, Markus Armbruster wrote: > > The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging > (2020-12-18 11:12:35 +) > > are available in the

Re: [PATCH 21/25] esp: rename get_cmd_cb() to esp_select()

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/30/20 4:37 PM, Mark Cave-Ayland wrote: > This better describes the purpose of the function. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PULL 00/55] Misc patches for 2020-12-21

2021-01-01 Thread Peter Maydell
On Mon, 21 Dec 2020 at 14:51, Paolo Bonzini wrote: > > The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging > (2020-12-18 11:12:35 +) > > are available in the Git

[Bug 1909823] [NEW] RDPMC check on PCE is backwards

2021-01-01 Thread Bruce Merry
Public bug reported: At [this line](https://github.com/qemu/qemu/blob/75ee62ac606bfc9eb59310b9446df3434bf6e8c2/target/i386/tcg/misc_helper.c#L225) the check on CR4_PCE_MASK is backwards: it's raising an exception if the flag is set (and CPL != 0) rather than if the flag is clear. It's low priorit

Re: [PATCH v3 5/8] hw/mips/fuloong2e: Remove unused env entry

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/24/20 4:17 AM, Jiaxun Yang wrote: > modetty is not handled by kernel and the parameter > here seems unreasonable. > > Signed-off-by: Jiaxun Yang > --- > v3: Bring busclock back > --- > hw/mips/fuloong2e.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/mips/fuloong2e.c b/hw/m

Re: [PULL 0/5] fuzzer and gitlab-CI patches

2021-01-01 Thread Peter Maydell
On Mon, 21 Dec 2020 at 13:45, Thomas Huth wrote: > > Hi! > > The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' > into staging (2020-12-17 18:53:36 +) > > are available in the Gi

Re: [PULL 00/14] s390x update

2021-01-01 Thread Peter Maydell
On Tue, 22 Dec 2020 at 10:45, Cornelia Huck wrote: > > The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging > (2020-12-18 11:12:35 +) > > are available in the Git

Re: [PULL 00/55] Misc patches for 2020-12-21

2021-01-01 Thread Paolo Bonzini
Il ven 1 gen 2021, 18:05 Peter Maydell ha scritto: > (why does it print the same failure three times rather than > stopping after the first one?) > It probably has something to do with how make processes rules to rebuild makefiles. I will remove the patch that moves xgettext from boolean to fea

Re: [PATCH v2 0/4] clock: Get rid of clock_get_ns()

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/15/20 4:09 PM, Peter Maydell wrote: > This patchseries makes some changes to the clock API: > * Remove clock_get_ns() > * Add clock_ticks_to_ns() to return number of nanoseconds >it will take the clock to tick N times > * clock_display_freq() to return prettily-formatted string >fo

Re: [PATCH v2 3/8] hw/mips: Use address translation helper to handle ENVP_ADDR

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/15/20 7:41 AM, Jiaxun Yang wrote: > It will signed extend vaddr properly. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/fuloong2e.c | 24 +- > hw/mips/malta.c | 62 ++--- > 2 files changed, 43 insertions(+), 43 deletions(-) Revi

Re: [PATCH v2 2/8] hw/mips/malta: Use address translation helper to calculate bootloader_run_addr

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/15/20 7:41 AM, Jiaxun Yang wrote: > So it will sign extend adresses properly. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/malta.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 6/8] target/mips/addr: Add translation helpers for KSEG1

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/15/20 7:45 AM, Jiaxun Yang wrote: > It's useful for bootloader to do IO opreations. > > Signed-off-by: Jiaxun Yang > --- > target/mips/addr.c | 10 ++ > target/mips/cpu.h | 2 ++ > 2 files changed, 12 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH V19 3/5] hw/mips: Add Loongson-3 boot parameter helpers

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/21/20 12:05 PM, Huacai Chen wrote: > Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a > UEFI-like interface for BIOS-Kernel boot parameters) helpers first. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > Signed-off

Re: [PATCH V19 4/5] hw/mips: Add Loongson-3 machine support

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/21/20 12:05 PM, Huacai Chen wrote: > Add Loongson-3 based machine support, it use liointc as the interrupt > controler and use GPEX as the pci controller. Currently it can work with > both TCG and KVM. > > As the machine model is not based on any exiting physical hardware, the > name of the

Re: [PATCH v3 5/8] hw/mips/fuloong2e: Remove unused env entry

2021-01-01 Thread Philippe Mathieu-Daudé
On 1/1/21 7:05 PM, Philippe Mathieu-Daudé wrote: > On 12/24/20 4:17 AM, Jiaxun Yang wrote: >> modetty is not handled by kernel and the parameter >> here seems unreasonable. >> >> Signed-off-by: Jiaxun Yang >> --- >> v3: Bring busclock back >> --- >> hw/mips/fuloong2e.c | 2 -- >> 1 file changed,

Re: [PATCH 04/12] vt82c686: Remove vt82c686b_[am]c97_init() functions

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/27/20 2:10 AM, BALATON Zoltan via wrote: > These are legacy init functions that are just equivalent to directly > calling pci_create_simple so do that instead. Also rename objects to > lower case via-ac97 and via-mc97 matching naming of other devices. > > Signed-off-by: BALATON Zoltan > ---

Re: [PATCH v2 04/10] vt82c686: Remove vt82c686b_[am]c97_init() functions

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/28/20 3:08 AM, BALATON Zoltan via wrote: > These are legacy init functions that are just equivalent to directly > calling pci_create_simple so do that instead. Also rename objects to > lower case via-ac97 and via-mc97 matching naming of other devices. > > Signed-off-by: BALATON Zoltan > ---

Re: [PATCH v2 06/10] audio/via-ac97: Simplify code and set user_creatable to false

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/28/20 3:08 AM, BALATON Zoltan via wrote: > Remove some unneded, empty code and set user_creatable to false > (besides being not implemented yet, so does nothing anyway) it's also > normally part of VIA south bridge chips so no need to confuse users > showing them these devices. > > Signed-of

Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/28/20 3:08 AM, BALATON Zoltan via wrote: > Drop DPRINTF and use trace functions instead. Two debug messages about > unimplemented registers could be converted to qemu_log_mask() but in > reality all registers are currently unimplemented (we just store and > return values of writable regs but

Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread BALATON Zoltan via
On Fri, 1 Jan 2021, Philippe Mathieu-Daudé wrote: On 12/28/20 3:08 AM, BALATON Zoltan via wrote: Drop DPRINTF and use trace functions instead. Two debug messages about unimplemented registers could be converted to qemu_log_mask() but in reality all registers are currently unimplemented (we just

Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread BALATON Zoltan via
On Fri, 1 Jan 2021, Philippe Mathieu-Daudé wrote: On 12/28/20 3:08 AM, BALATON Zoltan via wrote: Drop DPRINTF and use trace functions instead. Two debug messages about unimplemented registers could be converted to qemu_log_mask() but in reality all registers are currently unimplemented (we just

[RFC PATCH 0/5] hw/mips: Fix Fuloong2E to boot Linux guest again

2021-01-01 Thread Philippe Mathieu-Daudé
We closed 2020 with few discussions about the Fuloong 2E board (see [1] and [2]). This series collect the minimum set of patch to have the machine booting Linux guest again, including integration tests. This is sent as RFC because Mark raised some issues in (see [3] and previous in this thread) a

[RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-01 Thread Philippe Mathieu-Daudé
Per the datasheet (Chapter 5.7.1. "PCI address regions"), the PCIMAP register: Map the 64Mbyte regions marked "PCI_Lo" in the CPU's memory map, each of which can be assigned to any 64 Mbyte-aligned region of PCI memory. The address appearing on the PCI bus consists of the low 26 bits of th

[RFC PATCH 2/5] via-ide: Fix fuloong2e support

2021-01-01 Thread Philippe Mathieu-Daudé
From: Guenter Roeck The IDE legacy mode emulation has been removed in commit 4ea98d317eb ("ide/via: Implement and use native PCI IDE mode") but some Linux kernels (probably including def_config) require legacy mode on the Fuloong2e so only emulating native mode did not turn out feasible. Add prop

[RFC PATCH 1/5] ide: Make room for flags in PCIIDEState and add one for legacy mode

2021-01-01 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for further flags if needed in the future. This patch changes the "secondary" field to "flags" and

[RFC PATCH 4/5] tests/acceptance: Test boot_linux_console for fuloong2e

2021-01-01 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang The kernel comes from debian archive so it's trusted. Signed-off-by: Jiaxun Yang Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Reviewed-by: Huacai Chen Message-Id: <20201224031750.52146-9-jiaxun.y...@flygoat.com> Signed-off-by: Philippe Mathieu-Daud

[RFC PATCH 5/5] tests/integration: Test Fuloong2E IDE drive, run userspace commands

2021-01-01 Thread Philippe Mathieu-Daudé
Boot rootfs build by Guenter Roeck [*]. Full test output: $ avocado --show=app,console run -t machine:fuloong2e tests/acceptance/ Fetching asset from tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_fuloong2e Fetching asset from tests/acceptance/boot_linux_console.py:

Re: [PATCH v2 1/8] hw/mips: Make bootloader addresses unsgined

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/15/20 7:41 AM, Jiaxun Yang wrote: > Address should be unsigned anyway, otherwise it may carry > calculations wrongly. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/fuloong2e.c | 12 ++-- > hw/mips/malta.c | 22 +++--- > 2 files changed, 17 insertions(+), 17 del

Re: [PATCH v2 6/8] target/mips/addr: Add translation helpers for KSEG1

2021-01-01 Thread Philippe Mathieu-Daudé
On 1/1/21 9:42 PM, Philippe Mathieu-Daudé wrote: > On 12/15/20 7:45 AM, Jiaxun Yang wrote: >> It's useful for bootloader to do IO opreations. >> >> Signed-off-by: Jiaxun Yang >> --- >> target/mips/addr.c | 10 ++ >> target/mips/cpu.h | 2 ++ >> 2 files changed, 12 insertions(+) > > Rev

Re: [PATCH v2 3/8] hw/mips: Use address translation helper to handle ENVP_ADDR

2021-01-01 Thread Philippe Mathieu-Daudé
On 1/1/21 9:38 PM, Philippe Mathieu-Daudé wrote: > On 12/15/20 7:41 AM, Jiaxun Yang wrote: >> It will signed extend vaddr properly. >> >> Signed-off-by: Jiaxun Yang >> --- >> hw/mips/fuloong2e.c | 24 +- >> hw/mips/malta.c | 62 ++--- >>

Re: [RFC PATCH 3/5] hw/pci-host/bonito: Remap PCI "lo" regions when PCIMAP reg is modified

2021-01-01 Thread Peter Maydell
On Fri, 1 Jan 2021 at 23:12, Philippe Mathieu-Daudé wrote: > > Per the datasheet (Chapter 5.7.1. "PCI address regions"), > the PCIMAP register: > > Map the 64Mbyte regions marked "PCI_Lo" in the CPU's memory map, > each of which can be assigned to any 64 Mbyte-aligned region of > PCI memory.

Re: [RFC PATCH 0/5] hw/mips: Fix Fuloong2E to boot Linux guest again

2021-01-01 Thread BALATON Zoltan via
On Sat, 2 Jan 2021, Philippe Mathieu-Daudé wrote: We closed 2020 with few discussions about the Fuloong 2E board (see [1] and [2]). This series collect the minimum set of patch to have the machine booting Linux guest again, including integration tests. This is sent as RFC because Mark raised so