On 12/21/20 12:05 PM, Huacai Chen wrote: > Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a > UEFI-like interface for BIOS-Kernel boot parameters) helpers first. > > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Signed-off-by: Huacai Chen <chenhua...@kernel.org> > Co-developed-by: Jiaxun Yang <jiaxun.y...@flygoat.com> > Signed-off-by: Jiaxun Yang <jiaxun.y...@flygoat.com> > --- > MAINTAINERS | 2 + > hw/mips/loongson3_bootp.c | 151 ++++++++++++++++++++++++ > hw/mips/loongson3_bootp.h | 241 ++++++++++++++++++++++++++++++++++++++ > hw/mips/meson.build | 1 + > 4 files changed, 395 insertions(+) > create mode 100644 hw/mips/loongson3_bootp.c > create mode 100644 hw/mips/loongson3_bootp.h ...
> +struct MemmapEntry { > + hwaddr base; > + hwaddr size; > +}; > + > +extern const struct MemmapEntry virt_memmap[]; I'd rather avoid this extern (pass MemmapEntry as argument?). Anyhow, not a big deal ;) Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>